mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-18 06:04:33 +01:00
Stop giving bug reports a special rule in gstack's router (GST-2873) (#4442)
gstack's router no longer gives bug reports a special check-the-cause, fix-it-test-first rule, and its description no longer lists debugging, so the model fixes a bug the way it would without gstack. This keeps gstack to the parts that measurably help, and on 26 hard real bugs the rule gave no clear gain. Nothing to do. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Review-Finding: p1/red-team#1 reader=red-team
This commit is contained in:
1 parent
b79843c5d7
commit
f000b6e0e3
19 files changed
+25
-368
No files matched your search
@@ -439,7 +439,6 @@
|
||||
"test/exit-propagation.test.ts": 489,
|
||||
"test/extension-pty-inject-invariant.test.ts": 52,
|
||||
"test/external-host-carve.test.ts": 7522,
|
||||
"test/failure-routing-arm.test.ts": 2290,
|
||||
"test/flake-ledger.test.ts": 127,
|
||||
"test/free-home-guard.test.ts": 71,
|
||||
"test/free-seed-ratchet.test.ts": 550,
|
||||
|
||||
@@ -704,7 +704,6 @@
|
||||
"test/extension-pty-inject-invariant.test.ts": 15,
|
||||
"test/external-host-carve.test.ts": 2750,
|
||||
"test/factory-scorecard.test.ts": 369,
|
||||
"test/failure-routing-arm.test.ts": 217,
|
||||
"test/flake-ledger.test.ts": 30,
|
||||
"test/flaky-run.test.ts": 688,
|
||||
"test/founder-resources-optout.test.ts": 190,
|
||||
|
||||
@@ -1,13 +1,6 @@
|
||||
|
||||
import { FREE_TEXT_WRITE_RULE, freeTextFileBash, freeTextFileUse } from '../free-text-file';
|
||||
|
||||
export function generateFailureRouting(): string {
|
||||
return `**Failures: check the cause, then fix it test-first.** A failing test, error or stack trace shows where a failure surfaces, not its root cause.
|
||||
|
||||
- **Cause supplied** (the user names a specific cause and a narrow fix): make one read-only check of the evidence it rests on, such as the named file, test or log. If that confirms the cause, make the fix and run the focused test that covers it. If it does not, leave the suggested fix alone: reproduce the failure with a focused failing test, trace it to the root cause, fix that and rerun the test.
|
||||
- **Cause unknown:** make one read-only triage pass over the supplied evidence and the directly implicated test and code. Do not reproduce, test hypotheses or search wider. If that pass establishes the root cause and a narrow fix, make the fix and run the focused test that covers it. If the cause or scope is still unclear, write or run a focused test that fails on the bug before any edit, trace the failure to its root cause, fix that and rerun the test. If the intended behavior is unclear, ask the user.`;
|
||||
}
|
||||
|
||||
export function generateTestFailureTriage(): string {
|
||||
return `## Test Failure Ownership Triage
|
||||
|
||||
|
||||
Reference in new issue
Block a user