fix(review): define what a Step 5c Skip option says

Step 5c named "B) Skip" without saying what its description may claim. Two
CI captures (path-eligibility on 131d43be, index-flags on 4643cb85) offered a
Skip whose description added effects beyond declining: "The extraction can be
applied in a later editing review pass" and "replacing the invalidated prior
Skip". Those read as change commitments, so the no-change actor refused both.
Step 5c now says to describe Skip only as no code/index change with the Skip
recorded; adjacent lines are compacted so the review parity caps hold
unchanged. Both exact packets are kept as a free regression: still refused,
and accepted once Skip follows the rule. The actor's classifier is unchanged.
This commit is contained in:
garrytan committed 2026-09-30 19:36:02 +00:00
1 parent cc044e5f89
commit f02636f05e
4 files changed
+86 -9

No files matched your search

+4 -4
View File
@@ -965,13 +965,13 @@ Retain the completed action in the invocation action list before starting any re
### Step 5c: Batch-ask about ASK items
If there are ASK items remaining, present them in ONE AskUserQuestion:
Present remaining ASK items in ONE AskUserQuestion:
- List each item with a number, the severity label (or `[ADVISORY]` for optional advice), the problem, and a recommended fix
- For each item, provide options: A) Fix as recommended, B) Skip
- Number each item with its severity label (or `[ADVISORY]` for optional advice), problem and recommended fix
- Options per item: A) Fix as recommended, B) Skip (describe only as: no code/index change; Skip recorded)
- Include an overall RECOMMENDATION
If 3 or fewer ASK items, you may use individual AskUserQuestion calls instead of batching.
With 3 or fewer ASK items, individual AskUserQuestion calls are fine.
Retain each explicit Skip choice and its finding metadata in the invocation action list. Do not record an unanswered question as skipped or ask again about a decision already revalidated in this invocation.
### Step 5d: Apply user-approved fixes
+4 -4
View File
@@ -284,13 +284,13 @@ Retain the completed action in the invocation action list before starting any re
### Step 5c: Batch-ask about ASK items
If there are ASK items remaining, present them in ONE AskUserQuestion:
Present remaining ASK items in ONE AskUserQuestion:
- List each item with a number, the severity label (or `[ADVISORY]` for optional advice), the problem, and a recommended fix
- For each item, provide options: A) Fix as recommended, B) Skip
- Number each item with its severity label (or `[ADVISORY]` for optional advice), problem and recommended fix
- Options per item: A) Fix as recommended, B) Skip (describe only as: no code/index change; Skip recorded)
- Include an overall RECOMMENDATION
If 3 or fewer ASK items, you may use individual AskUserQuestion calls instead of batching.
With 3 or fewer ASK items, individual AskUserQuestion calls are fine.
Retain each explicit Skip choice and its finding metadata in the invocation action list. Do not record an unanswered question as skipped or ask again about a decision already revalidated in this invocation.
### Step 5d: Apply user-approved fixes