From f0f2838a77462293f704e5cec098f39118b6f95b Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sun, 16 Aug 2026 11:03:32 -0700 Subject: [PATCH] fix(setup): install office-hours into the external-host runtime roots MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #2449. plan-eng-review's inline office-hours step reads $GSTACK_ROOT/office-hours/SKILL.md, but the codex/factory/opencode runtime roots never installed it — the documented path pointed at nothing on every external-host install (Codex on Windows was the reported repro). Each runtime-root creator now links its host-rendered gstack-office-hours SKILL.md at office-hours/SKILL.md. Co-Authored-By: Claude Fable 5 --- setup | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/setup b/setup index 1a59f30b0..c692549f0 100755 --- a/setup +++ b/setup @@ -1090,6 +1090,13 @@ create_codex_runtime_root() { if [ -f "$agents_dir/gstack-upgrade/SKILL.md" ]; then _link_or_copy "$agents_dir/gstack-upgrade/SKILL.md" "$codex_gstack/gstack-upgrade/SKILL.md" fi + # plan-eng-review's inline office-hours step reads + # $GSTACK_ROOT/office-hours/SKILL.md (#2449) — install the codex-rendered + # variant there so the documented path exists. + if [ -f "${agents_dir}/gstack-office-hours/SKILL.md" ]; then + mkdir -p "${codex_gstack}/office-hours" + _link_or_copy "${agents_dir}/gstack-office-hours/SKILL.md" "${codex_gstack}/office-hours/SKILL.md" + fi # Review runtime assets (individual files, NOT the whole review/ dir which has SKILL.md) for f in checklist.md design-checklist.md greptile-triage.md TODOS-format.md; do if [ -f "$gstack_dir/review/$f" ]; then @@ -1138,6 +1145,13 @@ create_factory_runtime_root() { if [ -f "$factory_dir/gstack-upgrade/SKILL.md" ]; then _link_or_copy "$factory_dir/gstack-upgrade/SKILL.md" "$factory_gstack/gstack-upgrade/SKILL.md" fi + # plan-eng-review's inline office-hours step reads + # $GSTACK_ROOT/office-hours/SKILL.md (#2449) — install the factory-rendered + # variant there so the documented path exists. + if [ -f "${factory_dir}/gstack-office-hours/SKILL.md" ]; then + mkdir -p "${factory_gstack}/office-hours" + _link_or_copy "${factory_dir}/gstack-office-hours/SKILL.md" "${factory_gstack}/office-hours/SKILL.md" + fi for f in checklist.md design-checklist.md greptile-triage.md TODOS-format.md; do if [ -f "$gstack_dir/review/$f" ]; then _link_or_copy "$gstack_dir/review/$f" "$factory_gstack/review/$f" @@ -1187,6 +1201,13 @@ create_opencode_runtime_root() { if [ -f "$opencode_dir/gstack-upgrade/SKILL.md" ]; then _link_or_copy "$opencode_dir/gstack-upgrade/SKILL.md" "$opencode_gstack/gstack-upgrade/SKILL.md" fi + # plan-eng-review's inline office-hours step reads + # $GSTACK_ROOT/office-hours/SKILL.md (#2449) — install the opencode-rendered + # variant there so the documented path exists. + if [ -f "${opencode_dir}/gstack-office-hours/SKILL.md" ]; then + mkdir -p "${opencode_gstack}/office-hours" + _link_or_copy "${opencode_dir}/gstack-office-hours/SKILL.md" "${opencode_gstack}/office-hours/SKILL.md" + fi for f in checklist.md design-checklist.md greptile-triage.md TODOS-format.md; do if [ -f "$gstack_dir/review/$f" ]; then _link_or_copy "$gstack_dir/review/$f" "$opencode_gstack/review/$f"