CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-06-09 19:43:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: isolate E2E tests with GSTACK_STATE_DIR

Browse Source 
Sets GSTACK_STATE_DIR to a temp directory at module level, so all
E2E skill runs write artifacts to the temp dir instead of the real
~/.gstack/projects/. Prevents E2E garbage from accumulating.

The plan-eng-review artifact test now uses the isolated state dir
instead of hardcoding ~/.gstack/projects/test-project.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-18 23:51:15 -07:00
parent 624e4f234a
commit f29232277a
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/skill-e2e.test.ts
+18 -12
View File
@@ -13,6 +13,12 @@ import * as os from 'os';
const ROOT = path.resolve(import.meta.dir, '..'); const ROOT = path.resolve(import.meta.dir, '..');
// Isolate E2E tests from real ~/.gstack/ — all skill artifact writes go to a temp dir.
// gstack-slug reads GSTACK_STATE_DIR and lib/util.ts reads process.env.GSTACK_STATE_DIR.
const e2eStateDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-e2e-state-'));
const originalStateDir = process.env.GSTACK_STATE_DIR;
process.env.GSTACK_STATE_DIR = e2eStateDir;
// Skip unless EVALS=1. Session runner strips CLAUDE* env vars to avoid nested session issues. // Skip unless EVALS=1. Session runner strips CLAUDE* env vars to avoid nested session issues.
// //
// BLAME PROTOCOL: When an eval fails, do NOT claim "pre-existing" or "not related // BLAME PROTOCOL: When an eval fails, do NOT claim "pre-existing" or "not related
@@ -1511,22 +1517,14 @@ export function main() { return Dashboard(); }
// Set up remote-slug shim and browse shims (plan-eng-review uses remote-slug for artifact path) // Set up remote-slug shim and browse shims (plan-eng-review uses remote-slug for artifact path)
setupBrowseShims(planDir); setupBrowseShims(planDir);
// Create project directory for artifacts // Create project directory for artifacts (uses GSTACK_STATE_DIR isolation)
projectDir = path.join(os.homedir(), '.gstack', 'projects', 'test-project'); projectDir = path.join(e2eStateDir, 'projects', 'test-project');
fs.mkdirSync(projectDir, { recursive: true }); fs.mkdirSync(projectDir, { recursive: true });
}); });
afterAll(() => { afterAll(() => {
try { fs.rmSync(planDir, { recursive: true, force: true }); } catch {} try { fs.rmSync(planDir, { recursive: true, force: true }); } catch {}
// Clean up test-plan artifacts (but not the project dir itself) // Project dir is inside e2eStateDir — cleaned up by module-level afterAll
try {
const files = fs.readdirSync(projectDir);
for (const f of files) {
if (f.includes('test-plan')) {
fs.unlinkSync(path.join(projectDir, f));
}
}
} catch {}
}); });
test('/plan-eng-review writes test-plan artifact to ~/.gstack/projects/', async () => { test('/plan-eng-review writes test-plan artifact to ~/.gstack/projects/', async () => {
@@ -2842,7 +2840,7 @@ Output the diagram directly.`,
}, 180_000); }, 180_000);
}); });
// Module-level afterAll — finalize eval collector after all tests complete // Module-level afterAll — finalize eval collector and clean up E2E isolation
afterAll(async () => { afterAll(async () => {
if (evalCollector) { if (evalCollector) {
try { try {
@@ -2851,4 +2849,12 @@ afterAll(async () => {
console.error('Failed to save eval results:', err); console.error('Failed to save eval results:', err);
} }
} }
// Restore original GSTACK_STATE_DIR and clean up temp dir
if (originalStateDir) {
process.env.GSTACK_STATE_DIR = originalStateDir;
} else {
delete process.env.GSTACK_STATE_DIR;
}
try { fs.rmSync(e2eStateDir, { recursive: true, force: true }); } catch {}
}); });