Outside reviews that mention a problem no longer pass as clean (#4136)

* test(outside-review): failing-first cases for false-clean conclusions (GST-1808) and the preflight state-root leak (GST-1809)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test(outside-voice-preflight): spawn fixtures on an isolated state root (GST-1809)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test(outside-review): fixtures that read clean only through the lax scope and colon rules name the whole change (GST-1808)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix(outside-review): read the no-findings conclusion as one closed sentence (GST-1808)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test(outside-review): failing-first: a whole-change scope may name the branch or its base (GST-1808 review p1)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix(outside-review): a whole-change scope may name the branch or the base it is diffed against (GST-1808 review p1)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test(outside-review): failing-first: a base-name tail never accepts another origin ref (GST-1808 review p2)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix(outside-review): the base tail names only main or master, with or without origin/ (GST-1808 review p2)

Review-Finding: p2/red-team#1 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* docs(changelog): scope the toward-clean claim to captured fixture replies (GST-1808 review v2)

Review-Finding: v2/adversarial-native#3 reader=adversarial-native
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* docs(changelog): name the fragment after the branch and end the colon sentence (GST-1808, /ship Step 13)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
Garry Tanandcapy-ai[bot] authored and GitHub committed 2026-11-07 19:49:19 +00:00
1 parent 1a29fbc344
commit f97c0dde02
10 files changed
+145 -64

No files matched your search

+20 -16
View File
@@ -198,22 +198,26 @@ the readiness dashboard and the PR body, and never count it as a pass.
`gstack-outside-voice run`); the verdict still comes from the rules above.
- **No findings.** A review with no tag and no label is `clean` only when its
conclusion says so: the last sentence (or its last ", and" clause), or the
`because` clause of its `Recommendation:` line, opens with `NO_FINDINGS`,
"No issues found", "I found no actionable regressions", "I did not find
any bugs" or "The changes introduce no regressions", with no "but",
"however", "while", "whereas", "except", "other than" or "elsewhere". Closing sentences that
only report passing checks ("Tests, lint, and build all pass.") sign the
review off and are skipped, so the sentence before them is the conclusion;
a check sentence that quotes code, fails, is cut off, continues a wrapped
line, follows a colon or is the reply's only sentence is never skipped.
When other prose comes first, anything after that statement except a
predicate ("were found", "is evident") or a colon explanation must scope it
to the change as a whole ("in this change", "in the staged changes"); "No
issues in the parser." does not conclude the review, and neither does a
clause joined after that scope ("No issues in the diff, so it is safe.").
A statement with the change as its subject ("The changes introduce no
regressions") is held to this scope rule even as the reply's only sentence. A "no issues" phrase
anywhere else in the reply does not count. Otherwise the review is
`because` clause of its `Recommendation:` line, is a complete no-findings
sentence and nothing more. It may open with "Overall," or "After reviewing
the patch,", then states `NO_FINDINGS`, "No issues found", "I found no
actionable regressions", "I did not find any bugs" or "The changes introduce
no regressions", then may add "were found" or "is evident", then may name the
whole change ("in this change", "in the diff", "in the changed files", "in
the staged, unstaged, or untracked changes", "in the change as a whole",
"in the changes on this branch", "in the diff against main"), and ends
there with at most one `.`, `!` or `;`. Anything else makes the
review `unverified`: a clause after the scope ("No issues in the diff, so
it is safe.", "No issues in the diff: the fallback swallows ENOENT."), an
exception ("with the exception of", "save for"), a question ("No issues in
the diff?"), or a scope that names part of the change ("No issues in the
parser.", "in changed.ts"), whether it is the reply's only sentence or not.
Closing sentences that only report passing checks ("Tests, lint, and build
all pass.") sign the review off and are skipped, so the sentence before
them is the conclusion; a check sentence that quotes code, fails, is cut
off, continues a wrapped line, follows a colon or is the reply's only
sentence is never skipped. A "no issues" phrase anywhere else in the reply
does not count. Otherwise the review is
`unverified` (see below), never `clean`. A `/codex` consult
answer with no severity labels at all is not a review summary and stays
`clean`.