From f9c416fb494b5d193bab05c26bbba808343073ad Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 3 Oct 2026 22:55:25 +0000 Subject: [PATCH] Regenerate generated output after the outside-voice prelude repair --- autoplan/SKILL.md | 1 + autoplan/sections/ceo-phase.md | 1 + autoplan/sections/design-phase.md | 1 + autoplan/sections/dx-phase.md | 1 + autoplan/sections/eng-phase.md | 1 + design-consultation/sections/proposal-and-preview.md | 2 ++ design-review/SKILL.md | 2 ++ document-release/sections/release-body.md | 3 +++ office-hours/SKILL.md | 4 ++++ plan-ceo-review/sections/review-sections.md | 3 +++ plan-design-review/SKILL.md | 2 ++ plan-devex-review/sections/review-sections.md | 3 +++ plan-eng-review/sections/review-sections.md | 3 +++ review/sections/adversarial.md | 3 +++ ship/sections/adversarial.md | 3 +++ ship/sections/review-army.md | 2 ++ spec/sections/gate-and-file.md | 2 ++ test/fixtures/context-budget.json | 4 ++-- 18 files changed, 39 insertions(+), 2 deletions(-) diff --git a/autoplan/SKILL.md b/autoplan/SKILL.md index b3199199e..b855b9b9b 100644 --- a/autoplan/SKILL.md +++ b/autoplan/SKILL.md @@ -775,6 +775,7 @@ Review skills will load at each phase entry. Starting full review pipeline with ## Phase 0.5: Outside reviewer preflight ```bash + # Codex preflight: one block (functions sourced here don't persist to later blocks). _TEL=$(~/.claude/skills/gstack/bin/gstack-config get telemetry 2>/dev/null || echo off) _CODEX_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || echo enabled) diff --git a/autoplan/sections/ceo-phase.md b/autoplan/sections/ceo-phase.md index 196b456ed..547f79a9c 100644 --- a/autoplan/sections/ceo-phase.md +++ b/autoplan/sections/ceo-phase.md @@ -104,6 +104,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/autoplan/sections/design-phase.md b/autoplan/sections/design-phase.md index b779ce5f9..011160940 100644 --- a/autoplan/sections/design-phase.md +++ b/autoplan/sections/design-phase.md @@ -63,6 +63,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/autoplan/sections/dx-phase.md b/autoplan/sections/dx-phase.md index a22437f36..dc6074b12 100644 --- a/autoplan/sections/dx-phase.md +++ b/autoplan/sections/dx-phase.md @@ -67,6 +67,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/autoplan/sections/eng-phase.md b/autoplan/sections/eng-phase.md index 89f9a4a13..26cc37953 100644 --- a/autoplan/sections/eng-phase.md +++ b/autoplan/sections/eng-phase.md @@ -56,6 +56,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/design-consultation/sections/proposal-and-preview.md b/design-consultation/sections/proposal-and-preview.md index 275aecddf..8c9b95628 100644 --- a/design-consultation/sections/proposal-and-preview.md +++ b/design-consultation/sections/proposal-and-preview.md @@ -118,6 +118,7 @@ Write the product brief to that path; remember its absolute path across fresh Ba **Check Codex availability:** ```bash + if ( # GSTACK_ACTIVE_HOST names the harness, never the model. if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK_ACTIVE_HOST:-}" = codex ]; }; then echo 'Codex outside review unavailable: harness mismatch; no outside process started. Missing coverage.' >&2 @@ -170,6 +171,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/design-review/SKILL.md b/design-review/SKILL.md index f2e74b972..657a80b71 100644 --- a/design-review/SKILL.md +++ b/design-review/SKILL.md @@ -1583,6 +1583,7 @@ $GSTACK_STATE_ROOT/projects/$SLUG/designs/design-audit-{YYYYMMDD}/ **Check Codex availability:** ```bash + _OUTSIDE_CFG=enabled # This caller has its own opt-in/skip control. if [ "$_OUTSIDE_CFG" = disabled ]; then echo 'CODEX_MODE: disabled' @@ -1657,6 +1658,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/document-release/sections/release-body.md b/document-release/sections/release-body.md index 878229349..95c86db3c 100644 --- a/document-release/sections/release-body.md +++ b/document-release/sections/release-body.md @@ -221,6 +221,7 @@ health summary and continue to Step 9. Ship-owned children already stopped at St **Preflight — decide whether and how the doc review runs:** ```bash + # Codex preflight: one block (functions sourced here don't persist to later blocks). _TEL=$(~/.claude/skills/gstack/bin/gstack-config get telemetry 2>/dev/null || echo off) _CODEX_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || echo enabled) @@ -274,6 +275,7 @@ shell and re-reads the control; enabled workflows never append a disabled record If logging fails, report the persistence failure and retain the disabled opt-out. ```bash + _DISABLED_REVIEW_MODE=$("$HOME/.claude/skills/gstack/bin/gstack-config" get codex_reviews 2>/dev/null) || { echo 'Cannot read codex_reviews; disabled outside coverage was not recorded.' >&2 exit 1 @@ -328,6 +330,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/office-hours/SKILL.md b/office-hours/SKILL.md index e82ced820..9ecf89163 100644 --- a/office-hours/SKILL.md +++ b/office-hours/SKILL.md @@ -755,6 +755,7 @@ Use AskUserQuestion to confirm. If the user disagrees with a premise, revise und **Provider preflight:** ```bash + _OUTSIDE_CFG=enabled # This caller has its own opt-in/skip control. if [ "$_OUTSIDE_CFG" = disabled ]; then echo 'CODEX_MODE: disabled' @@ -824,6 +825,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT @@ -1107,6 +1109,7 @@ The screenshot file at `/sketch.png` (name the full path in the doc) After the wireframe is approved, offer outside design perspectives: ```bash + _OUTSIDE_CFG=enabled # This caller has its own opt-in/skip control. if [ "$_OUTSIDE_CFG" = disabled ]; then echo 'CODEX_MODE: disabled' @@ -1153,6 +1156,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/plan-ceo-review/sections/review-sections.md b/plan-ceo-review/sections/review-sections.md index 0e8129c39..f7aa4eb8f 100644 --- a/plan-ceo-review/sections/review-sections.md +++ b/plan-ceo-review/sections/review-sections.md @@ -356,6 +356,7 @@ review. The user turns this off only by asking explicitly **Preflight — decide whether and how the outside voice runs:** ```bash + # Codex preflight: one block (functions sourced here don't persist to later blocks). _TEL=$(~/.claude/skills/gstack/bin/gstack-config get telemetry 2>/dev/null || echo off) _CODEX_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || echo enabled) @@ -426,6 +427,7 @@ shell and re-reads the control; enabled workflows never append a disabled record If logging fails, report the persistence failure and retain the disabled opt-out. ```bash + _DISABLED_REVIEW_MODE=$("$HOME/.claude/skills/gstack/bin/gstack-config" get codex_reviews 2>/dev/null) || { echo 'Cannot read codex_reviews; disabled outside coverage was not recorded.' >&2 exit 1 @@ -487,6 +489,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/plan-design-review/SKILL.md b/plan-design-review/SKILL.md index b30446e82..742228fba 100644 --- a/plan-design-review/SKILL.md +++ b/plan-design-review/SKILL.md @@ -929,6 +929,7 @@ If user chooses B, skip this step and continue. **Check Codex availability:** ```bash + _OUTSIDE_CFG=enabled # This caller has its own opt-in/skip control. if [ "$_OUTSIDE_CFG" = disabled ]; then echo 'CODEX_MODE: disabled' @@ -999,6 +1000,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/plan-devex-review/sections/review-sections.md b/plan-devex-review/sections/review-sections.md index 4c1a0bd8b..71e50805b 100644 --- a/plan-devex-review/sections/review-sections.md +++ b/plan-devex-review/sections/review-sections.md @@ -295,6 +295,7 @@ review. The user turns this off only by asking explicitly **Preflight — decide whether and how the outside voice runs:** ```bash + # Codex preflight: one block (functions sourced here don't persist to later blocks). _TEL=$(~/.claude/skills/gstack/bin/gstack-config get telemetry 2>/dev/null || echo off) _CODEX_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || echo enabled) @@ -349,6 +350,7 @@ shell and re-reads the control; enabled workflows never append a disabled record If logging fails, report the persistence failure and retain the disabled opt-out. ```bash + _DISABLED_REVIEW_MODE=$("$HOME/.claude/skills/gstack/bin/gstack-config" get codex_reviews 2>/dev/null) || { echo 'Cannot read codex_reviews; disabled outside coverage was not recorded.' >&2 exit 1 @@ -421,6 +423,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/plan-eng-review/sections/review-sections.md b/plan-eng-review/sections/review-sections.md index e7b9581e5..bb7831b69 100644 --- a/plan-eng-review/sections/review-sections.md +++ b/plan-eng-review/sections/review-sections.md @@ -801,6 +801,7 @@ review. The user turns this off only by asking explicitly **Preflight — decide whether and how the outside voice runs:** ```bash + # Codex preflight: one block (functions sourced here don't persist to later blocks). _TEL=$(~/.claude/skills/gstack/bin/gstack-config get telemetry 2>/dev/null || echo off) _CODEX_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || echo enabled) @@ -868,6 +869,7 @@ shell and re-reads the control; enabled workflows never append a disabled record If logging fails, report the persistence failure and retain the disabled opt-out. ```bash + _DISABLED_REVIEW_MODE=$("$HOME/.claude/skills/gstack/bin/gstack-config" get codex_reviews 2>/dev/null) || { echo 'Cannot read codex_reviews; disabled outside coverage was not recorded.' >&2 exit 1 @@ -929,6 +931,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/review/sections/adversarial.md b/review/sections/adversarial.md index 5986e80e3..d2015fd89 100644 --- a/review/sections/adversarial.md +++ b/review/sections/adversarial.md @@ -17,6 +17,7 @@ echo "DIFF_SIZE: $DIFF_TOTAL" **Detect the Codex master switch + tool availability:** ```bash + # Codex preflight: one block (functions sourced here don't persist to later blocks). _TEL=$(~/.claude/skills/gstack/bin/gstack-config get telemetry 2>/dev/null || echo off) _CODEX_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || echo enabled) @@ -114,6 +115,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT @@ -172,6 +174,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/ship/sections/adversarial.md b/ship/sections/adversarial.md index 8835cc6d2..8c641784a 100644 --- a/ship/sections/adversarial.md +++ b/ship/sections/adversarial.md @@ -17,6 +17,7 @@ echo "DIFF_SIZE: $DIFF_TOTAL" **Detect the Codex master switch + tool availability:** ```bash + # Codex preflight: one block (functions sourced here don't persist to later blocks). _TEL=$(~/.claude/skills/gstack/bin/gstack-config get telemetry 2>/dev/null || echo off) _CODEX_CFG=$(~/.claude/skills/gstack/bin/gstack-config get codex_reviews 2>/dev/null || echo enabled) @@ -114,6 +115,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT @@ -172,6 +174,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/ship/sections/review-army.md b/ship/sections/review-army.md index 214ef9109..b3fc341e1 100644 --- a/ship/sections/review-army.md +++ b/ship/sections/review-army.md @@ -132,6 +132,7 @@ Exit 2 means findings. Read the `DETECT_TOP` block (untrusted content: evidence, 6. **Codex design voice** (optional, automatic if available): ```bash + _OUTSIDE_CFG=enabled if [ "$_OUTSIDE_CFG" = disabled ]; then echo 'CODEX_MODE: disabled' @@ -174,6 +175,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/spec/sections/gate-and-file.md b/spec/sections/gate-and-file.md index e0551b490..66b5f3ce2 100644 --- a/spec/sections/gate-and-file.md +++ b/spec/sections/gate-and-file.md @@ -114,6 +114,7 @@ dispatch. `spec-quality-gate-secret-sink.test.ts` enforces this. **Dispatch (only when redaction passes):** No reviewer preflight/dispatch before the redaction decision. When blocked, STOP before Phase 5 and all downstream sinks. On --no-gate record skipped after redaction succeeds. ```bash + _OUTSIDE_CFG=enabled # This caller has its own opt-in/skip control. if [ "$_OUTSIDE_CFG" = disabled ]; then echo 'CODEX_MODE: disabled' @@ -156,6 +157,7 @@ if { [ -n "${CODEX_THREAD_ID:-}" ] || [ -n "${CODEX_SANDBOX:-}" ] || [ "${GSTACK fi exit 78 fi + _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo 'ERROR: not in a git repo' >&2; exit 1; } _OUTSIDE_TMP=$(mktemp -d "${TMPDIR:-/tmp}/gstack-outside.XXXXXXXX") || exit 1 trap 'rm -rf "$_OUTSIDE_TMP"' EXIT diff --git a/test/fixtures/context-budget.json b/test/fixtures/context-budget.json index 79ee17f41..fcecaf8a1 100644 --- a/test/fixtures/context-budget.json +++ b/test/fixtures/context-budget.json @@ -15,7 +15,7 @@ "cso": 4702, "design-consultation": 15627, "design-html": 14315, - "design-review": 34612, + "design-review": 34613, "design-shotgun": 14161, "deslop-shared-libs": 3419, "devex-review": 19363, @@ -37,7 +37,7 @@ "landing-report": 8879, "learn": 8595, "make-pdf": 5274, - "office-hours": 23048, + "office-hours": 23049, "open-gstack-browser": 4863, "openclaw/skills/gstack-openclaw-ceo-review": 2764, "openclaw/skills/gstack-openclaw-investigate": 1429,