mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-06 00:44:07 +01:00
fix: pre-landing review fixes
Red team (/ship Step 9): a Drive copy at a bootstrapper revision below GSTACK_CAPY_MIN_WRAPPER is a WARN with the owner action in a direct (no-provenance) run too; only a pre-bootstrapper copy fails. A --for none session never self-upgrades. Stale fail-behind comment in gstack-capy-session; SKILL.md says ok not-needed is not an install verdict. Tests: UPGRADE_SKIPPED collapse, silent in-place message, direct-run WARN, wrapper-2 --for none handover. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
6a0f9e47bb
commit
fc69d3ff0b
10 files changed
+72
-14
No files matched your search
@@ -506,8 +506,10 @@ floor is not what keeps machines current). It never exceeds VERSION
|
||||
changes in a way older copies cannot work with; older Drive copies keep
|
||||
working and print an owner action
|
||||
([CAPY_WRAPPER_STALE](troubleshooting.md#capy-wrapper-stale)), and the
|
||||
doctor's `wrapper` row warns (an active copy below the minimum is a WARN,
|
||||
never a FAIL; `bin/gstack-upgrade` never leaves a pending reinstall for it).
|
||||
doctor's `wrapper` row warns (a bootstrapper copy below the minimum is a WARN,
|
||||
active or found in the Drive by a direct run, never a FAIL; only a
|
||||
pre-bootstrapper copy with no `GSTACK_CAPY_WRAPPER=` line fails;
|
||||
`bin/gstack-upgrade` never leaves a pending reinstall for it).
|
||||
Wrapper 2 only added optional exports (the trailer's `latest:` note and the
|
||||
`cloned` line). Wrapper 3 answers `--check --for none` itself (a copy at 1 or 2
|
||||
prints `fail not-installed` for a coordinator machine and still works for every
|
||||
|
||||
+10
-5
@@ -1574,8 +1574,10 @@ every lease with its age and `alive|dead|stale`; a holder is named as
|
||||
When you know they are idle, `GSTACK_UPGRADE_FORCE=1 bin/gstack-upgrade`
|
||||
proceeds. At a Capy session start the same refusal appears as
|
||||
`SELF_UPGRADE: skipped (live gstack sessions hold this installation: ...)`,
|
||||
and the trailer is `gstack: fail behind — … (UPGRADE_BUSY)`: a session that
|
||||
could not upgrade is never certified ok.
|
||||
the doctor adds `WARN behind — … (UPGRADE_BUSY)` and the trailer stays
|
||||
`gstack: ok … (behind=<n> (latest: <v>); upgrade skipped: … (UPGRADE_BUSY); fix: …)`:
|
||||
the installed revision is above the supported minimum, so the session is
|
||||
certified and the note names the fix.
|
||||
|
||||
<a id="upgrade-fetch-failed"></a>
|
||||
### `gstack-upgrade: could not reach origin (...) (UPGRADE_FETCH_FAILED)`
|
||||
@@ -1618,9 +1620,12 @@ action that never fails the run. Without provenance (a direct
|
||||
`gstack-doctor --check`, or a pre-bootstrapper copy with no
|
||||
`GSTACK_CAPY_WRAPPER=` line, which reads as wrapper 0) it reads the Drive
|
||||
copies (`~/.capy/drive/*/skills/gstack/scripts/install.sh`, or only
|
||||
`GSTACK_CAPY_WRAPPER_PATH` when set) and fails only when every copy is stale,
|
||||
listing each with its revision. A stale active wrapper is a `WARN` too: an
|
||||
older copy still works (`capy/support.env`). `bin/gstack-upgrade` runs the
|
||||
`GSTACK_CAPY_WRAPPER_PATH` when set), listing each with its revision: every
|
||||
copy a bootstrapper below the minimum is `WARN wrapper — every Capy skill copy
|
||||
is below the minimum wrapper <m> (it still works): ...` with the owner action,
|
||||
and it fails only when a copy is pre-bootstrapper (wrapper 0), which cannot
|
||||
hand over at all. A stale active wrapper is a `WARN` too: an older copy still
|
||||
works (`capy/support.env`). `bin/gstack-upgrade` runs the
|
||||
installer with the checkout's own copy as the active wrapper and never leaves
|
||||
a pending reinstall when the wrapper row is the only failure.
|
||||
|
||||
|
||||
Reference in new issue
Block a user