From ffc8c13ca0bcba8cead4ce2e02705270b14b5951 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Mon, 2 Nov 2026 15:26:07 -0800 Subject: [PATCH] v1.93.25.0 docs: /setup-browser-cookies warns about the eMudhra trust gap (#3338) (#3871) * docs(setup-browser-cookies): warn that the bundled Chromium still trusts the eMudhra intermediates (#3338) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: drop the issue number from model-read skill text (archaeology lint) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- CHANGELOG.md | 7 +++++++ VERSION | 2 +- agents-digest/gstack-AGENTS.md | 2 +- package.json | 2 +- setup-browser-cookies/SKILL.md | 2 ++ setup-browser-cookies/SKILL.md.tmpl | 2 ++ test/helpers/manual-judge-review-fixture.ts | 8 ++++++++ 7 files changed, 22 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 574a8987b..fe1f9ae4c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## [1.93.25.0] - 2026-11-02 + +**/setup-browser-cookies now warns that the fallback browser still trusts the compromised eMudhra intermediates (#3338).** BROWSER.md carried this warning since v1.91.239.0, but the cookie import skill did not, so an agent importing signed-in cookies into the bundled Chromium never told the user. + +### Changed +- **`setup-browser-cookies/SKILL.md.tmpl`**: before the import, the agent tells the user once that gstack's bundled Chromium still accepts certificates from those intermediates, says not to use the imported sessions on a network they do not trust until the Playwright bump, and points to `BROWSER.md`, **TLS trust: the bundled Chromium's root store**. + ## [1.93.24.0] - 2026-11-02 **The /ship workflow judge loses the contradiction it cited in every recorded red sample.** diff --git a/VERSION b/VERSION index 8eae0b3f6..041b4c23a 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.93.24.0 +1.93.25.0 diff --git a/agents-digest/gstack-AGENTS.md b/agents-digest/gstack-AGENTS.md index 1e6f2ef3d..01e83b302 100644 --- a/agents-digest/gstack-AGENTS.md +++ b/agents-digest/gstack-AGENTS.md @@ -1,4 +1,4 @@ -# gstack digest v1.93.24.0 — regenerate/re-copy after upgrading gstack +# gstack digest v1.93.25.0 — regenerate/re-copy after upgrading gstack Behavioral rules from gstack (https://github.com/garrytan/gstack), compressed for agent hosts without a full skill install. The full skills add workflows, diff --git a/package.json b/package.json index 0863537e1..cc3f39d04 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "gstack", - "version": "1.93.24", + "version": "1.93.25", "description": "Garry's Stack — Claude Code skills + fast headless browser. One repo, one install, entire AI engineering workflow.", "license": "MIT", "type": "module", diff --git a/setup-browser-cookies/SKILL.md b/setup-browser-cookies/SKILL.md index c193d6c3f..003faa78f 100644 --- a/setup-browser-cookies/SKILL.md +++ b/setup-browser-cookies/SKILL.md @@ -175,6 +175,8 @@ Use the picker when any of answers 1-2 is still open; it asks for them. Use dire $B goto "" ``` +Tell the user once, before the import: gstack's headless browser trusts the root store built into gstack's bundled Chromium, which still accepts certificates from the compromised eMudhra intermediates. Until gstack moves to a Playwright release that drops them, don't use the imported sessions on a network the user does not trust. That same root's `BROWSER.md`, **TLS trust: the bundled Chromium's root store**, has the details and the check. + ## 4. Import Picker (the user confirms the browser, profile and domains there, ticks verification if they asked for it, then tells you when done; the link works once, for five minutes, so rerun the command if it expires): diff --git a/setup-browser-cookies/SKILL.md.tmpl b/setup-browser-cookies/SKILL.md.tmpl index b8c81bfa1..eddad8ae4 100644 --- a/setup-browser-cookies/SKILL.md.tmpl +++ b/setup-browser-cookies/SKILL.md.tmpl @@ -51,6 +51,8 @@ Use the picker when any of answers 1-2 is still open; it asks for them. Use dire $B goto "" ``` +Tell the user once, before the import: gstack's headless browser trusts the root store built into gstack's bundled Chromium, which still accepts certificates from the compromised eMudhra intermediates. Until gstack moves to a Playwright release that drops them, don't use the imported sessions on a network the user does not trust. That same root's `BROWSER.md`, **TLS trust: the bundled Chromium's root store**, has the details and the check. + ## 4. Import Picker (the user confirms the browser, profile and domains there, ticks verification if they asked for it, then tells you when done; the link works once, for five minutes, so rerun the command if it expires): diff --git a/test/helpers/manual-judge-review-fixture.ts b/test/helpers/manual-judge-review-fixture.ts index b5f610f52..7a7874cd5 100644 --- a/test/helpers/manual-judge-review-fixture.ts +++ b/test/helpers/manual-judge-review-fixture.ts @@ -61,10 +61,18 @@ const LATER_COOKIE_ORDER_EDITS: Array<[string, string]> = [ ["# view the page; only --verify-auth proves sign-in", "# confirm the intended account"], ]; +// The #3338 trust warning (GSTA-84) added one paragraph after step 3's goto +// (two lines longer). Removing it first lets the GSTA-49 reversal match. +const LATER_TRUST_PARAGRAPH = "Tell the user once, before the import: gstack's headless browser trusts the root store built into gstack's bundled Chromium, which still accepts certificates from the compromised eMudhra intermediates. Until gstack moves to a Playwright release that drops them, don't use the imported sessions on a network the user does not trust. That same root's `BROWSER.md`, **TLS trust: the bundled Chromium's root store**, has the details and the check.\n\n"; + export function approvedCookieWorkflowSource(source: string): string { let removedLines = 0; let removedEntrypointLines = 0; let reordered = source; + if (reordered.includes(LATER_TRUST_PARAGRAPH)) { + removedEntrypointLines += LATER_TRUST_PARAGRAPH.split('\n').length - 1; + reordered = reordered.replace(LATER_TRUST_PARAGRAPH, ''); + } for (const [later, earlier] of LATER_COOKIE_ORDER_EDITS) { if (!reordered.includes(later)) continue; removedEntrypointLines += later.split('\n').length - earlier.split('\n').length;