From ffd5ece2f2f4f13e417f0a4a6e0da86a413ad411 Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 3 Oct 2026 00:07:35 +0000 Subject: [PATCH] document-release: changelog sell test as three questions, not a 0-3 score (s10 M6) The threshold stays (fewer than two answered = needs attention, not replacement). M4/M5 (NEVER CLOBBER / NEVER BUMP) keep their wording; the integrator owns the eval-gated rewrite. W7a pin: workflow-excerpt:170 'Entries scoring <2 need attention, not replacement' becomes a case-insensitive check that weak entries get attention, not replacement. Template-only commit: generated SKILL.md is expected red until the regeneration commit. --- document-release/sections/release-body.md.tmpl | 10 +++++----- test/workflow-excerpt.test.ts | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/document-release/sections/release-body.md.tmpl b/document-release/sections/release-body.md.tmpl index 25ca63d8d..a44484870 100644 --- a/document-release/sections/release-body.md.tmpl +++ b/document-release/sections/release-body.md.tmpl @@ -101,11 +101,11 @@ preserved them. This skill must NEVER do that. **If CHANGELOG was modified in this branch**, review the entry for voice: -- **Sell test (Diataxis rubric):** Score each CHANGELOG entry 0-3: - - **1 point** — answers "What changed?" (reference: names the feature/fix) - - **1 point** — answers "Why should I care?" (explanation: user impact, pain removed) - - **1 point** — answers "How do I use it?" (how-to: command, flag, or link to docs) - - Entries scoring <2 need attention, not replacement. Report missing facts or user impact; polish existing wording only. A score of 3 passes all three checks. +- **Sell test (Diataxis):** a good entry answers "What changed?" (names the + feature/fix), "Why should I care?" (user impact, pain removed) and "How do I use + it?" (command, flag, or link to docs). An entry that answers fewer than two of these needs + attention, not replacement: report the missing facts or user impact, and polish + existing wording only. - Lead with what the user can now **do** — not implementation details. - "You can now..." not "Refactored the..." - Flag commit-message-style entries and polish wording without removing facts. diff --git a/test/workflow-excerpt.test.ts b/test/workflow-excerpt.test.ts index 50d0090aa..dbedd67e8 100644 --- a/test/workflow-excerpt.test.ts +++ b/test/workflow-excerpt.test.ts @@ -167,7 +167,7 @@ describe('workflow judge excerpts', () => { expect(review).toContain('present the findings, then use AskUserQuestion ONCE:'); expect(review).toContain('On A or per-finding approvals, make the approved edits yourself'); expect(text).toContain('Step 9 then commits and pushes those edits'); - expect(text).toContain('Entries scoring <2 need attention, not replacement'); + expect(text).toMatch(/needs?\s+attention,?\s+not\s+replacement/i); expect(text).not.toContain('Flag and rewrite'); expect(text).toContain('if VERSION is absent, use the completion date only'); });