* fix(evals): repair five paid-case flakes at their causes: docsync --help slip, state-dir artifacts, preamble asset, defer paraphrase, probe --help (GSTA-107)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix: pre-landing review fixes
offersDefer: the wait/hold-off-for-now paraphrase must open the option or a
sentence and end it, so a drive option's "I wait for now while you sign in"
or a manual option's "wait for now and do it yourself" no longer reads as the
defer option (red-team finding on #3472). Negative controls added.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix: pre-landing review fixes (round 2)
- offersDefer: the wait/hold-off-for-now paraphrase never counts inside a
browser drive option, accepts an em dash without spaces and a curly
apostrophe in let's; negative and positive controls added (adversarial
review on #3472).
- docsync-authority: the interface assertion expects the rendered
`<home>/remote.git` form so it holds on Windows; the captured Linux
replay is POSIX-only like the late-result replay (outside voice P1).
- touchfiles: register the two new docsync captures with the paid cases
they replay (ship-docsync-store, ship-docsync-completion), which
test/free-fixtures.test.ts requires (remote gate red at 470ac55).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
---------
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-callers): bind QA section names in the caller prompt instead of teaching helper forms (W3-4)
The caller session prompt taught full capture/checkpoint syntax but only
mentioned materialize, so two ship-exploratory-small-cli sessions (paid
gate runs 38973329985, 38993076767) skipped qa/sections/exploratory.md and
system-functional.md and guessed a bare materialize. The prompt now
declares only fixture bindings (DEADLINE_TOOL, EVIDENCE_TOOL, PROBE_DIR,
DEADLINE_FILE, --public approval, --timeout-ms 10000 for plan probes) and
points to the section for every form. The read requirement is unchanged;
both captured transcripts are kept as negative controls.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): run the state-machine detector in the scope block and check its exit status (W3-5)
Specialist 9 named gstack-state-matrix detect only in selection prose, and
small diffs keep only State Machines, so agents ran an undeclared command
(paid gate run 39002269281). The generated scope block now runs the
detector with its exit status checked: on failure it keeps the detector's
diagnostics and sets SCOPE_STATE_MACHINE=unknown, and selection dispatches
State Machines when the signal is true or unknown. The check step becomes a
declared heredoc block. The clarity test requires every non-diff-scope
signal to come from a detect helper the scope block runs; a free test runs
the block against a failing detector stub; the captured standalone call
stays outside the caller interface.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(third-party-actions): letter the absent-Aside consent options B/C/D (W3-7)
The contract fixed letters only when Aside is detected, so a tpa-absent-linux
agent numbered its consent question 1/2/3 (paid run 39011101113), which the
lettered-offer inspection cannot read. The absent branch now offers
B) gstack's own visible browser, C) manual instructions, D) defer and omits
A). The paid test's assertion is unchanged; the captured numbered answer is
a documented fail example in the unit test.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(plan-reality): say tier 1 rows are never n/a (W3-8)
The plan-review reality block offered pass|finding|n/a without saying tier 1
rows may never be n/a, so a plan-mode-no-op session wrote
`REALITY: deferred-asks n/a ...`, check returned repair, and the repair loop
ran past the 300 s capture (paid run 39004466422). The block now says tier
1 rows are never n/a and that with no linked issue deferred-asks is pass
with a receipt showing none. The captured line is pinned through check as
missing=deferred-asks verdict=repair.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-functional): webhook fix runs re-verify the repaired invariant and rerun superseded captures (W3-6, W3-14)
W3-6: stage 2 of the fix-run prompt asked only for the original, happy,
cancel and dependency probes while verifyQANativeRegression reruns all
eight, so a status-only repair that left partial broken reached the verifier
(paid run 38986120559). The webhook fix prompt now states the capture budget
up front (at most 5 pre-repair captures, then the 7 post-repair scenarios:
duplicate, partial, concurrent-ab, concurrent-ba, happy, cancel, dependency;
12 in total; report incomplete if 5 cannot establish the defect). That list
feeds the capture nudge (GSTACK_QA_REQUIRED_PROBES);
QA_WEBHOOK_REQUIRED_SCENARIOS and the verdict are unchanged.
W3-14: the fix prompt now says to rerun every pre-repair capture the
verdict relies on after the final repair, and that a superseded row stays
open until its command reran on the repaired source (paid run 39053431488
labelled a pre-repair duplicate superseded and never reran it). The
detector and its negative test are unchanged; the captured shape joins them
as a negative control.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa): tie the exploratory stop rule to per-rule input probes; fix runs close superseded captures (W3-9, W3-14)
W3-9: two qa-functional-cli-report sessions stopped at 5-7 of 12 probes
without probing a non-digit amount (paid runs 38983306684, 39001107574),
though system-functional.md requires one probe per documented input rule.
The single stop rule shared by both exploratory templates now says each
documented input rule needs its own probe breaking only that rule, and
rules left uncovered at a probe or time cap go in limits.
W3-14: for fix runs (not qa-only), every capture taken before a fix is
superseded even when its client prints no snapshot; before completion the
agent reruns each one its verdict relies on or reports it as an open
remainder. Production superseded/open semantics are unchanged.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-functional): keep the captured webhook-report cat attempts as denied negative controls (Q3)
Paid run 39006896632 (qa-functional-webhook-report) attempted
`cat package.json probe.ts .gitignore` and `cat src/*.ts test/*.ts`; the
PreToolUse hook denied both. This is a model miss, not a detector defect, so
both commands are pinned as denied by the registered hook and outside
qaCommandAllowed. No detector change.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(docs-candidate): per-subcommand --help and a compare reject that names the fix (W3-2)
snapshot --help and compare --help print the usage and exit 0 before any side
effect; the docsync observer admits exactly those two forms. compare names the
record path, each missing or wrong field (schema_version, base, hashes) and
the snapshot command that writes a valid record, keeping exit 1. The captured
ship-docsync-stale-after commands from PR gate run 38990111230 replay inside
the interface; help with any other argument stays rejected.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(docsync-fault): prepare writes the production candidate through the installed snapshot (W3-1)
The fault actor prepare wrote its own {base_sha, content_hashes, ...} record,
which the installed gstack-docs-candidate compare rejects, while
ship/sections/documentation.md requires running compare; 79 of 198 docsync
captures (and the red in PR gate run 38990111230) were pushed off the
documented path by it.
prepare now runs the installed snapshot under a 30 s timeout for the same
selection, returns its exact command as snapshot_command so the post-child
rerun is literal, publishes prompt and event only after a valid record
exists, and removes a record its own failed snapshot left. dispatch observes
the candidate with the same installed snapshot; inspect returns base, index
and per-file git blob ids in the record representation; the legacy re-audit
check reads selected/hashes. The fault prompt names snapshot_command and the
new field names.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(todos): file the qa-quick capture headroom follow-up (fix wave 3, T)
qa-quick timed out once at 300 s (paid run 38980005793) against passing
runs of 164-272 s. Trimming what the Quick tier loads is a product call, so
it is filed, not repaired; no budget change.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(docsync): keep the two docsync model misses as negative controls (W3-3)
The Bash grep of ship-docsync-missing-asset (PR gate run 38983306684,
bash#13) and the composed cat; cat of ship-docsync-failure (38984977679,
bash#12) were correct rejections. They join the stored known_bad commands
(with a {home} placeholder for the fixture home); no detector change.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(golden): refresh the ship goldens for the W3-5 scope block and W3-7 consent letters
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(third-party-actions): state the absent-Aside letters in fewer characters (W3-7)
Same contract (B), C), D) when Aside is not detected; the next sentence
already omits the Aside option), 67 fewer characters on the pinned
land-and-deploy and office-hours skills.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(skill-md-size): re-pin 31 over-limit skills grown by fix wave 3 prompt repairs (owner sign-off needed)
CREW rule 11: these skills were already over 100,000 characters and grow
by the minimum text each repair needs; none crosses the limit for the
first time.
- gstack-review on cursor, factory, kiro, opencode, slate (+657..+676):
W3-5 runs gstack-state-matrix detect inside the scope block with its exit
status checked and declares the check step as a heredoc block; the new
fence carries the env-var-host runtime prelude (about 360 characters).
- gstack-plan-eng-review on 12 hosts (+104): W3-8 says tier 1 reality rows
are never n/a (paid run 39004466422 looped on a rejected n/a row).
- gstack-land-and-deploy on 12 hosts and gstack-office-hours on 4 hosts
(+21): W3-7 letters the absent-Aside consent options B), C), D).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(skills): fit the W3-5, W3-7 and W3-8 prompt repairs inside the parity budgets
The parity suite left 2-42 bytes of headroom on ship, review,
plan-eng-review, plan-ceo-review and land-and-deploy, so each repair now
pays for itself in the same resolver:
- W3-5: the scope block runs `source <(gstack-state-matrix detect --base
<base> || echo SCOPE_STATE_MACHINE=unknown)` (a failed detector's
stdout is overridden by the later unknown assignment; its stderr still
shows), the check block uses a short heredoc, and DIFF_LINES comes from one
`git diff --numstat | awk` sum instead of two --stat greps (same count:
insertions plus deletions, binary files zero).
- W3-7: the absent branch reads "offer only options B), C) and D)."
- W3-8: "never n/a" joins the tier 1 parenthesis, the no-linked-issue rule
joins the receipt sentence, and the deep header says the same in fewer
words; the redundant "(it prints the PLAN_REALITY: line)" is dropped.
Size pins: land-and-deploy (12 hosts, -20), office-hours (4 hosts, -20)
and plan-eng-review (12 hosts, -10) are lowered to their new sizes;
gstack-review on cursor, factory, kiro, opencode and slate stays above its
main pin (+355..+374) because the declared check block is a new fence that
carries the env-var-host runtime prelude. Raising those five pins needs
owner sign-off.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(design-e2e): the shim-dom scan check resolves the command's literal _REPORT/_RUN (W3-10)
PR gate run 38980005793 went red because the agent ran the generated DOM
block, scanning "$_REPORT/dom/$_RUN" with _RUN="run1" assigned in the same
command, and the check looked for the literal dom/run1 anywhere in a command.
domScanOfRun substitutes that command's own literal _REPORT=/_RUN=
assignments and credits a scan only when one of its own arguments is the run
directory. scan --changed, another directory, quoted heredoc report text and
non-literal or conflicting assignments stay negative controls. All 15
captured shim-dom runs in the window pass the new check (14 passed the old).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(pty): keep the last non-blank viewport for failure dumps (W3-11)
autoplan-guard-pty (PR gate run 38976253774) stalled at 489 s and its screen
dump, the tail of visibleText(), was only spinner redraws. Live PTY sessions
now remember the last non-blank viewport a screen read returned
(session.lastScreen()) and the harness wait-timeout dumps append it.
Diagnostic only: visibleText(), matching and verdicts are unchanged.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(autoplan): explicit 30 s timeout for each answer-invalidation test (W3-12)
The eng-only override test ran 4.1-4.4 s on a 4-core machine against Bun's
5 s default (7.8-9.4 s per file). Each test now names a 30 s budget.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(review-army): size the nested bun test budgets for windows-latest (W3-15)
windows-free-tests run 39053431430 (shard 5): the nested bun test exited 1 in
5.58 s because Bun's default 5 s hook timeout fired on the real Red Team
beforeAll (8 git spawns plus skill-section copies). Both nested argvs pass
--timeout 30000, which raises only the nested default; the registrations
under test keep their explicit timeouts. Spawn timeouts move from 8 s to
40 s and outer test timeouts to 45 s, including the consensus test that had
none. With a 6 s beforeAll injected, the lifecycle still matches; the old
argv reproduces the Windows hook timeout.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(todos): close the createQAFunctionalFixture entry and file D6 (W3-13)
The git auto-maintenance entry was fixed by 0bf9d50 (#3190). D6: nested bun
test output pollutes free-runner failure attribution in
scripts/lib/shard-engine.ts (windows-free-tests 39053431430).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(free-fixtures): declare the W3-4 captured caller transcript as a free-only fixture
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(pty): strip cursor-visibility escapes and print the last screen on autoplan-guard-pty failure (W3-11)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): keep the state-machine detector's output only on exit 0 (W3-5 confirm round)
A failing gstack-state-matrix detect prints SCOPE_STATE_MACHINE=false before
exiting non-zero. The scope block now captures its output and sources it only
when the detector succeeds; otherwise it discards the output, sets
SCOPE_STATE_MACHINE=unknown (dispatching the State Machines specialist) and
leaves the detector's stderr visible. Free tests cover false-output/non-zero,
empty-output/non-zero and a late failure after printing true. The stack
comment is shortened so gstack-review stays 4 chars under its pin; the five
host pins are lowered to match.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-functional): reserve webhook post-repair reruns first inside the unchanged 12-capture ceiling (W3-6/W3-14 confirm round)
The fix prompt now states precedence: post-repair reruns (the 7 stage-2
scenarios plus each distinct pre-repair command the verdict relies on, such as
a reject probe) are reserved first, pre-repair exploration gets what remains,
and reruns that cannot fit are reported as open. A free test fits a pre-repair
reject plus the reproduced defect and its replay within 12 (11 captures).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(docs-candidate): the compare reject never sends an agent to re-snapshot after the child audit (W3-2)
A post-audit snapshot over the candidate replaces the before-audit baseline, so
the ownership check would compare current files with themselves. The fix line
now says the candidate must be the record the Prepare snapshot wrote, that the
Prepare snapshot is rerun only before dispatching the child audit, and that the
post-child snapshot uses a different --out (<audit-id>-post.json). The helper
test pins the text.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(docsync-fault): diagnosable prepare snapshot failures with one fresh-id retry (W3-1)
A failed installed snapshot now returns exit 25 with a stable reason code
(snapshot_exit, snapshot_timeout, snapshot_spawn_error, snapshot_invalid_record),
the helper's stderr tail redacted through lib/redact-engine with the fixture
root as <HOME> and bounded to 800 characters, and keeps the attempt's files: the
candidate the helper left, if any, and prepare-<audit-id>-failure.json. The
failure is a prepare-failed event, not a rejected interaction. One retry is
allowed under a fresh audit id; reusing the failed id, dispatching it or a third
prepare is rejected. Tested before and after candidate creation. The two
snapshot tests get an explicit 30 s timeout: the compare/inspect agreement
test runs 4.3-4.8 s alone and timed out at Bun's 5 s default under load.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa-evidence): count required post-repair probes only after the fixture-declared final source edit (W3-6/W3-14 confirm round)
GSTACK_QA_REQUIRED_PROBES reminders counted any complete capture, so a
pre-repair duplicate or partial capture looked like post-repair coverage. The
caller may now declare GSTACK_QA_REQUIRED_AFTER_EDIT with absolute paths and a
clean-fixture time: only captures started after the last edit under those
paths count, none count before the first edit, and a malformed declaration
counts none. Without the declaration every capture counts as before. The
webhook fix fixture declares its src/ directory. A free test covers
pre-repair-only coverage (nudges), complete post-repair coverage (no nudge)
and a second edit (nudges again).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(harness): bump HARNESS_VERSION to 5 for the W3-11 stripAnsi change
stripAnsi now removes cursor-visibility escapes (ESC[?25h/l). Every PTY case
matches patterns against its output, so a pattern spanning one of those escapes
can now match where it did not before: a verdict can change, so this is a
behavioral bump, not a non-behavioral entry. The launch.ts change (last
non-blank screen in failure messages) is diagnostic only.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): pass the state-machines output to check as a written file, not a heredoc placeholder (W3-5)
The generated-bash lint (env-host-fence-conformance INV-3) rejects free text in
a heredoc body: <its complete output> reached the shell. The agent now writes
the specialist's full output to .gstack/tmp/state-machines.md and the fence
runs gstack-state-matrix check on that file. Two stack-detection comments and
the parenthetical are trimmed to stay inside the review/ship parity ratios;
gstack-review shrinks by 33 on the five pinned hosts and their pins are
lowered to match.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(autoplan-guard-pty): the scripted actor ends its turn after a background CEO dispatch before reading the close packet
PR gate 39070276914 (dc739be) failed at the close-packet check while gate
39069171159 (b789898) passed with byte-identical autoplan inputs. The evidence
differs only in order: the failing actor read the close packet in the dispatch
turn, so the first tool call after the CEO notice was the publication. The
product guard allowed all four guarded calls in both runs. The fixture step 5
told the actor to end its turn only conditionally; step 5 now ends the turn as
soon as the result says the agent runs in the background, and step 6 reads the
close packet only after the reviewer finished. The close-packet check moves to
closePacketReadAfterNotice, replayed in a free test against both captured
orders; a second free test pins the actor's steps 5 and 6.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* chore(release): v1.91.127.0 fix wave 3 paid-gate reliability round 2
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa): input-rule probes are per field, and a value breaking two rules covers neither (W3-9)
PR gate 39073934326 (93449bc) failed qa-functional-cli-report with no observed
unannounced defect, the same class as 38983306684 and 39001107574. The agent
read 'allowed characters' as the ID rule only, counted -5 as its sign probe
and never probed the amount's digits-only rule with an otherwise valid value,
so the seeded parseInt defect stayed hidden. The stop rule now says each
field's documented input rule needs a probe breaking only it, and that a
signed amount breaks sign and digits-only and covers neither; the functional
table row names input rules per field. The qa union stays inside its parity
ratio.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa): state the input-rule principle instead of a worked example (W3-9)
The signed-amount example in 0fe616e was misread in the focused rerun as 'a
signed amount breaks only the digits-only rule', and the run again missed
the seeded non-digit defect. The stop rule now states the principle: each
field's documented input rule needs a probe that breaks only it and satisfies
every other rule.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(tpa): the Darwin pitch detector accepts the canonical phrase anywhere, short forms only at a sentence start
PR gate 39075977549 (d6d82fb) failed tpa-absent-darwin on a correct pitch:
'One-time note: you can download Aside (macOS 15+) at aside.com, then open it,
sign in, and re-run'. The contract is to deliver the pitch once; the
sentence-start anchor exists only so narration is not counted. The full
canonical phrase now counts anywhere unless a negation precedes it, and the
short forms (download it / download Aside at aside.com) keep the
sentence-start rule. The detector moves to test/helpers/third-party-actions.ts
with a count helper. Free tests replay the captured red (counts once), the
four captured passing Darwin pitches (once each), five Linux and five READY
narrations plus both recovery-public responses (zero), a mid-sentence short
form and negated phrases (zero), and a duplicated phrase (two).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-callers): only a required plan check may swap the deadline for --timeout-ms; reruns keep the deadline
PR gate 39077524802 (0f71a55) failed ship-exploratory-late-input: after the
late input change the actor reran captures 001 and 002 with --timeout-ms
10000, reading the fixture's 'explicit plan probes outside the smoke budget'
clause as covering revalidation reruns, and the verifier reported both as
smoke probes missing a trusted deadline run. The binding now says only an
explicit plan check this phase requires may use --timeout-ms, and every other
capture, including a rerun or revalidation, uses the deadline.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(third-party-actions): count the Darwin pitch only at a recommendation boundary
/review delta on 51f1e02 (Claude and GPT-6.1 Sol voices): the 0f71a55
detector accepted the canonical phrase anywhere unless the adjacent word was
a negation, so a Darwin refusal or a quoted policy mention ('I will not ask
you to download Aside ...', 'The Darwin policy says to "download Aside ..."',
'You cannot download ...') satisfied the paid case's positive match, and a
free assertion even expected "You don't need to download ..." to count.
The canonical phrase now counts only where a recommendation can start: a
sentence, clause (, : ; dash), bullet, line or bold start, optionally led by
then/please/just/so/first/now and you can/could/may/should/need to, with no
negation directly before it across a line break. Quoted, parenthesised,
reported and clause-negated mentions fall outside that boundary. Every probe
from both voices is a free test; the five captured Darwin pitches (including
the 39075977549 red) still count 1 each and the Linux/READY captures 0.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(review-army): write the state-machines output to a fresh private file from gstack-state-matrix outfile
/review delta on 51f1e02 (Claude F2): dc739be wrote the specialist output to
a fixed .gstack/tmp/state-machines.md with no exclude. On a second review
Claude Code's Write refuses an existing unread file, so check could validate
the previous run's output, and git add -A could commit it.
gstack-state-matrix outfile creates .gstack/tmp (0700) at the repo top,
adds /.gstack/tmp/ to info/exclude once, and prints a new empty 0600 file
per call; the selection prose has the agent Read that file, write the full
output there and check that path. The prose moved the check command inline,
so gstack-review shrinks and its pins are lowered (cursor 141010->140637,
factory 144792->144416, kiro 140816->140449, opencode 143258->142872,
slate 140913->140543).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-evidence): pin the post-repair edit's mtime to capture 002's completion
The GPT voice's /review run on 51f1e02 failed qa-evidence.test.ts:547 once:
capture 003 reported no required probe remaining, so capture 002 (started
before the edit) counted as post-edit. The test wrote the edit right after
002 returned, a gap of one child run (7-27 ms measured here; the voice's
machine ran this test in 59 ms against 183 ms here, so a few ms there),
while an ext4 mtime comes from the kernel's coarse clock and lags
Date.now() by up to a tick (0.5-4.5 ms measured here).
The edit's mtime is now set to 002's recorded completedAt, so 002 started
strictly before the boundary and 003 starts after it on any machine. The
product boundary is unchanged: tick-scale imprecision only matters when a
capture starts within milliseconds before an edit, and a stricter margin
would refuse a real edit && capture chain.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
---------
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(designs): add fix wave 2026-10-15 plan (revision 3, approved)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(cso): invoke docker as argv0 docker so OrbStack's multicall binary dispatches
executable() returns the canonical path, and OrbStack installs docker as a
symlink to docker-tools, which dispatches on argv[0] and exits 127 with
'unsupported argv0 "docker-tools"'. Every Docker call failed, so doctor
reported local-docker-isolation and every scanner missing and setup could
not preload the qualified images.
runProcess takes an argv0 option; docker.ts routes every Docker call
through runDocker, which passes 'docker'. The native watchdog's execve
calls pass "docker" as argv[0] too, so its container cleanup works on the
same installs. The executed file is still the verified canonical path.
Fixes#3187
* test(cso): cover Docker and watchdog invocation through a multicall binary
A compiled fake that refuses any argv[0] but docker stands in for
OrbStack's docker-tools. Both behavior tests fail on the previous code.
Refs #3187
* fix(cso): bound the argv0 test's socket helper and probe images through OrbStack's multicall docker (#3187)
Follow-up to #3188 by Bryan Stone (@aegixx):
- the python3 spawnSync that binds the fake daemon socket gets a 30 s
timeout; without it test/spawnsync-timeout-tripwire.test.ts fails.
- reviewer test: dockerExactImagePresent, a production probe, admits an
image when the endpoint's canonical executable is a multicall binary
that refuses any argv0 other than "docker". It fails on 47d639a
(returns false) and passes with #3188.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(autoplan): own the conversation after a Claude Code 2.1.300 compaction
Claude Code 2.1.300 keeps a compaction's last records in place and lists
them in compactMetadata.preservedMessages. The segment's tail, which is
also the boundary's logicalParentUuid, is written after the boundary
under the compact summary, so the parent links form a cycle that the
owned causal order never reaches. Every record after the compaction was
dropped, and the publication guard denied each later phase entry with
close_incomplete.
Such a boundary now continues from the last preserved record that is a
node of the file and not its own descendant. Boundaries without that
metadata, with a foreign preserved uuid, or with nothing kept in place
still supply no ownership.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(autoplan): report a compaction-explained unreachable component as unrecognized_shape (#3194)
Follow-up to #3196 by vilano93. After the ownership walk, an owned node
the walk never reached was silently dropped, and the phase guard answered
the next phase entry with close_incomplete, which the user cannot satisfy.
When the unreachable node's ancestry ends in a cycle through a compact
boundary's logical parent, ownedCausalOrder now returns
unrecognized_shape:compaction_unreachable, the guard's existing
unverified disposition (allow with a visible warning and a guard-log
row). Orphans whose ancestor is missing (not flushed yet) and other roots
keep today's behaviour, so the fail-open surface does not widen beyond
compaction. Each node is walked once.
Gate-integrity edit: a close_incomplete denial becomes an unverified
allow for that shape only. Negative controls kept: the existing guard,
hook, guard-reasons and captured-fixture tests still deny (356 pass), and
a new case with the boundary not yet flushed still denies close_incomplete.
Intentional pin changes in #3196's own test file: the three "fails
closed" cases (tail-only segment, missing preserved metadata, foreign
preserved uuid) and the "without compactMetadata" case now expect
unrecognized_shape:compaction_unreachable instead of close_incomplete or
a silently cut transcript.
Reviewer tests: three compactions in one session stay owned and pass the
next phase entry; a 50k-record history with three compactions is decided
in ~300 ms (budget 1000 ms), so descends needs no memo.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* feat(lib): one echo sanitizer for external strings, with a Bash twin
lib/sanitize-echo.ts and bin/gstack-sanitize-echo.sh flatten CR/LF/TAB to
spaces, remove every other ASCII control byte (ESC included) and DEL,
collapse runs of spaces, and cap the result at 200 bytes of valid UTF-8
with no leading or trailing space. Every external string gstack echoes
into a message, a log line or a key=value state file goes through it
(fix wave 2026-10-15, plan rev 3 DX F8). test/sanitize-echo.test.ts runs
both twins on one table under bash, bash --posix and zsh, including a
"\nstages=" injection, ESC sequences and UTF-8 characters cut by the cap.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(bun-version): judge the Bun floor under zsh and hold on an unreadable version (#3195)
Reported by mochafreddo. _gstack_bun_below word-split $_gb_core, which
zsh does not do: `[ -ne ]` errored and every error path read as "not
below", so /gstack-upgrade Step 4 accepted Bun 1.3.2 in a zsh tool shell.
- _gstack_bun_below copies the release's parsed fields into quoted
positional parameters and compares with $((10#...)); no new _gb_*
globals. It returns 2 when either side cannot be parsed.
- gstack_bun_status prints malformed for an unparseable version or floor
(never ok); gstack_bun_incoming_hold holds on it with
bun-version-unreadable: ... (BUN_VERSION_UNREADABLE), the bun path and
its output passed through gstack_sanitize_echo. setup's own malformed
warning is unchanged.
- /gstack-upgrade Step 4 runs the check through `bash -c` and stops on
BUN_VERSION_UNREADABLE with a reinstall fix (never "bun upgrade").
- New result code BUN_VERSION_UNREADABLE with its troubleshooting entry;
bin/gstack-doctor-components.sh regenerated from the table.
test/bun-version-shells.test.ts: one version table (1.3.2,
1.3.3-canary.1, 1.3.3, 1.3.14, 1.4.2, 1.10.0, 01.04.02, 2.0.0, garbage)
drives bash, bash --posix, zsh and the TypeScript twin's below();
`zsh -c '. bin/gstack-bun-version.sh; gstack_bun_status 1.3.2'` printed
ok on 47d639a and prints too-old now.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* style(cso): format #3188's runDocker call so format:cso:check passes (#3187)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(cso): keep scanner JSON reports parseable after redaction (#3185)
Reported in #3185. The scanner path splices redactions into raw JSON, and
redactFindingSpans replaced a bare 10+ digit number
("max_memory_bytes":1145427776, an epoch) with an unquoted marker, so
JSON.parse failed and every non-trivial Semgrep run was INVALID_OUTPUT.
- lib/redact-engine.ts: redactJsonFindingSpans, a string- and
escape-aware lexical tokenizer over one or more top-level values
(NDJSON included). A span inside a number replaces that whole token
(-, fraction, exponent) with the quoted marker, number by number; a
span inside a string keeps the in-string marker, widened to whole
escapes; a span touching several tokens, whitespace, a literal or a
structural character returns null (withhold). Non-JSON text gets the
plain splice. redactFindingSpans is unchanged for every other caller.
- The scan operation's declared format rides the real capture path:
scanner-executor (scan stdout, or the report file read for outputPath
plans) -> DockerGroup.execCapture -> runProcess -> spliceRedaction,
which redacts the concatenated stdout once and maps each interleaved
run onto it. Version probes and stderr stay plain; marker-only
withholding and the cross-stream views check are kept, and the output
is a fixpoint of that check.
Behavior change: a redacted number in a scanner report is now the string
"<REDACTED-...>" instead of an unquoted marker; non-JSON streams keep the
unquoted form (test/cso-eval.test.ts unchanged).
Intentional pin change: test/cso-scanner-release.test.ts pinned the
report read as capture(['/bin/cat', plan.outputPath]); it now pins
capture(['/bin/cat', plan.outputPath], plan.format), so the read also
carries the declared JSON format (stricter, not weaker).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(browse): recover when the last tab is closed outside the CLI
Closing the last tab outside browse (for example, closing the headed
Chromium window) left the daemon wedged: the page 'close' handler removed
the tab and set activeTabId to 0, and executeCommand called
getActiveSession() first, so every later command (goto, status, even stop)
failed with "No active page" until the daemon PID was killed by hand.
closeTab() already opens a blank tab when the last tab closes; the external
close path never did. Add BrowserManager.ensureActiveTab(), which reselects
a remaining tab or opens one blank tab (concurrent callers share one
recovery), and call it before resolving the active session in
executeCommand.
Fixes#3167
* fix(browse): status and stop answer after an external close; recovery says what it did (#3167)
Follow-up to #3179 by aftabkh4n, which reopens a tab on demand.
- BrowserManager.ensureCommandTab runs before every command: status,
stop and restart never open a tab, so a daemon whose browser or context
is gone can still report and be stopped; any other command gets an
active tab. A failed recovery is BROWSE_TAB_UNRECOVERABLE carrying the
restart command (cause passed through sanitizeEcho), and a command that
ran on a newly opened tab prints a one-line warning first.
- server.ts reads the session inside the read and write branches instead
of before dispatch (2223 lines, cap 2224) and exposes browserManager
and handleCommandInternal on __testInternals__ for the dispatch test.
- meta-commands.ts: handleMetaCommand no longer reads the active session
before its switch (only snapshot and resume used it), and status prints
getCurrentUrl() so it works with zero tabs. This file is outside the
lane's listed ownership; no other lane or #3190 touches browse/.
- New result code BROWSE_TAB_UNRECOVERABLE and troubleshooting entries
for it and for the old "No active page" wedge.
Reviewer test browse/test/tab-external-close-dispatch.test.ts drives the
real dispatch in a child process: status, text, goto and stop after an
external close, and the closed-context case. On 47d639a (with only the
test seam added) all five fail with "No active page".
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(troubleshooting): /cso INVALID_OUTPUT on Semgrep reports and OrbStack's argv0 refusal (#3185, #3187)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(session-update): name the reinstall fix when an unreadable Bun holds the auto-update (#3195)
Item 11 makes every caller of gstack_bun_incoming_hold treat a Bun
version it cannot read as a hold (bun-version-unreadable,
BUN_VERSION_UNREADABLE). The session-start banner only knew
bun-too-old, so the new reason fell through to "git pull did not
finish ... gstack is not updating" with a pull-and-setup fix that does
not help.
- bin/gstack-session-update: a bun-version-unreadable banner case with
the reinstall fix and the troubleshooting anchor; the comment that
said a malformed version passes is corrected.
Intentional pin change: test/session-update-stages.test.ts "supported
or unparseable Bun (bun-dev (local build)) proceeds: setup decides" is
split. 1.3.14 still proceeds; bun-dev (local build) now holds with
BUN_VERSION_UNREADABLE, leaves the checkout and setup untouched, and
the banner names the reinstall fix. The fixture installs
bin/gstack-sanitize-echo.sh beside the floor helper, as a real install
of this release does. The new case fails on 47d639a.
Ownership exception granted by the coordinator for Lane A
(bin/gstack-session-update is Lane B's file; PR 1b stacks on 1a).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(session-update): recover a conflicting autostash by its unmerged files
The auto-updater fast-forwards with `merge --ff-only --autostash`. When
the carried-over local edits conflict with the incoming revision, git
2.56 still exits 0 from that merge, pops the edits with conflict markers
into the live checkout, and keeps the stash entry. The recovery only ran
on a non-zero exit with "autostash" in stderr, so on git 2.56 it never
ran: the updater logged UPDATED and ran setup over a half-merged tree,
in the directory Claude Code runs hooks from. When it did run, it had two
more problems:
- `git checkout -- .` refuses unmerged paths ("error: path 'f' is
unmerged", exit 1), so it left the markers in place anyway.
- `git stash drop` dropped stash@{0}, whatever that was. refs/stash is
shared with every worktree of the repository, and when
refs/stash.lock is held git cannot store the autostash at all, so the
top entry can be someone else's.
Now the merge is judged by `git ls-files -u`, whatever its exit code.
On unmerged files after the fast-forward, autostash_recover finds the
autostash commit by the id git prints ("cannot store <id>" first, then
"Created autostash: <id>", with the merge run under LC_ALL=C and
core.abbrev=40). A moved refs/stash is only the fallback. When that id
is not a stash entry, it is anchored under refs/gstack-autostash/<UTC>.
The tree is reset to the fast-forwarded revision, which the hook check
already passed, and the stash is kept. The log line is
AUTOSTASH_CONFLICT_RECOVERED tree_reset=1 kept_stash=<id> kept_ref=<ref>.
The update then continues, so the regenerable patches are re-rendered
and setup runs as for any other move. If the commit cannot be found,
nothing is reset: the markers stay for a person, the run logs
PULL_FAILED, and setup does not run.
Files that are already unmerged before the update, from someone's own
merge, rebase or stash pop, now hold the update with PULL_FAILED
"unmerged files ...". Without that check, the recovery would take them
for its own and reset them away.
core.abbrev=40, not "no": "no" is accepted from git 2.31.0 (its release
notes), and `merge --autostash` exists from 2.27.0, so "no" would fail
every update on git 2.27-2.30.
Files:
- bin/gstack-session-update: autostash_recover, the unmerged-files check
before the merge, the C-locale merge with its stdout kept for the id,
and removal of the old grep-and-drop block.
- test/session-update-autostash.test.ts: 7 cases in a new describe block.
A conflicting pop leaves no markers, keeps the edits and still runs
setup. A user's own stash entry survives. A held refs/stash.lock gets
the edits anchored. With a git whose merge prints nothing, a moved
refs/stash still finds the edits; with the lock held as well, nothing
is reset. Pre-existing unmerged files hold the checkout. A
non-conflicting edit rides over the update (control).
Tests, on upstream 15ebd85cd:
- 5 of the 7 new cases fail against the previous session-update; the
unmerged-files guard and the control pass on both.
- Two mutants are each caught by one new case: dropping the refs/stash
fallback, and resetting when the edits cannot be found.
- session-update-autostash, session-update-stages,
session-update-hook-hold and team-mode pass 63/0 with
`--timeout 60000`. At bun's 5 s default under heavy load (one
reading: load average 169), the three shared files timed out 8 tests
on this branch and 17 with the previous script.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(session-update): trust only git's autostash id; owe setup on a stop
An independent review of the autostash recovery (Codex gpt-6-astra,
high effort, verdict BLOCK high=1 med=2) found three defects on its rare
paths. All three are fixed here, each with a case that failed first.
- [high] The refs/stash fallback could erase local edits. When git's
messages were unavailable, recovery took any change to refs/stash as
its own autostash. refs/stash is shared with every worktree: if a
sibling pushed a stash while refs/stash.lock kept git from storing
this one, recovery took the sibling's entry and reset the checkout,
erasing edits nothing held. Now only git's own printed id counts. A
missing id resets nothing: the markers stay, the run logs
PULL_FAILED. Recovery needs git's messages, so when the temp file for
them cannot be created the update is held before the merge
(HELD temp-file-unavailable), not merged blind.
- [med] A stop after the checkout moved lost the setup it owed. The
failure recorded only the pull reason. Once the person resolved the
conflict, the next check saw an unchanged HEAD and no pending stage,
logged UP_TO_DATE, and never set up the new revision. Now a failure
after HEAD moved records `setup` as a pending stage, retried at once.
The unmerged-files check holds it until the conflict is resolved, and
the pull reason is the stage's reason, so the session-start line says
what to resolve.
- [med] An unreadable index read as "no conflicts". Both `git ls-files
-u` checks discarded the exit status, so a failed read after a
conflicting pop (which git exits 0 for) let setup run over the markers.
Now a failed read stops the update with PULL_FAILED "cannot read the
index", before the merge or after it.
Files:
- bin/gstack-session-update: autostash_recover drops the refs/stash
fallback (and STASH_BEFORE). The temp-file hold. The ls-files exit
status checked at both points. The pending setup stage on a failure
after HEAD moved.
- test/session-update-autostash.test.ts: a shim(fx, name, tool, body)
helper; the fallback case now expects a refusal; the refusal case runs
on through resolution to setup; three new cases (unreadable index
before and after the merge, no temp file for git's messages).
Tests, on upstream 15ebd85cd:
- The 5 changed or new cases failed on the previous commit, each on its
defect: refs/stash trusted and recovered; UP_TO_DATE with no setup
after resolution; UPDATED over an unreadable index, before and after
the merge; a blind merge with no temp file.
- Against upstream's own session-update, 8 of the block's 10 cases fail.
- session-update-autostash, session-update-stages,
session-update-hook-hold and team-mode pass 66/0 with
`--timeout 90000`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(session-update): reap heartbeat and its sleeper on exit
The lock heartbeat subshell left its sleep 300 child orphaned when the
updater exited, so heartbeats accumulated across sessions. Track and
reap the heartbeat job (with a job-table fallback for signals between
fork and $!), give the subshell its own exit trap that kills and waits
its sleeper, and map HUP/INT/TERM to exits so the EXIT trap always runs.
Adds a fixture-driven regression test.
* test(session-update): repin the lock trap and heartbeat to #3191's cleanup shape
Intentional pin change: test/session-update-autostash.test.ts 'reclaim is
TOCTOU-safe' and 'EXIT trap is ownership-checked' pinned the one-line
EXIT trap and the 'while :; do sleep 300; ...' loop that #3191 (Jess
Sullivan) replaces with cleanup_session_update and a 'sleep 300 & wait'
heartbeat. The pins still assert the ownership-checked rm -rf, the EXIT
trap, MYPID, and that the heartbeat is killed.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(session-update): move installs only through gstack-ff-update; extract hooks without tar (#3184)
Item 2 (#3189, #3191 adopted in the previous commits) and item 3 of the
fix-wave plan.
bin/gstack-ff-update <dir> <rev> is now the only code that moves an
install's tree. Inside an install-scoped lock (absolute git common dir,
the updater's TTL and mv-aside reap, a heartbeat reaped on exit) it
captures the working tree and the staged state through private indexes,
carries edits that merge cleanly (as an autostash pop would), lets the
regenerable SKILL.md/sections footprint take the target when it
conflicts, and shelves any other conflicting edit, staged change or
unmerged file into refs/gstack/rescue/<oid> (first parent the pre-update
HEAD, second the staged state; compare-and-create; gstack rescue
identity). The move is a two-way read-tree on the private index, so a
late edit or an untracked file in the way refuses with
autostash-unrecoverable and changes nothing. It sources nothing so the
held-install recovery can fetch it from the new revision.
gstack-session-update calls it instead of merge --autostash, holds a
checkout with unmerged files (unmerged-files:), and names shelved edits
at session start at most once a day with inspect, export-the-delta and
delete commands. The incoming revision is extracted for the hook check
through a private index and checkout-index with core.symlinks=false,
never tar (MSYS tar cannot create connect-chrome before its target), and
the held reason carries the failing command's flattened, control-free
stderr. Held lines print before the stage line, one case per reason
with its anchor, every path shell-quoted, no setup fix while unmerged
files exist. docs/troubleshooting.md gains the held-install recovery
forms (Git Bash, PowerShell 5.1, trial and go-back) and entries for each
new line.
design: kept_ref is refs/gstack/rescue/<oid>, refs/stash is never
touched, the quiet-merge cases become a pre-existing-ref refusal and its
recovery, pre-existing unmerged files are a HELD unmerged-files, and the
git shim pins the real binary through git --exec-path.
Intentional pin changes in existing tests:
- test/session-update-stages.test.ts: printed paths are shell-quoted;
the bun-too-old fix runs gstack-ff-update instead of git pull.
- test/session-update-hook-hold.test.ts: the order pin looks for
'bash "$FF_UPDATE"' instead of 'merge --ff-only'; the
hook-check-unavailable fix no longer recommends git pull --autostash;
installedUpdater copies gstack-ff-update beside the updater.
Reported by wengweiling (#3184).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(gstack-upgrade): Step 4 fast-forwards through gstack-ff-update (#3189)
Item 2 of the fix-wave plan, kept in its own commit so PR 1b can be
rebased onto PR 1a (which edits only Step 4's Bun floor-check line).
Step 4's `git pull --ff-only --autostash` had the same hole the
auto-updater had: a conflicting autostash exits 0 and leaves conflict
markers in the install, and the skill printed FF_OK. It now runs
bin/gstack-ff-update . origin/main after the fetch and the floor check:
exit 0 runs setup (a rescued line is relayed with its inspect, export
and delete commands), exit 4 (not a fast-forward) is the only way into
the gated reset fallback, and any other refusal stops with nothing
changed. The footprint discard moves to the reset fallback, ahead of
its stash, where the warning text already promised it.
Intentional pin changes:
- test/upgrade-template-pins.test.ts: the ff-before-reset pin looks for
'bash bin/gstack-ff-update . origin/main'.
- test/gstack-upgrade-fresh-shell.test.ts: the C9 fence marker is
'bash bin/gstack-ff-update'; the gstack-like fixture ships the bin.
- test/upgrade-setup-recovery.test.ts: the git-path fixtures ship
gstack-ff-update (a stub where git itself is a stub).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup.ps1): run under Windows PowerShell 5.1's legacy argument passing (#3130)
Item 4 of the fix-wave plan. Windows PowerShell 5.1 strips the double
quotes inside native arguments, so the bash -c script setup.ps1 handed
Git Bash arrived broken ("unexpected EOF while looking for matching").
The script now holds no double quote: `set -f; IFS=; mapfile -d '' -t
argv < $1; rm -f -- $1; exec ./setup ${argv[@]}` (empty IFS and no
globbing keep $1 and each argv entry whole). That form drops an empty
argument, so setup.ps1 refuses one before anything runs
(SETUP_PS1_EMPTY_ARGUMENT, with its troubleshooting entry).
test/setup-ps1.test.ts runs the adversarial arguments under legacy
passing (pwsh with $PSNativeCommandArgumentPassing = 'Legacy', and
powershell.exe itself on Windows) with a space in TMPDIR, plus the
empty-argument refusal. Intentional pin change: the pinned bash -c
line in "passes arguments NUL-separated through a private file to a
constant bash script" now names the quote-free script and asserts it
holds no double quote.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup): register hooks at the $HOME path when CLAUDE_CONFIG_DIR links back to it
A per-session CLAUDE_CONFIG_DIR whose skills symlink to ~/.claude/skills
passed the split-brain guard, so its temporary path was written into the
global settings.json and the hooks broke once the session directory was
removed. Fall back to $HOME/.claude/skills/gstack whenever both spellings
resolve to the same tree.
Fixes#3180
* fix(setup): one sourced helper picks the hook root for setup and gstack-memorable (#3180)
bin/gstack-memorable carried a verbatim copy of setup's old canonical-root
block, so `gstack-memorable enable` under a per-session CLAUDE_CONFIG_DIR
still baked the session path into settings.json after #3181 fixed setup.
The choice now lives in bin/gstack-claude-root.sh
(gstack_canonical_claude_root), sourced by both.
Intentional test changes:
- test/setup-hook-canonical-paths.test.ts: #3181's source-slicing block
test is rewritten to source the helper (with a spawnSync timeout, which
the sliced version lacked and the tripwire flags); the
"honors CLAUDE_CONFIG_DIR" pin moves from setup to the helper, and a new
pin requires both callers to source it. Adds a no-$HOME-install case.
- test/setup-hook-syntax-gate.test.ts: the hook-section slice starts at the
new assignment and the harness sources the helper.
- test/setup-claude-code-migration.test.ts, test/team-mode.test.ts: the
partial-checkout fixtures copy the new helper setup sources.
Reviewer test: gstack-memorable enable under a per-session config dir that
links back to ~/.claude registers the $HOME path (fails on main).
Builds on #3181 by NetrioGit.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup): remove 1.31-era unprefixed Cursor skill folders (#3133)
A 1.31 setup run from a checkout under ~/.cursor/skills linked unprefixed
<skill>/ folders there, each holding a SKILL.md symlink into the checkout.
Current setup links gstack-<skill>/ folders, and the retired-skill prune
only looks at gstack-* names, so the old folders stayed: Cursor loaded
autoplan, review and the rest twice, or kept dangling links once the
checkout moved.
Run the Claude flat-name cleanup on ~/.cursor/skills as well. Cursor
installs only gstack-* names, so no prefix gate is needed, and the helper
removes only entries proven to link into gstack (#2119), so user-owned
folders stay. It runs after linking, so a run that fails before the new
links exist keeps the old folders. Reported by @andrewkjankowski in #3084.
Fixes#3133
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(setup): name the skills dir in the flat-name cleanup line (#3133)
`./setup --host cursor` now runs the flat-name cleanup on
~/.cursor/skills as well as ~/.claude/skills, so the "cleaned up old
entries" line says which directory the folders were removed from.
Reviewer test for #3152 (szsunyuan): a real dir whose SKILL.md links into
gstack loses only that link and keeps the user's file; SKILL.md links into
a sibling repo named gstack-fork, a relative link, and a dangling link
outside any gstack checkout are all kept; the printed line names the
removed folders and the Cursor skills dir.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup): install Chromium with `bun x`, and name exit 127 for what it is (#3131)
A Bun installed with winget ships no `bunx`, so setup's
`bunx playwright install chromium` exited 127 and was reported as
"offline, proxy, or blocked download?". setup now runs
`bun_cmd x playwright install chromium` through its existing bun resolver
($BUN_CMD), and bin/gstack-browser-ensure runs the bun it found on PATH
with `x`. Exit 127 gets its own text naming the resolved bun, Bun from
bun.sh, and the skip commands for Git Bash and PowerShell; other codes
keep the network hint. New troubleshooting entry:
#chromium-install-exit-127.
Intentional test changes:
- test/setup-playwright-best-effort.test.ts: the installer stub is now a
`bun_cmd()` stub (was `bunx()`), its mark renamed bun-x-called and now
records the args; the block under test calls bun_cmd. New winget-shaped
cases (bun on PATH, no bunx anywhere) run setup's real bun_cmd.
- test/gstack-browser-ensure.test.ts: the fixture is winget-shaped (the
`bun` stub handles `x`, no `bunx` on PATH); the exit-7 pin now reads
`<stub>/bun x playwright install chromium exited 7 (...)`.
--help in gstack-browser-ensure prints the comment header only (3,24p).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows): prove setup.ps1 on PowerShell 5.1 and the held-install recovery natively (#3130, #3184)
windows-setup job:
- setup.ps1 joins the path filter (with bin/gstack-ff-update,
bin/gstack-claude-root.sh, bin/gstack-browser-ensure,
docs/troubleshooting.md and test/setup-ps1.test.ts).
- powershell.exe must be Windows PowerShell 5; test/setup-ps1.test.ts runs
with a space in TEMP and must report exactly 4 pass, 0 fail, 1 skip
(the Linux-only missing-prerequisite case).
- A copy of the built checkout under a path with a space installs through
`powershell.exe -File setup.ps1 --host codex`.
held-install-journey job (new, parallel):
- origin's main is this PR's tree on top of the v1.91.101.0 tree
(47d639abf); fix-branch adds one file.
- A prefix-mode v1.91.101.0 install at the runner's ~/.claude path in
three states (clean, dirty-conflicting, already-unmerged), with
auto_upgrade=true and the throttle cleared: the old updater must log
`HELD hook-check-unavailable`; the PowerShell recovery form, read
verbatim from docs/troubleshooting.md and run under powershell.exe,
must reach main with every local edit (only those) in one rescue ref.
The dirty state runs it with its .\setup.ps1; the others replace that
step with a marker.
- The trial and go-back forms move the install to fix-branch (detached)
and back to main.
- Only then a later release whose symlink sorts before its target is
pushed, and the new updater must log UPDATED and reach it.
- Both jobs assert the exact list of cases that ran.
The journey steps ran locally on Linux with pwsh in Legacy argument
mode as powershell.exe, a git exec-path whose ../../../bin/bash.exe is
bash, and a failing tar standing in for MSYS tar (all 9 cases passed);
the windows-latest run itself happens on the PR.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(ff-update): a killed step-4 run fails the status check instead of the type check
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows): the held-install job runs without the bun cache step
The cache key line is a secret-scanner false positive on added lines
(env.kv); the fixture's own setup installs its packages either way.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(fixtures): register #3191's heartbeat fixture as free
test/free-fixtures.test.ts failed on the frozen-branch Ubicloud run:
test/fixtures/session-update-heartbeat.sh (adopted with #3191) was in no
paid touchfile and not in FREE_FIXTURES. Its only consumer is
test/session-update-heartbeat.test.ts.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(session-update): leave the bun-version-unreadable banner case to item 11 (PR 1a)
PR 1a owns the bun-version-unreadable hold (BUN_VERSION_UNREADABLE), its
banner case and its troubleshooting entry; this branch is rebased onto 1a.
Drops the case, the docs entry and the banner test this branch had added.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup.ps1): resolve Git Bash in the shared order, with GSTACK_BASH as an alias and a BASH_UNAVAILABLE refusal
Follows lib/script-invocation.ts (Lane C, PR 2): GSTACK_GIT_BASH is the
override and GSTACK_BASH its deprecated alias at the same precedence;
when both are set and differ GSTACK_GIT_BASH wins and one warning prints.
An override that does not exist is refused, never skipped. Without one:
the install git --exec-path belongs to (behind a scoop shim, or a
portable Git), the folders around git.exe, %LOCALAPPDATA%\Programs\Git,
%ProgramFiles%\Git, and last a bash on PATH whose uname -s reports MSYS;
WSL's bash (System32, WindowsApps) is rejected. A miss lists every
candidate with its rejection, then the PowerShell user-variable and
~/.claude/settings.json env recipes (BASH_UNAVAILABLE, #bash-unavailable).
test/setup-ps1.test.ts gains a 14-row pwsh-on-Linux table with every
location injected (override, alias, both set, missing override and alias,
scoop shim, per-user, portable and machine-wide Git, MSYS PATH bash, WSL
and non-MSYS rejections, missing); 11 rows fail on main. The rows mirror
Lane C's table in test/script-invocation.test.ts; they are not wired to
it, since that branch is not available here. The Windows job's expected
skip count for this file moves from 1 to 15 (the table is Linux-only).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup.ps1): give the empty-argument refusal its result code (SETUP_PS1_EMPTY_ARGUMENT)
Adds the row to lib/result-codes.ts (anchor #setup-ps1-empty-argument,
which setup.ps1 already prints). bin/gstack-doctor-components.sh is
regenerated from the table (generated; resolved by regeneration at merge).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows): silence SC2016 on the PowerShell version probe (the $ is PowerShell's, not bash's)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows-setup): give tar a POSIX path for the spaced checkout
MSYS tar reads `D:\a\_temp/...` as host:path (rsh syntax) and fails with
'Cannot open: No such file or directory' before setup.ps1 runs. The copy
target now goes through cygpath -u; setup.ps1 still gets the Windows form.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows-setup): dereference symlinks when copying the spaced checkout
MSYS tar cannot extract connect-chrome, a symlink that precedes its target
(the #3184 failure mode), so the copy died before setup.ps1 ran. tar -h
stores the target instead.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(windows): one Git Bash resolver for gstack's shebang bins (#3197)
Windows has no shebangs, and gstack had three conflicting bash lookups:
the hooks fell back to a bare PATH `bash` (often WSL's launcher), the
gbrain sync checked three fixed paths, and setup.ps1 walked up from
git.exe. lib/script-invocation.ts is now the only TypeScript resolver:
GSTACK_GIT_BASH (GSTACK_BASH as a deprecated alias, same precedence,
warning when they differ, a missing value refused), bash next to
`git --exec-path` (scoop, per-user, portable Git), the known install
paths, then a PATH bash only when `uname -s` reports MSYS/MINGW. WSL
launchers are rejected unprobed. A miss is BASH_UNAVAILABLE, listing
every candidate with its rejection reason.
Bun-shebang bins run under Bun (process.execPath, or the PATH bun inside
a compiled binary). Hooks' runBin resolves through a state-root cache
keyed by git.exe path and mtime, written by temp file plus rename, so
the hot path spawns nothing extra; the override is never cached.
wtreeFingerprint({cwd, timeoutMs}) returns {tree} | {error, kind} with
GIT_OPTIONAL_LOCKS=0 and 40-64 hex ids; the consumers move next.
Intentional pin change: test/gbrain-spawn-windows-shell.test.ts expects
forward-slashed bash paths (WIN_BASH and the GSTACK_BASH override), the
form the shared resolver returns because Bun's spawnSync on Windows
returns ENOENT for a backslash exe path containing spaces.
The copied-tree adapters in test/timeline-stop-hook-slug.test.ts and
test/plan-tune-cathedral.test.ts list the two modules spawn-bin.ts now
imports; the new fixture is registered in test/helpers/free-fixtures-data.ts. bin/gstack-doctor-components.sh is
regenerated for the new result-code row.
Reported by @exGeni.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(windows): fingerprint and gstack bins through the shared invocation (#3197)
bin/gstack-wtree was spawned by path in lib/regen.ts, lib/gate-diff/git.ts,
lib/restamp.ts and bin/gstack-evidence; gstack-slug in restamp, gate-diff
and evidence; gstack-redact in the pregate secrets check; and a bare
`bash -c` in regen, the lane selection manifest and gstack-evidence run.
On Windows each one failed to launch. All now go through
lib/script-invocation.ts, and each fingerprint consumer keeps its fail
direction while saying why:
- gstack-regen check: incomplete, `cannot fingerprint the working tree
(gstack-wtree exited 1: <helper's own repair>)` instead of
`(gstack-wtree failed)`; write keeps the registry label as its run id.
- gstack-gate-diff: `+nowtree` candidate, with the cause.
- gstack-restamp: RESTAMP_CONFLICT carrying the launch or exit detail
(Windows printed `()` before).
- gstack-evidence: records without wtree (grades STALE) and warns once;
SHA-256 repositories now get a 64-hex fingerprint.
lib/regen.ts keeps a string-returning wtreeFingerprint(repoRoot) wrapper
for lib/pregate/context.ts and lib/pregate/index.ts (files #3190 changes);
item 10b migrates them. test/script-invocation-tripwire.test.ts fails on a
new by-path or bare-bash spawn under lib/, hosts/ or a Bun bin; five sites
outside this change are listed with their owners and may only shrink.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): keep framework route paths from a selection manifest (#3176)
laneFileSet parsed manifest output with `[\w.-]+` path segments, so
`app/(shop)/[id]/page.test.ts` came back as `page.test.ts`. The selected
test then matched no platform lane, its remote receipt obligation
vanished and it fell back to a local run. manifestTestPaths keeps route
segments whole (`(group)`, `[id]`, `[...slug]`, `[[lang]]`, `@slot`,
`$param`, `+page`), reads every path-shaped token on a line (JSON
arrays, quoted, `path:line`, parenthesized), and decides what is a test
file with the import graph's own isTestFile, so a test-file rule change
there (bats, #3177) reaches manifests without a second regex. A manifest
that cannot start is "unknown" (widens), like a non-zero exit.
This is the manifest-parser half of #3176 by @vocodestudios; the
import-graph half (tsconfig aliases, Next.js route mapping) ships in a
separate PR. test/pregate-manifest-paths.test.ts drives the CLI with a
bracketed route test in the fixture's Windows-only lane and asserts its
requires-remote obligation; it failed on main (requires_remote was []).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows): windows-pregate-e2e drives the #3197 paths natively
A windows-latest job (Bun 1.4.2) builds a fixture repository and runs
gstack-restamp --dry-run, gstack-regen check and write, gstack-evidence
run and gstack-gate-diff from their TypeScript entry points, asserting a
real tree fingerprint each time; times a question-log hook cold and warm
and checks it cached its Git Bash resolution; and checks that a missing
GSTACK_GIT_BASH refuses with BASH_UNAVAILABLE and lists the candidate.
The journey runs twice: under the runner's Git for Windows and under a
pinned PortableGit 2.56.0.2 (SHA-256 verified), found only through
`git --exec-path`. gstack-pregate run joins it with item 10b. The workflow is registered in
scripts/test-pr-profile.ts FREE_ONLY_PR_FILES (no paid case reads it), recorded
as a non-behavioral HARNESS_VERSION decision in scripts/harness-version.json.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(setup.ps1): resolve Git Bash by the shared fixture table (#3197)
test/setup-ps1.test.ts now drives setup.ps1 through every row of
test/fixtures/windows-bash-resolution.json, the table that pins
lib/script-invocation.ts, instead of a hand-mirrored copy. Two rows
failed and are fixed here:
- an override and alias that differ only in slash direction no longer
print the differ warning;
- the root git --exec-path names is also searched for usr\bin\bash.exe
(Git for Windows on arm64).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(windows): isolate the no-bash case and launch pregate as the product does (#3197, #3176)
windows-free-tests run 38813751242 failed two tests this layer added. Both
were fixture defects on a real Windows host, not product defects:
- gbrain-spawn-windows-shell "returns null when Windows has no bash" stubbed
only `exists`. The resolver's PATH step asks the real Bun.which and found
the runner's MSYS bash, which is correct. The case now also stubs
`which` and `gitExecPath`, so it really means "no bash anywhere".
- pregate-manifest-paths spawned the extensionless bin/gstack-pregate
directly. CreateProcess cannot exec a shebang, so nothing ran and stdout
was "". It now launches through lib/script-invocation's runScriptSync,
gstack's own Windows invocation, so the case runs the manifest lane end
to end on Windows instead of being excluded.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows): the missing-bash step survives the refusal it expects (#3197)
GitHub runs `shell: bash` as `bash -eo pipefail`, and the step's own
`set -uo pipefail` does not turn -e off. So when gstack-restamp refused, as
the step expects, `OUT=$(...)` aborted the script before `CODE=$?` and before
any output was printed: exit 1 after 0.5 s with nothing in the log (PR #3209,
job 116729693492). The capture is now `OUT=$(...) && CODE=0 || CODE=$?`.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(pregate): the manifest-lane case expects the host's own remote lanes (#3176)
Once 8b2f297cc made the case run on Windows, windows-free-tests run
38824886195 (shard 4) showed the expectation itself was Linux-only. pregate
owes a lane remotely when its runner platform is not the host's
(lib/pregate/workflows.ts). On a Windows host the fixture's Windows lane
runs locally, and the Ubuntu `free-tests.yml/unit` lane is the remote
obligation; that is the record Windows produced.
The case now derives the owed lanes from the host the same way. On Windows
it also requires `ran: node --test 'app/(shop)/[id]/page.test.js'`: there the
route reaches the local run only through the manifest's whole path. With a
cut manifest path (page.test.js) the local set is empty, checked through
buildContext({ platform: 'win32' }) + selectLanes.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(windows-setup): expect 31 skipped setup.ps1 cases now that the shared table drives it
Layer 2 drives setup.ps1 through the 16 shared rows of
test/fixtures/windows-bash-resolution.json; like the 14 existing resolution
rows they run under pwsh on Linux and skip on Windows. The case list is still
asserted exactly (4 pass, 0 fail, 31 skip).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(ship-measure): give the CLI tests a private HOME (#3162)
Every bun run test left ~/.gstack/projects/ship-measure-cli-*/evals and
sweep-cli-fake-*/evals in the developer's real home, and the free-suite
runner flagged them ("real home changed ... Give the writer a private
HOME/GSTACK_HOME"). ship-measure's diagnostic-dir check calls
getProjectEvalDir(), which builds the eval dir from os.homedir(), and
these two CLI tests passed the real HOME while overriding only the
state root.
Both now set HOME and USERPROFILE to the test's own state dir. The
sweep test also runs on the Windows lane, where os.homedir() reads
USERPROFILE. test/ship-measure.test.ts:79 already gives its config test
a private HOME the same way. getProjectEvalDir() itself is unchanged:
whether eval history should follow GSTACK_HOME is left open in #3162.
Fixes#3162
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(ship-measure): prove the sweep CLI never writes under the parent HOME (#3162)
Reviewer test for #3163 (adopted from y$un_, forrest.sun527): points the
parent HOME at a sentinel with a stub global gstack-slug and asserts no
.gstack dir appears there. Fails on 47d639a (the sentinel gets
.gstack/projects/leaked-slug/evals); passes with #3163.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(redact): isolate fixture git from inherited hooks
Fixture git was spawned with the parent environment, so a developer's
core.hooksPath ran on the local push and rejected it (#2967). The
helper blanks the global and system files and drops GIT_CONFIG_COUNT
and GIT_CONFIG_PARAMETERS. A hooksPath set in the fixture repo still runs.
* test(redact): blank GIT_CONFIG_GLOBAL with /dev/null on every platform (#2967)
Follow-up to #3156 (adopted from Lockyer228): Git for Windows rejects
GIT_CONFIG_GLOBAL=NUL (the repo convention is EMPTY_GLOBAL_GIT_CONFIG =
'/dev/null' in lib/cso/process.ts), so both fixture helpers use /dev/null
everywhere. Reviewer test: a hooksPath in the default global files under
HOME/.gitconfig and XDG_CONFIG_HOME/git/config cannot reject the fixture
push; it fails with the inherited environment (the 47d639a behavior) and
passes with the isolated env.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix: gstack-config compares whole root paths and prints a runnable recovery command
- report_root_disagreement compared word-split values, so two variables naming
the same directory with a space were reported as disagreeing. Compare each
complete value instead.
- The privacy-key recovery hint single-quoted the root and left the script
path bare; an apostrophe or space made it unrunnable. Quote with printf %q.
- On Bash 3.2 (macOS /bin/bash) a failed `.` under set -e exits before the
`||` fallback, so a missing gstack-state-root.sh exited 1 silently and
test/state-root-resolver-failure.test.ts failed there. Check readability first.
- The merge fixture now lives under a path with a space and an apostrophe,
executes the printed command, and asserts same-directory variables agree.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(config): pin the %q-quoted recovery command and run it from a spaced install path
Follow-up to #3186 (adopted from davidfragnoli-lang). Intentional pin
change: the fix line's GSTACK_STATE_ROOT='<legacy>' pin becomes the exact
bash printf %q form of the legacy root (the PR loosened it to a prefix
check; this restores an exact pin) and the original test name is kept.
Reviewer test: copy bin/ to a path containing a space and an apostrophe;
the printed fix: command runs cleanly and flips the merged value. Fails on
47d639a (unquoted $_SELF), passes with #3186.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(gstack-gbrain-sync): fail when a star gitignore already ignores the pin
ensureGbrainSourceGitignored appends .gbrain-source even when git
check-ignore already excludes that path. The extra line dirties a
tracked ignore-everything gitignore.
* fix(gstack-gbrain-sync): skip the pin line when git already ignores it
ensureGbrainSourceGitignored asked only for a literal .gbrain-source
line. An ignore-everything star already excludes the pin, and the extra
line left the tracked gitignore dirty.
* fix(gbrain-sync): only a tracked .gitignore can stand in for the pin line
Follow-up to #3178 (adopted from KuroChen). The skip now requires
`git -c core.excludesFile= check-ignore -v` to name a tracked .gitignore
(not global excludes, not .git/info/exclude, not a negation), so a pin
ignored only on this machine still gets the shared line teammates need
(#1384). Tests: the two git init spawns get timeouts (they failed the
spawnSync tripwire), fixtures isolate HOME/XDG_CONFIG_HOME, and the PR's
star-gitignore fixture stages its .gitignore (intentional fixture change:
the contract is a tracked file). Reviewer tests: global excludes only,
info/exclude only, an untracked star .gitignore, and a re-include each
still append; all three fail on the PR head.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(skill-end): log the completion event before the final drain (#3198)
gstack-skill-end drained and pushed before it appended its own completed
timeline event, and gstack-timeline-log backgrounded its enqueue, so a
full-tier end boundary returned with its latest event unpushed. The
completion log now runs before the drain and the logger waits for its
enqueue (one config read and a spool write; it exits early when sync is
off or the session is unattended). Every consent, secret-scan and
queue-lock gate is unchanged; the stale "local-only, never sent anywhere"
comment is replaced.
Patch and regression test from Kkkkkuro (#3198): 2 pass / 5 fail on
47d639a, 8/8 with the fix. Reviewer test: with artifacts_sync_mode off the
completion is written locally with no queue entry and no push.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): map Next.js route paths and tsconfig path aliases to their tests
QUOTED excluded ( ) [ ] +, so a test naming app/(app)/page.tsx in a string
never matched. resolveRef never read tsconfig compilerOptions.paths, so an
import through @/ resolved to nothing. Both were PREGATE_NO_LANE false
negatives in a Next.js App Router repo whose tests did name the files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(pregate): TypeScript alias precedence, relative extends and a no-lane explanation
Follow-up to #3176 (adopted from vocodestudios). Path aliases now follow
TypeScript's choice: an exact pattern, else the wildcard with the longest
prefix, targets tried in order. When the chosen pattern resolves nothing,
every plausible reading (other matching patterns, baseUrl, the repo root)
gains the edge, so uncertainty selects more tests, never fewer. Relative
extends chains are followed up to MAX_TSCONFIG_EXTENDS (4) hops, with
baseUrl and paths resolved against the config that declares them.
Trailing commas are dropped by the JSONC tokenizer (never inside a string)
instead of a whole-text regex.
A touched file with no lane now gets explain lines naming the import
specifiers in test files that resolved to no repo file, any extends hop
that was not followed (with the limit), and the hint to declare the file
under dependencies or report the resolver gap. The lines ride testsFor's
provenance, which lanes already pushes to --explain.
Reviewer tests: overlapping aliases in both key orders, exact vs
wildcard, target fallback, the union case, a two-hop extends chain, a
string containing ',]', and the depth-limit explanation. Five fail on the
PR head; all 12 pass. The manifest-parser half of #3176's follow-up
(lane-selection.ts) ships in PR 2.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(browse): reap PTY children on agent shutdown
* fix(browse): reap a terminal-agent PTY's whole process group at shutdown (#3147)
Follow-up to #3148 (adopted from Y4NN777). The PTY child leads its own
session and process group; its identity (pgid, sid, leader start time) is
recorded at spawn and stays checkable after the leader exits. Disposal
schedules a group reap after PTY_SHUTDOWN_GRACE_MS that, unlike the
direct-child SIGKILL fallback, is not cancelled when the leader exits, and
shutdown reaps every pending group before exiting, so descendants that
ignore SIGHUP no longer outlive the agent. Only proven members are
signalled: same pgid and sid, started no earlier than the leader, and
nothing at all when the leader's PID is held by a process with another
start time. Linux only (/proc); other platforms keep the direct-child
behavior. During the shutdown grace the server answers 503 and no new PTY
is spawned.
Test changes to the PR's own test (intentional): the agent is spawned
with process.execPath and the PTY child traps INT TERM HUP, so the case
proves the SIGKILL fallback instead of passing on the kernel hangup.
Reviewer tests: a HUP-immune grandchild is dead within the grace plus 1 s;
an early-exiting leader's surviving descendant is reaped; a session that
completed before shutdown still has its group reaped; unit cases for a
foreign group and a reused leader PID. All four integration cases fail on
47d639a; three fail on the PR head.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* build(deps): bump the github-actions group with 5 updates
Bumps the github-actions group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [actions/upload-artifact](https://github.com/actions/upload-artifact) | `7.0.1` | `7.0.2` |
| [actions/download-artifact](https://github.com/actions/download-artifact) | `8.0.1` | `8.0.2` |
| [actions/setup-node](https://github.com/actions/setup-node) | `7.0.0` | `7.1.0` |
| [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | `2.4.4` | `2.5.0` |
| [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) | `4.38.2` | `4.38.3` |
Updates `actions/upload-artifact` from 7.0.1 to 7.0.2
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/043fb46d1a93c77aae656e7c1c64a875d1fc6a0a...cf430e030ddbb5b0abf93d22962f4752f3646cd9)
Updates `actions/download-artifact` from 8.0.1 to 8.0.2
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c...9000827ccba6bdab643e8b6fd33ac0654aef8333)
Updates `actions/setup-node` from 7.0.0 to 7.1.0
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/820762786026740c76f36085b0efc47a31fe5020...949feb2413d6458794dcd2491c4babbbce0c15c1)
Updates `ossf/scorecard-action` from 2.4.4 to 2.5.0
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](https://github.com/ossf/scorecard-action/compare/2d1146689b8cda280b9bc96326124645441f03bc...fa7117db83c52d787ae5a89f350999701505d78e)
Updates `github/codeql-action/upload-sarif` from 4.38.2 to 4.38.3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2...24c54180a607b1449ed407dd24f251e4e9147c8d)
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: 7.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
- dependency-name: actions/download-artifact
dependency-version: 8.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
- dependency-name: actions/setup-node
dependency-version: 7.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions
- dependency-name: ossf/scorecard-action
dependency-version: 2.5.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions
- dependency-name: github/codeql-action/upload-sarif
dependency-version: 4.38.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(model-policy): track the upload-artifact v7.0.2 pin from #3175
Intentional pin change: test/model-policy-workflow.test.ts asserted
actions/upload-artifact@043fb46d…; dependabot #3175 moves the workflow to
cf430e03… (v7.0.2, verified against the upstream tag). The pin tracks the
workflow. #3175's free-tests.yml hunk is left out of this PR (free-tests.yml
is a #3190 file; it is re-bumped in PR 5).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(model-policy): its upload-artifact pin matches the eval workflows' pin
Reviewer test for dependabot #3175: the model-policy workflow's single
upload-artifact pin equals the pin evals.yml, evals-periodic.yml and
windows-free-tests.yml use, so a group bump that misses one workflow (or
the hard-coded pin above) is caught here.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* build(deps): hold Playwright minor/major bumps behind the windowsHide patch (#2923)
Dependabot #2923 bumped playwright to ^1.64.0 and dropped the
patchedDependencies entry keyed to playwright-core@1.62.1, which keeps
windowsHide on Windows (#2160, #1989). The bun ecosystem now ignores only
semver-minor and semver-major updates for playwright and playwright-core;
patch updates still flow. The 1.64 migration (re-key the patch, the
Dia/cookie qualification pins, the arm64 artifact name) is filed with
owner Garry, revisit 2026-11-15. Test fails on 47d639a (no ignore rule).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(readme): drop the stale skill lists users pasted into CLAUDE.md (#3169)
README's install prompt and troubleshooting block each carried a skill
list for CLAUDE.md; both were stale (18 shipped skills missing) and they
disagreed. Claude Code lists installed skills itself, so both now keep
only the /browse rule, and the troubleshooting entry says to delete an
old pasted list. New free test: any comma-separated skill list in
README.md or CLAUDE.md must name exactly the shipped skills (with a
negative control for the detector). Fails on 47d639a; passes now.
Reported by the #3169 issue author. The matching doctor warning for
pasted lists ships in PR 5.
Intentional pin change: test/test-value-bar.test.ts no longer expects the
README skill list to name /test-audit twice; it now expects that list to
be gone (0 occurrences), the registration this commit removes on purpose.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* chore(osv): image-size has a fix; html-to-docx's ^1.0.0 pin blocks it (#2753)
The image-size ledger said no fixed release exists. OSV lists 2.0.3 as
fixed for GHSA-5p2g-fcmc-qvqq and GHSA-w3rx-r6r6-pgpr (checked against
api.osv.dev), but html-to-docx@1.8.0 pins image-size ^1.0.0 and there is
no fixed 1.x, so the fix is a cross-major override. Both entries now say
so and name the upgrade trigger; the 2026-11-30 expiry is kept. New test
checks the wording and that bun.lock still shows the stated pin (it fails
on 47d639a). Correction first raised on #2753 by sonukapoor.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* feat(ios-qa): forward GSTACK_IOS_LAUNCH_ENV to devicectl launches (#1796)
Reimplements only the launch-environment half of #1796 (credit
Bmathews721; the session-cache half is superseded by #3132's design and
had state-root and symlink-write problems). devicectl.ts parses
GSTACK_IOS_LAUNCH_ENV as a JSON object of string to string;
launchEnvArgs() returns the --environment-variables argv (empty when
unset or {}) and launchApp passes it before the bundle id. Invalid JSON, a
non-object, a non-string value, a bad name or a key in the debug bridge's
reserved GSTACK_ namespace refuses before any launch with the new result
code IOS_LAUNCH_ENV_INVALID (the detail names keys and types, never
values). launchEnvArgs is exported for the forced-relaunch path in
tunnel-bootstrap.ts.
Adds the result-code row (bin/gstack-doctor-components.sh regenerated by
gen:skill-docs), a troubleshooting entry under its exact text, the
pregate-no-lane entry's explain note, and the how-to section with an
example. New test fails on 47d639a (module load: no parseLaunchEnv).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(deps): declare sharp and clear two transitive advisories
sharp is imported in four files, including browse/src/screenshot-size-guard.ts,
and test/dependency-security.test.ts asserts a >=0.35.4 floor on it and loads
it. It was declared in no dependency field, reaching the tree only through
@huggingface/transformers with the overrides pin forcing the version. Declare it
at ^0.35.4, matching the floor that test already asserts.
Upgrade @huggingface/transformers to ^4.3.0, which clears sprintf-js@1.1.3 and
aligns the sharp override with what the parent declares: 4.2.0 declared
sharp ^0.34.5 while the override pins 0.35.5, which is outside that range, and
4.3.0 declares ^0.35.4.
Upgrade @anthropic-ai/claude-agent-sdk to 0.2.141, which clears
@anthropic-ai/sdk@0.81.0.
The existing overrides entry for sharp is left in place.
* test(deps): sharp is declared and its override satisfies every asking range
Reviewer test for #3145 (adopted from sonukapoor): sharp must be a
declared dependency, and the pinned overrides.sharp must satisfy both
that declaration and every lockfile package that depends on sharp
(@huggingface/transformers included). Fails on 47d639a (sharp not
declared; transformers 4.2.0 asked for ^0.34.5 against a 0.35.5 pin).
Classifier smoke on the changed tree (transformers 4.3.0,
onnxruntime-node 1.30.0, sharp 0.35.5, claude-agent-sdk 0.2.141): the real
sidecar entry bundled for Node with a private state root, and the
classifier in-process under Bun, each downloaded the TestSavantAI model
fresh, reported testsavant: ok, and returned scores identical to
47d639a's tree on five inputs, including a >512-token input that
exercises the truncation override. dependency-security, deps-smoke,
overlay-sdk-cancel-eof, security-classifier and screenshot-size-guard
pass; typecheck:test reports no new diagnostics.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(gbrain-sync): the no-bash skip names GSTACK_GIT_BASH and how to set it (#3197)
The brain-sync stage's Windows skip line told users to set GSTACK_BASH.
After the fix wave the canonical override is GSTACK_GIT_BASH, with
GSTACK_BASH as a deprecated alias (plan correction 9). The summary is now
the exported NO_BASH_SUMMARY: it names GSTACK_GIT_BASH first and GSTACK_BASH
as the old name, and gives the two recipes that reach Claude Code (a
PowerShell user environment variable plus a Claude Code restart, or the
"env" block of ~/.claude/settings.json).
Minimal on purpose: once PR 2 lands, this switches to
lib/script-invocation.ts noBashMessage(). Until then lib/gbrain-exec.ts
still reads only GSTACK_BASH, so this line is accurate only with PR 2
merged first.
New test test/gbrain-sync-no-bash-message.test.ts fails on the previous
commit (NO_BASH_SUMMARY not exported) and passes now.
Handoff from Lane C (PR 2).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(ios-qa): the forced relaunch carries GSTACK_IOS_LAUNCH_ENV too (#1796)
bootstrapTunnel's relaunchApp (an app whose boot token an earlier daemon
consumed is relaunched once with --terminate-existing) built its own
devicectl argv and dropped GSTACK_IOS_LAUNCH_ENV, so an env-gated debug
bridge vanished after the one relaunch the howto says carries it. It now
uses launchEnvArgs(); an invalid value refuses the relaunch with
launch_failed and the IOS_LAUNCH_ENV_INVALID detail before anything is
terminated.
Two new tests in ios-qa/daemon/test/devicectl-launch-env.test.ts drive
bootstrapTunnel through a consumed-token device: both fail on the previous
commit (relaunch argv lacks --environment-variables; the invalid value
still terminates and relaunches) and pass now. ios-qa daemon: 167 pass.
tunnel-bootstrap.ts was assigned to Lane D by the coordinator for this fix.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci(version-gate): check the version queue only on PRs into main
Stacked layer PRs carry no VERSION stamp by design (the release layer stamps
once), so the queue check failed on any layer touching package.json. The
queue and its collision rule only describe main; a PR into main is still
checked exactly as before.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(browse): scope the SIGTERM PTY-reap case to POSIX signals (#3147)
windows-free-tests run 38813751242 (shard 6) failed "SIGTERM reaps every
active PTY child before terminal-agent exits" with "timed out waiting for
pty-child.pid", serially and on retry.
Diagnosis: invalid test expectation on Windows, not an agent defect the
test can observe. The contract under test is the agent's graceful
shutdown, its process.on('SIGTERM'/'SIGINT') cleanup in terminal-agent.ts.
On Windows, Bun's subprocess.kill('SIGTERM') is libuv's TerminateProcess,
so that handler never runs there; and the PTY fixture is an extension-less
`#!/bin/bash` script, which CreateProcess cannot launch, so the child never
starts (the timeout is at the pid file, after the port, token, grant and
WebSocket all succeeded). The file's other integration cases were already
Linux-scoped; this one now skips only on win32 and still runs on Linux and
macOS. The pure ownership unit tests in the file keep running on Windows.
Open, not covered by any test: whether a ConPTY child outlives a
hard-terminated agent on Windows. Testing it needs a Windows-launchable
terminal fixture, which BROWSE_TERMINAL_BINARY (one executable, fixed argv)
cannot express without a product change.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(plan-review): bound the native outside voice without TaskOutput (#3182)
Claude Code 2.1.277 removed TaskOutput, so the plan-review native fallback's
preflight always failed and users without the Codex CLI never got a second
voice. The fallback now uses primitives the host still enforces: a background
`sleep 300` Bash timer (its exit re-invokes the parent; the 2.1.300 sleep block
applies only to foreground commands), a background Plan dispatch whose
completion arrives as a <task-notification>, and TaskStop for whichever task
loses. Only a matching completed notification that beats the timer counts;
interim ("is waiting on its own background work"), turn-limit, foreground and
late results get no credit. The "[Subagent hand-back]" header (2.1.277) is
treated as framing.
The unavailable line now names its cause and fix, ends with
OUTSIDE_VOICE_UNAVAILABLE (new result code + troubleshooting entry), and the
review-log row carries unavailable_reason. The bounded-wait prose was
tightened so plan-ceo-review and plan-eng-review stay under their existing
size ceilings (no ratchet raise for this item).
Intentional pin change: test/run-in-background-guidance.test.ts
hasBoundedOutsideVoiceWait and the dispatch-contract cases now pin the
timer/notification/TaskStop contract instead of TaskOutput's envelope.
bin/gstack-doctor-components.sh is regenerated from lib/result-codes.ts.
Reported by HuellintonMota in #3182.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* feat(bin): gstack-ceo-plan-find locates the CEO plan for a branch (#280)
/plan-ceo-review saves its scope decisions under the state root's
ceo-plans/, but no plan review can find them: only /design-html reads
that directory, newest file first. This helper is the CEO-plan sibling of
gstack-design-doc-find, so /plan-eng-review can call one command instead
of a glob in prose.
It prints the newest top-level plan whose "Branch:" header names the
branch, compared the way gstack-slug writes BRANCH (feat/x matches
feat-x), else the newest plan, else nothing. Subdirectories are not
read. A usage error exits 2.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(plan-eng-review): read the CEO plan in the Design Doc Check (#280)
/plan-eng-review never looked in ceo-plans/, so an eng review after
/plan-ceo-review ran without the scope that review accepted, deferred or
skipped. capy-ai closed#414 asking for this focused fix, and TODOS.md
scopes it as a gstack-ceo-plan-find sibling of gstack-design-doc-find.
The Design Doc Check now prints "CEO plan found: <path>" or "No CEO plan
found" after the design doc line, and the prose says what to read the
plan for. The data-not-instructions rule names the CEO plan too, since
another agent may have written it. Only plan-eng-review changes: the
shared {{DESIGN_DOC_DISCOVERY}} block and the branch-scoped review log
are untouched. Reported by @chancheuklap in #280.
main left plan-eng-review 4 bytes under its parity cap, so the +325
bytes raise maxSizeRatio to the measured 1.2196, noted the way earlier
growth was.
Fixes#280
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(plan-eng-review): disclose a CEO plan borrowed from another branch (#280)
Review changes on top of #3159 (szsunyuan / y$un_):
- gstack-ceo-plan-find keeps stdout a bare path or empty; when it falls back
to another branch's plan it prints one stderr line,
"CEO plan found (from branch <b>, not <current>): <path>", with control
characters stripped from the plan header ("unknown" when it has none).
- The Design Doc Check tells an interactive reviewer to ask before using such
a plan, and a spawned session to use it and quote the disclosure.
- The Design Doc Check prose is tightened so plan-eng-review fits the
owner-approved 1.2196 ceiling (measured 151,950 / 124,597 = 1.2195).
Reviewer tests: test/ceo-plan-find-cross-branch.test.ts (5 of 7 fail on the
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
#3159 head). The design-doc finder's matching disclosure stays deferred.
* fix(test): credit abutting section chunks whose edge bytes repeat (#3182)
detectSectionReads trims the longest suffix/prefix overlap between
consecutive Bash outputs. Two chunks that abut exactly (tail -c +N after a
chunk ending at N-1) can share an edge byte by chance; the trim then drops a
real byte and a fully printed section reads as incomplete. #3182's
review-sections edit moved plan-ceo-review's 66,999-byte boundary onto
"cur|rent", which turned the existing byte-range test red. The detector now
also checks the plain concatenation; a gap still refuses.
Detector/fixture defect, not a product change. New regression case in
test/section-capture-native-tools.test.ts fails without the fix.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(changelog): fix wave 2026-10-15 release notes
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* v1.91.104.0 fix: the 2026-10-15 issue wave
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(qa): probe each documented input rule, not only its boundary values
The paid gate's qa-functional-cli-report run (38829994639) probed zero and an
unsafe integer but never a non-digit amount, so it missed the planted
parseInt defect ("Amounts contain only ASCII digits") and reported no
defect. The functional contract map's invalid-input row now asks for one
probe per documented input rule (allowed characters, format, sign, range,
arity).
test/qa-functional-prompt.test.ts replays a captured CI Read of
system-functional.md; its completed-method variant now feeds the current
section bytes, so the validator check keeps its omitted/pending negative
controls without pinning the old wording.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* v1.91.106.0: restamp the fix wave above v1.91.105.0
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(release): keep the wave's dependency bumps through the main merge
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: Bryan Stone <aegixx@gmail.com>
Co-authored-by: vilano93 <244097767+vilano93@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: aftabkh4n <akobkz@gmail.com>
Co-authored-by: Benjamin D. Smith <benjamin.smith@binarysword.com>
Co-authored-by: Jess Sullivan <jess@sulliwood.org>
Co-authored-by: NetrioGit <5wngh@naver.com>
Co-authored-by: y$un_ <forrest.sun527@gmail.com>
Co-authored-by: Lockyer <135391289+Lockyer228@users.noreply.github.com>
Co-authored-by: davidfragnoli-lang <249433777+davidfragnoli-lang@users.noreply.github.com>
Co-authored-by: KuroChen <kurochen_macmini@KuroChendeMac-mini.local>
Co-authored-by: AV <vo.quanganh@gmail.com>
Co-authored-by: Y4NN777 <171065166+Y4NN777@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sonu Kapoor <sonukapoor@gmail.com>
* fix(models): allowlist routing for model-pinned Claude families (W1)
resolveModel lowercases input and strips one trailing [...] context marker.
Opus 4.7, Opus 4.8 and Sonnet 5 keep their pinned overlay only for the bare
ID, the bare ID plus an 8-digit date, and the bare ID plus -latest; any other
suffix (point releases such as claude-sonnet-5-5, claude-opus-4-7-1) falls to
the generic claude overlay. claude-opus-5-5 routes to claude explicitly (no new
overlay, no new ALL_MODEL_NAMES entry). Fable keeps its prefix match while
CLAUDE_FRONTIER_EVAL_MODEL is claude-fable-5-1, guarded by a test.
Tests: one test/model-overlays.test.ts case per shape in the plan, plus the
lowercase / [1m] marker / family-name cases and the Fable guard.
* docs(CLAUDE.md): define when prompt bytes are a test contract (W7 prompt-byte rule)
Adds the gstack-repo definition to the Testing section at normal volume:
prompt bytes are a contract only when software reads them or a recorded eval
shows the wording matters. Amends the test-value-bar line so 'prompt bytes'
refers to that definition. scripts/resolvers/test-value.ts and
docs/test-value-bar.md are unchanged.
* fix(browse): sidebar tab hint names real tabs.json fields and how $B resolves (s11 H1, s11 M8, s11 M9)
* fix(router): route telemetry uses the echoed SESSION_ID (s01 H1)
$_SESSION_ID is never set in the router's bash block since
bin/gstack-skill-start took over session bookkeeping, so every /gstack route
event logged an empty session id. Use the literal SESSION_ID placeholder and
tell the model to substitute the echoed value, matching the completion-status
telemetry block. No W7a pins on the changed line.
* docs(CLAUDE.md): correct stale test-infra facts (s01 H2, H3, H4, H5)
H2: TREE_MUTATING is not empty; it still holds bootstrap-retention.
H3: catalog ceiling is CATALOG_BUDGET_TOKEN_EQUIVALENTS (1,194), not 1,171.
H4: detach timeouts point at package.json's --timeout values (gate is 49320s).
H5: Writing Style lives in preamble/generate-writing-style.ts and the jargon
list is Read at runtime, not baked at generation time.
No W7a pins on the changed lines.
* fix(preamble): drop the stale jargon-list count (s01 H6)
The list has 77 terms, not 80+, and the model Reads the file anyway. No W7a
pins on the changed text.
* fix(overlay): claude.md dedicated-tools nudge stops naming tools the host may lack (s01 M1)
The nudge named Glob and Grep, which some Claude hosts do not expose. It now
names the host's dedicated file tools and its search tools when it has them,
keeping the prefer-dedicated-tools behavior the claude-dedicated-tools-vs-bash
overlay eval measures. Updates the prose comment at
test/gen-skill-docs.test.ts:643 (comment only, no assertion change). The
matching comment in test/fixtures/overlay-nudges.ts is left to its owner.
* fix(preamble): progress notes on phase changes, not a [PROGRESS] cadence (s01 M2)
Context Health told the model to periodically write a tagged [PROGRESS]
summary. No code reads that tag; the line now says when to tell the user
(finishing a phase or changing direction). Loop detection stays.
W7a pin: test/terse-build.test.ts:103 pinned 'PROGRESS'; it now checks the
default build emits a non-empty Context Health body (terse still emits '').
* fix(preamble): learnings review without incident archaeology (s01 M3)
Drops the issue number, the 43-of-44 statistic and the ALWAYS caps from the
Operational Self-Improvement step; keeps the rule that the review runs every
time and that an empty result is stated explicitly. No W7a pins on the
removed text.
* docs(CLAUDE.md): fold 'Long-running tasks' into the detach section (s01 M4, CEO W4)
The 'don't give up' section told agents to poll a plain background task with
sleep 180 + TaskOutput, which the next section forbids for evals. Its one
durable rule (keep checking until the run finishes, report progress at each
check) now lives in the detach section's poll step, pointed at the
gstack-detach EXIT sentinel, at normal volume. No tests pin the removed text.
* fix(preamble): test-failure triage questions defer to the AskUserQuestion Format (s01 M5)
The two quoted pseudo-briefs pinned a superseded question shape (RECOMMENDATION:
Choose X, a completeness score on the recommendation, no D<N>/ELI10/Net). The
triage step now gives the facts, the options with their completeness values,
and the recommended option as data, and defers the shape to the Format section.
Option labels that Step T4 and test/skill-validation.test.ts:2004-2016 depend
on are verbatim. No W7a pins on the removed text.
* fix(proactive): PROACTIVE=false means no suggestions, including 'want me to run /X?' (W5.1)
The router forbade suggesting skills when PROACTIVE is false while the preamble
told the model to ask 'want me to run it?'. Decision: false means never
auto-invoke and never suggest, including by asking. The preamble line in
generate-upgrade-check.ts now matches the router, and both quote the value
as `false`, the way gstack-skill-start prints it. Restore with
gstack-config set proactive true.
W7a pin: test/gen-skill-docs.test.ts:4488 used the old quoted sentence as a
preamble-order marker; it now finds the PROACTIVE-false rule with a
quote-tolerant, case-insensitive pattern.
* docs(ETHOS.md): correct the claim that ETHOS is injected into every preamble (W5.7)
Nothing injects ETHOS.md. Preambles carry condensed principles (completeness,
voice, search before building) and the Search Before Building section links to
this file. Edit approved by Garry for this PR.
* office-hours: fix stale refs, state-root path, profile query, SESSION_ID (s07 H1, H2, H3, M7, M10; s01 H1 office-hours note)
- Phase 4.5 points at Founder Resources instead of the nonexistent Beat 3.5 (H1).
- builder-journey.md is written to $GSTACK_STATE_ROOT, where it is opened (H2).
- builder-profile context query reads developer-profile.json, the file the
migration leaves behind; drop meaningless tail (H3).
- Drop issue numbers from three headings (M7) and the MANDATORY/NOT optional
markers on Phase 4 (M10).
- Handoff telemetry uses the echoed SESSION_ID placeholder; $_SESSION_ID is
never set in a fresh shell.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* spec: plain Phase 3 gate, drop duplicates, dead telemetry and review IDs (s07 H4, M1, M2, M3, M4, M5, M6)
- H4: Standard template heading no longer names nonexistent --bug/--feature/--refactor flags.
- M1: Phase 3 read-code-first gate at normal volume, constraint and reason kept.
- M2: drop the in-phase repeat of the read-first rule (Rules recap stays).
- M3: drop the duplicate audit-sink paragraph.
- M4: drop TTHW telemetry block and its never-set frontmatter keys.
- M5/M6: drop plan-review finding IDs from Phase 5 headings and the /ship handoff.
W7a pins: spec-template-invariants:314 (Mandatory/MUST) becomes a Phase 3
section check for the read-evidence-before-asking constraint; :203 matches
'raw spec must not be persisted' across line wraps so no duplicate paragraph
is needed to satisfy it.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* investigate: drop issue numbers from freeze-script comment (s07 M8)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* qa: replace WTF point table with named signals and a plain stop rule (s07 M9)
The self-regulation check keeps its cadence (every 5 fixes or after a revert),
its signals (reverts, unrelated files, sprawl, long runs, low-severity tail),
STOP-and-ask, and the 50-fix hard cap. The percentage table goes; the stop
threshold (two reverts, or one unrelated-file edit) stops at least as early.
W7a pins: qa-browser-preservation:220 drops 'WTF > 20%' and checks the
signals case-insensitively; skill-validation:1250 checks the test-only
exclusion rule instead of the heading name; carve-guards qa anchor
'WTF-LIKELIHOOD' becomes the '### 8f. Self-Regulation' heading.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* design-html: match Pretext docs to the vendored bundle; fix cross-block server state (s08 H1, H2, H3, H4, H7, M6)
- H1-H3: walkLineRanges, layoutNextLine and layoutWithLines signatures and
return shapes now match design-html/vendor/pretext.js; patterns 2-4 rewritten.
- H4: inline the ES-module bundle in <script type="module"> with page code in
the same module; no window.Pretext global exists.
- H7: remember the printed server URL and PID; later blocks restate them.
- M6: drop the 2-3 line cap on the refinement summary.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* make-pdf: drop nonexistent --no-syntax flag, trigger list and relative phrasing (s08 H5, M7, M9)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* design-shotgun: DESIGN.md decides what variants vary; fix $SLUG; drop history (s08 H6, M1, M2, M3; W5.6)
- H6: the office-hours lookup block evals gstack-slug before using $SLUG.
- M1 + W5.6: with a DESIGN.md, variants keep its fonts and palette and vary
layout and composition; without one they vary font, palette and layout.
The swap-the-headline test and the 'Anti-convergence directive' heading
(carve-guards anchor) stay.
- M2: drop the Claude Code version pin; run_in_background: false and its
reason stay.
- M3: /tmp-then-cp rule and reason without the incident story.
G1 (replace executor subagents) deferred to TODOS.md per plan.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* design-review: plain identity line; scope 'never read source' to the audit (s08 M4, M10)
M5 (risk-percentage stop conditions) is a UC2 gate and keeps its wording.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* design-consultation: plain CLAUDE.md design-system snippet with its reason (s08 M8)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* plan-tune: describe the never-ask hook truthfully; drop plan codes (s09 H8, H9, H10, M10; W4 plan-tune)
W4: make the text true rather than change the hook. The consent copy and
scope now say never-ask questions are auto-decided with gstack's
recommendation by the question-preference hook (one-way doors still ask),
and the profile itself never changes defaults. H10 removes the nonexistent
--dismiss command. M10 strips cathedral/Layer/D-codes and keeps mechanisms.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* context-save/restore: drop rename history; fix command-list branch rule (s09 H11, M1, M2, M3, M4, M5, M6)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* retro: correct what the skill writes; drop word cap and archaeology (s09 H13, M7, M8, M9, M25)
H13 and M7 touch neighbouring lines and were merged by hand in that order.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* health: compute the composite in code; fix example weights; drop D6 codes (s09 H12, M21, M22)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* gstack-upgrade: drop issue numbers and version history, keep rationale (s09 M20)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* canary: replace the 30-second/don't-over-analyze rule with the goal (s09 M23)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* benchmark: self-contained page discovery instead of a /canary reference (s09 M24)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* codex: drop judge vocabulary and the maintainer known-bad-list note (s10 M1, M2)
The synthesis line keeps its Recommendation: <action> because <reason> shape.
M16 (consult-mode embed rule) is a UC2 gate and keeps its wording; the
outside-voice prompt bodies sent to Codex are unchanged.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* document-generate: true redaction-fence behavior; drop thoroughness booster (s10 H8, M3)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* document-release: changelog sell test as three questions, not a 0-3 score (s10 M6)
The threshold stays (fewer than two answered = needs attention, not
replacement). M4/M5 (NEVER CLOBBER / NEVER BUMP) keep their wording; the
integrator owns the eval-gated rewrite.
W7a pin: workflow-excerpt:170 'Entries scoring <2 need attention, not
replacement' becomes a case-insensitive check that weak entries get
attention, not replacement.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* ios-clean/fix/sync: match the generator's real header, package shape and regen command (s10 H2, H3, H4, H5, M9, M12)
- H2: inventory greps the header the generator actually writes.
- H4/H5: remove the local .package(path:) entry and DebugBridge* product
deps; delete the generated DebugBridge/ and DebugBridgeGenerated/ dirs so
the Phase 3 check can pass.
- H3: regenerate accessors with /ios-sync (gstack-ios-qa-regen).
- M12: ios-fix writes the regression with the project's own test runner.
- M9: drop migration-relative sentence.
ios-qa DEMO MODE (M8) is a UC2 gate and keeps its wording.
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* setup-deploy: drop User-invocable boilerplate; say default branch, not main (s10 M10, M11)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* skillify: test staged skills directly; stop after Aside scrapes; drop roadmap notes (s10 H1, H6, H7, M14, M15)
Template-only commit: generated SKILL.md is expected red until the regeneration commit.
* W4: transcript ingest needs affirmative consent (recent|all)
normalizeTranscriptConsent() in gstack-memory-ingest reads
transcript_ingest_mode once per process. Only recent (90 days) and all
(all history) are consent; an absent key, off, legacy gate letters,
incremental and unknown values skip transcripts while other memory still
syncs. The ingest's default source set drops transcript without consent;
an explicit --sources list naming transcript overrides.
gstack-gbrain-sync reads consent once at sync start and pins a non-consented
run to an explicit source list, so a mid-run config change cannot add
transcripts. It prints the pinned skip notice on every such run (even
--quiet), records the normalized mode and skip reason in the memory stage,
restages an interrupted import when the consent policy changed, passes
--all-history on --full for mode all, and documents the default in --help.
Tests: new gstack-gbrain-sync-transcript-mode.test.ts; memory-ingest
fixtures seed consent; regression-2922's every-type case seeds consent.
Findings: s09 H16 (enforce the consent choice in code).
* W4: gstack-brain-sync holds staged transcript pages without consent
Queued transcripts/ pages stay queued and on disk unless
transcript_ingest_mode is recent or all; other classes still push.
Test: brain-sync.test.ts push-filter case (absent, off, legacy A, then recent).
* W4: gstack-config validates transcript_ingest_mode; set rejects empty and multi-line values
transcript_ingest_mode accepts only recent|all|off and leaves the stored
value unchanged otherwise. set rejects an empty value or one containing a
newline for every key instead of truncating it. The config header documents
the key; lookup_default keeps off.
* setup-gbrain, sync-gbrain: fix stale facts and strip plan archaeology
Applies s09 H1a, H1c (Mac-only wording; the installer supports Linux and
Windows), H2 (smoke test has no delete step), H3 (five invocation modes),
H4 (no CI grep test backs the telemetry claim), H7 (Step 4.5 does not exist;
the prompt is Path 4 step 4d), M11, M12, M13, M15, M18, M19 (plan codes,
issue numbers, version pins, rename story), M14 (restore-from-sync never
shipped), M16 (draft self-dialogue in the Supabase steps), M17 (passed
sunset date, manual merge into both sections).
W7a: retires the setup-gbrain-bin-invocation-paths 'now persists staged
transcripts' change-detector (t06 #17); the no-bare-invocation regex tests
keep the contract.
* W4: transcript consent prose in /setup-gbrain, /sync-gbrain and memory.md
The Step 7.5 gate is rewritten as a consent question (manual merge of s09 H5,
with H1b and H6): it checks gstack-config has, asks once with A) recent,
B) all history, E) never, names Claude Code and Codex sessions from every
repo-policy-allowed project and the destination brain, stores the mode value
(never the letter), asks yes/no when no transcripts exist, never asks
spawned or headless sessions, and drops the silent no-question bulk paths
and the false skill-start-hook claim (s09 H5c). Path 4 no longer stores off
on the user's behalf. /sync-gbrain gains Step 1.6 (ask when the key is absent
or holds a legacy value). Step 10 and the sync verdict show the mode.
setup-gbrain/memory.md gains #transcripts (values, sources, destination,
override precedence, one-time restage, held staged pages, already-ingested
pages stay).
W7a: setup-gbrain-bin-invocation-paths drops the silent-bulk and
preamble-hook pins (that prose is gone) for negative checks (no pre-answer
--bulk, no skill-start claim), loosens the gstack-config pin (t06 #18) to
the command without <choice>, and adds the DX 'gated on has' order check for
both skills.
* W5.2: /sync-gbrain is the only writer of the CLAUDE.md search-guidance block
setup-gbrain's claude-md-persist section stops writing its own
'## GBrain Search Guidance' block, which also removes the false
'auto-syncs on every gstack skill start' text (s09 H15; s09 H14 decided).
Step 10 offers to run /sync-gbrain now and names it otherwise. Test sweep:
only skill-e2e-sync-gbrain-readiness references the heading, and it checks
the block /sync-gbrain writes, so no test changes.
* E4: config-key reader tripwire in gstack-config-defaults.test.ts
Every key in bin/gstack-config's DEFAULTS table must be read by code
(gstack-config get/has <key>, a config-binary variable, a spawn argv, a
config-reader call, or an anchored ^key: pattern in bin/, lib/, scripts/,
setup or any .tmpl; wildcard keys by prefix) or appear in PROSE_ONLY_KEYS
with a reason. Run on the current tree first: every key has a reader, so
the seeded prose-only list is empty. Failure messages name the two fixes.
A synthetic-tree case checks each reader form and that docs prose does not
count. setup is scanned because timeline_stop_hook is read only there.
* W4: /open-gstack-browser asks before replacing a live browse daemon
Step 0 probes with BROWSE_NO_AUTOSTART=1 $B status (no daemon is booted by
the probe). No live daemon: clear Chromium profile locks and run plain
$B connect, which reaps orphans and refuses to replace a busy daemon. Already
headed: connect reports it. Live headless daemon: AskUserQuestion, and only
an explicit yes runs $B connect --force-restart; spawned or headless sessions
leave it running and print the stop line with the resolved browse binary.
The hand-rolled kill / kill -9 of the recorded PID and the browse.json
deletion are gone. Supersedes s10 M13.
Tests: new open-gstack-browser-liveness.test.ts (no kill of the recorded PID,
status probe before connect, --force-restart only after the yes branch,
profile-lock cleanup kept, spawned/headless stop line). The state-extraction
tripwire now covers only the port snippet, since the pid snippet is gone.
* fix(browse): untrusted-content warnings name both marker formats (s02 H5, s02 L2 / W7f)
The /browse warning named only the --- UNTRUSTED EXTERNAL CONTENT --- envelope
and the browser fallback only the ═══ UNTRUSTED WEB CONTENT ═══ one; $B prints
both (commands.ts wrapUntrustedContent, content-security.ts ENVELOPE_BEGIN).
Both surfaces now name both formats.
W7f pin: test/aside-driver.test.ts:347-350 no longer bans the EXTERNAL marker;
it reads both marker labels from browse/src/commands.ts and
browse/src/content-security.ts and requires both in the fallback and warning.
Negative control: reverting browse.ts turns the test red.
Parity cap (test/helpers/carve-guards.ts): qa maxSizeRatio 1.103 -> 1.104
(measured 1.1035); the second marker adds bytes to every skill that renders
the browser fallback.
expected red until the regeneration commit (generated SKILL.md not committed)
* fix(design): mockup board loop matches the daemon CLI (s02 H1, s02 H2, s02 H3)
- H1: $D compare --serve publishes to the design daemon and exits; read
BOARD_URL from stderr, wait with AskUserQuestion, then read feedback.json /
feedback-pending.json. The fallback no longer names a $D serve command the
step never runs.
- H2: the reload POST uses the jq --arg form, so $_DESIGN_DIR expands (the
single-quoted JSON sent the literal variable name).
- H3: Content & Microcopy lists 11 items, not 8.
No test pins the removed text. expected red until the regeneration commit
* design: name the defaults to avoid in native design-direction prompts; plain path rule (s02 H4a, s02 H4b, s02 M9)
- H4a/H4b: the design-consultation and design-sketch native subagent prompts
now name the default looks to avoid (the three looks from the Hard Rules
calibration plus the catalog entries the sibling outside-voice prompt
already lists) and say to pick again if the first idea is one of them.
- M9: 'CRITICAL PATH RULE' -> 'Path rule'; the rule and its reason stay.
No test pins the changed text. Parity cap (test/helpers/carve-guards.ts):
design-consultation maxSizeRatio 1.085 -> 1.092 (measured 1.0911). expected red until the regeneration commit
* fix(outside-voice): preflight mode list no longer looks exhaustive (s02 M10)
The preflight also prints under_codex and under_current_harness; not_authed
exists only on the Codex path. 'every other mode skips them' covers all
non-ready modes. No test pins the old line. expected red until the regeneration commit
* outside-voice: drop booster sentences and plan-review decision IDs (s02 M1, s02 M7)
- M1: native adversarial subagent prompt drops 'Be adversarial. Be thorough.';
the attacker framing, defect list and 'No compliments' output rule stay.
- M7: doc-review headings drop the D3 / T3B plan-review decision IDs (D<N> also
collides with AskUserQuestion brief numbering).
Not changed: s02 M2 (outside adversarial prompt body sent to Codex/GPT: out of
scope per plan) and s02 M3 (CODEX_BOUNDARY: UC2 gate keeps its wording).
No test pins the removed text. expected red until the regeneration commit
* confidence: drop issue IDs and the contributor-only design-doc pointer (s02 M4a, s02 M4b)
- M4a: gate heading and FP-class intro lose '#1539' and the Django sprint
measurement note; the gate rule and its four FP classes stay.
- M4b: remove the pointer to ~/.gstack-dev/plans/1539-framework-aware-review.md,
a contributor-local file that never exists where /plan-eng-review and /ship run.
W7a pins (test/regression-1539-review-self-verify.test.ts):
- :34 toMatch(/#1539/) removed (cosmetic issue-number pin; the gate-header
check stays).
- :64-67 'references the deferred design doc' replaced by a structural check
that no .gstack-dev/plans/ path reaches the emitted prose.
expected red until the regeneration commit
* question-tuning: state why the summary is piped instead of citing #2024 (s02 M6)
No test pins the resolver text (#2024 appears only in test names/comments).
expected red until the regeneration commit
* fix(testing): shared TEST_BOOTSTRAP undoes only owned changes (s03 H1, s03 H2, s03 H3, s03 M1)
The shared {{TEST_BOOTSTRAP}} (/ship, /design-review) still told the agent to
'git checkout -- package.json package-lock.json', to 'revert all bootstrap
changes', to 'delete silently' a failing first test, and to stage 'all
bootstrap files'. The QA copy (qa/sections/test-bootstrap.md.tmpl) already
says undo only owned changes, never blanket-checkout, never silently delete a
valid red regression, and stop on unrelated staged edits. The shared copy now
matches it. This removes destructive behavior (UC2: lands regardless of eval).
W7g: test/qa-browser-preservation.test.ts gains a check that the shared copy
(ship, design-review) has no 'git checkout --', no silent deletion, no
blanket revert, and keeps the owned-change and staged-edits rules
(case-insensitive). Negative control: the old testing.ts turns it red.
Parity cap (test/helpers/carve-guards.ts): ship maxSizeRatio 1.404 -> 1.405
(measured 1.4044 at the branch tip, with the s03 M2/M3 wording).
expected red until the regeneration commit
* testing: coverage trace and test generation follow the value bar (s03 M2, s03 M3)
- M2: 'Every branch in this diagram needs a test' / 'Each step in the journey
needs a test' contradicted COVERAGE_GOAL ('Test count is not a goal') in the
same rendered audit. Branches and journey steps now need coverage that would
catch a regression; the value bar decides new test vs extension vs covered.
- M3: 'Mock all external dependencies' -> the smallest native test, mocking
only services unrelated to the behavior (matches the QA handoff in qa.ts and
the audit's own E2E routing).
No test pins the removed text. expected red until the regeneration commit
* plan-gates: per-item confirmation states its reason, not an incident ID (s03 M4)
'VAS-449' meant nothing to the model and reached the user in the >5-items
warning. The rule now gives the reason (a blanket confirmation lets the user
click through without opening any file / lets unchecked items pass as
verified). The per-item confirmation rule is unchanged.
W7a pin: test/ship-plan-completion-invariants.test.ts:122 toMatch(/VAS-449/)
removed (cosmetic incident-ID pin); the per-item rule and blanket-confirm ban
checks on the same test stay. expected red until the regeneration commit
* plan-gates, review-dashboard: terminal-report rules without trait claims or 'prior versions' narrative (s03 M5, s03 M7)
- M5: exit gate drops 'will (correctly) reject it' and the 'Self-deception
failure mode' aside; keeps the contract-violation sentence (pinned by
test/gen-skill-docs.test.ts) and the body-prose-is-not-the-report rule.
- M7: report-write step states the rule and its reason (delete and append at
EOF so the report stays last) instead of the history of how it broke.
No test pins the removed text. expected red until the regeneration commit
* spec-review: default anti-shortcut clause without incident narrative (s03 M6)
Drops 'the May 2026 transcript bug ... that's the bug, recognize it' and the
caps; keeps the rule: each non-trivial finding goes through AskUserQuestion
before it enters the plan, and only a zero-finding review skips asking. The
four skill-specific branches are unchanged.
W7a pin: test/skill-ceo-section-ordering.test.ts:868-873 pinned the SHA-256
of the default clause. It now checks, on every host, that the clause still
says the plan cannot replace the interactive review, routes findings through
AskUserQuestion, and lets only zero findings reach ExitPlanMode without
asking (case-insensitive), and that the clause is host-independent. The old
clause also passes; deleting the zero-findings rule turns it red. The DX
hash pin is unchanged.
expected red until the regeneration commit
* constants: foreground-dispatch note in current-state terms at normal volume (s03 M8)
Keeps every constraint (explicit run_in_background: false, Agent tool only,
never inline or as a Skill, fallback only after a dispatched subagent fails)
and the reason (fresh-context isolation); drops 'no longer', BACKGROUND/ONLY/
WRONG/FALLBACK caps. test/ship-control-flow.test.ts and
run-in-background-guidance.test.ts check the placeholder and the explicit
flag, not this prose. expected red until the regeneration commit
* tasks-section: inline the effort ratios for every phase (s03 M9)
The non-CEO/Eng branch said 'Effort uses the AI-compression table from
CLAUDE.md', but at runtime CLAUDE.md is the user's project file; the table
exists only in gstack's own repo. Every phase now renders the inline ratios
the CEO/Eng branch already used. No test pins the removed text.
expected red until the regeneration commit
* hosts, utility: model-neutral Claude co-author trailer (s03 M10, s11 M10)
The Claude host trailer and the resolver fallback (cursor, kiro, opencode,
slate) signed commits as 'Claude Opus 4.7' whatever model ran. Both now read
'Co-Authored-By: Claude <noreply@anthropic.com>' so the trailer cannot go
stale at the next model release (the s11 report offered this neutral form;
s03 M10's hunk uses it). document-release's release body renders the same
{{CO_AUTHOR_TRAILER}} and follows on regeneration.
test/host-config.test.ts:589 only requires 'Claude' and stays green. Goldens
move on regeneration (not committed). expected red until the regeneration commit
* changelog workflow: cross-check covers user-facing changes, not every commit (s03 M11)
'Every commit must map to at least one bullet' contradicted the same block's
voice rule (never mention contributor-facing details) and CLAUDE.md's entry
rule (the diff vs main, not how the branch got there). Every user-facing
change in the commit list must be represented; merges, version bumps and
mid-branch fixes need no bullet.
W7a pin: test/gen-skill-docs.test.ts:2038 no longer pins the old sentence; it
checks the Cross-check step still compares against the step-2 commit list
and scopes to user-facing changes (case-insensitive), without re-pinning the
new sentence. expected red until the regeneration commit
* plan-ceo-review, plan-eng-review: storage paths follow the state root (s04 F2, s04 F3)
The CEO storage policy and the eng write policy named ~/.gstack/projects/ and
~/.gstack/analytics/, while the writers (tasks-section.ts, testing.ts,
spec-review.ts) use $GSTACK_STATE_ROOT. When the state root is relocated the
prose pointed at the wrong directory.
W7a pin: test/plan-review-cases.test.ts:852 pinned the stale path; it now
checks the discovery path is under $GSTACK_STATE_ROOT and that the hardcoded
~/.gstack/projects/{slug}/ is gone. expected red until the regeneration commit
* plan-ceo-review: remove the handoff-note reader and cleanup for files nothing writes (s04 F6, s04 F7)
CEO handoff notes (*-ceo-handoff-*.md) have not been written since v0.11.5.1;
no template, resolver or bin script produces them. The reader cost a bash
call on every CEO run, depended on $SLUG/$BRANCH from another shell, and
looked under $GSTACK_STATE_ROOT where pre-state-root notes never lived.
W7a pin: test/skill-ceo-section-ordering.test.ts:320 sliced up to the
removed '## Handoff Note Cleanup' heading; it now slices to the next heading
('## Review Log') with the same assertions.
Note: the ceo-mode-option / ceo-mode-prerequisite PTY cases fail under the
image's Bun 1.3.14 with or without this change and pass under Bun 1.4.0.
expected red until the regeneration commit
* plan reviews: replace context-pressure triage with the full-completion rule (s04 F1; manual merge of s05 M2)
plan-ceo-review, plan-design-review and plan-devex-review ranked sections
'under context pressure' ending in 'Everything else', which licensed dropping
sections their own anti-skip rules require. plan-eng-review already replaced
the same block with 'Complete every required stage ... do not preemptively
warn'. All three now use that rule and name what may never be shortened
(design: Step 0, Step 0.5 mockups unless the user opted out, Passes 1-7;
devex: Step 0 with persona/empathy/benchmark/magical moment/TTHW, Passes 1-8).
s04 F1 noted the same block in the s05 files; the design copy is a manual
merge of s05 M2 (drops 'non-negotiable', which contradicted the user's
explicit 'skip mockups' opt-out). No test pins the removed text.
expected red until the regeneration commit
* plan-ceo-review: shared-code guidance matches the eng review (s04 F4, s04 F5)
'DRY: flag repetition aggressively' and 'DRY violations. Be aggressive.'
contradicted plan-eng-review's newer rule (require common behavior and
improved reliability or net savings; similar-looking code alone is
insufficient), so the two reviews gave the same plan opposite advice. Both
CEO lines now follow the eng rule; Section 5 keeps the file:line citation.
No test pins the removed text. expected red until the regeneration commit
* plan reviews: normal-volume rules; eng sections report every finding (s04 F8, s04 F10, s04 F11)
- F8: eng 'at most 8 findings' per section conflicted with 'never condense or
skip' and left a 9th high-confidence finding nowhere to go; report every
main-report finding, most severe first (confidence calibration still
suppresses low-confidence ones).
- F10: drop 'It is not optional.' (the anti-skip rule already covers Section 2).
- F11: 'ALWAYS a smell' -> 'a smell'.
No test pins the removed text. Two eng PTY cases fail under Bun 1.3.14 and
pass under Bun 1.4.0 (CI pin). expected red until the regeneration commit
* plan reviews: '## CRITICAL RULE — How to ask questions' -> '## How to ask questions' (s04 F9, s05 L3)
The bodies are plain procedure; the caps label added nothing and competed
with the CRITICAL GAP output label. Applied in plan-ceo-review,
plan-design-review and plan-devex-review sections (s05 L3 promoted by the
plan).
W7a: test/devex-finding-fixture.test.ts:83-84 now finds the section by a
heading regex ending in 'How to ask questions'; the skill-e2e-plan-ceo-plan-mode
failure diagnosis names the new heading.
Judge anchors NOT changed here (builder E moves them to structural anchors):
skill-ceo-section-ordering.test.ts (old :938), workflow-excerpt.test.ts:109,296,
skill-llm-eval.test.ts:638, workflow-judge-input.test.ts:366,373; the mirror
in touchfiles.test.ts:219 also uses '## CRITICAL RULE'. These stay red until
E's anchor commit lands. expected red until the regeneration commit
* autoplan: phase drivers match the loaded review skills (s05 H1, s05 H2, s05 H3, s05 H4, s05 H5, s05 M5)
- H1/H2: the skip list names the current headings ('Step 0: Detect platform
and base branch', 'Design Outside Voices (independent)'); the old names
never matched, risking a duplicate base-branch detection or outside-voice pass.
- H3: the DX journey map is the 6-stage table from Step 0F, not 9 stages.
- H4: the DX checklist names Step 0 'DX Investigation' and scores only after
the evidence exists, as plan-devex-review requires.
- H5 (manual merge): the eng test-plan artifact uses the eng skill's
{user}-{branch}-eng-review-test-plan-{datetime}.md name under
$GSTACK_STATE_ROOT/projects/$SLUG (consistent with s04 F3).
- M5: the Decision Audit Trail separator has 7 columns to match its header.
No test pins the removed text. Three autoplan PTY cases fail under Bun 1.3.14
and pass under Bun 1.4.0. expected red until the regeneration commit
* plan-design-review: scope gate runs Step 0 before mockups (W5.4, s05 H6)
The scope gate said 'audit → mockups → Step 0' while the body runs Step 0
(0A-0D) first and 0D announces 'I'll generate visual mockups next'. Per the
W5.4 decision, the three gate phrases now read audit → Step 0 → Step 0.5
mockups. 'Reply with A, B, or C' is unchanged.
W7a pins:
- test/plan-scope-selection.test.ts:616 pinned the old order sentence; it now
checks the order of the 'After resolution:' steps (preamble, base branch,
audit, Step 0, mockups). Negative control: the old order turns it red.
- test/gen-skill-docs.test.ts:4737 normalizer strips the design-only
'Then run the pre-review audit, ... against that plan.' sentence by pattern.
expected red until the regeneration commit
* plan-design-review: mockup default and retrospective at normal volume (s05 M1, s05 M3, s05 M4)
- M1: 'YOUR PRIMARY TOOL' / 'The rule is simple ... Don't ask permission ...
Mockups ARE the plan' -> generate mockups without asking when the plan has
UI and the designer is available, with the reason; skip only under the
Step 0.5 conditions (which include the user's opt-out).
- M3: 'be MORE aggressive' on previously flagged areas -> check whether the
earlier issue recurs or was only partly fixed and say so.
- M4: drop the unverifiable 'Tier 2+ (15+ RPM)' rate-tier aside; keep the
one-at-a-time rule and the /design-shotgun pointer.
(s05 M2 landed with s04 F1.) No test pins the removed text; the remaining
failing case is the plan-scope-selection PTY case that fails under Bun 1.3.14
and passes under Bun 1.4.0. expected red until the regeneration commit
* plan-devex-review: DX TRIAGE keeps every pass and reports blockers only (W5.5, s05 H7)
The Mode Quick Reference let TRIAGE skip the benchmark, the magical moment
and passes 2/4-8, contradicting the anti-skip rule, the 0C target gate and
the 'executed all 8 DX passes' self-check. Per the W5.5 decision the TRIAGE
cells now read 'Target only' / 'Verify exists' / 'All 8, blockers only',
matching the Rating Method's 'flag adoption blockers; skip nice-to-haves'.
No test pins the removed cells. expected red until the regeneration commit
* ship, review, land-and-deploy, landing-report: fix stale cross-references (s06 H1, s06 H2, s06 H3, s06 H4, s06 H5, s06 H8, s06 M6)
- H1: TODOS-format cites /ship Step 14, not 5.5.
- H2: the land readiness review is the checklist /ship applies in Step 9 (there
is no Step 3.5).
- H3: the Apple adapter names the no-credential-talk rule by location instead
of 'line 14' (it renders at line 16).
- H4: greptile triage diffs against origin/<base> from the caller's detected
base, not origin/main.
- H5: the land Important Rules recap matches the steps (4-minute CI rounds in
Step 3; 30 seconds for merge readback and deploy status).
- H8: landing-report calls the util once per bump level (four), and drops the
unsupported 'cached by bun' claim.
- M6: landing-report says what its base detection does instead of claiming
it matches other skills.
No test pins the removed text. expected red until the regeneration commit
* fix(land-and-deploy): readiness gate uses the project's test command and the live eval store (s06 H6, s06 H7)
- H6 (manual merge): TEST_COMMAND comes from CLAUDE.md or AGENTS.md; if
neither documents one, ask the user instead of defaulting to 'bun test'
(wrong for non-Bun projects and a bare suite run in gstack). The audit
hunk's 'persist the answer to CLAUDE.md' write is not adopted: it adds a
write the readiness gate never had.
- H7: E2E and judge results are searched in the eval store the collector
writes (~/.gstack/projects/<slug>/evals/ and its shards/*/ directories),
then the legacy ~/.gstack-dev/evals/ fallback; the gate no longer reports
'no E2E tests run today' when results exist.
test/state-root-ratchet.allowlist.json: allowlist the EVAL_DIR line with its
reason (test/helpers/eval-store.ts writes under os.homedir()/.gstack, so the
reader must use the same path, not $GSTACK_STATE_ROOT).
Parity cap (test/helpers/carve-guards.ts): land-and-deploy maxSizeRatio
1.10 -> 1.108 (measured 1.1076 at the branch tip, including the W7f marker).
expected red until the regeneration commit
* ship: Step 9 Pass 1 defers to the checklist's critical categories (W5.3, s06 H9)
/ship restated the checklist's Pass 1 as two of its five CRITICAL categories
(missing Race Conditions, Shell Injection, Enum Completeness). Per the W5.3
decision it now names 'the checklist's Pass 1 categories', matching /review.
No test pins the removed text. expected red until the regeneration commit
* land-and-deploy: host-neutral post-merge branch example (s06 M5)
The squash-merge cleanup example created 'codex/post-merge-pr-N' branches on
every host. The example is now 'post-merge/pr-N', naming Codex Desktop's
codex/ prefix as the host-specific case and keeping the detached-HEAD reason
and the no-force-push rule. No test pins the removed text.
expected red until the regeneration commit
* ship: drop issue/incident IDs and the 'continue silently' suppressor (s06 M2, s06 M3, s06 M4, s06 M7)
- M2/M3: '(#1946)' and '(#1079)' removed from the credential guard and REST
fallback headings; the rules are unchanged.
- M4: the audit-failure fallback states the reason (a skipped audit lets
unverified plan items ship as done) instead of 'the failure shape that
VAS-449 surfaced'.
- M7: 'Continue silently — just note the counts briefly' -> report the pass
counts in one line and continue to Step 6 (Step 16 cites these counts).
Not changed: s06 M1, the Step 16 IRON LAW (UC2 gate keeps its wording).
W7a pin: test/ship-plan-completion-invariants.test.ts:127 pinned the VAS-449
sentence; it now checks that the audit-failure fallback still forbids a
silent fail-open (case-insensitive). Negative control: deleting that
sentence turns it red. expected red until the regeneration commit
* test: anchor plan-design excerpts on the question-procedure heading, not '## CRITICAL RULE' (W7a judge-anchor move; workflow-excerpt.test.ts:109,296)
The end marker now accepts a RegExp. ASK_QUESTIONS_HEADING matches the heading
with or without its 'CRITICAL RULE — ' prefix, so the excerpt is byte-identical
on the current templates and survives the s04 F9 / s05 L3 rename.
* test: plan-design judge-input case anchors on the question-procedure heading (W7a judge-anchor move; workflow-judge-input.test.ts:366,373)
* test: plan-design workflow judge ends its slice at the question-procedure heading (W7a judge-anchor move; skill-llm-eval.test.ts:638)
Judge input is byte-identical on the current templates; judge prompts and
schemas are unchanged.
* test: CEO governing-stage order anchors on the question-procedure heading (W7a judge-anchor move; skill-ceo-section-ordering.test.ts:938)
* test: dedicated-tools overlay gates on correct output plus 20% fewer Bash calls (Eng W7 overlay predicate; replaces overlay-nudges.ts:213 taskCorrect)
Every ON trial must pass the fixture's verify (already a valid-measurement
requirement) and lowerIsBetter20Pct must hold; when the OFF median is 0, every
ON trial must also be 0. assessOverlayArms enforces both through a new
fixture.gate. Overlay contract bumps to v3 so v2 records are never
reinterpreted. overlay-measurement gains rows for correct+worse (fails),
20%+incorrect (fails) and the zero baseline (passes only at 0). The prose
comment follows the s01 M1 claude.md wording.
* test: document-release E2E stops coaching the rules it measures (W7b; UC2 gate eval for NEVER CLOBBER / NEVER BUMP)
Drops the IMPORTANT block at skill-e2e-workflow.test.ts:76-83, including
'auto-approve everything' and the CHANGELOG/VERSION instructions; keeps only
the environment facts (non-interactive, no remote). Asserts the outcome: the
original CHANGELOG entries remain, VERSION still reads 1.1.1, no commit after
the fixture head touches VERSION, and README mentions Feature C.
* test: routing E2E uses the routing instruction gstack ships (W7b routing fixture; skill-routing-e2e.test.ts:113)
readShippedSkillRouting() parses the '## Skill routing' section from the
routing-injection heredoc in bin/gstack-skill-start at test time. The journey
fixture now carries that instruction instead of 'ALWAYS invoke … FIRST action.
Do NOT answer directly', and still withholds the per-skill rule list so a
regressed description can fail. bin/gstack-skill-start and the helper join the
journey, context-skills and skillify touchfiles. A free check catches heredoc
drift. Runs on unchanged templates set the new baseline.
* test: context-skills E2E routes with the shipped ## Skill routing section (W7b routing fixture)
Replaces the shouted 'ALWAYS invoke it … FIRST action' fixture and its
hand-written context-save/restore rules with the section gstack appends to
CLAUDE.md, which already routes save/resume to those skills.
* test: skillify E2E stops scripting the skill and routes with the shipped section (W7b skillify prompt + routing fixture; W7d skillify narration ban)
- CLAUDE.md fixture: the shipped ## Skill routing section replaces 'ALWAYS
invoke it via the Skill tool as your FIRST action' and its hand-written rules.
- scrape-match-path: prompt is 'Run /scrape latest hacker news stories'; the
'You MUST follow … 1. Run skill list … Do NOT enter the prototype phase'
script is gone. Asserts the outcome: the bundled skill ran, no goto
prototyping, no new skill or skillify staging written. Listing is logged.
- scrape-prototype-path: drops the five-step script and the self-fulfilling
'Suggest /skillify'; keeps the user's JSON shape request.
- skillify-provenance-refusal: prompt no longer dictates the refusal.
- Narration grader moves to helpers/skill-body-narration.ts: line-start
'I '/'I'll '/'Let me ' plus mid-sentence 'let me <verb>', so 'let me know'
is legal. Stored known-good/known-bad bodies show it still rejects every
known-bad case the old /Let me /i ban caught.
* test: land-and-deploy E2Es state environment facts instead of scripting the skill (W7b deploy prompts)
The workflow, first-run and review-gate prompts drop the 'IMPORTANT … simulate:
1. Detect … 2. Infer … 3. Note …' scripts and the answers they supplied
(platform, app, URL, merge method, 'Eng Review should be NOT RUN'). They keep
the facts the fixture cannot provide (no remote, no PR, gh/fly unavailable,
gstack-review-read output, report directory). Assertions now check the outcome:
the artifacts name Fly and test-app, and the readiness report records the
missing review. Canary, benchmark and setup-deploy prompts are unchanged.
* test: ship triage asserts each failure's in-branch/pre-existing label (W7b ship triage)
The old check passed if the words 'in-branch', 'pre-existing', 'math' and
'string' appeared anywhere in the final message, in any pairing. The prompt
now asks for a closing JSON map; helpers/ship-triage-labels.ts reads it (or
unambiguous per-failure lines) and the test requires truncate/string ->
in-branch and divide/math -> pre-existing, plus a Bash call that ran the
suite. Stored outputs show swapped, words-only and one-label runs fail.
Drops the untyped recordE2E extras (typecheck baseline shrinks by one).
* test: design-review-fix asserts a fixed design issue, not only the Aside ritual (W7b design-review-fix)
Keeps the engine-routing checks (Aside driven, retired binary unused) and adds
the outcome: design-audit.md exists, names a seeded defect, and index.html or
style.css differs from the initial fixture commit. The style(design) commit
prefix is not required. This case still cannot gate the design-review
stop-condition rewrite (it self-skips without Aside and caps fixes in its
prompt), per the Eng item.
* test: CEO HOLD preservation grader checks the decision, not its phrasing (W7d CEO mode-routing regex judge, ceo-mode-option.ts:410-440)
Drops the exact 'Keep <x> in scope' / 'Defer <x> to TODOS' labels, the
'D<n> — Keep … in scope, or defer' title, the '<plan>.md lists' phrase and the
2-of-5 keyword quota. Keeps the evidence bindings (native answer, session,
timestamps, source read, mode context, later withdrawal) and now requires: one
keep option and one defer option, the answer selects keep, a word of the kept
label names a listed plan requirement, no expansion language, and an ELI10 +
Stakes rationale of at least 20 words (so a bare mode label still fails).
Stored captures: both retained known-good runs pass; every existing known-bad
mutation still fails; four rewordings the old grader rejected now pass; three
new known-bad cases fail. The Net/Note single-brief checks (t02 #3) are
unchanged: the 'second sentence after Net' row adds scope ('Also add shared
views'), so it stays a known-bad.
* test: docsync observer accepts harmless read wrappers (W7d docsync observer)
docsCommandAllowed now unwraps, on read-only commands only (pwd, ls, cat,
stat, sha256sum, Git reads): a leading 'cd <fixture repo> &&', '2>/dev/null',
a trailing '|| true', '--no-pager', '-C <fixture repo>' and '-c' with
core.pager=cat / core.quotepath / color.* settings. Lifecycle and script calls
stay literal so their failures cannot be suppressed. Writes, other repos,
--git-dir/--work-tree, config that can execute code, real composition and
redirects stay rejected.
Stored commands (fixtures/docsync-observer-commands.json): 11 known-good read
forms, which the old observer rejected, now pass; all 17 known-bad forms still
fail under the new and old observers. docsync-command-grammar moves its three
harmless rows to an accept test and keeps unsafe variants of them as rejects.
* test: AUQ matrix fails only on the format fields software reads (W7d AUQ matrix emoji check)
auqMachineFormatProblems() fails a first-question run when the
Recommendation: line is missing or empty, or when the brief does not label
exactly one option (recommended); recommendation substance >= 4 is unchanged.
ELI10, Pros / cons, ✅/❌ and Net: are still scored and logged but no longer
fail a paid case. scoreAuqFormat and the consistency suite are unchanged.
Stored briefs: three known-good (including one without emoji or Net) pass;
four known-bad (no or empty Recommendation, zero or two (recommended)) fail.
* test: coverage audit grades a closing tested/untested summary before the diagram grammar (W7d coverage-audit-evidence)
The diagram grammar grew through four waves of capture patches to accept
correct-but-different diagrams. The E2E prompt now asks for one closing JSON
line {"tested": [...], "untested": [...]}; coverageAuditVerdict passes the
outcome when processPayment is only in tested and refundPayment only in
untested (last summary wins; quoted or example summaries ignored). The legacy
grammar stays as a fallback, so every stored capture keeps its verdict
(all existing rows unchanged). Read evidence and capture success are still
required. Stored summaries: three known-good (which the old grader rejected)
pass; seven known-bad fail.
* test: disabled outside-plan grader reads the run's own coverage self-report (W7d disabled-plan-review-evidence)
The false-completion oracle kept being patched to tell historical review-log
mentions from current claims. The E2E prompt now asks for a closing JSON line
{"outside_review_this_run": ...}. When present, the coverage claim is that
report ('completed' fails) plus any undenied 'both reviewers agree';
'disabled' also satisfies attribution. Runs without it keep the existing
prose oracle, so all stored captures and mutation rows keep their verdicts.
Dispatch, CLI execution, preflight and persisted-disabled checks are
unchanged. Stored outputs: three known-good pass (the old grader rejected
the table form); four known-bad fail.
* test: investigate boundary grader checks the verified fix, not one Edit and one verify (W7d investigate exactly-one ritual)
Completion now needs at least one allowed Edit, the correction in place, at
least one verifier run whose final status is 0, and no edit after the final
verification. The ending-error case still requires a single verifier run
(status 69), because that fixture's error tells the actor to stop without
retrying. Ownership acquisition/release checks are unchanged. New free
protocol controls: a passing re-verification passes (the old grader failed
it); a failing final re-verification and a retry after the ending error both
fail, as they did before.
* test: CEO split-overflow call floor is two, the minimum for five options at four per call (W7d split-overflow 4-call floor)
The regression is a candidate silently dropped to fit the four-option cap.
The scope validator already requires an offered Include/Defer/Cut disposition
for all five candidates; the extra N-1 call floor failed agents that batch
compatible candidates, which the test header calls legitimate. FLOOR now comes
from CEO_SPLIT_CALL_FLOOR = 2. Stored shapes (ceo-split-floor.test.ts): five
sequential, 2-call and 3-call batches pass; a dropped candidate fails with
'missing target decisions'. The registration controls keep their verdicts;
the 3-call plan_ready scenario still fails, now on missing decisions.
* test: shared-libs PR coverage checks the stated page budget, not per-PR ceilings from one run (W7d shared-libs per-endpoint page caps)
prCoverageRequestViolations keeps the skill's stated older-open-PR budget
(five metadata pages, fifty file-list pages plus recent PR 7) and the coverage
outcome (PR 42's file list read from page 1 through page 2). It drops the PR 42
three/four-page and single-first-page ceilings, which were tuned to one
observed capture with a truncated first view. The judge criteria are
unchanged. Stored endpoint lists: three known-good (including a re-read first
page the old ceilings rejected) pass; four known-bad plus an over-budget
file-list run fail. incompleteFirstFileView is no longer used by the paid case.
* test: test-value review accepts any caller search, not only the literal 'git grep' (W7d literal git grep in test-value)
recordsNonTestCallerSearch keeps the value-card contract (non_test_callers
recorded) and accepts git grep, rg, grep or the Grep tool as the search.
Severity checks and the golden exclusion are unchanged. Stored evidence:
four known-good (three the old check rejected) pass; three known-bad (no
search, no caller count, prose only) fail.
* test: plan-format accepts any statement that kind-differentiated options are not comparable on coverage (W7d 'options differ in kind' phrase)
The outcome, no fabricated Completeness: N/10, stays asserted. The required
note now matches any brief wording of the same fact (KIND_NOTE_RE in
helpers/plan-format-kind-note.ts). The format-compliance suite that pins the
declared kind-note string is unchanged. Stored lines: four known-good pass,
three known-bad (a completeness score, a recommendation, 'kind to the user')
fail.
* test: plan-mode smokes check the targeted plan, not the scope-gate announcement, and reject plan-file ## Decisions (W7d exact scope-gate line; W7g plan-mode ## Decisions)
- Seeded eng/design plan-mode cases keep 'no scope menu' and replace the
exact 'Scope gate: plan mode — auto-selected B' requirement with
seededPlanTargeted(): the announcement or native seeded-plan selection, or
seed-only plan names appearing in the review output after the slash command
(trackTokens). The announcement is logged.
- The AskUserQuestion format forbids writing a decision to the plan file as a
substitute for asking. assertNoPlanFileDecisions() fails any plan_ready run
whose plan carries ## Decisions (eng, design, devex, office-hours
auto-mode). The AUQ-blocked cases (eng seeded, devex, office-hours) now
require outcome 'asked' (AskUserQuestion variant or prose fallback).
- plan-mode-evidence registration controls keep their verdicts; the
missing-decisions control now fails on 'without a question'.
- plan-mode-targeting.test.ts stores known-good (announcement; paraphrase plus
seed content) and known-bad (neither; an untracked token) observations and
plan files with and without ## Decisions.
* test: plan-design judge selection check anchors on the question-procedure heading (W7a judge-anchor move; touchfiles.test.ts:219)
Same structural anchor as the other judge-anchor moves; selects the same text
on the current templates and after the '## How to ask questions' rename.
* test: CEO plan-mode failure message names the current rule, not the '## CRITICAL RULE' heading (t13 F20)
* test: browse reference judge gates on its stated floors; the baseline comparison is recorded, not a ratchet (W7d browse judge baseline ratchet; t08 F7)
expect(regressions).toEqual([]) compared a noisy three-sample mean against
eval-baselines.json (clarity 4), silently raising the stated clarity floor of
3. The comparison stays in judge_reasoning; pass and assertions use
BROWSE_JUDGE_FLOORS (clarity 3, completeness 4, actionability 4). Judge
prompt and schema are unchanged. Stored panel means: three known-good (two the
ratchet rejected) pass; three below-floor panels fail.
* test: eval-kinds drops the exact 22 behavior / 25 judge census (W7d exact count in eval-kinds; t12 F6)
The kind contract is already asserted: every live case has one kind, kinds
are rule/behavior/judge, every LLM judge is judge-kind, every behavior case
has a literal registration and a BEHAVIOR_WHY, and the named contract-shaped
cases stay rule. The census count only broke on adding or retiring a case.
* test: plan-eng artifact case binds to the hermetic state root and requires the artifact; report case drops its shouted requirement (W7g plan-artifact fixture binding; W7g skill-e2e-plan.test.ts:479,720)
- plan-eng-review-artifact: actor, observer and cleanup use one isolated
GSTACK_HOME (the hermetic run's, or a seeded temporary one when hermetic
mode is off) and the slug gstack-slug resolves for the fixture, instead of
os.homedir()/.gstack/projects/test-project. A guard refuses a state root
under the real home, and cleanup removes only the fixture's project
directory. The 'IMPORTANT … you MUST write the test-plan artifact' line is
replaced by the environment fact (state root and slug). The soft warning
becomes an assertion: exactly one new *eng-review-test-plan-*.md about the
reviewed dashboard change.
- plan-review-report: removes 'CRITICAL REQUIREMENT … MOST IMPORTANT
deliverable' and the restated report contract; keeps 'plan.md is the plan
file'. The existing assertions (report present, last, rows, unresolved
status) now measure the skill's own report prose.
* test: session-runner-tools checks harness prompt properties, not a byte-for-byte copy (W7e session-runner-tools.test.ts:544; t09 F7, F8)
The ship capture prompt test asserts its purpose (no CEO-only writing
guidance) plus the functional rules: one allowed skill path, AskUserQuestion
unavailable, the section Read rule, no git/gh/mutation, and the REPORT.md
path. The two 'MUST actually Read' pins match the Read rule case-insensitively.
Negative control: dropping the no-mutation rule from the harness prompt turns
the test red.
* test: section-capture native tools checks harness prompt properties, not a copied golden (W7e section-capture-native-tools.test.ts:467; t04 F4)
Asserts the absolute skill path is the only SKILL.md named, the scenario,
AskUserQuestion unavailable, the section Read rule (case-insensitive, also at
:308), no git/gh/mutation, and the REPORT.md path. argv/tool-list checks are
unchanged. Negative control: dropping the no-mutation rule turns it red.
* test: office-hours review-preservation judge test keeps its schema and untrusted-data checks, not its wording (W7e office-hours-completion.test.ts:416-429; t09 F10)
Drops 13 phrase pins on the judge prompt. Kept: both inputs carried as JSON,
the response schema (wire format), and the separate untrusted-DATA test. The
validator behavior tests already use stub judges. Negative control: changing
the schema string in the prompt builder turns the test red.
* test: docsync lifecycle interface drops pins on its own helper prompt (W7e docsync-lifecycle-interface.test.ts; t02 #17)
docsNativeInterface is the test helper's own prompt, so its sentence pins
only checked that the helper says what it says. Kept: owned skill path, the
two extracted lifecycle commands (exact), the scripts-list interpolation, the
repo path and Git read examples, and every docsCommandAllowed /
docsToolFailures behavior check that enforces the interface.
* test: shared-libs revalidation prompt keeps its machine-shaped checks, not ~69 phrase pins (W7e shared-libs-revalidation-prompt; t11 #3, #8; t05 F17)
reviewRevalidationPrompt and reviewPrompt are test-owned harness prompts
(non-test callers: 0); the paid shared-libs E2Es measure whether they work.
Kept: the three exact receipt commands, base-prompt prefix and resumed suffix
identity, branch selection (actor / default / resumed coverage), the state
path and turn-budget interpolations, read-record-before-diff and
first-response-before-start ordering, no embedded token, no supplied Skip
answer, reusable:true before reusable:false, the captured R59 stage boundaries
in the exclusion list, asset roots and interfaces, and the stale step-6
reference ban. The review template's Step 4.7/4.8 completion rule is matched
by step number on one line, not by sentence. Negative control: reordering the
diff-read instruction turns the test red.
* test: plan-design SDK fixture pins its harness prompt once, by ordered properties (W7e plan-design-sdk-fixture.test.ts:91-120; t01 F13)
The prompt was pinned three ways (sha256, ~20 sentences, an order check).
Kept: the skill and lazy-section paths, the plan path, the ordered
read -> review -> edit -> Write -> read-back -> summary steps, and the
no-browsing rule (case-insensitive). Dropped the hash and sentence pins.
Negative control: removing the read-back step turns it red.
* docs: overlay benchmark contract v3 (dedicated-tools gate = correct output + 20% fewer Bash)
* test: dedicated-tools overlay case pinned to claude-opus-5-5 (E2)
* chore: regenerate SKILL.md, goldens and context-budget fixture for the Opus 5.5 prompt cleanup
* document-release: CHANGELOG-preservation and VERSION-ask rules at normal volume (s10 M4, M5; UC2, eval-gated)
* chore: regenerate document-release
* Revert "test: dedicated-tools overlay case pinned to claude-opus-5-5 (E2)"
This reverts commit 737bf478d9.
* test: memory-pipeline E2E seeds transcript consent (W4 consent-first default)
* test: plan-review-report free check follows the de-coached prompt (W7g)
* test(W7h): drop issue-number pins in land-and-deploy-postfail, match guards case-insensitively
W7h (t09 F12, F13). One test file.
Removed assertion groups:
- `cli/cli#3442` / `cli/cli#13380` pins (t09 F12). Invariant: none of its
own (upstream archaeology; the IDs stay in the template, only the pin goes).
The behavior they decorated, "after any non-zero `gh pr merge` exit, query
authoritative state before retrying", is now a kept free meaning check.
- `Universal invariant` label pin. Invariant: query-before-retry. Remaining
protection: the new case-insensitive check
`/non-zero exit from `gh pr merge`, query authoritative PR state before retrying/i`
(stronger: the mutation that inverts the rule now goes red; the old test
stayed green).
Loosened to case-insensitive meaning checks (kept, W7 keep list, data-loss
and destructive-op guards): STOP worktree cleanup without removing, no
`--force`, primary working tree never removed, CLOSED -> stop, never replay a
merge after MERGED, one direct fallback, no fallback from a direct attempt,
the OPEN/no-auto/no-queue fallback precondition, branch-absent vs check-failed
messages. Gate-tier E2E also covering the flow: land-and-deploy-workflow
(gate), judge `land-and-deploy/SKILL.md workflow` (gate lane).
Cosmetic pins dropped (no control needed): capitals on STOP / Do NOT.
Mutation log: .context/mutation-land-and-deploy-postfail.md (12 mutations,
0 unexpected: reorder, field delete and 7 safety deletes red; 3 rewordings green).
* test(W7c): ship-apple-gate matches its gates on meaning, not capitals
W7c (t06 #19). One test file.
Removed assertion groups:
- "A genuine blocker may require a safety or named documentation-risk
decision" and "routine interactions and blocking decisions above" sentence
pins. Invariant: routine release authorization never waives a blocking
safety/docs decision. Remaining protection: kept free meaning check
`/stop for that decision rather than treating release authorization as a waiver/i`
plus `/named documentation-risk exception before distribution/i`.
- Full-sentence "in `read-only` mode against the selected release source".
Invariant: the docs preflight is read-only. Remaining protection: kept free
check on "`read-only` mode".
Loosened (case-insensitive, kept): apply-only-to-repository-landing scope
line, CLASSIFY-before-credentials (credential boundary), never abort a store
release over branch topology (demonstrated failure), two routine interactions
(numeric limit), stop-for-decision (consent/stop line).
Kept unchanged: manifest trigger routing, Apple read before the branch gate,
byte-exact branch gate appearing once, docs preflight before the
authorization moment, fastlane/iris/appPriceSchedules command anchors,
stale-wording bans. No gate-tier E2E covers the Apple adapter, so every
invariant keeps a free check here.
Cosmetic pins dropped: capitals on ONLY / CLASSIFY / STOP.
Mutation log: .context/mutation-ship-apple-gate.md (14 mutations, 0
unexpected: 2 reorders, 1 marker and 6 safety mutations red; 5 rewordings green).
* test(W7c): ship-reentry-gates keeps stop/consent meaning, drops sentence pins
W7c (t08 F3). One test file.
Removed assertion groups (invariant -> remaining protection):
- "Retain queued fixes and restore coverage" -> a missing reviewer keeps
queued fixes: gate E2E ship-skipped-queued-finding (gate) and judge
`ship/SKILL.md workflow` (gate lane); the stop itself stays a free check.
- qa decline print line ("Test bootstrap previously declined — skipping.")
-> qa skips bootstrap after a saved decline: kept free meaning check
`/BOOTSTRAP_DECLINED ... skip the rest of bootstrap/i`.
- "with the user's free-text evidence" -> UNVERIFIABLE items are confirmed
one by one: kept free `/per-item confirmation/i` here plus the
blanket-confirm check in ship-plan-completion-invariants.
- Docs reentry sentences ("On reentry, reuse only ...", its duplicate, "base/
input hashes still match", "retain its actual status and scope", "Otherwise
use Blocked recovery ...") -> reentry reuses only this invocation's
validated evidence: kept free checks "never reuse an audit across
invocations" and "reentry never resets the count or authorizes a launch";
gate E2Es ship-docsync-stale-before, ship-docsync-stale-after,
ship-docsync-recovery, ship-docsync-late-result (all gate).
- "left uncommitted after Step 15" -> late commits take only remaining
changes: kept free "never create an empty commit" and "preserve unrelated
user files"; gate E2E ship-local-workflow (gate).
Loosened to case-insensitive meaning checks (stop/consent/approval lines,
always kept): STOP blocks advancement, answer each AskUserQuestion, routine
authorization never waives gates, dispatched-reviewer-missing -> stop,
CYCLES >= 3 -> stop, Any N -> stop as NOT DONE, resume only after verified,
no second deferral, per-item confirmation, explicit Add-tests choice overrides
the decline for this invocation only, framework approval, first entry
launches the audit, no third attempt, unwaivable redaction/security gates.
Kept unchanged: bootstrap branch order, no `rm` in the decline branch, the
Step 14 -> 14.5 routing line, stale-string bans, `NEW_TITLE` field and
`--title "$NEW_TITLE"`.
Cosmetic pins dropped: STOP capitals, "mandatory".
Mutation log: .context/mutation-ship-reentry-gates.md (17 mutations, 0
unexpected: 1 reorder, 2 marker and 9 safety mutations red; 5 rewordings green).
* test(W7c): shrink ceo-workflow-clarity to structural and meaning checks
W7c conversion (t05 F5-F8). Pin lines 48 -> 29 (toContain|toMatch|indexOf|includes|ordered); sentence pins
collapse to one case-insensitive meaning check per invariant. Per the Eng
"Retirements" item, CEO invariants count as periodic-only once
plan-ceo-review-benefits retires, so every invariant below keeps a free check.
Removed assertion groups (invariant -> remaining protection):
- Required/Pending/Settled status sentences (4 pins): pending work stays
unapproved; only exact authority settles a choice -> kept free: label order
plus /Pending: unapproved/i and /Settled: ... a recommendation does not/i.
- Admin-route sentences (Skip steps 1-4, 0E/0H ownership, admin answer that
requests a plan change, 0G proposals use this route, mode-change pointer):
admin menus approve nothing and return locally -> kept free: Admin < Plan
decision < steps 1-4 < checkpoints order, /this approves no plan changes/i,
/0D returns to its caller, not to mode selection/i.
- not.toContain('0D never restarts mode selection') and
not.toContain('using the Step 0E mode-handoff format') (t05 F8, bans of
retired phrasings): same invariants -> kept free: the positive route checks.
- '**STOP for the actual answer, even for a lone option.**' exact bold pin:
wait for the answer before recording -> kept free: /stop for the actual
answer/i, located between step 4 and the post-answer checkpoint.
- Mode-change sentences (repeat handoff record, complete newly applicable
Step 0 work, resume the paused step): a mode change waits for an answer ->
kept free: /pause and ask ... keep the mode until answered/i and
/selecting a mode does not approve changes/i; routing table rows kept exact.
- Scope-count sentences: reuse counts against limits, mode recommendation
excludes unchanged reuse, neither approves -> kept free: three short
case-insensitive meaning checks plus the >15 / 8-file / 2-class numbers and
the route order.
- Completion-fraction sentences (select answered questions, exclude unscored,
Y/X definitions): fraction definition -> kept free: 10/7/3 scale, reopened
choice counted once, 'Report X/Y, or `N/A` when Y is zero' (output field).
- Section-gate sentences ('0D's Plan decision route through its post-answer
save', 'Resolve critical risks now') and the literal Decision gate count 11
(t05 F7): one gate per section -> kept free: path order, /no path selects
the mode again/i, gate count derived from '### Section N:' headings.
- Section 1 opening sentences (retain mode/rationale, governing row ID): Section
1 publishes current dispositions, not a mode handoff -> kept free:
**Current scope** present, the four disposition names, /not another mode
handoff; do not ask or log the mode again/i.
Gate-tier judge that also grades this prose: 'plan-ceo-review/SKILL.md modes'.
Mutation pass (scratch worktree, generated plan-ceo-review skill): 16/16 as
expected; 11 kept-step/marker/safety/numeric mutations go red, 5 rewordings of
dropped sentences (and a lowered-register STOP line) stay green. Log:
.context/mutation-ceo-workflow-clarity.md.
* test(W7c): shrink eng-review-routing to structural and meaning checks
W7c conversion (t02 #4-#10, W7a s04 F15 pin). Pin lines 88 -> 74 (toContain|toMatch|indexOf|includes|ordered); ~50
full-sentence pins become order checks, field/marker checks and short
case-insensitive meaning checks. Remaining gate-tier judge for the plan-eng
prose: 'plan-eng-review/SKILL.md sections' (judge input is ENG_REVIEW_EXCERPT,
which the first test proves contains review-sections and Recovery routing).
Removed assertion groups (invariant -> remaining protection):
- Preparation sentences ('Follow the blocks below in order after startup',
'Confidence Calibration and Decision procedure are reference rules'): blocks
run in order -> kept free: heading order check now starts at
'## Review preparation'; judge 'plan-eng-review/SKILL.md sections'.
- Priority/compression sentences ('Shorten only optional commentary', 'never
Scope Challenge, Sections 1-4...', 'Never condense, abbreviate or skip a
section'): compression cannot drop required stages -> kept free:
/complete every required stage, decision gate and output/i and the
'Everything else' stale ban; judge.
- Exact seven-label toEqual on Scope Challenge assessments (t02 #8): all
seven checks present -> kept free: arrayContaining on the same labels plus
the A/B/C heading toEqual (excerpt anchors).
- 'Complete these checks before the complexity decision in B': A runs before
B -> kept free: heading order A < B < C.
- Below-threshold / findings sentences (numbered step full sentences): C
always runs, findings approve nothing -> kept free: step-number order,
/fewer than 8 files AND fewer than 2 new classes/i, /run C whether B was
completed or skipped/i, /approve no remedies/i, '"No issues found"'.
- '... STOP before Section 1' exact caps (t02 #4): high complexity halts ->
kept free: /at 8\+ files or 2\+ new classes\/services, stop before
section 1/i.
- High-complexity sentences ('With no proposed cuts...', 'Both retain the same
approved feature list...', 'Initial scope selectors need no grid...'): cuts
and structure asked separately -> kept free: step order with short anchors,
'Pending remedies not decided here: <ids>' field; judge.
- Smaller-arrangement sentences ('offer confirmation of the original
arrangement or a pause', 'then return to this structure selector'): a pause
authorizes no cut -> kept free: order + /do not continue to C until it is
settled/i + /investigate only the agreed question/i.
- Selector summary sentences ('post-answer scope summary, not a remedy's pending
ledger record', 'Do not invent a pre-answer record afterward', 'Scope
Challenge B also uses its own selectors'): answers saved before applying ->
kept free: field template order, /a failed save or read blocks
advancement/i, '**not persisted**', /these selections approve no
engineering remedy/i.
- Decision-procedure Read-choreography anchors ('use Read to fetch the entire
saved record', 'Read the entire resolution block, including State') and the
bold '**STOP until the actual answer arrives.**' anchor (t02 #5/#6, s04 F18):
ask once, wait, record before the next choice -> kept free: Compare <
Pending-record checkpoint < Send once < AskUserQuestion call < Record < next
choice, /stop until the actual answer arrives/i located between Send and
Record, /do not apply a remedy ... while the choice awaits an answer/i,
/approves no implementation/i; AUQ completeness and kind-note strings kept
exact (plan-tune reads them).
- 'An Investigate/Defer option must bound the investigation', 'Apply the
preamble's Completeness scores or kind-note accordingly': judge only (gate).
- Research/outside-voice sentences ('If Aside is unavailable, use host
WebSearch', 'Record the actual coverage...'): unavailable research is
recorded, not hidden -> kept free: exact 'Search unavailable' output string,
'Outside voice: recorded provider, completed / unavailable / disabled /
skipped (reason)' field, /only completed reviews enter cross-model tension/i,
TODO < Approval readiness < Required outputs order.
- Recovery sentences: kept as /i meaning checks (ExitPlanMode/telemetry wait,
do not resend, stop before dependent output, no chat-only success, skip
forbidden writes); 'If no recovery is specified or it fails' full sentence
-> kept free: 'follow **Blocked outcome**' routing; OUTCOME=error kept.
- Late-change sentences ('Refresh affected tests, tasks, dependencies and
parallelization', 'Unchanged saved outputs may reuse their successful Review
Log'): rerun affected outputs before navigation -> kept free: order of
return/Decision procedure/Approval readiness/Required outputs/navigation and
the stale-evidence Blocked outcome route; judge.
- Final sequence anchor 'Run Learning hooks, including gated Brain Calibration
Write-Back; then return to the entrypoint's Section self-check' -> kept
free: 'Section self-check' as the last ordered anchor.
- Coverage-audit sentences ('For each existing or proposed component in the
selected target', 'the selected target. For each existing or proposed
feature', 'dedicated tool call before drawing the diagram' (s06 L9
choreography)): plan diagrams cover proposed paths, ship covers changed code
-> kept free: /existing or proposed (component|function\/method)/,
/future paths remain proposals/i, the four 'Every ...' obligations,
/no skipping regression coverage/i, ship has no 'existing or proposed';
gate E2E plan-eng-coverage-audit.
- Brain write-back ordered prose list ('reserved default-off gate', 'this
runtime does not set it', 'not an instruction to write now', t02 #9 / W7a
s04 F15): no gbrain write without the default-off gate and trust policy ->
kept free: 'Skip unless `BRAIN_CALIBRATION_WRITEBACK` is set' precedes both
write tools, eng prefix says /skip this section/i and /do not enable it or
infer permission/i, trust-policy key, /if unknown, skip/i, no env
interpolation, other skills carry no eng-only skip prefix.
Mutation pass (scratch worktree; plan-eng-review templates and
scripts/resolvers/gbrain.ts): 21/21 as expected; 14 reorder/marker/stop/
approval/consent/numeric mutations go red, 7 rewordings of dropped sentences
and lowered-register STOP lines stay green. Log:
.context/mutation-eng-review-routing.md.
* test: fold the harness-freeze fixture tests into the tests that own their helpers (test-of-test ratchet)
Seven new files imported only test code; their stored known-good/known-bad
rows move unchanged into the owning tests:
- auq-matrix-format-gate -> auq-native-capture.test.ts
- browse-judge-floors -> workflow-judge-cache.test.ts
- ceo-split-floor -> plan-review-cases.test.ts (one block appended at the end)
- plan-mode-targeting -> plan-mode-evidence.test.ts
- shared-libs-pr-coverage-budget -> shared-libs-fixture.test.ts
- skill-body-narration -> skill-fixture.test.ts
- test-value-seam-evidence -> test-value-bar.test.ts
plan-format-kind-note and ship-triage-labels have no other owner, so each now
checks its grader against the production source it grades: the kind note
generateAskUserFormat prescribes, and the in-branch / pre-existing labels in
ship/sections/tests.md.tmpl. No BASELINE entries added.
* test(W7c): ship-plan-completion-invariants keeps tokens and gates, drops prose
W7c (t06 #9, #10, #11; #7/#8 already landed with W7a). One test file.
Removed assertion groups (invariant -> remaining protection):
- Execution-only extraction sentences ("implementation and test-creation
requirements", "retain its command, expected outcome and source verbatim",
"not EXTERNAL-STATE merely because ...", "Keep genuine external-state ...")
-> execution-only checks route to Step 8.1/9 outside counts and are never
DONE statically: kept free checks `Step 8.1/9`, outside implementation
counts, `never DONE from static inspection`, do-not-waive; gate E2E
ship-exploratory-plan-checks (gate).
- Plan-verification prep sentences (~17: "Clarify unknown outcomes", browser
vs functional items, "An API URL is not automatically a page", "Only browser
evidence needs screenshots", smoke-budget and command-limit sentences, risk
acceptance wording) -> plan checks are collected now, executed by the Step
9.2.1 owner before Fix-First, and never silently waived: kept free checks on
the heading list, `Collect now; execute in Step 9`, `Step 8.2`, `Handoff to
Step 9.2.1` order, `before Fix-First`, never silently waive, noninteractive
-> blocked, the `VERIFY_RESULT=` line and `## Verification Results`; gate
E2Es ship-exploratory-plan-checks, ship-exploratory-small-cli (gate).
- Parent-processing duplicates on the generated section (same pins as the
template test) -> kept on the template test; the generated copy keeps
section order + seven-field anchor; freshness via gen-skill-docs.
- "Check the task's terminal status", "recording the reason in the PR body and
Step 20 metrics" -> failed audits use the fallback: kept free LAST-line JSON
-> audit-failure fallback check and `(recommended/default)` marker.
- Step 16 evidence sentences ("Independently prove ...", "exact command, exit,
timestamp and log", "This recovery also applies ... stage 5") -> storage
failure is not stale input: kept free table-row structure, storage column
must not rerun `gstack-evidence run`, STALE/MISSING without proof, ledger
unavailable never FRESH; judge `ship/SKILL.md workflow` (gate lane).
- "Each commit must work independently" -> bisectable commits: kept
`bisectable commits`, `continue to Step 16`, no empty commit, history-
rewrite bans; judge `ship/SKILL.md workflow` (gate lane).
Loosened to case-insensitive meaning checks (kept): per-item confirmation,
blanket-confirm ban, classified DONE/NOT DONE by `[ -f` (MUST dropped), stop
publication on new/changed/unwaived test failure + `Run Steps 5–15`, waiver
reuse limited to verified pre-existing failures, fetch/push failure -> stop,
never rewrite history, only a successful push, stop live child before inline
audit, never race a late result, AskUserQuestion on second failure.
Kept unchanged: seven-field JSON contract parse, review-mode negatives,
CONTENT-SHAPE/validator tokens, Step 14 deferral routing, CHANGELOG negatives,
the executed push-idempotency shell test.
Cosmetic: MUST / mandatory / Do NOT capitals; "VAS-449" dropped from the
describe title.
Mutation log: .context/mutation-ship-plan-completion-invariants.md (19
mutations, 0 unexpected: 3 reorders, 4 markers, 7 safety red; 5 rewordings green).
* test(W7c): shrink eng-scope-entry-ap to structural and meaning checks
W7c conversion (t05 F1-F4; W7a s04 F15/F18 pins). Pin lines 97 -> 69
(toContain|toMatch|indexOf|includes|ordered). The AskUserQuestion-format
byte-equivalence test (t05 Kept) is unchanged. eng scope-gate E2Es are
periodic (plan-eng-review-plan-mode), so every scope-gate invariant keeps a
free check; duplicates of eng-review-routing cite that file.
Removed assertion groups (invariant -> remaining protection):
- 'Reply with A, B, or C. STOP and wait' order anchors (t05 F1): menu before
bootstrap -> kept free: the consumed prefix 'Reply with A, B, or C'
(pty/classify.ts, pty/judge.ts) before {{PREAMBLE}}, {{GBRAIN_CONTEXT_LOAD}}
and the first ```bash; new presence checks for the announcement and menu
after '## Scope gate' (an indexOf of -1 used to pass the order check).
- Preamble 'starting from the Scope gate...' exact pin: kept as /i meaning.
- Scope entry sentences ('Before discovery tools or preamble, check provided
messages...', 'Do not probe for session state', 'When no exception above
applied:', 'Announce an auto-selected plan in one line...', 'A fresh
announcement made before skill loading...', 'Step 0 below still verifies or
sends the public auto-selection line...') (t05 F4): target bound before
bootstrap and announced -> kept free: announcement/menu-before-bootstrap
order checks above, /first tool call = AskUserQuestion/i, /clarify
ambiguous, conflicting, quoted or stale targets/i; periodic E2E
plan-eng-review-plan-mode.
- Startup step sentences ('3. Check web-research readiness at ...', '4. Run
**Design Doc Check**, then ...', 'Keep the reviewed target fixed', 'Continue
at ...'): startup order -> kept free: ordered startup anchors (now including
Prerequisite Skill Offer), '**Engineering review → Step 0**' pointer, the
stale-path ban; 'Keep the reviewed target fixed' stays pinned (/i) in
eng-review-routing.test.ts.
- Entry anchors 'Before Step 0, require resolved scope' and '**Complexity
gate:** while a Scope Challenge complexity question' -> shortened anchors
'require resolved scope' and '**Complexity gate:**', same order check.
- Plan-selection exception sentences and 'If the tool is unavailable,
disallowed (`--disallowedTools`) ... send the menu as plain prose and STOP'
(t05 F4): pasted text is not a mode signal; ambiguity and named targets ask;
unavailable tool stops -> kept as /i meaning checks for each (safety and
consent lines); A/B/C menu body kept exact (consumed by the PTY classifier).
- 'Reply with A, B, or C. STOP and wait for the answer.' exact: kept as the
exact prefix plus /reply with A, B, or C\. stop and wait for the answer/i.
- Judge-bundle sentences ('format/transport rules apply throughout', 'Follow
the blocks below in order after startup', 'It may be the selected plan or a
separate file', 'Save permitted auxiliary artifacts under the write policy'):
ordering and write permission -> kept free: stage order, write-policy table
rows exact, /permission for one path authorizes no other/i, /defer ...
telemetry and plan status footer to finish/i, forbidden-log Blocked outcome
route (/i), section Read paths, log exit-code tails.
- Complexity-path duplicates of eng-review-routing (t05 F2: 'Complete these
checks before...', 'After verification, apply only accepted scope changes',
'Run C whether B...', 'Always ask the structure question...', post-answer
summary/Read-back sentences, 'A failed save or Read blocks advancement',
'Findings and scope answers approve no remedies', 'Continue to Section 1
only when...', 'Send one question object for one choice', 'Compare every
native field...', 'Repair any difference and repeat the complete Read
before asking', 'Read the selected saved label...', 'Check the save result,
then Read the entire resolution block', '**STOP until the actual answer
arrives.**', the Paused question / Blocked outcome lines): the same
invariants -> kept free in eng-review-routing.test.ts (order of
Send/AskUserQuestion/Record, /stop until the actual answer arrives/i, failed
save blocks, approve-no-remedies, Paused/Blocked recovery checks) and
auq-format-always-loaded.test.ts (one question object per choice); here:
A/B/C stage order and the 8-file / 2-class thresholds (/i, no caps STOP
literal), Recovery routing pointer for unreadable records. The Read-back
choreography is the dated text s04 F18 flags; judge
'plan-eng-review/SKILL.md sections' (gate) grades the procedure.
- Calibration note exact sentences and the one-line formatting pin (t05 F3,
W7a s04 F15): no shipped source enables BRAIN_CALIBRATION_WRITEBACK ->
kept free: {{BRAIN_WRITE_BACK}} once after {{LEARNINGS_LOG}}, /never set it
yourself/i, and a new code check that no file in bin/, lib/ or scripts/
assigns or exports BRAIN_CALIBRATION_WRITEBACK (only the gbrain resolver
names it).
Mutation pass (scratch worktree; plan-eng-review templates, generated
plan-eng-review skill, bin/gstack-config): 21/21 as expected; 14
reorder/marker/table/stop/safety/consent/code/numeric mutations go red, 7
rewordings and lowered-register lines stay green. Log:
.context/mutation-eng-scope-entry-ap.md.
* test: type the model-routing table; point skillify comment at skill-fixture.test.ts
* test(W7c): skill-validation matches three capital-letter pins on meaning
W7c (t08 F2, F4, F5). One test file; only these three pins change.
Removed assertion groups: none. Loosened, invariant kept as a free
case-insensitive meaning check:
- `MUTUALLY EXCLUSIVE` (codex skeleton) -> one codex mode per invocation:
`/mutually exclusive/i` (t08 F4).
- `skip the Codex passes ONLY` (review adversarial) -> `codex_reviews=disabled`
skips only the Codex passes, Claude adversarial still runs:
`/disabled[^\n]*skip the Codex passes only/i` (t08 F5).
- `If any in-branch failures remain unfixed, **STOP**. Do not proceed` (ship
tests section) -> unfixed in-branch failures block advancement:
`/in-branch failures remain unfixed ... stop ... do not proceed/i` (t08 F2).
Also covered by gate E2E ship-triage (gate).
Cosmetic pins dropped: capitals and bold only.
Mutation log: .context/mutation-skill-validation.md (6 mutations, 0
unexpected: 3 rule deletions red; 3 lower-case rewordings green).
* test(W7c): drop coverage-audit checklist tool-call prose pins
W7c conversion (t05 F11; unblocks s06 L9). Pin lines 17 -> 14.
Removed assertion group (invariant -> remaining protection):
- review/specialists/testing.md prose pins 'If the caller explicitly asks
for an ASCII coverage diagram', 'dedicated tool call' and /Read diffs,
package files, configs, or other context in separate tool calls\./ (tool-use
choreography): the agent reads the named source and test files before
drawing the diagram -> kept free: the same test still extracts the
checklist's example diagram and requires coverageAuditVerdict to accept it
(sourceRead/testsRead/diagram/passed), plus the kept [OK]/[GAP] row and
legend pins; gate-tier E2Es review-coverage-audit, plan-eng-coverage-audit
and ship-coverage-audit (E2E_TIERS: gate) grade the reads from transcript
evidence with the same oracle.
Mutation pass (scratch worktree, review/specialists/testing.md): 6/6 as
expected; reordered diagram rows, deleted legend, deleted [OK] marker and a
removed text fence go red; two rewordings of the dropped tool-call sentences
stay green. Log: .context/mutation-coverage-audit.md.
* test(W7c): loosen auq-format-always-loaded per-skill rule pins
W7c conversion (t01 F10-F12; W7c list item auq-format-always-loaded:61-72).
The MANDATORY format list (machine-read Recommendation:/(recommended) and the
AUQ format labels, W7 keep list) is unchanged.
Removed assertion groups (invariant -> remaining protection):
- plan-ceo-review /Do NOT batch/i (t01 F10): one decision per question ->
kept free: /One decision unit = one AskUserQuestion call/i in the same rule
list.
- plan-eng-review full-sentence regexes 'Send `AskUserQuestion({ questions:
[currentDecision] })` only after the pending-record checkpoint passes. Send
one question object for one choice; other IDs wait' and 'If you discover
another independent choice, separate it and rebuild this comparison before
saving or sending the question' (t01 F11): one question object per
independent choice survives the carve -> kept free: /one\s+question object
for one choice/i and /independently selectable changes separate IDs/i; the
checkpoint-before-send order stays pinned in eng-review-routing.test.ts.
- codex /Synthesis recommendation \(REQUIRED\)/i (t01 F12, caps marker):
codex keeps its synthesis rule always loaded -> kept free: /Synthesis
recommendation/i and the machine format /Recommendation\s*:\s*<action>\s*
because/i.
Mutation pass (scratch worktree, generated SKILL.md and sections): 8/8 as
expected; removing Recommendation: <action> because, the synthesis rule, or
the CEO/eng/design decision-unit rules goes red; dropping (REQUIRED) and
rewording the two dropped eng sentences stays green. Log:
.context/mutation-auq-format-always-loaded.md.
* test(W7c): qa-probe-gates keeps loop order, bounds and the CI-proven Read gate
W7c (t07 F3, F4, F5). One test file. This file stays the single owner of
shared QA loop ordering (qa-functional-prompt defers to it).
Removed assertion groups (invariant -> remaining protection):
- `> **STOP.** Before any probe ...` prefix pin (t07 F3, retire) -> parent
QA loads methods before any probe: kept free meaning check on "before any
probe, including plan checks, complete the ordered scope/method Reads" and
its order before the required-checks step.
- Preparation prose in the stage list ("in full and select the surfaces",
"2. Read the selected surface methods below in full", "Write a **charter**",
"Start once before baseline:") -> stage order scope -> methods -> charter ->
deadline start -> loop: kept as structural anchors (section Reads,
surface labels, `## 1. Charter and preflight`, `bun G start D SECONDS`,
step 1 title); added a reorder control moving a method Read after the charter.
- Bounds/layout sentences ("an unlimited mode uses the caller's bound",
"announce finite command timeouts", "EARLIER_UTC = caller's absolute
deadline, if set", "in the probe directory, beside its deadline if
bounded", duplicate SECONDS pins in the mode-bounds test, "charters as
Markdown in the report", the full "observed: its exact decoded child JSON
..." sentence) -> numeric bounds and field names are kept free checks;
the observed-field shape is enforced by the native checkpoint validator
(qa-functional-prompt validator tests, free) and gate E2Es
qa-functional-cli-report, qa-functional-webhook-report (gate).
- Publication prose ("No drafts/placeholders", "and replay limits in the
report", "An absolute state path is not itself a secret", "If capture is
incomplete, report that limit instead of reconstructing it") -> notes are
immutable and unsafe values withheld: kept free checks on "corrections
cannot repair published notes", never invent a substitute, withhold
secrets/unsafe values and stop the chain; validator-backed in
qa-functional-prompt; gate E2Es review-exploratory-small-cli,
ship-exploratory-small-cli (gate).
- Loop-step prose ("Guard if bounded; await completion", "Run that exact
probe; G enforces ..." duplicate, "then minimize via those gates", "Expiry
leaves confirmation/minimization incomplete", "for each affected
revalidation", "If bounded, run", "Reuse Step 4's ... completed Reads",
"Finish missing methods before charters") -> loop has 5 steps, guarded by
G, replays via steps 2–3, revalidation returns to step 2: kept free checks on
step count, `G enforces the deadline`, `bun G status D`, `via steps 2–3`,
`return to step 2`, refusals as not-run, do not repeat completed Reads.
- CI-fixture clause "description, section index or remembered method is not
a completed instruction Read" -> covered by the kept CI-proven clauses
(`## 0. Preparation gate`, await each Read, complete missing Reads before
Charter) and gate E2E ship-exploratory-small-cli (gate; the CI case).
Kept (meaning checks, case-insensitive where prose): CI-proven "await their
results before the first probe" rule (comment + mutation kept), Reads in
order, no repeated Reads, SECONDS=30/900, shorter mode/caller limit, no D
without a total limit, finite timeouts, REPORT_DIR layout and caller paths
win, plan checks after smoke with no smoke guard and no clock reset, caller
cap, not-run on expiry, await clock results, never reset D/bypass G,
invalid/missing D stops probes, expiry -> write the report, Step 4
read-only, isolation/permission preflight before setup, field names,
QA_DEADLINE receipts, all semantic-flip mutation controls, method/report
resource paths, helper commands.
Cosmetic pins dropped: STOP / AND capitals, bold STOP prefix.
Mutation log: .context/mutation-qa-probe-gates.md (22 mutations, 0
unexpected: 3 reorders, 4 markers, 8 safety red; 7 rewordings green).
* test(W7c): shrink autoplan-phase-order to structural and meaning checks
W7c conversion (t06 #13; W7c list item 'Eng runs LAST, always', 'ONLY/FINAL').
Pin lines 203 -> 166. autoplan has only periodic E2Es (autoplan-dual-voice,
autoplan-journal-drift: E2E_TIERS periodic), so every invariant keeps one
free check: sentence pins collapse to short /i meaning checks; commands, CLI
signatures, placeholders, tool parameters, report fields, packet outputs
(code-generated) and stale-string bans stay exact.
Removed assertion groups (invariant -> remaining protection):
- 'Eng runs LAST, always' (caps sentence): Eng is the terminal phase -> kept
free: /CEO → Design.*→ DX.*→ Eng/s, heading order 1 < 2 < 2.5 < 3 and the
'CEO → Design → Eng → DX' ban.
- Final-gate sentences ('...Use Decision Classification; ask once at Final
Approval Gate, never mid-run', 'Queue clearly-wrong/challenged premises',
'The user decides there; never stop mid-pipeline'): premises queue for the
single final gate -> kept free: /never auto-decide user challenges/i, /ask
once at final approval gate, never mid-run/i, 'as User Challenges for Phase
4', /never stop mid-pipeline/i, the two old-gate bans.
- Generated setup sentences ('Resolve this phase', 'Run all applicable skills
and lazy sections fully', 'log successful ranges/total to EOF'): phases load
at their own boundary -> kept free: /never prefetch future phases/i,
/missing skill: report phase and setup repair/i, per-phase methodology CLI
and Read-before-create order, no in-full-now Reads.
- Intake load sentence ("Resolve this phase's source to absolute
`<REVIEW_SKILL>`; load via its checkpoint") -> kept free: `<REVIEW_SKILL>`
token and /never prefetch future phases/i; section load keeps
`readRanges`/EOF/skip-listed checks.
- Native dispatch sentences ("ONLY/FINAL tool call", 'Keep native Reads
enabled', 'all criteria + plan', 'if its schema exposes it', 'Claude Code:
end response immediately', 'Other hosts await that ID', "Then outside →
this phase's review ONLY", 'No inline substitute; apply failure policy'):
the native review blocks and completes before outside review -> kept free:
native < outside order, run_in_background: false, isAsync: true, /final
tool call/i, /end response immediately/i, /no further tool calls\/review
until/i, `nativePromptPath` to EOF, INPUT-hash match, /retry invalid input
once/i, /no inline substitute/i, 720000ms timeout, provenance placeholder,
N/A and CONFIRMED status tokens, /primary cannot replace/i.
- Sequential Execution sentences (Keep ONE phase active, compaction reload,
'reconcile saved artifacts and sent conversation messages separately',
'Publication is a separate operation', 'an earlier Read is not this close',
"Then continue to the next phase's tool calls in the same turn", 'record
verbatim into fenced history', 'retaining its original source SHA',
'compaction resumes the existing invocation', the full LOG/amend-input
sentence): one phase at a time, publish before advancing -> kept free:
/keep one phase active/i, /never draft future-phase reviews/i, compaction
reload (/i), two ordered chains (load < snapshot < dispatch < consume <
remaining sections; phase-close < parent message < driver advance < after
Eng), skip/resume/step 6 (Publish) routes, open-gate, uptake, pending,
never-skip and raw-transcript lines (/i), rerun fields
`baselineEdits.record`/`sourceSha256`, `amend-input`.
- Amendment-binding sentences ('load the shared close steps afresh, even if
read earlier', 'Keep this checkpoint for this invocation; review exports do
not replace it') -> kept free: checkpoint field per phase, `methodologyPath`,
/afresh/i, /review exports do not replace it/i.
- Shared-close sentences (~20: completion prerequisites, readRanges Read
choreography, 'A Read of only the edited tail does not satisfy...', 'If a
result is truncated...', 'If a Read fails...', 'regenerate the packet...',
'Retention checks prove bytes; counts, hashes...', 'Review history stays in
Review record', 'Taste remains provisional', 'Apply the phase's failure
policy...'): read the whole packet, verify, then publish -> kept free: the
seven-step order, terminal-results/INPUT/pending/no-credit/User
Challenges/None/fixed-checkpoint lines (/i), prepare-close CLI,
`readRanges` with exact `offset` and `limit`, /through EOF/i, no advance
without a result, step-3 return, verification compare/recheck/keep-open,
stale ban, generated copy contains the template.
- Publication sentences ('After sending the actual parent report', 'using
actual findings and voice statuses', "The sent conversation message is step
6's output", 'This message is the next operation...', the duplicated driver
pins) -> kept free: publish < report < return order, /send the filled
report ... visible parent assistant text/i, /before any next-phase tool
call/i, both-voices rule, same-turn/driver-alone/no-continue-wait/skip
lines (/i), Bash-is-not-publication (/i), stale ban.
- Report-format sentences ("the actual host's reviewer names", 'Include the DX
metrics line only when ...', "Resolve `report.next` using the driver's
applicable scope/skip rules") -> kept free: every report field line,
`report.includeDxMetrics`, `report.next`, and the code-generated packet
checks.
- Intake/DX-scope/call-site sentences ('without losing requirements', 'Use
returned paths/`scope`', 'false and neither semantic trigger applies',
'checks exact retention', the 'for both voices' tail) -> kept free: ACTIVE_PLAN
field, save-to-ACTIVE_PLAN, conversation approval, backup-exactly, stop on
helper error, `## Review record` (all /i where prose), init/scope/create/
prepare-close CLIs, `dxRequired`, 2+ threshold, enabling flags, no-negation
rule, snapshot/verbatim dispatch/outside-inline lines, stale path bans.
Mutation pass (scratch worktree; autoplan template, sections and generated
phase-close): 23/23 as expected; 16 reorder/old-order/tool-param/placeholder/
numeric/consent/stop/safety mutations go red, 7 rewordings and lowered caps
(ONLY/FINAL, Keep ONE phase) stay green. Log:
.context/mutation-autoplan-phase-order.md.
* test(W7c): qa-functional-prompt keeps the verifier contract, drops driver prose
W7c (t07 F6, F7, F8). One test file. The eval prompt itself is unchanged.
Removed assertion groups (invariant -> remaining protection):
- ~40 driver-prompt sentence pins in the disclosure, artifact and fix-budget
tests ("All four reads are required before probing ...", "command is the
exact full outer capture invocation, including ...", "different later
command", "not the required same-command replay", "Only the helper writes
observed fields", "Link the evidence and checkpoint files ...", "Evidence
rows contain ONLY complete JSON ...", "aim under 400 words", "one causal
sentence per checkpoint hypothesis ...", "a reproduced in-tier defect
requires ...", duplicates of "retain its headings ..." etc.) -> the run
produces verifiable evidence and a linked report: free validator tests in
this file (qaFunctionalVerdict replay, validateQACheckpoints on CI, R29 and
R85 captures) and gate E2Es qa-functional-cli-report,
qa-functional-webhook-report, qa-functional-cli-fix,
qa-functional-webhook-fix (gate). Kept the machine-read contract: read
list, `"command":"<exact full outer capture invocation>"`,
`annotations.learning`, the three copied field names, the >20-character
limit, evidence.json before report.md.
- `maxTurns: 40` / `completionReserveMs: timeout / 4` exact source pins ->
replaced by a `maxTurns >= 40` floor and presence of `completionReserveMs`.
- Fix-stage provenance sentences ("most recent completed native probe",
"Tests, source edits and clock reads ...", "write no checkpoint when there
is no next probe") -> test output never becomes `observed`: kept one free
meaning check plus the R29 validator test (free).
- Duplicate loop-order checks on qa-only/sections/exploratory.md and grep of
`scripts/resolvers/qa.ts` source (t07 F6, F8) -> loop ordering has one
owner, qa-probe-gates (free, every host). Here the source grep becomes a
check on `generateQAExploratory` output (one probe per native command,
never batch probes), and the caller test keeps resource paths, field names
and structural stage anchors.
Loosened to case-insensitive meaning checks (kept): never synthesize JSON,
never shorten native JSON, existing tests read-only, freeze tests after red,
repair scope `src/<family>.ts`, green suite does not replace native probes,
report incomplete honestly, report-only proposes test stubs, completion
reserve does not end coverage, all eight scenarios required, never backfill
notes, owned probe directory, only complete emitted JSON, wrapper/entrypoint
boundary lines.
Kept unchanged: paid-case selection, CI/R29/R85 validator replays, actor
boundary and command allowlist, fix-stage order, verification probe list,
scenario lists.
Cosmetic pins dropped: ONLY / NOT / Never capitals.
Mutation log: .context/mutation-qa-functional-prompt.md (19 mutations, 0
unexpected: 3 reorders, 4 markers, 7 safety red; 5 rewordings green).
* test(W7c): match plan-scope-selection scope-gate stop lines case-insensitively
W7c conversion, scope-gate caps pins only (t06 #14). The scope classifiers
(nativeSeededPlanSelection, isScopeGateAutoSelectVisible,
isScopeGateQuestionVisible), the consumed announcement and A/B/C menu bytes,
and every non-caps assertion are unchanged.
Removed assertion groups (invariant -> remaining protection):
- 'Reply with A, B, or C. STOP and wait' order anchors (design, template and
every host expansion): menu precedes bootstrap -> kept free: the consumed
prefix 'Reply with A, B, or C' (pty/classify.ts, pty/judge.ts), now also
required to exist after '## Scope gate' so a missing menu cannot pass the
order check with indexOf -1.
- 'call AskUserQuestion FIRST and wait.', 'does NOT count as the mode signal',
'If the user explicitly named a DIFFERENT target' (design and eng), 'STOP
and wait for the answer — only after the user picks', 'STOP and wait for the
answer' (toContain and indexOf before the first ```bash on every host):
ask first, pasted text is not a mode signal, explicit targets win, stop
until answered -> kept free: the same rules as case-insensitive meaning
checks, including the per-host ordering (search /stop and wait for the
answer/i before the first ```bash, with a presence check).
Mutation pass (scratch worktree; plan-design-review and plan-eng-review
templates): 12/12 as expected; gate-after-preamble, removed design menu
prefix, removed stop lines (design, eng), removed mode-signal, ask-first and
explicit-target rules go red; lowering STOP/FIRST/NOT/DIFFERENT stays green.
The eng menu prefix is not pinned here (eng-scope-entry-ap.test.ts M1 covers
it). Log: .context/mutation-plan-scope-selection.md.
* test(W7c): match document-release spawned-dispatch contract on meaning
W7c conversion (t04 F3; W7a run-in-background-guidance.test.ts:472,474, named
by the Eng W7c gate as anti-injection and VERSION invariants that stay as
case-insensitive meaning checks). The run_in_background flag pins, structural
scanner and inverted-phrasing ban are unchanged.
Removed assertion groups (invariant -> remaining protection):
- 'NEVER trigger it on their own' (caps literal): prompt/file/tool claims do
not enable spawned mode (anti-injection) -> kept free: /claims never
trigger it on their own/i in the generated skill and template.
- 'The NEVER-do invariants below do' (short form of a wrapped sentence that
names the caps headings s10 rewrites): spawned auto-pick still never
rewrites CHANGELOG or changes VERSION -> kept free: /skip any
recommendation that rewrites CHANGELOG or changes VERSION/i
(whitespace-normalized) in both files; gate E2E document-release.
- 'A spawned run must never change VERSION': same rule, now /i.
Mutation pass (scratch worktree; document-release skill, template and
release-body section, ship/sections/documentation.md): 7/7 as expected;
deleting the anti-injection clause, the CHANGELOG/VERSION carve-out, the
spawned VERSION line, the run_in_background flag or the dispatch heading
goes red; lowering NEVER and rewording 'NEVER-do invariants' stays green.
Log: .context/mutation-run-in-background-guidance.md.
* test(W7c): match retro clock rule case-insensitively, drop proximity regex
W7c conversion (t02 #11, #12).
Removed assertion groups (invariant -> remaining protection):
- /NEVER from `date`/ (caps): today comes from the session reminder, not the
system clock -> kept free: /session reminder/ and /never from `date`/i.
- /(?:disclosure[\s\S]{0,200}narrative|narrative[\s\S]{0,200}disclosure)/
(200-char word-proximity window): offline/local-only runs disclose that the
window is not freshness-verified -> kept free: the exact disclosure string
'offline run, window not freshness-verified' (it reaches the retro output),
RETRO_REF disclosure and the GUARD_* script checks; gate judge
'retro/SKILL.md instructions'.
Mutation pass (scratch worktree, retro/SKILL.md.tmpl): 4/4 as expected;
allowing `date` or deleting the disclosure string goes red; lowering NEVER
and rewording the narrative clause stays green. Log:
.context/mutation-regression-1624-retro-stale-base.md.
* test(W7c): match redact scan-at-sink exact-bytes rule case-insensitively
W7c conversion (t02 #13). Credential-handling checks (mktemp, --from-file,
exit codes 3/2/0, visibility lookups, no HIGH skip flag) are unchanged.
Removed assertion group (invariant -> remaining protection):
- /EXACT bytes/ (caps): scan the exact bytes that will be sent -> kept free:
/exact bytes/i in the same test, next to the mktemp and --from-file checks.
Mutation pass (scratch worktree, scripts/resolvers/redact-doc.ts): 3/3 as
expected; scanning a summary instead of the exact bytes or dropping the
Exit 3 (HIGH) branch goes red; lowering EXACT stays green. Log:
.context/mutation-redact-doc-resolver.md.
* test(W7c): check the codex boundary on meaning and its path list
W7c conversion (t02 #14, W7a host-config.test.ts:565). The boundaryInstruction
bytes sent to Codex are unchanged; only the test loosens.
Removed assertion group (invariant -> remaining protection):
- toContain('Do NOT read') (caps fragment): Codex must not read or execute
Claude skill definitions -> kept free: /do not read or execute any files
under/i plus each excluded path ('~/.claude/', '~/.agents/',
'.claude/skills/', 'agents/'), which is the actual contract.
Mutation pass (scratch worktree, hosts/codex.ts): 3/3 as expected; replacing
the prohibition or dropping an excluded path goes red; lowering IMPORTANT/NOT
stays green. Log: .context/mutation-host-config.md.
* test(W7c): shrink skill-ceo-section-ordering to structural and meaning checks
W7c conversion of test/skill-ceo-section-ordering.test.ts: t06 #1-#6, t05 F5
(cross-reference: the remaining bold-STOP pins), t13 F3 / W7.md CRITICAL RULE
anchor. #1 (ASK_QUESTIONS_HEADING anchor) was already on the base branch; #5
now slices the blocked chat return to the next "\n## " heading, so removing or
renaming `## Review Log` cannot widen or break the window.
Pins (grep -cE 'toContain|toMatch|indexOf|includes'): 647 -> 388 lines;
toContain( 535 -> 136; expect() calls per run 1657 -> 1399. The carve block,
section-capture fixtures and validateCeoReviewCompletion tests are unchanged
(t06 keep list) except two exact-duplicate 0D pins.
CEO invariants count as periodic-only (plan-ceo-review-benefits retires), so
every invariant below keeps a free structural or case-insensitive check.
Gate-tier judge that also grades this prose: 'plan-ceo-review/SKILL.md modes'.
New helpers: ordered() (exact labels/headings/placeholders/table cells as
strings, meaning anchors as /i RegExp) and between() (fails loudly on a missing
end anchor instead of silently running to EOF).
Removed assertion groups (invariant -> remaining protection):
- t06 #2 / t05 F5: '**STOP for the actual answer, even for a lone option.**'
(x6 exact pins + 3 split/indexOf anchors) and '**STOP for the answer**'
(x3): wait for the actual answer before recording -> kept free: one
/stop for the actual answer/i per slice (template 0D in dispatch order
between the ask-one-row check and the answer save; every generated host
carrier between **4. Ask and **Post-answer checkpoint:**), /stop for the
answer/i in 0E step 3 (template and generated), plus the Pre-question <
4. Ask < Post-answer checkpoint order and the 2-checkpoint count. Dispatch
slices now end at **Post-answer checkpoint:**.
- t06 #4 'Recommendation is ALWAYS present': recommendation label contract ->
kept free: '(recommended)' and 'AUTO_DECIDE depends on it' in generated
SKILL.md; exactly-one-(recommended) rule in 0D's currentDecision table.
- t06 #6 and other bans of retired phrasings ('If the section has findings,
you MUST call AskUserQuestion', 'Otherwise, use AskUserQuestion for each
finding', 'After each section, pause and wait for feedback', 'Save pending
rows before comparisons', 'using the Step 0E mode-handoff format', 'Save a
chat-only plan', 'quality bonus, not a gate', 'If no file is in scope, skip
this section', 'always write', 'For every question', 'for architecture
choices', 'These approaches differ in coverage (...)', 'Finish with
ExitPlanMode', 'Before summaries, review logs or next-step menus...', "put the
complete comparison in the question's brief", 'Use this exact route:',
'citing its ID', /\blog (?:with|that ID)\b/): same invariants -> kept free:
the positive checks (one **Decision gate.** per section wired to Analyze →
Resolve → Apply; pending-rows-before-comparisons order; **Otherwise:** in
the 0H order; report not persisted + Read-back gate; write-when-permitted
incl. zero tasks; Outcome routing count 1; record-provenance-after-handoff
order; literal dispatch-object comparison). 'Do NOT proceed ... 0C-bis'
becomes not.toContain('0C-bis') on 0D. Short stale-token bans stay
(<approved 0D approach>, reference | commitment | current value, ___
methods, retry once, telemetry has logged, NUMBER + LETTER / "3A", the
Forbidden-storage regex, removed menu option, unbound placeholders).
- t06 #3, magic counts: literal 11 sections / toHaveLength(7) closing steps ->
kept free: section numbers 1..N derived from '## Review Sections (N
sections' and checked against the ### Section headings; closing-step count
derived from the 7 route labels.
- Decision cycle / storage / comparison sentences (Start at step 1, run steps
2–4 only when needed, mode-change pointer, storage-policy save sentence,
Copy the grid, Validate every field, Show unchanged/shared/pending repeated
x4, other rows stay fixed or pending x5, never prewrite x3, Build one
currentDecision x3, Ask one row per call x6, Save the answer reference x5,
Keep independent changes separate x4): full decision protocol in order ->
kept free: label order 1. Check < 2. Record < 3. Compare < grid <
Pre-question < Read-back < 4. Ask < Post-answer (template + every host),
one /i check each for pending-rows-before-comparisons, save-before-ask,
amend only authorized work, failed save stops, decline-all stop, show
unchanged/shared/pending, independent changes separate.
Admin/plan routes also kept in ceo-workflow-clarity.test.ts.
- Handoff/provenance sentences (After selection, send brief chat, Keep rows
separate, logging-row repeats, Section 1 current-scope sentences): mode
handoff applies before questions and logs provenance after -> kept free:
/before tools or further questions/i, handoff < Other selections <
provenance < selecting-a-mode order, the two exact output-format lines with
<rows or none> / <Application and rationale>, auto_decided true/false
fields, 'No new approach decision was needed' (quoted chat output). Section
1 dispositions -> ceo-workflow-clarity's Section 1 test.
- Scope/mode-selection sentences (REDUCTION, HOLD and SELECTIVE's HOLD
checks; For both expansion modes...; Skip/Defer destination repeats;
present both inputs for final approval; 0E counts changed files; Count all
deliverables; >15/greenfield repeats; SELECTIVE balances...): scope
decisions per item with exact destinations -> kept free: prescribed menu
label orders (A Add/B Defer/C Skip; A Defer/B Keep; TODO A/B/C; depth
A/B), Defer -> TODOS.md + NOT in scope, Skip -> no TODO, /ask separately/i,
/all four 0D steps for each unanswered addition or deferral/i, routing rows
and >15 / 8-file / 2-class numbers (once each; ceo-workflow-clarity keeps
the reuse-count checks), carve block's document-approval order.
- TODO menu (per plan-review-calibration t04 F11 retirement, which names this
file as the remaining free protection): kept free in the TODOS.md-updates
slice: /only unanswered TODO proposals reach this menu/i, /do not ask again
about an item already deferred, skipped or kept/i, /one per question/i.
- Resolver prose (spec review, plan report, tasks emit, exit gate, codex plan
review, brain cache refresh, approval readiness, design clause): each
sentence pin -> one short /i check per invariant on every host (five
dimensions, at most three launches, required save stops, destination-file
Read/Write order, zero tasks, unknown files JSONL format, ExitPlanMode only
after checks, forbidden history, outcome routing and skip routes, native
fallback never outside coverage); exact strings kept only for machine/output
tokens (NO UNRESOLVED DECISIONS, '- + N unresolved from prior reviews',
STATUS/SOURCE/OUTSIDE_STATUS assignments, CROSS-MODEL, OUTSIDE COVERAGE,
'N findings; R resolved; U unresolved', quoted report phrases, Gate outcome:
Blocked, Read-back gate). Dropped: 'If both counts are zero', 'For
**Outside Review**, use ...', 'Enter after either an external reviewer...',
'identify the causal mechanism', 'A credible material risk...', "check the
assembled set's capacity", 'including findings that needed only factual
correction', 'show unsaved fields and errors', Strategy-only tasks sentence,
verified-report-can-pass sentence -> neighbouring kept /i checks in the
same slice plus the gate-tier 'plan-ceo-review/SKILL.md modes' judge.
- Review-section prose (continuity requirement lists, test-review and outside
rule duplicates, strategy-only diagram sentences, Review facts repeats,
Stage 3 publishes it, Count a reopened choice once, Keep them before the
terminal report repeats, EXIT gate verifies..., no report or log needed
yet, then run telemetry as the last review operation): per-section gate and
ledger continuity -> kept free: Analyze < Resolve < Apply, Resolve paths
via check-scope < correct < record order, /resolve critical risks now/i,
/review only; do not change code/i, ledger header + status tokens, one /i
per approval/stop line; reopened-once lives in ceo-workflow-clarity;
terminal order kept as cache refresh < {{BRAIN_CACHE_REFRESH}} < Telemetry
< finished < Call ExitPlanMode < handoff.
- Duplicate pins removed outright (same string asserted 2-6 times across
tests, incl. carve-block 'Ask one row per call' and bold-STOP pins): each
keeps its single remaining check named above.
Cosmetic pins dropped without controls: bold/caps (**STOP**, ALWAYS, MUST),
double compactProse wrappers.
Mutation pass (scratch worktree; templates, generated SKILL.md and
review-dashboard resolver): 39/39 as expected; 28 kept-step/marker/
placeholder/safety/consent/numeric mutations go red (incl. the three TODO-menu
lines), 11 rewordings of dropped sentences, the CRITICAL RULE heading rename,
re-adding the retired #6 sentence, and lowered-register STOP lines stay green.
Log: .context/mutation-skill-ceo-section-ordering.md.
Runtime (Bun 1.4.0, 3 runs): before 2.05/1.84/1.77 s (median 1.84),
after 1.87/1.80/2.08 s (median 1.87); dominated by runGeneration and the
capture subprocess fixtures.
* test(W7c): shrink plan-review-cases to structural and meaning checks
W7c conversion (t03 F1-F4; t02 F4/F5 duplicate STOP/threshold pins). Pins
713 -> 208 lines by the brief's grep (toContain|toMatch|indexOf|includes);
prose assertions 592 -> 366 (toContain/toMatch calls plus expectAll regex
rules; expect() calls per run 3232 -> 2808). Tests 218 -> 215. t03 F1 (stale
~/.gstack/projects discovery path) was already fixed by W7a on the base; its
$GSTACK_STATE_ROOT check and the stale-path ban are kept.
Kept byte-exact or structural: marker-order arrays (### Prepare an unanswered
choice -> ### Send once and wait -> ### Record the answer, heading list
equality, Pending-record checkpoint, finish steps 1-6, entrypoint recovery
order, output placeholder order), the parsed write-policy table routes, the
generateAntiShortcutClause host matrix, every not.toContain(stale) ban,
numeric limits (8+ files / 2+ new classes, fewer than 8 / 2, under 5 words,
2-3 options, six-column / five-field / four-step), consumed tokens and field
names (`scope accepted as-is`, `scope reduced per recommendation`, FULL_REVIEW/
SCOPE_REDUCED mapping, **issues_found**, SOURCE=/OUTSIDE_STATUS=/STATUS=,
OUTCOME=, `BLOCKED`, `## GSTACK REVIEW REPORT`, `currentDecision`, D<N> and
ROW-ID formats, prescribed A-D menus), placeholders, commands/paths and all
picker behavior tests (unchanged). STOP/wait/approval/safety lines become
case-insensitive meaning checks located between their headings (e.g.
/stop until the actual answer arrives/i between Send once and Record the
answer; /do not replace the section in place/i plus /append the new report
at EOF/i). CEO invariants (periodic-only once plan-ceo-review-benefits
retires) each keep one free check. Eng/Design/DX invariants keep one free
check too; nothing below relies on a periodic-only E2E.
Removed assertion groups (invariant -> remaining protection):
- CEO route/narrow depth (:19) full sentences: admin answers approve nothing,
plan decisions run steps 1-4, settled choices go to 0E -> kept free:
Admin < Plan decision order, checkpoint order, five short /i checks, stale ban.
- Eng evidence paths/labels (:33) 'Prior Learnings configuration', path rule
sentences -> kept free: the three path field labels, /never invent paths/i,
`not available`, label tokens, stale ban.
- Eng first report save (:47) 9 requirement sentences -> 5 short /i
requirements with the same remove-one-must-throw self-control; parent-dir,
original-plan-copy and scope-record clauses dropped (initialization
invariant kept by target-header/preserve/no-findings/placement/terminal-
report checks; collision suffix kept in the write-policy test).
- Eng setup selectors (:79) and its duplicate in the big Eng ordering test:
selectors approve no remedy -> kept free: /these selections approve no
engineering remedy/i, B selectors, no pre-answer ledger, stale ban; the
'For the next choice' sentence -> kept free: transaction marker order.
- Eng performance (:94) exact bullet list -> kept free: four concern
keywords from the parsed bullets; Decision-procedure sentence -> kept free
in the four-section test.
- Eng complexity/MODE (:105) per-target counting, 'Count each once', 'Keep it
current', 'Continue to Section 1' sentences -> kept free: count-selected-
work, both thresholds, MODE tokens and mapping, scope-reduction meaning,
'approves no pending remedy', Continue-to-Section-1 in the C order array.
- Eng three-stage transaction (:125) sentence markers -> same 13-step order
array with short /i anchors and the remove-one-must-throw control.
- Eng Test Plan refresh, coverage trace (:150, :162) sentences -> kept free:
placeholder count/order, prepare step count, short /i checks; coverage audit
also graded by plan-eng-coverage-audit (gate).
- CEO fallback (:178) sentences -> kept free: host mode token matrix, status
field values, /final report is written later in Required Outputs/i, ban.
- Persistence per skill (:229) Eng duplicates ('If the required log is
forbidden', 'Neither supplies', FULL_REVIEW mapping, 'after successful
Read-back') -> kept free in the readiness, complexity and write-policy
tests; CEO 'retain its diagnostic' -> kept free: /do not claim that entry
was recorded/i and three other CEO log checks.
- Report resolver per host (:261) duplicate 'Do not choose another
destination', 'Review record and write policy', 'full review output',
explicit/named/active sentences -> kept free: target precedence order;
CEO writer's seven sentences -> kept free: six-anchor order ending at
'4. **Read-back gate:**' plus the blocked-return check.
- Generated carriers (:327) bold STOP pin -> /stop until the actual answer
arrives/i in the dispatch order array.
- Big Eng ordering test (:358) duplicates of the gate describe (one question
object, 8+/STOP, both-retain, setup, separate instrumentation, keep chosen
values, calibration<procedure<scope, Decision procedure < Architecture,
outside-voice consent lines) -> kept free once each (boundary list, queue
test, preparation order array now ending at ### 1. Architecture review);
'Use existing tests ... bounded probes', 'post-answer scope summary',
'Compare only the file/class arrangement', 'contracts and approved
security...', 'With no proposed cuts', 'Present numbered...' sentences ->
kept free: build-boundary order check, structure-question and
unapproved-fixes checks, C-step order array.
- Eng gate describe: exact-duplicate pins (same sentence 2-4x in one test or
repeated per section inside the 4-section loop) -> one copy kept; ledger
placeholder descriptions (Plan baseline/Runtime evidence/Actual answer/
Accepted scope text) -> kept free: parsed ledger field-name list, R1 header,
State values, A)/B) selectors, ledger position.
- Gate tests 'identifies commitments before comparing values', 'common new
defaults...', 'exact prior answers authorize...', 'finding evidence, stable
decision identity...' merged: every non-duplicate invariant (optional
depths, shared new value needs approval, unknown risks visible, drafts grant
nothing, reopened ID keeps D<N>, test scores not answer status) -> kept free
as one /i check in 'current contracts...' or 'all four section gates...';
their order checks -> kept free: prepare<identify<compare<save<send<record.
- Remove-old-occurrence, 'Otherwise leave the remedy pending', 'no question
or comparison grid is needed', 'never the saved-report gate', 'Compare the
label separately', 'When revising, replace the whole current payload',
'It may be the selected plan', 'Present each completely as not persisted',
'If none is permitted...', 'A forbidden write follows its row', 'Run
Learning hooks ...', 'Refresh affected tests...', 'If startup values...',
'instead of creating another approval row', 'Keep that remedy pending' ->
same invariant kept free by an adjacent check (State replace/once checks,
approves-no-implementation, factual-correction, recovery routing, payload
rebuild, write-policy routes, return-to-entrypoint count, late-change and
blocked checks, common-work check).
- Worked example anchor sentence -> anchored on the Compare section and
'Ask about jitter first:'; parsed R1/R2 table equality kept.
- Outside-voice queue: dead generic branch (all three skills `continue`
before it; never executed) removed -> none needed (unreachable). Eng
procedure re-checks inside the queue (5 sentences) -> kept free in the
gate describe. Shared CEO/Eng/DX scope-revision sentences hoisted to one
shared /i block per skill; CEO 'Keep candidate scope ...' etc. -> kept free
as short /i checks; prescribed A-D menus kept exact.
- Design register (:1771) sentences -> kept free: grounding-before-question
order and three /i checks; 'Surface real missing decisions' dropped
(positive restatement of the same rule).
Gate-tier coverage that also grades this prose: judges 'plan-eng-review/
SKILL.md sections', 'plan-design-review/SKILL.md passes', 'plan-ceo-review/
SKILL.md modes'; E2Es plan-eng-coverage-audit, plan-review-report,
plan-devex-review-plan-mode (gate). Cosmetic pins dropped without controls:
bold/caps STOP and NOT, issue-number comments unchanged.
Mutation pass (scratch worktree; eng/ceo/design templates and the
outside-voice, testing and review-dashboard resolvers): 33/33 as expected;
24 kept-step/marker/safety/numeric mutations go red, 6 rewordings of dropped
sentences and 3 lowered-register STOP/NOT lines stay green. Log:
.context/mutation-plan-review-cases.md.
Runtime (bun test, Bun 1.4.0, median of 3): 0.85 s -> 0.77 s.
* test(W7c): qa-caller-authority keeps authority and safety lines, drops report prose
W7c (t10 F12, F13). One test file; still renders every host x caller.
Removed assertion groups (invariant -> remaining protection):
- `STOP and wait` / `STOP for the answer` / `AskUserQuestion and WAIT`
capitals (t10 F12) -> approval before `./setup` or install: now an order
check (explicit approval < "only after approval" < `cd <SKILL_DIR> &&
./setup`; OK to proceed? < setup; AskUserQuestion-and-wait < install only
the actual choice), plus case-insensitive "stop for the answer". Stronger:
the mutation that moves setup ahead of the approval ask now goes red (the
old test stayed green). New negative control removes the approval ask.
- Report-layout prose for /review and /ship (keep metadata/outcome tables,
demote headings one/two levels, fields as subsections, keep scores
separate, save baseline normally) -> one final linked report section:
kept free checks on the `## Exploratory QA and Verification Results` /
`### Browser results` / `## Exploratory QA` headings, link every checkpoint
and no second report; gate E2Es review-exploratory-small-cli,
ship-exploratory-small-cli (gate).
- Smoke-pacing prose ("one success and the riskiest changed failure/edge",
"Required even for small diffs ...", "Required: plan commands/assertions,
listed separately", "Other ideas are optional, untested") and duplicate
report-status pins -> kept the numeric `5 minutes/12 probes` bound and the
report-clean-only-when-all-required-pass gate; gate E2Es
ship-exploratory-small-cli, ship-exploratory-plan-checks (gate).
- Dedup prose ("Combine saved `findings` ...", "If both history ... classify
normally", "Report the suppressed count once if nonzero", "If N > 0, print
once:", "Otherwise skip the summary") -> only user `skipped` findings are
suppressed: kept free order check (read decisions before matching) and the
`skipped` / never `fixed` / `auto-fixed` lines; gate E2E
ship-skipped-queued-finding (gate).
- Preparation sentence pins duplicated from qa-probe-gates (Reads in order,
no repeated Reads, "in full and select the surfaces", "Write a **charter**",
"charter** per behavior", "announce finite command timeouts") -> owned by
qa-probe-gates (free, every host); this file keeps scope < methods <
charter structural order for every caller.
- Learnings prose ("Otherwise skip this optional lookup", "Reading old notes
never requires writing new ones") -> report-only lookup never writes: kept
free checks (directory already known, caller permits, do not run the
search helper, no bash/gstack-config/AskUserQuestion, injection throw); the
query interpolation stays checked via `"webhook retries"`.
- Misc prose ("Re-run affected contracts and adjacent happy paths ...", "Run
only for selected browser surfaces", "Confirm each issue by retrying once",
"parent applies queued fixes", "No test framework detected", "Report QA
setup blockers", "required QA") -> judge `qa/SKILL.md workflow` and
`review/SKILL.md workflow` (gate lane); the adjacent kept gates remain free.
Kept as case-insensitive meaning checks (authority, consent, safety): probe-
local blocker rule, report-only never bootstraps/invokes skills, unknown
caller -> report-only, declined -> blocked, credentials/passwords/other tabs,
local-target ownership, no unit-test/curl substitute, functional-only reads
nothing browser-side, never-pass list, named-risk acceptance, noninteractive
-> blocked, test_stub ASK approval, ship waiver cannot complete review,
caller-required rechecks, blocked rechecks never verify repairs, no edits
during Step 4.8, no inner repair loop, REVIEW_START/token-once, native pass
required for 5.8, coverage-cap stop lines, report-only never commits or
dispatches, CI/test-weakening ban, never delete a valid red regression.
Kept unchanged: machine tokens (`bun G start D`, `$B snapshot -i`,
`DIFF_START`, `CONSOLE_ERRORS=`, `$B handoff/resume`), resource paths, the
`If A and allowance remains:` count, `Minimum = 60%, Target = 80%`, all
`.not.toContain` stale-workflow bans, existing negative controls.
Cosmetic pins dropped: STOP / WAIT / LOCAL / Never capitals.
Mutation log: .context/mutation-qa-caller-authority.md (23 mutations, 0
unexpected: 3 reorders, 3 markers, 11 safety red; 6 rewordings green).
* test(W7h): retire CEO TODO-menu prose pins from plan-review-calibration
W7h retirement (t04 F11; W7c list). The calibration corpus and
buildPlanReviewDecisionPrompt never read this CEO prose; the AUQ format
tokens (consumed by plan-tune and judges) and the calibration-harness
outcome tests are unchanged.
Retirement card:
- test: plan-review-calibration.test.ts, the six CEO TODO-menu pins ('Only
unanswered TODO proposals reach this menu', 'Do not ask again about an item
already deferred, skipped or kept', 'carry its actual answer and destination
forward', 'Resolve each remaining proposal through all four steps of 0D,
using the menu below', 'Never batch TODOs — one per question').
- detects: edits to plan-ceo-review TODO-menu prose.
- non_test_callers: none (test-only reads of the template).
- search_command: grep -rn "Never batch TODOs\|Only unanswered TODO" test/
- stronger_proof / replacement: skill-ceo-section-ordering.test.ts 'TODOS.md
updates' slice keeps /i meaning checks for unanswered-only, no re-asking
and one TODO per question (CEO invariants are periodic-only under the W7c
gate, so they keep a free check); 'route through 0D' stays covered by that
file's 0D route checks.
- history: 636175d v1.87.6.0.
- validation: bun test test/plan-review-calibration.test.ts.
Controls (scratch worktree): replacing 'Never batch TODOs — one per question'
or deleting 'Only unanswered TODO proposals reach this menu' turns
skill-ceo-section-ordering.test.ts red (2/2); in this file, removing an AUQ
format token goes red and rewording the retired TODO sentence stays green
(2/2). Log: .context/mutation-plan-review-calibration.md.
* test(W7h): retire spec-template-sync as a duplicate of the freshness check
W7h retirement (t05 F18; Eng factual correction: the file takes 145 ms, its
"2 minutes" was the 120 s timeout, so this is a duplicate-only retirement).
Removes its scripts/free-test-durations.json entry.
Retirement card:
- test: test/spec-template-sync.test.ts (regenerate /spec into an out-dir and
compare spec/SKILL.md + spec/sections/gate-and-file.md with the tracked
bytes; check the generated header).
- detects: /spec template edited without regeneration, or a hand-edited
generated file.
- non_test_callers: none.
- search_command: grep -rn spec-template-sync package.json scripts test .github
- stronger_proof / replacement: gen-skill-docs.test.ts 'generated files are
fresh (match --dry-run)' (FRESH for every skill, no STALE anywhere; the
dry-run covers carved sections such as spec/sections/gate-and-file.md); the
generated-banner checks in the same file cover the header.
- history: c118e24 / 410b492 / 394db32 / b1485d8 (codex T8).
- validation: bun test test/gen-skill-docs.test.ts.
Control (scratch worktree, run against the replacement): a stale
spec/sections/gate-and-file.md, a stale spec/SKILL.md, and a spec template
edit without regeneration each fail gen-skill-docs 'generated files are fresh'
(3/3). Log: .context/mutation-spec-template-sync.md.
* test(W7h): retire the literal 75 KB autoplan budget duplicate
W7h retirement (t04 F18). test/skill-preflight-budget.test.ts asserted the
same four-skill autoplan sum twice: once against
AUTOPLAN_PREFLIGHT_BUDGET_BYTES * 3 (25,600 x 3 = 76,800 = 75 KiB) and once
against a literal 75 * 1024, which would drift silently if the constant
changed.
Retirement card:
- test: skill-preflight-budget.test.ts 'autoplan total under 25 KB
instruction cap × 3 (75 KB instruction budget)'.
- detects: the four plan-* skills' brain preflight + refresh + write-back
instructions exceeding 75 KiB.
- non_test_callers: none.
- stronger_proof / replacement: 'autoplan: sum across 4 plan-* skills stays
under AUTOPLAN_PREFLIGHT_BUDGET_BYTES × 3 (instructions)' in the same file,
which reads the constant from scripts/brain-cache-spec.ts.
- history: c118e24 v1.64.1.0.
- validation: bun test test/skill-preflight-budget.test.ts.
Controls (scratch worktree): shrinking AUTOPLAN_PREFLIGHT_BUDGET_BYTES below
the current total, or growing the eng write-back instructions by 80 KB, turns
the kept constant-based check red (2/2). Log:
.context/mutation-skill-preflight-budget.md.
* test(W7c): workflow-excerpt keeps heading order and tokens, drops judged prose
W7c (t04 F5, F6, F7, F15; F1/F2 already landed with W7a). One test file.
This file guards judge-input fidelity; the judges that read these excerpts
grade the prose itself.
Removed assertion groups (invariant -> remaining protection):
- Ship rule sentences ("Use the documented selector and pre-merge command.",
"During pre-flight, read the existing review log", "Tests must pass or
retain approval ...", "For another repair, repeat rule 2 ...", "The
unchanged release steps follow", "Use this example only after confirming
...", "Retain queued fixes and restore coverage", "Each commit must work
independently", "Keep actual outcomes and incomplete flags", the long
"Continue to Step 9.2 with the core/design-lite findings ..." form, the
Y'd/D'd evidence sentence) -> judge `ship/SKILL.md workflow` (gate lane),
which reads this exact excerpt; kept free checks on step routing (`Step 4`,
`Step 8.1`, 9.2 -> 9.2.1 QA -> 9.3, `Insert Step 5, affected Steps 6–8 and
all of Step 9 before the pending Step 10`, `5 → 6 → … → 11.5`,
`continue to Step 16`), tokens (`BASE_VERSION`, `VERIFY_RESULT stays
fail`, `"partial":N,"not_done":N`, "intentionally dropped"), and the review
cycle order (9.1 < 9.2 < 9.2.1 < 9.3 < 9.4) as a structural check.
- Outside-review routing sentences ("Other preflight mode, including harness
mismatch", "Outside execution or output validation fails", "Retain its
output and diagnosis ...", "No prompt, outside process or native
replacement", "Other preflight failures retain their printed diagnosis",
the full fallback-list regex) -> disabled means no outside call: kept free
order of disabled/prompt/ready/fallback blocks, `outside_status` tokens,
`_DISABLED_REVIEW_MODE`, disabled recheck before dispatch, "disabled means
no replacement", fallback-not-completion; judges
`document-release/SKILL.md workflow`, `plan-eng-review/SKILL.md sections`
(gate lane).
- Eng/design prose ("quote the motivating plan requirement", "Use a scoped
Edit to save this record ... Leave other choices unchanged" full form,
"edit the plan and re-rate") -> judge `plan-eng-review/SKILL.md sections`
and `plan-design-review/SKILL.md passes` (gate lane); approval meaning
checks kept.
- Retro prose ("does not require saved history", "PRs referenced", "not
newly added test cases", "is the live **team** streak", "draft the
tweetable summary using the format in Step 14, then save") -> judge
`retro/SKILL.md instructions` (gate lane); kept headings, `prs_merged:
null`, `streak_days`, the one-second compare window, Capture Learnings
after Step 14, no `$(date`, two `today="<today>"`.
Loosened to case-insensitive meaning checks (stop/consent/approval and
safety lines, always kept): STOP for each pending decision (now a regex
anchor between Step 5 and the Test Plan Artifact), STOP until the actual
answer arrives, no remedy/next section/ExitPlanMode while a choice awaits an
answer, evidence-not-approval, reopened choices need answers, wait for
approval (design), AskUserQuestion once (t04 F6), per-finding approvals,
dispatched-reviewer-missing -> stop, CYCLES >= 3 -> stop with
`converged:false`, no fourth cycle, required-probe gate before Step 10,
failed probes block continuation, coverage-gate not bypassed, failed/unrun
probes not passed, three snapshots match, document-release VERSION-absent
rule, never create an empty commit, `read any other SKILL.md` (t04 F15),
AskUserQuestion-and-wait in the capture prompt.
Kept unchanged: heading/step order checks, `## Review Sections` single-copy
check, fail-closed marker tests, redact-before-edit ordering, approval gates
outside subagent prompts, plan-tune auto-decide output lines, CEO capture
harness contract, deploy formula execution, all stale-string bans.
Cosmetic pins dropped: STOP / ONCE / NOT / OTHER capitals.
Mutation log: .context/mutation-workflow-excerpt.md (21 mutations, 0
unexpected: 3 reorders, 3 markers, 8 safety red; 7 rewordings green).
* test(W7h): retire the paid first-task-scaffold E2E duplicate
W7h retirement (t12 F12). Removes the case from test/helpers/touchfiles-data.ts
(E2E_TOUCHFILES, E2E_TIERS periodic, E2E_KINDS rule) and both
scripts/paid-test-durations.json entries; test/helpers/periodic-exclude-data.ts
had no entry. e2e-tier-alignment, eval-kinds, eval-detach-timeout-floor,
periodic-exclude-policy, touchfiles and paid-shards tests stay green.
Retirement card:
- test: test/skill-e2e-first-task-scaffold.test.ts ('first-task-scaffold',
periodic, ~$0.02): Haiku is told to run exactly one detector command and the
test greps the tool result for code_node / greenfield.
- detects: detector bucket regressions in bin/gstack-first-task-detect.
- non_test_callers: none.
- search_command: grep -rn "first-task-scaffold" test scripts .github
- stronger_proof / replacement: test/preamble-first-task-scaffold.test.ts
(free; executes the real detector on fixture repos for every bucket,
including code_node and greenfield, plus first-run gating and telemetry in
bin/gstack-skill-start). The model added nothing: the prompt dictated the
exact command.
- history: c118e24 v1.64.1.0.
- validation: bun test test/preamble-first-task-scaffold.test.ts plus the
registration tests above.
Control (scratch worktree, against the replacement): making the detector emit
the wrong bucket for a Node project or a commit-less repo turns
preamble-first-task-scaffold.test.ts red (2/2). Log:
.context/mutation-first-task-scaffold.md.
* test(W7c): shrink gen-skill-docs to structural and meaning checks
W7c conversion of the sentence/caps pins in test/gen-skill-docs.test.ts
(t01 F2-F9, F18, F19; t08 F12; t10 F4; t02 #5 duplicate STOP literal).
t01 F1 ('Every commit must map to at least one bullet point') was already gone
on the base. Pins (grep -cE 'toContain|toMatch|indexOf|includes') 1446 -> 1360;
tests 457 -> 457. Untouched: the FRESH/STALE freshness check, the routing
soft-policy negative, skill-start/end script pins, the SESSION_KIND spawned
line, and the old-wording negative pins (delete-then-append, 0D/0F, gate
"if applicable"). Machine markers stay byte-exact: NO UNRESOLVED DECISIONS,
`**UNRESOLVED DECISIONS:**`, `Approval readiness: PASS`, `D<N> — <ROW-ID>: ...`,
`## EXIT PLAN MODE GATE (BLOCKING)` anchors, `**Gate outcome: Blocked**`, helper
commands/flags (gstack-office-hours-review prepare/check/finalize --design,
--out-dir, --report, --unreviewed), helper stop reasons, analytics commands.
Consent, stop, approval, decision-cycle and navigation lines (incl. the Eng
W7c-gate lines at the old 2362-2370) are kept as short case-insensitive checks.
Removed assertion groups (invariant -> remaining protection):
- qa-only 'Never fix bugs' + 'NEVER fix anything' (t01 F8): report-only skill
-> kept free: /never fix/i in Additional Rules + frontmatter no Edit/Glob/Grep.
- qa 'WTF' token (t08 F12): fix-loop self-check -> kept free: /every 5 fixes/i.
- TEST_COVERAGE_AUDIT sharedPhrases sentences and the three Test-step sentences
(t01 F4): read source before tracing/diagramming in plan and ship -> kept
free: order 'concrete source and test files' < Trace data flow < Diagram the
execution < Quality scoring rubric in both, star/GAP markers, the plan/diff
mode split, the Test review subheading structure test; gate judges
'plan-eng-review/SKILL.md sections', 'ship/SKILL.md workflow'.
- 'REGRESSION RULE' / 'IRON RULE' labels (t01 F4): regression coverage is
required -> kept free: REGRESSION RULE heading, /without regression coverage,
that coverage is a critical requirement/i (plan), /regression test is written
immediately/i (ship), plus the existing regression-contract tests.
- '**STOP for each pending decision.**' (t01 F7, retired) -> kept free: 'Wait
for its answer before applying that remedy' (control C1).
- F19 rule sentences: step numbers dropped; kept free /prevent duplicate bumps,
pushes and PRs, never verification/i, /native result never supplies outside
coverage/i, /required-probe gate, never silently waive/i, /never offer a
conversion/i, /actual counts, never estimates/i (deduped 2 -> 1).
- SPEC_REVIEW_LOOP (t01 F3, about 74 sentence pins):
- office-hours dispatch sentences (Before EACH dispatch, parent Read does not
deliver, string unchanged) -> kept free: prepare --design/--out-dir,
order mktemp < prepare < round-N.prompt.md < `dispatch`, /all preceding valid
round files in order/i, /read the entire prepared prompt/i.
- reviewer prompt sentences -> kept free: document/verdict path and schema
wiring, mode sections ('The Assignment', 'What I noticed...'), dimension
order, short checks for coaching protection, no invented customer answers,
minor findings included, identical JSON, classify every prior finding,
open questions vs committed behavior. Dropped: 'Could an engineer implement
this...' ban (positive design-and-coaching check carries it), absence-is-not-
confirmation, unsupported-claims and labeling sentences -> gate E2E
office-hours-spec-review; prior-status validation in office-hours-review.test.ts.
- convergence evidence sentences, 'Recording concerns does not mark them
fixed', Disposition, observation/attempt counting, 'unavailable score is
null', 'missing or invalid verdict is ... never PASS', 'Preserve the failed
output' -> office-hours-review.test.ts (convergence, finalize, invalid
artifact vs --unreviewed, null quality_score) + gate E2E
office-hours-spec-review; kept free: helper stop-reason order and round 3,
/before fixing any findings or dispatching again/i, /on a stop, do not fix
again or re-dispatch/i, /do not edit that generated section/i, finalize before
/existing user approval/i, --unreviewed wiring, /do not fabricate JSON/i,
/not an approval gate/i.
- CEO spec-review sentences (Read Agent's tool definition, omit field, consume
completed review, Keep both consistent, duplicated 'both complete labeled
texts'/'all five dimensions'/'Preserve the failure'/'citing the owning
input'/'## Reviewer Concerns', 'Read these documents' ban, strategy-only and
narrow-decision sentences) -> CEO is periodic-only, so kept free: one short
check per invariant (wait tool, no-wait resume, no advance while waiting,
three launches, stop after third, stop the loop, missing score, null grade,
SCORE 1-10, not persisted, mkdir/append stop, save-failure stop, ITERATIONS,
FOUND/FIXED/REMAINING order, both inputs in full, partial-input refusal,
summary-is-not-the-plan, 1-10 score, PASS rule, cite input) plus the
existing order/count/command checks.
- Design approval reconciliation (t01 F2, about 79 pins):
- Pass 5 sentences and 'AskUserQuestion once per issue. Do NOT batch.
Recommend + WHY.' -> kept free: /stop\W+AskUserQuestion once per issue/i
located after four short reuse/new-evidence/first-decision checks; batching ->
auq-format-always-loaded.test.ts PER_SKILL_RULES ('One issue = one
AskUserQuestion call').
- duplicate 'Never group distinct issues.' pins (2 -> 1) and the rest of the
Design gate 0 sentences -> kept free: 0 < 1 order, short checks per
approval line, refresh < Read-back gate < rerun order; gate judge
'plan-design-review/SKILL.md passes'.
- CEO readiness/gate/0D sentences -> kept free: one short check per approval
line, readiness order, `Approval readiness: PASS`, gate order Read-only <
Verify readiness < 1. Read, route order, /stop for the actual answer/i in
step 4, `D<N> — <ROW-ID>` header, row fields; admin-route sentences ->
ceo-workflow-clarity.test.ts kept checks. Dropped: 'No report or completion
log is needed' (order check carries it), 'Save or present the updated plan',
'checked row IDs...' (marker kept), strategy-only/narrow-decision
sentences (default kept), cross-model/integration sentences reduced to
external-only and native-fallback checks.
- Eng readiness/procedure sentences -> kept free: short approval checks,
gate numbering/order, AUQ call < /stop until the actual answer arrives/i <
Record the answer, recovery order; 'separate it and rebuild this
comparison' -> auq-format-always-loaded.test.ts PER_SKILL_RULES.
- Exit gate 'contract violation' sentence (t01 F9, design/devex/codex) ->
kept free: heading anchor + /do not call ExitPlanMode/i inside the gate.
- Unresolved-decisions gate (t01 F5): '(MANDATORY', 'Never omit'/'never
omitted', 'FINAL non-whitespace line is the unresolved-decisions', 'FAILS the
gate', 'DROP the current skill' -> kept free: NO UNRESOLVED DECISIONS,
/final\s+non-whitespace\s+line/i, `**UNRESOLVED DECISIONS:**`, /missing\s+status
[^.]*fails/i in every gate skill and the resolver, /avoids double-counting/i,
the old soft-wording negative pin.
- delete-then-append 'never mid-file' / 'Do NOT replace the section in place'
(t01 F6) -> kept free: 'delete-then-append flow' + /append the new report at
EOF/i; old-wording negatives kept.
- design-html '**Never include by default (AI slop blacklist):**' (t01 F18) ->
kept free: /AI slop blacklist/i, catalog id comment, lib/design-catalog.ts.
- CODEX_BOUNDARY 'Do NOT read or execute any' casing (t10 F4) -> kept free:
/do not read or execute any/i in every codex-calling skill.
- CEO 0D order anchor '**STOP for the actual answer...**' (one of the 8) ->
kept free: /stop for the actual answer/i at the same position.
Mutation pass (scratch worktree, generated SKILL.md/sections plus
spec-review.ts and lib/office-hours-review.ts; the freshness test is excluded
with -t because any mutation makes it STALE): 43/43 as expected. 25 kept-step,
marker, safety, numeric and retirement-control mutations go red; 18 rewordings
of dropped sentences and lowered-register STOP/NEVER/FAILS lines stay green.
Log: .context/mutation-gen-skill-docs.md.
Runtime (Bun 1.4.0, wall, 3 runs): before 4.42/4.49/4.70s (median 4.49s),
after 4.42/4.53/4.63s (median 4.53s).
* test(W7c): review-workflow-clarity keeps order, tokens and gates, drops judged prose
W7c (t06 #12). One test file. Each removed pin was the text fix for a past
`review/SKILL.md workflow` judge finding; that judge (gate lane) still
grades the prose, so the free test keeps only structure, tokens and gates.
Removed assertion groups (invariant -> remaining protection):
- Plan-audit sentences ("retain the exact command ...", "A mixed item
contributes to both lists", "Keep external-state ...", "If only behavioral
checks remain ...", "File-existence checks ... are static audit checks")
-> audited deliverables vs deferred behavioral checks: kept free checks on
the separation, never DONE from a diff, zero-deliverable no-waive,
UNVERIFIABLE -> Step 4.7, read-only audit (no apps/APIs/state) and inspect
-before-invoke order; gate E2E review-exploratory-small-cli (gate).
- QA loop/report duplicates of qa-probe-gates / qa-caller-authority (probe
loop sentences, shared contracts, report layout prose, "Only the parent
runs report-only discovery", "Read agent/user updates ...", "Prepare one
provisional QA section", smoke composition) -> owned there (free, every
host); here only `5 minutes/12 probes`, headings, link-every-checkpoint,
no second report, never overwrite another run, freshness vs current inputs.
- Persistence/finalization prose (~45: "final zero-edit pass, reconcile",
"by structural identity", "without requiring deleted pre-extraction
blocks", "raw bytes equal the bound snapshot blobs", "Keep both through
re-reviews", "Earlier core tokens remain unused", "Re-read its final-
snapshot supporting source ...", "Fixed advice needs no skip coverage",
"The required in-host adversarial result controls native completion",
"Optional outside attempts keep their own incomplete records ...", etc.)
-> kept free token list (REVIEW_START/PASS_START, COMPLETED, CONVERGED,
CYCLES=0 once, `review_binding`, `snapshot_covered_paths`,
sharedLibsFingerprint, `completed:false`, evidence_paths/helper_target),
cycle limit (at most 3, Below 3 repeat, At 3 persist `converged:false`),
section order, and the integrity gates below; judge `review/SKILL.md
workflow` (gate lane); gate E2Es review-army-delivery-audit,
review-army-json-findings, review-army-quality-score (gate).
- Confidence-calibration prose (data loss/outage examples, missing field /
nullable / race quoting, metaclass/ORM sentence, missing-literal sentence,
learning-log sentence) -> kept the score table as a routing table (each
band's action), `[CRITICAL]` / `[CRITICAL|INFORMATIONAL]`, no P0-2,
`file:line`, force 4-5, never invent 7+, unverified-without-quote, gate
before table; judge `review/SKILL.md workflow` (gate lane).
- Shared-code reuse safeguard enumeration (assume-unchanged/skip-worktree,
sparse index, symlinks, submodules, Git filters, encodings, fsmonitor,
textconv, provenance, binding wording) -> enforced in code and covered by
free tests test/shared-libs-snapshot-check.test.ts,
test/shared-libs-evidence.test.ts, test/shared-libs-checker-interface-
evidence.test.ts; kept the checker command/heredoc/JSON tokens and the
fail-closed lines.
- Misc definitions ("A probe is affected when ...", "An invocation is this
/review run ...", "Step 1.5's provisional notes ...", "Otherwise record
each considered specialist", "Core findings use the confidence gates
below", "highest confidence", "distinct specialists", "all source names",
"active or unknown reader/writer", Greptile "Before edits, inspect ...")
-> judge `review/SKILL.md workflow` (gate lane).
Kept as case-insensitive meaning checks (stop/consent/approval/safety):
no edits before Step 5, readers returned or confirmed stopped, no edits in
Step 4.8, stop without edits on unconfirmed readers (review and ship),
stop at 3 cycles with no clean summary or fourth pass, failed/blocked
probes mean incomplete, ship named-risk cannot complete review, native vs
outside cannot substitute, structured-review gate, never carry coverage
forward, never invent a binding, skipped advisory cannot suppress a defect,
user-skip-only suppression, Greptile reply != code approval and wait for
approval before editing, HIGH-impact gate options (A ends, read-only audit,
no shipping authorization), never downgrade severity, never trust a supplied
hash, missing metadata cannot dedupe, test creation needs approval,
report-only review never runs setup/installs/cookie import.
Kept unchanged: all marker-order arrays, manifest order, Pre-Landing summary
after the logger, finish-token count and negatives, stale-wording bans
(incl. `git diff origin/main`), ship/review routing negatives.
Cosmetic pins dropped: STOP / NON / COUNT capitals; the test titled "resolves
the judged ... ambiguities" is renamed to say what it keeps.
Mutation log: .context/mutation-review-workflow-clarity.md (23 mutations,
0 unexpected: 3 reorders, 4 markers, 11 safety red; 5 rewordings green).
* test(W7c): ship-control-flow keeps step routing, tokens and gates, drops rule prose
W7c (t09 F1, F2, F3, F4). One test file.
Removed assertion groups (invariant -> remaining protection):
- Work-list prose ("Expand a repair into individual steps ...", "This
replaces the current item ...", "Add its destination only if ...", "The
saved list takes precedence ...", "For another repair, repeat rule 2 ...",
"The unchanged release steps follow", "Follow the saved work list",
"Keep CYCLES and scoped approvals across this repeat", "Keep the findings
and their approvals", "any further repair inserts its checks ...") ->
repairs insert ordered steps ahead of pending work: kept free checks on the
example sequences (`5 → … → 11.5`, `9 → 10 → 11` before 11.5, `5–11.5 →
12–14 → 16`, `14.5 → 15 → 16`, `9 → 10 → 11 → 11.5`), insert-before-
pending routing lines, no unlisted steps, same attempt counts, no reset of
the one-repair limit; judge `ship/SKILL.md workflow` (gate lane); gate
E2Es ship-docsync-recovery, ship-docsync-stale-after (gate).
- Queue-qualification sentence pins duplicated in ship-version-sync (t09 F4:
"require successful utility output ...", "`offline:false` qualifies ...",
"Offline output without that fallback ...") -> kept in
test/ship-version-sync.test.ts next to its script-behavior tests (free);
here the Qualify < Usable < No-usable order, `NEW_VERSION=CANDIDATE_VERSION`,
`>= NEW_VERSION`, `BUMP_LEVEL`, `currentVersion` and the approval line stay.
- Distribution prose ("List candidate distribution paths", untracked files,
manifest sentences) -> kept the New-artifact branch label, AskUserQuestion
and the no-release-during-/ship safety line; gate E2E ship-local-workflow
(gate).
- Dispatch/dashboard/coverage prose ("Omitting the flag runs the subagent in
the background", "keeping a fresh context", "Use one row for each entry in
step 1", "including its undetermined-percentage and test-only rules") ->
kept the `run_in_background: false` contract at all three sites, the
dashboard header/verdict tokens, no inline Skill fallback, coverage gate
not bypassed; gate E2E ship-coverage-audit (gate).
- Recovery/docs/test sentences ("If an attempt remains and either ...", "a
concrete launch/input/permission correction ...", "restart Step 16 stage 1
to regenerate ...", "This recovery also applies ... stage 5", "Content-
preserving commits keep valid evidence", "Retain queued fixes and restore
coverage", "If this pass made edits, resume at the next decision ...",
"Undispatched host-unsupported/gated specialists do not block", "count it
in the invocation record before launch", "Keep Step 9.4's incomplete
flags", "saved handle, original token and source", "unknown or missing
status is unavailable", "Finish the saved replies ...", "fetch and inspect
the remote, then merge ...") -> judge `ship/SKILL.md workflow` (gate
lane); gate E2Es ship-docsync-* (gate) and ship-skipped-queued-finding
(gate); the adjacent stop/approval lines stay free.
Kept as case-insensitive meaning checks (t09 F1/F3; stop/consent/approval
and safety lines): STOP and AskUserQuestion gates apply during repairs, a
repair never resets or expands approvals, children return evidence not
permission, prior-invocation audits never qualify, one repair/re-audit and
no third attempt (initial-plus-one, once), Otherwise -> stop unless the user
accepts the named docs risk, never silently refresh hashes, never run a third
audit, dispatched-reviewer-missing -> stop, CYCLES >= 3 -> stop with
`converged:false`, no fourth cycle, missing coverage cannot be replaced,
failed probes never clean, required-probe gate before Step 10, cannot waive
reviewer/test/security gates, native recovery stops the task first and
remains blocked, outside output cannot replace native, never attach new
tokens to old work, failed build stops shipping, never edit the child's
counts, test failure stops publication, push failure stops with no Step 19,
never rewrite history, never bypass failed guards, both redaction scans
before publishing, no release publish during /ship, only approval changes the
version, declining bootstrap is not test approval.
Kept unchanged: the executed plan-tune nudge shell test (3 roots), section/
step ordering checks, Step 11.5 placement and `review_binding.*` fields,
branch-label order in the adversarial finish (every host), all stale-
wording bans, `(recommended)` marker on Add tests.
Cosmetic pins dropped: STOP / ONE capitals (t09 F1, F3).
Mutation log: .context/mutation-ship-control-flow.md (21 mutations, 0
unexpected: 3 reorders, 3 markers, 9 safety red; 6 rewordings green).
* test(W7h): replace workflow-judge-cache source-grep counts with an invariant
W7h retirement (t09 F16, t13 F6) of the source-grep counts in 'workflow
registration preserves model work and reserves only terminal-recording
grace'. The stage-order check over runWorkflowJudge (the cheapest guard) and
every behavioral callback test stay.
Retirement card:
- test: workflow-judge-cache.test.ts pins of skill-llm-eval.test.ts source:
"execution: reused ? 'reused' : 'executed'", 'const workDeadline = started
+ JUDGE_MS;', 'const WORKFLOW_JUDGE_RECORD_MS = 5_000;', 'const
WORKFLOW_JUDGE_TEST_MS = JUDGE_MS + 10_000;', "testName: 'review/SKILL.md
workflow'", and the magic counts /}, WORKFLOW_JUDGE_TEST_MS\);/ x17 and
/}, JUDGE_MS\);/ x7.
- detects: any workflow eval added or removed, any constant reformatted.
- non_test_callers: none.
- stronger_proof / replacement: (a) a new invariant in the same test: every
`await runWorkflowJudge(` registration closes with WORKFLOW_JUDGE_TEST_MS
(the property the 17-count stood in for, now independent of how many evals
exist); (b) the real-callback tests in this file exercise execute-once,
reuse with provenance (execution reused/executed), timeout, supersede,
expiry and the recording deadline.
- history: 636175d (#2898); last 7fca42a.
- validation: bun test test/workflow-judge-cache.test.ts.
Controls (scratch worktree, test/skill-llm-eval.test.ts): moving cache.publish
before the score assertions or registering the ship workflow judge with
JUDGE_MS goes red; adding a correctly registered eval and reformatting
5_000 as 5000 (both red under the old pins) stay green (4/4). Log:
.context/mutation-workflow-judge-cache.md.
* test(W7h): retire the bws session-awareness (ELI16) paid case
W7h retirement (t14 F5). Removes the case from test/skill-e2e-bws.test.ts and
its E2E_TOUCHFILES / E2E_TIERS (gate) / E2E_KINDS (rule) entries in
test/helpers/touchfiles-data.ts; scripts/paid-test-durations.json is
per-file and test/helpers/periodic-exclude-data.ts had no entry.
test/touchfiles.test.ts selection examples now name sibling cases with the
same touchfiles (skillmd-outside-git, skillmd-no-local-binary).
e2e-tier-alignment, eval-kinds and touchfiles stay green.
Retirement card:
- test: skill-e2e-bws.test.ts 'session-awareness' (gate, paid).
- detects: nothing gstack ships. The prompt coaches a mode that no longer
exists ("_SESSIONS=4, so ELI16 mode is active ... Re-ground them";
`git grep ELI16` outside test/ and CHANGELOG is empty) and says "DO NOT
actually call AskUserQuestion"; every asserted word (billing/acme,
payment/feature, stripe/checkout, recommend) comes from the prompt itself.
- non_test_callers: none.
- search_command: git grep -n "session-awareness\|ELI16" -- test scripts
- stronger_proof / replacement: the AUQ format's grounding line
'Project/branch/task: <1 short grounding sentence using _BRANCH>' is pinned
free by plan-review-calibration.test.ts (format tokens) and graded by gate
E2E auq-format-gate; session identity in the preamble stays pinned by
skill-validation.test.ts 'contains session awareness' and
gen-skill-docs.test.ts 'session awareness lives in gstack-skill-start'.
- history: c118e24 v1.64.1.0 (#2572).
- validation: bun test test/touchfiles.test.ts test/e2e-tier-alignment.test.ts
test/eval-kinds.test.ts.
Control (scratch worktree, against the replacement): removing the
'Project/branch/task:' grounding line from the AUQ format resolver turns
plan-review-calibration.test.ts red (1/1). Log:
.context/mutation-session-awareness.md.
* test(W7h): pin the Codex availability probe free for the four offering skills
Replacement check for the codex-offered-* paid retirement (t14 F8): each of
office-hours, plan-ceo-review, plan-design-review and plan-eng-review must
render the executed `command -v codex` probe and its `not_installed`
fallback mode in its generated SKILL.md + sections. These are bash lines the
agent runs, so a deterministic grep replaces a paid model summary of them.
skill-validation.test.ts already covers the default-on outside voice for
eng/CEO/devex; this adds office-hours and plan-design-review and the
fallback token.
Control (scratch worktree, generated files): removing the probe from
office-hours, plan-design-review or plan-eng-review, or the CEO
not_installed branch, turns the new test red (4/4). Log:
.context/mutation-codex-offering.md.
* test(W7c): ship-workflow-clarity becomes a structural check of ship-only invariants
W7c (t07 F1, F2, F15). One test file: 59 tests / ~438 pins -> 33 tests.
Round-tagged titles (r6/r12/r22) are gone. Every invariant this file shared
with the other converted ship files is now checked once, in its owner:
ship-control-flow (work list, repair ranges, docs/test/push recovery,
adversarial finish order, Step 11.5 binding), ship-plan-completion-
invariants (evidence ledger, push/commit, waivers), ship-reentry-gates (stop
lines, docs reentry, NEW_TITLE), workflow-excerpt (review cycle order,
coverage/probe gates), qa-probe-gates / qa-caller-authority (QA loop).
Removed assertion groups (invariant -> remaining protection):
- Duplicated literals (45 repeated 2-7x, e.g. "Keep the same attempt counts
throughout the invocation" x7, "Docs, TODO edits ... make evidence STALE"
x5, the CYCLES >= 3 / fixes-below-cap / no-edits sentences, push-failure
and native-recovery sentences) -> one free check each in the owners above.
- Smoke/plan-check loop sentences and "Required even for small diffs ..."
-> qa-probe-gates (free, every host); gate E2E ship-exploratory-small-cli
(gate). Kept here: smoke guard started once before step 3, every host.
- Invocation-record field lists (receipt/handle/attempt field prose, "reuse
this invocation's saved level", FRESH/ALREADY_BUMPED level derivation,
receipt definition, start-token definition) -> kept `BUMP_LEVEL`, record
outside the product tree, approval scope, never borrow/replace a token,
REVIEW_START/PASS_START/DESIGN_START, `gstack-review-log --start`,
`gstack-wtree`; version derivation also in test/ship-version-sync.test.ts
(free); judge `ship/SKILL.md workflow` (gate lane).
- Reuse/judge-evidence prose ("original command, result/counts ...",
"Compare hashes or complete bytes", "consumed files, fixtures ...",
"complete expanded request, rubric ...") -> kept never resample, changed/
unknown dependencies rerun, mandatory reviews still run, freeze inputs;
judge `ship/SKILL.md workflow` (gate lane).
- Build/route prose ("If none exists, record not applicable ...", "declared
generation/build commands ...", "Run them and save results", "Explain why
other changes cannot affect it", "Inspect writer handles, including the
docs child", "Keep Step 8's original child report and counts", "Recheck
affected plan items ...", "append current evidence ...") -> kept stage
order, route-label order, prompts/templates count as behavior, no-change ->
stage 3, writer termination before another writer, stop until confirmed,
build-failed label, no substitute command; gate E2Es ship-docsync-*
(gate).
- Docs-collector prose ("Terminal completion or confirmed termination is
sufficient", "Require every field/type ...", "Compare saved base and input
hashes ...", "Otherwise save post-child hashes ...", "A stale snapshot is
neither ...", "Reconcile those before proceeding") -> kept attempt counting
incl. failed launches, request alone insufficient, exited child blocked,
HEAD/index unchanged + `files_updated`, protected-file exclusions,
`documentation_section`, failed/blocked -> recovery, actual user exception,
blocked status retained, same approved scope and exact content, retry
restarts stage 1; gate E2Es ship-docsync-missing-marker,
ship-docsync-launch-failure, ship-docsync-late-result (gate).
- Release/commit prose ("Record the release decision after a version was
actually written", "Skip unchanged versions and manifest-only repairs",
"Best-effort, non-interactive, non-blocking", "Group VERSION + CHANGELOG
+ TODOS.md ...", "Only the final VERSION/CHANGELOG commit gets the release
version and co-author trailer", "use the first changed component ...
(major/minor/patch/micro") -> kept ALREADY_BUMPED, the stale "skip if
ALREADY_BUMPED" ban, `baseVersion`/`currentVersion`, absent fourth
component is zero, no automatic rebump, digest tokens and pre-push digest
check, no Git tag, commit-before-push order; gate E2E ship-local-workflow
(gate).
- Coverage/design prose ("Count each generation-authorized attempt ...",
"including the initial audit, failures and zero-test results", "Two passes
already used ...", "read-only reassessment uses no pass", design-lite
ownership, same path/line merge, specialist stats, distinct defects) ->
kept the 2-pass and 30/5/2-minute limits, re-entry never resets, missing
permission is not approval, audit-only header/override order/no commit/
return decisions, child JSON, one item with both sources and stricter ASK,
neither pass substitutes; gate E2Es ship-coverage-audit,
ship-coverage-value (gate). Design-review-lite E2E is periodic, so the
merge rule keeps its free meaning check here.
- Spec/title/comment prose ("existing open PR/MR", "one match supplies the
existing title/identity", "Save the result for Step 19's recheck", "In a
new shell, restore ...", "Partial, deferred, failed, dropped or unverified
scope uses ...", "newest", "Try to auto-resolve if they are simple",
"distinguish an app from a library/CLI", "If the ask is App Store/
TestFlight distribution", "a new package.json or Cargo.toml alone ...",
"After edits, the full re-review repeats ...") -> judge `ship/SKILL.md
workflow` (gate lane); ship-apple-gate (free) for the Apple route.
Kept as case-insensitive meaning checks (stop/consent/approval/safety,
always kept): never invent credentials, ask for unknown targets first,
include the workflow in tests/review, frontmatter read as data never shell
source, exact spec_branch match, positive-integer issue number, Closes #N
only for fully completed scope, lookup failure/ambiguous match -> stop never
"no PR", never publish an unprefixed title, ambiguous conflicts -> stop,
AskUserQuestion and wait, unclear Apple target -> AskUserQuestion and wait,
confirmed app -> stop and Read, stop for repair (recommended) or accept each
named probe risk, skipping a fix is not risk acceptance, accepted risk is not
passing verification, queue without editing in Steps 10/11, never credit
outside coverage, do not report a clean review, unavailable outside
challenge never resets the three-cycle limit, records mismatch blocks
release, missing snapshots block regardless of HEAD, uncertain edits cannot
be exempted, scripts/dependencies/runtime config need live tests, named
testing gap A/B/C (recommended), reuse prior B only for same scope, declared
but unavailable suite blocks, explicit untested-scope approval, report the
gap never FRESH, no documentation writer after push, do not run create
commands for an existing PR, Greptile status truthfulness.
Kept unchanged: all stale-string bans, machine tokens and JSON contracts
(`gh pr list ... --json number,title,url`, glab list, `v$NEW_VERSION `,
`${NEW_TITLE:?...}` guard, exit 3, `--allow-paths ...`, `| FRESH (exit 0) |`,
`--label <lane> --expect-cmd`, `gstack-review-read`, `git diff <reviewed-tree>
<current-tree>`, `"status":"complete|no_pr|unavailable"`, specialist and
coverage JSON, `status:"unavailable"`/`completed:false`/`converged:false`,
`Pre-Landing Review: INCOMPLETE`, `ALREADY_PUSHED`), the threshold/branch/
installed-asset reference test, the section-index row check.
Cosmetic pins dropped: STOP / ONE / ONLY capitals and bold (t07 F2).
Mutation log: .context/mutation-ship-workflow-clarity.md (23 mutations, 0
unexpected: 4 reorders, 4 markers, 9 safety red; 6 rewordings green, all of
which turned the old test red).
* test(W7c): qa-exploratory-callers keeps phase order and authority, drops duplicated prose
W7c (t04 F8, F16). One test file; only the generated-parent-path and
runner-prompt pins change. The validator-backed caller tests (observer,
checkpoint causality, read-only diff grammar, write watcher, deadline
authority) are unchanged.
Removed assertion groups (invariant -> remaining protection):
- Parent-path loop and preparation pins duplicated from qa-probe-gates
(Reads in order, "Reuse Step 4's surfaces ...", "Finish missing methods
before charters", isolation preflight, shared preparation order, the six
plan-execution sentences, the three shared loop contracts) -> owned by
qa-probe-gates (free, every host, with semantic mutation controls).
- Parent prose ("Templates cannot replace them", "Only the parent runs
report-only discovery", "Read agent/user updates and await results ...",
report-clean and not-run list duplicates of qa-caller-authority) -> caller
observer attribution tests in this file (free) and gate E2Es
review-exploratory-small-cli, ship-exploratory-small-cli (gate); report
gates stay in qa-caller-authority (free, every host).
- Shared-loop duplicates (preserve key/value, Q supplies observed, write the
report, return to step 2, pass requires) -> qa-probe-gates /
qa-caller-authority; kept the observationCommand/observed field definitions
and identity-hash rule here.
- Runner harness prompt sentences (t04 F16: receipt-interface prose,
appendSystemPrompt rules, scheduling prompt) -> reduced to one anchor per
rule; `at most ${maxTurns} assistant turns`, maxTurns/timeout/reserve
values, `(probe-...)`, `reports/review.md`, and every `not.toMatch`
scenario-answer ban stay. validateCallerEvidence remains the behavioral
oracle.
Kept as case-insensitive meaning checks: phase order 1-4 per caller,
review readiness follows report-only rules and never installs/imports
cookies/bootstraps, smoke stop at 5 minutes or 12 probes, G enforces the
deadline, never reset D/bypass G, plan checks remain required past the
smoke budget, /review incomplete and /ship blocked unless the user accepts
the named risk, repeat step 3 for affected checks, harness keeps parent
decision gates, turn limit never authorizes skipping work, never group
probes, Hard deadline UTC rule, HANDOFF.md read before completed records,
no checkpoint for deferred ideas.
Cosmetic pins dropped: AND / Never capitals.
Mutation log: .context/mutation-qa-exploratory-callers.md (15 mutations, 0
unexpected: 2 reorders, 2 markers, 6 safety red; 5 rewordings green).
* test(W7h): pin the CEO /office-hours prerequisite structure free
Replacement check for the plan-ceo-review-benefits paid retirement (t14 F7).
The paid case had a model summarize plan-ceo-review/SKILL.md and grep the
summary for "office hours" and "design doc". The rendered text is static, so
this free test checks it directly: the Prerequisite Skill Offer triggers on
the design-doc check's "No design doc found", offers
'A) Run /office-hours now' and 'B) Skip — proceed with standard review', does
not re-offer later in the session, and Mid-session detection (0A) offers
`/office-hours`. Per the Eng Retirements item, CEO invariants become
periodic-only once this gate case retires, so they keep this structural
free check.
Control (scratch worktree, generated plan-ceo-review/SKILL.md): removing the
/office-hours option, the no-design-doc trigger, the mid-session offer or the
no-re-offer rule goes red; rewording the pitch stays green (5/5). Log:
.context/mutation-ceo-benefits.md.
* test(W7h): retire the paid SKILL.md-summary cases in skill-e2e-plan
W7h retirement (t14 F6-F8): office-hours-spec-review, plan-ceo-review-benefits
and codex-offered-{office-hours,ceo-review,design-review,eng-review}. Each
asked a model to read a generated SKILL.md, write a summary, and grepped the
summary for facts the generated file states directly.
Registration cleanup in the same commit: E2E_TOUCHFILES, E2E_TIERS (all six
gate) and E2E_KINDS (rule) in test/helpers/touchfiles-data.ts; six
scripts/paid-test-durations.json case-shard entries; no
test/helpers/periodic-exclude-data.ts entries existed. The fast PR profile
(scripts/test-pr-profile.ts) drops plan-ceo-review-benefits and
office-hours-spec-review from PR_PROFILE_CASE_IDS and PR_PROFILE_FILES. Tests
that named the retired ids as live examples move to existing ones:
paid-free-boundary and paid-pr-profile (a CEO template change now plans
auq-format-gate plus the CEO judge; the case-shard fixture uses
plan-review-report), test-pr-profile, touchfiles (CEO selection count
21 -> 19), the touchfile-moved-code w5 golden (retired ids removed), the
behavior-lane case-shard census (78 -> 72) in cookie-validation-phases, and
the skill-e2e-plan timeout list and full-gate PR floor (78,425 -> 72,755 s)
in paid-retry-supervision. e2e-tier-alignment, eval-kinds,
eval-detach-timeout-floor and paid-shards stay green.
Coverage consequence: per the Eng Retirements item, plan-ceo-review-benefits
was the only gate-tier CEO E2E in the fast PR profile, so CEO invariants are
treated as periodic-only under the W7c gate (every CEO conversion in this
branch keeps one free check per invariant); the gate judge
'plan-ceo-review/SKILL.md modes' still runs for CEO prompt changes. An
office-hours prompt change now has no fast PR E2E and is reported as
deferred to broad coverage rather than run.
Retirement cards:
- office-hours-spec-review: detects the Spec Review Loop's stated dimensions,
dispatch tool, iteration cap and metrics. Replacement: gen-skill-docs.test.ts
'SPEC_REVIEW_LOOP resolver' (round-3 cap, prepare/check/finalize commands,
verdict and round-file wiring) and test/office-hours-review.test.ts (verdict
parsing). Control: changing the round limit in
scripts/resolvers/spec-review.ts turns gen-skill-docs red.
- plan-ceo-review-benefits: detects the CEO /office-hours prerequisite and
mid-session offer. Replacement: gen-skill-docs.test.ts 'plan-ceo-review
offers /office-hours when no design doc exists and detects a lost user
mid-session' (previous commit). Control: 4/4 red mutations there.
- codex-offered-* (x4): detects the `command -v codex` probe, a fallback and
optionality. Replacement: gen-skill-docs.test.ts 'Codex outside voice is
offered behind an executed availability probe' (probe + not_installed
fallback for all four skills) and skill-validation.test.ts 'plan reviews run
the Codex outside voice default-on'. Control: 4/4 red there.
- non_test_callers: none; history: c118e24 v1.64.1.0 (#2572).
- validation: the registration tests named above.
Controls log: .context/mutation-skill-e2e-plan-retirements.md.
* test(W7h): delete the codex-offering prompt builder left unused by the retirement
Dead-code follow-up to the codex-offered-* retirement: buildCodexOfferingPrompt
(test/helpers/codex-offering-fixture.ts) had no caller besides those cases.
Deletes the helper, its free test (test/codex-offering-fixture.test.ts), the
two captured public fixtures it replayed, its scripts/free-test-durations.json
entry, and the helper/fixture paths still listed as touchfiles of six plan
review E2Es in test/helpers/touchfiles-data.ts.
Retirement card:
- test: codex-offering-fixture.test.ts (pinned the builder's prompt text and
replayed captured timeout/CDD transcripts against it).
- detects: changes to a prompt that no paid case sends any more.
- non_test_callers: none (grep -rn codex-offering test scripts is empty).
- replacement: none needed; the behavior it supported is now the free probe
check in gen-skill-docs.test.ts.
- validation: bun test test/touchfiles.test.ts test/touchfiles-map-diff.test.ts
test/paid-shards.test.ts test/e2e-tier-alignment.test.ts; bun run typecheck.
* test(W7h): delete validateOfficeHoursSpecSummary left unused by the retirement
Dead-code follow-up to the office-hours-spec-review retirement:
validateOfficeHoursSpecSummary in test/helpers/office-hours-completion.ts graded
only that paid case's model-written summary. Deletes it and its free
describe block in test/office-hours-completion.test.ts ('office-hours
spec-review summary completion'); every other validator and test in both
files is unchanged.
Retirement card:
- detects: a summary missing five dimensions, the Agent dispatch, the 3
iteration cap or the four metrics.
- non_test_callers: none.
- replacement: the facts it graded are pinned free on the generated text by
gen-skill-docs.test.ts 'SPEC_REVIEW_LOOP resolver' (round-3 cap and loop
wiring); see the retirement commit's control.
- validation: bun test test/office-hours-completion.test.ts.
* test(W7h): drop the no-op review-report check from setup-gbrain-remote
W7h retirement (t12 F9) of one assertion in the paid setup-gbrain-remote
case. No registration changes (the case stays).
Retirement card:
- assertion: `expect(/## GSTACK REVIEW REPORT|critical_gaps/i
.test(result.output)).toBe(false)` with its comment.
- detects: /setup-gbrain writing a plan-review report or critical_gaps
findings, which it never produces; the removed comment itself said
"Setup-gbrain doesn't have a review report contract". Copied from the
plan-review tests (c118e24, #2572).
- non_test_callers: none.
- replacement: none needed; `grep -rln "PLAN_FILE_REVIEW_REPORT\|GSTACK REVIEW
REPORT\|critical_gaps" setup-gbrain/*.tmpl setup-gbrain/sections/*.tmpl`
is empty, so there is no behavior to control. The case's real contracts stay:
the secret token never reaches CLAUDE.md, `mcp add ... --transport http`,
and `Mode: remote-http` (read by bin/gstack-gbrain-detect).
- validation: bun test test/skill-e2e-setup-gbrain-remote.test.ts (skips
without EVALS; module loads).
* test(W7h): delete incompleteFirstFileView, which no paid case uses
W7h retirement (task scope: "incompleteFirstFileView + its free test in
test/shared-libs-fixture.test.ts if no paid case uses it"). `grep -rn
incompleteFirstFileView test scripts` showed only the export in
test/helpers/shared-libs-eval-fixture.ts and its own free describe block;
no paid case or grader calls it, so the helper and the two tests that pinned
it are dead code.
Retirement card:
- test: shared-libs-fixture.test.ts 'incompleteFirstFileView (census
36641820398 shared-libs-pr-coverage)' (2 tests).
- detects: regressions in a page-1 recovery classifier nothing consumes.
- non_test_callers: none.
- replacement: none needed; the shared-libs page budgets that a recovery read
is charged to stay enforced by the kept budget function and its tests.
- validation: bun test test/shared-libs-fixture.test.ts (241 pass);
bun run typecheck.
* test: update the periodic release floor for the opus-5-5 overlay case
paid-retry-supervision.test.ts 'detached PR fallback and release commands
cover their actual default worker budgets' was red on the integrated base
23a0be82d (green on f30b7b7): 737bf478d (E2, "dedicated-tools overlay case
pinned to claude-opus-5-5") added a periodic file, so the recomputed periodic
release floor is 33,852 s, not the pinned 33,821 s. Updates the pinned floor
and the two-tier sum (55,546 -> 55,577 s); the detached release wall
(116,700 s) still exceeds the recomputed census wall plus 120 s, which the
same test asserts, so package.json does not change. eval-detach-timeout-floor
stays green.
* test(E1): pin CLAUDE.md facts, /ship step references and state-root literals
New free test test/instruction-facts.test.ts (CEO/DX/Eng E1 items; DX-13 one
named test() per check, each failure prints both values, file:line and the
fix):
- 'CLAUDE.md names every TREE_MUTATING file and does not call the set
empty': imports TREE_MUTATING from scripts/test-free-shards.ts (today
test/bootstrap-retention.test.ts).
- 'CLAUDE.md states the current catalog ceiling from
test/catalog-budget.test.ts': the "`CATALOG_BUDGET_TOKEN_EQUIVALENTS`
(N today" value must equal the constant (1,194).
- 'CLAUDE.md points at package.json for detach timeouts instead of stating
numbers': no eval:bg* --timeout value appears in CLAUDE.md (plain or with
commas), and the detach section names package.json's eval:bg:gate /
eval:bg:periodic and states no timeout number.
- 'every explicit /ship Step reference names a defined /ship step with the
expected title': matches only `/ship Step N` and `/ship's Step N`
(backticked or not) across every .tmpl and scripts/resolvers/; each must
be a table row whose step is a heading in ship/SKILL.md.tmpl or
ship/sections/*.md.tmpl whose title contains the row's subject, and the
reference's line or enclosing heading must mention that subject; stale rows
fail. Today: document-release release-body Step 7 -> /ship Step 14
(TODOS.md), plus the incident-history comment in
scripts/resolvers/constants.ts ("/ship Step 18"), kept as a historical row
with a reason (handoff: that comment's step is stale; the dispatch is Step
14.5).
- 'negative control: moving a reference to another existing /ship step
fails': rewrites the TODOS reference to Step 12 in memory and asserts the
checker reports it.
- 'every ~/.gstack/projects/ and ~/.gstack/analytics/ hit is allowlisted with
a reason' and 'every state-root allowlist row still matches a hit': all 37
current hits in .tmpl and scripts/resolvers/ are covered by 36 rows, each with one of four
reasons (user-facing description; gbrain context_queries manifest glob read
literally by bin/gstack-brain-context-load.ts; source comment; pending
conversion tracked in TODOS.md). The readiness-gate EVAL_DIR rows reuse the
reason from test/state-root-ratchet.allowlist.json. New hits fail, and
converting a literal fails until its row is deleted.
Mutation pass (scratch worktree): 15/15 as expected; drifting the catalog
number in CLAUDE.md or the constant, dropping or emptying TREE_MUTATING text,
adding a TREE_MUTATING key, copying a detach timeout into CLAUDE.md,
moving/undefining/retitling a /ship reference, a new /ship reference, a new
state-root literal and a converted allowlisted literal all go red; unrelated
rewording stays green. Log: .context/mutation-instruction-facts.md.
* test: integration repairs after F2 (calibration test renders the AUQ format; census counts and release floors without the reverted overlay case)
* chore: constants comment names the /ship documentation dispatch, not a stale step number
* test: office-hours-auto-mode joins the fast PR profile (replaces the retired office-hours-spec-review probe)
* docs: TODOS for the Opus 5.5 prompt-cleanup deferrals
* fix(state-root): design-doc discovery reads $GSTACK_STATE_ROOT/projects
DESIGN_DOC_DISCOVERY and autoplan's Step 2 design-doc lookup read the literal
~/.gstack/projects path, so under a non-default state root they missed the
docs office-hours writes. The block now globs "$GSTACK_STATE_ROOT"/projects,
and each caller's bash block (autoplan, plan-ceo/devex/eng-review, the
spec-review prerequisite recheck) resolves the root with the guarded
gstack-paths eval first.
Allowlist: drops the autoplan ls row, both _LOCALDOC rows and the resolver
source-comment row from STATE_ROOT_ALLOWLIST.
Tests: the eng Design Doc Check fixture installs gstack-paths and seeds docs
under a non-default root; the CEO discovery fixture passes an explicit
GSTACK_STATE_ROOT.
* chore: regenerate SKILL.md and context budget after design-doc discovery state-root change
* fix(state-root): history, report and ledger paths name $GSTACK_STATE_ROOT
Agent-facing read/write paths that named the literal ~/.gstack default now
name the state root their writers use:
- canary-history.jsonl and health-history.jsonl (the blocks above already
resolve the root and print PROJECT_DIR)
- ios-design-review report: adds {{SLUG_SETUP}} so the report path is the
PROJECT_DIR it prints
- plan-tune dream-cycle gate's distillation-proposals.json
- retro's skill-usage and eureka reads: read the path gstack-retro-metrics
prints (it already checks $_gstack_sr_root/analytics)
- ship's apple-effects.log durable-effect ledger and the gstack-evidence
ledger description (bin/gstack-evidence writes under resolveStateRoot())
Allowlist: drops the nine matching PENDING rows from STATE_ROOT_ALLOWLIST.
* chore: regenerate SKILL.md, ship goldens and context budget after history/ledger state-root paths
* fix(state-root): taste-profile legacy fallback globs $GSTACK_STATE_ROOT designs
The legacy approved.json fallback in {{TASTE_PROFILE}} (design-consultation,
design-shotgun) named the literal ~/.gstack/projects path while the approval
writers use $GSTACK_STATE_ROOT/projects/$SLUG/designs.
Allowlist: drops the design.ts PENDING row.
Pin (W7a): design-consultation-contract's exact glob string becomes a
meaning-level check (legacy fallback names the state-root designs dir and
approved.json, and no ~/.gstack literal).
* chore: regenerate SKILL.md and context budget after taste-profile state-root glob
* fix(state-root): completion-status telemetry prose names $GSTACK_STATE_ROOT/analytics
gstack-skill-end writes analytics under the resolved state root ($_GH), so the
PLAN MODE EXCEPTION note now names $GSTACK_STATE_ROOT/analytics/ instead of
the ~/.gstack default.
Allowlist: drops the generate-completion-status.ts PENDING row.
Pin (W7a): gen-skill-docs 'render documents the analytics sink' now checks
that the render names the state-root analytics dir.
* chore: regenerate SKILL.md, ship goldens and context budget after telemetry prose state-root change
* fix(state-root): gbrain context_queries globs use {gstack_state_root}/
bin/gstack-brain-context-load.ts resolves the {gstack_state_root}/ prefix
through gstack-paths (configuredStateGlob); the legacy ~ form only matched the
default root. The nine projects/analytics manifest globs in design-consultation,
design-shotgun, investigate, office-hours, plan-ceo-review and retro now use the
prefix, as does office-hours' builder-profile developer-profile.json glob
(plan-tune writes it under $GSTACK_STATE_ROOT).
Allowlist: drops the nine MANIFEST_GLOB rows and the now-unused MANIFEST_GLOB
and PENDING reasons; the header lists the remaining row kinds.
Tests: new brain-context-load case loads the shipped investigate and
office-hours queries against a configured root and proves a file only under
~/.gstack is not read.
* chore: regenerate SKILL.md and context budget after manifest state-root globs
* plan-tune, office-hours, retro: read gate and profile files from the state root (E1 follow-up)
* chore: regenerate plan-tune, office-hours, retro
* release: v1.91.15.0 — Opus 5.5 prompt cleanup, behavior-level skill tests, transcript consent
* test: calibration-gate scan reads tracked files with POSIX paths (windows-free-tests)
* test: skillify E2E sweeps the state root (GSTACK_HOME) where the global tier actually writes
* qa-only: one rule for mixed-run clocks; annotations and materialize are per probe directory
* chore: regenerate qa-only
* test: shared-libs evals deliver the skill instructions in context, as a loaded skill does
* Revert design-doc discovery state-root conversion: it made plan-eng-review ask its scope gate in prose (plan-mode no-op eval)
* chore: regenerate after design-doc discovery revert
* test: plan-review-report prompt asks plainly to save the review to plan.md
* docs: CHANGELOG and TODOS reflect the held design-doc discovery conversion
* docs: exact eval counts for the held design-doc conversion
* test: coverage-audit grader accepts read-only git diff with a -- pathspec (CI run 37094035231 shape)
* qa: plain self-regulation stop rule; drop the report template's link to an index.md nothing writes
* chore: regenerate qa
* qa: --quick sets both tier and exploration; say how browser phases and functional contracts share the probe loop
* chore: regenerate qa
* test: a bare QA helper invocation is a usage probe, like --help (CI run ship-exploratory-unavailable)
* refactor(resolvers): split review.ts into MECE resolver modules (pure move)
Move every function from scripts/resolvers/review.ts, unchanged, into:
- review-dashboard.ts: review dashboard, plan-file review report
- plan-gates.ts: approval check, exit-plan-mode gate, plan-file discovery,
plan-completion audit/gate (ship + review), plan verification exec
- spec-review.ts: both spec review loops, benefits-from, anti-shortcut clause
- outside-voice-steps.ts: Codex second opinion, adversarial step, Codex plan
review, Codex doc review, disabled-outside record
- review-scope.ts: scope drift, cross-review dedup, shared-code reuse
review.ts is deleted; index.ts imports the new modules. gen-skill-docs
output is byte-identical for every host (--host all). Test imports and
source-path references are re-pointed; the two source-text report/gate
tests in gen-skill-docs.test.ts become behavioral renders across every
consuming skill and host. All 46 touchfile entries that named review.ts
now name all five modules, guarded by a recorded selection golden.
* test(browse): black-box auth matrix for every server route and both surfaces
Drives buildFetchHandler fetchLocal/fetchTunnel with no token, wrong token,
root token, scoped token and the SSE cookie for all 33 routes, plus unmatched
paths and wrong methods. Denials assert today's exact status, body and content
type; allowed credentials assert the handler was reached. Written against the
unchanged if-chain server so the W3 route-table refactor must keep it green.
* refactor(shard-engine): move scripts/test-strict-output.ts to scripts/lib/shard-engine.ts
The shared shard engine grows from the existing strict-output module
(runShardChild, killProcessGroup, signal forwarding, strict classifier).
scripts/test-strict-output.ts stays as a re-export so existing importers,
mock.module paths and the strict-output/run-shard-child tests are unchanged.
The engine inherits the global touchfile entry; the free runner's CLI-routing
fixture copies the new module.
* refactor(resolvers): decompose the three >150-line review resolvers (output-neutral)
Split generateAdversarialStep, generateCodexPlanReview and
generatePlanCompletionAuditInner into per-section helpers whose template
literals are copied verbatim, so every function in the new modules is at
or under 150 lines. gen-skill-docs output is byte-identical for every host
(--host all, compared against 96764e80 with a fixed --link-root).
* refactor(resolvers): one outside-voice failure policy (deliberate prose unification)
outsideVoiceFailurePolicy(ctx, opts) in outside-voice.ts now renders the
auth / timeout / empty-response bullets for all four call sites that
hand-typed them (Codex second opinion, adversarial step, Codex plan
review, design outside voices). Options are explicit per site
(timeoutMinutes, onTimeout, stderrOnEmpty, fallback, escape) with no
defaults.
Deliberate generated-prose changes (every host):
- office-hours: 'Fall back to <native> subagent.' becomes
'Fall back to the <native> subagent below.'
- plan-devex-review: the plain 'Auth failure (stderr contains ...)'
bullets become the canonical bold bullets; auth also triggers on
'API key'; 'auth failed' becomes 'authentication failed'.
- review/ship adversarial: 'exceeded 9 minutes and was terminated'
becomes 'timed out after 9 minutes and was terminated'; the timeout
is still MISSING COVERAGE.
- design outside voices: unchanged.
Adds ratchet (d) (test/outside-voice-failure-policy.test.ts) with a
reasoned allowlist for /codex's own CLI errors, the MISSING COVERAGE
retention test, refreshed codex/factory ship goldens, and outside-voice.ts
in every touchfile entry of review.ts and design.ts (selection golden
extended).
* test(pty): fake PTY session driver with an injectable clock through the runner launch seam
The three plan-skill runners take an optional PtyDriver (launch, now,
monotonic, sleep); omitted, they use the real launcher and clocks exactly as
before. test/helpers/pty/fake-session.ts feeds scripted frames through that
seam, and claude-pty-runner.runners.unit.test.ts runs observation, counting
and floor for success, deadline timeout, permission prompt and plan-ready
outcomes with no CLI or real timers. These cases must stay green unchanged
through the W4 split and the runPtySession extraction.
Touchfiles: every entry that lists claude-pty-runner.ts or pty-screen.ts now
also lists test/helpers/pty/**.
* refactor(shard-engine): run both lanes on the shared engine; lane policy injected
Engine (scripts/lib/shard-engine.ts) gains the W2 primitives: per-shard
tmp/Chromium sandbox + async cleanup backstop, log-path allocation and
full-stream log capture, one duration-seed reader/writer with a lane
predicate, LanePolicy (seed predicate + zero-execution verdict),
strictShardStatus, and the shared CLI flag loop. runShardChild takes an
optional companion (signal/settle) and waits a bounded 250ms to reap a
wall-killed child.
Free lane stops spawning shards itself: runFreeShard uses runShardChild
with trackShardBrowser as the companion (win32 path unchanged: no process
group, no negative-pid kill). Its sync state-dir removal stays lane policy.
Paid lane uses the sandbox, log, seed, verdict and flag primitives; the
hollow-shard guard applies PAID_LANE_POLICY. Lane outcomes are unchanged
(free keeps >= 0 seeds and file-count zero-exec rule; paid keeps > 0 seeds,
warning under selection and passed-empty under EVALS_ALL).
paid-free-boundary's closure assertion now names the engine module, where
the strict classifier lives.
* test(shard-engine): engine unit tests, fixture-corpus equivalence, per-lane CLI parity
- test/shard-engine.test.ts: failing/unhandled/module-load output fails both
lanes, per-lane zero-execution and seed rules, whole-group kill on a wall
timeout (both lanes), mocked-win32 path with no negative-pid kill,
companion settle order, log capture, sandbox isolation, flag loop.
- test/shard-engine-equivalence.test.ts + test/fixtures/shard-equivalence:
seven outcome fixtures plus one real shard, run through both lanes and
compared with classifications recorded from the base runners (96764e80).
- test/shard-cli-parity.test.ts + test/fixtures/shard-cli-parity: flag set,
defaults, validation errors and the Unknown argument error per lane match
the base runners.
* refactor(shard-engine): decompose runFreeShard and runPaidShard to <= 150 lines
Output-neutral extraction under the fixture-corpus equivalence and runner
tests: captureFreeStream, explainFreeVerdict and logFreeRecovery (free);
paidShardCommand, settleShardSpool, settleBootstrapRetention and
printLogTail (paid). The bootstrap scope-creation block that
bootstrap-retention.test.ts evaluates stays verbatim.
* refactor(pty): split claude-pty-runner.ts into test/helpers/pty/* behind a barrel
Pure move: every line of the former 5,047-line runner lands verbatim in one
module (four private helpers gain `export` for cross-module use):
binary, screen (absorbs test/helpers/pty-screen.ts, which now re-exports it),
launch, session (PtyDriver), judge, classify, auq, plan-native, boundaries,
runners/{observation,counting,floor}. claude-pty-runner.ts re-exports the
original public surface by name; pty/ modules import siblings directly.
Tests that read the runner's source text:
- rewritten as behavioral: the unit test's model-pin tripwire (fake CLI argv:
fallback chain, --model before extraArgs, hermetic --strict-mcp-config),
pty-skill-seeding-wiring (runners through the fake driver; launcher through
a fake CLI reporting CLAUDE_CONFIG_DIR). The "three wrappers forward model"
grep is replaced by the runners' fake-driver launch assertions.
- pty-screen-session / pty-screen-supervision: stop copying runner source;
they mock.module the real pty/screen.ts (and the fixture cleanup) instead.
- re-pointed to the owning module (they execute a sliced runner body with
injected boundaries; no seam exists for those boundaries yet):
eng-seeded-completion-ai, plan-floor-permission, plan-create-prepublication,
plan-count-completion; hermetic-wiring's source guard now reads pty/launch.ts
and scans every pty/ module for raw process.env spreads.
- plan-count-timeout and pty-output-wake mock the viewport at pty/screen.ts.
* test(ratchet-c): enforcing module/function size ratchet and moved-code touchfile coverage
Ratchet (c) ships enforcing: test/helpers/module-size.ts counts file and
top-level function lengths by brace matching over masked source (strings,
comments, regex literals and template text masked; ${} expressions kept),
covering function declarations, arrow functions assigned to consts and
route-table handler properties, with no parser dependency. Its self-test
uses template literals and code-fence braces copied from
scripts/resolvers/review.ts and design.ts. test/fixtures/module-size-ratchet.json
binds scripts/lib/shard-engine.ts (<= 800 lines, <= 150 per function) and
records the residual runner sizes (free 2352, paid 1921) as non-growth caps;
allowlist entries are keyed on file plus matched text and need a reason.
Failure output lists file:line, the rule, Fix: and the allowlist path.
touchfiles.test.ts gains the moved-code superset check over
test/fixtures/touchfile-move-goldens/ (W2 golden recorded at 96764e80:
test-strict-output.ts and test-paid-shards.ts global, test-free-shards.ts none).
* refactor(browse): declared route table replaces the buildFetchHandler if-chain
The ~1,300-line if-chain in buildFetchHandler becomes a route table:
each entry declares method, path, auth kind and surfaces, and one auth
gate in browse/src/routes/table.ts returns the per-kind denial (root-bearer,
scoped, root-or-sse-cookie: 401 Unauthorized; root-token: 403 Root token
required; extension-origin: 403 Forbidden). Unmatched requests take the
declared fallthrough (root-bearer check, then plain-text 404). Handlers move
to browse/src/routes/{core,pairing,pty,tokens,tunnel,activity,commands,files,
inspector}.ts and receive a RouteContext with auth checks as functions
instead of closing over factory locals. Dispatch order is unchanged:
tunnel filter, beforeRoute overlay, gate, handler. TUNNEL_PATHS stays a
literal in server.ts.
Behavior-preserving: the black-box auth matrix from the previous commit
passes unchanged. /memory and /inspector/events are declared root-bearer
because the blanket check always ran before their SSE-cookie branch.
Source-text route tests are rewritten as behavioral tests through
buildFetchHandler or a route's real handler with a stub RouteContext
(browse/test/route-test-harness.ts). Checks with no runtime seam are
re-pointed to the route modules: Surface type, /inspector/events SSE
helper, sanitizeReplacer imports, /pty-inject-scan sidecar-client import,
and the ngrok config lookup and startTunnel wiring that stay in server.ts.
* test(browse): stubbed-handler auth matrix and route inventory for the route table
Every ROUTES entry runs through the real dispatcher and gate with stub
handlers on each declared surface and six credentials; denials assert the
exact status and body each auth kind returned at 96764e8, admitted
credentials assert the handler ran (with the gate's TokenInfo for scoped
routes). Also pins the reviewed route inventory (method, path, auth kind,
surfaces), that every entry declares auth and surfaces, that the table's
tunnel paths equal the TUNNEL_PATHS literal with GET /connect admitted, the
unmatched fallthrough, and that the root token is rejected on every tunnel
route through buildFetchHandler.
* test(browse): ratchet (b) keeps route dispatch inside the route table
Scans browse/src/server.ts and browse/src/routes/*.ts for pathname
comparisons; only the table matcher and the tunnel-surface filter are
allowed, listed with reasons in browse/test/fixtures/route-dispatch-allowlist.json
(keyed on file plus line text). Also checks every entry declares auth and
surfaces and that gstack registers no beforeRoute overlay itself. Self-tests
plant a violation and assert the file:line, Fix: and allowlist path in the
message, that a shifted line stays allowlisted, and that a reasonless entry
is rejected.
* test: touchfile superset check for modules moved out of browse/src/server.ts
Records the paid evals selected by touching browse/src/server.ts at 96764e80
(17 E2E, 1 LLM judge) and asserts every browse/src/routes/*.ts module selects
a superset. The test reads every golden in test/fixtures/moved-module-selection/
so other moved-code goldens can sit beside it.
* test(shard-engine): give non-timeout corpus fixtures CI headroom; keep the POSIX golden off the Windows lane
Only the wall-timeout fixture keeps a 3s wall; the rest get 60s so a loaded
host cannot turn a pass into a timeout. Base and branch runners still agree
on every classification under the new walls. The Windows exclusion entry
moves the free runner's ratchet (c) residual cap to 2356 lines.
* refactor(pty): one runPtySession loop drives observation, counting and floor
test/helpers/pty/session.ts owns launch -> start -> (poll -> tick)* ->
timeout and the failure contract the three runners each hand-rolled: the
run's own error wins over capture and close errors, close always runs, owned
fixture cleanup runs last (also when launch fails). Each runner now supplies a
PtySessionPlan: its boot/command step, poll cadence (2s observation/floor
sleep; counting's output wake + 250ms coalesce), tick policy (permission
handling, native identity, terminal rules stay per runner because they differ)
and capture hooks. The runner bodies are decomposed into top-level steps so no
function exceeds 150 lines; behavior is unchanged and the fake-driver cases
from the first W4 commit pass unmodified.
The counting capture step and the native completion-summary predicate are now
named functions (countingCapture, isNativeCompletionSummary), so
plan-create-prepublication and plan-count-completion call them directly
instead of executing sliced source. The two harnesses that still execute a
sliced runner body with injected boundaries (eng-seeded-completion-ai,
plan-floor-permission) pass the PtyDriver seam instead of overriding
Date/Bun.sleep.
* test(ratchet-c): register route modules, review resolver modules and server.ts residual cap
* refactor(pty): decompose launchClaudePty and engNumberedFindingAUQ under 150 lines
launchClaudePty (349 lines) becomes launch preparation (args, hermetic
child env, owned state roots), recorder creation, spawn, the trust-dialog
watcher, close, and the session handle over one PtyProcess state object. The
failure order is unchanged: abort the viewport, dispose any recorders created
so far, dispose the viewport, rethrow. The --model / --strict-mcp-config
ordering and seedSkills wiring stay pinned by the behavioral fake-CLI tests.
engNumberedFindingAUQ (345 lines) keeps its guards and dispatch; each
self-contained issue family (declared cache, library retry hooks, cache
owner, injected singleton, shared writers, injected export) moves verbatim
into its own function. Every pty/ module is now <= 800 lines and every
top-level function <= 150 lines.
* test(pty): split claude-pty-runner.unit.test.ts along the pty/ module seams
The 188 unit tests move verbatim into claude-pty-runner.{screen,classify,
auq,launch,plan-native,boundaries}.unit.test.ts (test names unchanged; each
file imports only what it uses from the barrel). The five files that no longer
read a SKILL.md template join the test-of-test ratchet baseline with a reason.
* test(touchfiles): moved PTY modules keep their paid-eval selection
test/fixtures/touchfile-selection/w4-pty.json records, at 96764e8, the paid
evals selected by touching test/helpers/claude-pty-runner.ts (20) and
test/helpers/pty-screen.ts (20). touchfiles.test.ts now asserts every .ts file
under test/helpers/pty/ (and pty/screen.ts for both sources) selects a
superset, reading every golden in that directory so later moves can add one;
a planted-violation case pins the report and its Fix line.
* fix(browse): unexchanged pair setup keys no longer authenticate bearer requests
validateToken accepted a gsk_setup_ key as a bearer on /command, /batch and
/file (found while building the W3 auth matrix). A setup key now only
authenticates the /connect exchange.
* W1: one state-root owner (lib/state-root.ts + bin/gstack-state-root.sh), gstack-paths --explain and fail-stop, parity tests
* W1: guarded migration of every executable state-root site; uninstall deletes only ~/.gstack
Bins, careful/freeze hooks, setup, upgrade migrations, browse/src, design,
ios-qa daemon, lib and scripts resolve the state root through
bin/gstack-state-root.sh (bash) or lib/state-root.ts (TS). Bins source the
twin and stop with a reinstall message when it is missing; hooks source it
and never spawn gstack-paths. browse/src/config.ts and lib/cso/state.ts
delegate to resolveStateRoot. Analytics writers and readers move together
so the usage log stays one file. gstack-uninstall deletes state only at
~/.gstack, refuses (exit 2) when it resolves to /, $HOME or an ancestor,
the checkout or the git root, and leaves any other resolved root in place
with the removal command. Fixtures that copy single bins now copy the twin.
* W1: privacy keys and trust-policy deny tiers merge across state roots; gstack-config reporting; test hermeticity
readConfigKey / gstack_read_config_key return the most restrictive
telemetry, memorable_recall, codex_reviews and update_check across the
resolved root and ~/.gstack; other keys read the resolved root only.
gstack-config set reports an overriding root with the exact override
command, list shows the winning root and a root-variable disagreement line.
gstack-gbrain-repo-policy get merges deny/read-only tiers. gstack-egress
reads through readConfigKey. test-setup.ts strips inherited
GSTACK_STATE_ROOT/GSTACK_STATE_DIR and redirects the legacy root.
* W1: shared hook logging helper (hosts/claude/hooks/hook-log.ts)
One hook-errors.log writer: root from resolveStateRoot, 0600 on every
append, opt-in rate limit used only by memorable-user-prompt. The five
hooks route through it.
* W1: docs/state-root.md and README troubleshooting pointer
Precedence table, a real --explain example, the move-your-state recipe,
merged privacy keys, the uninstall rule, the resolver-failure fix, and the
plugin-mode note (evidence gate: no official plugin distribution).
* W1b: template and resolver prose resolve state through guarded gstack-paths; ratchet (a)
Every gstack-paths eval in templates and resolvers carries the fail-stop
guard; executable ~/.gstack paths in bash blocks (context recovery preamble,
eureka log, analytics, project artifacts, upgrade snooze, setup-gbrain lock,
retro snapshots, ship consent marker) use $GSTACK_STATE_ROOT, and the writer
prose that pairs with them points at the printed PROJECT_DIR / RETRO_FILE.
ship drops export GSTACK_STATE_ROOT. SKILL.md regenerated (claude + codex),
ship goldens re-pinned, parity and context-budget caps raised to the measured
sizes with notes. test/state-root-ratchet.test.ts enforces the rule with a
reasoned allowlist; W1 touchfile entries plus a superset golden.
* refactor: apply W1 state-root edits in W2/W3/W5-owned files; one moved-code touchfile golden for all workstreams
* test: fold the moved-code touchfile golden into touchfiles.test.ts; fix integration fixture closure and caps
* v1.91.11.0: CHANGELOG, TODOS, docs and conventions for the refactor wave
* test: re-measure plan-ceo/design-consultation caps and ship goldens after the guarded plan-discovery and spec-review blocks; add the state-root twin to the workflow-boundaries fixture
* fix(windows): migrations resolve their directory with either path separator; state-root parity compares under the HOME Git Bash actually sees
* fix(review,ship): state plan-check timing after smoke expiry and test_stub Skip semantics (review workflow judge clarity)
* test(qa-eval): webhook fix eval asks for the fix loop's post-repair probes; eight-scenario coverage stays in the report-only case and the harness recheck
* test(qa-eval): re-pin the webhook prompt contract to the fix-loop stage; R29 coverage omissions stay bound by the report-only case
* fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped
* fix(qa): carry #2999's checkpoint receipt link, report-template line and full-revision placeholder (identical hunks)
* test(qa-callers): disable git auto maintenance in the caller fixture
Git 2.47+ runs auto maintenance detached after commit; on the CI runner's git
2.55 it rewrote .git/objects fan-out directories while the write observer was
running, which surfaced as unauthorized mutations. Same gc.auto=0 /
maintenance.auto=false guard the shared-libs fixture already uses.
* test(plan-mode-no-op): require prose evidence for the prose-fallback members so a spinner-frame judge verdict cannot end the run as asked
* test(ship-docsync): carry #2999's seeded-attempt docsync harness (identical files)
The doc-sync fault cases replayed attempt 1 before reaching their gate and ran
out of their 285s budget. The fixture now seeds attempt 1 and the parent starts
at the gate under test. Taken byte-identical from origin/capy/audit-fix-wave
(fb526898, e6ac813d, 6ce10ff7, d0c53577, 77cce3be). Local: stale-before,
recovery and late-result 6/6 PASS (97-164s); the whole file 12/12 PASS.
