Commit Graph
3 Commits
Author SHA1 Message Date
Garry Tanandcapy-ai[bot] bd449234aa Pre-commit /verify fails on a timeout, and the review collector stops reading reviewers' scope lists as findings (GST-3201) (#4527)
Pre-commit /verify now fails a check that times out and runs its checks
on one time budget; a reviewer's scope-list bullets no longer need an
owner ruling to clear; stack tests fail when git can't list a PR's
tests.

Why: each let a result read clean with nothing proving it, or block on
nothing (#4518, #4519). Goal: gates never pass on missing evidence.

Nothing to do; `gstack-checks quick --timeout` is now one budget the
checks share (540 s default).

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/outside-voice#1 reader=outside-voice
Review-Finding: p1/outside-voice#2 reader=outside-voice
2026-11-19 15:17:30 +00:00
Garry Tanandcapy-ai[bot] 2f57b07495 gstack's script runner and merge-queue checks now refuse cut-off command output (GST-3104) (#4502)
The helper that runs gstack's own scripts and `bash -c` commands, and
the merge queue's branch-ownership, stacked-test, release-version and
merge-group record checks, now fail with `SPAWN_OUTPUT_INCOMPLETE` when
Bun cuts a command's output off, instead of treating part of it as the
whole answer.

Why: #4492 added this for the scanners and gates but left these on
Node's `spawnSync`, and its release note claimed wider coverage than it
shipped.

Nothing to do: a new test stops any new gstack command from calling
Node's `spawnSync` directly.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 18:40:12 +00:00
Garry Tanandcapy-ai[bot] 36b349d660 Commands that read cut-off output now fail instead of judging part of it (GST-3086) (#4492)
Commands that read large git or gh output, including the credential
pre-push hook, the pre-merge secret and literal scans and the
sealed-output guard, now fail when Bun cuts that output off, instead of
judging the part they got.

Why: Bun can report exit status 0 together with ENOBUFS and partial
stdout, so a push whose diff passed 64 MiB could get a credential past
the pre-push hook.

Nothing to do: the failure names `SPAWN_OUTPUT_INCOMPLETE` and links its
troubleshooting entry.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 17:00:18 +00:00