Commit Graph
571 Commits
Author SHA1 Message Date
Garry Tanandcapy-ai[bot] e95cea8404 On Capy, /ship hands its pull request edits and comments to Capy's PR tool, always naming the right repository (GST-3183) (#4518)
On Capy, /ship's PR body edits, comments and new PRs no longer go out
through `gh` under the machine owner's GitHub account.

Each write runs its checks, saves the exact text to a private file and
prints a `HOST_PUBLISH:` line that names the repository (and host, off
github.com) it belongs to, so Capy's PR tool sends it to the same place
`gh` would have.

Nothing changes outside Capy (`GSTACK_CAPY` unset).

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=specialist-batched
Review-Finding: p1/specialist-batched#3 reader=specialist-batched
Review-Finding: p1/red-team#6 reader=red-team
Review-Finding: p1/specialist-batched#1 reader=testing
Review-Finding: p1/specialist-batched#2 reader=testing
2026-11-19 11:30:53 +00:00
Garry Tanandcapy-ai[bot] ed267248d3 A folder marked as published data can no longer hide source code or agent files from /ship's review (GST-3158) (#4516)
In a folder a repo marks as published data (`review_content_patterns`),
source code in any language, agent instruction files, config and data
that kept code names by full path now stay in /ship's review.

Why: #4511 let a `.java` file, a binary `AGENTS.md` or a file named by a
kept script leave review there, and reviewers must see every line of
code a PR changes.

Nothing to do: no base policy sets the key yet.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/specialist-batched#1 reader=specialist-batched
2026-11-19 11:15:51 +00:00
Garry Tanandcapy-ai[bot] 944b41e24d Codex gets gstack's skill routing hint and destructive-command check (GST-3172) (#4512)
`./setup --host codex` now adds gstack's skill-routing hint and
destructive-command check to Codex's `~/.codex/hooks.json`, next to your
own hooks, so Codex users get the same guardrails Claude Code users
have.

Codex runs a hook only after you trust it, so nothing fires until you
accept gstack's hooks at Codex's startup prompt or in `/hooks`;
`gstack-doctor` shows whether you have.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team
2026-11-19 11:09:11 +00:00
Garry Tanandcapy-ai[bot] 957fab79c5 Second-model review keeps the reviewer's result and reports budget stops (GST-3181) (#4515)
When Codex reviews a change, gstack now keeps the review file the
reviewer wrote instead of replacing it with Codex's one-line closing
message, and a provider that refuses with HTTP 402 is reported as a
used-up budget instead of "exit 1" or a login failure.

Why: gstack-evals lost 22 review attempts to the overwrite and 5 of 45
sessions to a 402 from a metering proxy whose cause gstack threw away.

Nothing to do: a 401 or 403 is still a login problem. Open notes, one of
them a known gap, are listed below.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=testing
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
2026-11-19 10:27:37 +00:00
Garry Tanandcapy-ai[bot] f13dbb0d4a Ship policy can mark published data as content, so /ship can review large data PRs (GST-3158) (#4511)
A repo can now list published-data folders under a new
`review_content_patterns` ship-policy key, so /ship leaves `.patch`
diffs, `MANIFEST.sha256` and extension-less licences out of review,
while source files there stay reviewed.

Why: gstack-evals #352 is 13.8 MB, 13.6 MB of it published session data,
and could never pass /ship's 2 MB review limit.

Nothing to do until a repo adds the key to its base-branch policy; a
pattern that keeps too many files now stops with
`REVIEW_EXCLUDE_KEEP_TOO_LARGE` instead of being dropped.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p2full/red-team#1 reader=red-team
2026-11-19 09:02:33 +00:00
Garry Tanandcapy-ai[bot] c25390daa2 /ship's review works when the shipped checkout isn't the project's default checkout (GST-3145) (#4507)
/ship's review pass now lets its readers start in a checkout of an
unrelated repository, and refuses to start them in any other checkout
that holds the review's diff base, such as a sibling worktree or a
separate clone of the shipped repository.

Why: a project whose default checkout is another repository needed a
fresh machine for every /ship review, while a worktree or clone of the
same history could read the wrong diff with no error.

Nothing to do: the pass still stops before anything starts if the
shipped checkout can't be reached.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-19 08:55:01 +00:00
Garry Tanandcapy-ai[bot] 12bd33b648 Pull requests that merged a release reuse their earlier test run when the release only regenerated a declared file (GST-3067) (#4483)
When a pull request merges a release whose only extra change is a
generated file the repo lists under `release_outputs`, its earlier
remote test run now counts for it, if the clear command gets
`--allow-repo-commands`.

Why: gbrain paid one extra full CI run for each such pull request,
several a day.

Without the flag nothing changes except that the refusal now says to
pass it; a hand edit to the generated file, or any other changed file,
is still refused.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-19 08:11:34 +00:00
Garry Tanandcapy-ai[bot] b702243859 When Claude Code runs /verify before a commit, it now gets a quick check instead of the full fix loop (GST-3150) (#4508)
When Claude Code calls /verify on its own right before `git commit`,
gstack now runs one quick check-only command that ends in a single
`VERIFY PASS`, `VERIFY FAIL` or `VERIFY skipped: ` line; typing /verify
still runs the full skill.

Why: since Claude Code 2.1.286 any skill named `verify` is run before
every commit, so gstack's fix loop, its first-run notices and a hard
stop in repos with no remote landed on ordinary commits.

Nothing to do; `gstack-config set verify_before_commit off` turns the
check off.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=specialist-batched
Review-Finding: p1/specialist-batched#2 reader=specialist-batched
2026-11-19 06:06:43 +00:00
Garry Tanandcapy-ai[bot] 5afef04e31 The prompt-routing hook suggests skills you install, and stops sending bug reports to /qa (GST-3123) (#4506)
The prompt-routing hook can now suggest skills you installed yourself:
any skill that lists `triggers:` in its SKILL.md, not only gstack's
/review, /qa and /verify. It also stops sending ordinary bug reports to
/qa.

Why: a bug-fix skill you install was never named (0 of 60 real bug
reports); now it's named on 40 of 60, and /qa takes none of them instead
of 3.

Nothing to do after merge.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/specialist-batched#2 reader=api-contract
Review-Finding: p1/specialist-batched#1 reader=security
2026-11-19 04:26:51 +00:00
Garry Tanandcapy-ai[bot] 3f1b82b22a Helper hooks are on by default, the destructive-command check runs as a hook, and prompt routing fires on long bug reports (GST-3110) (#4503)
Claude Code now gets gstack's prompt-routing, skill-contract and
destructive-command hooks on by default, and new OpenClaw and Hermes
registrations get the start hook. On 60 real bug reports, routing now
matches a bug-fix skill on 40 (was 22), but gstack's own skills route 14
(was 17).

Why: on Opus 5.5, unattended, a hook line naming a skill got it loaded
in 58 of 60 sessions, and a skill relying on its description in 0 of 60
(gstack-evals#369).

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1v/outside-voice#1 reader=outside-voice
Review-Finding: p1v/adversarial-native#4 reader=adversarial-native
Review-Finding: p2/red-team#1 reader=red-team
2026-11-18 23:36:58 +00:00
Garry Tanandcapy-ai[bot] 43026970b7 /ship's state-machine check accepts the header lines its reader is told to write (GST-3115) (#4504)
The state-machine check in /ship no longer stops a review because its
reader opened the reply with the `REVIEWED_TREE` and `REVIEW_VERDICT`
lines its instructions require.

Why: on yc-software/qm#3728 the check reported those two lines as gaps,
so /ship stopped before its adversarial review step.

Nothing to do after merge.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 22:33:08 +00:00
Garry Tanandcapy-ai[bot] 2f57b07495 gstack's script runner and merge-queue checks now refuse cut-off command output (GST-3104) (#4502)
The helper that runs gstack's own scripts and `bash -c` commands, and
the merge queue's branch-ownership, stacked-test, release-version and
merge-group record checks, now fail with `SPAWN_OUTPUT_INCOMPLETE` when
Bun cuts a command's output off, instead of treating part of it as the
whole answer.

Why: #4492 added this for the scanners and gates but left these on
Node's `spawnSync`, and its release note claimed wider coverage than it
shipped.

Nothing to do: a new test stops any new gstack command from calling
Node's `spawnSync` directly.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 18:40:12 +00:00
0ab5657112 Changed-number check stops flagging tests that only share a word like limit (#4478) (#4496)
/ship's changed-number check no longer stops on tests that only use the
same word as a changed property: lowering `limit: 120` to `30` used to
report every test that said "limit" and held 120.

Why: `docs/pregate.md` already said a test counts for a word like
`limit` only when it also names the changed module, but the code
enforced that only for one-character values. Tests that import the
module are still reported.

Nothing to do. Thanks to @dtoelke, who reported this and sent the first
fix in #4478.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: dtoelke <14206719+dtoelke@users.noreply.github.com>
2026-11-18 17:03:55 +00:00
Garry Tanandcapy-ai[bot] 36b349d660 Commands that read cut-off output now fail instead of judging part of it (GST-3086) (#4492)
Commands that read large git or gh output, including the credential
pre-push hook, the pre-merge secret and literal scans and the
sealed-output guard, now fail when Bun cuts that output off, instead of
judging the part they got.

Why: Bun can report exit status 0 together with ENOBUFS and partial
stdout, so a push whose diff passed 64 MiB could get a credential past
the pre-push hook.

Nothing to do: the failure names `SPAWN_OUTPUT_INCOMPLETE` and links its
troubleshooting entry.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 17:00:18 +00:00
Garry Tanandcapy-ai[bot] 2767d229fb gstack-artifact validate now refuses a run.json that gstack-autoplan never wrote (GST-3090) (#4494)
`gstack-artifact validate` and `ack` now refuse a run.json that
gstack-autoplan never wrote, so a hand-built run can no longer pass as a
finished review.

Why: a session skipped `gstack-autoplan next`, built run.json with a
script copied from the reference fixture, and got ARTIFACT_VALID.

Nothing to do unless you validate old or hand-made run directories:
rerun those through gstack-autoplan.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 16:45:06 +00:00
Garry Tanandcapy-ai[bot] 45f879b534 The Codex readiness check and the second-model review pick the same model for a custom Codex provider (GST-3089) (#4491)
With a custom Codex provider, `gstack-codex-probe role-ready` and
`gstack-outside-voice run --runner codex-cli` now resolve the
plan-review model the same way, so a session no longer skips a review
that would have run.

Why: the check refused a `config.toml` naming `gpt-6-astra` while the
runner ran it, and a day-one eval session dropped the second-model
review in every phase.

Nothing to do: a custom provider naming the frontier catalog ID just
works; any other name now says how to opt in.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 16:44:07 +00:00
Garry Tanandcapy-ai[bot] 782f4595ed Two owner-answer adds at once no longer collide, and three flaky tests get real fixes (GST-3084) (#4490)
Recording the same owner answer from two processes at once no longer
fails about one time in ten; the second add waits for the first to
finish writing.

Why: this was a daily flaky-test repair, and the owner-answers "two
processes adding at once" failure turned out to be a real race, not a
flaky test.

Nothing to do: tests only change, except the 11 lines in
`lib/owner-answers.ts`.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=testing
2026-11-18 15:08:17 +00:00
Garry Tanandcapy-ai[bot] bf2c126b55 gstack-post no longer reads /ship's own run ids and commit ids as phone numbers (#4480) (#4488)
Posting a /ship PR body no longer stops on a phone-number warning for
the run id and commit ids that /ship writes into it.

Why: most /ship runs hit this confirm (#4480, and #4474), which turned a
privacy guard into noise people click past.

Nothing to do: the next /ship post goes through without `--confirm`.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: v1/outside-voice#1 reader=outside-voice
Review-Finding: v1/adversarial-native#1 reader=adversarial-native
2026-11-18 14:57:04 +00:00
Garry Tanandcapy-ai[bot] 3ecd7168b2 The token-capped /ship child on Claude Code now starts its prompt with the typed /ship command (GST-3078) (#4487)
The /ship child that `gstack-ship-budget launch` starts on Claude Code
now opens its prompt with `/ship --continue ` (or `/gstack-ship` under
`skill_prefix`), so Claude Code expands the skill instead of hoping the
model finds it.

Why: Claude Code expands a skill only when the prompt starts with the
typed command, and unattended Opus 5.5 found a skill from its
description in 0 of 60 sessions (gstack-evals#366).

Nothing to do: the rule for parents is now in docs/unattended.md.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 13:32:03 +00:00
Garry Tanandcapy-ai[bot] 0109703797 Security findings no longer show their file, line or reason in PR bodies (GST-3076) (#4486)
A security finding that an owner ruled a note, dispositioned, or that
review deferred now shows in a PR body only as an opaque id and
"security finding, details recorded privately".

Why: on a public repository the old lines named the file, line and
reason of a live exposure outside the PR's change.

Nothing to do: other findings print exactly as before, and the details
stay in the private approval record.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=security
Review-Finding: p1/red-team#1 reader=red-team
2026-11-18 12:57:24 +00:00
Garry Tanandcapy-ai[bot] 07611a00a7 /ship no longer reports zero blockers when the second-model review found one (GST-3075) (#4485)
When /ship stopped on a second-model review finding marked "Blocks:
yes", the record it left on the PR said no blockers were found; now the
finding is counted and /ship will not write that record until it is
fixed or ruled.

Why: `ready` and the merge step trust that record, so an undercount let
a blocked PR look clean.

Nothing to do: the next /ship run logs Step 11's findings and checks
them before writing.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: h2p1/red-team#1 reader=red-team
Review-Finding: h2p1/red-team#2 reader=red-team
Review-Finding: h2p1/red-team#3 reader=red-team
Review-Finding: v1/outside-voice#1 reader=outside-voice
2026-11-18 12:51:14 +00:00
Garry Tanandcapy-ai[bot] 44170d6791 Unattended /autoplan on Claude Code says its phase guard is on, and a report hidden in reasoning gets a clear fix (GST-3062) (#4481)
An unattended /autoplan run on Claude Code now says its phase guard is
on, instead of saying it is off while the guard blocks it. A phase
report written only in reasoning now gets a denial that says so and
names the exact command to send.

Why: in the day-one eval, two runs were blocked by a guard their own
record called off, and one run ended blocked after four publish attempts
whose report was invisible.

Nothing to do.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 08:47:07 +00:00
Garry Tanandcapy-ai[bot] f87d4325a3 A round grant at the review round cap buys the fix round it names (GST-2968) (#4479)
When /ship stops at a pull request's review round cap, a grant naming
that stop now buys one scoped review of the fix, in the same run or the
next, instead of another read-only full review.

Before, a grant recorded after the read-only review, or between /ship
runs, bought nothing, so teams paid for extra full reviews or second
grants (ghome#40: $8.78 against about $3).

Nothing to do: /ship prints the grant command when it stops.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=security
Review-Finding: p1/specialist-batched#2 reader=state-machines
Review-Finding: p1/specialist-batched#3 reader=testing
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p1/red-team#3 reader=red-team
2026-11-18 08:34:39 +00:00
Garry Tanandcapy-ai[bot] 33b1a965ba /ship's push step ends with one line that says whether it pushed (GST-3053) (#4474)
/ship's push step now always ends with one line that says what happened:
`PUSH: pushed …`, `PUSH: already_pushed …` or `PUSH: failed reason=`,
with the remote, branch and full commit.

Why: an eval grader looked for a `git push` call and counted 48 real
/ship pushes as "no push"; scripts and graders can now match this one
line instead.

If a script of yours matched the old `PUSH: ALREADY_PUSHED ` or `PUSH:
pushed to origin/` lines, update it; the exit status is unchanged.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 03:56:41 +00:00
Garry Tanandcapy-ai[bot] 9222485040 Review planner sends Swift health, permission and on-device storage code to full review (GST-3052) (#4472)
/ship's review planner now sends Swift code that asks for a privacy
permission, reads HealthKit or calendar data, or writes, deletes or
protects users' files on the device to the full review panel.

Why: since #4469, iOS changes that asked for microphone permission,
wrote and deleted meeting transcript files, or read calendars got the
light, one-reader review. Reported from the GHome iOS app's PR review.

Nothing to do: plain SwiftUI views, UserDefaults settings and file reads
still plan light.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
2026-11-18 03:55:13 +00:00
Garry Tanandcapy-ai[bot] 0a6bb42e74 Reused CI runs that passed only after a re-run are now marked instead of shown as clean passes (GST-3054) (#4473)
When /ship reuses a CI run that passed only after its failed jobs were
re-run, its CI line and its final summary line now add `rerun=
attempts=`.

Why: gbrain's CI now records which test files passed on a re-run
(gbrain#9690), and a pass on a re-run must read as flaky, never as
clean.

Nothing to do: runs without that record print as before; a malformed
record is refused with `CI_CARRY_RERUN_MALFORMED`.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/outside-voice#1 reader=outside-voice
Review-Finding: p1/outside-voice#2 reader=outside-voice
Review-Finding: p1/adversarial-native#2 reader=adversarial-native
Review-Finding: p1/red-team#1 reader=red-team
2026-11-18 03:47:25 +00:00
Garry Tanandcapy-ai[bot] 237371474b Let autoplan revise accept a plan without section headings, as next does (GST-3050) (#4470)
`gstack-autoplan revise` now accepts a revised plan whenever the first
`next` accepted its shape, so a run no longer pays for a full review
round and then refuses the owner's edit.

Why: a plan with no section headings is reviewed whole by `next`, but
once the owner added one heading, `revise` stopped with
`PLAN_SECTIONS_INVALID`.

Nothing to do: runs already in progress pick this up too.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 02:21:31 +00:00
Garry Tanandcapy-ai[bot] c9b6fe0ab3 Second-model plan reviews in autoplan stop being reported unavailable; --help stops printing a fake refusal (GST-3051) (#4471)
A second-model plan review in `/autoplan` is no longer reported as
unavailable when it actually ran, and `gstack-outside-voice --help` no
longer prints a line that reads like a real consent refusal.

Why: sessions believed the false label and paid to re-run the review, or
closed the plan phase without its second-model review.

Nothing to do: the command autoplan already runs now picks the right
check by itself.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-18 02:12:43 +00:00
Garry Tanandcapy-ai[bot] 29e950227b Review planner sorts Swift and Xcode files by risk instead of sending every iOS PR to the full panel (GST-3041) (#4469)
/ship's review planner now sorts Swift and Xcode files by risk, so a
plain iOS UI change gets the light review instead of the full
five-reader panel.

Why: `gstack-diff-scope` had no rule for `.swift`, so every all-Swift
diff printed `SCOPE_ERROR=unmatched` and the planner failed closed.
Reported from the GHome iOS app's PR review.

Nothing to do: unknown file types still fail closed exactly as before.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/outside-voice#1 reader=outside-voice
Review-Finding: p2/red-team#1 reader=red-team
2026-11-18 01:28:22 +00:00
Garry Tanandcapy-ai[bot] dd4266dc4b Check each app build with an agent from another model family before its owner is asked to try it (GST-3025) (#4465)
Adds `gstack-first-use`: before an app build reaches its owner as "ready
to try", an agent from another model family plays that exact build, does
the plan's first five day-one actions with a screenshot or video of
each, and checks every link. Only then does it print the "try this
build" message.

Why: a recent app build passed every review and its owner still found
the first screen broken, because nothing tried the build the way the
owner would.

Nothing to do now; the first real use is that app's next build.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p1/red-team#4 reader=red-team
2026-11-17 23:19:24 +00:00
Garry Tanandcapy-ai[bot] 0b656a171d Check a question against the owner's earlier answers before asking it again (GST-3025) (#4467)
An agent can now check a draft question against the owner's earlier
answers before sending it, so the owner isn't asked again about
something they already said yes to.

Why: owners repeat "don't ask me, just do it" across threads, because
each new session forgets earlier answers. In a four-day sample, about 1%
of 444 asks were repeats this could skip, so a two-week pilot decides
whether it's kept.

Nothing to do: the new command is opt-in, and no existing command,
install output or factory rule changes.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=testing
Review-Finding: p1/specialist-batched#2 reader=state-machines
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p3/outside-voice#1 reader=outside-voice
Review-Finding: p3/outside-voice#2 reader=outside-voice
2026-11-17 23:13:14 +00:00
Garry Tanandcapy-ai[bot] d3d35019a0 Tests and scratch repositories can no longer write approval rows into a real Capy Drive (GST-3027) (#4466)
Tests and scratch repositories in the temp directory can no longer write
approval rows into your real Capy Drive. When `gstack-approvals` runs
under `bun test`, or its state root or repository sits in the temp
directory, a Drive mirror that resolves outside the temp directory
(links followed) is refused with `APPROVAL_RECORD_WRITE_FAILED`; the
local row is kept.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team
2026-11-17 22:56:51 +00:00
Garry Tanandcapy-ai[bot] fc5c285035 /office-hours keeps its founder resources out of the skill file (GST-3024) (#4463)
/office-hours no longer carries its 34 founder videos and essays in the
skill file; the closing runs a new `gstack-founder-resources` command
that prints the ones a user hasn't been shown yet.

Why: the skill was 9 bytes from its size cap, and the approved
partner-session improvements need room. This frees about 8.6 KB.

Nothing to do as a reader.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=testing
2026-11-17 22:47:26 +00:00
44c904fe9b Pre-push test selection finds tests in monorepo apps that use their own @/ alias (#4464)
/ship's pre-push test selection now finds the tests of a monorepo app
that imports through its own `@/` alias (for example `apps/mobile`
mapping `@/*` to `./src/*`).

Why: only the root tsconfig was read, so every touched file in such an
app failed with `PREGATE_NO_LANE` even with a test beside it. Rebuilt
from #4462 by @dtoelke, who found and fixed it; thank you.

Nothing to do: a repo whose only tsconfig is at the root (gstack itself)
resolves exactly as before.

Co-authored-by: stackpt-agent <348614618+stackpt-agent@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=testing
Review-Finding: p2v/outside-voice#1 reader=outside-voice
2026-11-17 22:43:07 +00:00
Garry Tanandcapy-ai[bot] da98d0a0eb /ship reuses CI's passing run when a base merge changed no file, and stops before long local test runs or an unknown base (GST-3019) (#4461)
/ship's preflight and its CI-run lookup now reuse a passing CI test run
when a base merge left the files unchanged, stop instead of quietly
starting an hour-long test suite on the local machine, and refuse a
`--base` that names no commit instead of reporting an empty diff.

Why: gbrain #9662 lost a green CI run to a no-op base merge, then ran a
50-minute suite on a 4-CPU box, and its audit read a commit sha as a
branch and saw zero changed files.

Nothing to do: `--run-uncarried-here` restores running an uncovered
suite locally under `--tests-only`.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: s11/outside-voice#1 reader=outside-voice
Review-Finding: s11/outside-voice#2 reader=outside-voice
2026-11-17 20:56:07 +00:00
Garry Tanandcapy-ai[bot] 76535826f5 /ship stops asking owners to clear base-side merge text and reviewers' confirmation prose (GST-2975, GST-2972) (#4458)
/ship no longer stops for an owner's ruling when a base merge only
changes base-side text, such as the preamble hash in regenerated
SKILL.md files, and a reviewer's confirmation prose becomes a finding
the lead can lower with a reason.

Why: each of these cost a stopped /ship and an owner ruling on recent
PRs (#4383, ghome#16, #4431), which keeps unattended shipping from
finishing.

Nothing to do.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 20:08:56 +00:00
Garry Tanandcapy-ai[bot] e671a531f4 Unattended /autoplan runs its configured second-model review in the foreground, and run ids no longer collide (GST-3015) (#4459)
Unattended `/autoplan --full` now runs the second-model review when
`codex_reviews: enabled` is set, runs it in the foreground with a
9-minute limit, and records a timeout with the standard failure line
instead of ending the session. Two runs started in the same second also
get different run ids now.

Why: in a planning test, Opus 5.5 skipped the second reviewer in 2 of 3
runs over consent the config had already given, and ended the third
session while the review ran in the background.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 19:54:16 +00:00
Garry Tanandcapy-ai[bot] e1cfceae6a Secrets check stops flagging three code shapes and catches concatenated and commented secrets (GST-3004) (#4457)
The secrets check no longer stops a push on three kinds of ordinary code
that only look like secrets: TypeScript types with spaced generic
arguments, Python arguments that read a settings constant, and camelCase
dotted field paths.

It also catches two kinds of real secrets it used to miss, one built
with `+` from short pieces and one written in a comment, so pushes are
both quieter and safer.

Nothing to do; a secret in any of the loosened positions still fails the
check.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/adversarial-native#1 reader=adversarial-native
Review-Finding: p1/outside-voice#1 reader=outside-voice
Review-Finding: p1/outside-voice#2 reader=outside-voice
2026-11-17 18:47:18 +00:00
Garry Tanandcapy-ai[bot] b1c32824fd Keep skill_prefix after updates, retire the ClawHub install route, and stop misreading cross-repo issue refs (GST-2967) (#4454)
Three small fixes: `skill_prefix=true` now survives updates when gbrain
is installed, the OpenClaw docs stop sending people to stale ClawHub
skills, and `gstack-issue-links` no longer reads other repositories'
issue numbers as gstack issues.

Why: each one misleads users or /ship today (wrong skill names after
every update, April 2026 skill builds, wrong `Refs #N` lines in PR
bodies).

Nothing to do as a reader. Thanks @fliaron (#4413) and @exGeni (#4421)
for the detailed reports.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 17:13:42 +00:00
Garry Tanandcapy-ai[bot] 0ee5914628 Run each driven /ship phase as one command, count its calls, and stop it at 100 minutes (GST-2984) (#4451)
A driven /ship now runs each ship/DRIVER.md phase as one command, shows
how many calls the run made, and stops itself with a printed line at 100
minutes.

Why: measured /ship runs made 121 to 308 calls where the driver plans 9
to 12, and 10 of 12 ran past the 100-minute stop while those limits were
only prose.

Nothing to do: older ship records without `calls=` still validate and
print.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/outside-voice#1 reader=outside-voice
2026-11-17 16:44:06 +00:00
Garry Tanandcapy-ai[bot] 9c6e0a0f85 Token-capped /ship hands its child Claude Code session its prompt (#4448) (#4452)
A `/ship` with a token cap on Claude Code no longer stops at its first
handoff: the child `claude -p` session now gets its prompt.

Why: `--allowedTools` takes every argument after it, so the prompt was
read as one more tool name and the child exited at once. The launch now
puts `--` before the prompt.

Nothing to do. Thanks to @exGeni for the report and diagnosis.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 16:37:56 +00:00
Garry Tanandcapy-ai[bot] f000b6e0e3 Stop giving bug reports a special rule in gstack's router (GST-2873) (#4442)
gstack's router no longer gives bug reports a special check-the-cause,
fix-it-test-first rule, and its description no longer lists debugging,
so the model fixes a bug the way it would without gstack. This keeps
gstack to the parts that measurably help, and on 26 hard real bugs the
rule gave no clear gain.

Nothing to do.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team
2026-11-17 14:37:34 +00:00
Garry Tanandcapy-ai[bot] b79843c5d7 Keep a pull request's review count intact when a posted description brings its own run history (GST-2707) (#4440)
When `/ship` posts a pull request's description, the count of earlier
review rounds now always comes from the PR's real history. Before this
fix, a description that brought extra history blocks of its own could
make gstack count one round where there were three.

Why: the per-PR round cap (R51) depends on that count, and it's the last
gap before crews can stop counting rounds by hand.

Nothing to do as a reader.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/specialist-batched#1 reader=red-team
Review-Finding: p1/specialist-batched#2 reader=testing
2026-11-17 14:10:23 +00:00
Garry Tanandcapy-ai[bot] 169eb9c8a5 Approval page re-reviews two-reviewer scope changes and checks quotes only against this repository (#4441)
/autoplan's approval page now re-reviews a scope change both reviewers
raise, asks a plan with no Owner's words to confirm its direction, and
checks owner quotes only against this repository's approvals record.

This keeps the rule that only the owner's own words set a plan's
direction, and there is nothing for the reader to do.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/specialist-batched#1 reader=specialist-batched
Review-Finding: p1/specialist-batched#2 reader=specialist-batched
2026-11-17 13:22:10 +00:00
Garry Tanandcapy-ai[bot] c53b15c48d Open pull requests with three plain lines and land each one as a single commit (GST-2737) (#4438)
* WIP plain PR bodies and squash messages

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Fold PR bodies to three plain lines and land every PR as one plainly titled commit

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Expect the plain commit body in the train land tests

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Count the new policy keys in the floor tests and record the ship size change

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Let older, generated and Dependabot PRs pass the body check, and keep comments posting

The opening check now follows the same date and branch exemption as the rest of the body check, Dependabot branches are exempt, the exemption only counts for branches in this repository, a merge that cannot read the PR waits instead of refusing, and a broken policy file no longer stops comments.

Review-Finding: p1/specialist-batched#1 reader=testing
Review-Finding: p1/specialist-batched#2 reader=testing
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p1/red-team#4 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Stop re-posted PR bodies from duplicating sections, and let file names through the word check

Posting an already-folded body now replaces each section once instead of keeping the old copy beside it, and listed words inside file paths or file names, such as a test file in the Tests section, no longer count as prose.

Review-Finding: v2/outside-voice#3 reader=outside-voice
Review-Finding: v2/adversarial-native#2 reader=adversarial-native
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Describe the folded three-line PR body in the skills guide and the prose lint help

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 13:14:33 +00:00
Garry Tanandcapy-ai[bot] aeb74eb00b /ship's test step says when it hits its time limit, and long test file lists no longer overflow the remote command (GST-2958) (#4429)
* Say when /ship's test step hit its time limit, and keep long file lists off the remote test command line

gstack-ship-preflight stopped gstack-pregate after a fixed hour and printed
'PREGATE: unreadable (exit 143)'. The whole step's budget is now
--step-timeout <s> (default 3600), and a stop at it prints
'PREGATE: time limit hit' with the way out: push and let CI's full run
carry the tests, or a larger budget.

The test_backend command pregate prints for a small machine put every
selected file into one argument, which Linux refuses past 128 KiB. The
files now reach the VM in a setup script named by its content.

Also adds an arg-limit troubleshooting entry and says the Windows job has
eight shards.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Read the small-machine file list from the setup script in the hidden-folder path test

The remote command now names a setup script instead of the files, so the
test checks that the script lists the ./-prefixed path.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Keep a test path with a newline out of the remote file list

A selected test path containing a newline, or equal to the list's end marker, could end the setup script's file list early and run the rest as shell on the test VM. Such paths now keep the quoted inline command.

Review-Finding: p1/outside-voice#1 reader=outside-voice
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Mark the preflight half of the Step 5 time limit to-do as done

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 13:13:19 +00:00
Garry Tanandcapy-ai[bot] e8c8625bd6 Keep checking custom skill contracts that still list the removed test-after-edit item (GST-2811) (#4439)
* Keep checking a custom skill's contract when it still lists the removed test-after-edit item

The Stop hook used to treat such a contract as invalid and check none of
its items. It now skips only that item, warns with a line naming the file
and item, and checks the rest.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Move the changelog note to its own entry, since a landed entry is never edited

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix: pre-landing review fixes

Test that gstack-skill-contract check warns about a removed-kind item and checks the rest.

Review-Finding: p1/specialist-batched#1 reader=specialist-batched
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* chore: changelog and TODOS

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 12:51:54 +00:00
Garry Tanandcapy-ai[bot] ab114c5308 Say when to use each gstack skill in Claude Code's skill list (GST-2774) (#4387)
* Say when to use each gstack skill in Claude Code's skill list (GST-2774)

Claude Code's listing of each gstack skill now keeps a short when-to-use
clause after its first sentence, so Opus 5.5 loads /review on "review my
changes" and /plan-eng-review on "plan this feature" (GSTA-558).

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Keep /review and /plan-eng-review within their size pins and refresh budgets

CI on the first head found five size and fact checks the new catalog
clause moved: the per-host SKILL.md size pins, the context-budget
ceilings, the deslop-shared-libs catalog byte pin, the Claude ship golden
and the catalog ceiling CLAUDE.md states. /review's and /plan-eng-review's
full descriptions are now shorter than before, so their pins go down, and
/plan-eng-review's scope gate is unchanged from main.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Say which skills keep no when-to-use clause in the changelog entry

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Update the catalog budget and voice-trigger docs for the when-to-use clause

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Drop "deploy this" from /ship's Claude Code skill list line

Deploying belongs to /land-and-deploy, so /ship's when-to-use clause keeps
"ship it, create a pr, push to main" only. Budgets, the size ledger and the
Claude ship golden are re-measured.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix: pre-landing review fixes

Review-Finding: p1/specialist-batched#1 reader=specialist-batched
Review-Finding: p1/red-team#1 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Re-measure the setup-gbrain size cap after merging main

Main grew setup-gbrain's always-loaded part to 38,621 bytes, and this
branch's when-to-use clause adds 55 more, so the cap measured on the old
base (38,637) is stale. The cap is now the merged measurement, 38,676.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 12:23:35 +00:00
Garry Tanandcapy-ai[bot] 127bcd6d55 Accept a requested docs fix when the audit names the file with a line number (#4437)
finish --docs-requested refused a correct fix when the docs audit named the
file as path:line ("changelog.d/engine-parity-decisions.md:8: wording") or
path:line:column, because the match only allowed whitespace, quotes or
punctuation right after the path. It now also allows :<line> and
:<line>:<column> before those, while a different file sharing the path's
prefix still doesn't match. Reported by Vorflux via FOUN-32.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 12:22:11 +00:00
c5250dedc1 Keep reviewer product challenges open on the approval page (#4431)
* Keep reviewer product challenges open on the approval page

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Read the approvals record without writing the slug cache when building the gate

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Keep every reviewer challenge on the approval page, and ask again when the cut list changes

A challenge with no change kind and no real owner quote now becomes a proposal instead of vanishing. An ordinary finding that only mentions an earlier challenge no longer closes it. The cut list and confirm-direction items carry their content in their origin, so an earlier answer is not reused for a changed list.

Review-Finding: p1/specialist-batched#1 reader=specialist-batched
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p1/red-team#3 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Keep removed owner quotes redacted, and keep High proposals as blocking tasks when declined

Public exports now redact the Owner's words from every plan text the run kept, so a quote a revision removed stays hidden in earlier reviewer results. A paired proposal takes the heaviest change either reviewer named, so an ordering-plus-scope pair is re-reviewed instead of settled. A proposal behind a Critical or High finding offers b as keep the draft and carry it into the build as a blocking task, and only a settles it.

Review-Finding: p1v/outside-voice#1 reader=outside-voice
Review-Finding: p1v/outside-voice#2 reader=outside-voice
Review-Finding: p1v/adversarial-native#2 reader=adversarial-native
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Document owner's words, reviewer proposals and day-one items on the approval page

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* chore: changelog and TODOS

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-11-17 12:02:11 +00:00