Commit Graph
5 Commits
Author SHA1 Message Date
Garry Tanandcapy-ai[bot] eb54692427 Never let a later docs-audit line override an earlier blocked result (GST-2349) (#4434)
* Never let a later docs-audit line override an earlier blocked line (GST-2349)

A blocked documentation-audit result line followed by an unfenced "current"
JSON line for the same audit as the very last line was accepted as current,
and a last "current" line whose only fault was its format was repaired back to
current. The blocked verdict now carries: a last line that drops an earlier
blocked status or blocker for the audit is never accepted and gets the
one-way re-ask, whose reply must stay blocked and keep those blockers.

Step 2 of the docs audit section no longer says it parses only the last
line, and the changelog entry now claims only what the parser checks.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Leave the landed changelog entry alone and correct its claim in a new entry (GST-2349)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Split a run-on sentence in the changelog entry for the docs-audit fix

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 11:12:52 +00:00
Garry Tanandcapy-ai[bot] 2af3822f94 Stop /ship's docs audit halting when the child writes prose after its result (GST-2349) (#4285)
* Stop /ship's docs audit halting when the child writes prose after its result (GST-2349)

The Step 14.5 documentation audit read only the child's last nonempty line.
Children that ended with their JSON result and then restated the documentation
section in prose had a valid "current, no edits" audit rejected with no format
repair, which spent an attempt each time and, after two, stopped /ship for an
owner risk grant (founderstar #837, harness-evals #393).

gstack-docs-candidate result now reads the last line that opens a JSON object,
ignores prose after it and says so with TRAILING_PROSE:. A result missing only
documentation_section keeps the existing free re-ask, whose prompt now tells the
child to put the section inside the JSON and write nothing after the line; the
re-audit retry note says the same. Content failures still count.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Send any docs-audit result with text after it back for one free re-ask (GST-2349)

A cross-family audit of the previous commit showed that ignoring prose after
the result line let a contradicting verdict through: a blocked result followed
by a fenced "current" example was accepted as current, and a "Correction: the
audit is BLOCKED" after a current line became a repair that had to stay current.

Text after a JSON line carrying the audit id is no longer ignored and never
searched for another result. It is a format slip: FORMAT_REPAIR re-asks once
for the whole result line without spending an attempt, the re-ask counts
everything the audit wrote after its JSON line, and the reply is judged on its
own with nothing kept from the first line. A reply that itself has text after
its line counts as an attempt.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Keep a blocked docs audit blocked through the free re-ask (GST-2349)

Review of the previous change found that the free whole-line re-ask could
turn a blocked audit into a passing one: a blocked result line, then a fenced
"current" example, then a "current" reply was accepted as current.

The re-ask now works one way. It is offered only when every JSON line that
carries the audit id is free of content problems; a content problem such as a
missing status or "current" with edits still spends an attempt. If any of those
lines said blocked or listed a blocker, the reply must stay blocked and keep
every blocker (it may add more), and the re-ask prompt says so.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-17 09:36:21 +00:00
Garry Tanandcapy-ai[bot] 4414f4cc93 Stop /ship's docs audit from refusing Next.js bracketed route paths (GST-2554) (#4321)
* Stop /ship's docs audit from refusing Next.js bracketed route paths (GST-2554)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* List the bracketed route path rule in the docs audit troubleshooting entry (GST-2554)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-12 15:44:36 +00:00
Garry Tanandcapy-ai[bot] c25580eb52 Let the docs audit repair a badly shaped final line without using an attempt (#4205)
* Let the docs audit repair a badly shaped final line without using an attempt

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Keep the audit id and outcome out of docs audit format repairs

A missing audit id or a missing or unknown status is now a content failure, a --repair-of that names a non-repairable output no longer uses up the audit's one repair, and the re-ask goes to a fresh agent with no tools instead of the writer child.

Review-Finding: p1/specialist-batched#1 reader=testing
Review-Finding: p1/specialist-batched#2 reader=testing
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Treat repeated identity keys and malformed outcome lists as failed docs audits

A repeated audit_id or status key, and a files_updated or blockers list that is present but malformed, are now content failures, so a format repair can no longer erase a reported blocker or choose the outcome. A missing list stays repairable.

Review-Finding: v1/outside-voice#1 reader=outside-voice
Review-Finding: v1/outside-voice#2 reader=outside-voice
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-09 10:32:29 +00:00
Garry Tanandcapy-ai[bot] aa46032f2b Stop /ship from stalling when the docs checker misspells a field in its reply (GST-1843) (#4147)
* Stop /ship from stalling when the docs checker misspells a field in its reply (GST-1843)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Make the docs reply check refuse hidden extra fields and keep old audit ids out of the retry

Review-Finding: p1/specialist-batched#1 reader=security
Review-Finding: p1/specialist-batched#2 reader=testing
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p1/red-team#3 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Let the docs eval fixture run the new reply check, and keep odd audit ids and keys from escaping it

Review-Finding: v1/outside-voice#2 reader=outside-voice
Review-Finding: v1/adversarial-native#1 reader=adversarial-native
Review-Finding: fc1/fix-check#1 reader=fix-check
Review-Finding: v1/outside-voice#1 reader=outside-voice
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Add the changelog entry for the docs reply check

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* List every way a docs checker reply can be refused in the troubleshooting entry

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-07 22:27:38 +00:00