// setup-gbrain bin invocation path lint. // // Pins the correct bun-run + .ts invocation form for gstack-memory-ingest // and gstack-gbrain-sync wherever setup-gbrain's docs instruct the agent // to run them. Regression coverage for #2393 / #2250: both scripts are // .ts files with no package.json bin alias stripping the extension, so a // bare name (no `bun run` prefix, no `.ts` suffix) fails with "No such // file or directory" the moment an agent follows the doc literally. // // Why a structural test instead of a full Agent SDK E2E: // - The failure is entirely in the prose an agent reads, not in // runtime behavior a service test could exercise. A grep-based // regression on the template/reference-doc text is fast (<200ms), // free, and catches the same drift a full E2E would, without the // token cost. Same rationale as test/setup-gbrain-path4-structure.test.ts. // - The correct invocation form and the stale one differ only by // `bun run ` + `.ts`, right next to each other in the same files — // exactly the kind of drift a cheap structural check exists to catch. import { describe, test, expect } from 'bun:test'; import * as fs from 'fs'; import * as path from 'path'; const ROOT = path.resolve(import.meta.dir, '..'); const TMPL = path.join(ROOT, 'setup-gbrain', 'SKILL.md.tmpl'); const SECTIONS_DIR = path.join(ROOT, 'setup-gbrain', 'sections'); const MEMORY_DOC = path.join(ROOT, 'setup-gbrain', 'memory.md'); // Carve-aware (token-reduction Phase 4): setup-gbrain is carved. The Step 7.5 // ingest-gate body (which owns the R1-R4 invocations) lives in // sections/transcript-gate.md.tmpl; the skeleton keeps dispatch + the Step 10 // verdict prose. Negative (no-bare-invocation) checks run over the UNION so a // stale form can't hide in any template file. const tmpl = fs.readFileSync(TMPL, 'utf-8'); const transcriptGate = fs.readFileSync( path.join(SECTIONS_DIR, 'transcript-gate.md.tmpl'), 'utf-8', ); const tmplUnion = [tmpl] .concat( fs .readdirSync(SECTIONS_DIR) .filter((f) => f.endsWith('.md.tmpl')) .sort() .map((f) => fs.readFileSync(path.join(SECTIONS_DIR, f), 'utf-8')), ) .join('\n'); const memoryDoc = fs.readFileSync(MEMORY_DOC, 'utf-8'); // A "bare invocation" is the tool name immediately followed by a flag/arg // with no `.ts` in between — the exact stale shape #2393/#2250 reported. // The negative lookahead means `gstack-memory-ingest.ts --probe` (correct) // does NOT match, while `gstack-memory-ingest --probe` (stale) does. // `(?:\s|\\\r?\n)+` also spans a backslash line-continuation between the // name and its flag (e.g. `gstack-memory-ingest \` newline ` --probe`), // a style this same template already uses for other commands (see the // read_secret_to_env invocation a few hundred lines up) — a plain `\s+` // would miss a stale invocation reintroduced in that form. const bareMemoryIngest = /\bgstack-memory-ingest\b(?!\.ts)(?:\s|\\\r?\n)+--/; const bareGbrainSync = /\bgstack-gbrain-sync\b(?!\.ts)(?:\s|\\\r?\n)+--/; describe('setup-gbrain templates (skeleton + sections) — bin invocation paths', () => { test('no bare gstack-memory-ingest invocation remains anywhere in the union', () => { expect(tmplUnion).not.toMatch(bareMemoryIngest); }); test('no bare gstack-gbrain-sync invocation remains anywhere in the union', () => { expect(tmplUnion).not.toMatch(bareGbrainSync); }); test('the probe step uses bun run + .ts (R1, transcript-gate section)', () => { expect(transcriptGate).toContain( 'bun run ~/.claude/skills/gstack/bin/gstack-memory-ingest.ts --probe' ); }); test('the gate never bulk-ingests before the user answers (transcript-gate section)', () => { expect(transcriptGate).not.toMatch(/gstack-memory-ingest\.ts --bulk/); }); test('the post-answer full-sync step uses bun run + .ts (R3, transcript-gate section)', () => { expect(transcriptGate).toContain( 'bun run ~/.claude/skills/gstack/bin/gstack-gbrain-sync.ts --full --no-brain-sync' ); }); test('no skill-start hook is claimed to ingest transcripts; /sync-gbrain is named (transcript-gate section)', () => { expect(transcriptGate).not.toMatch(/every skill\s+start/i); expect(transcriptGate).toContain('/sync-gbrain'); }); test('the post-answer gstack-config line stores a mode value, not the answer letter (bash script, no extension)', () => { expect(transcriptGate).toContain('~/.claude/skills/gstack/bin/gstack-config set transcript_ingest_mode'); expect(transcriptGate).not.toContain('transcript_ingest_mode '); }); }); describe('transcript consent question is gated on `gstack-config has`', () => { const syncTmpl = fs.readFileSync(path.join(ROOT, 'sync-gbrain', 'SKILL.md.tmpl'), 'utf-8'); for (const [name, text] of [['setup-gbrain transcript gate', transcriptGate], ['sync-gbrain', syncTmpl]] as const) { test(`${name} checks presence with has before asking, and never asks spawned or headless sessions`, () => { const hasAt = text.indexOf('gstack-config has transcript_ingest_mode'); expect(hasAt).toBeGreaterThanOrEqual(0); expect(text.indexOf('AskUserQuestion', hasAt)).toBeGreaterThan(hasAt); for (const v of ['recent', 'all', 'off']) expect(text).toContain(`\`${v}\``); expect(text).toMatch(/spawned[\s\S]{0,40}headless[\s\S]{0,80}do not ask/i); }); } }); describe('setup-gbrain/memory.md — bin invocation paths', () => { test('no bare gstack-memory-ingest invocation remains', () => { expect(memoryDoc).not.toMatch(bareMemoryIngest); }); test('no bare gstack-gbrain-sync invocation remains', () => { expect(memoryDoc).not.toMatch(bareGbrainSync); }); test('the secret-scanning example uses bun run + .ts (R5)', () => { expect(memoryDoc).toContain('bun run bin/gstack-memory-ingest.ts --bulk --scan-secrets'); expect(memoryDoc).toContain( 'GSTACK_MEMORY_INGEST_SCAN_SECRETS=1 bun run bin/gstack-memory-ingest.ts --bulk' ); }); test('the troubleshooting full-pass mention uses bun run + .ts (R5)', () => { expect(memoryDoc).toContain('Run `bun run bin/gstack-gbrain-sync.ts --full` to do a full pass.'); }); test('the troubleshooting incremental-reingest mention uses bun run + .ts (R5)', () => { expect(memoryDoc).toContain( 're-run `bun run bin/gstack-gbrain-sync.ts --incremental` to re-ingest from' ); }); test('the already-correct reference line at the top of the file is unchanged', () => { expect(memoryDoc).toContain('bun run bin/gstack-memory-ingest.ts --probe` (which'); }); }); describe('bare-invocation regex — backslash line-continuation coverage', () => { // This template writes multi-line commands with a trailing backslash // continuation elsewhere (e.g. the read_secret_to_env invocation), so a // stale invocation reintroduced in that same style must still be caught. test('catches a bare invocation split across a backslash continuation', () => { const staleContinuation = 'gstack-memory-ingest \\\n --probe'; expect(staleContinuation).toMatch(bareMemoryIngest); }); test('does not flag a correct invocation split across a backslash continuation', () => { const fixedContinuation = 'bun run bin/gstack-gbrain-sync.ts \\\n --incremental'; expect(fixedContinuation).not.toMatch(bareGbrainSync); }); });