/** * plan-design-review plan-mode smoke (gate, paid, real-PTY). * * See test/skill-e2e-plan-ceo-plan-mode.test.ts for the shared assertion * contract. Exercises the same contract against /plan-design-review. * * Note: on no-UI-scope branches plan-design-review legitimately short- * circuits to plan_ready without firing AskUserQuestion. Both 'asked' and * 'plan_ready' are valid pass outcomes. */ import { describe, test, expect } from 'bun:test'; import { runPlanSkillObservation, assertReportAtBottomIfPlanWritten, isProseAUQVisible, } from './helpers/claude-pty-runner'; const shouldRun = !!process.env.EVALS && process.env.EVALS_TIER === 'gate'; const describeE2E = shouldRun ? describe : describe.skip; describeE2E('plan-design-review plan-mode smoke (gate)', () => { test('reaches a terminal outcome (asked or plan_ready) without silent writes', async () => { const obs = await runPlanSkillObservation({ skillName: 'plan-design-review', inPlanMode: true, timeoutMs: 300_000, }); if (obs.outcome === 'silent_write' || obs.outcome === 'exited' || obs.outcome === 'timeout') { throw new Error( `plan-design-review plan-mode smoke FAILED: outcome=${obs.outcome}\n` + `summary: ${obs.summary}\n` + `elapsed: ${obs.elapsedMs}ms\n` + `--- evidence (last 2KB visible) ---\n${obs.evidence}`, ); } expect(['asked', 'plan_ready']).toContain(obs.outcome); assertReportAtBottomIfPlanWritten(obs); }, 360_000); // v1.21+ regression: see skill-e2e-plan-ceo-plan-mode.test.ts for the // contract. plan-design-review legitimately short-circuits on no-UI-scope // branches, so this case has historically used a looser envelope. // // Post-v1.28 (forever-war fix), 'exited' is acceptable when BLOCKED is // visible in the TTY (model correctly recognized the AUQ-unavailable // failure mode and stopped). The legacy 'plan_ready' (with or without // decisions section) and 'asked' paths remain valid pass outcomes. // // The discriminating regression signals are 'auto_decided' (AUTO_DECIDE // preamble fired upstream), 'silent_write', 'timeout', or 'exited' // without BLOCKED visible — all mean the user never saw a question they // should have. test('does not silently auto-decide when --disallowedTools AskUserQuestion is set', async () => { const obs = await runPlanSkillObservation({ skillName: 'plan-design-review', inPlanMode: true, extraArgs: ['--disallowedTools', 'AskUserQuestion'], timeoutMs: 300_000, }); // Surface visibility check (same as ceo / autoplan migrations): user // must SEE the question via BLOCKED string OR prose-rendered AUQ options. const blockedVisible = /BLOCKED\s*[—-]\s*AskUserQuestion/i.test(obs.evidence); const proseAUQVisible = isProseAUQVisible(obs.evidence); const surfaceVisible = blockedVisible || proseAUQVisible; if ( obs.outcome === 'auto_decided' || obs.outcome === 'silent_write' || obs.outcome === 'timeout' ) { throw new Error( `plan-design-review AskUserQuestion-blocked regression: outcome=${obs.outcome}\n` + `summary: ${obs.summary}\n` + `elapsed: ${obs.elapsedMs}ms\n` + `--- evidence (last 2KB visible) ---\n${obs.evidence}`, ); } if (obs.outcome === 'exited' && !surfaceVisible) { throw new Error( `plan-design-review AskUserQuestion-blocked regression: outcome=exited without any visible question surface (no BLOCKED string, no prose-rendered AUQ options). Model quit silently.\n` + `--- evidence (last 2KB visible) ---\n${obs.evidence}`, ); } expect(['asked', 'plan_ready', 'exited']).toContain(obs.outcome); // NOTE: assertReportAtBottomIfPlanWritten intentionally not called — // see skill-e2e-plan-ceo-plan-mode test 2 for the full rationale. Under // --disallowedTools the model can't run a full review, so the // report-at-bottom contract doesn't apply. }, 360_000); });