Files
gstack/test/test-free-shards.test.ts
Garry TanandClaude Fable 5 e76f65a8da v1.77.0.0 feat: test-infrastructure overhaul wave 1 — matrix deletion, flake telemetry, sync-spawn wedge class extinct (#2746)
* fix: pin the claude CLI to an exact version in the CI image + tripwire

The image installed @anthropic-ai/claude-code UNPINNED and rebuilt weekly
'to pick up CLI updates' — while bun sat carefully pinned at 1.3.13 two RUN
lines above. The PTY harness screen-scrapes this CLI's TUI, and that drift
broke it three separate times (welcome-screen wedge on 2.1.233, skillify
HOME discovery on 2.1.237, guard/freeze hooks on 2.1.162), each debugged as
a flake first. Pin 2.1.251 (current latest), bump deliberately via a PR
that runs the PTY gate, and enforce with test/ci-image-cli-pin.test.ts:
any global npm install in Dockerfile.ci without an exact @X.Y.Z pin fails
the free suite. The weekly ci-image cron stays as a cheap tag self-heal.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: stamp the claude CLI version into every eval-store run record

Three harness breakages were traced to claude-CLI TUI drift only after long
flake hunts, because no run record said which CLI it actually exercised.
EvalCollector now stamps claude_cli_version (claude --version, cached once
per process, 'unknown' when the binary is absent) into both partial and
finalized records — schema-additive optional field, no SCHEMA_VERSION bump.
Correlating a flake wave with a CLI release becomes a grep over
~/.gstack/projects/<slug>/evals/ instead of archaeology.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: give the spinning-shard kill test load headroom (30s -> 90s)

The test spawns and group-kills three real children (one a busy-loop
burning a full core) while five sibling shard processes compete for eight
vCPUs. Under full-suite load it blew bun's default 30s per-test ceiling at
30,009ms — while passing in isolation in 1.4s — and red the only required
lane. Every assertion in it is event-based (statuses, group-kill proof,
heartbeat lines); the sole latency claim is the <30s kill-deadline sanity
bound, which stays. Explicit 90s headroom, not a weakened oracle.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: green-by-skip census — skip counts in the classifier, all-skipped labeling in the paid runner

bun's 'Ran N tests' line COUNTS skipped tests, so a codex/gemini shard
whose every test self-skipped (binary absent on the runner — true of every
CI runner today) exits 0, dodges the hollow-shard guard, and reads as
coverage in the weekly census. The classifier now parses bun's ' N skip' /
' N pass' recap lines; ShardOutcome carries skippedTests; formatSummary and
the fail-closed slices report label an all-skipped pass explicitly:
'all N tests SKIPPED — verified nothing'. Status stays 'passed' (external
service availability is host state, not a repo regression) but the census
can no longer mistake absence for coverage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: extract composite actions for eval-lane setup; surviving lanes gain the fail-fast registry verification

'Fix bun temp' x3, 'Restore deps' x5, 'Seed claude interactive config' x3,
and 'Register gstack skills' x3 were byte-near-identical copies across the
legacy matrix, the sliced lane, and the periodic lane — and only the MATRIX
copy of register-skills carried the 19-line dangling-symlink + frontmatter
fail-fast loop written after a silent 'Unknown command' + 35-min-timeout
incident. Extract all four into .github/actions/ composites; the register
composite carries the verification loop (generalized over the skill list),
so the sliced and periodic lanes — the lanes that SURVIVE the matrix
deletion — now inherit the check they had silently dropped. Matrix-job
inline copies are left untouched: that job is deleted next.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: delete the legacy 17-row eval matrix — the sliced lane is the only paid lane

Every PR paid twice: the hand-enumerated matrix (18 test files, 22.6 min,
~$21 API measured on run 33263204465) ran serialized AHEAD of the strictly
superior sliced lane via 'needs: evals' — 35.5 min wall and ~2x paid spend
for the same diff. 14 of 17 rows carried no tier:, so periodic Opus
benchmarks leaked into every PR (the e2e-plan row alone: 12/12 tests,
21.7 min, $7.28 — the wall-clock bound of ALL of CI).

Parity receipt (static, pre-deletion): the sliced lane's gate census (49
files, derived from the runner itself) strictly contains all 18 matrix test
files, plus 31 files the matrix never ran. Pure deletion — one revert
restores it. The PR comment moved into slices-report (same '## E2E Evals'
upsert marker, now sourced from slice artifacts + carrying the fail-closed
reconciliation verdict). plan-slices loses the needs edge; the dead
workflow-level EVALS_TIER env goes with it.

test/evals-workflow-matrix.test.ts (and its KNOWN_MATRIX_GAPS /
KNOWN_TIER_UNSET burn-down ratchets — retired: the sliced census makes
'every gate file runs' true by construction) is rewritten as
test/evals-workflow-wiring.test.ts: matrix stays deleted, planner/executor/
report tier + slice-count agreement, both surviving lanes on the shared
register-skills composite with its fail-fast verification loop, PR comment
survival. Expected: PR eval wall 35.5 -> ~13 min, per-PR paid spend ~halved.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: provider-runner timeouts kill the whole process GROUP; codex/gemini inherit the orphan-drain hardening

All three provider runners (claude/codex/gemini) killed only the direct
child on timeout: tool subprocesses the CLI spawned survived as orphans
holding our pipes open and burning shared API rate (observed: a 600s
timeout stretching past 1400s; a stalled run once burned a core for 15
hours). gstack-detach's watchdog had the same shape one level up — killpg
SIGTERM, 5s grace, then a direct-child proc.kill() that orphaned
grandchildren.

Fix: spawn provider children via node:child_process with detached (own
process group) and killProcessGroup(SIGKILL) in the timeout handler —
runShardChild's proven pattern, EPERM/ESRCH fallbacks included. The codex
and gemini copies also gain the reader.cancel() + stderr Promise.race
hardening only the claude copy had (they still carried the blocked-drain
hang it fixed). gstack-detach's watchdog now group-SIGKILLs after the
grace.

Regression net: test/session-runner-groupkill.test.ts drives the REAL
runSkillTest against a fake claude shim (PATH override) that spawns a
grandchild and wedges — the run must classify timeout within budget and
leave neither shim nor grandchild alive — plus source pins on all three
runners (detached + killProcessGroup, no bare timeout kill, no Bun.spawn
reversion).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: skill-e2e-opus-47 renders SKILL.md fixtures into a mkdtemp — never the live tree

mkEvalRoot ran gen-skill-docs with cwd=ROOT, regenerating every in-repo
SKILL.md mid-run while concurrent paid shards copyFileSync those same files
in their beforeAll (EVALS_JOBS>=4 locally, 2 per CI slice) — a sibling
could capture a half-regenerated or opus-rendered SKILL.md, and a timeout
before afterAll stranded the whole tree at the wrong model for every later
shard. A cross-shard race that could flake ANY concurrent paid test.

Render via the --out-dir flag gen-skill-docs grew for exactly this reason
(mirrors the repo layout, which is all the fixture reads), read the skill
heads from the render dir, delete it, and drop the afterAll restore-regen
entirely.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: claude CLI version resolves in the runner parent, never on a test thread

Eng-review finding: getClaudeCliVersion's fallback is a SYNCHRONOUS
spawnSync on the same thread that polls concurrent PTY/session tests — the
judgePtyState blocking class this overhaul kills elsewhere. The paid runner
parent now resolves it once (cached) and stamps GSTACK_CLAUDE_CLI_VERSION
into every shard's env; eval-store short-circuits on the env var, and the
fallback spawn's budget tightens 10s -> 3s (bounded one-time stall, records
'unknown' on a slow CLI).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test: wire skippedTests end-to-end through runPaidShard

The census unit tests hand-built outcomes and the classifier tests parsed
strings; nothing proved a real child's ' N skip' recap flows into
outcome.skippedTests and the formatSummary label. A commandFor fake now
prints the recap shape and the test asserts the parsed counts, the
all-skipped predicate, and the 'verified nothing' label.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: make the setup composites rerun-safe (codex diff-review hardenings)

restore-deps: 'cp -r SRC node_modules' with an existing node_modules NESTS
the copy and leaves stale deps active — rm first. register-gstack-skills:
'ln -snf' hard-errors under set -eu when a REAL directory occupies the
gstack slot — clear a non-symlink leftover first. CI workspaces are fresh
today; a reusable composite must survive dirty reruns.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: sweep — every sync spawn in the test trees carries a timeout (436 sites, 157 files)

spawnSync/execSync/Bun.spawnSync BLOCK the main thread, so bun's in-process
per-test timeout can never fire while one waits — a hung child (stdin read,
network probe, dead daemon) wedges the whole shard until the runner's
external wall-clock SIGKILL. This exact class reached main: free-tests run
33262077256, test/gstack-memory-ingest.test.ts (normally 2.3s) held shard 2
at the 360s wall while its five siblings finished in ~65s.

Mechanical sweep in two waves (12 + 4 fan-out agents, every edit verified
against its call site): default timeout: 30_000 (matches the free runner's
per-test budget), 120_000 for genuinely slow ops (installs, builds,
playwright, provider CLIs), helper wrappers fixed ONCE where call sites
route through them. Sites that only LOOK like calls (string fixtures, grep
needles, comments) were skipped with reasons — the enforcement commit that
follows marks them exempt.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test: sync-spawn timeout tripwire — the wedge class stays extinct

Free scanner over all test trees (test/, browse/test/, design/test/,
make-pdf/test/, ios-qa, browser-skills): every spawnSync/execSync/
Bun.spawnSync call site must carry a timeout within a 30-line options
window, or an explicit '// tripwire-exempt: <reason>' marker. Comment
lines are skipped; exemptions are counted and ratcheted shrink-only
(ceiling 6 = the 6 string-fixture/grep-needle sites where the pattern is
CONTENT, not a call — marked in this commit). A scan-sanity test pins that
the scanner still sees >100 real call sites so it can never rot to a
vacuous green. Companion to the 436-site sweep in the previous commit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: paid-lane flake telemetry — record-level attempts, flaky_retries, report surfacing

bun --retry leaves a retried pass INVISIBLE in its output: a fail-then-pass
prints the error detail but no (fail) result line and recaps as a clean
pass (probed live on 1.3.10). So attempts are recorded where they cannot
lie: EvalCollector.addTest stamps a 1-based attempt on same-name re-records
(a retried test runs its body again and re-records), finalized runs carry
flaky_retries, printSummary warns loudly, and the fail-closed slices report
lists every passed-only-on-retry test — recorded and ranked, never blocking
and never silent. Cross-model confirmed (codex reached the same don't-parse
-the-stream conclusion independently).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: free-lane flake ledger — retry ON in CI, flaky-passes recorded and uploaded

The runner's attribution-gated flaky-retry pass (cap 5, truncation veto)
was OFF in the required lane and its FLAKY-PASS evidence was console-only —
so a single timing flake red the merge gate while repeat offenders stayed
unenumerable. free-tests.yml now sets GSTACK_FREE_RETRY_FLAKY=1 and points
GSTACK_FLAKE_LEDGER at runner.temp; every flaky-pass appends a JSONL entry
(SINGLE writer: the parent runner — no concurrent-append hazard by
construction; fail-open with a loud warning so a broken ledger can never
red the lane) and the artifact uploads UNCONDITIONALLY — a flaky-pass run
is green, which is exactly when the evidence matters. Wiring pinned by
free-tests-workflow-wiring; ledger behavior unit-tested incl. the fail-open
path. Matches 2026 industry practice (retry for data, quarantine out of
merge-blocking but never out of logging) with the repo's own receipts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: eval:flake-rank — the flake-telemetry dial

Aggregates per-test series across every finalized eval-store run (shard
dirs included) plus the free flake ledger: runs, fails, RETRIED PASSES
(the flake signature), avg duration — ranked retries-first. This is the
readable dial behind two policies: a flaky pass never blocks a merge but
is always ranked here, and the WS16 required-check promotion needs weeks
of clean flake-rank, not vibes. --json for machines, --dir for downloaded
CI artifacts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: two-phase session timeout — silent APIs die at the startup grace, named

The single spawn-armed timer charged API queue latency to the work budget:
the recurring '0 turns / $0.00 / x3 attempts' failure with four budget-bump
receipts (180->300s, 240->360s, 300->420s, 90->300s). Split: startup phase
(no NDJSON byte yet) kills EARLY at min(grace, timeout) with the distinct
exitReason 'timeout_startup' — an availability verdict, not transcript
archaeology — and the work phase arms on the first byte for the REMAINING
budget, so total wall never exceeds the timeout (tier envelopes are
margin-free: tests pass timeout: CAPTURE_MS and bun-budget the same tier).
Local grace 90s (observed queue latency 60-90s), CI floor 300s (TODOS-filed;
shared runners queue harder), both pinned by the new grace tests with fake
-claude shims covering the late-first-byte and silent-API paths.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: census integrity — 17 phantom selection keys deleted, reverse invariant added, gitignored dep patterns replaced, local map forks derived

The merge-blocking gate census counted tests that could not run. Deleted
(critic-verified against both quoted-occurrence and dep-registration
liveness): 7 *-prosons-format keys with no declaring test, ship-plan-
completion/-verification, review-plan-completion, design-shotgun-path/
session/full, autoplan-core (dead ~10 months), e2e-harness-audit (its
namesake is a FREE-suite file), plus 2 dead LLM-judge keys and 2 free-file
keys (budget-regression-pty, global-discover) misplaced in the PAID maps.
Census: 191 -> 174 keys, gate 86 -> 78 honest.

The new reverse invariant in touchfiles.test.ts makes the class structurally
impossible: every key must be quoted in a living paid test file OR
registered to an existing paid test file via its dep list (the constructed-
name binding the 2026-08 self-registration sweep established) — zero
exceptions needed today, with a live-file check on any future exception.

Also: '.agents/skills/**' dep patterns replaced with the generator
(scripts/gen-skill-docs.ts) — .agents/ is gitignored, so those patterns
could NEVER match a git diff and review-template edits silently stopped
selecting codex/gemini tests; the codex/gemini local touchfile maps are now
DERIVED from the canonical map (loud throw if a key vanishes) instead of
hand-forked copies that had already drifted. ios-qa-e2e demoted gate ->
periodic: its gate declaration was never executable in CI (hardware
exclusion only applies at tier=periodic), so every Linux PR planned a
hollow shard.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: routing journeys lose their answer key and end at the routing decision

The journey tests exist to catch skill-DESCRIPTION regressions (touchfiles:
*/SKILL.md.tmpl), but the fixture CLAUDE.md shipped an explicit
prompt->skill lookup table — with the answer key in context, a badly
regressed frontmatter description still routed correctly, so the tests
could not fail on the exact class they select for. The fixture now carries
only the generic invoke-skills nudge; the frontmatter carries the routing
load. Also capped all 10 journeys at maxTurns 2 / tools [Skill, Read]:
only the FIRST Skill call is asserted, so 5 turns of Read/Bash/Glob/Grep
was pure spend — roughly halves each journey's cost.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: retire decided A/B experiments; vendor the pre-cut fixture; ban raw-SHA fixtures

Three one-shot decision experiments kept re-running weekly as N=1
stochastic comparisons — flaky by construction with near-zero remaining
information: skill-e2e-auq-repetition-cut-ab (its own header: gate "passed
pre-landing, approved 2026-08-25"), skill-e2e-preamble-script-ab ("demoted
post-Phase-3"), and opus-47's fanout arm-vs-arm (parA >= parB across two
SINGLE stochastic runs — a coin flip). Deleted, with their selection keys;
the SDK overlay-harness stays as the maintained instrument for the next
experiment, and opus-47 keeps its routing-precision cases.

verboseSkill() now reads the VENDORED test/fixtures/auq-pre-cut-...-SKILL.md
instead of `git show ab66193e^:...` — a branch-local ref that dies on
branch prune and already failed on shallow clones. New free tripwire
(test/git-ref-fixture-tripwire.test.ts) bans the raw-SHA fixture class
outright: quoted SHA:path rev-specs and gitRef-style hex defaults in the
test trees fail the suite with the vendor-instead instruction.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: demote plan-ceo-review-expansion-energy to periodic

Opus generator + a subjective 2-axis >=4/5 LLM-judge threshold sat in the
MERGE-BLOCKING gate — the exact class its sibling posture tests were
demoted for, with a receipt (a +21-line preamble change once flipped the
score). CLAUDE.md's own tiering rule: Opus model test -> periodic. The
weekly lane keeps the regression signal; merges stop paying a judge-
temperament tax.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: paid shards get per-shard TMPDIR + CHROMIUM_PROFILE isolation and a kill-path cleanup backstop

The free runner treats this isolation as MANDATORY (two concurrent shards
on one Chromium profile kill each other's browser; shared tmp
cross-contaminates) — the paid lane had none of it. Doubly load-bearing
here: a shard that hits its 30-min wall is group-SIGKILLed, so per-test
afterAll cleanup never runs; the rmSync backstop is the only thing keeping
wedged runs from accumulating full git-repo workspaces in the shared
tmpdir forever. This is the DAG prerequisite for raising EVALS_JOBS (next
commit) — more concurrency on shared state amplifies exactly the
shared-tree race class opus-47 exhibited.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: paid-runner defaults 4x4 -> 8x2 — halve the local gate worst case

39 of 75 skill-e2e files hold exactly ONE test, so within-shard
concurrency was dead weight for most shards: 4 jobs x 4 concurrency
yielded only ~4-6 real in-flight sessions and a 13-wave local gate worst
case (~6.5h). 8 jobs x 2 gives ~10-13 in-flight — under the
documented-safe ~15 — and ~7 waves (~3.3h worst case). CI lanes keep
their explicit EVALS_JOBS env (2 per slice; 4 for gate-census); this
changes local defaults. Rollback trigger: sustained 429 storms in the WS1
telemetry across 2 PR cycles. test/eval-detach-timeout-floor.test.ts
recomputed green (the raise LOWERS the worst-case floor).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: SHA-pin every action in the secrets-bearing eval lanes

evals.yml and evals-periodic.yml execute PR-authored code with three
provider API keys in env, yet rode mutable action tags (@v7/@v8/@v2/@v4)
— while quality-gate.yml, osv-scanner.yml, and dependency-review.yml
already model the SHA-pin pattern. All 30 uses sites across both lanes now
pin the exact commit (tag noted in a trailing comment); dependabot's
github-actions ecosystem keeps them fresh via PRs instead of silent tag
moves. Pulled forward from the plan's endgame on the CEO-review + outside-
voice agreement: supply-chain pins on secret lanes go first, not last.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: sweep wave 3 — the execFileSync family gets timeouts (90 sites, 17 files)

The tripwire's regex covered spawnSync/execSync/Bun.spawnSync but not
execFileSync — an entire blocking sync-spawn API family that could
reintroduce the shard-wedge class undetected (ship review army). Same
mechanical recipe as waves 1-2: timeout: 30_000 default, 120_000 for slow
ops, shared wrappers fixed once, string-needle sites skipped with reasons.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test: review-army + adversarial test hardening

- Tripwire scans execFileSync too (ceiling 8: two more grep-needle string
  exemptions); merge-introduced timeout-less spawnSync in
  question-preference-hook fixed — the tripwire caught a site that landed
  on main AFTER the sweep, on its first day.
- gstack-detach gains TWO watchdog kill regression tests: TERM-immune
  grandchild (the killpg-after-grace escalation) and the leader-dies
  variant (the pgid-at-spawn fix — the case the first test cannot see).
- eval-flake-rank gets its unit suite (final-attempt accounting, artifact
  exclusion, shard recursion, recency bound).
- Groupkill/startup-grace shim markers are per-run unique (pid-suffixed
  sleep durations): sibling Conductor worktrees run free suites with no
  machine lock, and fixed markers let one run pgrep/pkill the other's
  shims — a cross-run flake inside the anti-flake tests.
- flake-ledger test pins the project-scoped local default; stale empty
  section headers in touchfiles-data deleted (they invited entries under
  deliberately retired categories).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: adversarial-review runtime fixes across the telemetry + kill paths

- session-runner: exit-labeling keys off 'exit', not 'close' — an orphan
  holding the pipes could relabel a REAL exit (auth failure) as
  'timeout_startup' availability noise; the kill path still always
  group-kills and cancels the reader (labeling and unblocking are separate
  concerns). Work phase arms on a flag, not firstResponseMs===0 (a same-ms
  first byte left the startup timer live all run). The CI startup grace is
  now a real FLOOR (Math.max), matching its name and pinning test.
- gstack-detach: pgid captured AT SPAWN (== child pid under
  start_new_session) — resolving it after the grace raised ESRCH once the
  leader died on SIGTERM, orphaning TERM-immune grandchildren forever.
- test-free-shards: ledger entries carry branch + git_sha (rev-parse split:
  '--abbrev-ref HEAD HEAD' printed the branch twice and recorded it as the
  sha); local ledger default is per-PROJECT, not the machine-global tmpdir.
- eval-flake-rank: per-LINE ledger parse (one torn JSONL line vanished the
  whole series), 60-day recency bound (transcript-bearing files are MBs),
  shared isFinalizedEvalResultFile predicate (the artifact-taxonomy rule
  lived in three places); eval-store exports the predicate and finalize
  stops computing flakyRetries twice; paid-shards cleanup uses async rm
  (a SIGKILLed shard's git-workspace teardown blocked every sibling's
  stream classification on the parent event loop).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: CI trust-boundary + fail-closed repairs (adversarial findings)

- Token/exec separation restored: slices-report (runs PR-authored code:
  bun install + the reconcile runner) drops to contents:read; the PR
  comment moves to a NEW slices-comment job holding the write token with
  ZERO repo code — no checkout, no bun, only downloaded artifacts + jq/gh.
  $GITHUB_ENV/BASH_ENV persistence is job-scoped, so the split is the
  boundary. The matrix-era report job had this property; the consolidation
  had regressed it. Pinned by the wiring test.
- Reconcile exit captured via PIPESTATUS[0] in BOTH lanes: GitHub's default
  run-step shell has no pipefail, so `$?` after `| tee` was tee's exit —
  the fail-closed gate was silently fail-open. Wiring test pins it.
- PR comment: final-attempt accounting restored the dropped COST
  accumulation (the dial read $0 forever), flaky passes render as the
  warning they are (never as failures), and a malformed tests[] artifact
  skips that file instead of aborting the whole comment under bash -e.
- Remaining mutable action tags pinned (free-tests upload-artifact,
  ci-image checkout/docker trio — the image publisher holds packages:write
  and feeds the secret-bearing lanes). restore-deps fallback installs
  --frozen-lockfile; register-gstack-skills validates skill names before
  its rm -rf.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore: bump version and changelog (v1.77.0.0)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: update project documentation for v1.77.0.0

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: cross-model doc-review fixes — flake-ledger env knobs, CI retry-on note, stale version comment

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: correct CHANGELOG receipt numbers to measured values

Gate census keys: 78 -> 77 (bun-imported E2E_TIERS count). Sweep receipt:
586 sites/176 files -> 499 sites/146 files, measured by running this
branch's spawnsync-timeout-tripwire against origin/main (exit 1, 499
violations across 146 unique files; green on this branch).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: slices-comment creates the PR comment via REST — the write-token job has no git context

The token/exec split gives slices-comment NO checkout by design, and gh's
pr-comment subcommand resolves the repo FROM git — it died with 'not a git
repository' on PR #2746's first run (the update-existing PATCH path was
already explicit-repo REST and worked). Create now posts through
gh api repos/.../issues/N/comments, and the wiring test pins that no
git-context-requiring comment call can creep back into the job.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: startup-grace probes clear CI for local semantics; new probe pins the floor clamp

The two shim probes pass explicit 2s/4s graces, but in CI the runner clamps
any explicit grace up to the 300s floor (deliberate adversarial-review fix),
so 'silent API killed at the grace' died at the 30s work cap instead of 2s —
a deterministic red on every CI run, green locally. The probes now pin LOCAL
semantics with CI cleared (same save/restore pattern as their PATH shim),
and a fourth probe pins the clamp itself: CI=1 + 2s grace + 6s timeout must
kill at the 6s cap, still in the startup phase — proof an explicit low grace
cannot bypass the floor.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-31 08:55:30 -07:00

671 lines
31 KiB
TypeScript
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import { describe, test, expect } from 'bun:test';
import * as fs from 'fs';
import * as path from 'path';
import * as os from 'os';
import {
isFreeTestFile,
collectFreeTestFiles,
detectWindowsFragility,
curateWindowsSafe,
stableHash,
assignFilesToShards,
buildShardArgs,
normalizeRelativePath,
runFreeShard,
FreeRunReporter,
buildRunEpilogue,
FREE_TEST_TIMEOUT_MS,
DEFAULT_WALL_TIMEOUT_MS,
PER_FILE_WALL_MS,
wallTimeoutForShard,
KNOWN_WINDOWS_INCOMPATIBLE,
TEST_ROOTS,
TREE_MUTATING,
WORKER_HOSTILE,
} from '../scripts/test-free-shards';
import {
loadFreeTestDurations,
packShardsByDuration,
wallTimeoutForPackedShard,
DEFAULT_WALL_TIMEOUT_MS as WALL_BASE_MS,
} from '../scripts/test-free-shards';
const ROOT = path.resolve(import.meta.dir, '..');
describe('test-free-shards: enumeration', () => {
test('isFreeTestFile rejects non-test files', () => {
expect(isFreeTestFile('test/foo.ts')).toBe(false);
expect(isFreeTestFile('test/foo.test.ts')).toBe(true);
expect(isFreeTestFile('test/foo.test.tsx')).toBe(true);
expect(isFreeTestFile('test/foo.test.mjs')).toBe(true);
});
test('isFreeTestFile rejects paid eval tests', () => {
expect(isFreeTestFile('test/skill-e2e-foo.test.ts')).toBe(false);
expect(isFreeTestFile('test/skill-llm-eval.test.ts')).toBe(false);
expect(isFreeTestFile('test/codex-e2e.test.ts')).toBe(false);
expect(isFreeTestFile('test/codex-e2e-sol-scope.test.ts')).toBe(false);
expect(isFreeTestFile('test/gemini-e2e.test.ts')).toBe(false);
});
test('collectFreeTestFiles returns sorted, deduped, only-free list', () => {
const files = collectFreeTestFiles(ROOT);
expect(files.length).toBeGreaterThan(10);
expect(files).toEqual([...files].sort());
expect(new Set(files).size).toBe(files.length);
for (const f of files) {
expect(isFreeTestFile(f)).toBe(true);
}
});
test('normalizeRelativePath converts Windows backslashes to forward slashes', () => {
expect(normalizeRelativePath('test\\foo\\bar.test.ts')).toBe('test/foo/bar.test.ts');
expect(normalizeRelativePath('test/foo/bar.test.ts')).toBe('test/foo/bar.test.ts');
});
});
describe('test-free-shards: Windows curation', () => {
function withTempFile(content: string, fn: (filePath: string) => void): void {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'curation-test-'));
const file = path.join(dir, 'sample.test.ts');
fs.writeFileSync(file, content);
try {
fn(file);
} finally {
fs.rmSync(dir, { recursive: true, force: true });
}
}
test('detects /bin/bash hardcode', () => {
withTempFile(`spawn('/bin/bash', ['-c', 'echo hi']);`, (f) => {
expect(detectWindowsFragility(f)?.reason).toBe('hardcoded /bin/sh or /bin/bash');
});
});
test('detects spawn("sh", ...)', () => {
// tripwire-exempt: string fixture fed to detectWindowsFragility, not a call
withTempFile(`spawnSync('sh', ['-c', 'command -v claude']);`, (f) => {
expect(detectWindowsFragility(f)?.reason).toBe('spawn("sh", ...)');
});
});
test('detects raw /tmp/ paths', () => {
withTempFile(`const TMPERR = '/tmp/codex-err.txt';`, (f) => {
expect(detectWindowsFragility(f)?.reason).toBe('raw /tmp/ path (use os.tmpdir())');
});
});
test('detects which claude shell command', () => {
// tripwire-exempt: string fixture fed to detectWindowsFragility, not a call
withTempFile(`execSync('which claude').trim();`, (f) => {
expect(detectWindowsFragility(f)?.reason).toBe('which claude (use Bun.which)');
});
});
test('Windows-safe code passes the filter', () => {
withTempFile(`import { spawn } from 'child_process'; spawn(claude.command, args);`, (f) => {
expect(detectWindowsFragility(f)).toBeNull();
});
});
test('curateWindowsSafe partitions files into safe + excluded', () => {
const files = collectFreeTestFiles(ROOT);
const result = curateWindowsSafe(files, ROOT);
expect(result.safe.length + result.excluded.length).toBe(files.length);
// Sanity: at least one excluded entry, since we know test/ship-version-sync.test.ts uses /bin/bash
expect(result.excluded.length).toBeGreaterThan(0);
// Every excluded entry has a non-empty reason
for (const { reason } of result.excluded) {
expect(reason.length).toBeGreaterThan(0);
}
});
});
describe('test-free-shards: sharding', () => {
test('stableHash is deterministic', () => {
expect(stableHash('foo.test.ts')).toBe(stableHash('foo.test.ts'));
expect(stableHash('foo.test.ts')).not.toBe(stableHash('bar.test.ts'));
});
test('assignFilesToShards partitions every file across exactly shardCount shards', () => {
const files = ['a.test.ts', 'b.test.ts', 'c.test.ts', 'd.test.ts', 'e.test.ts'];
const shards = assignFilesToShards(files, 3);
expect(shards.length).toBe(3);
expect(shards.flat().sort()).toEqual([...files].sort());
});
test('empty shards are preserved so indices stay stable for a CI matrix', () => {
// 2 files can never occupy 10 shards — the rest MUST be present and empty,
// not filtered out (filtering renumbered every later shard by occupancy).
const files = ['a.test.ts', 'b.test.ts'];
const shards = assignFilesToShards(files, 10);
expect(shards.length).toBe(10);
expect(shards.flat().sort()).toEqual([...files].sort());
expect(shards.some((s) => s.length === 0)).toBe(true);
});
test("a file's shard index depends only on its own path — other files never renumber it", () => {
const target = 'test/target.test.ts';
const expected = stableHash(target) % 7;
const alone = assignFilesToShards([target], 7);
const crowded = assignFilesToShards(
[target, 'test/a.test.ts', 'test/b.test.ts', 'test/c.test.ts', 'test/d.test.ts', 'browse/test/e.test.ts'],
7,
);
expect(alone.findIndex((s) => s.includes(target))).toBe(expected);
expect(crowded.findIndex((s) => s.includes(target))).toBe(expected);
});
test('assignFilesToShards rejects invalid shard counts', () => {
expect(() => assignFilesToShards(['a.test.ts'], 0)).toThrow();
expect(() => assignFilesToShards(['a.test.ts'], -1)).toThrow();
});
test('shards are stable across runs (same files always land in same shard)', () => {
const files = ['x.test.ts', 'y.test.ts', 'z.test.ts'];
const a = assignFilesToShards(files, 5);
const b = assignFilesToShards(files, 5);
expect(a).toEqual(b);
});
});
describe('test-free-shards: shard args', () => {
test('resolves exact absolute selectors (no substring shard bleed) and pins the per-test timeout', () => {
const args = buildShardArgs(['test/foo.test.ts'], { rootDir: ROOT });
expect(args[0]).toBe('test');
expect(args[1]).toBe(path.resolve(ROOT, 'test/foo.test.ts'));
expect(args).toContain(`--timeout=${FREE_TEST_TIMEOUT_MS}`);
expect(args).toContain('--max-concurrency=1');
expect(args).not.toContain('--parallel');
});
test('parallel mode swaps serial max-concurrency for --parallel', () => {
const args = buildShardArgs(['test/foo.test.ts'], { rootDir: ROOT, parallel: true });
expect(args).toContain('--parallel');
expect(args).not.toContain('--max-concurrency=1');
});
test('per-test timeout matches the 30s the package.json test script used before the repoint', () => {
expect(FREE_TEST_TIMEOUT_MS).toBe(30_000);
});
});
describe('test-free-shards: strict shard execution', () => {
// Fake command seam, same pattern as test/paid-shards.test.ts: each "file"
// label selects a child command. Unlike the paid runner, runFreeShard
// enforces the terminal-summary file count on injected commands too, so
// fake PASSING commands must print a synthetic bun summary line.
const SUMMARY_1 = 'Ran 3 tests across 1 files. [12.00ms]';
const BUSY_LOOP = 'const end = Date.now() + 600000; while (Date.now() < end) {}';
const FAIL_LINE = '(fa' + 'il) planted failure [0.10ms]'; // split so this source file never contains a raw bun fail line
const commandFor = (files: string[]) => {
const mode = files[0];
if (mode === 'spin') return { command: process.execPath, args: ['-e', BUSY_LOOP] };
if (mode === 'no-summary') return { command: process.execPath, args: ['-e', 'console.log("ok")'] };
if (mode === 'fail-exit') {
return { command: process.execPath, args: ['-e', `console.log(${JSON.stringify(SUMMARY_1)}); process.exit(3)`] };
}
if (mode === 'fail-line-exit-zero') {
return { command: process.execPath, args: ['-e', `console.log(${JSON.stringify(FAIL_LINE)}); console.log(${JSON.stringify(SUMMARY_1)})`] };
}
if (mode === 'wrong-file-count') {
return { command: process.execPath, args: ['-e', 'console.log("Ran 3 tests across 4 files. [12.00ms]")'] };
}
return { command: process.execPath, args: ['-e', `console.log(${JSON.stringify(SUMMARY_1)})`] };
};
test('exit 0 WITHOUT bun\'s terminal summary is a FAILURE (anti-truncation backstop)', async () => {
const outcome = await runFreeShard(['no-summary'], 1, 1, { commandFor, quiet: true, log: () => {} });
expect(outcome.status).toBe('failed');
expect(outcome.exitCode).toBe(0);
});
test('exit 0 WITH the terminal summary passes, and the per-shard epilogue line is printed', async () => {
const lines: string[] = [];
const outcome = await runFreeShard(['pass'], 1, 1, { commandFor, quiet: true, log: (l) => lines.push(l) });
expect(outcome.status).toBe('passed');
expect(lines.some((l) => /^\[test:free\] shard 1\/1: 1 files, \d+s, pass$/.test(l))).toBe(true);
});
test('a non-zero exit stays a failure even when the summary is present', async () => {
const outcome = await runFreeShard(['fail-exit'], 1, 1, { commandFor, quiet: true, log: () => {} });
expect(outcome.status).toBe('failed');
expect(outcome.exitCode).toBe(3);
});
test('a printed (fail) result line is a failure even on exit 0 (bun exit-code bug class)', async () => {
const outcome = await runFreeShard(['fail-line-exit-zero'], 1, 1, { commandFor, quiet: true, log: () => {} });
expect(outcome.status).toBe('failed');
expect(outcome.exitCode).toBe(0);
});
test('a summary reporting the wrong file count is a failure (partial execution)', async () => {
const outcome = await runFreeShard(['wrong-file-count'], 1, 1, { commandFor, quiet: true, log: () => {} });
expect(outcome.status).toBe('failed');
});
test('a spinning shard is killed at the wall-clock deadline and reported timed-out, distinct from failed', async () => {
const lines: string[] = [];
const outcome = await runFreeShard(['spin'], 1, 1, {
commandFor, quiet: true, wallTimeoutMs: 1_200, log: (l) => lines.push(l),
});
expect(outcome.status).toBe('timed-out');
expect(outcome.status).not.toBe('failed');
// Killed at the deadline, not left to burn the full 600s busy loop.
expect(outcome.elapsedMs).toBeLessThan(30_000);
expect(outcome.groupPid).toBeGreaterThan(0);
if (process.platform !== 'win32') {
expect(() => process.kill(outcome.groupPid as number, 0)).toThrow();
}
expect(lines.some((l) => /^\[test:free\] shard 1\/1: 1 files, \d+s, timed-out$/.test(l))).toBe(true);
}, 30_000);
test('an empty shard is a fast no-op success and never spawns (stable CI-matrix indices)', async () => {
const lines: string[] = [];
const outcome = await runFreeShard([], 7, 20, {
commandFor: () => { throw new Error('an empty shard must not spawn a child'); },
log: (l) => lines.push(l),
});
expect(outcome.status).toBe('passed');
// Mutation-caught gap: bun strips types at runtime, so a missing
// failingFiles here feeds undefined into the flaky-retry flatMap.
expect(outcome.failingFiles).toEqual([]);
expect(outcome.unattributedFailures).toBe(0);
expect(lines.some((l) => /^\[test:free\] shard 7\/20: 0 files, 0s, pass$/.test(l))).toBe(true);
});
test('the log-file path is announced once at start and the PASS epilogue repeats it', async () => {
const lines: string[] = [];
const outcome = await runFreeShard(['pass'], 1, 1, { commandFor, quiet: true, log: (l) => lines.push(l) });
expect(outcome.status).toBe('passed');
const announced = lines.filter((l) => /^\[test:free\] full log: .+gstack-free-test-.+\.log$/.test(l));
expect(announced.length).toBe(1);
// PASS epilogue carries the counts from the terminal summary + the log path.
expect(lines.some((l) => /^\[test:free\] PASS — 3 tests, 1 files, \d+s\. Full log: .+\.log$/.test(l))).toBe(true);
});
test('spawned shard gets throwaway TMPDIR but NEVER an injected GSTACK_HOME', async () => {
// GSTACK_HOME injection was tried and reverted: one shared scratch home
// per invocation made 6,900 tests share MUTABLE state — config tests
// wrote keys that relink/update-check tests then read (12 measured
// cross-contamination failures). This pin keeps the regression out.
const captureDir = fs.mkdtempSync(path.join(os.tmpdir(), 'free-shard-env-'));
const dump = path.join(captureDir, 'env.json');
try {
const script =
`const fs = require("fs");`
+ `fs.writeFileSync(${JSON.stringify(dump)}, JSON.stringify({`
+ ` home: process.env.GSTACK_HOME ?? null, tmp: process.env.TMPDIR,`
+ ` tmpExists: fs.existsSync(process.env.TMPDIR || "") }));`
+ `console.log(${JSON.stringify(SUMMARY_1)});`;
const outcome = await runFreeShard(['env-dump'], 1, 1, {
commandFor: () => ({ command: process.execPath, args: ['-e', script] }),
quiet: true,
log: () => {},
});
expect(outcome.status).toBe('passed');
const seen = JSON.parse(fs.readFileSync(dump, 'utf8'));
// GSTACK_HOME passes through untouched (whatever the parent had, incl. unset).
expect(seen.home).toBe(process.env.GSTACK_HOME ?? null);
// TMPDIR is a per-shard throwaway, cleaned up once the shard finishes.
expect(seen.tmp).toContain('gstack-free-shard-');
expect(seen.tmpExists).toBe(true);
expect(seen.tmp).not.toBe(process.env.TMPDIR ?? '');
expect(fs.existsSync(seen.tmp)).toBe(false);
} finally {
fs.rmSync(captureDir, { recursive: true, force: true });
}
});
});
describe('test-free-shards: output contract (log capture, quiet console, failure epilogue)', () => {
// Convention from the block above: never write a raw bun fail line into this
// source file — build it at runtime so a printed source excerpt can't trip
// the strict classifier.
const FAIL_WORD = '(fa' + 'il)';
const failLine = (name: string) => `${FAIL_WORD} ${name} [0.10ms]`;
const SUMMARY_1 = 'Ran 3 tests across 1 files. [12.00ms]';
/** Fake child that prints the given lines (stdout, then stderr) and exits. */
const commandPrinting = (stdoutLines: string[], stderrLines: string[] = [], exitCode = 0) => () => ({
command: process.execPath,
args: ['-e',
stdoutLines.map((l) => `console.log(${JSON.stringify(l)});`).join('')
+ stderrLines.map((l) => `console.error(${JSON.stringify(l)});`).join('')
+ (exitCode !== 0 ? `process.exit(${exitCode});` : ''),
],
});
test('failure epilogue names the failing test, attributed to its file-chunk header', async () => {
const lines: string[] = [];
const commandFor = commandPrinting(['test/planted.test.ts:', failLine('planted failure'), SUMMARY_1]);
const outcome = await runFreeShard(['planted'], 1, 1, { commandFor, quiet: true, log: (l) => lines.push(l) });
expect(outcome.status).toBe('failed');
expect(lines.some((l) =>
/^\[test:free\] FAIL — 1 failing test\(s\) in 1 file\(s\), 0 crashed worker\(s\)\. Full log: .+\.log$/.test(l),
)).toBe(true);
expect(lines).toContain(' ✗ test/planted.test.ts — planted failure');
});
test('crash markers surface in the epilogue as crashed+retried workers', async () => {
const lines: string[] = [];
const commandFor = commandPrinting([
'test/crashy.test.ts:',
'⟳ crashed running test/crashy.test.ts, retrying',
'test/crashy.test.ts:',
'✗ test/crashy.test.ts (crashed: exited)',
'Ran 0 tests across 1 files. [12.00ms]',
], [], 1);
const outcome = await runFreeShard(['crashy'], 1, 1, { commandFor, quiet: true, log: (l) => lines.push(l) });
expect(outcome.status).toBe('failed');
expect(lines.some((l) =>
/^\[test:free\] FAIL — 0 failing test\(s\) in 0 file\(s\), 1 crashed worker\(s\)\. Full log: /.test(l),
)).toBe(true);
expect(lines).toContain(' ⚠ crashed+retried: test/crashy.test.ts');
});
test('default console is quiet: noise stays in the log; fail/error/summary lines pass through', async () => {
const consoleOut: string[] = [];
const commandFor = commandPrinting([
'PASSING-NOISE gitleaks ascii art',
'test/noisy.test.ts:',
failLine('quiet mode failure'),
'error: expect(received).toBe(expected)',
'Ran 1 tests across 1 files. [1.00ms]',
], ['telemetry stderr spam']);
const outcome = await runFreeShard(['noisy'], 1, 1, {
commandFor, consoleWrite: (t) => consoleOut.push(t), log: () => {},
});
expect(outcome.status).toBe('failed');
const joined = consoleOut.join('');
expect(joined).toContain(failLine('quiet mode failure'));
expect(joined).toContain('error: expect(received).toBe(expected)');
expect(joined).toContain('Ran 1 tests across 1 files.');
expect(joined).not.toContain('PASSING-NOISE');
expect(joined).not.toContain('telemetry stderr spam');
expect(joined).not.toContain('test/noisy.test.ts:'); // headers feed the epilogue, not the console
});
test('--verbose restores the full firehose to the console', async () => {
const consoleOut: string[] = [];
const commandFor = commandPrinting(
['PASSING-NOISE gitleaks ascii art', SUMMARY_1],
['telemetry stderr spam'],
);
const outcome = await runFreeShard(['pass'], 1, 1, {
commandFor, verbose: true, consoleWrite: (t) => consoleOut.push(t), log: () => {},
});
expect(outcome.status).toBe('passed');
const joined = consoleOut.join('');
expect(joined).toContain('PASSING-NOISE gitleaks ascii art');
expect(joined).toContain('telemetry stderr spam');
});
test('quiet suppresses the console entirely, even with an injected sink', async () => {
const consoleOut: string[] = [];
const commandFor = commandPrinting(['PASSING-NOISE', failLine('hidden'), SUMMARY_1]);
await runFreeShard(['pass'], 1, 1, {
commandFor, quiet: true, consoleWrite: (t) => consoleOut.push(t), log: () => {},
});
expect(consoleOut).toEqual([]);
});
test('the full child stream lands in the per-run log file, including console-filtered noise', async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'free-log-'));
const logFilePath = path.join(dir, 'run.log');
try {
const lines: string[] = [];
const commandFor = commandPrinting(['stdout NOISE-A', SUMMARY_1], ['stderr NOISE-B']);
const outcome = await runFreeShard(['pass'], 1, 1, { commandFor, quiet: true, logFilePath, log: (l) => lines.push(l) });
expect(outcome.status).toBe('passed');
expect(lines).toContain(`[test:free] full log: ${logFilePath}`);
const logged = fs.readFileSync(logFilePath, 'utf8');
expect(logged).toContain('stdout NOISE-A');
expect(logged).toContain('stderr NOISE-B');
expect(logged).toContain('Ran 3 tests across 1 files.');
} finally {
fs.rmSync(dir, { recursive: true, force: true });
}
});
test('colored fail lines are attributed after ANSI stripping (a prior grep missed them)', async () => {
const lines: string[] = [];
const colored = `\u001B[31m${failLine('colored failure')}\u001B[0m`;
const commandFor = commandPrinting(['test/colored.test.ts:', colored, 'Ran 1 tests across 1 files. [1.00ms]']);
const outcome = await runFreeShard(['colored'], 1, 1, { commandFor, quiet: true, log: (l) => lines.push(l) });
expect(outcome.status).toBe('failed');
expect(lines).toContain(' ✗ test/colored.test.ts — colored failure');
});
test('wall-timeout epilogue lists wedge suspects: header seen, no results, no summary', async () => {
const lines: string[] = [];
const commandFor = () => ({
command: process.execPath,
args: ['-e', 'console.log("test/wedged.test.ts:");console.log("wedged noise");setTimeout(() => {}, 600000);'],
});
const outcome = await runFreeShard(['wedged'], 1, 1, {
commandFor, quiet: true, wallTimeoutMs: 1_500, log: (l) => lines.push(l),
});
expect(outcome.status).toBe('timed-out');
expect(lines).toContain(' ⏱ in flight at kill: test/wedged.test.ts');
// The epilogue headline shape stays stable across statuses.
expect(lines.some((l) => l.startsWith('[test:free] FAIL — '))).toBe(true);
}, 30_000);
test('timeout with no observable header falls back to the buffered-parallel explanation', () => {
const reporter = new FreeRunReporter(['test/a.test.ts', 'test/b.test.ts']);
reporter.end();
const lines = buildRunEpilogue('timed-out', reporter.report(), 5_000, '/tmp/x.log');
expect(lines.some((l) => l.includes('in flight at kill: unknown'))).toBe(true);
expect(lines.some((l) => l.includes('2 planned file(s) produced no output'))).toBe(true);
});
test('duplicate fail lines dedupe; pre-header failures are labeled unattributed', () => {
const reporter = new FreeRunReporter(['test/a.test.ts']);
reporter.write(`${failLine('early unattributed')}\n`, 'stderr');
reporter.write('test/a.test.ts:\n', 'stderr');
reporter.write(`${failLine('dup')}\n${failLine('dup')}\n`, 'stderr');
reporter.end();
const report = reporter.report();
expect(report.failures).toEqual([
{ file: null, testName: 'early unattributed' },
{ file: 'test/a.test.ts', testName: 'dup' },
]);
const lines = buildRunEpilogue('failed', report, 1_000, '/tmp/x.log');
expect(lines).toContain(' ✗ (unattributed) — early unattributed');
expect(lines).toContain(' ✗ test/a.test.ts — dup');
expect(lines.some((l) => l.includes('2 failing test(s) in 2 file(s)'))).toBe(true);
});
test("a later file's header ends the previous chunk — completed noisy files are not wedge suspects", () => {
const reporter = new FreeRunReporter(['test/done.test.ts', 'test/hung.test.ts']);
reporter.write('test/done.test.ts:\n', 'stderr');
reporter.write('noise from the completed file\n', 'stderr');
reporter.write('test/hung.test.ts:\n', 'stderr');
reporter.write('noise before the hang\n', 'stderr');
reporter.end();
// No terminal summary: only the still-open chunk is in flight.
expect(reporter.report().inFlight).toEqual(['test/hung.test.ts']);
});
test('../-prefixed printed paths canonicalize to planned relative paths (symlinked cwd)', () => {
const reporter = new FreeRunReporter(['browse/test/x.test.ts']);
reporter.write('../../../work/repo/browse/test/x.test.ts:\n', 'stderr');
reporter.write(`${failLine('boom')}\n`, 'stderr');
reporter.end();
expect(reporter.report().failures[0]).toEqual({ file: 'browse/test/x.test.ts', testName: 'boom' });
});
});
describe('test-free-shards: GitHub Actions log-group attribution', () => {
const failLine = (name: string) => `(fail) ${name} [1.00ms]`;
// On GHA (GITHUB_ACTIONS=1) bun wraps each file's section in ::group::.
// Unstripped, the real header fails FILE_HEADER_RE, failures attribute to
// the PREVIOUS file, and the terminal recap's re-printed (fail) lines land
// under a phantom second file — the first Linux run reported 5 real
// failures as 10 across 2 files.
test('::group::-wrapped headers attribute failures to the right file, once', () => {
const reporter = new FreeRunReporter(['test/a.test.ts', 'test/b.test.ts']);
reporter.write('::group::test/a.test.ts:\n', 'stderr');
reporter.write('::endgroup::\n', 'stderr');
reporter.write('::group::test/b.test.ts:\n', 'stderr');
reporter.write(`${failLine('planted')}\n`, 'stderr');
reporter.write('::endgroup::\n', 'stderr');
// Terminal recap re-prints the failing file header + result line.
reporter.write('1 tests failed:\n', 'stderr');
reporter.write('::group::test/b.test.ts:\n', 'stderr');
reporter.write(`${failLine('planted')}\n`, 'stderr');
reporter.end();
expect(reporter.report().failures).toEqual([{ file: 'test/b.test.ts', testName: 'planted' }]);
});
test('headerless recap re-prints do not invent a phantom failing file', () => {
// Round-3 CI shape: bun's recap prints "N tests failed:" then the (fail)
// lines with NO file headers — the stale currentFile (an innocent file)
// was charged with the previous file's failures.
const reporter = new FreeRunReporter(['test/a.test.ts', 'test/b.test.ts']);
reporter.write('::group::test/a.test.ts:\n', 'stderr');
reporter.write(`${failLine('planted')}\n`, 'stderr');
reporter.write('::endgroup::\n', 'stderr');
reporter.write('::group::test/b.test.ts:\n', 'stderr');
reporter.write('(pass-ish output, no failures here)\n', 'stderr');
reporter.write('2 tests failed:\n', 'stderr');
reporter.write(`${failLine('planted')}\n`, 'stderr');
reporter.write(`${failLine('planted')}\n`, 'stderr');
reporter.end();
expect(reporter.report().failures).toEqual([{ file: 'test/a.test.ts', testName: 'planted' }]);
});
});
describe('test-free-shards: curated-list census pins', () => {
// A renamed test file must FAIL here, not silently drop its serialization
// (a phantom TREE_MUTATING key means the reader races regenerating shards
// again) or its serial-child quarantine (WORKER_HOSTILE).
test('every TREE_MUTATING and WORKER_HOSTILE key names a real free test file', () => {
const census = new Set(collectFreeTestFiles(ROOT));
const stale = [...Object.keys(TREE_MUTATING), ...Object.keys(WORKER_HOSTILE)]
.filter((key) => !census.has(key));
expect(stale).toEqual([]);
});
test('every KNOWN_WINDOWS_INCOMPATIBLE entry names a real free test file', () => {
const census = new Set(collectFreeTestFiles(ROOT));
const stale = KNOWN_WINDOWS_INCOMPATIBLE.map((e) => e.file).filter((f) => !census.has(f));
expect(stale).toEqual([]);
});
test('every TEST_ROOTS entry exists on disk and contributes at least one test file', () => {
const files = collectFreeTestFiles(ROOT);
for (const root of TEST_ROOTS) {
expect(fs.existsSync(path.join(ROOT, root))).toBe(true);
expect(files.some((f) => f.startsWith(`${root}/`))).toBe(true);
}
});
});
describe('test-free-shards: wall-timeout scaling', () => {
test('typical local shard keeps the 6-minute floor', () => {
expect(wallTimeoutForShard(70)).toBe(DEFAULT_WALL_TIMEOUT_MS);
});
test('oversized shards (jobs=1 machines, Windows lane) scale linearly past the floor', () => {
expect(wallTimeoutForShard(130)).toBe(130 * PER_FILE_WALL_MS);
expect(wallTimeoutForShard(420)).toBe(420 * PER_FILE_WALL_MS);
});
test('an explicit base above the scaled value wins', () => {
expect(wallTimeoutForShard(10, 10 * 60_000)).toBe(10 * 60_000);
});
});
describe('test-free-shards: duration-aware packing (full-suite LPT)', () => {
const files = ['test/a.test.ts', 'test/b.test.ts', 'test/c.test.ts', 'test/d.test.ts'];
test('LPT balances by cost, not count', () => {
const durations = {
'test/a.test.ts': 90_000, // one giant file
'test/b.test.ts': 30_000,
'test/c.test.ts': 30_000,
'test/d.test.ts': 30_000,
};
const { shards, predictedMs } = packShardsByDuration(files, 2, durations);
// The giant file gets its own shard; the three smalls share the other.
expect(shards.map((s) => s.length).sort()).toEqual([1, 3]);
expect(Math.max(...predictedMs)).toBe(90_000);
});
test('deterministic for identical inputs', () => {
const durations = { 'test/a.test.ts': 5, 'test/b.test.ts': 5, 'test/c.test.ts': 5, 'test/d.test.ts': 5 };
const one = packShardsByDuration(files, 3, durations);
const two = packShardsByDuration([...files].reverse(), 3, durations);
expect(one.shards).toEqual(two.shards);
});
test('unknown files get 75th-percentile pessimism (placed early, never the tail)', () => {
const durations = {
'test/a.test.ts': 1_000,
'test/b.test.ts': 2_000,
'test/c.test.ts': 100_000,
// test/d.test.ts unrecorded → p75 of known = 100_000 (pessimistic)
};
const { shards } = packShardsByDuration(files, 2, durations);
// The unknown must NOT be packed as if free: it lands opposite the
// 100s file, not stacked onto it.
const shardOfC = shards.findIndex((s) => s.includes('test/c.test.ts'));
const shardOfD = shards.findIndex((s) => s.includes('test/d.test.ts'));
expect(shardOfC).not.toBe(shardOfD);
});
test('every file lands in exactly one shard', () => {
const { shards } = packShardsByDuration(files, 3, {});
expect(shards.flat().sort()).toEqual([...files].sort());
});
test('invalid shard count throws', () => {
expect(() => packShardsByDuration(files, 0, {})).toThrow();
});
test('corrupt seed falls back to null (hash sharding), never throws', () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'durations-seed-'));
const seedPath = path.join(dir, 'seed.json');
fs.writeFileSync(seedPath, '{ definitely not json');
const prev = process.env.GSTACK_FREE_TEST_DURATIONS;
process.env.GSTACK_FREE_TEST_DURATIONS = seedPath;
try {
expect(loadFreeTestDurations()).toBeNull();
// Missing file: silent null (fresh checkouts are normal).
process.env.GSTACK_FREE_TEST_DURATIONS = path.join(dir, 'missing.json');
expect(loadFreeTestDurations()).toBeNull();
// Valid seed round-trips, non-numeric entries dropped.
fs.writeFileSync(seedPath, JSON.stringify({ version: 1, durations: { 'test/a.test.ts': 42, bad: 'nope' } }));
process.env.GSTACK_FREE_TEST_DURATIONS = seedPath;
expect(loadFreeTestDurations()).toEqual({ 'test/a.test.ts': 42 });
} finally {
if (prev === undefined) delete process.env.GSTACK_FREE_TEST_DURATIONS;
else process.env.GSTACK_FREE_TEST_DURATIONS = prev;
fs.rmSync(dir, { recursive: true, force: true });
}
});
test('packed shards get duration-aware walls (count heuristic is wrong under LPT)', () => {
// A packed shard predicted at 120s must get a 360s wall even though its
// file COUNT would produce only the 6-minute base under the old formula.
expect(wallTimeoutForPackedShard(120_000)).toBe(Math.max(WALL_BASE_MS, 360_000));
// Tiny prediction: base still floors it.
expect(wallTimeoutForPackedShard(1_000)).toBe(WALL_BASE_MS);
});
test('packed walls never undercut the per-file floor (predictions do not transfer across machines)', () => {
// The duration seed is recorded on fast CI; a syscall-supervised sandbox
// replays the same files 2-4x slower. A 253-file shard predicted at ~242s
// got wall-killed at predicted×3 = 725s while genuinely progressing —
// the count-based floor (253 × 5s = 1265s) the runner always guaranteed
// must survive duration packing. Looser is allowed, tighter is not.
expect(wallTimeoutForPackedShard(242_000, WALL_BASE_MS, 253)).toBe(253 * 5_000);
// When the prediction is the larger bound, it still wins.
expect(wallTimeoutForPackedShard(600_000, WALL_BASE_MS, 10)).toBe(1_800_000);
});
});