mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-05 08:23:59 +01:00
* fix(autoplan): empty findings fences, repo-relative rows, PLAN_REALITY flags, pending/--all/provider (Lane B: B3 B6 B7 B8 B9 B10 B11)
B3 parseFences: the body group is optional (lazy), so an LF/CRLF empty fence is zero
findings in both the canonical and record grammars; opener without closer still
RESULT_FINDINGS_MISSING.
B6 plan-reality/3: item/section references are not quantities; backtick phrases are
exempt only from the plan-scope rule-phrase check (B-f); a measured number inside
backticks stays flagged in review scope. vaguePlanTerms() feeds an advisory
`flagged: PLAN_REALITY ...` line under the p1 approval item (never blocking).
B7 canonical rows: absolute repo paths become repo-relative; snapshot/active-plan
citations become the plan file name with the source line mapped (or dropped).
B8 `status` prints `PENDING: <id> phase=<p> voice=<v> result=<file>` per open attempt.
B9 `gstack-gate render --all`; paged output says to relay every page.
B10 `gstack-plan-reality check --plan <snapshot>`: a number in a "quoted" span copied
verbatim from the reviewed plan needs no receipt (reviewer scope only).
B11 submit defaults the provider to host-subagent when --runner is omitted.
Lane B files: lib/autoplan-reconcile.ts lib/plan-reality.ts lib/autoplan-gate.ts
lib/gate-list.ts lib/autoplan-plan-text.ts lib/autoplan-run.ts bin/gstack-gate
bin/gstack-plan-reality scripts/resolvers/plan-reality.ts autoplan/sections/ceo-phase.md
autoplan/sections/eng-phase.md test/plan-reality.test.ts test/autoplan-gate-artifacts.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(ubicloud): ubi-runner up/run -S accepts only Ubicloud's storage sizes, before any API call (A11)
Files: scripts/ubicloud/ubi-runner.sh, test/ubicloud-runner.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(issue-links): promotion candidates, Related PRs, validated flake issues, body/receipt consistency (Lane D: D1-D3)
D1: the GBRA-40 fix wave's gbrain #6279 body had no `## Issues` section and no
receipt (it was not composed by /ship, so gstack-issue-links never ran), and
#6252 appeared only as a subject parenthetical `(#6252)`, which the closure
rule correctly treats as Refs. The rule is kept. Same-repo references are now
printed as promotion candidates (`(promote: fix #N)`, `candidates` in --json),
and `gstack-ship-receipt write --issues ... --body` refuses a body that lacks a
line its issues object records (ISSUE_LINKS_MISSING), so a /ship body can no
longer drop its closing lines.
D2: open PRs by other authors whose closing set overlaps this PR's Fixes are
`Related: #N (@author)` (paged GraphQL closedByPullRequestsReferences; viewer
and this branch excluded; cross-repo PRs keep owner/repo#N). `Supersedes` and
`Contributed by` only with --supersedes/--credit; --no-auto-links skips the
lookup; the stderr preview names each added line's source. A failed lookup is
ISSUE_LOOKUP_FAILED (installer form with docs anchor) and keeps the other lines.
D3: a --ci-run match becomes a Flake line only for a bot-opened issue of this
repository that names that run (flake:json first_seen.run_id or this repo's
actions/runs URL) and a test; duplicates of one test keep the lowest number;
every refused match prints its reason.
Files: bin/gstack-issue-links, bin/gstack-ship-receipt, lib/issue-links.ts,
lib/ship-receipt.ts, lib/headless-artifacts.ts (ship-receipt issues.related),
lib/result-codes.ts (ISSUE_LOOKUP_FAILED, ISSUE_LINKS_MISSING,
resultLineWithDocs), bin/gstack-doctor-components.sh (regenerated),
docs/pregate.md, docs/troubleshooting.md, test/ship-issue-intent.test.ts,
test/helpers/pregate-fixture.ts (gh shim: repo view, api graphql, full issue rows).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(ship): link issues by intent at publish and handoff; Fixes: trailer at commit (Lane D: D1, D2, D-a)
- Step 15: a commit fixing a user-named issue carries a `Fixes: #<n>` trailer
(offset by tightening Step 15 so the skeleton stays at 80,998 <= 81,000).
- pr-body: an explicit "Issue links" step runs gstack-issue-links before the
body is composed (previously only a placeholder inside the body template);
interactive runs ask once about `(promote: fix #N)` references and add
`--supersedes`/`--credit` only on the owner's confirmation; unattended runs
keep Refs and list unpromoted candidates, Related lines and lookup failures
in the completion message; `ISSUE_LINKS_MISSING` from the receipt write.
- handoff (no-PR lanes): runs gstack-issue-links and passes --issues to the
receipt; the completion message gains an `issues:` line.
- Regenerated ship/SKILL.md and sections; refreshed the four ship goldens.
- Parity: union 309,431 / 187,706 = 1.6485 (> 1.6450 by 655 bytes); maxSizeRatio
raised to the measured 1.6485 with its justification, as previous waves did.
Files: ship/SKILL.md.tmpl, ship/SKILL.md, ship/sections/pr-body.md.tmpl,
ship/sections/pr-body.md, ship/sections/handoff.md.tmpl, ship/sections/handoff.md,
test/fixtures/golden/{claude,codex,factory,agy}-ship-SKILL.md,
test/helpers/carve-guards.ts (ship maxSizeRatio).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(install): one Bun resolution contract, versioned runtime store, verdict per (checkout, project), drift and wrapper rows (A1-A3, A5, A6, A8, A-c, A-d, A-f, A-h, A-i)
- bin/gstack-bun-version.sh: GSTACK_BUN_DEFAULT=1.4.3 beside the 1.4.2 floor,
gstack_bun_install_version (GSTACK_BUN_INSTALL_VERSION override),
gstack_bun_store, portable gstack_realpath, and gstack_bun_resolve (pin and
default in the store, $BUN_INSTALL/bin, ~/.bun/bin, PATH; first candidate
satisfying every pin; shim-marked files never returned). gstack_bun_launch_dir
is replaced by it.
- lib/pregate/runtime.ts: resolveBun, the TypeScript twin; launchRuntime runs
the Bun the install verdict recorded under the admission condition and
explains the skip otherwise.
- bin/gstack-capy-install: install and --check resolve through the contract;
verified archives publish atomically to <state root>/runtimes/bun/<v>/bun
under ~/.gstack-runtime.lock and ~/.bun/bin is never written; the "no Bun
satisfies" line names the candidates judged; --check reports
BUN_RESOLUTION_DRIFT with one converging fix.
- bin/gstack-install-verdict.sh, lib/install-verdict.ts: schema 2 verdicts
keyed by (checkout, project) with pin, bun_path, bun_version, bun_rule;
schema 1 path still read; admission binds test-running workflows to the
project and refuses a running Bun the verdict did not record.
- bin/gstack-doctor-check.sh, lib/doctor-components.ts: wrapper core row
(CAPY_WRAPPER_STALE by active provenance, WARN for stale Drive copies),
runtime drift row, shim note, install-version note.
- lib/result-codes.ts: BUN_RESOLUTION_DRIFT, BUN_INSTALL_VERSION_INVALID;
CAPY_WRAPPER_STALE fix names the workaround and the owner action.
Files: bin/gstack-bun-version.sh, bin/gstack-capy-install,
bin/gstack-doctor-check.sh, bin/gstack-doctor-components.sh (generated),
bin/gstack-install-verdict.sh, lib/doctor-components.ts,
lib/install-verdict.ts, lib/pregate/runtime.ts, lib/result-codes.ts,
test/bun-resolve.test.ts, test/gstack-capy-install.test.ts,
test/gstack-doctor.test.ts, test/install-verdict.test.ts,
test/pregate-guards.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(issue-links): --author for the Related lookup when gh runs as an app (Lane D: D2)
On a Capy machine the gh viewer is `capy-ai[bot]`, not the owner (checked live
against garrytan/gbrain #6252), so "other authors" needs the PR author named:
`--author <login>` overrides the viewer; the pr-body Issue links step says to
pass it when gh runs as an app.
Files: bin/gstack-issue-links, docs/pregate.md, ship/sections/pr-body.md.tmpl,
ship/sections/pr-body.md, test/ship-issue-intent.test.ts,
test/helpers/carve-guards.ts (ship maxSizeRatio re-measured: 309,483 / 187,706 = 1.6488).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(troubleshooting): BUN_RESOLUTION_DRIFT and BUN_INSTALL_VERSION_INVALID anchors; CAPY_WRAPPER_STALE covers the wrapper row (A5, A8, A-f, G1)
Files: docs/troubleshooting.md, bin/gstack-capy-install, bin/gstack-doctor-check.sh, test/gstack-capy-install.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* feat(install): marked per-directory bun and bunx shims for fresh Capy shells (A4, A-e)
gstack-capy-install (install mode, Capy machines only, GSTACK_BUN_SHIM=0 opts
out) writes ~/.local/bin/bun and bunx under ~/.gstack-runtime.lock. The shim
bakes the store, verdict directory, checkout and install default, walks up to
.git without spawning git, runs the Bun the (checkout, project) verdict
recorded, else a store Bun matching the .bun-version/package.json subset
(stderr names the --check to run when none matches), else the install
default, else the next unmarked bun on PATH. A foreign file or dangling link
is never touched. GSTACK_BUN_SHIM_EXPLAIN=1 prints project, record, choice and
rule; the doctor's runtime row shows the shim and its target.
Files: bin/gstack-capy-install, test/gstack-capy-install.test.ts, test/gstack-doctor.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): test stage never hangs silently; small machines record the remote gate (Lane C, GBRA-95)
C1 diagnosis (gbrain 92f0ea87, a core edit selecting 3,683 local files, 358
serial; Bun 1.4.2 and 1.4.3 identical): --timeout was applied per runner
spawn (unit group plus one per serial file), so the check was unbounded, and
spawnSync buffered all output until it returned: 360 s with 0 bytes on stdout
and stderr. A backgrounded child holding stdout made spawnSync wait the full
timeout and then report exit 0 (a silent wait, then green). Not the Bun 1.4.2
spawnSync hang.
C2/C-b: test-tier commands (lanes runner, guards, the --remote gate) run via
lib/pregate/supervise.ts: own process group (setsid), stdout/stderr appended
to a log file (no pipes), async supervision; CheckDef.run may return a
promise and runPregate/withFingerprint await it (a rejection is incomplete).
Leftover group members are killed after exit; SIGINT/SIGTERM to pregate
SIGKILLs running groups, writes no pregate.json, exits 130/143. Windows:
taskkill /T /F (reparented or detached descendants can survive; documented).
C3/C-a: --timeout bounds the whole check; groups past the deadline are not
started. --stall-timeout <s> (default stall_timeout_s, else 300; 0 disables)
kills a group whose log stops growing and records PREGATE_STALLED naming the
last file started. Live stderr: PREGATE_TEST per file (bun test adapter; any
runner for one-file runs), PREGATE_HEARTBEAT after 60 s without progress,
PREGATE: tests <verdict>. --json stdout unchanged.
C4/C-c: under 8 cores, a base-branch remote_gate or a non-local test_backend
records the local tier as a requires-remote obligation with its command
(pregate.json/remote_gate or test_backend/<backend>). --remote runs the
declared remote_gate now (needs --allow-repo-commands, never --policy-from
head) under --spend-cap/GSTACK_SPEND_CAP_USD; it clears only on
PREGATE_REMOTE: tree=<tested tree> tests>0 failed=0 with exit 0, and reports
spent/reserved/unknown.
G1: new code PREGATE_STALLED has its result-codes row, troubleshooting anchor
and the installer-form error line (CODE; url#anchor).
Files (G2): lib/pregate/supervise.ts (new), lib/pregate/types.ts,
lib/pregate/context.ts, lib/pregate/index.ts, lib/pregate/checks/lanes.ts,
lib/pregate/checks/guards.ts, lib/pregate/config.ts, lib/headless-artifacts.ts,
lib/result-codes.ts, bin/gstack-pregate, bin/gstack-doctor-components.sh
(generated), docs/pregate.md, docs/troubleshooting.md,
test/pregate-supervise.test.ts (new), test/pregate-remote.test.ts (new).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(ship): Step 5 pre-gate text for stalls and the small-machine remote gate (Lane C-c)
The pre-gate paragraph now says `incomplete` blocks (a stall is incomplete)
and that `requires-remote` covers the remote gate under 8 cores, cleared by
`gstack-pregate clear` or `--remote --spend-cap <usd>` only under a cap the
user gave. Kept within the ship parity size cap (union 308,771 of 308,776
bytes; base 308,767), so the `--explain` hint moved to docs/pregate.md. The
handoff's escalation line already names any `requires-remote` lane; unchanged.
Files (G2): ship/sections/tests.md.tmpl, ship/sections/tests.md (generated).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(install): one ok-trailer grammar with requested, pins-skipped and latest notes; bootstrapper revision 2 exports origin's VERSION (A9, A-a)
Notes ride only on the ok trailer in fixed order; the failure head is
unchanged, pinned by a test that runs the Capy skill's dispatch examples
against real doctor output. The latest note comes only from
GSTACK_CAPY_REMOTE_VERSION, which the bootstrapper sets from a fetch in this
run and unsets otherwise (a stale FETCH_HEAD never reaches the installer).
Files: bin/gstack-capy-install, bin/gstack-capy-session,
capy/skill/gstack/scripts/install.sh, capy/skill/gstack/SKILL.md,
test/gstack-capy-install.test.ts, test/capy-skill-wrapper.test.ts,
test/gstack-doctor.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(upgrade): every success path certifies the caller's project; a pins failure keeps the move, ends on gstack: fail pins, exit 1, no pending marker (A7, A-b)
gstack-upgrade captures the caller's directory and git toplevel before any
cd. Already-current, fast-forwarded and resumed-pending paths run
bin/gstack-capy-install --project <it> on Capy (installing a verified pinned
Bun) or gstack-doctor --check --require runtime,pins elsewhere. The
reinstall's own trailer is held back when a project certification follows,
so no ok precedes a pins failure; a RUNTIME_PIN_CONFLICT stop becomes
gstack: fail pins — <conflict>. --check and --ff-only-no-reinstall certify
nothing.
Files: bin/gstack-upgrade, test/gstack-upgrade-bin.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(install): fresh-install log lines name the clone and every host installed (A10)
gstack-capy-install prints `cloned <repo> at <sha> (<version>)` for a checkout
it cloned, or one the bootstrapper (revision 2, GSTACK_CAPY_CLONED) cloned in
this run, instead of `reusing`. setup's final line is
`gstack ready (<hosts>)` from the same rows as its summary table, including
the --refresh-registered upgrade summary.
Files: bin/gstack-capy-install, bin/gstack-capy-session,
capy/skill/gstack/scripts/install.sh, setup, test/gstack-capy-install.test.ts,
test/host-conformance.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): --remote runs the gate only when local tests are selected (Lane C4)
With only platform lanes selected, --remote no longer launches the remote
gate with an empty file list; the existing no-local-lane path applies.
Files (G2): lib/pregate/checks/lanes.ts.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(autoplan): one-word rec, verified pairing, sealed attempt results, deferred reopen (Lane B: B1 B2 B4 B5)
B1/B-b/B-c `rec` (aliases: all, approve all, accept all, take all recommendations)
takes every recommendation, plan changes included; `as-is` keeps every
direction. The render offers `rec` first and prints what it resolves to
with gate_rev and rec_hash. `gstack-autoplan recommend` changes one
recommendation before relay (provenance recorded, p1 and decisions follow)
and bumps rec_rev, so a `rec` without the new --rec-hash is refused
(GATE_REC_STALE). An agent answer needs the owner's words verbatim
(--owner-reply <text>|-, --owner-reply-file; OWNER_REPLY_REQUIRED); a
parseable owner reply that resolves differently from the relay is refused
(GATE_OWNER_REPLY_MISMATCH). Supersedes field-wave R1 per the owner's
gate_rev 1 decision.
B2/B-a reconcile associates by title first; a file:line-only match is
`unverified` (associated, never confirmed). `b` is recommended only for a
confirmed pair with the same `changes` and one shared proposal (override)
or the same normalized remedy; the basis says which. Negative control and
positives copied from run-20261014225954 (test/fixtures/autoplan-pairing).
B4/B-e each attempt writes <phase>-<voice>.<attempt>.md; submit refuses another
attempt's file (ATTEMPT_MISMATCH) and binds a sealed 0444
<phase>-<voice>.<attempt>.bound.md copy, so a late write changes nothing
bound; reopen keeps sealed copies in place.
B5/B-d answer records accepted changes as amendments (status amend_pending) and
reopens nothing; revise reopens what changed. `revise --settle <id|d4>`
discharges a packaging/ordering change on an unchanged plan
(AMENDMENT_NOT_SETTLEABLE otherwise). APPLY/NEXT/status lines say which.
DRIVER.md and the reply table move to the rec grammar.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* feat(autoplan): durable checkpoint and resume --from; Capy checklist (Lane B: B12)
With GSTACK_AUTOPLAN_CHECKPOINT_DIR set, every command that leaves a run at
rest (gate_pending, amend_pending, complete, incomplete) publishes
<dir>/<run>/: checkpoint.json listing every file's sha256, the run under run/,
the owner's plan file under plan-input/ when it lives outside the run, and
restore.md as the human index. Publication swaps in a fully written sibling.
Checkpointing at every rest state, not only gate_pending, keeps accepted
decisions from rolling back on restore.
`gstack-autoplan resume --out <new dir> --from <checkpoint>` checks
containment (no absolute or .. paths, regular files only) and every hash
before publishing the run with one rename. It restores a missing plan file
into the run, journals `restored` with both hosts, and takes the lock.
CHECKPOINT_INVALID and CHECKPOINT_TARGET_EXISTS each get a result-codes row
and a troubleshooting anchor. Journal and revise staging paths are now
run-relative, so a moved run recovers.
DRIVER.md and the Capy skill's autoplan section get a short Capy checklist:
always drive gstack-autoplan, never present a hand review as an autoplan run,
relay every gate page with rec as the default, pass --owner-reply, and point
the checkpoint at the private project-user Drive folder.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* A-g: run the quick free tier on GSTACK_BUN_DEFAULT in CI; drift test pins it
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs(autoplan): unattended contract and reply-unparsed fix move to rec, sealed results, settle and checkpoints (Lane B)
docs/unattended.md: rec/as-is/rec except grammar, --owner-reply and recommend/--rec-hash, unverified pairing and the shared-proposal rule for b, amend_pending and revise --settle, attempt-owned result paths with the sealed .bound.md copy, render --all, and the checkpoint/resume --from paragraph. GATE_REPLY_UNPARSED's fix names rec/as-is (DRIVER.md regenerated).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs/capy-install: resolver, versioned store, bun shim, trailer notes; wrapper minimum 2
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): --timeout bounds each runner process again, not the whole lanes check
Lane C made --timeout a deadline for the whole lanes check, so a repo whose
unit group and serial files each fit in 600 s but exceed it together ended
incomplete and blocked /ship. --timeout is per runner process again (unit
group, each serial file); the stall timeout still catches hung or silent
processes. A timed-out process is incomplete naming its last file, and the
next serial file still runs. Regression: three 1.5 s serial files under
--timeout 3 pass; one 5 s file is incomplete.
Files (G2): lib/pregate/checks/lanes.ts, bin/gstack-pregate (help),
docs/pregate.md, test/pregate-supervise.test.ts.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pins): CI exact pins for this platform are alternatives; the installer prefers a non-CI exact pin, else the install default among CI alternatives, else the highest verified (integration item 1)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): clear validates the remote gate receipt; test_backend run URLs are attested
`gstack-pregate clear` accepted any --run-url for a small machine's
obligation. A pregate.json/remote_gate obligation now clears only with
--receipt <file> holding the gate's PREGATE_REMOTE: line, validated as
--remote validates it (tree equals the tested tree, tests > 0, failed = 0;
shared parseRemoteReport/remoteReportProblem); a run URL is usage (exit 2)
and a bad receipt is PREGATE_RECEIPT_INVALID (exit 1, obligation unchanged).
A test_backend/<backend> obligation has no machine-checkable receipt: its
--run-url is recorded as attested:<url> and the output says attested, not
validated. Platform lanes are unchanged. Hints name the right clear form.
New code PREGATE_RECEIPT_INVALID: result-codes row, troubleshooting anchor,
installer-form error line, regenerated doctor components.
Files (G2): lib/pregate/index.ts, lib/pregate/checks/lanes.ts,
bin/gstack-pregate, lib/result-codes.ts, bin/gstack-doctor-components.sh
(generated), docs/pregate.md, docs/troubleshooting.md,
test/pregate-remote.test.ts.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(issue-links): derive this PR's author when gh runs as an app, so handoff and pr-body exclude the owner's own PRs (Lane D fix 1)
The handoff ran gstack-issue-links without --author, and the pr-body step only
asked the agent to pass one, so under Capy's app identity (viewer
`capy-ai[bot]`) the owner's own open PRs were listed as `Related:`. The bin now
derives the author itself: --author, else the gh viewer, else (for a `…[bot]`
viewer) the HEAD commit's GitHub user, else the owner of a user-owned
repository; with none it keeps every PR and reports ISSUE_LOOKUP_FAILED.
`--json` gains `author: {login, source}`; the stderr preview names it. Both ship
steps work unchanged, so the pr-body `--author` clause is dropped (union
309,487 -> 309,435 bytes, under the unchanged 1.6488 cap; skeleton 80,998).
Files: bin/gstack-issue-links, lib/result-codes.ts (ISSUE_LOOKUP_FAILED row),
docs/troubleshooting.md (#issue-lookup-failed), docs/pregate.md,
ship/sections/pr-body.md.tmpl, ship/sections/pr-body.md,
test/helpers/pregate-fixture.ts (gh stub: PR-author query),
test/ship-issue-intent.test.ts.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(wrapper): GSTACK_CAPY_MIN_WRAPPER back to 1; an active wrapper below the minimum is a WARN; gstack-upgrade never leaves a pending marker for the wrapper row and maps every installer stop to a trailer (integration items 2, 9)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(shim): validate and contain store pins, read the 'none' record outside projects and in the checkout, fall back in the resolver's order, stay quiet without a pin; quote baked paths; publish bunx and replace store entries without a window (integration items 3, 4, 6, 9)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(install): --check fails BUN_RESOLUTION_DRIFT only when the recorded Bun is gone, changed or no longer satisfies the pins; a newer candidate is a note and the recorded Bun stays the launch Bun (integration item 5)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(install): one final 'gstack ready (claude, codex)' after both host setups (integration item 7)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): lanes and guards validate the install verdict like admission and return incomplete (INSTALL_UNVERIFIED, BUN_RESOLUTION_DRIFT) before launching; the checkout binds the 'none' verdict (integration item 8)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* docs: CI pin alternatives, shim order and containment, drift note, wrapper WARN, final ready line
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(autoplan): settle after or with a revise, title pairs need the same remedy, legacy gates refuse rec (integration items 1, 7, 8)
1. A gate with a scope change (uc1) and a packaging change (uc2) answered
`rec` deadlocked: after `revise --plan v2 --incorporates uc1` reopened the
phases, `revise --settle uc2` compared against the first phase snapshot
(now undefined) and was refused forever. Settle evidence is now the plan
hash recorded when the owner accepted the change (Amendment.plan_sha256)
or a later plan_revised hash, plus "the plan file has no unrevised edits".
`--settle` may ride the same revise as `--plan/--incorporates` and binds
to the revision's hash. Settling the last amendment after a reopen leaves
the run `running` (the reopened phases rerun) instead of approving it.
NEXT and PLAN_AMEND_PENDING list the settle step before the edit step.
7. A title association alone no longer confirms: the same remedy confirms,
opposite remedies (one keeps, drops or negates what the other changes)
disagree, different or missing remedies stay `unverified`. The pairing
fixture gains same-title negative controls (opposite and different
remedies) and a same-remedy positive, for ordinary findings and user
challenges.
8. A gate.json without rec_rev (written by 1.91.101.0, whose render said
`all` leaves b items pending) refuses rec/all/approve all/`all except`
with GATE_REC_STALE until a re-render binds --rec-hash; explicit tokens
still answer. New gates carry rec_rev: 0.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(autoplan): checkpoints never touch the live run; generations, newest-valid restore, validated staging (integration items 2-6)
2. checkpointRun canonicalizes the collection and the run directory (symlinks
resolved through the deepest existing ancestor) and refuses, before
touching anything, when they are the same or one contains the other
(CHECKPOINT_OVERLAP); restore applies the same check to source, target and
staging. Before, <root>/<run> equal to the live run replaced it.
3. Publication writes an immutable generation (generations/g<revision>-…),
renames it into place complete, then switches current.json with one
rename; the previous generation is kept, so an interruption at the publish
boundary (fault hook checkpoint-before-pointer) leaves the last checkpoint
current. A generation never replaces a newer one (higher run revision):
"CHECKPOINT: skipped … newer". Publication and restore hold the
collection's .lock; restore also holds <out>.lock.
4. Restore checks every listed file's real path stays inside the generation
(an ancestor symlink no longer copies outside files), parses run.json and
runs validateRun on the staged run before publishing; a refusal leaves
--out absent. readState reroots plan_input and plan_source for moved runs,
and a restore with the owner's plan file gone points both at the restored
copy, so a second restore cycle and a later revise work.
5. A checkpoint failure after a committed command prints
"CHECKPOINT: failed for <run>: … ; the command's result stands" on stderr
and keeps the command's exit code.
6. `gstack-autoplan checkpoints --from <dir>` lists generations newest first
(run, gate_rev, status, revision, time, hash ok|bad, current).
`resume --from <collection or root>` restores the newest generation that
verifies, printing each corrupt newer one it skipped; a root holding
several runs must name one.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* chore: budget the Capy skill's autoplan checklist and trim its install notes
Files: capy/skill/gstack/SKILL.md, test/fixtures/context-budget.json (capy/skill/gstack ceiling only: 2364 tok x 1.10)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* chore: release 1.91.102.0 (tentative stamp) — GBRA-40 field list
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test: supply _setup_ready_line to setup-tail harnesses, register the pairing fixture, make the admission test runner-Bun independent; announce shim writes
Files: test/setup-hook-syntax-gate.test.ts, test/redact-prepush-hook.test.ts, test/setup-playwright-best-effort.test.ts, test/helpers/free-fixtures-data.ts, test/pregate-guards.test.ts, bin/gstack-capy-install
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* ci: run quick-bun-default on the ubicloud-standard-8 class the free suite uses
The ubuntu-24.04 runner timed out two Swift typecheck tests at 30 s (render @Observable marker, ios-qa-regen); both pass on Bun 1.4.3 on Ubicloud.
Files: .github/workflows/free-tests.yml
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): read bun test's GitHub Actions group headers; exclude pregate-remote from the Windows subset; give quick-bun-default the free suite's flake policy
Files: lib/pregate/supervise.ts, test/pregate-supervise.test.ts, scripts/lib/windows-curation.ts, .github/workflows/free-tests.yml
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test: run the Capy wrapper and shim doctor-row tests on POSIX only (Git Bash prints MSYS paths)
Files: test/gstack-doctor.test.ts
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* chore: restamp 1.91.107.0 (1.91.106.0 is claimed by #3209)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* fix(pregate): spawn the supervised shell through lib/script-invocation (#3197 tripwire)
The supervisor now resolves bash via bashCommandInvocation, so Windows uses
Git Bash instead of a PATH bash, and an unresolvable bash reports spawn-failed.
guards.ts and lanes.ts no longer spawn bash (they run through supervise.ts),
so their KNOWN_SITES entries are removed.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(qa-functional): disable auto gc and maintenance in the fixture repo
On eval-slices (9), qa-functional-webhook-fix failed mid-run with 100+
'directory watch lost: .git/objects/..' entries and forbidden writes to
.git/info/refs and .git/objects/pack. That is git's detached auto
maintenance repacking the fixture under the write observer. This applies the
same gc.auto=0 / maintenance.auto=false config qa-callers-fixture uses.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
* test(autoplan-guard-pty): say Phase 2 starts without waiting for user input
On eval-slices (1), haiku published Phase 1 and then ended its turn with
'Waiting for next invocation to continue with step 8'. Step 5 tells it to end
its turn while the reviewer runs, so step 8's 'In a later message' read as a
later user turn. Phase 2 never started, the guard logged 2 of the 4 expected
allows, and the run hit its deadline. Step 8 now says to continue in the next
assistant message, still separate from the step 7 publication message.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
---------
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
694 lines
34 KiB
Cheetah
694 lines
34 KiB
Cheetah
---
|
||
name: ship
|
||
preamble-tier: 4
|
||
version: 1.0.0
|
||
description: |
|
||
Ship workflow: detect + merge base branch, run tests, review diff, bump VERSION,
|
||
update CHANGELOG, commit, push, create PR. Use when asked to "ship", "deploy",
|
||
"push to main", "create a PR", "merge and push", or "get it deployed".
|
||
Proactively invoke this skill (do NOT push/PR directly) when the user says code
|
||
is ready, asks about deploying, wants to push code up, or asks to create a PR. (gstack)
|
||
allowed-tools:
|
||
- Bash
|
||
- Read
|
||
- Write
|
||
- Edit
|
||
- Grep
|
||
- Glob
|
||
- Agent
|
||
- AskUserQuestion
|
||
- WebSearch
|
||
sensitive: true
|
||
triggers:
|
||
- ship it
|
||
- create a pr
|
||
- push to main
|
||
- deploy this
|
||
---
|
||
|
||
{{PREAMBLE}}
|
||
|
||
{{THIRD_PARTY_ACTIONS}}
|
||
|
||
# Ship: Fully Automated Ship Workflow
|
||
|
||
STOP blocks advancement until the stated repair/resume route clears; without one, end this attempt.
|
||
Answer each AskUserQuestion before continuing.
|
||
Routine authorization never waives those gates or their required user decisions.
|
||
|
||
**Routine work needs no confirmation:** include uncommitted changes, choose MICRO/PATCH
|
||
under Step 12, draft CHANGELOG and commits, mark completed TODOs and auto-fix findings.
|
||
When Step 7 coverage meets its target, report remaining gaps and verify generated
|
||
tests without asking again. Step 15 commits those tests.
|
||
|
||
**Route:** integrate (1–3) → test and review (4–11.5) → prepare the release
|
||
(12–15) → verify frozen content (16) → push and publish (17–21).
|
||
Every new invocation repeats Steps 1–16, including both reviews and the docs audit.
|
||
Steps 12, 17 and 19 prevent duplicate bumps, pushes and PRs, never verification.
|
||
|
||
### Keep state between steps
|
||
|
||
Keep one private Markdown **invocation record** outside the product tree and save
|
||
its absolute path, with these headings so a paused run can resume:
|
||
- **Release:** versions, `BUMP_LEVEL`, reviewed tree and attempt counts.
|
||
- **Decisions:** each approval's finding, files and authorized action. Reuse it only
|
||
for that same scope; a repair never resets or expands approvals.
|
||
- **Reviews:** handles, original start tokens, terminal states, outputs and queued fixes.
|
||
- **Checks:** command/label, result/counts, timestamp, log and consumed inputs.
|
||
- **Documentation:** candidate/id, attempts used, accepted hashes or named blocked exception.
|
||
- **Next steps:** one ordered work list, with the current step marked.
|
||
|
||
A **receipt** is saved evidence of a check's command, result and consumed content.
|
||
A review's **start token** is the opaque value returned by `gstack-review-log --start`
|
||
before it reads the diff. Keep `REVIEW_START` for Step 9, a separate `PASS_START` for
|
||
each Step 11 attempt, and `DESIGN_START` for design. Finish each pass with its original
|
||
token; `--finish` stamps the binding fields automatically. Never borrow or replace a token.
|
||
`gstack-wtree` prints a Git tree hash covering tracked and non-ignored untracked files,
|
||
not a commit ID. Use `git diff <old-tree> <new-tree>` to compare these snapshots.
|
||
|
||
### Ship control flow
|
||
|
||
You, the **parent** running /ship, own advancement; children return evidence, not
|
||
permission to proceed. Follow the saved work list:
|
||
|
||
1. Start with Steps 1–21 in order, including 6.5, 11.5 and 14.5. Advance only after
|
||
the current item's gates clear.
|
||
2. Expand a repair into individual steps and insert them before the still-pending
|
||
work. This replaces the current item, whose result stays in the record.
|
||
Add its destination only if not already the next pending step.
|
||
3. For another repair, repeat rule 2 without discarding pending work.
|
||
The saved list outranks ordinary next-step sentences inside a repair.
|
||
A range never adds unlisted steps.
|
||
|
||
**Example:** Step 11 fixes insert `9 → 10 → 11` before 11.5. A further Step 9 fix
|
||
affecting 6–8 makes the list `5 → 6 → 7 → 8 → 9 → 10 → 11 → 11.5`.
|
||
The unchanged release steps follow. STOP and AskUserQuestion gates still apply during repairs.
|
||
|
||
Keep the same attempt counts throughout the invocation. A range ending at Step 14
|
||
does not enter Step 14.5. A range including Step 14.5 enters its existing audit
|
||
decision, not an unconditional new launch; its initial-plus-ONE limit never resets.
|
||
Permitted repairs continue in this invocation without restarting /ship.
|
||
|
||
---
|
||
|
||
{{SECTION_INDEX:ship}}
|
||
|
||
---
|
||
|
||
{{BASE_BRANCH_DETECT}}
|
||
|
||
`<base>` means the detected branch name for fetch/helper arguments;
|
||
`origin/<base>` is its remote-tracking ref for comparisons. Step 1 fetches it.
|
||
|
||
{{GBRAIN_CONTEXT_LOAD}}
|
||
|
||
## Step 0.9: Apple target detection
|
||
|
||
If the ask is App Store/TestFlight distribution, look for an `.xcodeproj`,
|
||
`.xcworkspace`, or Swift app product. Read `Package.swift` and its entrypoint to
|
||
distinguish an app from a library/CLI. If unclear, AskUserQuestion to identify
|
||
the target and wait before choosing a release path.
|
||
For a confirmed app, **STOP and Read
|
||
`~/.claude/skills/gstack/ship/sections/apple-release.md` FIRST**. Store distribution proceeds
|
||
through that adapter from the current branch, including a clean base branch.
|
||
The branch gate and repository-landing pipeline below apply ONLY to
|
||
repository-landing asks, including on Apple repos.
|
||
|
||
## Step 1: Pre-flight
|
||
|
||
1. Save the current branch as `<branch-name>`. If on the base branch or the repo's default branch, **abort**: "You're on the base branch. Ship from a feature branch."
|
||
|
||
2. Run `git status` (never `-uall`). Uncommitted changes are always included; do not ask.
|
||
|
||
3. Run `git fetch origin <base>` before inspecting the diff. If fetch fails, STOP:
|
||
report the error and restore access first. Then inspect
|
||
`git diff origin/<base> --stat`, untracked files from status, and
|
||
`git log origin/<base>..HEAD --oneline`.
|
||
|
||
4. Display historical readiness using the dashboard below, then finish Step 1.
|
||
Prior CLEAR reviews or dashboard skips never replace Step 9's gates.
|
||
|
||
{{REVIEW_DASHBOARD}}
|
||
|
||
An outside review with status `unverified` or `unavailable` is missing coverage, never a pass.
|
||
|
||
For diffs >200 lines (`git diff origin/<base> --stat | tail -1`), recommend
|
||
`/plan-eng-review` or `/autoplan`.
|
||
|
||
For Design Review: run `source <(~/.claude/skills/gstack/bin/gstack-diff-scope <base> 2>/dev/null)`. If `SCOPE_FRONTEND=true` and no design review exists, mention: "Design Review not run — Step 9 includes the lite check; consider /design-review for a full visual audit."
|
||
|
||
Continue to Step 2 without asking; Step 9 applies the review gates.
|
||
|
||
---
|
||
|
||
## Step 2: Distribution Pipeline Check
|
||
|
||
Check distribution for new standalone artifacts (CLI binaries, packages, tools),
|
||
not web services already deployed.
|
||
|
||
1. List candidate distribution paths:
|
||
```bash
|
||
git diff origin/<base> --diff-filter=A --name-only | grep -E '(^|/)(cmd/[^/]+/main\.go|bin/[^/]+|Cargo\.toml|setup\.py|package\.json)$' | head -5
|
||
```
|
||
Include matching untracked files from Step 1's status. Read each match:
|
||
a new `package.json` or `Cargo.toml` alone is not a publishable artifact;
|
||
also check existing manifests for newly declared binaries or package
|
||
exports. Gate only when a new distributable is present.
|
||
|
||
2. If new artifact detected, check for a release workflow:
|
||
```bash
|
||
ls .github/workflows/ 2>/dev/null | grep -iE 'release|publish|dist'
|
||
grep -qE 'release|publish|deploy' .gitlab-ci.yml 2>/dev/null && echo "GITLAB_CI_RELEASE"
|
||
```
|
||
|
||
3. **New artifact without a pipeline:** AskUserQuestion: "Users cannot download this
|
||
artifact after merge without a release pipeline."
|
||
- A) Add the platform's release workflow now
|
||
- B) Defer with a P1 distribution TODO in Step 14
|
||
- C) Not needed: internal/web-only, covered by existing deployment
|
||
|
||
4. **If A:** Add packaging/publish configuration using repository CI conventions.
|
||
Ask for unknown targets, registries or access first; never invent credentials.
|
||
Recheck against the artifact and include the workflow in tests and review.
|
||
Do not publish a release during `/ship`.
|
||
5. Otherwise continue without a pipeline.
|
||
|
||
---
|
||
|
||
## Step 3: Merge the base branch (BEFORE tests)
|
||
|
||
Merge the base ref fetched in Step 1 so tests and reviews cover the integrated code:
|
||
|
||
```bash
|
||
git merge origin/<base> --no-edit
|
||
```
|
||
|
||
**Merge conflicts:** Auto-resolve simple ones (VERSION, schema.rb, CHANGELOG ordering). For complex or ambiguous conflicts, **STOP**, show the conflicting choices, use AskUserQuestion for the resolution, and wait for the answer before editing or continuing.
|
||
|
||
**If already up to date:** Continue silently.
|
||
|
||
**Ship policy:** `~/.claude/skills/gstack/bin/gstack-ship-policy show-effective --base <base>`
|
||
(docs/ship-policy.md); its `ship:` lines bind Steps 12, 16 and history.
|
||
|
||
If integration changes the artifact or distribution configuration inspected in Step 2,
|
||
repeat Step 2 (decisions included) on the merged content, then Step 4.
|
||
|
||
---
|
||
|
||
{{SECTION:tests}}
|
||
|
||
{{SECTION:greptile-early}}
|
||
|
||
{{SECTION:test-coverage}}
|
||
|
||
{{SECTION:plan-completion}}
|
||
|
||
{{SECTION:review-army}}
|
||
|
||
{{SECTION:greptile}}
|
||
|
||
{{SECTION:adversarial}}
|
||
|
||
## Step 11.5: Bind the reviews
|
||
|
||
1. **Select the two reviews.** Run `~/.claude/skills/gstack/bin/gstack-review-read`.
|
||
Select this invocation's final Step 9.4 record (`skill:"review"`, `via:"ship"`)
|
||
and Step 11 native record (`skill:"adversarial-review"`). Match each to its saved
|
||
handle, original token and source; reject outside-provider or older records.
|
||
2. **Compare their content.** Require the native record's `review_binding.state`
|
||
to be `verified`. All three snapshots must match: its `wtree`, Step 9.4's
|
||
`review_binding.start_wtree` and `review_binding.end_wtree`. A mismatch or missing
|
||
record/field blocks release preparation: report **Review records missing or mismatched**
|
||
and insert `9 → 10 → 11 → 11.5` before Step 12. Bind the new records at 11.5.
|
||
Never attach new tokens to old work.
|
||
3. **Preserve any QA exception.** A named probe-risk exception may leave Step 9.4's
|
||
root `wtree` absent; item 2 still compares its start/end snapshots. Matching content
|
||
does not mean failed or unrun probes passed. Keep Step 9.4's incomplete flags
|
||
and the user's exception.
|
||
4. **Save the evidence.** Save both records and matching **reviewed tree** for
|
||
Step 16. Continue to Step 12.
|
||
|
||
## Step 12: Version bump (auto-decide)
|
||
|
||
Item 3 needs `BUMP_LEVEL`: reuse this invocation's saved level. Otherwise FRESH
|
||
chooses it in item 2 and ALREADY_BUMPED derives it in item 1.
|
||
|
||
`ship: queue_mode stamp-at-merge` replaces items 1–4.
|
||
|
||
1. **Classify state** — pure reader, never writes:
|
||
```bash
|
||
bun run ~/.claude/skills/gstack/bin/gstack-version-bump classify --base <base>
|
||
```
|
||
Save the JSON `baseVersion` as `BASE_VERSION`, then read `state` and dispatch:
|
||
- **FRESH** → use the recorded level or choose it in item 2, then check the queue and write.
|
||
- **ALREADY_BUMPED** → keep `NEW_VERSION=currentVersion`. If `BUMP_LEVEL` is missing,
|
||
use the first changed component from `baseVersion` to `currentVersion`
|
||
(major/minor/patch/micro; an absent fourth component is zero). Continue at item 3,
|
||
not another automatic bump.
|
||
- **DRIFT_STALE_PKG** → run `gstack-version-bump repair`, then reclassify.
|
||
Success follows ALREADY_BUMPED, including its queue check; failure stops.
|
||
Repair alone never re-bumps.
|
||
- **DRIFT_UNEXPECTED** → STOP: package.json disagrees with VERSION while VERSION
|
||
matches base. Reconcile the manual edit, then reclassify.
|
||
- **NO_VERSION** → print `notice` verbatim and ship without a version change: skip
|
||
the rest of Step 12 and Step 13's CHANGELOG entry, never create VERSION, use an
|
||
unprefixed title in Step 18 and log `"version":null` in Step 20.
|
||
- **Exit 2** → STOP and show stderr: a configured version file is missing, empty,
|
||
unreadable or malformed. Fix it or its pin, then reclassify. Never substitute `0.0.0.0`.
|
||
|
||
2. **Decide the bump level** from the diff (agent judgment):
|
||
- **MICRO**: <50 lines, trivial tweaks/config. **PATCH**: 50+ lines, no feature signal.
|
||
- **MINOR**: ask for any feature signal (new route/page, migration, module) or 500+ lines.
|
||
**MAJOR**: ask for milestones or breaking changes (`ship: bump patch` never asks).
|
||
AskUserQuestion: recommended level with rationale, smaller level, or cancel.
|
||
Wait; cancel stops before release writes or push and preserves existing work.
|
||
Save lowercase `BUMP_LEVEL`. A claimed version may move the next available number
|
||
forward, but cannot change the chosen MICRO/PATCH/MINOR/MAJOR level.
|
||
|
||
3. **Queue-aware pick** (workspace-aware ship):
|
||
```bash
|
||
QUEUE_JSON=$(bun run ~/.claude/skills/gstack/bin/gstack-next-version --base <base> --bump "$BUMP_LEVEL" --current-version "$BASE_VERSION" 2>/dev/null || echo '{"offline":true}')
|
||
CANDIDATE_VERSION=$(echo "$QUEUE_JSON" | jq -r '.version // empty')
|
||
```
|
||
**Qualify first:** require successful utility output and a nonempty valid version.
|
||
`offline:false` qualifies; `offline:true` qualifies only with `fallback:"git"`.
|
||
Offline output without that fallback, failure, malformed output or an empty version
|
||
is unusable, even when it contains a version-looking string.
|
||
|
||
- **Usable candidate:** print warnings and claimed queue. FRESH sets `NEW_VERSION=CANDIDATE_VERSION`.
|
||
ALREADY_BUMPED compares it with `currentVersion`: if different, ask to rebump
|
||
(refresh CHANGELOG/PR title) or keep current (CI rejects a collision).
|
||
Only approval changes the existing version. Check JSON `active_siblings` by
|
||
`branch` and `version`; a sibling holding `>= NEW_VERSION` requires a choice:
|
||
advance past it, or stop this attempt and sync.
|
||
- **No usable candidate:** print queue-unverified. FRESH uses local `BUMP_LEVEL`
|
||
arithmetic; ALREADY_BUMPED keeps `currentVersion`. Never use an empty candidate.
|
||
|
||
4. **Write the bump** (FRESH, or an approved rebump):
|
||
```bash
|
||
bun run ~/.claude/skills/gstack/bin/gstack-version-bump write --version "$NEW_VERSION" --regen-digest
|
||
```
|
||
The CLI validates `MAJOR.MINOR.PATCH.MICRO` (or pinned 3-digit semver), writes
|
||
VERSION, the manifest (`--package-json-path` → `.gstack/package-json-path` →
|
||
`./package.json`) and existing npm lockfiles, never creating one, with the 3-digit
|
||
translation (`1.67.0.0` → `1.67.0`); VERSION is authoritative. Exit 3 is a half-write:
|
||
reclassify and `repair` DRIFT_STALE_PKG.
|
||
|
||
`--regen-digest` runs repo code (`scripts/gen-agents-digest.ts`) with Step 5's privileges
|
||
only when it and committed `agents-digest/gstack-AGENTS.md` exist; if `agentsDigest` is
|
||
false, run `bun scripts/gen-agents-digest.ts` and stage the digest with the bump. Before
|
||
push, verify the committed digest matches generation for the selected VERSION.
|
||
|
||
5. **Record the release decision after a version was written**, including
|
||
an approved ALREADY_BUMPED rebump. Skip unchanged versions and manifest-only repairs.
|
||
```bash
|
||
~/.claude/skills/gstack/bin/gstack-decision-log '{"decision":"Ship NEW_VERSION (BUMP_LEVEL)","rationale":"WHY","scope":"repo","source":"skill","confidence":9}' 2>/dev/null || true
|
||
```
|
||
Substitute `NEW_VERSION`, `BUMP_LEVEL` and a one-line `WHY` (scope or breaking-change signal); best-effort.
|
||
|
||
{{SECTION:changelog}}
|
||
|
||
## Step 14: TODOS.md (auto-update)
|
||
|
||
Read `~/.claude/skills/gstack/review/TODOS-format.md`.
|
||
|
||
**1. Open or create:** Read root `TODOS.md`. An explicit "add TODO" choice authorizes
|
||
creation with `# TODOS` and `## Completed`. Otherwise, if missing, ask: A) Create
|
||
a component/priority-organized TODOS.md, B) Skip. Skip goes to item 5.
|
||
|
||
**2. Organization:** Use component headings, `**Priority:**` P0–P4 and `## Completed`
|
||
at the bottom. If disorganized, ask: A) Reorganize preserving all content
|
||
(recommended), B) Leave as-is.
|
||
|
||
**3. Add approved deferrals:**
|
||
- Step 2: add the approved distribution follow-up as P1 with the missing pipeline and affected artifact.
|
||
- Step 8: add each approved P1 plan deferral with `Deferred from plan: {plan file path}` and the missing work.
|
||
- Step 5: retain P0 test-failure entries already written; deduplicate by failure and source, adding missing approved entries with error output and branch.
|
||
Never turn dropped scope into TODOs or invent unapproved follow-ups. Reuse matching entries instead of duplicating them.
|
||
|
||
**4. Detect completed TODOs:** Compare titles, files and behavior with
|
||
`git diff origin/<base>`, untracked files and `git log origin/<base>..HEAD --oneline`.
|
||
Move proven completions to `## Completed` with `**Completed:** vX.Y.Z (YYYY-MM-DD)`;
|
||
leave uncertain items open.
|
||
|
||
**5. Save the summary:** Report additions, deferrals, completions, remaining count and
|
||
creation/reorganization. If creation was declined or a write failed, warn and carry
|
||
unsaved follow-ups in Step 19's PR summary; never claim they were saved. TODO
|
||
write failures are non-blocking.
|
||
|
||
---
|
||
|
||
## Step 14.5: Documentation audit (every ship)
|
||
|
||
**Doc-sync invariant:** Every ship dispatches the /document-release subagent before final
|
||
commit/verification/publication, including reruns, already-pushed branches, existing PRs and docs-only changes.
|
||
No edits means an executed audit, not a skip; report the section's verified outcome.
|
||
|
||
{{SECTION:documentation}}
|
||
|
||
## Step 15: Commit (bisectable chunks)
|
||
|
||
Make bisectable commits; if already committed, continue to Step 16. Never create an empty commit.
|
||
|
||
1. Group changes with their tests, config/routes, views and Step 14.5 docs;
|
||
migrations may stand alone. Under 50 lines across fewer than 4 files may be one commit.
|
||
2. Order dependencies first: infrastructure → models/services → controllers/views.
|
||
Each commit works alone (no broken imports or missing code).
|
||
Group VERSION + CHANGELOG + TODOS.md after the feature commits.
|
||
3. Use `<type>: <summary>` (feat/fix/chore/refactor/docs) and a brief body; fixing a
|
||
user-named issue adds a `Fixes: #<n>` trailer. Only the final
|
||
VERSION/CHANGELOG commit gets the release version and co-author trailer. No Git tag:
|
||
|
||
```bash
|
||
git commit -m "$(cat <<'EOF'
|
||
chore: bump version and changelog (vX.Y.Z.W)
|
||
|
||
{{CO_AUTHOR_TRAILER}}
|
||
EOF
|
||
)"
|
||
```
|
||
|
||
---
|
||
|
||
## Step 16: Verification Gate
|
||
|
||
**IRON LAW: NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE.**
|
||
|
||
Run stages 1–5 in order; recovery notes below name where to resume. Content
|
||
changes during or after verification restart at stage 1 and complete all five
|
||
stages before Step 17. Content-preserving commits keep evidence valid.
|
||
|
||
### 1. Finish writers and prepare outputs
|
||
|
||
Inspect writer handles, including the docs child. Confirm terminal completion or
|
||
termination before another writer runs; timeout or cancellation acknowledgment
|
||
alone means STOP until confirmed.
|
||
|
||
Find declared generation/build commands in project instructions, manifests, build
|
||
files and CI. Run them and save results. If none exists, record not applicable and
|
||
the inspected sources. A missing prerequisite or failed build stops shipping:
|
||
report **Build failed or prerequisite missing**, with the command, error and needed
|
||
repair. Never invent a substitute command.
|
||
**If blocked:** Repair it, then repeat stage 1. After it passes, continue
|
||
to stage 2; treat any content repair as a behavioral change there.
|
||
|
||
### 2. Choose the change route
|
||
|
||
Capture the current tree with `~/.claude/skills/gstack/bin/gstack-wtree`. Inspect
|
||
`git diff <reviewed-tree> <current-tree>` against the snapshot saved before Step 12.
|
||
Missing snapshots block this comparison, regardless of HEAD equality.
|
||
|
||
Classify the comparison in this order:
|
||
|
||
1. **Behavior, tests or build inputs changed:** Prompts/templates count as behavior.
|
||
Insert `5–11.5 → 12–14 → 16` before the pending Step 17, then stop this step.
|
||
This repair excludes Step 14.5 because the rebuild can change generated docs.
|
||
Step 16 restarts at stage 1: rebuild and compare again before stage 3 decides
|
||
documentation freshness. Further repairs use the same work list.
|
||
2. **Only authored docs or release metadata changed:** Keep Step 8's original child
|
||
report and counts. Recheck affected plan items using their recorded verification
|
||
and append current evidence to the invocation record. If a classification is no
|
||
longer supported, run Step 8's audit and decision gates only, then return to
|
||
Step 16 stage 1. Never edit the child's counts yourself.
|
||
3. **No changes, or the docs-only checks still support the plan:** Continue to stage 3
|
||
without a new code review.
|
||
|
||
### 3. Resolve documentation freshness
|
||
|
||
Compare the base and hashes of the selected release paths, generated
|
||
outputs and docs/templates with Step 14.5's saved values. A prior invocation's
|
||
audit or risk decision never qualifies.
|
||
|
||
| Outcome | Action |
|
||
|---|---|
|
||
| This invocation's accepted audit matches all inputs | Continue to stage 4. |
|
||
| User-accepted named documentation risk covers the same approved scope and exact content, and unwaivable gates clear | Continue to stage 4; retain `Documentation: blocked`, its reason and incomplete scope. |
|
||
| Missing, stale or blocked | Use recovery below. Never silently refresh hashes. |
|
||
|
||
Report changed inputs, blockers and attempts used:
|
||
|
||
- **An attempt remains, with changed inputs or an available repair:** insert
|
||
`14.5 → 15 → 16` before Step 17. Use Blocked recovery with the existing count.
|
||
Validate the outcome before Step 15, then restart Step 16 stage 1.
|
||
- **Otherwise:** STOP unless the user accepts
|
||
the specific named documentation risk and all unwaivable gates clear, under
|
||
Step 14.5's Blocked recovery rules. Unchanged approved content goes to stage 4;
|
||
repaired content goes to stage 1.
|
||
|
||
Never run a third audit. Child return is not acceptance.
|
||
|
||
### 4. Verify the frozen candidate
|
||
|
||
Freeze inputs through verification and push. Run declared docs/link/generated-file
|
||
checks; report any that are unavailable.
|
||
|
||
**Reuse a check when its inputs match.** Compare hashes or complete bytes of its
|
||
saved and current consumed files, fixtures, dependencies and execution parameters.
|
||
Changed or unknown dependencies require a rerun. For model judges, compare the complete
|
||
expanded request, rubric, parameters and builder/runtime dependencies. Cite the original
|
||
command, result/counts, timestamp and log, never resample. Mandatory reviews still run.
|
||
|
||
**Check each test lane's receipt as well.** Use its actual Step 5 label/command:
|
||
`--label <lane> --expect-cmd '<exact Step 5 command>'`. Inspect changes since the run;
|
||
`--allow-paths` exempts only release metadata. A `package.json` version-only edit
|
||
can qualify; scripts, dependencies and runtime configuration require live tests.
|
||
Uncertain edits cannot be exempted. Docs, TODO edits, new/generated tests and fixes
|
||
make evidence STALE even without a new code review. Use this example only once
|
||
every allowed edit is release metadata:
|
||
|
||
```bash
|
||
~/.claude/skills/gstack/bin/gstack-evidence check --label tests --expect-cmd '<tests>' --label vitest --expect-cmd '<vitest>' --max-age 24 --allow-paths CHANGELOG.md,VERSION,package.json,agents-digest/gstack-AGENTS.md
|
||
```
|
||
|
||
| Receipt result | Next action |
|
||
|---|---|
|
||
| FRESH (exit 0) | Cite the label, exit, timestamp, log and `tests_ran`. |
|
||
| STALE/MISSING: changed content, command or age, or no proven run | Run `~/.claude/skills/gstack/bin/gstack-evidence run --label <lane> -- '<command>'`, read the result and recheck once. Handle failures as described below. |
|
||
| ZERO-RUN: the receipt's `tests_ran` is 0 | STALE-equivalent: the lane proved nothing. Use Step 5's ZERO-RUN triage (a failed lane), never FRESH, even with exit 0. |
|
||
| `tests_ran: unknown` | Non-blocking: keep the exit-0 verdict, cite the lane as `count unavailable`. Never record it as ZERO-RUN or as a counted pass. |
|
||
| Only receipt storage/readback failed | Independently prove unchanged final content, the same command and valid age from the successful run's evidence. Cite its exact command, exit, timestamp and log as **ledger unavailable**, never FRESH. Without that proof, use STALE/MISSING. |
|
||
|
||
No test lanes: require Step 5's explicit untested-scope approval for final content,
|
||
or run Steps 5–15, including the no-tests decision, then return to Step 16 stage 1.
|
||
Report the gap, never FRESH; builds must pass.
|
||
|
||
**New, changed or unwaived test failure:** STOP publication. Run Steps 5–15,
|
||
starting with Step 5's triage, then return to Step 16 stage 1. This recovery also
|
||
applies if a failure appears while reporting in stage 5. Reentry to Step 14.5
|
||
keeps its existing audit count; it does not authorize a third attempt.
|
||
|
||
### 5. Report, then push
|
||
|
||
Commit only approved, verified release changes left uncommitted after Step 15,
|
||
including generated outputs; use its grouping rules; never create an empty commit.
|
||
Preserve unrelated user files.
|
||
|
||
Paste build/docs/test results. Reuse waivers only for the same verified
|
||
pre-existing failures and approved scope; cite the actual approval and failing
|
||
counts, never FRESH or all-green. A new, changed or unwaived test failure uses
|
||
stage 4's recovery before publication.
|
||
|
||
Then the honesty inventory, two lines, from Step 9's latest `Gate edits:` line and
|
||
its records:
|
||
- For each gate finding: `gate`, path, disposition (`kept`/`restored`/`open`),
|
||
`reason` and logger-stamped `actor`. If there are none, the coverage line
|
||
(`none detected (...)`, `partial (...)` or `UNAVAILABLE — ...`).
|
||
- Each test lane's `tests_ran` (N, ZERO-RUN or `count unavailable`).
|
||
Write this report in the auditor's posture: this session's own gate edits are
|
||
evidence for the reader to examine, not positions to defend; a kept gate
|
||
states its reason and nothing more. Otherwise continue to Step 17.
|
||
|
||
---
|
||
|
||
## Step 17: Push
|
||
|
||
**Credential pre-push guard — run before the push:**
|
||
|
||
```bash
|
||
_REDACT_PREPUSH=$(~/.claude/skills/gstack/bin/gstack-config get redact_prepush_hook 2>/dev/null || echo "false")
|
||
_HOOK_PATH=$(git rev-parse --git-path hooks/pre-push 2>/dev/null || echo "")
|
||
_HOOK_STATE="missing"
|
||
if [ -e "$_HOOK_PATH" ] || [ -L "$_HOOK_PATH" ]; then
|
||
_HOOK_STATE="unmanaged"
|
||
if [ -f "$_HOOK_PATH" ] && [ ! -L "$_HOOK_PATH" ] && grep -Fqx '# gstack-redact pre-push (managed)' "$_HOOK_PATH" 2>/dev/null; then
|
||
_HOOK_STATE="managed"
|
||
fi
|
||
fi
|
||
_HOOKS_DIR=$(git rev-parse --git-path hooks 2>/dev/null || echo "")
|
||
_HOOKS_IN_GIT_DIR="no"
|
||
_HOOKS_CONFIG_STATUS=0
|
||
git config --get core.hooksPath >/dev/null 2>&1 || _HOOKS_CONFIG_STATUS=$?
|
||
if [ -n "$_HOOK_PATH" ] && [ -n "$_HOOKS_DIR" ] && [ "$_HOOKS_CONFIG_STATUS" = "1" ] && [ ! -L "$_HOOKS_DIR" ]; then
|
||
_HOOKS_IN_GIT_DIR="yes"
|
||
fi
|
||
GSTACK_STATE_ROOT=$(~/.claude/skills/gstack/bin/gstack-paths --get GSTACK_STATE_ROOT); : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
||
_PREPUSH_PROMPTED=$([ -f "$GSTACK_STATE_ROOT/.redact-prepush-prompted" ] && echo "yes" || echo "no")
|
||
if [ "$_REDACT_PREPUSH" = "true" ] && [ "$_HOOKS_IN_GIT_DIR" = "yes" ] && [ "$_HOOK_STATE" != "unmanaged" ]; then
|
||
~/.claude/skills/gstack/bin/gstack-redact install-prepush-hook || exit $?
|
||
fi
|
||
echo "REDACT_PREPUSH: $_REDACT_PREPUSH"
|
||
echo "HOOK_STATE: $_HOOK_STATE"
|
||
echo "HOOKS_IN_GIT_DIR: $_HOOKS_IN_GIT_DIR"
|
||
echo "PREPUSH_PROMPTED: $_PREPUSH_PROMPTED"
|
||
```
|
||
|
||
Branch on the echoed values:
|
||
|
||
1. **`REDACT_PREPUSH: true`** — the block installs or refreshes managed
|
||
hooks, preserving `pre-push.local` and complete stdin. On installer
|
||
failure, STOP before pushing. `HOOKS_IN_GIT_DIR: no`: do not install;
|
||
request manual integration. `HOOK_STATE: unmanaged`: ask consent only
|
||
for a regular, non-symlink hook in the default directory without
|
||
`pre-push.local`; otherwise request manual integration. Dangling
|
||
symlinks are unmanaged. Never overwrite either policy.
|
||
2. **`REDACT_PREPUSH` not true AND `PREPUSH_PROMPTED: no`** — one-time
|
||
offer (once ever, machine-wide). AskUserQuestion:
|
||
|
||
> gstack can install a per-repo git pre-push hook that blocks pushes
|
||
> containing credentials (API keys, tokens, private keys). It's a
|
||
> guardrail, not enforcement — `GSTACK_REDACT_PREPUSH=skip` bypasses it.
|
||
> Install it for repos you ship from?
|
||
|
||
Options:
|
||
- A) Yes — install the credential guard (recommended)
|
||
- B) No — never ask again
|
||
|
||
If A: run `~/.claude/skills/gstack/bin/gstack-config set redact_prepush_hook true`
|
||
then re-run the block and apply the same directory and unmanaged-hook rules above.
|
||
If B: run `~/.claude/skills/gstack/bin/gstack-config set redact_prepush_hook false`.
|
||
ALWAYS after either answer (never after a failed question; it must re-offer
|
||
next time):
|
||
```bash
|
||
GSTACK_STATE_ROOT=$(~/.claude/skills/gstack/bin/gstack-paths --get GSTACK_STATE_ROOT); : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
||
touch "$GSTACK_STATE_ROOT/.redact-prepush-prompted"
|
||
```
|
||
3. **Declined earlier** — continue without comment.
|
||
|
||
**Open gate findings against an existing ready PR/MR:** when Step 9 left a gate
|
||
finding `open`, look up an open PR/MR for `<branch-name>` before pushing
|
||
(`gh pr list --head <branch-name> --state open --json number,isDraft`; GitLab
|
||
`glab mr list --source-branch <branch-name> --output json`, reading `draft`). A lookup
|
||
failure STOPs here. If one exists and is not a draft:
|
||
|
||
1. The preamble echoed `SESSION_KIND: spawned` or `headless`: **STOP before pushing.**
|
||
Report the open gate findings (`gate`, path) and the PR/MR; no push, no
|
||
publication claim. A later human dispositions them.
|
||
2. Otherwise AskUserQuestion once: A) Resolve the open items now — insert `9 → 10 →
|
||
11 → 11.5 → 12 → 13 → 14 → 14.5 → 15 → 16` before Step 17; B) Publish ready with
|
||
the `Gate edits: N open` banner. Record B in the invocation record as a
|
||
human-authorised publication; Step 19 reads it. Never convert a ready PR to a draft.
|
||
|
||
A new PR or an existing draft needs no question: Step 19 creates or keeps the draft.
|
||
|
||
**Idempotency check:** Check if the branch is already pushed and up to date.
|
||
|
||
```bash
|
||
LOCAL=$(git rev-parse HEAD) || exit 1
|
||
REMOTE_REF=$(git ls-remote --heads origin refs/heads/<branch-name>) || {
|
||
echo "STATUS: BLOCKED — cannot verify remote branch; restore access before pushing"
|
||
exit 1
|
||
}
|
||
REMOTE=$(printf '%s\n' "$REMOTE_REF" | awk '{print $(1)}')
|
||
REMOTE=${REMOTE:-none}
|
||
echo "LOCAL: $LOCAL REMOTE: $REMOTE"
|
||
[ "$LOCAL" = "$REMOTE" ] && echo "ALREADY_PUSHED" || echo "PUSH_NEEDED"
|
||
```
|
||
|
||
`ALREADY_PUSHED`: skip the push, continue to Step 18. Otherwise push with upstream tracking:
|
||
|
||
```bash
|
||
git push -u origin <branch-name>
|
||
```
|
||
|
||
**If the push fails, STOP.** No Step 19 or publication claim. Report the error:
|
||
- **Non-fast-forward push:** fetch and inspect the remote, then merge under Step 3's
|
||
conflict rules. Run Steps 5–16 before returning to Step 17. Never rewrite history.
|
||
- **Authentication, hook or network failure:** repair the cause, then repeat Step 16
|
||
even with unchanged content before returning to Step 17. Never bypass failed guards.
|
||
Never force-push. Only a successful push or verified `ALREADY_PUSHED` proceeds.
|
||
|
||
Continue to Step 18. No documentation writer runs after push.
|
||
|
||
---
|
||
|
||
## Step 18: Prepare publication metadata
|
||
|
||
First look up open PRs/MRs for `<branch-name>` on the detected platform:
|
||
|
||
- GitHub: `gh pr list --head <branch-name> --state open --json number,title,url`
|
||
- GitLab: `glab mr list --source-branch <branch-name> --output json` (defaults to open).
|
||
|
||
An empty array means new; one match supplies the existing title/identity.
|
||
Lookup failure or ambiguous matches **STOP** for resolution, never mean no PR.
|
||
Save the result for Step 19's recheck.
|
||
|
||
The pr-body section prepares the title from that result, then publishes;
|
||
`--no-pr` or an automation lane takes the handoff section.
|
||
|
||
{{SECTION:pr-body}}
|
||
|
||
{{SECTION:handoff}}
|
||
|
||
## Step 20: Persist ship metrics
|
||
|
||
Log metrics for `/retro` through `gstack-review-log`; it handles project/branch paths,
|
||
JSON validation, storage and sync and takes **no path argument**.
|
||
|
||
```bash
|
||
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"ship","timestamp":"'"$(date -u +%Y-%m-%dT%H:%M:%SZ)"'","coverage_pct":COVERAGE_PCT,"coverage_schema":2,"coverage_pct_value":COVERAGE_PCT_VALUE,"weak_gaps":WEAK_GAPS,"tests_extended":TESTS_EXTENDED,"tests_rejected":TESTS_REJECTED,"regression_proof":REGRESSION_PROOF,"plan_items_total":PLAN_TOTAL,"plan_items_done":PLAN_DONE,"verification_result":"VERIFY_RESULT","version":"VERSION","branch":"'"$(git rev-parse --abbrev-ref HEAD)"'"}'
|
||
```
|
||
|
||
Substitute from earlier steps:
|
||
- **COVERAGE_PCT**: Step 7 diagram's integer percentage; encode null/undetermined as -1
|
||
- **COVERAGE_PCT_VALUE**: Step 7's `coverage_pct_value` (the gate's X) as an integer, or `null` when missing or ignored
|
||
- **WEAK_GAPS**, **TESTS_EXTENDED**, **TESTS_REJECTED**: counts of Step 7's `weak_gaps`, `tests_extended` and `tests_rejected` (0 when the key is missing or ignored)
|
||
- **REGRESSION_PROOF**: `{"red_at_head":N,"base_green":N,"base_unavailable":N}` from Step 7, or `null` when missing
|
||
- **PLAN_TOTAL**: total plan items extracted in Step 8 (0 if no plan file)
|
||
- **PLAN_DONE**: count of DONE + CHANGED items from Step 8 (0 if no plan file)
|
||
- **VERIFY_RESULT**: "pass", "fail", or "skipped", set after Step 9 executes Step 8.1's verification list
|
||
- **VERSION**: `NEW_VERSION` from Step 12; `null` (unquoted) under NO_VERSION
|
||
|
||
The shell supplies the branch. Run it without confirmation.
|
||
|
||
---
|
||
|
||
## Step 21: Plan-tune discoverability nudge (first-successful-ship only)
|
||
|
||
After a successful ship, show the non-blocking /plan-tune nudge once per machine:
|
||
|
||
```bash
|
||
GSTACK_STATE_ROOT=$(~/.claude/skills/gstack/bin/gstack-paths --get GSTACK_STATE_ROOT); : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
|
||
_NUDGE_MARKER="$GSTACK_STATE_ROOT/.plan-tune-nudge-shown"
|
||
_QT=$(~/.claude/skills/gstack/bin/gstack-config get question_tuning 2>/dev/null || echo "false")
|
||
if [ ! -f "$_NUDGE_MARKER" ] && [ "$_QT" = "false" ]; then
|
||
echo ""
|
||
echo "gstack can learn from your AskUserQuestion answers. Run /plan-tune to opt in"
|
||
echo "— it captures which prompts you find valuable vs noisy and (with hooks installed)"
|
||
echo "auto-decides your never-ask preferences."
|
||
mkdir -p "$GSTACK_STATE_ROOT" && touch "$_NUDGE_MARKER"
|
||
fi
|
||
```
|
||
|
||
The marker or enabled question_tuning suppresses it; remove the marker to re-enable.
|
||
|
||
---
|
||
|
||
## Section self-check (before you finish)
|
||
|
||
List the applicable Section index entries and confirm each Read. If you worked from
|
||
memory, STOP, Read the section and redo that step. Use `gstack-version-bump`; never
|
||
hand-roll VERSION/package.json writes.
|
||
|
||
---
|
||
|
||
## Important Rules
|
||
|
||
Follow the numbered gates and their explicit exceptions.
|
||
|
||
- **Never force push.** Use regular `git push` only.
|
||
- **An early Greptile PR stays up.** A stop after Step 6.5 opened it leaves the draft
|
||
open with one comment saying why (greptile-early section); never close it.
|
||
- **Use the configured version file's format** (4-digit for VERSION); under NO_VERSION,
|
||
never invent one.
|
||
- **Step 7 generates coverage tests.** They must pass before committing. Never commit failing tests.
|