mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-05 16:34:00 +01:00
* feat(evals): Opus 5.5 is the paid gate's model under test; judge stays Fable (GSTA-49 TM1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * v1.91.140.0 chore: stamp TM1 (Opus 5.5 model under test) and CHANGELOG Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): repair the five Opus gate reds from run 39161502626 - coverage audit: owned cd; followed by one && chain, wc -l on in-cwd files - shared-libs: Claude Code 2.1.292 git --version probe, exact argv only - ship hook: accept 'integrate the hook yourself' / 'combine ... by hand' - qa-only: deadline starts only after the charter Write completes - plan floor: tool-only parent session identifies the owned Create grant; floor runner fails fast with PERMISSION_DIALOG_UNANSWERED Each repair replays its captured run as a free regression with negative controls. HARNESS_VERSION stays 6 (re-recorded from main's 5). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): ship hook manual-integration sentence rule; qa-only inspection uses Read/Glob; tool-only permission tests join their owner file Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): tpa-absent-linux accepts instructions the user follows themselves as the manual option Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): owned plan Edit menu binds to exactly one pending Edit, including unpublished ones Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): shared-libs read evidence counts a literal path loop whose output names each file Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore: restamp to v1.91.142.0 (queue slot moved) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): investigate boundary fixture identifies the owner question by its continue/abort options Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): plan-design-with-ui focus check accepts the skill's design-completeness rating in the question body Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): phrasing sweep across the 108 gate rule cases; replay captured Opus paraphrases with negative controls Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(evals): command-detector sweep — exact-count anchor, label slot, 2.1.292 worktree probe - coverage audit (gate 39207508651 plan-eng-coverage-audit): output of exactly known length (wc -l over literal in-cwd files) anchors the next owned read at that line; a label's slot counts from the end and a later complete copy voids the credit (review/specialists/testing.md prints '---') - shared-libs-unsupported-git (39161502626): Claude Code 2.1.292's askPass-first 'worktree list --porcelain -z' cwd probe is Claude's own; the read-only Git check is shared (repoGitRequests, isReadOnlyRepoGitRequest) and the free regression replays every Git request of that capture Each fix replays its captured command with negative controls. No threshold, trial count, case kind or judge changed. HARNESS_VERSION stays 6. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
24 lines
5.2 KiB
JSON
24 lines
5.2 KiB
JSON
{
|
|
"provenance": {
|
|
"source": "https://github.com/garrytan/gstack/actions/runs/39207508651 eval slice 3, plan-eng-coverage-audit (claude-opus-5-5); the first Bash call and its result, byte-exact",
|
|
"recordedPassed": false,
|
|
"recordedFailures": [
|
|
"missing successful source-file read",
|
|
"missing successful test-file read"
|
|
]
|
|
},
|
|
"cwd": "/home/runner/.cache/gstack-paid-shard-LcqBEz/tmp/skill-e2e-plan-eng-review-coverage-ZqqvIJ",
|
|
"sessionId": "57278890-6314-4027-81d1-cd7c0041b348",
|
|
"call": {
|
|
"toolUseId": "toolu_017eDbqRbXZ1KgwfLu1MkB92",
|
|
"command": "cd /home/runner/.cache/gstack-paid-shard-LcqBEz/tmp/skill-e2e-plan-eng-review-coverage-ZqqvIJ; wc -l plan-eng-review/SKILL.md plan-eng-review/sections/review-sections.md; cat src/billing.ts; echo ----; cat test/billing.test.ts",
|
|
"isError": false,
|
|
"output": " 359 plan-eng-review/SKILL.md\n 1542 plan-eng-review/sections/review-sections.md\n 1901 total\n\nexport function processPayment(amount: number, currency: string) {\n if (amount <= 0) throw new Error('Invalid amount');\n if (currency !== 'USD' && currency !== 'EUR') throw new Error('Unsupported currency');\n return { status: 'success', amount, currency };\n}\n\nexport function refundPayment(paymentId: string, reason: string) {\n if (!paymentId) throw new Error('Payment ID required');\n if (!reason) throw new Error('Reason required');\n return { status: 'refunded', paymentId, reason };\n}\n\n// coverage-read-evidence: 464ac75f-f634-4507-ab80-301fa99c4d72\n----\n\nimport { describe, test, expect } from 'vitest';\nimport { processPayment } from '../src/billing';\n\ndescribe('processPayment', () => {\n test('processes valid payment', () => {\n const result = processPayment(100, 'USD');\n expect(result.status).toBe('success');\n });\n // GAP: no test for invalid amount\n // GAP: no test for unsupported currency\n // GAP: refundPayment not tested at all\n});\n\n// coverage-read-evidence: 03ff5e05-d277-409f-8467-45dedf773ad8"
|
|
},
|
|
"finalOutput": "## Test review: `src/billing.ts` (targeted audit)\n\nI read `src/billing.ts` and `test/billing.test.ts` and treated the two exported functions as the codepaths under review. Vitest is the framework, per the test file's import. As asked, I skipped architecture, code quality, performance, test generation and the rest of the workflow, and I didn't change any files.\n\n```\nCODE PATHS USER FLOWS\n[+] src/billing.ts [+] Take a payment (caller → processPayment)\n ├── processPayment(amount, currency) ├── [★★ TESTED] Valid USD charge — billing.test.ts:6\n │ ├── guard: amount <= 0 → throw 'Invalid amount' ├── [GAP] Valid EUR charge\n │ │ ├── [GAP] amount = 0 (boundary) └── [GAP] Caller sees 'Invalid amount' /\n │ │ └── [GAP] amount < 0 'Unsupported currency' error\n │ ├── guard: currency not USD/EUR → throw\n │ │ ├── [GAP] 'GBP' / '' / 'usd' (case) [+] Refund a payment (caller → refundPayment)\n │ │ └── [GAP] 'EUR' allowed branch ├── [GAP] Successful refund\n │ ├── return { status:'success', amount, currency } └── [GAP] Caller sees 'Payment ID required' /\n │ │ └── [★★ TESTED] (100,'USD') → status only 'Reason required' error\n │ │ — billing.test.ts:6-9\n │ └── edge: NaN / Infinity amount\n │ └── [GAP] NaN <= 0 is false → NaN passes the guard and returns 'success'\n │\n └── refundPayment(paymentId, reason) ← never imported by the test file\n ├── guard: !paymentId → throw 'Payment ID required'\n │ └── [GAP] '' / undefined paymentId\n ├── guard: !reason → throw 'Reason required'\n │ └── [GAP] '' / undefined reason\n └── return { status:'refunded', paymentId, reason }\n └── [GAP] happy path\n\nLegend: ★★★ behavior + edge + e",
|
|
"files": {
|
|
"source": "\nexport function processPayment(amount: number, currency: string) {\n if (amount <= 0) throw new Error('Invalid amount');\n if (currency !== 'USD' && currency !== 'EUR') throw new Error('Unsupported currency');\n return { status: 'success', amount, currency };\n}\n\nexport function refundPayment(paymentId: string, reason: string) {\n if (!paymentId) throw new Error('Payment ID required');\n if (!reason) throw new Error('Reason required');\n return { status: 'refunded', paymentId, reason };\n}\n\n// coverage-read-evidence: 464ac75f-f634-4507-ab80-301fa99c4d72\n",
|
|
"tests": "\nimport { describe, test, expect } from 'vitest';\nimport { processPayment } from '../src/billing';\n\ndescribe('processPayment', () => {\n test('processes valid payment', () => {\n const result = processPayment(100, 'USD');\n expect(result.status).toBe('success');\n });\n // GAP: no test for invalid amount\n // GAP: no test for unsupported currency\n // GAP: refundPayment not tested at all\n});\n\n// coverage-read-evidence: 03ff5e05-d277-409f-8467-45dedf773ad8\n"
|
|
}
|
|
}
|