mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-07 09:23:50 +01:00
8fc9f2a58d
Every outside-review gate, execution included, reads P0-P3 labels in label position, table cells and severity words; an unreadable label is unverified (unparsed_severity) and "Verdict: not ready" with no severity blocks with FINDINGS: unspecified. The owned journal reader collapses Claude Code 2.1.293's post-compaction copies (equal apart from uuid, parentUuid and message.usage), so /autoplan's guard no longer denies with tool_identity, init_own or a false disarm. /plan-eng-review with writes forbidden ends DONE with PERSISTED: no and a final PERSIST: line; /ship names it when no Eng Review is saved. Fixes #3105 Fixes #3106 Fixes #3107 Co-authored-by: Kolla Prakyath <177159691+kolla23@users.noreply.github.com> Co-authored-by: Mr-B-1 <214900604+Mr-B-1@users.noreply.github.com>
Codex reply shapes from #3105
Issue #3105 reports 13 Codex consult/challenge replies that the outside-review
helper summarised as VERDICT: clean / FINDINGS: none. The issue describes the
forms but does not include the replies, so these files are synthesized from the
forms it documents (1. **P1 — x**, 1. P2 — x, a bare P2 — label, a final
Verdict: not ready (...) line, and one ready reply with a single P3), plus
negative controls: a real no-findings reply and P1 tokens quoted inside code.
test/outside-review-unparsed-severity.test.ts holds the expected verdicts.