mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-04 15:57:33 +01:00
UI scope reads the Implementation plan only and needs a rendered file path or a UI
term next to a visual noun; bare UI words stay weak evidence (sections load, no
Design phase). Scope records sources {ui,dx} (flag|marker|detected), --no-dx turns
DX off, a first-line <!-- gstack-autoplan-scope: ... --> marker is read and never
written, and the first next prints SCOPE: evidence plus a SCOPE_PIN hint. The
snapshot tool's scope output carries uiRequired from the same detector and
autoplan Step 2 uses it instead of a prose grep (field wave item 11).
Intentional pin change: test/review-checklists.test.ts Scope literal and the
source= line shape (source=ui:detected,dx:detected).
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
77 lines
4.6 KiB
TypeScript
77 lines
4.6 KiB
TypeScript
/**
|
|
* autoplan-scope — the scope evidence both /autoplan paths share (field wave
|
|
* item 11). The runner (lib/autoplan-prompts.ts `detectScope`) and the
|
|
* interactive path (`gstack-autoplan-snapshot.ts scope`, read by
|
|
* autoplan/SKILL.md) take UI scope from `detectUiScope` over the
|
|
* Implementation plan only. UI needs a rendered surface: a path to a rendered
|
|
* file, or a UI term next to a visual noun. Bare UI words are weak evidence:
|
|
* they keep the runner's conservative section fallback but do not add the
|
|
* Design phase. The scope marker is the author's way to pin flags in the plan
|
|
* itself; it is read, never written.
|
|
*/
|
|
|
|
export const UI_TERMS = ['component', 'screen', 'form', 'button', 'modal', 'layout', 'dashboard', 'sidebar', 'nav', 'dialog'] as const;
|
|
export const VISUAL_NOUNS = ['page', 'layout', 'style', 'pixel', 'view', 'browser', 'css'] as const;
|
|
const VISUAL_WINDOW = 4;
|
|
const RENDERED_EXT = /(?:^|\/)[^/.][^/]*\.(?:tsx|jsx|vue|svelte|css|scss|html|erb|hbs)$/i;
|
|
const RENDERED_DIR = /(?:^|\/)(?:components|pages|views|styles)\//i;
|
|
|
|
export interface UiEvidence { terms: Array<{ term: string; count: number }>; visual: string[]; files: string[] }
|
|
export interface UiScope { uiRequired: boolean; uiMatches: number; uiEvidence: UiEvidence }
|
|
|
|
const wordOf = (w: string, list: readonly string[]) => list.find(t => w === t || w === `${t}s` || (t === 'style' && w === 'stylesheet'));
|
|
|
|
/** UI scope from rendered surfaces: a rendered file path, or a UI term within a few words of a visual noun in the same sentence (paths are not prose). */
|
|
export function detectUiScope(implementationPlan: string): UiScope {
|
|
const files = [...new Set([...implementationPlan.matchAll(/[\w@~$.\/-]+/g)]
|
|
.map(m => m[0].replace(/[.\-]+$/, ''))
|
|
.filter(t => t.length > 1 && (RENDERED_EXT.test(t) || RENDERED_DIR.test(t))))];
|
|
const counts = new Map<string, number>();
|
|
const visual: string[] = [];
|
|
for (const sentence of implementationPlan.split(/[.!?;:](?:\s|$)|\n\s*\n/)) {
|
|
const words = sentence.replace(/\S*\/\S*|\b[\w-]+\.[a-z]{1,6}\b/gi, ' ').toLowerCase().match(/[a-z]+/g) ?? [];
|
|
words.forEach((w, i) => {
|
|
const term = wordOf(w, UI_TERMS);
|
|
if (!term) return;
|
|
counts.set(term, (counts.get(term) ?? 0) + 1);
|
|
for (let j = Math.max(0, i - VISUAL_WINDOW); j <= Math.min(words.length - 1, i + VISUAL_WINDOW); j++) {
|
|
const noun = j !== i ? wordOf(words[j]!, VISUAL_NOUNS) : undefined;
|
|
if (noun && noun !== term) { visual.push(`${term}~${noun}`); return; }
|
|
}
|
|
});
|
|
}
|
|
const terms = UI_TERMS.flatMap(term => (counts.has(term) ? [{ term, count: counts.get(term)! }] : []));
|
|
return { uiRequired: files.length > 0 || visual.length > 0, uiMatches: terms.reduce((s, t) => s + t.count, 0), uiEvidence: { terms, visual: [...new Set(visual)], files } };
|
|
}
|
|
|
|
export interface ScopeFlags { ui?: boolean; developerTool?: boolean; agentPrimary?: boolean; dx?: boolean }
|
|
export const SCOPE_FLAG_TOKENS = ['--ui', '--no-ui', '--no-dx', '--developer-tool', '--agent-primary'] as const;
|
|
const MARKER_RE = /^<!--\s*gstack-autoplan-scope:(.*?)-->\s*$/;
|
|
|
|
export function scopeTokens(f: ScopeFlags): string[] {
|
|
return [...(f.ui === true ? ['--ui'] : f.ui === false ? ['--no-ui'] : []), ...(f.dx === false ? ['--no-dx'] : []),
|
|
...(f.developerTool ? ['--developer-tool'] : []), ...(f.agentPrimary ? ['--agent-primary'] : [])];
|
|
}
|
|
|
|
export function parseScopeTokens(tokens: readonly string[], where: string): ScopeFlags {
|
|
const unknown = tokens.filter(t => !(SCOPE_FLAG_TOKENS as readonly string[]).includes(t));
|
|
if (unknown.length) throw new Error(`${where}: unknown scope flag ${unknown.join(', ')} (known: ${SCOPE_FLAG_TOKENS.join(' ')})`);
|
|
if (tokens.includes('--ui') && tokens.includes('--no-ui')) throw new Error(`${where}: --ui and --no-ui conflict`);
|
|
return {
|
|
...(tokens.includes('--ui') ? { ui: true } : tokens.includes('--no-ui') ? { ui: false } : {}),
|
|
...(tokens.includes('--no-dx') ? { dx: false } : {}),
|
|
...(tokens.includes('--developer-tool') ? { developerTool: true } : {}),
|
|
...(tokens.includes('--agent-primary') ? { agentPrimary: true } : {}),
|
|
};
|
|
}
|
|
|
|
export const scopeMarker = (tokens: readonly string[]) => `<!-- gstack-autoplan-scope: ${tokens.join(' ')} -->`;
|
|
|
|
/** The marker on the plan's first line (before any heading), or null. */
|
|
export function readScopeMarker(planText: string, file: string): { tokens: string[]; flags: ScopeFlags } | null {
|
|
const m = MARKER_RE.exec(planText.split('\n', 1)[0]!.replace(/^\uFEFF/, '').trimEnd());
|
|
if (!m) return null;
|
|
const tokens = m[1]!.trim().split(/\s+/).filter(Boolean);
|
|
return { tokens, flags: parseScopeTokens(tokens, `scope marker in ${file}`) };
|
|
}
|