Files
gstack/design/src/image-args.ts
Garry TanandMatt Van Horn fe6d1ae62a v1.91.17.0 fix: mvanhorn wave (checkpoint provenance, never-overwrite design images) (#3022)
* fix: mark Remaining Work provenance so restore verifies guessed steps first (#3004)

/context-save now starts every Remaining Work item with `Open.` and ends it
with how this session knows it: `(path run)` with the observed outcome,
`(path read)` or `(path assumed)` for concrete paths, and
`(target state checked)`, `(code read)` or `(path assumed)` for writing
steps. /context-restore keeps saved order and original text but splits the
list into Next steps and Verify first (assumed, code-read, failed runs and
unmarked concrete or writing items), prints a banner for pre-marker
checkpoints, and option A walks saved order so an unverified first item is
verified before any later step runs.

Adds a prompt-byte contract test for the marker wire format and a periodic
behavior E2E (context-restore-provenance-order) that seeds an assumed item
ahead of a run item plus a code-read write.

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

* fix(design): never overwrite a paid design image (#1529)

Every image the API returns now goes through one persistence path
(design/src/persist.ts): mkdir, exclusive `wx` claim that bumps
x.png -> x-2.png ... x-999.png, write, fsync, close. A failure after the
bytes arrived removes the claimed file and keeps a 0600 recovery copy in
the temp dir; empty image data is a failure, never a 0-byte PNG. The API
call is the only thing inside each retry loop, so a local save failure
never buys a second image (variants, iterate fallback, generate --retry).

generate, iterate, evolve and variants (both branches) print the same run
fields (requested, saved, selected, failures, recovered) on every exit,
with exit 0 / 2 (nothing saved) / 3 (stopped after saving). Each
generate --retry attempt is its own saved image listed in `attempts`.
compare accepts --images-file and JSON-array --images. The gallery lists
bumped names, orders history by mtime then board-images.json, and marks
approvals by approved_path. New bin/gstack-design-claim publishes staged
images without clobbering; bin/gstack-design-approved resolves an
approval record (legacy letter-only records still resolve; a missing
approved_path is an error, never a substitute).

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

* fix(design skills): read the paths $D printed, never fixed variant names (#1529)

Every design flow now captures each generating $D command's JSON and exit
code without set -e, does round accounting before the first board, check
or inline view (stopping when nothing was saved), and carries the printed
paths forward. Boards are built from board-images.json via
compare --images-file after archiving any earlier feedback.json, and
approvals map the confirmed letter through that file and record
approved_path. design-shotgun subagents generate into a per-run mktemp
staging directory and publish with bin/gstack-design-claim instead of a
shared /tmp/variant-X.png plus cp. design-html and taste memory resolve
approvals with gstack-design-approved; design-review verifies against the
printed target path.

test/design-printed-paths.test.ts bans fixed variant names, variant globs,
variant-{letter} reads, cp/mv of $D output and literal check paths in the
generated skills and resolvers (one content-anchored allowlist entry: the
design-html discovery probe), and pins the accounting/board marker order.
test/design-approval-flow.test.ts runs the generated board and approval
blocks through a stubbed two-round flow.

* chore: release v1.91.17.0 (mvanhorn fix wave: checkpoint provenance, never-overwrite design images)

* fix(design): keep iterate sessions in the OS temp dir and normalize tripwire paths on Windows

* fix(setup-deploy): report failing status commands, specify merge-method, health and workflow checks

---------

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
2026-10-03 16:13:45 -07:00

54 lines
1.7 KiB
TypeScript

/**
* Image list parsing for `$D compare`. Accepted forms, in order:
* --images-file <path> JSON array of path strings (lossless; skills use this)
* --images '[...]' JSON array string, only when it starts with `[` and parses as string[]
* --images 'dir/*.png' glob (sorted)
* --images 'a.png,b.png' comma-separated list, or a single path
*/
import fs from "fs";
function parseStringArray(text: string): string[] | null {
try {
const value = JSON.parse(text);
if (Array.isArray(value) && value.every(item => typeof item === "string")) return value;
} catch {}
return null;
}
export async function resolveImagePaths(input: string | undefined, imagesFile?: string): Promise<string[]> {
if (imagesFile) {
let text: string;
try {
text = fs.readFileSync(imagesFile, "utf-8");
} catch (err: any) {
throw new Error(`cannot read --images-file ${imagesFile}: ${err.code || err.message}`);
}
const list = parseStringArray(text);
if (!list) throw new Error(`--images-file ${imagesFile} must contain a JSON array of image path strings`);
return list;
}
if (!input) {
throw new Error("--images or --images-file is required. Provide a JSON array file, glob pattern or comma-separated paths.");
}
if (input.trimStart().startsWith("[")) {
const list = parseStringArray(input);
if (list) return list;
}
if (input.includes("*")) {
const glob = new Bun.Glob(input);
const paths: string[] = [];
for await (const match of glob.scan({ absolute: true })) {
if (match.endsWith(".png") || match.endsWith(".jpg") || match.endsWith(".jpeg")) {
paths.push(match);
}
}
return paths.sort();
}
return input.split(",").map(p => p.trim());
}