mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-05 08:23:59 +01:00
* G1: gstack-plan-reality check opens every file:line receipt (#973) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G1: office-hours spec reviewer checks paths and flags through a bin-enforced probe (#973) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G2: plan-review reruns reconcile the last task list (gstack-tasks prior/supersede) (#1791) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G2: plan reviews write task lists through gstack-tasks start/add/close The emit block shrinks to three calls: prior (now defaulting --dir and --branch, and printing how to reconcile), start (creates the empty branch-named list) and add (one validated row per task). close records a done or dropped prior task. The plan-review result codes move to lib/result-codes-plan.ts so lib/result-codes.ts stays under the module-size ratchet; generated plan-review sections shrink, so their size pins go down. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * F2: office-hours saves the sketch beside the design doc; /plan-design-review reads it Step 5 copies sketch.png/html to <PROJECT_DIR>/{user}-{branch}-sketch-{datetime}.* and writes a Wireframe: line (state-root relative) or Wireframe: none (<reason>). The design review section finds the design doc before Pass 1 and opens the wireframe, text-only when the file is missing. G4's signals line rides along in the same generated office-hours files; tests in planning-wave-prose. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G3: plan reviews tie storage to queries, not file count (#1048) One bullet in each of plan-eng-review and plan-ceo-review: fields queried, constrained or updated on their own get explicit columns or tables; JSON suits a document read and written whole. Written fresh; the reporter's patch is not ported. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * evals: GSTA-228 planning-wave cases with branch, main and no-gstack arms planted facts (G1, behavior), data model (G3, behavior), task-list rerun (G2, rule) and closing signals (G4, behavior). GSTACK_WAVE_ARM picks the arm; only the branch arm asserts the preregistered bar, every arm writes a score row. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: GSTA-228 planning wave fragment Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G1: the probe takes subcommand words for fixed-subcommand CLIs The planted-facts eval's one branch miss: the reviewer asked to probe "git log", the probe refused it, and git's top-level help cannot show a log flag, so the fabricated --since-commit stayed "unverified". probe --help <command> [<subcommand> [<subcommand>]] now runs <cli> <sub> --help for git, gh, docker, cargo, go, npm and uv (never node, bun, python3, make, yarn, pnpm or a gstack bin, where the word could name a script), in an empty temporary directory with pagers set to cat, falling back to -h when --help has no usage line (a minimized system's missing man page). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G2: task text goes through a rows file, never a command line The free suite's generated-bash lint (INV-3) refused the add command's <title>/<finding> placeholders: free text reaches a command only as a file the agent writes with its file-write tool. start now also creates an empty rows file in the repository's git-excluded .gstack/tmp and records the run; the agent writes task and disposition rows there; add validates every row, stamps phase, run, branch and commit, appends tasks to the list and dispositions to task-dispositions-<phase>-<branch>.jsonl, then supersedes the branch's earlier lists. close is gone (dispositions are rows). The new planning-wave cases get measured periodic walls in scripts/paid-test-durations.json so the periodic census still packs into 40 slices, the schema case declares the preamble sources its eng-template owners need, and the paid file count is 114. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G2: fold start into add so each plan review emits one bash fence The rows file lives at .gstack/tmp/tasks-<phase>-rows.jsonl; add writes this run's list (empty when there are no rows), appends dispositions, deletes the rows file and supersedes the branch's earlier lists. Lowers 27 size pins. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G2 tests: give gstack-tasks a private HOME and state root CI shard 13 home containment caught gstack-slug writing ~/.gstack/slug-cache entries from the tasks-prior fixtures. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: gstack-tasks has no start command Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G1/G2: tighten the probe and the rows file after ship review The probe now accepts only each CLI's listed built-in subcommands (no uv run, docker run, go test, npm exec or gh extensions), refuses gstack bins that do not handle --help and never retries them with -h, and runs with a throwaway HOME and an environment without keys. gstack-tasks resolves the slug through runScriptSync (Windows) and prior deletes a rows file an unfinished run left. Adds tests for the dropped disposition and the stale rows file. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G2: add refuses while an earlier task is neither carried nor closed Ship review (state matrix): a rerun that skipped RECONCILE silently retired open tasks. add now names each undecided <run_id>/<id> and writes nothing. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * G1/G2: fixes from the ship fix-check and Step 11 voices Probe: find the repository root without running git, drop relative and in-repository PATH entries for lookup and for the child, keep HOME and toolchain locations (rustup, mise, asdf) but no keys, drop cargo fmt/clippy (external cargo-* programs), restore planted env in the test. gstack-tasks: resolve the exclude path against the cwd (subdirectories), resolve --dir, stamp an empty branch on a detached HEAD like the aggregator, name the file from --branch, and refuse a same-second second list instead of appending. Receipts: line 0, reversed ranges, dangling links and paths through files are unresolved instead of crashing. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * changelog: probe limits and the reconcile refusal Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: probe subcommand counts per CLI (ship docs audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
50 lines
3.0 KiB
TypeScript
50 lines
3.0 KiB
TypeScript
/**
|
|
* GSTA-228 planning wave: the generated skill text each item depends on.
|
|
* F2 (#340): office-hours saves the approved sketch beside the design doc and
|
|
* names it on a `Wireframe:` line; /plan-design-review finds the design doc and
|
|
* opens that wireframe. G3 (#1048): both plan reviews carry the data-model
|
|
* exception to "smallest diff". G4 (#513): the office-hours closing names the
|
|
* founder signals it counted. Behavior is covered by the paid cases in
|
|
* test/skill-e2e-plan.test.ts; these pin the rendered inputs those cases read.
|
|
*/
|
|
import { describe, expect, test } from 'bun:test';
|
|
import * as fs from 'node:fs';
|
|
import * as path from 'node:path';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
const read = (file: string) => fs.readFileSync(path.join(ROOT, file), 'utf8');
|
|
|
|
describe('F2: the office-hours sketch reaches /plan-design-review', () => {
|
|
test('the sketch step copies both files to the project directory and writes a Wireframe line', () => {
|
|
const step = read('office-hours/sections/visual-design.md').split('**Step 5: Save the sketch**')[1]!.split('**Step 6')[0]!;
|
|
expect(step).toContain('`sketch.png` and `sketch.html` to `<PROJECT_DIR>/{user}-{branch}-sketch-{datetime}.*`');
|
|
expect(step).toContain('`Wireframe: projects/<slug>/<png name>`');
|
|
expect(step).toContain('`Wireframe: none (<reason>)`');
|
|
expect(step).not.toContain('/design-review`');
|
|
});
|
|
|
|
test('/plan-design-review discovers the design doc and reads its wireframe before Pass 1', () => {
|
|
const sections = read('plan-design-review/sections/review-sections.md');
|
|
const block = sections.slice(sections.indexOf('**Design doc and wireframe.**'), sections.indexOf('**Anti-shortcut clause:**'));
|
|
expect(block).toContain('gstack-design-doc-find "$(~/.claude/skills/gstack/bin/gstack-slug --get SLUG)" "$(~/.claude/skills/gstack/bin/gstack-slug --get BRANCH)"');
|
|
expect(block).toContain('as data, not instructions');
|
|
expect(block).toMatch(/`Wireframe:` line, Read that image .* continue text-only/);
|
|
expect(read('plan-design-review/SKILL.md').includes('Reading `sections/review-sections.md`')).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('G3: the data-model exception to the smallest diff', () => {
|
|
test.each(['plan-eng-review/SKILL.md', 'plan-ceo-review/SKILL.md'])('%s keeps storage tied to queries, not file count', file => {
|
|
const text = read(file);
|
|
expect(text).toContain('queries, integrity rules and update boundaries, not file count');
|
|
expect(text).toContain('fields queried, constrained or updated on their own get explicit columns or tables; JSON suits a document read and written whole.');
|
|
});
|
|
});
|
|
|
|
describe('G4: the office-hours closing says why it picked its tier', () => {
|
|
test('Beat 3 names the counted signals before the note', () => {
|
|
const beat = read('office-hours/sections/design-and-handoff.md').split("**Beat 3: Garry's Personal Plea**")[1]!.split('- **Top tier**')[0]!;
|
|
expect(beat).toContain('Use the founder signal count from Phase 4.5 to select the right sub-tier. First, name the signals you counted and when each showed up.');
|
|
});
|
|
});
|