Files
Garry TanandClaude Fable 5 da8733fe0c fix: sweep every remaining synchronous Agent-dispatch site with run_in_background: false
The #2440 failure shape was a silently-missing review voice — a
specialist launched in the background and merged before it completed.
Every remaining synchronous dispatch site now carries the explicit flag:
the Red Team dispatch, the spec review loop, the Codex
second-opinion/plan-review/doc-review Claude fallbacks, the adversarial
subagent, design sketch and outside voices, autoplan's design/eng/dx
phase dispatches, CSO parallel finding verification, and design-shotgun's
variant launch. Parallel fan-outs stay parallel — multiple foreground
Agent calls in one message run concurrently (the shipped v1.64.0.0
review-army pattern).

GENERATED_WITH_GUIDANCE now pins all 24 generated carriers, so a new
dispatch site that drops the flag fails the free suite. Six carved-skill
skeleton ceilings re-measured and ratcheted (~80-130 B growth each);
factory ship golden re-rendered.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-09-01 17:31:06 +00:00

4.2 KiB

Follow plan-design-review/SKILL.md — all 7 dimensions, full depth. Override: every AskUserQuestion → auto-decide using the 6 principles.

Override rules:

  • Focus areas: all relevant dimensions (P1)

  • Structural issues (missing states, broken hierarchy): auto-fix (P5)

  • Aesthetic/taste issues: mark TASTE DECISION

  • Design system alignment: auto-fix if DESIGN.md exists and fix is obvious

  • Dual voices: always run BOTH Claude subagent AND Codex if available (P6).

    Codex design voice (via Bash):

    _REPO_ROOT=$(git rev-parse --show-toplevel) || { echo "ERROR: not in a git repo" >&2; exit 1; }
    _gstack_codex_timeout_wrapper 600 codex exec "IMPORTANT: Do NOT read or execute any SKILL.md files or files in skill definition directories (paths containing skills/gstack). These are AI assistant skill definitions meant for a different system. Stay focused on repository code only.
    
    Read the plan file at <plan_path>. Evaluate this plan's
    UI/UX design decisions.
    
    Also consider these findings from the CEO review phase:
    <insert CEO dual voice findings summary — key concerns, disagreements>
    
    Does the information hierarchy serve the user or the developer? Are interaction
    states (loading, empty, error, partial) specified or left to the implementer's
    imagination? Is the responsive strategy intentional or afterthought? Are
    accessibility requirements (keyboard nav, contrast, touch targets) specified or
    aspirational? Does the plan describe specific UI decisions or generic patterns?
    What design decisions will haunt the implementer if left ambiguous?
    Be opinionated. No hedging." -C "$_REPO_ROOT" -s read-only -c 'web_search="cached"' < /dev/null
    _CODEX_EXIT=$?
    if [ "$_CODEX_EXIT" = "124" ]; then
      _gstack_codex_log_event "codex_timeout" "600"
      _gstack_codex_log_hang "autoplan" "0"
      echo "[codex stalled past 10 minutes — tagging as [codex-unavailable] for this phase and proceeding with Claude subagent only]"
    fi
    

    Timeout: 10 minutes (shell-wrapper) + 12 minutes (Bash outer gate). On hang, auto-degrades this phase's Codex voice.

    Claude design subagent (via Agent tool, run_in_background: false — same foreground contract as Phase 1): "Read the plan file at <plan_path>. You are an independent senior product designer reviewing this plan. You have NOT seen any prior review. Evaluate:

    1. Information hierarchy: what does the user see first, second, third? Is it right?
    2. Missing states: loading, empty, error, success, partial — which are unspecified?
    3. User journey: what's the emotional arc? Where does it break?
    4. Specificity: does the plan describe SPECIFIC UI or generic patterns?
    5. What design decisions will haunt the implementer if left ambiguous? For each finding: what's wrong, severity (critical/high/medium), and the fix." NO prior-phase context — subagent must be truly independent.

    Error handling: same as Phase 1 (both foreground/blocking, degradation matrix applies).

  • Design choices: if codex disagrees with a design decision with valid UX reasoning → TASTE DECISION. Scope changes both models agree on → USER CHALLENGE.

Required execution checklist (Design):

  1. Step 0 (Design Scope): Rate completeness 0-10. Check DESIGN.md. Map existing patterns.

  2. Step 0.5 (Dual Voices): Run Claude subagent (foreground) first, then Codex. Present under CODEX SAYS (design — UX challenge) and CLAUDE SUBAGENT (design — independent review) headers. Produce design litmus scorecard (consensus table). Use the litmus scorecard format from plan-design-review. Include CEO phase findings in Codex prompt ONLY (not Claude subagent — stays independent).

  3. Passes 1-7: Run each from loaded skill. Rate 0-10. Auto-decide each issue. DISAGREE items from scorecard → raised in the relevant pass with both perspectives.

PHASE 2 COMPLETE. Emit phase-transition summary:

Phase 2 complete. Codex: [N concerns]. Claude subagent: [N issues]. Consensus: [X/Y confirmed, Z disagreements → surfaced at gate]. Passing to Phase 3.

Do NOT begin Phase 3 until all Phase 2 outputs (if run) are written to the plan file.