mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-07 05:56:41 +02:00
07b4e15b34
* fix: cookie import picker returns JSON instead of HTML jsonResponse() was defined at module scope but referenced `url` which only existed as a parameter of handleCookiePickerRoute(). Every API call crashed, the catch block also crashed, and Bun returned a default HTML page that the frontend couldn't parse as JSON. Thread port via corsOrigin() helper and options objects. Add route-level tests to prevent this class of bug from shipping again. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add help command to browse server Agents that don't have SKILL.md loaded (or misread flags) had no way to self-discover the CLI. The help command returns a formatted reference of all commands and snapshot flags. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: version-aware find-browse with META signal protocol Agents in other workspaces found stale browse binaries that were missing newer flags. find-browse now compares the local binary's git SHA against origin/main via git ls-remote (4hr cache), and emits META:UPDATE_AVAILABLE when behind. SKILL.md setup checks parse META signals and prompt the user to update. - New compiled binary: browse/dist/find-browse (TypeScript, testable) - Bash shim at browse/bin/find-browse delegates to compiled binary - .version file written at build time with git commit SHA - Build script compiles both browse and find-browse binaries - Graceful degradation: offline, missing .version, corrupt cache all skip check Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: clean up .bun-build temp files after compile bun build --compile leaves ~58MB temp files in the working directory. Add rm -f .*.bun-build to the build script to clean up after each build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: make help command reachable by removing it from META_COMMANDS help was in META_COMMANDS, so it dispatched to handleMetaCommand() which threw "Unknown meta command: help". Removing it from the set lets the dedicated else-if handler in handleCommand() execute correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: bump version and changelog (v0.3.2) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add shared Greptile comment triage reference doc Shared reference for fetching, filtering, and classifying Greptile review comments on GitHub PRs. Used by both /review and /ship skills. Includes parallel API fetching, suppressions check, classification logic, reply APIs, and history file writes. * feat: make /review and /ship Greptile-aware /review: Step 2.5 fetches and classifies Greptile comments, Step 5 resolves them with AskUserQuestion for valid issues and false positives. /ship: Step 3.75 triages Greptile comments between pre-landing review and version bump. Adds Greptile Review section to PR body in Step 8. Re-runs tests if any Greptile fixes are applied. * feat: add Greptile batting average to /retro Reads ~/.gstack/greptile-history.md, computes signal ratio (valid catches vs false positives), includes in metrics table, JSON snapshot, and Code Quality Signals narrative. * docs: add Greptile integration section to README Personal endorsement, two-layer review narrative, full UX walkthrough transcript, skills table updates. Add Greptile training feedback loop to TODO.md future ideas. * feat: add local dev mode for testing skills from within the repo bin/dev-setup creates .claude/skills/gstack symlink to the working tree so Claude Code discovers skills locally. bin/dev-teardown cleans up. DEVELOPING_GSTACK.md documents the workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: narrow gitignore to .claude/skills/ instead of all .claude/ Avoids ignoring legitimate Claude Code config like settings.json or CLAUDE.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: rename DEVELOPING_GSTACK.md to CONTRIBUTING.md Rewritten as a contributor-friendly guide instead of a dry plan doc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: explain why dev-setup is needed in CONTRIBUTING.md quick start Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add browser interaction guidance to CLAUDE.md Prevents Claude from using mcp__claude-in-chrome__* tools instead of /browse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add shared config module for project-local browse state Centralizes path resolution (git root detection, state dir, log paths) into config.ts. Both cli.ts and server.ts import from it, eliminating duplicated PORT_OFFSET/BROWSE_PORT/STATE_FILE logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: rewrite port selection to use random ports Replace CONDUCTOR_PORT magic offset and 9400-9409 scan with random port 10000-60000. Atomic state file writes, log paths from config module, binaryVersion field for auto-restart on update. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: move browse state from /tmp to project-local .gstack/ CLI now uses config module for state paths, passes BROWSE_STATE_FILE to spawned server. Adds version mismatch auto-restart, legacy /tmp cleanup with PID verification, and removes stale global install fallback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: update crash log path reference to .gstack/ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: add config tests and update CLI lifecycle test 14 new tests for config resolution, ensureStateDir, readVersionHash, resolveServerScript, and version mismatch detection. Remove obsolete CONDUCTOR_PORT/BROWSE_PORT filtering from commands.test.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update BROWSER.md and TODO.md for project-local state Replace /tmp paths with .gstack/, remove CONDUCTOR_PORT docs, document random port selection and per-project isolation. Add server bundling TODO. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update README, CHANGELOG, and CONTRIBUTING for v0.3.2 - README: replace Conductor-aware language with project-local isolation, add Greptile setup note - CHANGELOG: comprehensive v0.3.2 entry with all state management changes - CONTRIBUTING: add instructions for testing branches in other repos Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add diff-aware mode to /qa — auto-tests affected pages from branch diff When on a feature branch, /qa now reads git diff main, identifies affected pages/routes from changed files, and tests them automatically. No URL required. The most natural flow: write code, /ship, /qa. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: update CHANGELOG for complete v0.3.2 coverage Add missing entries: diff-aware QA mode, Greptile integration, local dev mode, crash log path fix, README/SKILL.md updates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
206 lines
7.4 KiB
TypeScript
206 lines
7.4 KiB
TypeScript
/**
|
|
* Tests for cookie-picker route handler
|
|
*
|
|
* Tests the HTTP glue layer directly with mock BrowserManager objects.
|
|
* Verifies that all routes return valid JSON (not HTML) with correct CORS headers.
|
|
*/
|
|
|
|
import { describe, test, expect } from 'bun:test';
|
|
import { handleCookiePickerRoute } from '../src/cookie-picker-routes';
|
|
|
|
// ─── Mock BrowserManager ──────────────────────────────────────
|
|
|
|
function mockBrowserManager() {
|
|
const addedCookies: any[] = [];
|
|
const clearedDomains: string[] = [];
|
|
return {
|
|
bm: {
|
|
getPage: () => ({
|
|
context: () => ({
|
|
addCookies: (cookies: any[]) => { addedCookies.push(...cookies); },
|
|
clearCookies: (opts: { domain: string }) => { clearedDomains.push(opts.domain); },
|
|
}),
|
|
}),
|
|
} as any,
|
|
addedCookies,
|
|
clearedDomains,
|
|
};
|
|
}
|
|
|
|
function makeUrl(path: string, port = 9470): URL {
|
|
return new URL(`http://127.0.0.1:${port}${path}`);
|
|
}
|
|
|
|
function makeReq(method: string, body?: any): Request {
|
|
const opts: RequestInit = { method };
|
|
if (body) {
|
|
opts.body = JSON.stringify(body);
|
|
opts.headers = { 'Content-Type': 'application/json' };
|
|
}
|
|
return new Request('http://127.0.0.1:9470', opts);
|
|
}
|
|
|
|
// ─── Tests ──────────────────────────────────────────────────────
|
|
|
|
describe('cookie-picker-routes', () => {
|
|
describe('CORS', () => {
|
|
test('OPTIONS returns 204 with correct CORS headers', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/browsers');
|
|
const req = new Request('http://127.0.0.1:9470', { method: 'OPTIONS' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(204);
|
|
expect(res.headers.get('Access-Control-Allow-Origin')).toBe('http://127.0.0.1:9470');
|
|
expect(res.headers.get('Access-Control-Allow-Methods')).toContain('POST');
|
|
});
|
|
|
|
test('JSON responses include correct CORS origin with port', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/browsers', 9450);
|
|
const req = new Request('http://127.0.0.1:9450', { method: 'GET' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.headers.get('Access-Control-Allow-Origin')).toBe('http://127.0.0.1:9450');
|
|
});
|
|
});
|
|
|
|
describe('JSON responses (not HTML)', () => {
|
|
test('GET /cookie-picker/browsers returns JSON', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/browsers');
|
|
const req = new Request('http://127.0.0.1:9470', { method: 'GET' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.headers.get('Content-Type')).toBe('application/json');
|
|
const body = await res.json();
|
|
expect(body).toHaveProperty('browsers');
|
|
expect(Array.isArray(body.browsers)).toBe(true);
|
|
});
|
|
|
|
test('GET /cookie-picker/domains without browser param returns JSON error', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/domains');
|
|
const req = new Request('http://127.0.0.1:9470', { method: 'GET' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(400);
|
|
expect(res.headers.get('Content-Type')).toBe('application/json');
|
|
const body = await res.json();
|
|
expect(body).toHaveProperty('error');
|
|
expect(body).toHaveProperty('code', 'missing_param');
|
|
});
|
|
|
|
test('POST /cookie-picker/import with invalid JSON returns JSON error', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/import');
|
|
const req = new Request('http://127.0.0.1:9470', {
|
|
method: 'POST',
|
|
body: 'not json',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
});
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(400);
|
|
expect(res.headers.get('Content-Type')).toBe('application/json');
|
|
const body = await res.json();
|
|
expect(body.code).toBe('bad_request');
|
|
});
|
|
|
|
test('POST /cookie-picker/import missing browser field returns JSON error', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/import');
|
|
const req = makeReq('POST', { domains: ['.example.com'] });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(400);
|
|
const body = await res.json();
|
|
expect(body.code).toBe('missing_param');
|
|
});
|
|
|
|
test('POST /cookie-picker/import missing domains returns JSON error', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/import');
|
|
const req = makeReq('POST', { browser: 'Chrome' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(400);
|
|
const body = await res.json();
|
|
expect(body.code).toBe('missing_param');
|
|
});
|
|
|
|
test('POST /cookie-picker/remove with invalid JSON returns JSON error', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/remove');
|
|
const req = new Request('http://127.0.0.1:9470', {
|
|
method: 'POST',
|
|
body: '{bad',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
});
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(400);
|
|
expect(res.headers.get('Content-Type')).toBe('application/json');
|
|
});
|
|
|
|
test('POST /cookie-picker/remove missing domains returns JSON error', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/remove');
|
|
const req = makeReq('POST', {});
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(400);
|
|
const body = await res.json();
|
|
expect(body.code).toBe('missing_param');
|
|
});
|
|
|
|
test('GET /cookie-picker/imported returns JSON with domain list', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/imported');
|
|
const req = new Request('http://127.0.0.1:9470', { method: 'GET' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.headers.get('Content-Type')).toBe('application/json');
|
|
const body = await res.json();
|
|
expect(body).toHaveProperty('domains');
|
|
expect(body).toHaveProperty('totalDomains');
|
|
expect(body).toHaveProperty('totalCookies');
|
|
});
|
|
});
|
|
|
|
describe('routing', () => {
|
|
test('GET /cookie-picker returns HTML', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker');
|
|
const req = new Request('http://127.0.0.1:9470', { method: 'GET' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.headers.get('Content-Type')).toContain('text/html');
|
|
});
|
|
|
|
test('unknown path returns 404', async () => {
|
|
const { bm } = mockBrowserManager();
|
|
const url = makeUrl('/cookie-picker/nonexistent');
|
|
const req = new Request('http://127.0.0.1:9470', { method: 'GET' });
|
|
|
|
const res = await handleCookiePickerRoute(url, req, bm);
|
|
|
|
expect(res.status).toBe(404);
|
|
});
|
|
});
|
|
});
|