mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 14:38:59 +02:00
* feat(aside): browser-driver contract, cookbook, research and fallback resolvers
{{ASIDE_SETUP}} (readiness probe + ten rules for driving the user's real browser), {{ASIDE_COOKBOOK}} (script shapes verified live against Aside CLI 1.26: one flow per aside repl script, CDP console hook before navigation, evidence lines, session-directory artifact handoff, GSTACK_STEP_OK sentinel), {{ASIDE_RESEARCH}} (research through aside exec, WebSearch when Aside is absent, knowledge otherwise) and {{BROWSE_FALLBACK}} (the fifteen-row Aside-step to $B-command table plus the rules that differ, so every browsing skill keeps working on gstack's own headless browser). test/aside-driver.test.ts pins the sentences and asserts every browsing skill carries the Aside block followed by the fallback; test/helpers/aside-available.ts is the shared live-Aside probe.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* feat(render): Aside-first local-HTML renderer with the bundled browser as fallback
lib/aside-render.ts serves the HTML's directory on loopback (Aside refuses file:// URLs), opens it with waitUntil load, prints through CDP Page.printToPDF so tagged output, outlines, header/footer templates and page numbers survive, emulates device metrics for sized screenshots, and writes in-page evaluations to files; when Aside is absent it runs the same spec through the browse daemon (newtab, load, js, pdf, screenshot, closetab) and reports ENGINE=aside|browse. bin/gstack-render.ts is the CLI skill templates call. lib/claude-bin.ts and lib/error-handling.ts become the canonical copies (browse/src re-exports them).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(browse): /browse drives Aside first, with the $B reference behind the fallback
Contract, cookbook, mode choice (aside repl by default, aside exec for reading), report format, the fallback section, and the full command reference carved on demand.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(qa): /qa and /qa-only drive Aside, fall back to $B
QA_METHODOLOGY runs every phase as Aside scripts (orient, explore, document, re-test, mobile viewport via CDP emulation, links via HEAD fetch); the authenticate phase is 'you are already signed in'; a 13th rule requires consent before mutating actions on non-local targets; the fallback section translates each step onto $B. The qa E2E tests run on whichever engine is present.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(design): design-review, design-consultation, design-shotgun, plan-design-review, design-html drive Aside
Design-system extraction is one script printing FONTS/COLORS/HEADINGS/TOUCH_TARGETS/NAV; competitor research confirms the exact URLs before opening them in the real browser and runs on the bundled browser when Aside is absent; design-html's viewport screenshots, sketches and comparison boards render through gstack-render.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(deploy): benchmark, canary, land-and-deploy Step 7, devex-review drive Aside
One aside repl script per page prints NAV/PAINT/LCP/RESOURCES/SCRIPTS/CSS/SUMMARY (benchmark), CONSOLE_ERRORS/NAV/TEXT + screenshot (canary, re-run every 60s), and the post-deploy check reads responseStatus from the navigation entry; each carries the $B fallback.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* feat(third-party-actions): Aside is the recommended driver; gstack's visible browser stays the fallback
The readiness probe is lifted from {{ASIDE_SETUP}} at gen time (byte-identity pinned) and rule 3 points at browse/SKILL.md for how to drive; the consent question offers Aside first and gstack's own visible browser (handoff/resume for sign-in) as the fallback, as v1.72 framed it.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(scrape): /scrape reads pages through Aside; the browser-skills runtime rides the fallback
Look-then-extract scripts build the JSON inside the page and print it between JSON_START/JSON_END; aside exec for fuzzy intents; on the $B fallback the browser-skills match/prototype flow and /skillify apply as before.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(make-pdf): print through Aside first, the bundled browser otherwise
asideClient.ts replaces the direct $B client with one render() call per PDF (the exact option mapping the browse pdf command had: paper, margins, header/footer/page numbers, tagged, outline, printBackground, preferCSSPageSize, Paged.js wait); the diagram pre-pass, oversized-image downscale and DOCX rasters each run as one render script with per-fence try/catch; exit 4 now means no browser is available and names both remedies; $P setup reports which engine it found. The e2e gates run on whichever engine is present, so the Linux lane exercises the fallback.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(diagram): the triplet is one gstack-render call
SVG, PNG and excalidraw from one invocation over the content-addressed bundle staged under /tmp/gstack-render; every diagram type gets an excalidraw export; gstack-render picks the engine and prints ENGINE=; the diagram E2E gates on either engine.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* feat(research): web research runs in Aside first, WebSearch second
The planning, review, design, security and investigate skills research through {{ASIDE_RESEARCH}}; WebSearch stays in allowed-tools as the fallback; testing.ts's bootstrap step follows; skeleton ceilings ratcheted for the research block.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* feat(setup,gen-skill-docs): prune renders of skills that no longer exist
setup gains _prune_stale_generated for every host tree and the doc generator removes gstack-* output dirs it did not write, so a skill removed from the source tree can never linger in an install.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* test: registries, budgets and suite reconciled for Aside-first with the $B fallback
Touchfiles + E2E tiers gain the Aside keys, coverage matrix and eval baselines updated, size budget re-baselined to parity-baseline-v1.80.0.0.json (the contract plus fallback ride in every browsing skill), parity ceilings ratcheted with measured values, LLM-judge prompts and the E2E fixtures speak Aside-first, browse-fallback.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs: Aside first, gstack browser fallback
README, BROWSER.md, docs/, CONTRIBUTING, CLAUDE.md, ARCHITECTURE, AGENTS.md, TODOS and the root router describe the one product story: Aside is the browser gstack drives first; the bundled headless browser is the automatic fallback (Linux, Windows, app closed) where cookie import, GStack Browser, pair-agent and browser-skills still apply.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* chore: regenerate SKILL.md docs, llms.txt, agents digest, ship goldens, context-budget fixture
bun run gen:skill-docs over the templates; goldens re-rendered; context-budget ceilings recaptured.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* v1.80.0.0: Aside is the browser gstack drives first; the bundled browser is the fallback
MINOR: new capability across ten skills, the renderer and research; nothing removed. CHANGELOG release summary + itemized changes; VERSION 1.80.0.0; package.json 1.80.0.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs(todos): file non-Claude host ownership-gate and version-heading pin follow-ups
Two follow-ups from the /plan-ceo-review + /plan-eng-review pass on merging
PR #2804 with main's v1.80.0.0 ownership gate: bring the Codex/Factory/
OpenCode/Cursor/Kiro copy loops and the stale-render prune under the
.gstack-owned marker rule, and a free test pinning that the CHANGELOG top
heading equals VERSION (the collision that git cannot see).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix: pre-landing review fixes for the Aside-first branch
Review army + adversarial passes (Claude and Codex) on the merged branch:
setup
- _prune_stale_generated scans the host dirs too (the generator already
removed the render before setup ran, so the host branch was dead), skips
symlinks in the render tree (rm -rf on a slash-terminated link empties its
target), removes a host symlink only when it resolves into gstack, cleans a
bannered real dir through _cleanup_weak_dir, recognizes frontmatter-renamed
skills, and logs through log. The always-run codex render passes every host
dir that may link to it.
- NEEDS_BUILD checks all three binaries (with $_EXE) and lib/ sources; the
browser hint and the bootstrap summary honor GSTACK_SKIP_ASIDE, treat a
requested skip as a request, and derive one skill list.
lib/aside-render.ts + bin/gstack-render.ts
- The loopback server carries a per-render secret path, checks containment on
the real path (symlink escapes are 403), and rejects malformed encoding.
- Inline eval results are one base64 line, so page text cannot forge
ASIDE_DIR= or the sentinel; the last ASIDE_DIR wins.
- runProc escalates SIGTERM to SIGKILL, bounds every wait, and clears every
timer (an uncleared one kept gstack-render alive after printing OK).
- renderTmpDir refuses a shared /tmp name owned by someone else; the work dir
and server are created inside try; goto's budget follows the render budget.
- probeAside classifies a present-but-failing CLI as ASIDE_NOT_RUNNING like
the skills' bash probe; render() retries on gstack's own browser when Aside
could not start or its private CDP bridge is gone (never on a page error
or a timeout of a running script); the CLI reports the engine that actually
rendered, exits 0 on --help, rejects non-numeric flags, documents
--wait-timeout, fences EVAL/PAGE_ERRORS as untrusted content, and names the
daemon's cookie-import JS lock remedy.
- The browse path passes --scale only when asked (a scale change rebuilds
the daemon context) and restores the viewport after a sized screenshot.
resolvers / templates
- The bash probe honors GSTACK_SKIP_ASIDE and has a perl deadline on stock
macOS; .local is no longer LOCAL (mDNS); same-origin filters compare parsed
origins; link status is HEAD-checked only on LOCAL targets; every
aside exec goes through the receipted _aside_exec prelude
({{ASIDE_EXEC_PRELUDE}}), including nine template blocks that called it
bare; the design sketch and diagram staging use private directories.
- The generator prunes only bannered renders and never a host whose
generation failed.
Docs, stale comments and dead code cleaned; goldens re-rendered; tests
updated and added for every behavior above.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* test: coverage for the render CLI, setup rebuild check, make-pdf exit codes, and prose $B spans
New free tests from the ship coverage audit: test/gstack-render-cli.test.ts
(argv guards, --help, output contract with a fake daemon, failure and
serve-root paths, no-browser case, prompt exit), test/setup-needs-build.test.ts
(every binary and source set flips NEEDS_BUILD, Windows suffixes),
make-pdf/test/cli-exit-codes.test.ts and setup-smoke.test.ts (error to exit
code mapping, runSetup stages, renderPdf's engine), and prose-span cases for
extractBrowseCommands in test/skill-parser.test.ts.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs: CHANGELOG and TODOS cover the review fixes (v1.81.0.0)
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs: sync project docs with the v1.81.0.0 review fixes
BROWSER.md, ARCHITECTURE.md, CONTRIBUTING.md, README.md, CLAUDE.md,
docs/TESTING_INTERNALS.md and docs/PROJECT_STRUCTURE.md now describe the
shipped renderer and setup: the loopback render server's per-render secret
path and real-path containment, ENGINE= naming the engine that actually
rendered (mid-run retry on gstack's own browser), EVAL/PAGE_ERRORS fenced as
untrusted content, --wait-timeout and the CLI's argv guards, the receipted
_aside_exec prelude ({{ASIDE_EXEC_PRELUDE}} in the placeholder table), the
LOCAL host rule without .local, LOCAL-only HEAD checks in the links script,
GSTACK_SKIP_ASIDE across probe/renderer/setup, the ownership-gated
retired-skill prune, the widened NEEDS_BUILD check, and the new free tests
(gstack-render-cli, setup-prune-stale-generated, setup-browser-hint,
setup-needs-build, make-pdf cli-exit-codes and setup-smoke).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs: CHANGELOG states the precise mid-run retry rule
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(test): skill-e2e-bws slices the $B setup block from the Browser fallback section
browse/SKILL.md no longer has '## SETUP' / '## Core QA Patterns' (Aside is the
primary driver; the $B block moved under 'Browser fallback'), so the gate test
sliced an empty block and handed the agent nothing to run. Anchor on
'### Find the `$B` binary' up to the next heading. 7/7 pass.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(test): gate POSIX-only fixtures off Windows
windows-free-tests: the gstack-render CLI tests drive a shebang fake browse
that CreateProcess cannot exec, and two NEEDS_BUILD cases assert an execute
bit and a bare-name miss that MSYS bash does not have (test -x ignores mode
bits and resolves design -> design.exe). Those describes and cases now
self-skip on win32; argument guards, --help, the no-browser case, and every
other rebuild-check case still run there.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(render): runProc waits for the exit code until the kill deadline; newtab retries once on a cold daemon
A process whose pipes have reached EOF is exiting, but runProc gave the exit
code only five seconds to arrive and then returned null, which run() reports
as a failed command. Under CI's six-shard load one such render failed with the
artifact already written. The SIGTERM/SIGKILL timers already bound the wait,
so the exit race now runs to the kill deadline.
The first CLI call auto-starts the browse daemon; on a cold start it can
answer 'Unable to connect' once while the server is still coming up. That
single case is retried after 1.5s; every other newtab failure is not.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* test(aside-render): warm the daemon before live fallback cases; failures name the render error
- Live fallback cases run 'goto about:blank' up to twice before asserting and
skip (never fail) when the daemon cannot come up.
- expectOk() puts r.error and the browse transcript into the assertion so a
failed render is diagnosable from the CI log.
- The argv-contract cases dump the fake's log on a miss.
- File default timeout is 30s: the subject is the CLI contract, not latency.
- Two cases pin the cold-daemon newtab retry and that other errors are not
retried.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs: CHANGELOG notes the cold-start tolerance of the bundled-browser renderer
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
---------
Co-authored-by: Sina <sdroid674+github@gmail.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
269 lines
13 KiB
TypeScript
269 lines
13 KiB
TypeScript
/**
|
|
* Offline-posture sanitizer tests — raw-HTML fetch vectors beyond <img src>
|
|
* (which the image inliner owns). No browser, no PDF generation.
|
|
*
|
|
* Regression for: <style>@import, inline style="…url(https://…)…", and
|
|
* <img srcset> surviving sanitizeUntrustedHtml, letting Chromium fetch
|
|
* remote resources at print time with no --allow-network.
|
|
*/
|
|
|
|
import { describe, expect, test } from "bun:test";
|
|
|
|
import { render, sanitizeUntrustedHtml } from "../src/render";
|
|
|
|
describe("sanitizeUntrustedHtml (offline fetch vectors)", () => {
|
|
test("strips @import url(...) from raw <style> blocks, keeps legit rules", () => {
|
|
const input = `<style>@import url("https://evil.example/track.css");\nh1 { color: red; }</style>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("@import");
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("color: red");
|
|
});
|
|
|
|
test("strips string-form @import (no url())", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>@import "https://evil.example/a.css";</style>`);
|
|
expect(out).not.toContain("@import");
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes remote url() inside <style> blocks", () => {
|
|
const input = `<style>body { background: url(https://evil.example/px.gif); color: blue; }</style>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
expect(out).toContain("color: blue");
|
|
});
|
|
|
|
test("neutralizes remote url() in inline style attributes", () => {
|
|
const input = `<div style="background:url(https://evil.example/px.gif);padding:4px">x</div>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
expect(out).toContain("padding:4px");
|
|
});
|
|
|
|
test("neutralizes protocol-relative url(//…) in style attributes", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(//evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
// ── Bypass regressions: unquoted style attributes ──
|
|
// HTML spec: an unquoted attribute value runs until whitespace or `>`, so
|
|
// <div style=background:url(https://…)> is live markup Chromium honors.
|
|
// The original neutralizer only rewrote quoted values.
|
|
|
|
test("neutralizes remote url() in UNQUOTED style attributes", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style=background:url(https://evil.example/px.gif)>x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
});
|
|
|
|
test("keeps local url() in unquoted style attributes functional", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style=background:url(local.png)>x</div>`);
|
|
expect(out).toContain("url(local.png)");
|
|
});
|
|
|
|
// ── Bypass regressions: CSS-escape obfuscation ──
|
|
// Chromium decodes CSS ident/string escapes before fetching, so \69 → i and
|
|
// \68 → h defeat literal-pattern matching. Untrusted styling has no
|
|
// legitimate need for escaped url schemes or at-rule names — fail closed.
|
|
|
|
test("drops CSS-escaped @import (@\\69mport url(...)) in <style> blocks", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>@\\69mport url("https://evil.example/a.css");</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).not.toMatch(/@\\/); // no escaped at-rule survives for Chromium to decode
|
|
});
|
|
|
|
test("drops CSS-escaped string-form @import (@\\69mport \"https://…\")", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>@\\69mport "https://evil.example/a.css";</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).not.toMatch(/@\\/);
|
|
});
|
|
|
|
test("neutralizes CSS-escaped scheme inside url() (\\68ttps://…)", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>body{background:url("\\68ttps://evil.example/px.gif")}</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes CSS-escaped function names (u\\72l(https://…))", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>body{background:u\\72l(https://evil.example/px.gif)}</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes HTML-entity-encoded backslash escapes in style attributes", () => {
|
|
// Attribute values are entity-decoded by the HTML parser before the CSS
|
|
// parser runs, so \68ttps reaches Chromium as \68ttps → https.
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url('\68ttps://evil.example/px.gif')">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
// ── Bypass regressions: non-backslash entity obfuscation in style attrs ──
|
|
// The same attribute entity layer can hide ANY character of a fetch vector,
|
|
// not just backslashes: h → h, / → /. <style> BLOCKS don't need
|
|
// this handling — element content is raw text, never attribute-decoded.
|
|
|
|
test("neutralizes numeric-entity-obfuscated scheme in style attributes (https)", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(https://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes entity-obfuscated slashes in style attributes (// for //)", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(https://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes entity-obfuscated url( name in style attributes (url)", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(https://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("entity-decoded local styles stay functional and safely re-encoded", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="content:"hi";background:url(local.png)">x</div>`);
|
|
expect(out).toContain("url(local.png)");
|
|
expect(out).toContain(""hi"");
|
|
});
|
|
|
|
test("double-encoded entities are not double-decoded into a live scheme", () => {
|
|
// Browser decodes &#104; exactly once → literal https://… text,
|
|
// which is not a scheme. The sanitizer must mirror that single decode:
|
|
// decoding twice would CREATE url(https://…) where the browser sees none.
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(&#104;ttps://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toMatch(/url\(\s*https:/);
|
|
});
|
|
|
|
test("strips srcset with a remote candidate, leaves src for the inliner", () => {
|
|
const input = `<img src="local.png" srcset="local.png 1x, https://evil.example/x.png 2x">`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("srcset");
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain(`src="local.png"`);
|
|
});
|
|
|
|
test("strips unquoted remote srcset", () => {
|
|
const out = sanitizeUntrustedHtml(`<img src="a.png" srcset=https://evil.example/x.png>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("keeps local-only srcset (no network vector)", () => {
|
|
const input = `<img src="a.png" srcset="a.png 1x, a@2x.png 2x">`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`srcset="a.png 1x, a@2x.png 2x"`);
|
|
});
|
|
|
|
// ── Bypass regressions: SVG remote-fetch vectors ──
|
|
// The svg handling only stripped <script> and the javascript: scheme, so a
|
|
// plain https:// href on <image>/<use>/<feImage> survived and Chromium
|
|
// fetched it at print time.
|
|
|
|
test("neutralizes remote <image href> inside <svg> blocks", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><image href="https://evil.example/x.png"/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain(`href="#"`);
|
|
});
|
|
|
|
test("neutralizes remote <use xlink:href> inside <svg> blocks", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><use xlink:href="https://evil.example/defs.svg#icon"/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes protocol-relative and unquoted svg hrefs", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><image href=//evil.example/x.png /><use href='//evil.example/d.svg#i'/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes remote svg-element href even when the <svg> is never closed", () => {
|
|
// Chromium auto-closes an unclosed <svg> at EOF and still fetches.
|
|
const out = sanitizeUntrustedHtml(`<svg><image href="https://evil.example/x.png">`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes entity-obfuscated remote svg href (https)", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><image href="https://evil.example/x.png"/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("keeps local fragment href (#id) inside svg intact", () => {
|
|
const input = `<svg><defs><circle id="dot" r="2"/></defs><use href="#dot"/><use xlink:href="#dot"/></svg>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).toContain(`href="#dot"`);
|
|
expect(out).toContain(`xlink:href="#dot"`);
|
|
});
|
|
|
|
test("keeps local-file svg <image href> intact", () => {
|
|
expect(sanitizeUntrustedHtml(`<svg><image href="local.png"/></svg>`)).toContain(`href="local.png"`);
|
|
});
|
|
|
|
test("leaves regular <a href=\"https://…\"> hyperlinks alone (links don't fetch at print)", () => {
|
|
const input = `<a href="https://example.com/docs">docs</a>`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`href="https://example.com/docs"`);
|
|
});
|
|
|
|
// ── Bypass regressions: image-set() with bare quoted URL strings ──
|
|
// `image-set("https://…" 1x)` carries no url() token and no backslash, so
|
|
// the url()/escape passes never fired on it.
|
|
|
|
test("neutralizes remote image-set(...) in <style> blocks", () => {
|
|
const input = `<style>body { background: image-set("https://evil.example/a.png" 1x); color: blue; }</style>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
expect(out).toContain("color: blue");
|
|
});
|
|
|
|
test("neutralizes remote image-set(...) in style attributes", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background: image-set('https://evil.example/a.png' 1x)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes -webkit-image-set with a remote string argument", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>body{background:-webkit-image-set("//evil.example/a.png" 1x)}</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("keeps local image-set(...) functional", () => {
|
|
const input = `<style>body { background: image-set("local.png" 1x, "local@2x.png" 2x); }</style>`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`image-set("local.png" 1x, "local@2x.png" 2x)`);
|
|
});
|
|
|
|
test("neutralizes remote <video poster> and <source src>", () => {
|
|
const input = `<video poster="https://evil.example/p.jpg"><source src="https://evil.example/v.mp4"></video>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("leaves remote <img src> alone — the image inliner owns its blocked-remote placeholder", () => {
|
|
const input = `<img src="https://evil.example/px.gif">`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`src="https://evil.example/px.gif"`);
|
|
});
|
|
|
|
test("does NOT rewrite url(https://…) mentioned in code/prose text", () => {
|
|
// marked entity-encodes quotes in code spans, so this is plain text
|
|
// outside any <style> block or style attribute — must stay intact.
|
|
const input = `<code>background: url(https://example.com/a.png)</code>`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain("url(https://example.com/a.png)");
|
|
});
|
|
|
|
test("end-to-end: rendered document carries no remote fetch vector from raw HTML", () => {
|
|
const md = [
|
|
"# Doc",
|
|
`<style>@import url("https://evil.example/t.css"); h1{color:red}</style>`,
|
|
`<div style="background:url('https://evil.example/px.gif')">hi</div>`,
|
|
`<img src="a.png" srcset="https://evil.example/a.png 2x">`,
|
|
`<svg><image href="https://evil.example/s.png"/><use xlink:href="https://evil.example/d.svg#i"/></svg>`,
|
|
`<div style="background:image-set('https://evil.example/is.png' 1x)">x</div>`,
|
|
].join("\n\n");
|
|
const { bodyHtml } = render({ markdown: md });
|
|
expect(bodyHtml).not.toContain("evil.example");
|
|
});
|
|
|
|
test("end-to-end: unquoted and CSS-escaped vectors don't survive render()", () => {
|
|
const md = [
|
|
"# Doc",
|
|
`<style>@\\69mport "https://evil.example/b.css"; body{background:url("\\68ttps://evil.example/px.gif")}</style>`,
|
|
`<div style=background:url(https://evil.example/px.gif)>hi</div>`,
|
|
].join("\n\n");
|
|
const { bodyHtml } = render({ markdown: md });
|
|
expect(bodyHtml).not.toContain("evil.example");
|
|
expect(bodyHtml).not.toMatch(/@\\/);
|
|
});
|
|
});
|