Files
Garry Tan b805aa0113 feat: Confusion Protocol, Hermes + GBrain hosts, brain-first resolver (v0.18.0.0) (#1005)
* feat: add Confusion Protocol to preamble resolver

Injects a high-stakes ambiguity gate at preamble tier >= 2 so all
workflow skills get it. Fires when Claude encounters architectural
decisions, data model changes, destructive operations, or contradictory
requirements. Does NOT fire on routine coding.

Addresses Karpathy failure mode #1 (wrong assumptions) with an
inline STOP gate instead of relying on workflow skill invocation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add Hermes and GBrain host configs

Hermes: tool rewrites for terminal/read_file/patch/delegate_task,
paths to ~/.hermes/skills/gstack, AGENTS.md config file.

GBrain: coding skills become brain-aware when GBrain mod is installed.
Same tool rewrites as OpenClaw (agents spawn Claude Code via ACP).
GBRAIN_CONTEXT_LOAD and GBRAIN_SAVE_RESULTS NOT suppressed on gbrain
host, enabling brain-first lookup and save-to-brain behavior.

Both registered in hosts/index.ts with setup script redirect messages.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: GBrain resolver — brain-first lookup and save-to-brain

New scripts/resolvers/gbrain.ts with two resolver functions:
- GBRAIN_CONTEXT_LOAD: search brain for context before skill starts
- GBRAIN_SAVE_RESULTS: save skill output to brain after completion

Placeholders added to 4 thinking skill templates (office-hours,
investigate, plan-ceo-review, retro). Resolves to empty string on
all hosts except gbrain via suppressedResolvers.

GBRAIN suppression added to all 9 non-gbrain host configs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: wire slop:diff into /review as advisory diagnostic

Adds Step 3.5 to the review template: runs bun run slop:diff against
the base branch to catch AI code quality issues (empty catches,
redundant return await, overcomplicated abstractions). Advisory only,
never blocking. Skips silently if slop-scan is not installed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: add Karpathy compatibility note to README

Positions gstack as the workflow enforcement layer for Karpathy-style
CLAUDE.md rules (17K stars). Links to forrestchang/andrej-karpathy-skills.
Maps each Karpathy failure mode to the gstack skill that addresses it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: improve native OpenClaw thinking skills

office-hours: add design doc path visibility message after writing
ceo-review: add HARD GATE reminder at review section transitions
retro: add non-git context support (check memory for meeting notes)

Mirrors template improvements to hand-crafted native skills.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: update tests and golden fixtures for new hosts

- Host count: 8 → 10 (hermes, gbrain)
- OpenClaw adapter test: expects undefined (dead code removed)
- Golden ship fixtures: updated with Confusion Protocol + vendoring

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: regenerate all SKILL.md files

Regenerated from templates after Confusion Protocol, GBrain resolver
placeholders, slop:diff in review, HARD GATE reminders, investigation
learnings, design doc visibility, and retro non-git context changes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: update project documentation for v0.18.0.0

- CHANGELOG: add v0.18.0.0 entry (Confusion Protocol, Hermes, GBrain,
  slop in review, Karpathy note, skill improvements)
- CLAUDE.md: add hermes.ts and gbrain.ts to hosts listing
- README.md: update agent count 8→10, add Hermes + GBrain to table
- VERSION: bump to 0.18.0.0

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: sync package.json version to 0.18.0.0

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: extract Step 0 from review SKILL.md in E2E test

The review-base-branch E2E test was copying the full 1493-line
review/SKILL.md into the test fixture. The agent spent 8+ turns
reading it in chunks, leaving only 7 turns for actual work, causing
error_max_turns on every attempt.

Now extracts only Step 0 (base branch detection, ~50 lines) which is
all the test actually needs. Follows the CLAUDE.md rule: "NEVER copy
a full SKILL.md file into an E2E test fixture."

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: update GBrain and Hermes host configs for v0.10.0 integration

GBrain: add 'triggers' to keepFields so generated skills pass
checkResolvable() validation. Add version compat comment.

Hermes: un-suppress GBRAIN_CONTEXT_LOAD and GBRAIN_SAVE_RESULTS.
The resolvers handle GBrain-not-installed gracefully, so Hermes
agents with GBrain as a mod get brain features automatically.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: GBrain resolver DX improvements and preamble health check

Resolver changes:
- gbrain query → gbrain search (fast keyword search, not expensive hybrid)
- Add keyword extraction guidance for agents
- Show explicit gbrain put_page syntax with --title, --tags, heredoc
- Add entity enrichment with false-positive filter
- Name throttle error patterns (exit code 1, stderr keywords)
- Add data-research routing for investigate skill
- Expand skillSaveMap from 4 to 8 entries
- Add brain operation telemetry summary

Preamble changes:
- Add gbrain doctor --fast --json health check for gbrain/hermes hosts
- Parse check failures/warnings count
- Show failing check details when score < 50

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: preserve keepFields in allowlist frontmatter mode

The allowlist mode hard-coded name + description reconstruction but
never iterated keepFields for additional fields. Adding 'triggers'
to keepFields was a no-op because the field was silently stripped.

Now iterates keepFields and preserves any field beyond name/description
from the source template frontmatter, including YAML arrays.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add triggers to all 38 skill templates

Multi-word, skill-specific trigger keywords for GBrain's RESOLVER.md
router. Each skill gets 3-6 triggers derived from its "Use when asked
to..." description text. Avoids single generic words that would collide
across skills (e.g., "debug this" not "debug").

These are distinct from voice-triggers (speech-to-text aliases) and
serve GBrain's checkResolvable() validation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: regenerate all SKILL.md files and update golden fixtures

Regenerated from updated templates (triggers, brain placeholders,
resolver DX improvements, preamble health check). Golden fixtures
updated to match.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: settings-hook remove exits 1 when nothing to remove

gstack-settings-hook remove was exiting 0 when settings.json didn't
exist, causing gstack-uninstall to report "SessionStart hook" as
removed on clean systems where nothing was installed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: update project documentation for GBrain v0.10.0 integration

ARCHITECTURE.md: added GBRAIN_CONTEXT_LOAD and GBRAIN_SAVE_RESULTS
to resolver table.

CHANGELOG.md: expanded v0.18.0.0 entry with GBrain v0.10.0 integration
details (triggers, expanded brain-awareness, DX improvements, Hermes
brain support), updated date.

CLAUDE.md: added gbrain to resolvers/ directory comment.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: routing E2E stops writing to user's ~/.claude/skills/

installSkills() was copying SKILL.md files to both project-level
(.claude/skills/ in tmpDir) and user-level (~/.claude/skills/).
Writing to the user's real install fails when symlinks point to
different worktrees or dangling targets (ENOENT on copyFileSync).

Now installs to project-level only. The test already sets cwd to
the tmpDir, so project-level discovery works.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: scale Gemini E2E back to smoke test

Gemini CLI gets lost in worktrees on complex tasks (review times out
at 600s, discover-skill hits exit 124). Nobody uses Gemini for gstack
skill execution. Replace the two failing tests (gemini-discover-skill
and gemini-review-findings) with a single smoke test that verifies
Gemini can start and read the README. 90s timeout, no skill invocation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-16 10:41:38 -07:00

230 lines
7.8 KiB
Cheetah

---
name: devex-review
preamble-tier: 3
version: 1.0.0
description: |
Live developer experience audit. Uses the browse tool to actually TEST the
developer experience: navigates docs, tries the getting started flow, times
TTHW, screenshots error messages, evaluates CLI help text. Produces a DX
scorecard with evidence. Compares against /plan-devex-review scores if they
exist (the boomerang: plan said 3 minutes, reality says 8). Use when asked to
"test the DX", "DX audit", "developer experience test", or "try the
onboarding". Proactively suggest after shipping a developer-facing feature. (gstack)
voice-triggers:
- "dx audit"
- "test the developer experience"
- "try the onboarding"
- "developer experience test"
triggers:
- live dx audit
- test developer experience
- measure onboarding time
allowed-tools:
- Read
- Edit
- Grep
- Glob
- Bash
- AskUserQuestion
- WebSearch
---
{{PREAMBLE}}
{{BASE_BRANCH_DETECT}}
{{BROWSE_SETUP}}
# /devex-review: Live Developer Experience Audit
You are a DX engineer dogfooding a live developer product. Not reviewing a plan.
Not reading about the experience. TESTING it.
Use the browse tool to navigate docs, try the getting started flow, and screenshot
what developers actually see. Use bash to try CLI commands. Measure, don't guess.
{{DX_FRAMEWORK}}
## Scope Declaration
Browse can test web-accessible surfaces: docs pages, API playgrounds, web dashboards,
signup flows, interactive tutorials, error pages.
Browse CANNOT test: CLI install friction, terminal output quality, local environment
setup, email verification flows, auth requiring real credentials, offline behavior,
build times, IDE integration.
For untestable dimensions, use bash (for CLI --help, README, CHANGELOG) or mark as
INFERRED from artifacts. Never guess. State your evidence source for every score.
## Step 0: Target Discovery
1. Read CLAUDE.md for project URL, docs URL, CLI install command
2. Read README.md for getting started instructions
3. Read package.json or equivalent for install commands
If URLs are missing, AskUserQuestion: "What's the URL for the docs/product I should test?"
### Boomerang Baseline
Check for prior /plan-devex-review scores:
```bash
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
~/.claude/skills/gstack/bin/gstack-review-read 2>/dev/null | grep plan-devex-review || echo "NO_PRIOR_PLAN_REVIEW"
```
If prior scores exist, display them. These are your baseline for the boomerang comparison.
## Step 1: Getting Started Audit
Navigate to the docs/landing page via browse. Screenshot it.
```
GETTING STARTED AUDIT
=====================
Step 1: [what dev does] Time: [est] Friction: [low/med/high] Evidence: [screenshot/bash output]
Step 2: [what dev does] Time: [est] Friction: [low/med/high] Evidence: [screenshot/bash output]
...
TOTAL: [N steps, M minutes]
```
Score 0-10. Load "## Pass 1" from dx-hall-of-fame.md for calibration.
## Step 2: API/CLI/SDK Ergonomics Audit
Test what you can:
- CLI: Run `--help` via bash. Evaluate output quality, flag design, discoverability.
- API playground: Navigate via browse if one exists. Screenshot.
- Naming: Check consistency across the API surface.
Score 0-10. Load "## Pass 2" from dx-hall-of-fame.md for calibration.
## Step 3: Error Message Audit
Trigger common error scenarios:
- Browse: Navigate to 404 pages, submit invalid forms, try unauthenticated access
- CLI: Run with missing args, invalid flags, bad input
Screenshot each error. Score against the Elm/Rust/Stripe three-tier model.
Score 0-10. Load "## Pass 3" from dx-hall-of-fame.md for calibration.
## Step 4: Documentation Audit
Navigate the docs structure via browse:
- Check search functionality (try 3 common queries)
- Verify code examples are copy-paste-complete
- Check language switcher behavior
- Check information architecture (can you find what you need in <2 min?)
Screenshot key findings. Score 0-10. Load "## Pass 4" from dx-hall-of-fame.md.
## Step 5: Upgrade Path Audit
Read via bash:
- CHANGELOG quality (clear? user-facing? migration notes?)
- Migration guides (exist? step-by-step?)
- Deprecation warnings in code (grep for deprecated/obsolete)
Score 0-10. Evidence: INFERRED from files. Load "## Pass 5" from dx-hall-of-fame.md.
## Step 6: Developer Environment Audit
Read via bash:
- README setup instructions (steps? prerequisites? platform coverage?)
- CI/CD configuration (exists? documented?)
- TypeScript types (if applicable)
- Test utilities / fixtures
Score 0-10. Evidence: INFERRED from files. Load "## Pass 6" from dx-hall-of-fame.md.
## Step 7: Community & Ecosystem Audit
Browse:
- Community links (GitHub Discussions, Discord, Stack Overflow)
- GitHub issues (response time, templates, labels)
- Contributing guide
Score 0-10. Evidence: TESTED where web-accessible, INFERRED otherwise.
## Step 8: DX Measurement Audit
Check for feedback mechanisms:
- Bug report templates
- NPS or feedback widgets
- Analytics on docs
Score 0-10. Evidence: INFERRED from files/pages.
## DX Scorecard with Evidence
```
+====================================================================+
| DX LIVE AUDIT — SCORECARD |
+====================================================================+
| Dimension | Score | Evidence | Method |
|----------------------|--------|----------|----------|
| Getting Started | __/10 | [screenshots] | TESTED |
| API/CLI/SDK | __/10 | [screenshots] | PARTIAL |
| Error Messages | __/10 | [screenshots] | PARTIAL |
| Documentation | __/10 | [screenshots] | TESTED |
| Upgrade Path | __/10 | [file refs] | INFERRED |
| Dev Environment | __/10 | [file refs] | INFERRED |
| Community | __/10 | [screenshots] | TESTED |
| DX Measurement | __/10 | [file refs] | INFERRED |
+--------------------------------------------------------------------+
| TTHW (measured) | __ min | [step count] | TESTED |
| Overall DX | __/10 | | |
+====================================================================+
```
## Boomerang Comparison
If /plan-devex-review scores exist from the baseline check:
```
PLAN vs REALITY
================
| Dimension | Plan Score | Live Score | Delta | Alert |
|------------------|-----------|-----------|-------|-------|
| Getting Started | __/10 | __/10 | __ | ⚠/✓ |
| API/CLI/SDK | __/10 | __/10 | __ | ⚠/✓ |
| Error Messages | __/10 | __/10 | __ | ⚠/✓ |
| Documentation | __/10 | __/10 | __ | ⚠/✓ |
| Upgrade Path | __/10 | __/10 | __ | ⚠/✓ |
| Dev Environment | __/10 | __/10 | __ | ⚠/✓ |
| Community | __/10 | __/10 | __ | ⚠/✓ |
| DX Measurement | __/10 | __/10 | __ | ⚠/✓ |
| TTHW | __ min | __ min | __ min| ⚠/✓ |
```
Flag any dimension where live score < plan score - 2 (reality fell short of plan).
## Review Log
**PLAN MODE EXCEPTION — ALWAYS RUN:**
```bash
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"devex-review","timestamp":"TIMESTAMP","status":"STATUS","overall_score":N,"product_type":"TYPE","tthw_measured":"TTHW","dimensions_tested":N,"dimensions_inferred":N,"boomerang":"YES_OR_NO","commit":"COMMIT"}'
```
{{REVIEW_DASHBOARD}}
{{PLAN_FILE_REVIEW_REPORT}}
{{LEARNINGS_LOG}}
## Next Steps
After the audit, recommend:
- Fix the gaps found (specific, actionable fixes)
- Re-run /devex-review after fixes to verify improvement
- If boomerang showed significant gaps, re-run /plan-devex-review on the next feature plan
## Formatting Rules
* NUMBER issues (1, 2, 3...) and LETTERS for options (A, B, C...).
* Rate every dimension with evidence source.
* Screenshots are the gold standard. File references are acceptable. Guesses are not.