Files
gstack/make-pdf/test/toc-anchors.test.ts
ac20ef1e13 v1.91.16.0 fix: safe installs and upgrades, skills start everywhere, truthful completion (parallel wave) (#3014)
* fix(make-pdf,design): real TOC page numbers and anchors; design models move to gpt-5.5 + gpt-image-2 (#2903, #2807)

* ci: pin every action to a SHA, Scorecard, checksummed Bun, scoped Codex CLI in the CI image, macOS named-regressions job (#1948, #1706, #1997)

* fix(cso,browse): Windows/macOS lease identity, retention skips bad runs, truthful 'not assessed' reports, env.kv false positive, Windows browse spawn fixes (#2894, #2912, #2048, #2637, #2805)

* fix(outside-voice): one Codex model precedence for probe and dispatch, bounded timeouts with KILL escalation, probe cache identity, guarded mktemp, skills hidden in nested Codex (#2776, #2914, #2787, #2881, #2847)

* feat(setup): install registry, ./setup --status, staged activation, per-scope migrations, host tiers and conformance kit, OpenCode/Hermes fixes, Copilot CLI (experimental), disabled_skills, slimmer CLAUDE.md (#1925, #2879, #2347, #2338, #2626, #2629, #2825, #2015, #393, #1206, #2096)

Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com>
Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com>
Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com>

* fix(preamble): skills start in worktree-isolated Claude Code sessions — one literal skill-start line, context-recovery helper, no eval in skill blocks, $N token tripwire, honest plan-mode precedence (#2763, #2896, #2851)

* fix(setup): per-install renders for renamed, vendored and custom-config installs, space-safe alias roots, per-host /cso launcher path (#1882, #2906)

* test: free tests never write the real HOME (home-write tripwire), no orphaned browse daemons, symlinked-TMPDIR (macOS) fixes, gbrain-on-PATH isolation (#2895, #2816, #2829, #2841, #2982, #2911, #2909, #2908, #2910)

* chore: integrate wave follow-ups — regenerate all hosts, README model docs, TODOS, touchfiles, duration seeds, Bun 1.3 telemetry test fix, replay fixtures pinned to their recorded bytes

* v1.91.14.0: release metadata

* test(browse): group-kill cleanup falls back to the leader when macOS returns EPERM for a live group

* ci: Codex login steps run under bash (the CI container's default sh rejects pipefail)

* fix: full-suite repairs — private state roots for 7 real-HOME writers, truthful home-guard attribution with --attribute-home, gstack-paths shim in ship-hook fixtures, Copilot in team-init probes, test-of-test detector, cookie review fixture pinned to the approved excerpt

* fix(windows): LF for Dockerfiles, normalized home-guard exclusions, path.relative fixture containment, ship push test spawn timeouts

* test(design-detect): widen the whole-scan budget test's timing margins so a loaded macOS runner can't time out the single-batch call

* fix(evals): qa protocol names defined for the judge, async PTY judge so overlapping sessions keep their cleanup deadline, bws setup cases use the standard JUDGE_MS tier

* test(pty): the non-blocking judge case is POSIX-only (its fake judge is a shebang script, like the PTY harness it covers)

* test(evals): ship-coverage-audit names absolute skill paths, uses Read, and skips the Step 7 artifact nothing consumes (removes the mechanism behind 3 of 4 historical timeouts)

* test: deflake terminal-agent concurrent startup (write the placeholder record before spawning, like the product) and qa-evidence resumed pipe (barrier on a full high-water mark instead of a sleep)

* fix(design): daemon log stream handles open errors instead of crashing the daemon; shutdown test awaits the stubbed exit

* test(evals): skillify checks the product's resolved state root (no GSTACK_HOME bypass), negative cases check every root; tpa shims live outside the agent's cwd and answer consistently

* test(evals): coverage-audit detector splits parallel columns at │ rails and [+] groups; coverage prompts name absolute skill paths; TODOs from the gate eval census

* fix(plan-eng-review): scope gate always sends the menu (no headless 'Scope pending' exit); PTY harness ends idle turn-ends and API-error panels promptly with a precise diagnostic

* test(evals): one position-bound coverage-read rule credits read-only && chains (labels, context ranges, git displays in either order) and still rejects forged output

* fix(ship): documentation section has one saved source inserted by cat (never retyped); spawned-marker evidence is the child output; refreshed codex/factory ship goldens

* test(docsync): the byte-exact insert positive is POSIX-only (the bash-command observer refuses backslash paths by design)

* test(evals): plan-design-with-ui focus-title rule accepts the comma-less 'dimensions or focus' wording (replayed on the captured CI run, negative controls kept)

* fix(qa-callers): exploratory preflight says the scope/method Reads come after exploratory.md; design-review scan check credits an executed scan proven by one engine run over the changed files

---------

Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com>
Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com>
Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com>
2026-10-03 07:54:09 -07:00

96 lines
4.6 KiB
TypeScript

/**
* #2903: TOC labels and link targets come from ONE heading inventory. Before
* the fix, addHeadingIds() numbered every H1-H3 while extractHeadings()
* dropped empty ones, so one empty heading shifted every later link
* (`#toc-0` pointed at the empty H1, the "Alpha" entry at nothing named
* Alpha); a user `id="toc-1"` or a `data-id` attribute did the same.
*
* The oracle here is the HTML fragment rule: a link `#x` lands on the FIRST
* element whose id is x. Every TOC entry must land on a heading with the
* entry's own text.
*/
import { describe, expect, test } from "bun:test";
import { render } from "../src/render";
function stripTags(s: string): string {
return s.replace(/<[^>]+>/g, "").trim();
}
function decode(s: string): string {
return s.replace(/&quot;/g, '"').replace(/&#39;/g, "'").replace(/&lt;/g, "<").replace(/&gt;/g, ">").replace(/&amp;/g, "&");
}
/** [entry label, text of the element the link lands on] for every TOC entry. */
function tocLandings(html: string): Array<{ label: string; landsOn: string | null }> {
const toc = html.match(/<section class="toc">[\s\S]*?<\/section>/)?.[0] ?? "";
const body = html.slice(html.indexOf(toc) + toc.length);
const entries = [...toc.matchAll(/<a href="#([^"]*)">([\s\S]*?)<\/a>/g)];
return entries.map(([, href, label]) => {
const id = decode(href);
let landsOn: string | null = null;
for (const m of body.matchAll(/<([a-zA-Z][a-zA-Z0-9]*)\b([^>]*)>/g)) {
const attr = m[2].match(/\sid\s*=\s*(?:"([^"]*)"|'([^']*)'|([^\s"'>]+))/i);
if (!attr || decode(attr[1] ?? attr[2] ?? attr[3]) !== id) continue;
const rest = body.slice(m.index! + m[0].length);
landsOn = /^h[1-3]$/i.test(m[1]) ? decode(stripTags(rest.slice(0, rest.search(new RegExp(`</${m[1]}>`, "i"))))) : `<${m[1]}>`;
break;
}
return { label: decode(label), landsOn };
});
}
describe("TOC anchors: one inventory for labels and targets (#2903)", () => {
test("an empty H1 does not shift the links after it", () => {
const { html } = render({ markdown: `#\n\n# Alpha\n\nx\n\n# Beta\n\ny\n`, toc: true });
const landings = tocLandings(html);
expect(landings.map((l) => l.label)).toEqual(["Alpha", "Beta"]);
for (const l of landings) expect(l.landsOn).toBe(l.label);
});
test("an image-only heading gets no entry and shifts nothing", () => {
const { html } = render({ markdown: `# ![logo](data:image/png;base64,AAAA)\n\n## Real\n\nx\n`, toc: true });
expect(tocLandings(html)).toEqual([{ label: "Real", landsOn: "Real" }]);
});
test("custom ids are kept; a user id that squats toc-N never captures a generated link", () => {
const md = [
"# Intro", "",
"## Plain", "",
`<h2 id="toc-1">Squatter</h2>`, "",
`<h2 id="custom">Custom</h2>`, "",
].join("\n");
const { html } = render({ markdown: md, toc: true });
const landings = tocLandings(html);
expect(landings.map((l) => l.label)).toEqual(["Intro", "Plain", "Squatter", "Custom"]);
for (const l of landings) expect(l.landsOn).toBe(l.label);
expect(html).toContain(`<a href="#custom">Custom</a>`);
expect(html).toContain(`<a href="#toc-1">Squatter</a>`);
});
test("a duplicate id (first owner wins) gets a fresh id instead of linking to the first heading", () => {
const md = [`<h2 id="dup">First</h2>`, "", `<h2 id="dup">Second</h2>`, "", `<div id="taken">x</div>`, "", `<h2 id="taken">Third</h2>`, ""].join("\n");
const { html } = render({ markdown: md, toc: true });
const landings = tocLandings(html);
expect(landings.map((l) => l.label)).toEqual(["First", "Second", "Third"]);
for (const l of landings) expect(l.landsOn).toBe(l.label);
});
test("data-id, unquoted and empty id attributes are read as what they are", () => {
const md = [`<h2 data-id="z">DataId</h2>`, "", `<h2 id=bare>Bare</h2>`, "", `<h2 id="">EmptyId</h2>`, ""].join("\n");
const { html } = render({ markdown: md, toc: true });
const landings = tocLandings(html);
expect(landings.map((l) => l.label)).toEqual(["DataId", "Bare", "EmptyId"]);
for (const l of landings) expect(l.landsOn).toBe(l.label);
expect(html).toContain(`<a href="#bare">Bare</a>`);
});
test("each TOC page cell targets the same id as its link", () => {
const { html } = render({ markdown: `#\n\n# A\n\n<h2 id="k&amp;v">B</h2>\n`, toc: true });
const toc = html.match(/<section class="toc">[\s\S]*?<\/section>/)![0];
const hrefs = [...toc.matchAll(/href="#([^"]*)"/g)].map((m) => m[1]);
const cells = [...toc.matchAll(/data-toc-target="([^"]*)"/g)].map((m) => m[1]);
expect(cells).toEqual(hrefs);
expect(hrefs).toHaveLength(2);
});
});