mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-16 09:55:29 +02:00
* feat: add a restricted and supervised Claude Code runner Preserve configured authentication and models while enforcing tool access, strict completion JSON, bounded output and process cleanup. Cover argv, failure handling, session metadata and Windows process containment. * feat: route outside reviews by harness and migrate wrapper installs Use Claude Code from Codex and Codex from other supported hosts, with shared invocation rendering, positive gate validation and per-phase provenance. Rename /claude to /claude-code, repair managed shared and copied installations safely, and generate native Kiro skills. Add installed-workflow, failure-injection and live cross-harness regression coverage. * test: recognize CEO mode labels without terminal spacing The paid workflow rendered SCOPEEXPANSION at option 4, but its driver required a literal space. Match the leading mode title without cursor-spacing artifacts and ignore adjacent preview text. Preserve missing-target failures and downstream posture assertions. * test: isolate plan-count fixtures before starting review workflows Seed the complete test plan in a private git repository before launching Claude, so a bare slash command cannot review the live workspace while a delayed fixture message remains queued. Preserve count thresholds, parsers and budgets. Add initial-context and installed-discovery tests, and retain startup/terminal diagnostics on failed evaluations. * test: stabilize review fixtures and Claude eval startup Preserve source boundaries in workflow judge inputs, isolate CEO mode plans, and wait for interactive trust input readiness. Keep startup failure evidence and retain existing models, budgets, and assertions. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: classify collapsed review modes and isolate seeded findings Keep review questions out of the setup count when terminal cursor positioning removes spaces. State existing webhook safeguards so the five-finding control measures its seeded defects without accidental extra security and concurrency gaps. Preserve question bands and the paired control. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: isolate browser daemon state across free shards Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: stabilize native review counting and interactive navigation Co-Authored-By: OpenAI Codex <noreply@openai.com> * chore: prepare v1.82.0.0 release Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: eliminate browser and process-cleanup test flakes Pin every CI surface to Bun 1.4.0 to avoid extra-stdio finalizers closing reused live sockets. Add an isolated GC/listener regression that fails on Bun 1.3.13, and prevent coordinated rollback to an affected CI runtime. Check renderer cleanup against the render's own staging directory so concurrent renders cannot invalidate the assertion. Make the no-pgrep process-tree walk tolerate disappearing /proc entries, and synchronize its test fixture through child readiness and pipe EOF instead of sleeps. Validation: 9,157 passed, 31 skipped, zero failures across 556 files with retries disabled. Build, all-host generation freshness, and skill checks passed. All three races have failing-before/passing-after regressions. * fix: count completed native review questions in evals * fix: drive review navigation from confirmed native choices * fix: require complete section-loading eval reports * test: isolate telemetry HTTP transport from local assertions * fix: keep review input on the active native question * test: let tunnel revocation daemon choose an available port * test: allocate available ports for pairing and watchdog fixtures * fix: stabilize planning eval navigation and phase reporting * test: isolate installed runtime paths in planning evals * test: stabilize review evidence and concurrent refresh fixtures * fix: resolve design findings before editing the plan * fix: honor and persist disabled outside plan reviews * fix: preserve planning decisions and terminal evidence Load installed host reviews at autoplan phase entry and wait for completed reviewers and saved artifacts. Reuse approved remedies while preserving individual finding decisions. Drive interactive evals from the current terminal viewport, bind native questions across scrolling, and require complete native report evidence. Cover captured stale menus, permission lifecycles, setup classification, and disabled-review tool availability with deterministic regressions. Advance release metadata and the upgrade migration to the unclaimed 1.83.0.0 slot. * fix: drive native review questions and preserve current plans Use the native single-choice keyboard protocol and current terminal viewport, with per-question navigation inside packets and completed-call coverage. Keep permissions, multi-select menus, and Submit controls distinct. Send Autoplan reviewers the amended implementation plan, keep its review record separate, and supply retained application contracts in the chain fixture. Clarify individual DevEx decisions and complete CEO fix options; use one active plan destination for the section-loading report. * fix: preserve complete plan-review decisions * fix: recognize native plan dialogs and reviewer controls * fix: preserve review decisions and phase completion * fix: recognize completed reviews without losing findings * fix: preserve review continuity and native eval completion * test: fix native review completion and eval retry isolation * test: handle native review menus and complete eval fixtures * test: fix native review setup, completion, and isolation failures * test: limit native skill discovery to runtime assets * fix: bind Autoplan reviews to full ordered phase inputs * test: fix planning eval routing, counting, and timeout handling * chore: advance queued release to v1.84.0.0 * fix: preserve complete review inputs and planning decisions * fix: reconcile review approvals and preserve phase obligations * fix: preserve review obligations and unblock eval permissions Carry recorded Autoplan requirements into blind phase inputs, require Eng review approvals before exit, and exercise combined asynchronous flows in CEO reviews. Correct native finding and handoff classification and unblock repeated report edits using scoped request identities. * fix: retain plan requirements and complete native review dialogs * fix: complete native review prompts and retain plan references * fix: preserve review inputs and classify native eval evidence * fix: check competing completion orders in CEO reviews * fix: recognize review decisions and require phase methodology Require the current phase methodology before Autoplan snapshots. Correct substantive decision, closed handoff, and cache-finding classification, and honor the recommended implementation approach in native review dialogs. Add captured-transcript regressions without changing review thresholds, provider models, retries, or deadlines. * test: bind native review decisions and close completed handoffs * fix: complete review dialogs and verify methodology delivery * fix: preserve review evidence and unblock native eval prompts * fix: handle native review question completions * fix: recognize native review narration and controls * fix: count native review decisions and isolate eval fixtures * test: verify seeded review coverage and current artifact permissions * test: isolate model and brain-aware skill renders * fix: repair native workflow evaluation and clarify review steps * fix: stabilize workflow eval evidence and review guidance * test: repair native workflow observation and fixture isolation * fix: recognize completed workflow evidence and owned skill reads * test: repair seeded workflow delivery and completion evidence * test: recognize current review evidence across native forms * test: handle native review variants and permission redraws * fix: honor review preferences and recognize native eval evidence * test: recognize completed review decisions and queued permissions * test: match current review contracts and partial-line edits * test: recognize completed workflow evidence and bounded human waits * fix: preserve review entry gates and native eval interactions * fix: recognize native workflow evidence and preserve review gates * test: recognize current review evidence and preconfigure workflow fixtures * test: recognize completed review findings and scoped artifact permissions * fix: stabilize native workflow review and permission evidence * fix: recognize current review evidence and scoped edit confirmations Clarify Design and engineering review entry instructions and Design scoring. Recognize required legacy coverage and public Autoplan completion recaps. Bind the pending Edit confirmation to its exact file, ordered digest, and one-request approval when a preceding command display remains visible. Keep reviews within their existing size limits and preserve scope gates when extracting workflow fixtures from either supported preamble header. Keep failure outcomes, review thresholds, provider choices, and eval budgets. * fix: recover review workflow progress and eval evidence * fix: recognize valid review evidence and scope selection * test: fix review evidence parsing and repeated artifact prompts * test: recognize valid review decisions and pending native cards * fix(plan-eng-review): keep final navigation consistent with approved tasks * test: recognize valid review evidence and bind legacy diff requests * fix: stabilize review eval evidence and harness repair guidance * docs: update project documentation for v1.85.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: fix Windows CI fixtures and credential scan Rebase captured JSON values and filesystem evidence using the appropriate path convention. Compile native fake CLIs on Windows and synchronize pipe holder readiness, with cleanup retained when assertions fail. Assemble synthetic credential fixtures at runtime so the added-line scan keeps enforcing the same gate without flagging its own rejection controls. Discover generated skills directly for the empty-find regression check, avoiding a recursive scan through saved evaluation artifacts and dependencies. * fix: preserve source renders on Windows Compare canonical generator paths using native separators so an output sidecar pointing at the source cannot overwrite its skill or metadata. Keep the regression fixture isolated from the real checkout and expose freshness diagnostics before asserting subprocess status. Detach Windows drain-test pipe holders from the fake provider's automatic child cleanup while preserving the enclosing runner job and its assertions. * fix: clarify outside review fallback and CEO decisions Render one applicable own-harness fallback path and retain native review, disabled policy, and missing-coverage semantics. Align report field names and mode labels, and make the existing per-cut scope approval explicit. Regenerate skill outputs and keep the workflow judge's model, thresholds, and retry policy unchanged. * chore: move release to free version slot (v1.86.0.0) PR #2852 now claims v1.85.0.0. Align the release metadata and rename migration so upgrades from that version still receive it. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: include engineering review prerequisites and restore branch context * fix: recognize coverage diagrams and clarify design review instructions * fix: preserve file identities and join Windows test processes --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
219 lines
12 KiB
TypeScript
219 lines
12 KiB
TypeScript
import { expect, test } from 'bun:test';
|
|
import { ceoFirstReviewAUQ, ceoStep0Boundary, nativePlanCallFingerprint, planCountQuestionPhase } from './helpers/claude-pty-runner';
|
|
import captured from './fixtures/ceo-annotation-aj.json';
|
|
import { E2E_TOUCHFILES } from './helpers/touchfiles-data';
|
|
|
|
const call = (index = 3): any => structuredClone(captured.cases.paired.calls[index]);
|
|
const fp = (c: any) => nativePlanCallFingerprint(c, 0, true);
|
|
function edit(c: any, change: (s: string) => string) {
|
|
const q = c.questions[0], answer = c.answers[q.question];
|
|
q.question = change(q.question); c.answers = { [q.question]: answer };
|
|
}
|
|
|
|
test('completed native receipt and retry findings retain identity through section annotations', () => {
|
|
for (const index of [3, 4]) expect(ceoFirstReviewAUQ(fp(call(index)))).toBe(true);
|
|
});
|
|
|
|
test('actual setup remains excluded before the two completed assertion findings', () => {
|
|
let started = false;
|
|
const phases = captured.cases.paired.calls.map(c => {
|
|
const phase = planCountQuestionPhase(fp(c), started, ceoStep0Boundary, ceoFirstReviewAUQ);
|
|
started = phase.reviewStarted;
|
|
return phase.preReview;
|
|
});
|
|
expect(phases).toEqual([true, true, true, false, false]);
|
|
const approach = structuredClone(captured.cases.distinct.calls[2]);
|
|
expect(ceoFirstReviewAUQ(fp(approach))).toBe(false);
|
|
});
|
|
|
|
test('the new captured inputs belong only to the existing CEO count owner', () => {
|
|
for (const dependency of ['test/ceo-annotation-aj.test.ts', 'test/fixtures/ceo-annotation-aj.json']) {
|
|
expect(Object.entries(E2E_TOUCHFILES).filter(([, paths]) => paths.includes(dependency)).map(([name]) => name))
|
|
.toEqual(['plan-ceo-finding-count']);
|
|
}
|
|
});
|
|
|
|
test('section references do not replace finding or native option identity', () => {
|
|
for (const index of [3, 4]) {
|
|
const c = call(index);
|
|
edit(c, s => s.replace(/\(Sections? [^)]+\)/, '(Sections 3, 5 and 8, Error Handling)'));
|
|
expect(ceoFirstReviewAUQ(fp(c))).toBe(true);
|
|
c.answers[c.questions[0].question] = c.questions[0].options[1].label;
|
|
expect(ceoFirstReviewAUQ(fp(c))).toBe(true);
|
|
const renamed = call(index), q = renamed.questions[0], old = String(index - 2);
|
|
edit(renamed, s => s.replace(new RegExp('Finding F' + old), 'Finding F9')
|
|
.replace(new RegExp('^Recommendation: ' + old, 'm'), 'Recommendation: 9')
|
|
.replace(new RegExp('^' + old + '([A-Z][)])', 'gm'), '9$1'));
|
|
q.header = q.header.replace(/^F\d+/, 'F9');
|
|
q.options.forEach((o: any) => { o.label = o.label.replace(/^\d+/, '9'); });
|
|
renamed.answers = { [q.question]: q.options[0].label };
|
|
expect(ceoFirstReviewAUQ(fp(renamed))).toBe(true);
|
|
}
|
|
});
|
|
|
|
test('source frames and conditional or missing assessments cannot supply a current finding', () => {
|
|
for (const index of [3, 4]) for (const change of [
|
|
(s: string) => 'Example: ' + s,
|
|
(s: string) => '> ' + s,
|
|
(s: string) => '```\n' + s + '\n```',
|
|
(s: string) => s.replace(/^ELI10: (.+)$/m, 'ELI10: `$1`'),
|
|
(s: string) => s.replace(/^ELI10: (.+)$/m, 'ELI10: "$1"'),
|
|
(s: string) => s.replace(/^ELI10: /m, 'ELI10: If '),
|
|
(s: string) => s.replace(/^ELI10: /m, 'ELI10: Suppose '),
|
|
(s: string) => s.replace(/^ELI10: .+$/m, ''),
|
|
(s: string) => s + '\nELI10: A second contradictory assessment.',
|
|
(s: string) => s.replace(/: the (success|repeated)/, ': the hypothetical $1'),
|
|
(s: string) => s.replace(/\(Sections? [^)]+\)/, '(Section 6, Quoted Source)'),
|
|
(s: string) => s.replace(/\(Sections? [^)]+\)/, '(Section 6, Historical Example)'),
|
|
]) { const c = call(index); edit(c, change); expect(ceoFirstReviewAUQ(fp(c))).toBe(false); }
|
|
});
|
|
|
|
test('same-brief withdrawals defeat a finding while attributed historical quotes do not', () => {
|
|
for (const index of [3, 4]) {
|
|
for (const tail of ['This issue is withdrawn.', 'We have withdrawn this finding.',
|
|
'There is no current defect or unresolved issue.', `F${index - 2} is rejected.`]) {
|
|
const c = call(index); edit(c, s => s + '\n' + tail); expect(ceoFirstReviewAUQ(fp(c))).toBe(false);
|
|
}
|
|
const quoted = call(index); edit(quoted, s => s + '\nOld note: "This issue is withdrawn."');
|
|
expect(ceoFirstReviewAUQ(fp(quoted))).toBe(true);
|
|
}
|
|
});
|
|
|
|
test('administrative options and stale action rows do not amend the current contract', () => {
|
|
for (const index of [3, 4]) {
|
|
for (const wording of ['Start review', 'Pause', 'Write the completed report']) {
|
|
const stale = call(index), native = stale.questions[0];
|
|
native.options.forEach((o: any, i: number) => {
|
|
o.label = `${index - 2}${String.fromCharCode(65 + i)}: ${wording}`;
|
|
o.description = wording;
|
|
});
|
|
stale.answers = { [native.question]: native.options[0].label };
|
|
expect(ceoFirstReviewAUQ(fp(stale))).toBe(false);
|
|
}
|
|
const c = call(index), q = c.questions[0];
|
|
q.options.forEach((o: any, i: number) => {
|
|
o.label = `${index - 2}${String.fromCharCode(65 + i)}: Archive the completed report ${i}`;
|
|
o.description = 'Save the completed review for reference.';
|
|
});
|
|
c.answers = { [q.question]: q.options[0].label };
|
|
expect(ceoFirstReviewAUQ(fp(c))).toBe(false);
|
|
const noGap = call(index);
|
|
edit(noGap, s => s.replace(/^D\d+[^\n]+/, `D4 — Finding F${index - 2} (Sections 2 and 6): where should the completed report be stored?`)
|
|
.replace(/^ELI10: .+$/m, 'ELI10: The review is complete and all assertions already enforce the full contract.'));
|
|
expect(ceoFirstReviewAUQ(fp(noGap))).toBe(false);
|
|
const negated = call(index);
|
|
edit(negated, s => s.replace(/asserts only/, 'does not assert only')
|
|
.replace(/^ELI10: .+$/m, 'ELI10: The assertions enforce the complete receipt and retry contracts.'));
|
|
expect(ceoFirstReviewAUQ(fp(negated))).toBe(false);
|
|
}
|
|
});
|
|
|
|
test('completion, recommendation, identity and actual offered options remain required', () => {
|
|
for (const index of [3, 4]) for (const mutate of [
|
|
(c: any) => { c.answered = false; },
|
|
(c: any) => { c.failed = true; },
|
|
(c: any) => { c.unansweredQuestionIndices = [0]; },
|
|
(c: any) => { c.sessionId = ''; },
|
|
(c: any) => { c.answers = {}; },
|
|
(c: any) => { c.answers[c.questions[0].question] = 'Foreign answer'; },
|
|
(c: any) => { c.questions[0].multiSelect = true; },
|
|
(c: any) => { c.questions.push(structuredClone(c.questions[0])); },
|
|
(c: any) => { c.questions[0].header = 'Approach'; },
|
|
(c: any) => { c.questions[0].header = 'Finding 99'; },
|
|
(c: any) => { c.questions[0].options[1].description = ''; },
|
|
(c: any) => { c.questions[0].options[1].label = '99B: Different finding'; },
|
|
(c: any) => edit(c, s => s.replace(/^Recommendation: .+$/m, 'Recommendation: 99Z')),
|
|
(c: any) => edit(c, s => s.replace(/^Recommendation: .+$/m, '')),
|
|
(c: any) => edit(c, s => s + '\n<gstack-qid:plan-eng-review-finding>'),
|
|
]) { const c = call(index); mutate(c); expect(ceoFirstReviewAUQ(fp(c))).toBe(false); }
|
|
for (const index of [3, 4]) {
|
|
const original = fp(call(index));
|
|
expect(ceoFirstReviewAUQ({ ...original, signature: 'foreign:call' })).toBe(false);
|
|
expect(ceoFirstReviewAUQ({ ...original, nativeCall: undefined })).toBe(false);
|
|
expect(ceoFirstReviewAUQ({ ...original, options: original.options.slice(1) })).toBe(false);
|
|
}
|
|
});
|
|
|
|
test('completed dotted issue briefs retain their full identity and section option binding', () => {
|
|
for (const source of captured.cases.distinct.calls.slice(4)) {
|
|
expect(ceoFirstReviewAUQ(fp(source))).toBe(true);
|
|
}
|
|
let started = false;
|
|
const phases = captured.cases.distinct.calls.map(c => {
|
|
const phase = planCountQuestionPhase(fp(c), started, ceoStep0Boundary, ceoFirstReviewAUQ);
|
|
started = phase.reviewStarted;
|
|
return phase.preReview;
|
|
});
|
|
expect(phases).toEqual([true, true, true, true, false, false, false, false, false]);
|
|
});
|
|
|
|
test('dotted issue syntax never supplies missing current defect or remedy evidence', () => {
|
|
for (const source of captured.cases.distinct.calls.slice(4)) {
|
|
const identity = /\(Issue ([\d.]+)\)/.exec(source.questions[0]!.question)![1]!;
|
|
for (const change of [
|
|
(s: string) => 'Example: ' + s,
|
|
(s: string) => s.replace(/^ELI10: /m, 'ELI10: If '),
|
|
(s: string) => s.replace(/^ELI10: /m, 'ELI10: Historical example: '),
|
|
(s: string) => s.replace(/^ELI10: (.+)$/m, 'ELI10: `$1`'),
|
|
(s: string) => s.replace(/^ELI10: .+$/m, ''),
|
|
(s: string) => s.replace(/^ELI10: .+$/m, 'ELI10: The completed review has no current defect or unresolved issue.'),
|
|
(s: string) => s.replace(/^ELI10: .+$/m, 'ELI10: The existing behavior satisfies every contract and needs no change.'),
|
|
(s: string) => s + '\nThis issue has been resolved.',
|
|
(s: string) => s + `\nIssue ${identity} is rejected.`,
|
|
(s: string) => s.replace(/^Recommendation: \d+[A-Z]/m, 'Recommendation: 99Z'),
|
|
(s: string) => s + '\n<gstack-qid:plan-eng-review-finding>',
|
|
]) { const c = structuredClone(source); edit(c, change); expect(ceoFirstReviewAUQ(fp(c))).toBe(false); }
|
|
const sourceOnly = structuredClone(source), q = sourceOnly.questions[0]!;
|
|
q.options.forEach((o, i) => { o.label = `${identity.split('.')[0]}${String.fromCharCode(65 + i)}: Archive the completed report ${i}`; o.description = 'Save the completed review.'; });
|
|
sourceOnly.answers = { [q.question]: q.options[0]!.label };
|
|
expect(ceoFirstReviewAUQ(fp(sourceOnly))).toBe(false);
|
|
const quoted = structuredClone(source); edit(quoted, s => s + `\nOld note: "Issue ${identity} is rejected."`);
|
|
expect(ceoFirstReviewAUQ(fp(quoted))).toBe(true);
|
|
}
|
|
});
|
|
|
|
test('dotted identities remain complete while the option prefix names the containing section', () => {
|
|
for (const source of captured.cases.distinct.calls.slice(4)) {
|
|
const identity = /\(Issue ([\d.]+)\)/.exec(source.questions[0]!.question)![1]!;
|
|
for (const mutate of [
|
|
(c: any) => { c.answered = false; },
|
|
(c: any) => { c.failed = true; },
|
|
(c: any) => { c.unansweredQuestionIndices = [0]; },
|
|
(c: any) => { c.answers = {}; },
|
|
(c: any) => { c.answers[c.questions[0].question] = 'Unrelated answer'; },
|
|
(c: any) => { c.questions[0].header = 'Approach'; },
|
|
(c: any) => { c.questions[0].header = `Finding ${identity.split('.')[0]}`; },
|
|
(c: any) => { c.questions[0].header = 'Issue 99.1'; },
|
|
(c: any) => { c.questions[0].options[1].label = '99B: Borrowed option'; },
|
|
(c: any) => { c.questions[0].options[1].description = ''; },
|
|
(c: any) => { c.questions[0].multiSelect = true; },
|
|
(c: any) => { c.questions.push(structuredClone(c.questions[0])); },
|
|
(c: any) => edit(c, s => s.replace(`Issue ${identity}`, 'Issue 1.0')),
|
|
]) { const c = structuredClone(source); mutate(c); expect(ceoFirstReviewAUQ(fp(c))).toBe(false); }
|
|
const header = structuredClone(source); header.questions[0]!.header = `Finding ${identity}`;
|
|
expect(ceoFirstReviewAUQ(fp(header))).toBe(true);
|
|
const localQid = structuredClone(source); edit(localQid, s => s + '\n<gstack-qid:plan-ceo-review-handler-correctness>');
|
|
expect(ceoFirstReviewAUQ(fp(localQid))).toBe(true);
|
|
expect(ceoFirstReviewAUQ({ ...fp(source), signature: 'foreign:call' })).toBe(false);
|
|
expect(ceoFirstReviewAUQ({ ...fp(source), nativeCall: undefined })).toBe(false);
|
|
}
|
|
});
|
|
|
|
|
|
test('an owning assessment declaration cannot relabel source or hypothetical prose as a current finding', () => {
|
|
for (const source of [...captured.cases.paired.calls.slice(3), ...captured.cases.distinct.calls.slice(4)]) {
|
|
for (const frame of [
|
|
'The following is a quoted source excerpt.',
|
|
'The following is a hypothetical example.',
|
|
'This assessment is only a historical example.',
|
|
]) {
|
|
const c = structuredClone(source);
|
|
edit(c, s => s.replace(/^ELI10: /m, 'ELI10: ' + frame + ' '));
|
|
expect(ceoFirstReviewAUQ(fp(c))).toBe(false);
|
|
}
|
|
const quoted = structuredClone(source);
|
|
edit(quoted, s => s.replace(/^(ELI10: .+)$/m, '$1 Old note: "The following is a hypothetical example."'));
|
|
expect(ceoFirstReviewAUQ(fp(quoted))).toBe(true);
|
|
}
|
|
});
|