mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-16 01:45:29 +02:00
* feat: add a restricted and supervised Claude Code runner Preserve configured authentication and models while enforcing tool access, strict completion JSON, bounded output and process cleanup. Cover argv, failure handling, session metadata and Windows process containment. * feat: route outside reviews by harness and migrate wrapper installs Use Claude Code from Codex and Codex from other supported hosts, with shared invocation rendering, positive gate validation and per-phase provenance. Rename /claude to /claude-code, repair managed shared and copied installations safely, and generate native Kiro skills. Add installed-workflow, failure-injection and live cross-harness regression coverage. * test: recognize CEO mode labels without terminal spacing The paid workflow rendered SCOPEEXPANSION at option 4, but its driver required a literal space. Match the leading mode title without cursor-spacing artifacts and ignore adjacent preview text. Preserve missing-target failures and downstream posture assertions. * test: isolate plan-count fixtures before starting review workflows Seed the complete test plan in a private git repository before launching Claude, so a bare slash command cannot review the live workspace while a delayed fixture message remains queued. Preserve count thresholds, parsers and budgets. Add initial-context and installed-discovery tests, and retain startup/terminal diagnostics on failed evaluations. * test: stabilize review fixtures and Claude eval startup Preserve source boundaries in workflow judge inputs, isolate CEO mode plans, and wait for interactive trust input readiness. Keep startup failure evidence and retain existing models, budgets, and assertions. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: classify collapsed review modes and isolate seeded findings Keep review questions out of the setup count when terminal cursor positioning removes spaces. State existing webhook safeguards so the five-finding control measures its seeded defects without accidental extra security and concurrency gaps. Preserve question bands and the paired control. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: isolate browser daemon state across free shards Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: stabilize native review counting and interactive navigation Co-Authored-By: OpenAI Codex <noreply@openai.com> * chore: prepare v1.82.0.0 release Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: eliminate browser and process-cleanup test flakes Pin every CI surface to Bun 1.4.0 to avoid extra-stdio finalizers closing reused live sockets. Add an isolated GC/listener regression that fails on Bun 1.3.13, and prevent coordinated rollback to an affected CI runtime. Check renderer cleanup against the render's own staging directory so concurrent renders cannot invalidate the assertion. Make the no-pgrep process-tree walk tolerate disappearing /proc entries, and synchronize its test fixture through child readiness and pipe EOF instead of sleeps. Validation: 9,157 passed, 31 skipped, zero failures across 556 files with retries disabled. Build, all-host generation freshness, and skill checks passed. All three races have failing-before/passing-after regressions. * fix: count completed native review questions in evals * fix: drive review navigation from confirmed native choices * fix: require complete section-loading eval reports * test: isolate telemetry HTTP transport from local assertions * fix: keep review input on the active native question * test: let tunnel revocation daemon choose an available port * test: allocate available ports for pairing and watchdog fixtures * fix: stabilize planning eval navigation and phase reporting * test: isolate installed runtime paths in planning evals * test: stabilize review evidence and concurrent refresh fixtures * fix: resolve design findings before editing the plan * fix: honor and persist disabled outside plan reviews * fix: preserve planning decisions and terminal evidence Load installed host reviews at autoplan phase entry and wait for completed reviewers and saved artifacts. Reuse approved remedies while preserving individual finding decisions. Drive interactive evals from the current terminal viewport, bind native questions across scrolling, and require complete native report evidence. Cover captured stale menus, permission lifecycles, setup classification, and disabled-review tool availability with deterministic regressions. Advance release metadata and the upgrade migration to the unclaimed 1.83.0.0 slot. * fix: drive native review questions and preserve current plans Use the native single-choice keyboard protocol and current terminal viewport, with per-question navigation inside packets and completed-call coverage. Keep permissions, multi-select menus, and Submit controls distinct. Send Autoplan reviewers the amended implementation plan, keep its review record separate, and supply retained application contracts in the chain fixture. Clarify individual DevEx decisions and complete CEO fix options; use one active plan destination for the section-loading report. * fix: preserve complete plan-review decisions * fix: recognize native plan dialogs and reviewer controls * fix: preserve review decisions and phase completion * fix: recognize completed reviews without losing findings * fix: preserve review continuity and native eval completion * test: fix native review completion and eval retry isolation * test: handle native review menus and complete eval fixtures * test: fix native review setup, completion, and isolation failures * test: limit native skill discovery to runtime assets * fix: bind Autoplan reviews to full ordered phase inputs * test: fix planning eval routing, counting, and timeout handling * chore: advance queued release to v1.84.0.0 * fix: preserve complete review inputs and planning decisions * fix: reconcile review approvals and preserve phase obligations * fix: preserve review obligations and unblock eval permissions Carry recorded Autoplan requirements into blind phase inputs, require Eng review approvals before exit, and exercise combined asynchronous flows in CEO reviews. Correct native finding and handoff classification and unblock repeated report edits using scoped request identities. * fix: retain plan requirements and complete native review dialogs * fix: complete native review prompts and retain plan references * fix: preserve review inputs and classify native eval evidence * fix: check competing completion orders in CEO reviews * fix: recognize review decisions and require phase methodology Require the current phase methodology before Autoplan snapshots. Correct substantive decision, closed handoff, and cache-finding classification, and honor the recommended implementation approach in native review dialogs. Add captured-transcript regressions without changing review thresholds, provider models, retries, or deadlines. * test: bind native review decisions and close completed handoffs * fix: complete review dialogs and verify methodology delivery * fix: preserve review evidence and unblock native eval prompts * fix: handle native review question completions * fix: recognize native review narration and controls * fix: count native review decisions and isolate eval fixtures * test: verify seeded review coverage and current artifact permissions * test: isolate model and brain-aware skill renders * fix: repair native workflow evaluation and clarify review steps * fix: stabilize workflow eval evidence and review guidance * test: repair native workflow observation and fixture isolation * fix: recognize completed workflow evidence and owned skill reads * test: repair seeded workflow delivery and completion evidence * test: recognize current review evidence across native forms * test: handle native review variants and permission redraws * fix: honor review preferences and recognize native eval evidence * test: recognize completed review decisions and queued permissions * test: match current review contracts and partial-line edits * test: recognize completed workflow evidence and bounded human waits * fix: preserve review entry gates and native eval interactions * fix: recognize native workflow evidence and preserve review gates * test: recognize current review evidence and preconfigure workflow fixtures * test: recognize completed review findings and scoped artifact permissions * fix: stabilize native workflow review and permission evidence * fix: recognize current review evidence and scoped edit confirmations Clarify Design and engineering review entry instructions and Design scoring. Recognize required legacy coverage and public Autoplan completion recaps. Bind the pending Edit confirmation to its exact file, ordered digest, and one-request approval when a preceding command display remains visible. Keep reviews within their existing size limits and preserve scope gates when extracting workflow fixtures from either supported preamble header. Keep failure outcomes, review thresholds, provider choices, and eval budgets. * fix: recover review workflow progress and eval evidence * fix: recognize valid review evidence and scope selection * test: fix review evidence parsing and repeated artifact prompts * test: recognize valid review decisions and pending native cards * fix(plan-eng-review): keep final navigation consistent with approved tasks * test: recognize valid review evidence and bind legacy diff requests * fix: stabilize review eval evidence and harness repair guidance * docs: update project documentation for v1.85.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: fix Windows CI fixtures and credential scan Rebase captured JSON values and filesystem evidence using the appropriate path convention. Compile native fake CLIs on Windows and synchronize pipe holder readiness, with cleanup retained when assertions fail. Assemble synthetic credential fixtures at runtime so the added-line scan keeps enforcing the same gate without flagging its own rejection controls. Discover generated skills directly for the empty-find regression check, avoiding a recursive scan through saved evaluation artifacts and dependencies. * fix: preserve source renders on Windows Compare canonical generator paths using native separators so an output sidecar pointing at the source cannot overwrite its skill or metadata. Keep the regression fixture isolated from the real checkout and expose freshness diagnostics before asserting subprocess status. Detach Windows drain-test pipe holders from the fake provider's automatic child cleanup while preserving the enclosing runner job and its assertions. * fix: clarify outside review fallback and CEO decisions Render one applicable own-harness fallback path and retain native review, disabled policy, and missing-coverage semantics. Align report field names and mode labels, and make the existing per-cut scope approval explicit. Regenerate skill outputs and keep the workflow judge's model, thresholds, and retry policy unchanged. * chore: move release to free version slot (v1.86.0.0) PR #2852 now claims v1.85.0.0. Align the release metadata and rename migration so upgrades from that version still receive it. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: include engineering review prerequisites and restore branch context * fix: recognize coverage diagrams and clarify design review instructions * fix: preserve file identities and join Windows test processes --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
74 lines
7.0 KiB
TypeScript
74 lines
7.0 KiB
TypeScript
import {describe,expect,test} from 'bun:test';
|
|
import {devexSeedCoverage} from './helpers/devex-seed-coverage';
|
|
import fixture from './fixtures/dx-reversed-tuples-av.json';
|
|
|
|
const fresh=()=>structuredClone(fixture.call) as any;
|
|
const coverage=(call:any)=>devexSeedCoverage({status:'ready',calls:[call],assistantMessages:[]} as any);
|
|
const ids=(call:any)=>coverage(call).decisions['reversed-arguments'];
|
|
function question(call:any,change:(text:string)=>string){const q=call.questions[0],old=q.question,answer=call.answers[old];q.question=change(old);call.answers={[q.question]:answer};}
|
|
function title(call:any,change:(text:string)=>string){question(call,text=>{const [first,...rest]=text.split('\n');return[change(first!),...rest].join('\n');});}
|
|
const rejected=(mutate:(call:any)=>void)=>{const call=fresh();mutate(call);expect(ids(call)).toEqual([]);};
|
|
|
|
describe('DX current named functions with reversed tuple arguments',()=>{
|
|
test('counts the exact completed D7 decision without crediting an entire review',()=>{
|
|
const call=fresh();expect(fixture.provenance.paidOutcomesReclassified).toBe(false);
|
|
expect(ids(call)).toEqual([`${call.sessionId}:${call.toolUseId}`]);
|
|
expect(coverage(call).complete).toBe(false);
|
|
expect(coverage(call).batched).toEqual([]);expect(coverage(call).invalid).toEqual([]);
|
|
});
|
|
test.each(['while','inline code','spacing','no journey label','reverse orientation'])('tuple structure permits %s',form=>{
|
|
const call=fresh();title(call,t=>form==='while'?t.replace(' but ',' while '):form==='inline code'?t.replace('run_eval','`run_eval`').replace('run_batch','`run_batch`').replace('(dataset, evaluator)','`(dataset, evaluator)`').replace('(evaluator, dataset)','`(evaluator, dataset)`'):form==='spacing'?t.replace('(dataset, evaluator)','( dataset , evaluator )').replace('(evaluator, dataset)','( evaluator , dataset )'):form==='no journey label'?t.replace('Journey stage REAL USAGE: ',''):t.replace('(dataset, evaluator)','(evaluator, dataset)').replace('run_batch takes (evaluator, dataset)','run_batch takes (dataset, evaluator)'));
|
|
expect(ids(call)).toHaveLength(1);
|
|
});
|
|
test.each(['same order','different sets','duplicates','unknown parameters','wrong function','negated assertion'])('rejects %s',form=>{
|
|
rejected(call=>title(call,t=>form==='same order'?t.replace('run_batch takes (evaluator, dataset)','run_batch takes (dataset, evaluator)'):form==='different sets'?t.replace('run_batch takes (evaluator, dataset)','run_batch takes (evaluator, records)'):form==='duplicates'?t.replace(/\((?:dataset, evaluator|evaluator, dataset)\)/g,'(dataset, dataset)'):form==='unknown parameters'?t.replace(/dataset/g,'items').replace(/evaluator/g,'callback'):form==='wrong function'?t.replace('run_batch','run_other'):t.replace('run_eval takes','run_eval does not take')));
|
|
});
|
|
test.each(['"','`','> '])('whole quoted/source statement stays non-current: %s',mark=>{
|
|
rejected(call=>title(call,t=>t.replace(/^(D7 — )(.*)$/s,`$1${mark}$2${mark==='> '?'':mark}`)));
|
|
});
|
|
test.each(['Historical assessment.','Source:','Hypothetical scenario.','If approved,','Assuming approval,'])('rejects current evidence introduced as %s',prefix=>{
|
|
rejected(call=>question(call,t=>t.replace('ELI10: ',`ELI10: ${prefix} `)));
|
|
});
|
|
test.each(['withdrawn','rejected','not current','no longer current'])('owned status %s rejects the finding and offered action',status=>{
|
|
for(const quote of ['',"'",'"','`']){
|
|
rejected(call=>question(call,t=>`${t}\nThis finding is ${quote}${status}${quote}.`));
|
|
rejected(call=>{for(const option of call.questions[0].options)option.description+=`\nThis option is ${quote}${status}${quote}.`;});
|
|
}
|
|
});
|
|
test('quoted historical withdrawals do not withdraw the current decision',()=>{
|
|
const call=fresh();question(call,t=>`${t}\nEarlier reviewer said "This finding is withdrawn."`);
|
|
for(const option of call.questions[0].options)option.description+='\nEarlier reviewer said "This option is withdrawn."';
|
|
expect(ids(call)).toHaveLength(1);
|
|
});
|
|
test('current conditional or resolved evidence does not establish an unresolved reversal',()=>{
|
|
for(const status of ['This finding applies if approved.','These functions are now aligned.','run_eval and run_batch now use the same positional order.'])
|
|
rejected(call=>question(call,t=>`${t}\n${status}`));
|
|
for(const status of ['This option applies once approved.','Do not align both functions.','Never change these signatures.'])
|
|
rejected(call=>{for(const option of call.questions[0].options)option.description+=`\n${status}`;});
|
|
});
|
|
test('the current repair must belong to one offered option for these functions',()=>{
|
|
for(const options of [
|
|
[{label:'Align',description:'Review the naming.'},{label:'Document the order',description:'Keep the current functions.'}],
|
|
[{label:'Align order',description:'Change the CLI flags only.'},{label:'Keep both functions',description:'No signature change.'}],
|
|
[{label:'Keep current behavior',description:'Earlier reviewer said "Both functions align argument order."'},{label:'Document the status quo',description:'No implementation change.'}],
|
|
])rejected(call=>{call.questions[0].options=options;call.answers={[call.questions[0].question]:options[0]!.label};});
|
|
});
|
|
test.each(['unanswered','failed','missing timestamp','pending item','missing answer','foreign answer','duplicate labels','multiple questions'])('does not manufacture native completion: %s',state=>{
|
|
rejected(call=>{if(state==='unanswered')call.answered=false;else if(state==='failed')call.failed=true;else if(state==='missing timestamp')call.answeredAt='';else if(state==='pending item')call.unansweredQuestionIndices=[0];else if(state==='missing answer')call.answers={};else if(state==='foreign answer')call.answers={[call.questions[0].question]:'Unlisted option'};else if(state==='duplicate labels')call.questions[0].options[1].label=call.questions[0].options[0].label;else call.questions.push(structuredClone(call.questions[0]));});
|
|
});
|
|
});
|
|
|
|
// Independent review found that semicolons must retain the same current owner.
|
|
test('tuple currentness is preserved at a semicolon boundary',()=>{
|
|
for(const statement of ['This finding is withdrawn.','This finding is "withdrawn".','This finding is `no longer current`.','D7 is withdrawn.','These functions are now aligned.','run_eval and run_batch now use the same positional order.']) {
|
|
rejected(call=>question(call,t=>t+'\nAssessment complete; '+statement));
|
|
for(const history of ['Historical reviewer said "Assessment complete; '+statement.replaceAll('"','')+'"','```\nAssessment complete; '+statement+'\n```']){
|
|
const call=fresh();question(call,t=>t+'\n'+history);expect(ids(call)).toHaveLength(1);
|
|
}
|
|
}
|
|
for(const statement of ['This option is withdrawn.','This option is `no longer current`.','Do not align both functions.']) {
|
|
rejected(call=>{for(const option of call.questions[0].options)option.description+='\nAssessment complete; '+statement;});
|
|
const call=fresh();for(const option of call.questions[0].options)option.description+='\nHistorical reviewer said "Assessment complete; '+statement.replaceAll('"','')+'"';expect(ids(call)).toHaveLength(1);
|
|
}
|
|
});
|