Files
gstack/test/eng-before-rewrite-ar.test.ts
Garry TanandOpenAI Codex 9f81911136 v1.86.0.0 feat: route outside reviews by harness (#2850)
* feat: add a restricted and supervised Claude Code runner

Preserve configured authentication and models while enforcing tool access, strict completion JSON, bounded output and process cleanup. Cover argv, failure handling, session metadata and Windows process containment.

* feat: route outside reviews by harness and migrate wrapper installs

Use Claude Code from Codex and Codex from other supported hosts, with shared invocation rendering, positive gate validation and per-phase provenance. Rename /claude to /claude-code, repair managed shared and copied installations safely, and generate native Kiro skills. Add installed-workflow, failure-injection and live cross-harness regression coverage.

* test: recognize CEO mode labels without terminal spacing

The paid workflow rendered SCOPEEXPANSION at option 4, but its driver required a literal space. Match the leading mode title without cursor-spacing artifacts and ignore adjacent preview text. Preserve missing-target failures and downstream posture assertions.

* test: isolate plan-count fixtures before starting review workflows

Seed the complete test plan in a private git repository before launching Claude, so a bare slash command cannot review the live workspace while a delayed fixture message remains queued. Preserve count thresholds, parsers and budgets. Add initial-context and installed-discovery tests, and retain startup/terminal diagnostics on failed evaluations.

* test: stabilize review fixtures and Claude eval startup

Preserve source boundaries in workflow judge inputs, isolate CEO mode plans, and wait for interactive trust input readiness. Keep startup failure evidence and retain existing models, budgets, and assertions.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: classify collapsed review modes and isolate seeded findings

Keep review questions out of the setup count when terminal cursor positioning removes spaces. State existing webhook safeguards so the five-finding control measures its seeded defects without accidental extra security and concurrency gaps. Preserve question bands and the paired control.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: isolate browser daemon state across free shards

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: stabilize native review counting and interactive navigation

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* chore: prepare v1.82.0.0 release

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: eliminate browser and process-cleanup test flakes

Pin every CI surface to Bun 1.4.0 to avoid extra-stdio finalizers closing
reused live sockets. Add an isolated GC/listener regression that fails on
Bun 1.3.13, and prevent coordinated rollback to an affected CI runtime.

Check renderer cleanup against the render's own staging directory so
concurrent renders cannot invalidate the assertion. Make the no-pgrep
process-tree walk tolerate disappearing /proc entries, and synchronize
its test fixture through child readiness and pipe EOF instead of sleeps.

Validation: 9,157 passed, 31 skipped, zero failures across 556 files with
retries disabled. Build, all-host generation freshness, and skill checks
passed. All three races have failing-before/passing-after regressions.

* fix: count completed native review questions in evals

* fix: drive review navigation from confirmed native choices

* fix: require complete section-loading eval reports

* test: isolate telemetry HTTP transport from local assertions

* fix: keep review input on the active native question

* test: let tunnel revocation daemon choose an available port

* test: allocate available ports for pairing and watchdog fixtures

* fix: stabilize planning eval navigation and phase reporting

* test: isolate installed runtime paths in planning evals

* test: stabilize review evidence and concurrent refresh fixtures

* fix: resolve design findings before editing the plan

* fix: honor and persist disabled outside plan reviews

* fix: preserve planning decisions and terminal evidence

Load installed host reviews at autoplan phase entry and wait for completed
reviewers and saved artifacts. Reuse approved remedies while preserving
individual finding decisions.

Drive interactive evals from the current terminal viewport, bind native
questions across scrolling, and require complete native report evidence.
Cover captured stale menus, permission lifecycles, setup classification,
and disabled-review tool availability with deterministic regressions.

Advance release metadata and the upgrade migration to the unclaimed
1.83.0.0 slot.

* fix: drive native review questions and preserve current plans

Use the native single-choice keyboard protocol and current terminal viewport,
with per-question navigation inside packets and completed-call coverage.
Keep permissions, multi-select menus, and Submit controls distinct.

Send Autoplan reviewers the amended implementation plan, keep its review record
separate, and supply retained application contracts in the chain fixture.
Clarify individual DevEx decisions and complete CEO fix options; use one active
plan destination for the section-loading report.

* fix: preserve complete plan-review decisions

* fix: recognize native plan dialogs and reviewer controls

* fix: preserve review decisions and phase completion

* fix: recognize completed reviews without losing findings

* fix: preserve review continuity and native eval completion

* test: fix native review completion and eval retry isolation

* test: handle native review menus and complete eval fixtures

* test: fix native review setup, completion, and isolation failures

* test: limit native skill discovery to runtime assets

* fix: bind Autoplan reviews to full ordered phase inputs

* test: fix planning eval routing, counting, and timeout handling

* chore: advance queued release to v1.84.0.0

* fix: preserve complete review inputs and planning decisions

* fix: reconcile review approvals and preserve phase obligations

* fix: preserve review obligations and unblock eval permissions

Carry recorded Autoplan requirements into blind phase inputs, require Eng
review approvals before exit, and exercise combined asynchronous flows in
CEO reviews. Correct native finding and handoff classification and unblock
repeated report edits using scoped request identities.

* fix: retain plan requirements and complete native review dialogs

* fix: complete native review prompts and retain plan references

* fix: preserve review inputs and classify native eval evidence

* fix: check competing completion orders in CEO reviews

* fix: recognize review decisions and require phase methodology

Require the current phase methodology before Autoplan snapshots. Correct
substantive decision, closed handoff, and cache-finding classification, and
honor the recommended implementation approach in native review dialogs.

Add captured-transcript regressions without changing review thresholds,
provider models, retries, or deadlines.

* test: bind native review decisions and close completed handoffs

* fix: complete review dialogs and verify methodology delivery

* fix: preserve review evidence and unblock native eval prompts

* fix: handle native review question completions

* fix: recognize native review narration and controls

* fix: count native review decisions and isolate eval fixtures

* test: verify seeded review coverage and current artifact permissions

* test: isolate model and brain-aware skill renders

* fix: repair native workflow evaluation and clarify review steps

* fix: stabilize workflow eval evidence and review guidance

* test: repair native workflow observation and fixture isolation

* fix: recognize completed workflow evidence and owned skill reads

* test: repair seeded workflow delivery and completion evidence

* test: recognize current review evidence across native forms

* test: handle native review variants and permission redraws

* fix: honor review preferences and recognize native eval evidence

* test: recognize completed review decisions and queued permissions

* test: match current review contracts and partial-line edits

* test: recognize completed workflow evidence and bounded human waits

* fix: preserve review entry gates and native eval interactions

* fix: recognize native workflow evidence and preserve review gates

* test: recognize current review evidence and preconfigure workflow fixtures

* test: recognize completed review findings and scoped artifact permissions

* fix: stabilize native workflow review and permission evidence

* fix: recognize current review evidence and scoped edit confirmations

Clarify Design and engineering review entry instructions and Design scoring.
Recognize required legacy coverage and public Autoplan completion recaps.
Bind the pending Edit confirmation to its exact file, ordered digest, and
one-request approval when a preceding command display remains visible.
Keep reviews within their existing size limits and preserve scope gates
when extracting workflow fixtures from either supported preamble header.

Keep failure outcomes, review thresholds, provider choices, and eval budgets.

* fix: recover review workflow progress and eval evidence

* fix: recognize valid review evidence and scope selection

* test: fix review evidence parsing and repeated artifact prompts

* test: recognize valid review decisions and pending native cards

* fix(plan-eng-review): keep final navigation consistent with approved tasks

* test: recognize valid review evidence and bind legacy diff requests

* fix: stabilize review eval evidence and harness repair guidance

* docs: update project documentation for v1.85.0.0

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: fix Windows CI fixtures and credential scan

Rebase captured JSON values and filesystem evidence using the appropriate
path convention. Compile native fake CLIs on Windows and synchronize pipe
holder readiness, with cleanup retained when assertions fail.

Assemble synthetic credential fixtures at runtime so the added-line scan
keeps enforcing the same gate without flagging its own rejection controls.

Discover generated skills directly for the empty-find regression check,
avoiding a recursive scan through saved evaluation artifacts and dependencies.

* fix: preserve source renders on Windows

Compare canonical generator paths using native separators so an output
sidecar pointing at the source cannot overwrite its skill or metadata.
Keep the regression fixture isolated from the real checkout and expose
freshness diagnostics before asserting subprocess status.

Detach Windows drain-test pipe holders from the fake provider's automatic
child cleanup while preserving the enclosing runner job and its assertions.

* fix: clarify outside review fallback and CEO decisions

Render one applicable own-harness fallback path and retain native review,
disabled policy, and missing-coverage semantics. Align report field names
and mode labels, and make the existing per-cut scope approval explicit.

Regenerate skill outputs and keep the workflow judge's model, thresholds,
and retry policy unchanged.

* chore: move release to free version slot (v1.86.0.0)

PR #2852 now claims v1.85.0.0. Align the release metadata and
rename migration so upgrades from that version still receive it.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: include engineering review prerequisites and restore branch context

* fix: recognize coverage diagrams and clarify design review instructions

* fix: preserve file identities and join Windows test processes

---------

Co-authored-by: OpenAI Codex <noreply@openai.com>
2026-09-14 14:32:45 -07:00

93 lines
7.2 KiB
TypeScript

import { describe, expect, test } from 'bun:test';
import { readFileSync } from 'node:fs';
import { createHash } from 'node:crypto';
import { evaluateEngSeedCoverage } from './helpers/eng-seeded-coverage';
import { E2E_TOUCHFILES, selectTests } from './helpers/touchfiles';
// Exact acknowledged public report; the paid attempt remains failed.
const report = readFileSync(new URL('./fixtures/eng-before-rewrite-ar.md', import.meta.url), 'utf8');
const declaration = report.match(/^### REGRESSION RULE \(mandatory, no decision required\)\n[\s\S]*?(?=\n### )/m)![0];
const task = report.match(/^- \[ \] \*\*T1 .*\n(?: .*(?:\n|$))*/m)![0];
const compact = '# Current reviewed plan\n\n## Tests (reviewed)\n\n' + declaration +
'\n## Implementation Tasks\n' + task + '\n## GSTACK REVIEW REPORT\n| Eng Review | complete |\n';
const check = (text: string) => evaluateEngSeedCoverage({ status: 'ready', calls: [], assistantMessages: [] }, text, 0, 1);
const negative: Array<[string, (text: string) => string]> = [
['missing mandatory declaration', s => s.replace(declaration, '')],
['optional declaration', s => s.replace('mandatory, no decision required', 'optional, decision pending')],
['historical owner', s => s.replace('## Tests (reviewed)', '## Historical tests')],
['quoted source ancestor', s => '# Source excerpt\n' + s.replace('# Current reviewed plan\n', '')],
['source declaration prefix', s => s.replace('`legacyAuthFlow()` is', 'Source excerpt:\n`legacyAuthFlow()` is')],
['conditional declaration', s => s.replace('`legacyAuthFlow()` is', 'If approved, `legacyAuthFlow()` is')],
['quoted declaration', s => s.replace(declaration, declaration.split('\n').map(line => '> ' + line).join('\n'))],
['fenced declaration', s => s.replace(declaration, '```\n' + declaration + '\n```')],
['literal declaration', s => s.replace(declaration, declaration.replace(/`/g, '').split('\n').map(line => '`' + line + '`').join('\n'))],
['wrong legacy target', s => s.replaceAll('legacyAuthFlow', 'anotherFlow')],
['capture after rewrite', s => s.replace('before any rewrite, record', 'after the rewrite, record')],
['proposed outputs', s => s.replace('the exact output', 'the proposed output')],
['no required flag-on rerun', s => s.replace('The new path must pass', 'The new path might pass')],
['different rerun suite', s => s.replace('pass the same suite', 'pass a different suite')],
['missing baseline task', s => s.replace(task, '')],
['historical task section', s => s.replace('## Implementation Tasks', '## Historical Implementation Tasks')],
['conditional task', s => s.replace(task, 'If approved:\n' + task)],
['source task', s => s.replace(task, 'Source excerpt:\n' + task)],
['quoted task', s => s.replace(task, task.split('\n').map(line => '> ' + line).join('\n'))],
['another test file', s => s.replace(' - Files: tests/auth/legacyAuthFlow.regression.test.ts', ' - Files: tests/auth/anotherFlow.regression.test.ts')],
['missing baseline verification', s => s.replace(' - Verify: suite green on current code; green again with flag on after rewrite', '')],
['modified baseline', s => s.replace('suite green on current code;', 'suite green on rewritten code;')],
['missing flag-on verification', s => s.replace('; green again with flag on after rewrite', '')],
['source verification', s => s.replace(' - Verify:', ' Source:\n - Verify:')],
['conditional verification', s => s.replace(' - Verify:', ' If approved:\n - Verify:')],
['assuming verification', s => s.replace(' - Verify:', ' Assuming approval,\n - Verify:')],
['verification from neighboring task', s => s.replace(' - Verify:', '- [ ] T2 — tests/auth — Another test suite\n - Verify:')],
['duplicate task identities', s => s.replace(task, task + task)],
['cancelled task', s => s + '\n## Current assessment\nT1 is withdrawn.\n'],
['quoted task status', s => s + '\n## Current assessment\nT1 verification is "withdrawn".\n'],
['cancelled legacy suite', s => s + '\n## Current assessment\nThe legacy regression suite is "withdrawn".\n'],
['cancelled baseline verification', s => s.replace(task, task + ' Correction: this baseline verification is withdrawn.\n')],
['quoted baseline status', s => s.replace(task, task + ' Correction: this baseline verification is "withdrawn".\n')],
['superseded baseline verification', s => s.replace(task, task + ' Correction: this baseline verification is "superseded".\n')],
['baseline verification no longer current', s => s.replace(task, task + ' Correction: this baseline verification is not current.\n')],
['verification waits for approval', s => s.replace(' - Verify:', ' Once approved:\n - Verify:')],
['verification depends on approval', s => s.replace(' - Verify:', ' When approved:\n - Verify:')],
['verification has approval pending', s => s.replace(' - Verify:', ' Pending approval:\n - Verify:')],
['bare source owns the following sections', s => 'Source:\n\n' + s.replace('# Current reviewed plan\n', '')],
['current task withdrawal row', s => s + '\n## Current assessment\n| T1 | Withdrawn |\n'],
['quoted current task withdrawal value', s => s + '\n## Current assessment\n| T1 | "Withdrawn" |\n'],
['baseline changes before task', s => s + '\n## Current assessment\nlegacyAuthFlow() is modified before T1.\n'],
];
describe('mandatory characterization binds the current baseline and same-file rerun', () => {
test('the exact acknowledged report supplies regression coverage, without inventing native decisions', () => {
expect(createHash('sha256').update(report).digest('hex')).toBe('7e4c56d66f98b9ccea54b7427ec2dbbca89adfc6407f0fedf2017801eafada99');
expect(check(report)).toMatchObject({regression: 'plan', ok: false,
missing: ['complexity', 'shared-cache', 'swallowed-errors', 'sequential-idp']});
expect(check(compact).regression).toBe('plan');
});
test('formatting and current task numbering do not affect the obligation', () => {
expect(check(compact.replaceAll('T1', 'T21')).regression).toBe('plan');
expect(check(compact.replace(/\n(?=[a-z])/g, ' ')).regression).toBe('plan');
expect(check(compact.replaceAll('tests/auth', 'test/login')).regression).toBe('plan');
});
test('quoted history and a separate suite cannot cancel the current legacy obligation', () => {
expect(check(compact + '\n## History\n"T1 is withdrawn."\n').regression).toBe('plan');
expect(check(compact + '\n## Payment regression suite\nThe regression suite is withdrawn.\n').regression).toBe('plan');
expect(check(compact + '\n## Historical task status\n| T1 | Withdrawn |\n').regression).toBe('plan');
expect(check(compact + '\n## Current task status\n| T9 | Withdrawn |\n').regression).toBe('plan');
expect(check('Source:\n\n' + compact).regression).toBe('plan');
});
test.each(negative)('%s supplies no mandatory legacy baseline', (_, change) => {
const altered = change(compact);
expect(altered).not.toBe(compact);
expect(check(altered).regression).toBeUndefined();
});
test('new artifacts select only the existing Eng owner', () => {
for (const file of ['test/eng-before-rewrite-ar.test.ts', 'test/fixtures/eng-before-rewrite-ar.md'])
expect(selectTests([file], E2E_TOUCHFILES, []).selected).toEqual(['plan-eng-finding-count']);
});
});