mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-17 18:32:19 +02:00
* feat: add a restricted and supervised Claude Code runner Preserve configured authentication and models while enforcing tool access, strict completion JSON, bounded output and process cleanup. Cover argv, failure handling, session metadata and Windows process containment. * feat: route outside reviews by harness and migrate wrapper installs Use Claude Code from Codex and Codex from other supported hosts, with shared invocation rendering, positive gate validation and per-phase provenance. Rename /claude to /claude-code, repair managed shared and copied installations safely, and generate native Kiro skills. Add installed-workflow, failure-injection and live cross-harness regression coverage. * test: recognize CEO mode labels without terminal spacing The paid workflow rendered SCOPEEXPANSION at option 4, but its driver required a literal space. Match the leading mode title without cursor-spacing artifacts and ignore adjacent preview text. Preserve missing-target failures and downstream posture assertions. * test: isolate plan-count fixtures before starting review workflows Seed the complete test plan in a private git repository before launching Claude, so a bare slash command cannot review the live workspace while a delayed fixture message remains queued. Preserve count thresholds, parsers and budgets. Add initial-context and installed-discovery tests, and retain startup/terminal diagnostics on failed evaluations. * test: stabilize review fixtures and Claude eval startup Preserve source boundaries in workflow judge inputs, isolate CEO mode plans, and wait for interactive trust input readiness. Keep startup failure evidence and retain existing models, budgets, and assertions. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: classify collapsed review modes and isolate seeded findings Keep review questions out of the setup count when terminal cursor positioning removes spaces. State existing webhook safeguards so the five-finding control measures its seeded defects without accidental extra security and concurrency gaps. Preserve question bands and the paired control. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: isolate browser daemon state across free shards Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: stabilize native review counting and interactive navigation Co-Authored-By: OpenAI Codex <noreply@openai.com> * chore: prepare v1.82.0.0 release Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: eliminate browser and process-cleanup test flakes Pin every CI surface to Bun 1.4.0 to avoid extra-stdio finalizers closing reused live sockets. Add an isolated GC/listener regression that fails on Bun 1.3.13, and prevent coordinated rollback to an affected CI runtime. Check renderer cleanup against the render's own staging directory so concurrent renders cannot invalidate the assertion. Make the no-pgrep process-tree walk tolerate disappearing /proc entries, and synchronize its test fixture through child readiness and pipe EOF instead of sleeps. Validation: 9,157 passed, 31 skipped, zero failures across 556 files with retries disabled. Build, all-host generation freshness, and skill checks passed. All three races have failing-before/passing-after regressions. * fix: count completed native review questions in evals * fix: drive review navigation from confirmed native choices * fix: require complete section-loading eval reports * test: isolate telemetry HTTP transport from local assertions * fix: keep review input on the active native question * test: let tunnel revocation daemon choose an available port * test: allocate available ports for pairing and watchdog fixtures * fix: stabilize planning eval navigation and phase reporting * test: isolate installed runtime paths in planning evals * test: stabilize review evidence and concurrent refresh fixtures * fix: resolve design findings before editing the plan * fix: honor and persist disabled outside plan reviews * fix: preserve planning decisions and terminal evidence Load installed host reviews at autoplan phase entry and wait for completed reviewers and saved artifacts. Reuse approved remedies while preserving individual finding decisions. Drive interactive evals from the current terminal viewport, bind native questions across scrolling, and require complete native report evidence. Cover captured stale menus, permission lifecycles, setup classification, and disabled-review tool availability with deterministic regressions. Advance release metadata and the upgrade migration to the unclaimed 1.83.0.0 slot. * fix: drive native review questions and preserve current plans Use the native single-choice keyboard protocol and current terminal viewport, with per-question navigation inside packets and completed-call coverage. Keep permissions, multi-select menus, and Submit controls distinct. Send Autoplan reviewers the amended implementation plan, keep its review record separate, and supply retained application contracts in the chain fixture. Clarify individual DevEx decisions and complete CEO fix options; use one active plan destination for the section-loading report. * fix: preserve complete plan-review decisions * fix: recognize native plan dialogs and reviewer controls * fix: preserve review decisions and phase completion * fix: recognize completed reviews without losing findings * fix: preserve review continuity and native eval completion * test: fix native review completion and eval retry isolation * test: handle native review menus and complete eval fixtures * test: fix native review setup, completion, and isolation failures * test: limit native skill discovery to runtime assets * fix: bind Autoplan reviews to full ordered phase inputs * test: fix planning eval routing, counting, and timeout handling * chore: advance queued release to v1.84.0.0 * fix: preserve complete review inputs and planning decisions * fix: reconcile review approvals and preserve phase obligations * fix: preserve review obligations and unblock eval permissions Carry recorded Autoplan requirements into blind phase inputs, require Eng review approvals before exit, and exercise combined asynchronous flows in CEO reviews. Correct native finding and handoff classification and unblock repeated report edits using scoped request identities. * fix: retain plan requirements and complete native review dialogs * fix: complete native review prompts and retain plan references * fix: preserve review inputs and classify native eval evidence * fix: check competing completion orders in CEO reviews * fix: recognize review decisions and require phase methodology Require the current phase methodology before Autoplan snapshots. Correct substantive decision, closed handoff, and cache-finding classification, and honor the recommended implementation approach in native review dialogs. Add captured-transcript regressions without changing review thresholds, provider models, retries, or deadlines. * test: bind native review decisions and close completed handoffs * fix: complete review dialogs and verify methodology delivery * fix: preserve review evidence and unblock native eval prompts * fix: handle native review question completions * fix: recognize native review narration and controls * fix: count native review decisions and isolate eval fixtures * test: verify seeded review coverage and current artifact permissions * test: isolate model and brain-aware skill renders * fix: repair native workflow evaluation and clarify review steps * fix: stabilize workflow eval evidence and review guidance * test: repair native workflow observation and fixture isolation * fix: recognize completed workflow evidence and owned skill reads * test: repair seeded workflow delivery and completion evidence * test: recognize current review evidence across native forms * test: handle native review variants and permission redraws * fix: honor review preferences and recognize native eval evidence * test: recognize completed review decisions and queued permissions * test: match current review contracts and partial-line edits * test: recognize completed workflow evidence and bounded human waits * fix: preserve review entry gates and native eval interactions * fix: recognize native workflow evidence and preserve review gates * test: recognize current review evidence and preconfigure workflow fixtures * test: recognize completed review findings and scoped artifact permissions * fix: stabilize native workflow review and permission evidence * fix: recognize current review evidence and scoped edit confirmations Clarify Design and engineering review entry instructions and Design scoring. Recognize required legacy coverage and public Autoplan completion recaps. Bind the pending Edit confirmation to its exact file, ordered digest, and one-request approval when a preceding command display remains visible. Keep reviews within their existing size limits and preserve scope gates when extracting workflow fixtures from either supported preamble header. Keep failure outcomes, review thresholds, provider choices, and eval budgets. * fix: recover review workflow progress and eval evidence * fix: recognize valid review evidence and scope selection * test: fix review evidence parsing and repeated artifact prompts * test: recognize valid review decisions and pending native cards * fix(plan-eng-review): keep final navigation consistent with approved tasks * test: recognize valid review evidence and bind legacy diff requests * fix: stabilize review eval evidence and harness repair guidance * docs: update project documentation for v1.85.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: fix Windows CI fixtures and credential scan Rebase captured JSON values and filesystem evidence using the appropriate path convention. Compile native fake CLIs on Windows and synchronize pipe holder readiness, with cleanup retained when assertions fail. Assemble synthetic credential fixtures at runtime so the added-line scan keeps enforcing the same gate without flagging its own rejection controls. Discover generated skills directly for the empty-find regression check, avoiding a recursive scan through saved evaluation artifacts and dependencies. * fix: preserve source renders on Windows Compare canonical generator paths using native separators so an output sidecar pointing at the source cannot overwrite its skill or metadata. Keep the regression fixture isolated from the real checkout and expose freshness diagnostics before asserting subprocess status. Detach Windows drain-test pipe holders from the fake provider's automatic child cleanup while preserving the enclosing runner job and its assertions. * fix: clarify outside review fallback and CEO decisions Render one applicable own-harness fallback path and retain native review, disabled policy, and missing-coverage semantics. Align report field names and mode labels, and make the existing per-cut scope approval explicit. Regenerate skill outputs and keep the workflow judge's model, thresholds, and retry policy unchanged. * chore: move release to free version slot (v1.86.0.0) PR #2852 now claims v1.85.0.0. Align the release metadata and rename migration so upgrades from that version still receive it. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: include engineering review prerequisites and restore branch context * fix: recognize coverage diagrams and clarify design review instructions * fix: preserve file identities and join Windows test processes --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
88 lines
33 KiB
JSON
88 lines
33 KiB
JSON
{
|
|
"provenance": {
|
|
"runLabel": "ship-source-ad-full-paid-20260909-v3",
|
|
"sourceCommit": "4636893f5201e9357f9af2dd3cbbfb679e57bfdc",
|
|
"capturedScreenSha256": "1fff662a95e7ee1d0b362d3ca9b56e0665982d201caa6fc78b2157ef8a8008bc",
|
|
"publicEventsSha256": "12aa45b4d9fd2035e7c44f5b373d60f32e1cd15c655ba9632a8eb33761f00a61",
|
|
"note": "Exact retained current viewport and public parent Write/Edit requests/results only. Event projection preserves the recorded session identity from retained native descriptor. Tests relocate the owned path and replay current file state from the final successful Write; this is projected execution, not a historical granted permission or pass.",
|
|
"commandTimestamp": "Actual retained parent user <command-name>/autoplan timestamp, not reconstructed from viewport."
|
|
},
|
|
"commandStartedAt": 1788984403953,
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"cwd": "/tmp/gstack-paid-shard-kz30Zk/tmp/gstack-autoplan-chain-PdOGYy",
|
|
"stateRoot": "/tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack",
|
|
"viewport": " 64 +- **Success target made numeric:** 45 seconds absolute; if the production baseline is already under 60 seconds, the\n + target becomes 25% below baseline and the Final Gate premise item is escalated. \n 65 +- **Session join check is P1**, part of task T1 (a precondition to flag-on), with a fallback metric (per-member dai\n +ly median joined on member ID and day). Row 0b's query remains P2. \n 66 +- **Exposure metric labelled** with cohort (flag on or off) and entry kind (redirect or direct visit) so redirected\n + and direct visitors are compared separately. \n 67 +- **Toast triggers enumerated:** mark-all-read outcomes only. Quick actions are links and raise no toast. \n 68 +- **Route registration file** for `/dashboard` added to blast radius. \n 69 +- **Mark-all-read validation tightening** is a decision, not just a blast-radius line: rejecting malformed or futur\n +e snapshots with 422 is a security hardening accepted in the review record's security section; the API contract for\n + valid input does not change. \n 70 +- **Freshness after \"View all\":** `usePanelData` fetches on mount and on every route entry, so a keep-alive router \n +still refreshes. \n 71 +- **Row 2 (shell badge) is P3**, consistent with \"design happens when picked up\". **Row 3 (undo)** is not symmetric\n +: it must restore prior read state, so it needs state capture; effort L when picked up. \n 72 +- **Units:** \"points\" everywhere means percentage points. \n 73 +- **Row 8 criterion is an explicit proxy:** share of first actions labelled \"resume assigned work\" stands in for th\n +e trigger population (exactly one assigned item, no unread alerts), which cannot be measured until the dashboard ex\n +poses both counts. \n 74 +- **Task index:** tasks T1 to T14 are listed in the review record's CEO Implementation Tasks section and in `~/.gst\n +ack/projects/gstack-autoplan-chain-PdOGYy/tasks-ceo-review-20260909-201501.jsonl`; the Final Gate aggregates them. \n 75 + \n 76 +## Reviewer Concerns (unresolved after three iterations) \n 77 + \n 78 +- The document cannot name routes, action IDs, or the analytics session key because the repository contains no appl\n +ication source. Each is pinned by a named task at implementation start; the reviewer considers that a deferral. \n 79 +- Baseline item 1 changes \"Users land here after login\" into a flag-gated cohort redirect. This is a rollout mechan\n +ism, not a scope change, but the reviewer wants it labelled as a decision; it is recorded here as such. \n 80 + \n 81 ## Deferred to TODOS.md (one line each; design happens when the item is picked up)\n 82 - Shell unread badge (P2, S).\n 83 - Undo for mark-all-read (P3, M); needs a new mutation API decision first.\n\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\u254c\n Do you want to make this edit to 2026-09-09-user-dashboard.md?\n \u276f 1. Yes\n 2. Yes, and switch to accept edits (auto-approve file edits and common file commands) for this session (shift+tab)\n 3. No\n\n Esc to cancel \u00b7 Tab to amend\n",
|
|
"events": [
|
|
{
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"timestamp": "2026-09-09T20:14:13.991Z",
|
|
"toolUseId": "toolu_01JEjFAdBnCZwTzBXkejvP4n",
|
|
"kind": "use",
|
|
"name": "Write",
|
|
"input": {
|
|
"file_path": "/tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack/projects/gstack-autoplan-chain-PdOGYy/ceo-plans/2026-09-09-user-dashboard.md",
|
|
"content": "---\nstatus: ACTIVE\n---\n# CEO Plan: User Dashboard Page\nGenerated by /plan-ceo-review (via /autoplan) on 2026-09-09\nBranch: main | Mode: SELECTIVE EXPANSION\nRepo: gstack-autoplan-chain-PdOGYy (no remote configured)\n\n## Vision\n\n### 10x Check\nThe 10x version is not a better dashboard. It is a landing that already knows what the member came to do. When a member has exactly one assigned item and no unread alerts, the login lands them inside that item with a one-line \"3 changes since you left\" strip; when they have alerts, the landing leads with the alert that blocks them. The dashboard in this plan is the necessary first step: it is the only surface that can host that adaptive behavior later, and it produces the exposure and click data needed to decide which action deserves the redirect. Effort for the adaptive landing itself: human ~2 weeks / CC ~2 hours, gated on two weeks of dashboard analytics. It is deferred, not rejected.\n\n### Platonic Ideal\nNot produced (SELECTIVE EXPANSION mode).\n\n## Scope Decisions\n\n| # | Proposal | Effort | Decision | Reasoning |\n|---|----------|--------|----------|-----------|\n| 1 | \"View all\" links from each panel to the existing full activity and notification pages | S | ACCEPTED | In blast radius (panel components only), completes the 20-record cap story, zero new infra |\n| 2 | Unread-count badge in the shared page shell header | S | DEFERRED | Touches the page shell, outside this plan's files; valuable but separate |\n| 3 | Inline \"Undo\" after mark-all-read | M | DEFERRED | Requires a new unmark mutation API; the plan states no new mutation API |\n| 4 | Real-time updates for notifications (polling or push) | L | DEFERRED | New infra; the dashboard refetches on focus and after mutations, which covers v1 |\n| 5 | \"New since your last visit\" divider in the activity feed | M | DEFERRED | Requires persisting last-visit time per member; new storage |\n| 6 | Prefetch dashboard payload in the login response | M | DEFERRED | Touches the login flow, outside blast radius |\n| 7 | Keyboard shortcuts (g+d, j/k through notifications) | S | DEFERRED | Low value for the first cohort; revisit with usage data |\n| 8 | Adaptive landing: redirect straight into work when one obvious next item exists (10x) | L | DEFERRED (Phase 2) | Needs dashboard exposure/click data first; surfaced at the Final Gate as a taste item |\n\n## Accepted Scope (added to this plan)\n- Per-panel \"View all\" links to the existing full activity page and full notifications page.\n\n## Deferred to TODOS.md\n- Shell unread badge (P2, S): one badge in the page shell fed by the notifications unread count; reuses the same endpoint section.\n- Undo for mark-all-read (P3, M): needs an unmark-at-or-before-snapshot mutation; the snapshot semantics make it cheap once the API exists.\n- Real-time notifications (P3, L): polling first, push later; only if refetch-on-focus proves insufficient.\n- \"New since last visit\" activity divider (P3, M): persist last dashboard exposure timestamp per member.\n- Prefetch dashboard payload at login (P3, M): saves one round trip; measure first.\n- Keyboard shortcuts (P3, S).\n- Adaptive landing / smart redirect (P2, L): Phase 2, decided from two weeks of dashboard analytics segmented by first action type.\n"
|
|
}
|
|
},
|
|
{
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"timestamp": "2026-09-09T20:14:16.766Z",
|
|
"toolUseId": "toolu_01JEjFAdBnCZwTzBXkejvP4n",
|
|
"kind": "result",
|
|
"content": "File created successfully at: /tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack/projects/gstack-autoplan-chain-PdOGYy/ceo-plans/2026-09-09-user-dashboard.md (file state is current in your context \u2014 no need to Read it back)",
|
|
"isError": false
|
|
},
|
|
{
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"timestamp": "2026-09-09T20:21:08.778Z",
|
|
"toolUseId": "toolu_01ABvTvbVrtF2d3yKu1o2ouu",
|
|
"kind": "use",
|
|
"name": "Write",
|
|
"input": {
|
|
"file_path": "/tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack/projects/gstack-autoplan-chain-PdOGYy/ceo-plans/2026-09-09-user-dashboard.md",
|
|
"content": "---\nstatus: ACTIVE\n---\n# CEO Plan: User Dashboard Page\nGenerated by /plan-ceo-review (via /autoplan) on 2026-09-09\nBranch: main | Mode: SELECTIVE EXPANSION\nRepo: gstack-autoplan-chain-PdOGYy (no remote configured)\n\n## How to read this document\n\n- **Source plan:** `.claude/plans/ui-heavy-feature.md` in the repo. This document records scope *decisions* made during the CEO review; it does not replace the source plan. The full review, including every accepted engineering requirement referenced below, lives in the active plan file's \"Review record\" section (`## Review record`, block `autoplan-accepted:ceo`).\n- **Effort scale (one scale, used everywhere):** S = human under 1 day, CC under 30 minutes. M = human 1 to 3 days, CC under 2 hours. L = human 1 to 2 weeks, CC 2 to 4 hours. \"CC\" means implementation with Claude Code plus gstack.\n- **Priority scale:** P1 blocks shipping this plan. P2 should land on this branch or the next one. P3 is a backlog item. Priority is unrelated to \"Phase 2\", which means \"a separate later plan, after this one ships and has data\".\n- **Final Gate:** the single approval step at the end of the /autoplan pipeline where the user confirms or overrides recommendations. A \"taste item\" is a decision reasonable people could make differently; it is auto-decided with a recommendation and surfaced at the Final Gate for the user to confirm or flip.\n- **Blast radius (the files this plan may touch):** `src/pages/UserDashboard.tsx`; `src/components/dashboard/` (ActivityFeed, NotificationsPanel, QuickActions, MarkAllReadDialog, usePanelData, PanelState); `src/components/feedback/` (ToastProvider, useToast); `src/api/dashboard/` (handler, envelope); the snapshot validation in the existing mark-all-read handler; dashboard tests under `test/` and `e2e/`; `docs/dashboard-rollout.md`. Anything else (page shell, login flow, repositories, schema) is outside blast radius.\n\n## Baseline scope (unchanged from the source plan)\n\n1. New page `/dashboard` (`UserDashboard.tsx`) that becomes the post-login landing for members in the `dashboard_landing` flag cohort.\n2. Three panels: `ActivityFeed` (immutable audit history), `NotificationsPanel` (member alerts with read state), `QuickActions` (the three registry actions, filtered by server-side eligibility). Each panel has loading, empty, error and success states.\n3. Confirmation modal for \"Mark all as read\", built on the existing dialog primitive, calling the existing snapshot-bounded idempotent bulk-read API. No new mutation API.\n4. Toast feedback (a `role=\"status\"` live region) for action results; required by the existing accessibility policy.\n5. New aggregate endpoint `GET /api/dashboard` composing the three existing repository reads with per-section success or failure; no schema change.\n6. Exposure and interaction instrumentation for the new page (the source plan states the page \"still needs its own exposure and interaction instrumentation\"). Decision row 0 below makes this explicit.\n7. Out of scope per the source plan: dark mode, personalization.\n\nBehaviors cited below as \"accepted requirements\" (refetch on window focus throttled to once per 60 seconds, refetch of the notifications section after mark-all-read, 10 rendered items per panel) are recorded in the accepted-requirements block of the review record, not invented here.\n\n## Vision\n\n### 10x Check\nThe 10x version is not a better dashboard. It is a landing that already knows what the member came to do. When a member has exactly one assigned item and no unread alerts, login lands them inside that item with a one-line \"3 changes since you left\" strip; when they have alerts, the landing leads with the alert that blocks them. The dashboard in this plan is the necessary first step: it is the only surface that can host that adaptive behavior later, and it produces the exposure and click data needed to decide which action deserves the redirect. Effort for the adaptive landing itself: L, and only after the data in row 8 exists. It is deferred, not rejected.\n\n### Platonic Ideal\nNot produced (SELECTIVE EXPANSION mode).\n\n## Scope Decisions\n\n| # | Proposal | Effort | Decision | Reasoning |\n|---|----------|--------|----------|-----------|\n| 0 | Analytics events: `dashboard_exposure` on page view and `dashboard_action_click{action_id}` on quick-action click, plus first-action-after-login segmentation computed from existing login/action-start events | S | ACCEPTED (P1) | Already required by the source plan; made explicit because rows 8 and the rollout criteria depend on it |\n| 1 | \"View all\" link in the footer of ActivityFeed and NotificationsPanel, same tab, no filter state, pointing at the existing full activity page and full notifications page. Rendered only in the panel's success state (hidden while loading, on error, and when the panel is empty). Routes are the ones the existing pages already own; confirm the exact paths at implementation. | S | ACCEPTED (P1) | Inside blast radius (panel components only); gives the 10-item cap a real destination. Read-state freshness after navigating back is covered by the accepted refetch-on-mount and refetch-on-focus requirements. |\n| 2 | Unread-count badge in the shared page shell header | S | DEFERRED (P2) | The page shell is outside blast radius |\n| 3 | Inline \"Undo\" after mark-all-read | M | DEFERRED (P3) | Requires a new unmark mutation; the source plan states no new mutation API. Assumption for the estimate: the existing bulk-read API is snapshot-bounded, as the source plan states, so an inverse \"unmark at or before snapshot\" call is a symmetric M-sized API addition; if the real API marks by ID list, re-estimate. |\n| 4 | Real-time notification updates | L | DEFERRED (P3) | New infra. Revisit if, after the 100% rollout, more than 5% of dashboard sessions stay open longer than 10 minutes while new notifications arrive for that member (measurable from exposure events plus notification creation times). Until then, refetch on focus and after mutations covers v1. |\n| 5 | \"New since your last visit\" divider in the activity feed | M | DEFERRED (P3) | Requires persisting a per-member timestamp; new storage |\n| 6 | Prefetch dashboard payload in the login response | M | DEFERRED (P3) | Touches the login flow, outside blast radius |\n| 7 | Keyboard shortcuts | S | DEFERRED (P3) | Low value for the first cohort; revisit with usage data |\n| 8 | Adaptive landing: redirect straight into the assigned item when it is the member's only obvious next step; otherwise show the dashboard | L | DEFERRED, Phase 2 (P2) | Decision criterion: after two weeks at 100% rollout, if more than 60% of first actions after login are \"resume assigned work\" across at least 500 sessions, open the Phase 2 plan. Owner: the rollout kill owner named in `docs/dashboard-rollout.md`. Also the independent CEO reviewer's preferred reframing; surfaced at the Final Gate as a taste item. |\n\n## Accepted Scope (added to this plan)\n- Row 0: explicit exposure and action-click analytics events plus first-action segmentation.\n- Row 1: footer \"View all\" links on the two list panels, success state only.\n\n## Deferred to TODOS.md (one line each; design happens when the item is picked up)\n- Shell unread badge (P2, S).\n- Undo for mark-all-read (P3, M); needs a new mutation API decision first.\n- Real-time notifications (P3, L); criterion in row 4.\n- \"New since last visit\" activity divider (P3, M).\n- Prefetch dashboard payload at login (P3, M).\n- Keyboard shortcuts (P3, S).\n- Adaptive landing (Phase 2, P2, L); criterion and owner in row 8.\n"
|
|
}
|
|
},
|
|
{
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"timestamp": "2026-09-09T20:21:09.785Z",
|
|
"toolUseId": "toolu_01ABvTvbVrtF2d3yKu1o2ouu",
|
|
"kind": "result",
|
|
"content": "The file /tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack/projects/gstack-autoplan-chain-PdOGYy/ceo-plans/2026-09-09-user-dashboard.md has been updated successfully. (file state is current in your context \u2014 no need to Read it back)",
|
|
"isError": false
|
|
},
|
|
{
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"timestamp": "2026-09-09T20:24:23.997Z",
|
|
"toolUseId": "toolu_01FUctxcUNfgcfnxpu5tQvFA",
|
|
"kind": "use",
|
|
"name": "Write",
|
|
"input": {
|
|
"file_path": "/tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack/projects/gstack-autoplan-chain-PdOGYy/ceo-plans/2026-09-09-user-dashboard.md",
|
|
"content": "---\nstatus: ACTIVE\n---\n# CEO Plan: User Dashboard Page\nGenerated by /plan-ceo-review (via /autoplan) on 2026-09-09\nBranch: main | Mode: SELECTIVE EXPANSION\nRepo: gstack-autoplan-chain-PdOGYy (no remote configured)\n\n## How to read this document\n\n- **Source plan:** `.claude/plans/ui-heavy-feature.md` in the repo. This document records scope *decisions* made during the CEO review; it does not replace the source plan. The full review, including every accepted engineering requirement referenced below, lives in the active plan file's \"Review record\" section (block `autoplan-accepted:ceo`).\n- **Repository state:** the repository under review contains only `README.md` and the source plan. There is no application source, so routes, action IDs and analytics join keys cannot be read here; where this document depends on them it says so and names the implementation task that pins them down.\n- **Effort scale (one scale, used everywhere):** S = human under 1 day, CC under 30 minutes. M = human 1 to 3 days, CC under 2 hours. L = human 1 to 2 weeks, CC 2 to 4 hours. \"CC\" means implementation with Claude Code plus gstack.\n- **Priority scale (applies only to work on this branch or the next):** P1 blocks shipping this plan. P2 lands on this branch or the next one. P3 is a backlog item. Items marked \"Phase 2\" are a separate later plan that starts only after this one ships and has data; they carry no branch priority.\n- **Final Gate:** the single approval step at the end of the /autoplan pipeline where the user confirms or overrides recommendations. A \"taste item\" is a decision reasonable people could make differently; it is auto-decided with a recommendation and surfaced at the Final Gate for the user to confirm or flip.\n- **Blast radius (the files this plan may touch):** `src/pages/UserDashboard.tsx`; `src/components/dashboard/` (ActivityFeed, NotificationsPanel, QuickActions, MarkAllReadDialog, usePanelData, PanelState); `src/components/feedback/` (ToastProvider, useToast); `src/api/dashboard/` (handler, envelope); one flag-gated conditional at the existing post-login redirect site; input-validation tightening in the existing mark-all-read handler (reject malformed or future snapshots, no contract change for valid input, no new API); analytics event emission from `UserDashboard` and `QuickActions` through the existing analytics client (no new analytics module); dashboard tests under `test/` and `e2e/`; `docs/dashboard-rollout.md` (created by this plan). Anything else (rest of the page shell and login flow, repositories, schema) is outside blast radius.\n\n## Baseline scope (unchanged from the source plan)\n\n1. New page `/dashboard` (`UserDashboard.tsx`), registered for every authenticated workspace member. It renders for anyone who visits it directly. The `dashboard_landing` flag changes only the post-login redirect target for members in the cohort.\n2. Three panels: `ActivityFeed` (immutable audit history), `NotificationsPanel` (member alerts with read state), `QuickActions` (the three registry actions, filtered by server-side eligibility). Each panel has loading, empty, error and success states. The source plan names the actions by label only: \"create an item\", \"resume assigned work\", \"invite a member\"; their stable IDs come from the registry and are read at implementation (task T10).\n3. Confirmation modal for \"Mark all as read\", built on the existing dialog primitive, calling the existing bulk-read API, which the source plan states is idempotent and snapshot-bounded (marks only notifications at or before the supplied snapshot time). No new mutation API.\n4. Toast feedback (a `role=\"status\"` live region) for action results; required by the existing accessibility policy.\n5. New aggregate endpoint `GET /api/dashboard` composing the three existing repository reads with per-section success or failure; no schema change.\n6. Exposure and interaction instrumentation for the new page (the source plan states the page \"still needs its own exposure and interaction instrumentation\"). Decision row 0a below makes this explicit.\n7. Out of scope per the source plan: dark mode, personalization.\n\nBehaviors cited below as accepted requirements are recorded in the accepted-requirements block of the review record: `usePanelData` fetches on mount and refetches on window focus throttled to once per 60 seconds; the notifications section refetches after mark-all-read; each list panel renders at most 10 of the 20 returned items; `dashboard_exposure_total` fires once per route entry, never on refetch.\n\nRollout criteria, in one line (full text in the review record and `docs/dashboard-rollout.md`): cohorts 10%, 50%, 100% at 7 days each; success is median login-to-first-completed-task at or below a target restated relative to the production baseline measured before flag-on; kill if completed-task rate drops more than 2 points or permission-error rate rises at all; rollback is flag off. **Kill owner:** the rollout doc is created by this plan, so the owner is not yet named; the user names the owner at the Final Gate or in the PR, and the rollout doc cannot be merged without a named owner (task T12).\n\n## Vision\n\n### 10x Check\nThe 10x version is not a better dashboard. It is a landing that already knows what the member came to do. When a member has exactly one assigned item and no unread alerts, login lands them inside that item with a one-line \"3 changes since you left\" strip; when they have alerts, the landing leads with the alert that blocks them. The dashboard in this plan is the necessary first step: it is the only surface that can host that adaptive behavior later, and it produces the exposure and click data needed to decide which action deserves the redirect. Effort for the adaptive landing itself: L, and only after the data in row 8 exists. It is deferred, not rejected.\n\n### Platonic Ideal\nNot produced (SELECTIVE EXPANSION mode).\n\n## Scope Decisions\n\n| # | Proposal | Effort | Decision | Reasoning |\n|---|----------|--------|----------|-----------|\n| 0a | Page analytics events: `dashboard_exposure_total` once per route entry, `dashboard_action_click_total{action_id}` per quick-action click, emitted through the existing analytics client from `UserDashboard` and `QuickActions` | S | ACCEPTED (P1) | Already required by the source plan; made explicit because the rollout criteria and row 8 depend on it |\n| 0b | First-action-after-login segmentation: a saved analytics query joining existing login and action-start events by their session key, owned by the rollout owner, reviewed at the Phase 2 evaluation | S | ACCEPTED (P2) | Serves row 8 only, so it must not block shipping. Assumption to verify in task T1 before the query is written: login and action-start events share a session key. If they do not, row 8 is decided on exposure and click data alone. |\n| 1 | \"View all\" link in the footer of ActivityFeed and NotificationsPanel, same tab, no filter state, pointing at the existing full activity page and full notifications page. Rendered only in the success state and only when the section's response cursor indicates more records than were returned; hidden while loading, on error, when empty, and when everything already fits. Routes are the ones the existing pages own; they cannot be read in this repository and are pinned in task T10 at implementation start. | S | ACCEPTED (P1) | Inside blast radius (panel components only); gives the 10-item cap a real destination. Read-state freshness after navigating back is covered by the accepted fetch-on-mount requirement, not by the 60-second focus throttle. |\n| 2 | Unread-count badge in the shared page shell header | S | DEFERRED (P2) | The page shell is outside blast radius |\n| 3 | Inline \"Undo\" after mark-all-read | M | DEFERRED (P3) | Requires a new unmark mutation; the source plan states no new mutation API. Because the bulk-read API is snapshot-bounded, the inverse call is a symmetric M-sized addition when it is picked up. |\n| 4 | Real-time notification updates | L | DEFERRED (P3) | New infra. Revisit criterion, measurable with existing tooling: more than 5 support tickets or member reports per month about stale alerts on the dashboard after the 100% rollout. Until then, fetch on mount, refetch on focus and refetch after mutations cover v1. |\n| 5 | \"New since your last visit\" divider in the activity feed | M | DEFERRED (P3) | Requires persisting a per-member timestamp; new storage |\n| 6 | Prefetch dashboard payload in the login response | M | DEFERRED (P3) | Touches the login flow beyond the single redirect conditional, outside blast radius |\n| 7 | Keyboard shortcuts | S | DEFERRED (P3) | Low value for the first cohort; revisit with usage data |\n| 8 | Adaptive landing: redirect straight into the assigned item when it is the member's only obvious next step; otherwise show the dashboard | L | DEFERRED, Phase 2 (no branch priority) | Decision criterion: after two weeks at 100% rollout, if more than 60% of first actions after login are the registry action labelled \"resume assigned work\" across at least 500 sessions (from the row 0b query), open the Phase 2 plan. Owner: the rollout kill owner. Also the independent CEO reviewer's preferred reframing; surfaced at the Final Gate as a taste item. |\n\n## Accepted Scope (added to this plan)\n- Row 0a: explicit exposure and action-click analytics events (P1).\n- Row 0b: first-action segmentation query (P2, after the join-key check in T1).\n- Row 1: footer \"View all\" links on the two list panels, success state with more records only (P1).\n\n## Deferred to TODOS.md (one line each; design happens when the item is picked up)\n- Shell unread badge (P2, S).\n- Undo for mark-all-read (P3, M); needs a new mutation API decision first.\n- Real-time notifications (P3, L); criterion in row 4.\n- \"New since last visit\" activity divider (P3, M).\n- Prefetch dashboard payload at login (P3, M).\n- Keyboard shortcuts (P3, S).\n- Adaptive landing (Phase 2, L); criterion and owner in row 8.\n"
|
|
}
|
|
},
|
|
{
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"timestamp": "2026-09-09T20:24:27.406Z",
|
|
"toolUseId": "toolu_01FUctxcUNfgcfnxpu5tQvFA",
|
|
"kind": "result",
|
|
"content": "The file /tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack/projects/gstack-autoplan-chain-PdOGYy/ceo-plans/2026-09-09-user-dashboard.md has been updated successfully. (file state is current in your context \u2014 no need to Read it back)",
|
|
"isError": false
|
|
},
|
|
{
|
|
"sessionId": "f59fb94e-e006-49c9-8cdf-983aaa0e3a61",
|
|
"timestamp": "2026-09-09T20:27:34.342Z",
|
|
"toolUseId": "toolu_01STRhL1CTCpvY9CAfwjquhi",
|
|
"kind": "use",
|
|
"name": "Edit",
|
|
"input": {
|
|
"replace_all": false,
|
|
"file_path": "/tmp/gstack-paid-shard-kz30Zk/tmp/gstack-hermetic-2065087-pJs7H4/skill-home-w8xczb/.gstack/projects/gstack-autoplan-chain-PdOGYy/ceo-plans/2026-09-09-user-dashboard.md",
|
|
"old_string": "## Deferred to TODOS.md (one line each; design happens when the item is picked up)",
|
|
"new_string": "## Corrections after adversarial review (three iterations, convergence guard stopped the loop)\n\n- **\"View all\" rule corrected:** shown when the section returned more items than the 10 displayed *or* the cursor indicates further pages. The earlier \"cursor only\" rule would have stranded items 11 to 20.\n- **Kill rules corrected:** measured per 7-day stage against the flag-off cohort with at least 1,000 sessions per cohort; completed-task rate down more than 2 percentage points, or permission-error rate up more than 0.5 percentage points. \"Rises at all\" was noise-prone.\n- **Success target made numeric:** 45 seconds absolute; if the production baseline is already under 60 seconds, the target becomes 25% below baseline and the Final Gate premise item is escalated.\n- **Session join check is P1**, part of task T1 (a precondition to flag-on), with a fallback metric (per-member daily median joined on member ID and day). Row 0b's query remains P2.\n- **Exposure metric labelled** with cohort (flag on or off) and entry kind (redirect or direct visit) so redirected and direct visitors are compared separately.\n- **Toast triggers enumerated:** mark-all-read outcomes only. Quick actions are links and raise no toast.\n- **Route registration file** for `/dashboard` added to blast radius.\n- **Mark-all-read validation tightening** is a decision, not just a blast-radius line: rejecting malformed or future snapshots with 422 is a security hardening accepted in the review record's security section; the API contract for valid input does not change.\n- **Freshness after \"View all\":** `usePanelData` fetches on mount and on every route entry, so a keep-alive router still refreshes.\n- **Row 2 (shell badge) is P3**, consistent with \"design happens when picked up\". **Row 3 (undo)** is not symmetric: it must restore prior read state, so it needs state capture; effort L when picked up.\n- **Units:** \"points\" everywhere means percentage points.\n- **Row 8 criterion is an explicit proxy:** share of first actions labelled \"resume assigned work\" stands in for the trigger population (exactly one assigned item, no unread alerts), which cannot be measured until the dashboard exposes both counts.\n- **Task index:** tasks T1 to T14 are listed in the review record's CEO Implementation Tasks section and in `~/.gstack/projects/gstack-autoplan-chain-PdOGYy/tasks-ceo-review-20260909-201501.jsonl`; the Final Gate aggregates them.\n\n## Reviewer Concerns (unresolved after three iterations)\n\n- The document cannot name routes, action IDs, or the analytics session key because the repository contains no application source. Each is pinned by a named task at implementation start; the reviewer considers that a deferral.\n- Baseline item 1 changes \"Users land here after login\" into a flag-gated cohort redirect. This is a rollout mechanism, not a scope change, but the reviewer wants it labelled as a decision; it is recorded here as such.\n\n## Deferred to TODOS.md (one line each; design happens when the item is picked up)"
|
|
}
|
|
}
|
|
]
|
|
}
|