gstack/test/fixtures/coverage-audit-separator-collision.json

{
 "provenance": {
  "source": "https://github.com/garrytan/gstack/actions/runs/39199692993 eval slice 3, review-coverage-audit (claude-opus-5-5); the first Bash call and its result, byte-exact. review/specialists/testing.md prints a \"---\" line.",
  "recordedPassed": true
 },
 "cwd": "/home/runner/.cache/gstack-paid-shard-0wFRYb/tmp/skill-e2e-review-coverage-WsAy0N",
 "sessionId": "d230c924-9216-4482-9d3c-8bf9a4981b2e",
 "call": {
  "toolUseId": "toolu_01UhC84BBSpsHkQHPabCCEQM",
  "command": "cd /home/runner/.cache/gstack-paid-shard-0wFRYb/tmp/skill-e2e-review-coverage-WsAy0N; cat review/specialists/testing.md; echo ----; cat src/billing.ts; echo ----; cat test/billing.test.ts; echo ----; wc -l review/SKILL.md review/sections/review-army.md",
  "isError": false,
  "output": "# Testing Specialist Review Checklist\n\nScope: Always-on (every review)\nOutput: JSON objects, one finding per line. Schema:\n{\"severity\":\"CRITICAL|INFORMATIONAL\",\"confidence\":N,\"path\":\"file\",\"line\":N,\"category\":\"testing\",\"summary\":\"...\",\"fix\":\"...\",\"fingerprint\":\"path:line:testing\",\"specialist\":\"testing\"}\nOptional: line, fix, fingerprint, evidence, test_stub.\nIf no findings: output `NO FINDINGS` and nothing else.\n\nIf the caller explicitly asks for an ASCII coverage diagram, first read the\nnamed source and test files directly in a dedicated tool call. Keep that tool\ncall limited to those two file reads, using either native Read calls or a simple\nshell display such as `cat -n src/file && echo ---- && cat -n test/file`. Read\ndiffs, package files, configs, or other context in separate tool calls. Then\noutput the diagram before any JSON findings. Use one function root per public or\nchanged function, put the `[OK]` or `[GAP]` marker on the same branch row as the\ntested or missing path, and keep the legend inside the same diagram block:\n\n```text\nsrc/billing.ts\nprocessPayment(amount, currency)\n├── valid USD happy path returns success [OK]\n└── invalid amount / unsupported currency branches [GAP]\nrefundPayment(paymentId, reason)\n└── refund success and guard branches not imported or untested [GAP]\nLegend: [OK] tested [GAP] no test\n```\n\nDo not rely on a summary table, prose paragraph, or distant nested marker as the\nonly coverage evidence. Covered happy-path rows must name the successful, valid,\nor concrete tested input path; gap rows must stay under the function that owns\nthe missing path.\n\n---\n\n## Categories\n\n### Exploratory hypotheses\n\nThe parent runs one shared exploratory QA pass before Fix-First, including small diffs\nthat skip specialists. Supply high-risk changed contracts, adverse scenarios and native\ntest candidates to that pass; do not launch another explorer, edit product/tests or\ncommit. A test proposal uses `test_stub` and keeps the caller's approval requirements.\nCheck real request/queue/storage effects, retries, duplicates and interrupted recovery\nwhere applicable. A diagram or test count is not executed proof. For discoveries promoted\nto regressions, require failure for the reproduced bug before repair and green plus\noriginal/adjacent probes afterward; never accept buggy-output goldens or discarded valid\nred tests. Unit tests suit logic; real integration/E2E tests protect boundaries mocks hide.\n\n### Missing Negative-Path Tests\n- New code paths that handle errors, rejections, or invalid input with NO corresponding test\n- Guard clauses and early returns that are untested\n- Error branches in try/catch, rescue, or error boundaries with no failure-path test\n- Permission/auth checks that are asserted in code but never tested for the \"denied\" case\n\n### Missing Edge-Case Coverage\n- Boundary values: zero, negative, max-int, empty string, empty array, nil/null/undefined\n- Single-element collections (off-by-one on loops)\n- Unicode and special characters in user-facing inputs\n- Concurrent access patterns with no race-condition test\n\n### Negative Assertions\n- A new assertion that something is absent (`not.toContain`, `not in`, `assertNotIn`,\n  `pytest.raises` on a call that used to succeed) records a behavior removal, not coverage.\n  Cite the spec line, plan item or PR text that authorizes the removal; with none, report it\n  as a product decision shipped as a test.\n- A rename or removal in this diff can empty a standing negative assertion: a test asserting\n  the old token is absent now passes forever and guards nothing. For each identifier, flag,\n  heading or string the diff renames or deletes, grep the test suite for negative assertions\n  naming the old value, including inside tests that assert something else, and report each\n  as a coverage gap whose fix names the new value.\n\n### Test Isolation Violations\n- Tests sharing mutable state (class variables, global singletons, DB records not cleaned up)\n- Order-dependent tests (pass in sequence, fail when randomized)\n- Tests that depend on system clock, timezone, or locale\n- Tests that make real network calls instead of using stubs/mocks\n\n### Flaky Test Patterns\n- Timing-dependent assertions (sleep, setTimeout, waitFor with tight timeouts)\n- Assertions on ordering of unordered results (hash keys, Set iteration, async resolution order)\n- Tests that depend on external services (APIs, databases) without fallback\n- Randomized test data without seed control\n\n### Security Enforcement Tests Missing\n- Auth/authz checks in controllers with no test for the \"unauthorized\" case\n- Rate limiting logic with no test proving it actually blocks\n- Input sanitization with no test for malicious input\n- CSRF/CORS configuration with no integration test\n\n### Coverage Gaps\n- New public methods/functions with zero test coverage\n- Changed methods where existing tests only cover the old behavior, not the new branch\n- Utility functions called from multiple places but tested only indirectly\n- A path whose only tests are weak (★ smoke/existence/trivial, or a new test failing the\n  authoring gate below) stays a coverage gap at its existing severity; a low-value test\n  never closes a gap\n\n### Low-value or implementation-coupled tests\nScope: tests and test-only production seams added or changed in the diff. Findings are\nINFORMATIONAL, never CRITICAL, and never an auto-delete: recommend rewrite at the owning\nboundary, extend an existing test, or retire with a complete retirement card\n(`test, detects, non_test_callers, search_command, stronger_proof, history, unlocks,\nvalidation`). End each finding's `fix` with `Repo-wide sweep: run /test-audit.`\n\nA new or changed test passes the authoring gate only when all four answers exist (read\nits `Value: protects=...; fails_when=...; why_new=...; seam=...` header comment when the\ndiff has one; an optional `no_claim=...` names what green does not prove and which\nfixtures or mocks stand in for what, and never waives a required live check):\n1. What observable behavior, invariant or independent contract does it protect?\n2. What credible regression makes it fail?\n3. Why does existing coverage not already catch that? Prefer adding a row to an existing table-driven test or shared fixture over a near-duplicate.\n4. Does it need a production seam (export, flag, wrapper, injection hook) that no production caller needs? If yes, test at the real boundary instead.\n\nPatterns:\n- assertion-free coverage probes\n- self-comparisons and identity copies\n- copied fixtures, inventories or export lists\n- exact source, import or string greps that are not a declared contract\n- private predicate or call-shape tests duplicated at a real boundary\n- duplicate invocations of the same contract\n- per-caller replays of a shared helper's tests\n- tests whose only purpose is keeping a test-only export, global or wrapper alive\n- production code whose only callers are tests\n\nRetention bar (never flag): a test that independently enforces a public API, protocol,\nconfig, migration, storage, security, platform, default, prompt-byte, generated-output\n(SKILL.md golden), package, release or architecture contract; call order when order is\nobservable; source inspection when it is the cheapest independent guard; anything\nreachable from the package entrypoint (`package.json` exports/main, index re-exports).\nStatic or slow is not a reason to delete.\n\nEvidence for each finding goes in `evidence` with the fields `detects` (what failure the\ntest can actually detect), `non_test_callers`, `search_command` and `stronger_proof`.\nFor the last two patterns, run the caller check for each symbol the diff adds or exports,\nonly when the symbol matches `^[A-Za-z_][A-Za-z0-9_]*$` (otherwise record \"caller check\nunavailable: unsupported symbol\"), with the symbol quoted, never interpolated unquoted:\n\n```bash\ngit grep -n -F -w -e '<symbol>' -- . ':!test/' ':!tests/' ':!spec/' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/*_test.*' ':!**/test_*.py'\n```\n\nRecord the command, exclusions and hit count, and mark the evidence \"grep-only\" (it cannot\nsee re-exports, dynamic dispatch or generated code). If the search fails, record: caller\ncheck unavailable: <command>. The finding stays INFORMATIONAL and nothing is proposed for\ndeletion; run the search by hand to complete the evidence. (see\n~/.claude/skills/gstack/docs/test-value-bar.md#caller-check-unavailable)\n\nSkip a test carrying `gstack:test-value keep reason=\"<why>\"` (any comment syntax). If any\nwere skipped, report their count and reasons as one INFORMATIONAL line. Emit no finding\nfor a test you reviewed and kept.\n\nRejection vocabulary, when a finding names why a new test fails the gate:\n`duplicate_protects`, `needs_seam`, `incomplete_card`, `no_credible_regression`,\n`covered_elsewhere`, `implementation_coupled`.\n\n### Regression test without red proof\n- The diff adds a test named or commented as a regression, and neither the commit history\n  nor the PR body shows it failing before the fix. A regression test that never\n  demonstrably failed proves the mock, not the fix. INFORMATIONAL; ask for the\n  fails-at-HEAD / passes-after-fix record.\n----\n\nexport function processPayment(amount: number, currency: string) {\n  if (amount <= 0) throw new Error('Invalid amount');\n  if (currency !== 'USD' && currency !== 'EUR') throw new Error('Unsupported currency');\n  return { status: 'success', amount, currency };\n}\n\nexport function refundPayment(paymentId: string, reason: string) {\n  if (!paymentId) throw new Error('Payment ID required');\n  if (!reason) throw new Error('Reason required');\n  return { status: 'refunded', paymentId, reason };\n}\n\n// coverage-read-evidence: 327b3980-777b-4f27-8c7e-a204a4a1857f\n----\n\nimport { describe, test, expect } from 'vitest';\nimport { processPayment } from '../src/billing';\n\ndescribe('processPayment', () => {\n  test('processes valid payment', () => {\n    const result = processPayment(100, 'USD');\n    expect(result.status).toBe('success');\n  });\n  // GAP: no test for invalid amount\n  // GAP: no test for unsupported currency\n  // GAP: refundPayment not tested at all\n});\n\n// coverage-read-evidence: f9dbc617-45bc-46ea-8cb7-db50c869530e\n----\n  856 review/SKILL.md\n  263 review/sections/review-army.md\n 1119 total"
 },
 "files": {
  "source": "\nexport function processPayment(amount: number, currency: string) {\n  if (amount <= 0) throw new Error('Invalid amount');\n  if (currency !== 'USD' && currency !== 'EUR') throw new Error('Unsupported currency');\n  return { status: 'success', amount, currency };\n}\n\nexport function refundPayment(paymentId: string, reason: string) {\n  if (!paymentId) throw new Error('Payment ID required');\n  if (!reason) throw new Error('Reason required');\n  return { status: 'refunded', paymentId, reason };\n}\n\n// coverage-read-evidence: 327b3980-777b-4f27-8c7e-a204a4a1857f\n",
  "tests": "\nimport { describe, test, expect } from 'vitest';\nimport { processPayment } from '../src/billing';\n\ndescribe('processPayment', () => {\n  test('processes valid payment', () => {\n    const result = processPayment(100, 'USD');\n    expect(result.status).toBe('success');\n  });\n  // GAP: no test for invalid amount\n  // GAP: no test for unsupported currency\n  // GAP: refundPayment not tested at all\n});\n\n// coverage-read-evidence: f9dbc617-45bc-46ea-8cb7-db50c869530e\n"
 }
}