mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-31 05:56:37 +01:00
* fix(make-pdf,design): real TOC page numbers and anchors; design models move to gpt-5.5 + gpt-image-2 (#2903, #2807) * ci: pin every action to a SHA, Scorecard, checksummed Bun, scoped Codex CLI in the CI image, macOS named-regressions job (#1948, #1706, #1997) * fix(cso,browse): Windows/macOS lease identity, retention skips bad runs, truthful 'not assessed' reports, env.kv false positive, Windows browse spawn fixes (#2894, #2912, #2048, #2637, #2805) * fix(outside-voice): one Codex model precedence for probe and dispatch, bounded timeouts with KILL escalation, probe cache identity, guarded mktemp, skills hidden in nested Codex (#2776, #2914, #2787, #2881, #2847) * feat(setup): install registry, ./setup --status, staged activation, per-scope migrations, host tiers and conformance kit, OpenCode/Hermes fixes, Copilot CLI (experimental), disabled_skills, slimmer CLAUDE.md (#1925, #2879, #2347, #2338, #2626, #2629, #2825, #2015, #393, #1206, #2096) Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com> * fix(preamble): skills start in worktree-isolated Claude Code sessions — one literal skill-start line, context-recovery helper, no eval in skill blocks, $N token tripwire, honest plan-mode precedence (#2763, #2896, #2851) * fix(setup): per-install renders for renamed, vendored and custom-config installs, space-safe alias roots, per-host /cso launcher path (#1882, #2906) * test: free tests never write the real HOME (home-write tripwire), no orphaned browse daemons, symlinked-TMPDIR (macOS) fixes, gbrain-on-PATH isolation (#2895, #2816, #2829, #2841, #2982, #2911, #2909, #2908, #2910) * chore: integrate wave follow-ups — regenerate all hosts, README model docs, TODOS, touchfiles, duration seeds, Bun 1.3 telemetry test fix, replay fixtures pinned to their recorded bytes * v1.91.14.0: release metadata * test(browse): group-kill cleanup falls back to the leader when macOS returns EPERM for a live group * ci: Codex login steps run under bash (the CI container's default sh rejects pipefail) * fix: full-suite repairs — private state roots for 7 real-HOME writers, truthful home-guard attribution with --attribute-home, gstack-paths shim in ship-hook fixtures, Copilot in team-init probes, test-of-test detector, cookie review fixture pinned to the approved excerpt * fix(windows): LF for Dockerfiles, normalized home-guard exclusions, path.relative fixture containment, ship push test spawn timeouts * test(design-detect): widen the whole-scan budget test's timing margins so a loaded macOS runner can't time out the single-batch call * fix(evals): qa protocol names defined for the judge, async PTY judge so overlapping sessions keep their cleanup deadline, bws setup cases use the standard JUDGE_MS tier * test(pty): the non-blocking judge case is POSIX-only (its fake judge is a shebang script, like the PTY harness it covers) * test(evals): ship-coverage-audit names absolute skill paths, uses Read, and skips the Step 7 artifact nothing consumes (removes the mechanism behind 3 of 4 historical timeouts) * test: deflake terminal-agent concurrent startup (write the placeholder record before spawning, like the product) and qa-evidence resumed pipe (barrier on a full high-water mark instead of a sleep) * fix(design): daemon log stream handles open errors instead of crashing the daemon; shutdown test awaits the stubbed exit * test(evals): skillify checks the product's resolved state root (no GSTACK_HOME bypass), negative cases check every root; tpa shims live outside the agent's cwd and answer consistently * test(evals): coverage-audit detector splits parallel columns at │ rails and [+] groups; coverage prompts name absolute skill paths; TODOs from the gate eval census * fix(plan-eng-review): scope gate always sends the menu (no headless 'Scope pending' exit); PTY harness ends idle turn-ends and API-error panels promptly with a precise diagnostic * test(evals): one position-bound coverage-read rule credits read-only && chains (labels, context ranges, git displays in either order) and still rejects forged output * fix(ship): documentation section has one saved source inserted by cat (never retyped); spawned-marker evidence is the child output; refreshed codex/factory ship goldens * test(docsync): the byte-exact insert positive is POSIX-only (the bash-command observer refuses backslash paths by design) * test(evals): plan-design-with-ui focus-title rule accepts the comma-less 'dimensions or focus' wording (replayed on the captured CI run, negative controls kept) * fix(qa-callers): exploratory preflight says the scope/method Reads come after exploratory.md; design-review scan check credits an executed scan proven by one engine run over the changed files --------- Co-authored-by: Andrey Esipov <61357035+andrey-esipov@users.noreply.github.com> Co-authored-by: Matthew Williams <5863886+ridermw@users.noreply.github.com> Co-authored-by: Rocky Wu <92764750+lolisaigao1234@users.noreply.github.com>
76 lines
3.7 KiB
TypeScript
76 lines
3.7 KiB
TypeScript
/**
|
|
* Skills start in worktree-isolated Claude Code sessions (#2763).
|
|
*
|
|
* A session isolated to `.claude/worktrees/<name>` refuses any Bash command it
|
|
* cannot statically prove keeps git inside the worktree. Reproduced with the
|
|
* pinned CLI (2.1.284, `claude -p --worktree`), refused verbatim:
|
|
* - a command named by a variable (`"$_SS" …`): "runs a command whose name
|
|
* is computed at runtime inside a construct too complex to verify"
|
|
* - `eval "$(…gstack-slug…)"` / `eval "$(…gstack-paths)"`, `.` / `source`:
|
|
* "runs eval inside a construct too complex to verify"
|
|
* - git inside a pipe or an argument substitution, or `X=$(git …)` followed
|
|
* by further commands: "names git in a form too complex to verify"
|
|
* while a literal-path command, `X=$(<literal path> …)` and `: "${X:?…}"` run.
|
|
* These checks pin the generated shapes to the forms that ran.
|
|
*/
|
|
import { describe, test, expect } from 'bun:test';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
const EVAL_HELPER = /\beval\s+"\$\(.*gstack-(?:slug|paths)/;
|
|
|
|
function claudeSkills(): string[] {
|
|
const dirs = fs.readdirSync(ROOT, { withFileTypes: true }).filter(e => e.isDirectory() && !e.name.startsWith('.') && e.name !== 'node_modules');
|
|
const files = ['SKILL.md'];
|
|
for (const d of dirs) {
|
|
if (fs.existsSync(path.join(ROOT, d.name, 'SKILL.md'))) files.push(path.join(d.name, 'SKILL.md'));
|
|
const sections = path.join(ROOT, d.name, 'sections');
|
|
if (fs.existsSync(sections)) for (const f of fs.readdirSync(sections)) if (f.endsWith('.md')) files.push(path.join(d.name, 'sections', f));
|
|
}
|
|
return files;
|
|
}
|
|
|
|
function bashFences(text: string): string[] {
|
|
return [...text.matchAll(/^```(?:bash|sh)\n([\s\S]*?)\n```/gm)].map(m => m[1]!);
|
|
}
|
|
|
|
function fenceAfter(text: string, heading: RegExp): string {
|
|
const at = text.search(heading);
|
|
expect(at).toBeGreaterThan(-1);
|
|
const open = text.indexOf('```bash\n', at) + '```bash\n'.length;
|
|
return text.slice(open, text.indexOf('\n```', open));
|
|
}
|
|
|
|
describe('worktree-isolated session shapes (#2763)', () => {
|
|
test('no generated Claude skill or section evals gstack-slug or gstack-paths', () => {
|
|
const offenders: string[] = [];
|
|
for (const file of claudeSkills()) {
|
|
for (const fence of bashFences(fs.readFileSync(path.join(ROOT, file), 'utf-8'))) {
|
|
for (const line of fence.split('\n')) if (EVAL_HELPER.test(line)) offenders.push(`${file}: ${line.trim()}`);
|
|
}
|
|
}
|
|
expect(offenders).toEqual([]);
|
|
});
|
|
|
|
test('the skill start, context recovery and eureka blocks use only the forms that ran', () => {
|
|
let starts = 0;
|
|
for (const file of claudeSkills().filter(f => f.endsWith('SKILL.md'))) {
|
|
const text = fs.readFileSync(path.join(ROOT, file), 'utf-8');
|
|
if (!/^## Preamble \((?:run first|after scope gate)\)/m.test(text)) continue;
|
|
starts++;
|
|
expect(fenceAfter(text, /^## Preamble \((?:run first|after scope gate)\)/m), file)
|
|
.toMatch(/^~\/\.claude\/skills\/gstack\/bin\/gstack-skill-start --skill "[a-z0-9-]+" --model "[a-z0-9.-]+"$/);
|
|
if (text.includes('\n## Context Recovery\n')) {
|
|
expect(fenceAfter(text, /^## Context Recovery$/m), file).toBe('~/.claude/skills/gstack/bin/gstack-context-recovery');
|
|
}
|
|
if (text.includes('**Eureka:**')) {
|
|
const eureka = fenceAfter(text, /\*\*Eureka:\*\*/);
|
|
expect(eureka, file).not.toMatch(/\beval\b|^\.\s|\bsource\b|\$\(git\b|^"\$/m);
|
|
expect(eureka.split('\n')[0], file).toBe('GSTACK_STATE_ROOT=$(~/.claude/skills/gstack/bin/gstack-paths --get GSTACK_STATE_ROOT); : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"');
|
|
}
|
|
}
|
|
expect(starts).toBeGreaterThan(40);
|
|
});
|
|
});
|