mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-11 07:29:00 +02:00
Garry TanandClaude Fable 5
3e674e4c01
spawnSync/execSync/Bun.spawnSync BLOCK the main thread, so bun's in-process per-test timeout can never fire while one waits — a hung child (stdin read, network probe, dead daemon) wedges the whole shard until the runner's external wall-clock SIGKILL. This exact class reached main: free-tests run 33262077256, test/gstack-memory-ingest.test.ts (normally 2.3s) held shard 2 at the 360s wall while its five siblings finished in ~65s. Mechanical sweep in two waves (12 + 4 fan-out agents, every edit verified against its call site): default timeout: 30_000 (matches the free runner's per-test budget), 120_000 for genuinely slow ops (installs, builds, playwright, provider CLIs), helper wrappers fixed ONCE where call sites route through them. Sites that only LOOK like calls (string fixtures, grep needles, comments) were skipped with reasons — the enforcement commit that follows marks them exempt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
72 lines
2.8 KiB
TypeScript
72 lines
2.8 KiB
TypeScript
import { describe, test, expect } from 'bun:test';
|
|
import { spawnSync } from 'child_process';
|
|
import * as path from 'path';
|
|
|
|
const HELPER = path.join(import.meta.dir, '..', 'bin', 'gstack-pr-title-rewrite.sh');
|
|
|
|
function rewrite(version: string, title: string): { stdout: string; status: number; stderr: string } {
|
|
const r = spawnSync(HELPER, [version, title], { encoding: 'utf-8', timeout: 30_000 });
|
|
return { stdout: (r.stdout ?? '').trimEnd(), status: r.status ?? -1, stderr: r.stderr ?? '' };
|
|
}
|
|
|
|
describe('gstack-pr-title-rewrite', () => {
|
|
test('already correct: no change', () => {
|
|
const r = rewrite('1.2.3.4', 'v1.2.3.4 feat: foo');
|
|
expect(r.status).toBe(0);
|
|
expect(r.stdout).toBe('v1.2.3.4 feat: foo');
|
|
});
|
|
|
|
test('different version prefix: replaces it', () => {
|
|
expect(rewrite('1.2.3.5', 'v1.2.3.4 feat: foo').stdout).toBe('v1.2.3.5 feat: foo');
|
|
});
|
|
|
|
test('different prefix length (3-part vs 4-part): replaces it', () => {
|
|
expect(rewrite('1.2.3.4', 'v1.2.3 feat: foo').stdout).toBe('v1.2.3.4 feat: foo');
|
|
});
|
|
|
|
test('bare correct version (no description): no change, not duplicated', () => {
|
|
// CHANGELOG/ship uses a version-only title for branch-ahead bumps. It must
|
|
// stay as-is, not become "v1.2.3.4 v1.2.3.4".
|
|
expect(rewrite('1.2.3.4', 'v1.2.3.4').stdout).toBe('v1.2.3.4');
|
|
});
|
|
|
|
test('bare different version (no description): replaces, not duplicates', () => {
|
|
// Must strip the stale prefix even with nothing after it, otherwise CI
|
|
// writes back "v1.2.3.4 v1.2.3".
|
|
expect(rewrite('1.2.3.4', 'v1.2.3').stdout).toBe('v1.2.3.4');
|
|
});
|
|
|
|
test('idempotent on a bare version title', () => {
|
|
const once = rewrite('1.2.3.4', 'v1.2.3').stdout;
|
|
expect(rewrite('1.2.3.4', once).stdout).toBe(once);
|
|
});
|
|
|
|
test('no version prefix: prepends', () => {
|
|
expect(rewrite('1.2.3.4', 'feat: foo').stdout).toBe('v1.2.3.4 feat: foo');
|
|
});
|
|
|
|
test('does not mistake plain words for a prefix', () => {
|
|
expect(rewrite('1.2.3.4', 'version 5 feature').stdout).toBe('v1.2.3.4 version 5 feature');
|
|
});
|
|
|
|
test('does not strip a single-segment prefix like v1', () => {
|
|
expect(rewrite('1.2.3.4', 'v1 feat: foo').stdout).toBe('v1.2.3.4 v1 feat: foo');
|
|
});
|
|
|
|
test('errors on missing args', () => {
|
|
const r = spawnSync(HELPER, ['1.2.3.4'], { encoding: 'utf-8', timeout: 30_000 });
|
|
expect(r.status).not.toBe(0);
|
|
});
|
|
|
|
test('rejects malformed VERSION with shell metacharacters', () => {
|
|
expect(rewrite('1.*.*.*', 'feat: foo').status).toBe(2);
|
|
expect(rewrite('1.2.3.4; rm -rf /', 'feat: foo').status).toBe(2);
|
|
});
|
|
|
|
test('idempotent: applying twice yields the same result', () => {
|
|
const once = rewrite('1.2.3.4', 'feat: foo').stdout;
|
|
const twice = rewrite('1.2.3.4', once).stdout;
|
|
expect(twice).toBe(once);
|
|
});
|
|
});
|