mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-13 00:19:03 +02:00
Garry TanandClaude Fable 5
3e674e4c01
spawnSync/execSync/Bun.spawnSync BLOCK the main thread, so bun's in-process per-test timeout can never fire while one waits — a hung child (stdin read, network probe, dead daemon) wedges the whole shard until the runner's external wall-clock SIGKILL. This exact class reached main: free-tests run 33262077256, test/gstack-memory-ingest.test.ts (normally 2.3s) held shard 2 at the 360s wall while its five siblings finished in ~65s. Mechanical sweep in two waves (12 + 4 fan-out agents, every edit verified against its call site): default timeout: 30_000 (matches the free runner's per-test budget), 120_000 for genuinely slow ops (installs, builds, playwright, provider CLIs), helper wrappers fixed ONCE where call sites route through them. Sites that only LOOK like calls (string fixtures, grep needles, comments) were skipped with reasons — the enforcement commit that follows marks them exempt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
82 lines
2.8 KiB
TypeScript
82 lines
2.8 KiB
TypeScript
/**
|
|
* gstack-upgrade/migrations/v1.0.0.0.sh — writing style migration.
|
|
*
|
|
* Coverage:
|
|
* - Fresh state: writes the pending-prompt flag
|
|
* - Idempotent: second run does nothing if .writing-style-prompted exists
|
|
* - Pre-set explain_level: counts as answered (user already decided)
|
|
*/
|
|
import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import * as os from 'os';
|
|
import { spawnSync } from 'child_process';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
const MIGRATION = path.join(ROOT, 'gstack-upgrade', 'migrations', 'v1.0.0.0.sh');
|
|
|
|
let tmpHome: string;
|
|
|
|
beforeEach(() => {
|
|
tmpHome = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-mig-test-'));
|
|
});
|
|
|
|
afterEach(() => {
|
|
fs.rmSync(tmpHome, { recursive: true, force: true });
|
|
});
|
|
|
|
function run(): { stdout: string; stderr: string; status: number } {
|
|
// Override HOME too — the migration reads `${HOME}/.claude/skills/gstack/bin/gstack-config`,
|
|
// and the developer's real config may have `explain_level` set, which the
|
|
// migration interprets as "user already decided" and short-circuits without
|
|
// writing the pending-prompt flag (breaking these tests).
|
|
const res = spawnSync('bash', [MIGRATION], {
|
|
encoding: 'utf-8',
|
|
env: { ...process.env, GSTACK_HOME: tmpHome, HOME: tmpHome },
|
|
timeout: 30_000,
|
|
});
|
|
return {
|
|
stdout: (res.stdout ?? '').trim(),
|
|
stderr: (res.stderr ?? '').trim(),
|
|
status: res.status ?? -1,
|
|
};
|
|
}
|
|
|
|
describe('v1.0.0.0 upgrade migration', () => {
|
|
test('migration file exists and is executable', () => {
|
|
expect(fs.existsSync(MIGRATION)).toBe(true);
|
|
const stat = fs.statSync(MIGRATION);
|
|
// Owner execute bit should be set
|
|
expect(stat.mode & 0o100).toBeGreaterThan(0);
|
|
});
|
|
|
|
test('fresh state: writes pending-prompt flag', () => {
|
|
const result = run();
|
|
expect(result.status).toBe(0);
|
|
expect(fs.existsSync(path.join(tmpHome, '.writing-style-prompt-pending'))).toBe(true);
|
|
});
|
|
|
|
test('idempotent: second run after user answered is a no-op', () => {
|
|
// Simulate user answered: flag exists
|
|
fs.writeFileSync(path.join(tmpHome, '.writing-style-prompted'), '');
|
|
|
|
const result = run();
|
|
expect(result.status).toBe(0);
|
|
// No pending flag created
|
|
expect(fs.existsSync(path.join(tmpHome, '.writing-style-prompt-pending'))).toBe(false);
|
|
});
|
|
|
|
test('idempotent: pre-existing pending flag is not duplicated', () => {
|
|
// First run
|
|
run();
|
|
const firstStat = fs.statSync(path.join(tmpHome, '.writing-style-prompt-pending'));
|
|
|
|
// Second run — flag stays, no error
|
|
const result = run();
|
|
expect(result.status).toBe(0);
|
|
// Flag still exists; mtime may update but existence is stable
|
|
expect(fs.existsSync(path.join(tmpHome, '.writing-style-prompt-pending'))).toBe(true);
|
|
void firstStat;
|
|
});
|
|
});
|