mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 14:38:59 +02:00
Garry TanandClaude Fable 5.1
da6f0ff2f6
The DOM-dump script is an arrow function, not a self-calling IIFE: Aside's `pg.evaluate($_DUMP)` receives the function and runs it in the page (the IIFE form executed in the repl sandbox, where `document` does not exist), and the fallback engine calls it with `$B js "($_DUMP)()" --out --raw`. Hygiene widens to every URL-bearing attribute (src, srcset per candidate, poster, action, formaction, data, ping, cite lose their query strings and fragments) and to data: URLs inside existing <style> nodes. The persist and scan blocks restate REPORT_DIR and RUN_ID literally instead of relying on a shell variable from an earlier block; the baseline's targetSet is defined per mode (repo-relative paths in source mode, page slugs in DOM mode) so DOM-mode deltas can match; the PR-body Detector line lists the states the probe can actually print. The DOM fixture is re-captured with the new script from outside the repo (the engine walks up from cwd for DESIGN.md, which the metadata now records). Doctrine contradictions the design specialist found: the landing-page motion rule matches the one-authored-moment reflex; the background rule names the catalog's halo/spotlight/stripe/grid slop instead of asking for gradients; the universal font rule is scoped to the display voice with the body/UI exceptions; "two typefaces max" allows the mono; the methodology's banned-font line renders BANNED_FONTS; Courier New is banned outright; the Brutalist, Retro-Futuristic, and Playful menu entries stop recommending system stacks, glow, and bounce; the coherence nudge uses the decoration vocabulary; Path A's gate names the display voice; font-loading prose points at the source the procedure verified; centered-everything is MEDIUM (an aggregate heuristic); the mockup guard reads "Never by default (unless the brief above asks for it)". The checklist's AUTO-FIX list renders the catalog's auto-fix rules; category 9 and the Hard Rules pointer count from the same partition helpers (detectorSlopEntries, judgmentTellEntries); the handoff list renders from HANDOFF_COMMANDS; a missing catalog id fails gen-skill-docs by name. gstack's own DESIGN.md gains border tokens and Decisions Log rows for its live-feed pulse and 11px mono labels. frontend-scope is case-sensitive like the bash arm. gen-skill-docs shares one emitGenerated helper for sections and lib-derived assets; renderCatalog keeps the one style with a caller. Tests: shared sliceBetween that fails on a missing end marker, the slop-gate fixture's real end marker, an isolated browse daemon for the DOM-mode E2E, the DOM hygiene test gated to CI or opt-in, docs notes for the two superseded plan sentences. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
45 lines
2.1 KiB
TypeScript
45 lines
2.1 KiB
TypeScript
/**
|
|
* briefToPrompt carries the catalog's generation-time slop guard.
|
|
*
|
|
* The "Never:" line is built from MOCKUP_NEVER_NAMES (lib/design-catalog.ts),
|
|
* so the image model is told up front what not to reach for. The catalog test
|
|
* owns the "exactly ten ids" invariant; this one pins the prompt shape.
|
|
*/
|
|
import { describe, expect, test } from "bun:test";
|
|
import { briefToPrompt, type DesignBrief } from "../src/brief";
|
|
import { MOCKUP_NEVER_NAMES } from "../../lib/design-catalog";
|
|
|
|
const brief: DesignBrief = {
|
|
goal: "Dashboard for a coding assessment tool",
|
|
audience: "Technical users",
|
|
style: "Dark theme, minimal",
|
|
elements: ["builder name", "score badge"],
|
|
screenType: "desktop-dashboard",
|
|
};
|
|
|
|
describe("briefToPrompt", () => {
|
|
test("carries a Never-by-default line listing every MOCKUP_NEVER_NAMES entry, before the fixed tail", () => {
|
|
const prompt = briefToPrompt(brief);
|
|
const never = `Never by default (unless the brief above asks for it): ${MOCKUP_NEVER_NAMES.join(", ")}.`;
|
|
expect(prompt).toContain(never);
|
|
expect(MOCKUP_NEVER_NAMES.length).toBeGreaterThanOrEqual(8);
|
|
for (const name of MOCKUP_NEVER_NAMES) expect(prompt).toContain(name);
|
|
expect(prompt.indexOf(never)).toBeLessThan(prompt.indexOf("The mockup should look like a real production UI"));
|
|
expect(prompt.indexOf(never)).toBeGreaterThan(prompt.indexOf("Required elements:"));
|
|
});
|
|
|
|
test("names are plain English: no hyphenated rule ids leak into the prompt", () => {
|
|
const prompt = briefToPrompt(brief);
|
|
expect(prompt).not.toMatch(/\b[a-z]+(-[a-z]+)+\b(?=[,.])/);
|
|
for (const name of MOCKUP_NEVER_NAMES) expect(name).not.toMatch(/^[a-z0-9]+(-[a-z0-9]+)+$/);
|
|
});
|
|
|
|
test("optional fields still render around the guard", () => {
|
|
const prompt = briefToPrompt({ ...brief, constraints: "Max width 1024px", reference: "DESIGN.md excerpt" });
|
|
expect(prompt).toContain("Constraints: Max width 1024px.");
|
|
expect(prompt).toContain("Design reference: DESIGN.md excerpt");
|
|
expect(prompt).toContain("Never by default (unless the brief above asks for it): ");
|
|
expect(prompt.endsWith("1536x1024 pixels.")).toBe(true);
|
|
});
|
|
});
|