mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 22:48:57 +02:00
Garry TanandClaude Fable 5.1
982a738663
- The DOM-dump Aside block was the only double-quoted `aside repl` script in
the tree (to splice the function text), which put the agent-filled <url>
inside a double-quoted bash string: a same-origin href carrying $(...) would
run in the reviewer's shell when Phase 3 opened that page. The script is
single-quoted like every other Aside script and the function text enters
through a closed-quote segment ('"$_DUMP"'); the fallback line is
`$B js '('"$_DUMP"')()'`. A free test pins that no rendered Aside script
opens with a double quote.
- The persist block capped dumps at 10 MiB but ran gstack-redact with its
1 MiB default, so every real page between the two was deleted as
DOM_DUMP_REDACTION_BLOCKED; the gate passes --max-bytes at the dump cap and
blocks on any exit other than clean (0) or MEDIUM (2), so a redaction tool
that fails to run can no longer fall through to "persist".
- Dump hygiene removes <template> and <noscript> subtrees (invisible to the
attribute walk), inline on* handlers, and the cross-origin <link> nodes
already named in the note, so the file handed to the engine references no
remote stylesheet.
- Doctrine: the Codex design-voice prompts said "2-3 intentional motions"
against the one-authored-moment rule; the overused-display heading scoped
its ban to Persuade/Experience while the catalog and hard rules ban it
everywhere; design-consultation's Important Rule 4 still said "as primary";
design-html's blacklist header is now "Never include by default" with the
mockup/DESIGN.md/user-ask override the catalog grants; the slop gate honors
Decisions Log and Do's and Don'ts blessings like /review does; the landing
"poster" line says poster in stance, not type size; the design binary's
variant dials no longer flip light/dark for variety; gstack's DESIGN.md
rows name data labels (UI labels stay the DM Sans token) and call the
skill-bar fill and hovers functional transitions.
- design-review names how the base branch is found (gh pr view, then the
repo default; never main) for the source-mode scan and the diff-aware mode.
- frontend-scope matches the config globs at the repo root only, like the
bash arm; the parity test carries nested samples.
- Cleanups: renderCatalog's stale style option, an unused import, the
identity-map bannedFontNames, the checklist header's "same entries" claim,
the catalog header's consumer list, the orphaned main() docstring, the
plan doc's IIFE bullet. design-html's skeleton ceiling is re-measured
(54,184) for the two doctrine sentences.
Tests: AUTO-FIX rendering from the catalog, the E2E slice markers checked in
the free suite, the hygiene cases for templates/noscript/handlers/remote
links, and the review E2E counting detector rows separately from the seven
checklist plants.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
34 lines
1.6 KiB
TypeScript
34 lines
1.6 KiB
TypeScript
// lib/frontend-scope.ts — which repo paths count as frontend.
|
|
//
|
|
// Pure module: no I/O, no imports from scripts/. The patterns mirror the
|
|
// `m_frontend` arm of bin/gstack-diff-scope (the bash source of truth for
|
|
// SCOPE_FRONTEND); test/frontend-scope.test.ts pins the two against the same
|
|
// sample paths so they cannot drift. bin/gstack-design-detect.ts uses this to
|
|
// derive `scan --changed <base>` targets without consuming a shell-split list.
|
|
|
|
const EXTENSIONS = new Set([
|
|
'.css', '.scss', '.less', '.sass', '.pcss',
|
|
'.tsx', '.jsx', '.vue', '.svelte', '.astro',
|
|
'.erb', '.haml', '.slim', '.hbs', '.ejs',
|
|
'.html',
|
|
]);
|
|
|
|
// Root-level only: the bash arm's glob (`tailwind.config.*`) is matched against the
|
|
// whole repo-relative path, so a nested `apps/web/tailwind.config.js` is not frontend there.
|
|
const ROOT_CONFIG_PREFIXES = ['tailwind.config.', 'postcss.config.'];
|
|
|
|
/** Repo-relative path (forward slashes) → is it a frontend file per gstack-diff-scope? */
|
|
export function isFrontendPath(relPath: string): boolean {
|
|
const rel = relPath.replace(/\\/g, '/').replace(/^\.\//, '');
|
|
const base = rel.slice(rel.lastIndexOf('/') + 1);
|
|
const dot = base.lastIndexOf('.');
|
|
const ext = dot >= 0 ? base.slice(dot) : ''; // case-sensitive, exactly like gstack-diff-scope's globs
|
|
if (EXTENSIONS.has(ext)) return true;
|
|
if (!rel.includes('/') && ROOT_CONFIG_PREFIXES.some(p => base.startsWith(p))) return true;
|
|
if (rel.startsWith('app/views/')) return true;
|
|
if (rel.includes('/components/')) return true;
|
|
if (rel.startsWith('styles/') || rel.startsWith('css/')) return true;
|
|
if (rel.startsWith('app/assets/stylesheets/')) return true;
|
|
return false;
|
|
}
|