mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 06:28:59 +02:00
Garry TanandClaude Fable 5
3e674e4c01
spawnSync/execSync/Bun.spawnSync BLOCK the main thread, so bun's in-process per-test timeout can never fire while one waits — a hung child (stdin read, network probe, dead daemon) wedges the whole shard until the runner's external wall-clock SIGKILL. This exact class reached main: free-tests run 33262077256, test/gstack-memory-ingest.test.ts (normally 2.3s) held shard 2 at the 360s wall while its five siblings finished in ~65s. Mechanical sweep in two waves (12 + 4 fan-out agents, every edit verified against its call site): default timeout: 30_000 (matches the free runner's per-test budget), 120_000 for genuinely slow ops (installs, builds, playwright, provider CLIs), helper wrappers fixed ONCE where call sites route through them. Sites that only LOOK like calls (string fixtures, grep needles, comments) were skipped with reasons — the enforcement commit that follows marks them exempt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
83 lines
3.7 KiB
TypeScript
83 lines
3.7 KiB
TypeScript
/**
|
|
* Deprecated codex web-search flag tripwire (#2525).
|
|
*
|
|
* codex >=0.144 deprecates `--enable web_search_cached` (its `--enable
|
|
* <FEATURE>` surface now means `-c features.<name>=true`); the replacement
|
|
* is `-c 'web_search="cached"'`, owned by ONE constant:
|
|
* CODEX_WEB_SEARCH_FLAG in scripts/resolvers/constants.ts. Resolvers
|
|
* interpolate it; templates reference {{CODEX_WEB_SEARCH_FLAG}}.
|
|
*
|
|
* These tests fail CI if the deprecated spelling re-enters any source
|
|
* (resolver, template, helper) or any rendered SKILL.md / section / golden.
|
|
*/
|
|
import { describe, test, expect } from 'bun:test';
|
|
import { execSync } from 'child_process';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { CODEX_WEB_SEARCH_FLAG } from '../scripts/resolvers/constants';
|
|
|
|
const ROOT = path.join(import.meta.dir, '..');
|
|
const DEPRECATED = '--enable web_search_cached';
|
|
|
|
function grepRepo(pattern: string, includes: string[]): string[] {
|
|
const includeArgs = includes.map((i) => `--include='${i}'`).join(' ');
|
|
const out = execSync(
|
|
`grep -rln ${includeArgs} -e '${pattern}' "${ROOT}" || true`,
|
|
{ encoding: 'utf-8', timeout: 30_000 },
|
|
);
|
|
return out
|
|
.split('\n')
|
|
.filter(Boolean)
|
|
.filter((f) => !f.includes('node_modules'))
|
|
// The workspace-local .claude/ install is not generated output and can
|
|
// carry dangling symlinks from unrelated sessions.
|
|
.filter((f) => !f.includes('/.claude/'))
|
|
.filter((f) => !f.endsWith('test/codex-web-search-flag.test.ts'));
|
|
}
|
|
|
|
describe('deprecated codex web-search flag is gone (#2525)', () => {
|
|
test('the replacement flag has exactly the documented shape', () => {
|
|
expect(CODEX_WEB_SEARCH_FLAG).toBe(`-c 'web_search="cached"'`);
|
|
});
|
|
|
|
test('no rendered SKILL.md or section carries the deprecated flag', () => {
|
|
const hits = grepRepo(DEPRECATED, ['SKILL.md', '*.md']);
|
|
expect(hits).toEqual([]);
|
|
});
|
|
|
|
test('no source file (resolver, template, helper) carries the deprecated flag', () => {
|
|
const hits = grepRepo(DEPRECATED, ['*.ts', '*.tmpl']);
|
|
expect(hits).toEqual([]);
|
|
});
|
|
|
|
test('rendered codex skill actually resolves the token to the live flag', () => {
|
|
const rendered = fs.readFileSync(path.join(ROOT, 'codex', 'SKILL.md'), 'utf-8');
|
|
expect(rendered).toContain(CODEX_WEB_SEARCH_FLAG);
|
|
expect(rendered).not.toContain('{{CODEX_WEB_SEARCH_FLAG}}');
|
|
});
|
|
|
|
test('rendered codex mode sections resolve the token at every invocation site', () => {
|
|
// The mode bodies (and their codex invocations) are carved into
|
|
// codex/sections/*-mode.md (T9) — each generated section must carry the
|
|
// live flag, never the unresolved token.
|
|
for (const file of ['review-mode.md', 'challenge-mode.md', 'consult-mode.md']) {
|
|
const rendered = fs.readFileSync(path.join(ROOT, 'codex', 'sections', file), 'utf-8');
|
|
expect(rendered, `${file} lost the web-search flag`).toContain(CODEX_WEB_SEARCH_FLAG);
|
|
expect(rendered).not.toContain('{{CODEX_WEB_SEARCH_FLAG}}');
|
|
}
|
|
});
|
|
|
|
test('rendered autoplan phase sections resolve the token at every inline site', () => {
|
|
// The four phase bodies (and their codex invocations) are carved into
|
|
// autoplan/sections/*-phase.md — each generated section must carry the
|
|
// live flag, never the unresolved token.
|
|
for (const file of ['ceo-phase.md', 'design-phase.md', 'eng-phase.md', 'dx-phase.md']) {
|
|
const rendered = fs.readFileSync(path.join(ROOT, 'autoplan', 'sections', file), 'utf-8');
|
|
expect(rendered, `${file} lost the web-search flag`).toContain(CODEX_WEB_SEARCH_FLAG);
|
|
expect(rendered).not.toContain('{{CODEX_WEB_SEARCH_FLAG}}');
|
|
}
|
|
const skeleton = fs.readFileSync(path.join(ROOT, 'autoplan', 'SKILL.md'), 'utf-8');
|
|
expect(skeleton).not.toContain('{{CODEX_WEB_SEARCH_FLAG}}');
|
|
});
|
|
});
|