Files
gstack/plan-ceo-review/sections/review-sections.md.tmpl
T
01593aa67c v1.91.2.0 fix: consolidate gstack reliability wave (#2959)
* fix(memory-ingest): --scan-secrets scans the rendered page and fails closed

--scan-secrets ran gitleaks on the raw transcript .jsonl, then imported a
page rendered from it. gitleaks' assignment rules don't match across a
JSON-escaped quote (KEY=\"v\" on disk), so a secret the rendered page
shows as KEY="v" was imported unflagged. And the gate skipped a file only
on scanner "gitleaks" with findings, so a scan that errored (non-zero
exit, 16MB maxBuffer overflow on a file with many findings, unparseable
report) or could not run (gitleaks missing, slow-probe cooldown) imported
the file unscanned.

Scan the rendered page body, the exact bytes writeStaged() writes, via a
new secretScanText() helper, and skip the file whenever the scan did not
complete. Skipped files stay out of the state file, so the next run
retries them. Reword the helper warnings and setup-gbrain/memory.md,
which described the fail-open as intended.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(test): reconcile Bun failure markers and footer counts

* fix(sync-gbrain): verify source-scoped reads without mutation

* fix(test): recognize grounded TTHW target choices structurally

* fix(aside): make the readiness probe work under zsh and report why it failed

The probe built its deadline into `_T` and expanded it unquoted, so
`$_T aside repl …` only worked in a shell that word-splits. zsh does not: it
looked for a command literally named "gtimeout 30", the probe answered
ASIDE_NOT_RUNNING with Aside installed and ready, and every browsing skill
fell back to the bundled Chromium in silence. zsh is the macOS default and
Aside is macOS-only, so on a stock Mac the probe could never report READY.

The deadline becomes a function, `_gs_d`. It receives the command as "$@",
already split, so sh, bash and zsh all behave the same, and the gtimeout →
timeout → perl alarm chain is unchanged. A 4th arm runs the call unbounded
when none of the three is present, which is what the empty `_T` did before.
Not `eval`: it re-parses the string, so the parens and `;` of the perl arm
become syntax and that arm dies in bash *and* zsh — on a stock Mac, the arm
that actually runs.

On failure the probe now prints the CLI's reason after ASIDE_NOT_RUNNING:,
the shape gstack-render already uses: the first line that starts with a
capital letter, i.e. the CLI's own sentence or Node's `Error:` line below its
loader frame. "Not running" covers states with different fixes — no window
open for the profile, a NODE_OPTIONS preload that kills the CLI — and a bare
verdict sent all of them to "open the Aside app". The BROWSER SETUP prose
quotes that reason before asking the user to open the app.

The text pin asserted the broken invocation verbatim, so it now pins the
function and asserts neither `$_T aside repl` nor an eval form comes back. A
second test executes the rendered probe in sh, bash and zsh on each of the
four deadline arms with stubbed binaries on a narrowed PATH, plus two failing
CLIs: one that prints its own sentence, one that crashes like Node with the
useful line below the frame.

The deadline function costs zero bytes against the lines it replaces; the
reason costs 53 per copy of the probe (44 where the reworded BROWSER SETUP
line gives 9 back). That moves four guards by the measured amount:
plan-devex-review's skeleton cap to 68,550 (measured 68,544), plan-ceo-review's
skeleton cap to 80,150 (measured 80,111) and union ratio to 1.081 (measured
1.0803), and plan-eng-review's union ratio to 1.151 (measured 1.1504).

Fixes #2842, #2941.

* Clarify engineering review startup and decision flow

* Fix Windows readiness fixture PATH and command shim

* fix(test): recognize grounded TTHW target choices structurally

* Clarify engineering review startup and decision flow

* fix(test): restrict QA-only fixture tools to its no-Edit contract

* v1.90.0.0 fix(sync-gbrain): guard readiness verdicts and refresh metadata

* fix(browse): validate canonical upload targets

* fix(gbrain): classify structured PGLite busy response

* fix(browse): preserve native extension runtime APIs

* Fix displayless browser handoff ownership

* Accept unique installed autoplan methodology aliases

* fix(skills): preserve positional literals during installation

* fix(browse): checksum installer contents through stdin

* fix(test): normalize Windows checksum fixture paths

* test: emulate unavailable shasum in Windows checksum fixture

* fix(investigate): preserve owned freeze lifecycle

* fix(review): preserve N+1 retry and Red Team completion

* fix: bound Aside readiness and preserve safe fallback

* test: exercise setup and Chromium on native ARM

* fix: preserve install ownership and ARM browser selection

* Fix gbrain ingest scan boundaries and seed observation

* Refresh managed ship hooks and supervise expanded paid census

* Reject resumed gbrain pages excluded by current policy

* Recover zombie agent locks safely and enable CI Python venv

* Repair paid actor declarations and Aside pitch assertions

* Bump consolidated wave to next free minor release

* Clarify CEO review admin choices and option tradeoffs

* Preserve CEO mode handoff anchors in clarified workflow

* Make Windows portability fixtures use shell-native paths

* Restore ARM Bun alias and clarify ship review gates

* Refresh ship workflow golden snapshots

* Fix Windows DX documentation controls without piped stdin

* Decode Codex child pipes without Bun's encoded-stream stall

* Bound DX pre-review audit before product questions

* Clarify trusted review-start read in paid revalidation

* Bump consolidated wave to next free minor release

* Clarify CEO review admin choices and option tradeoffs

* Preserve CEO mode handoff anchors in clarified workflow

* Make Windows portability fixtures use shell-native paths

* Restore ARM Bun alias and clarify ship review gates

* Refresh ship workflow golden snapshots

* Fix Windows DX documentation controls without piped stdin

* Decode Codex child pipes without Bun's encoded-stream stall

* Bound DX pre-review audit before product questions

* Clarify trusted review-start read in paid revalidation

* Reconcile new main planning flow and paid judge census

* fix: reconcile rebased planning and source-bound validation

* test: pin cookie workflow judge to scored Sonnet model

* fix: keep terminal agent boot out of module imports

* fix: preserve pending-question uncertainty in engineering review

* fix: stabilize Windows reliability-wave fixtures

* fix: clarify design consultation research workflow

* fix: preserve independent design consultation inputs

* fix: resolve design taste scope and browser research guidance

* fix: make consultation opt-in preflight unambiguous

* test: await native Edge owner readiness or terminal result

---------

Co-authored-by: Bruce Krysiak <brucek@alum.mit.edu>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Antonio Vitalic <antoninte99@gmail.com>
2026-09-26 18:57:53 -04:00

599 lines
39 KiB
Cheetah
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
## Review Sections (11 sections, after scope and mode are agreed)
**Anti-skip rule:** Evaluate Sections 1–10 in full for every plan, including strategy,
spec, code and infra. Run Section 11 if accepted work adds or changes UI screens,
components, user interactions, frontend frameworks, user-visible states,
mobile/responsive behavior or the design system. Otherwise record `SKIPPED (no UI scope)`. In evaluated sections,
say "No issues found" only when there are zero findings.
**Use the review depth chosen in Step 0.** For scope prioritization, use each
section to decide inclusion and feasibility under accepted constraints. Diagrams
and maps must show candidate boundaries, failure mechanisms, feasibility conditions
and unresolved risks. Resolve material blockers now; revisit priorities when new
evidence changes them. Leave non-blocking implementation choices pending with an
owner and required verification. Use Step 0's depth-expansion decision before
designing endpoint, method or state-machine contracts beyond that depth. In strategy-only depth, use
capability-level rows and "implementation owner must prove ___" notes instead
of method-level registries. In implementation-ready depth, require the concrete
method/codepath, contract, rescue and test rows. Report what is approved, what
is verified and what remains unchosen; completing prioritization does not mean
the implementation is ready.
**Preserve accepted requirements.** Compare the proposed implementation with
stated invariants and acceptance criteria. Report gaps and propose remedies,
including omitted mechanisms in HOLD SCOPE. Never weaken a guarantee, accept its
violation or change a test to expect it. Low frequency, bounded impact and
documentation do not meet stricter requirements. Changing a requirement needs
explicit authority; until then, keep both the proposal and original gap unresolved.
Carry prior approvals into findings, tasks and the report. Routine auto-decide
cannot override user constraints or non-goals.
## CRITICAL RULE — How to ask questions
Follow the AskUserQuestion format from the Preamble above. Additional rules for plan reviews:
* **One decision unit = one AskUserQuestion call.** Use Step 0D boundaries, not topic labels.
* Describe the problem concretely, with file and line references.
* Present 2-3 options, including "do nothing" where reasonable.
* For each option: effort, risk, and maintenance burden in one line.
* Before calling AskUserQuestion, draft the recommended option as a complete remedy
for this one issue. Its offered description must state the rescue behavior,
verification, and failure visibility needed for that fix. Include those details
in the option itself. Omit irrelevant work, and keep independent findings and
new TODOs in their own questions.
* **Map the reasoning to my engineering preferences above.** One sentence connecting your recommendation to a specific preference.
* Use the preamble's `D<N>` question heading and A/B/C option labels. Cite the stable ledger ID separately so a reopened question keeps its earlier decision history.
* An "obvious fix" still needs approval when it is not covered by an exact accepted choice.
## Formatting Rules
* Keep option labels short; use Step 0D's exact `currentDecision` fields for the question and option descriptions.
* Use **CRITICAL GAP** / **WARNING** / **OK** for scannability.
## Mode Quick Reference
The mode changes which work is included, not review depth or section coverage.
Apply the review and outputs to the accepted work in every mode.
| Step | SCOPE EXPANSION | SELECTIVE EXPANSION | HOLD SCOPE | SCOPE REDUCTION |
|------|-----------------|---------------------|------------|-----------------|
| Scope proposals | Offer additions individually | Offer cherry-picks individually | No expansions | Offer cuts individually |
| 10x check | Required; additions need approval | Required; additions need approval | Skip | Skip |
| Platonic ideal | Required | Skip | Skip | Skip |
| Delight opportunities | At least 5, each opt-in | At least 5, each opt-in | Skip | Skip |
| Complexity | Review accepted ambition | Review baseline and accepted additions | Simplest correct accepted scope | Minimum valuable scope |
| Temporal interrogation (0I) | Run | Run | Run | Skip |
| Separate CEO archive (0H) | Write | Write | Skip | Skip |
| Future direction (Section 10) | Review accepted trajectory | Review accepted cherry-picks | Maintainability; no expansions | Maintainability of remaining scope |
| Design (Section 11) | Review if UI scope | Review if UI scope | Review if UI scope | Review if UI scope |
All modes produce the review content. Save it to the permitted working plan;
when no plan/report write is permitted, present it in chat as not persisted and
end with completion blocked. The CEO archive is additional expansion-mode output.
### Working review decisions
At each section's **Decision gate**, follow Analyze → Resolve → Apply below.
Continue the six-column ledger with each row's owner section. Review only;
do not change code.
**Analyze.** Check input, source and actual approvals. Correct false claims and
dependent test/runbook text without changing approved behavior. Preserve contracts
and mitigations even if later text omits them. Flag approval conflicts. Unavailable
code proves neither failure nor safety; record unknown risks with their owners
and required verification.
**Resolve.** If this section needs a new decision or evidence warrants reopening
one, complete 0D through its post-answer save, then continue to Apply below.
Use the same row ID in the ledger, `currentDecision` and question; complete 0D's
pre-question checkpoint before each new or reopened question.
If all choices are settled, cite their exact answers and go straight to Apply.
Resolve critical risks now. Reference other pending rows in their owner sections;
do not decide them here. Keep independent safety fixes and throughput improvements
in separate rows, following 0D's test table.
**Apply.** Check the saved plan against each answer's exact scope. Preserve existing
content, approved behavior, required implementation, tests and success/failure
contracts. Leave unapproved remedies and extra verification pending; do not put
them into tasks or prescribe them in diagrams. If the plan already matches, do
not save again. Correct discrepancies under the storage policy; if a correction
needs approval, resolve it through 0D before repeating this check.
Record findings and dispositions, then review the next section. Do not write its
conclusions or tasks before reviewing it. After Sections 1–10 and Section 11's
review or no-UI skip, follow Closing sequence. Keep unresolved choices in the
ledger and report; an approval is not proof of implementation or verification.
### Section 1: Architecture Review
Publish **Current scope** in chat using the Step 0E mode-handoff format and the current ledger dispositions, including actual later scope-answer references. Retain mode, rationale and preference attribution. This updates scope after 0G; do not ask or log the mode again. Keep earlier answers as history, showing current accepted scope. Then say `Section 1: Architecture Review`.
Evaluate and diagram:
* System design and component boundaries. Draw the dependency graph.
* Data flow — all four paths. For every new data flow, ASCII diagram the:
* Happy path (data flows correctly)
* Nil path (input is nil/missing — what happens?)
* Empty path (input is present but empty/zero-length — what happens?)
* Error path (upstream call fails — what happens?)
* State machines. ASCII diagram for every new stateful object. Include impossible/invalid transitions and what prevents them.
* Coupling concerns. What new coupling exists, and is it justified? Draw before/after dependencies.
* Scaling characteristics. What breaks first under 10x and 100x load?
* Single points of failure. Map them.
* Security architecture. Auth boundaries, data access patterns, API surfaces. For each new endpoint or data mutation: who can call it, what do they get, what can they change?
* Production failure scenarios. For each integration point, describe one realistic failure and whether the plan handles it.
* Rollback posture. If this ships broken, name the rollback path and time.
**EXPANSION and SELECTIVE EXPANSION additions:**
* What would make this architecture elegant and obvious to a new engineer?
* What infrastructure makes this a platform for later features?
**SELECTIVE EXPANSION:** If any accepted cherry-picks from Step 0G affect the architecture, evaluate their architectural fit here. Flag any that create coupling concerns or don't integrate cleanly — this is a chance to revisit the decision with new information.
Required ASCII diagram: full system architecture showing new components and their relationships to existing ones.
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 2: Error & Rescue Map
This is the section that catches silent failures. It is not optional.
For strategy-only depth, map each retained capability, integration or data
boundary that can fail. For implementation-ready depth, map every new method,
service or codepath that can fail. Use the same table shape for both:
```
METHOD/CODEPATH | WHAT CAN GO WRONG | EXCEPTION CLASS
-------------------------|-----------------------------|-----------------
ExampleService#call | API timeout | TimeoutError
| API returns 429 | RateLimitError
| malformed JSON | JSONParseError
-------------------------|-----------------------------|-----------------
EXCEPTION CLASS | RESCUED? | RESCUE ACTION | USER SEES
-----------------------------|-----------|------------------------|------------------
TimeoutError | Y | Retry 2x, then raise | Temporary outage
RateLimitError | Y | Backoff + retry | Transparent
JSONParseError | N ← GAP | — | 500 error ← BAD
```
Rules for this section:
* Catch-all error handling (`rescue StandardError`, `catch (Exception e)`, `except Exception`) is ALWAYS a smell. Name the specific exceptions.
* Generic-only logging is insufficient. Log what was attempted, with what args and for what user/request.
* Every rescued error must retry with backoff, degrade gracefully with a user-visible message, or re-raise with added context. "Swallow and continue" is almost never acceptable.
* For each GAP (unrescued error that should be rescued): specify the rescue action and what the user should see.
* For LLM/AI calls: handle malformed, empty, hallucinated-invalid JSON and refusals as distinct failure modes.
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 3: Security & Threat Model
Security is not a sub-bullet of architecture. It gets its own section.
Evaluate:
* Attack surface expansion. What new attack vectors does this plan introduce? New endpoints, new params, new file paths, new background jobs?
* Input validation. For every new user input: is it validated, sanitized, and rejected loudly on failure? What happens with: nil, empty string, string when integer expected, string exceeding max length, unicode edge cases, HTML/script injection attempts?
* Authorization. For every new data access: is it scoped to the right user/role? Is there a direct object reference vulnerability? Can user A access user B's data by manipulating IDs?
* Secrets and credentials. New secrets? In env vars, not hardcoded? Rotatable?
* Dependency risk. New gems/npm packages? Security track record?
* Data classification. PII, payment data, credentials? Handling consistent with existing patterns?
* Injection vectors. SQL, command, template, LLM prompt injection — check all.
* Audit logging. For sensitive operations: is there an audit trail?
For each finding: threat, likelihood (High/Med/Low), impact (High/Med/Low), and whether the plan mitigates it.
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 4: Data Flow & Interaction Edge Cases
Trace data and user interactions adversarially.
**Data Flow Tracing:** For every new data flow, produce an ASCII diagram showing:
`INPUT -> VALIDATION -> TRANSFORM -> PERSIST -> OUTPUT`, with shadow paths for
nil/empty/wrong type, invalid/too long, exception/timeout/OOM, conflict/dup/lock,
stale/partial/encoding.
For each node: what happens on each shadow path? Is it tested?
**Async ordering:** For flows sharing mutable state:
1. **Define the boundary.** State the invariant and its exact caller/time boundary. Draw a combined ASCII schedule with one column per operation and one for shared state.
2. **Exercise both orders.** For each pair of overlapping awaits that can affect that invariant, show both completion orders. At each relevant `await`, callback or job handoff: pause, let a competing operation complete, resume, then start a fresh consumer. Exclude an order only by naming the mechanism that prevents it.
3. **Compare the result.** Show the observed result against the invariant. The invariant is a requirement, not proof that the implementation meets it. If safe, name the mechanism that prevents the violating schedule. Separate diagrams, one favorable schedule, single-thread execution and atomic calls do not prove ordering across awaits. An accepted exception needs its exact contract clause; bounded damage is insufficient.
4. **Specify regression proof.** Test the relevant completion orders with controlled pause/release points. Compare relevant pairs; exhaustive permutations are unnecessary.
**Interaction Edge Cases:** For every new user-visible interaction, evaluate:
`INTERACTION | EDGE CASE | HANDLED? | HOW?`. Include Double-click/stale submit,
navigate away/timeout/retry, zero/large/changing list, and failed/duplicate/backlogged jobs.
Flag any unhandled edge case as a gap. For each gap, specify the fix.
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 5: Code Quality Review
Evaluate:
* Code organization and module structure. Does new code fit existing patterns?
* DRY violations. Be aggressive. If the same logic exists elsewhere, flag it and reference the file and line.
* Naming quality. Are new classes, methods, and variables named for what they do, not how they do it?
* Error handling patterns. (Cross-reference with Section 2 — this section reviews the patterns; Section 2 maps the specifics.)
* Missing edge cases: nil, empty, 429/timeouts and boundary values.
* Over-engineering: abstractions for problems that do not exist yet.
* Under-engineering: happy-path fragility or missing defensive checks.
* Cyclomatic complexity. Flag any new method that branches more than 5 times. Propose a refactor.
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 6: Test Review
Carry requested or approved coverage forward, including directly determined tests, without re-asking. For an unresolved test-method choice or additional verification scope/depth, name the distinct regression existing tests miss and resolve that choice through 0D before prescribing it. An approved runtime contract alone does not choose extra verification scope.
Make a complete diagram of every new thing this plan introduces:
new UX flows, data flows, codepaths, background jobs/async work,
integrations/external calls, and error/rescue paths (cross-reference Section 2).
For each item in the diagram:
* What type of test covers it? (Unit / Integration / System / E2E)
* Does a test for it exist in the plan? If not, draft its header within requested or approved coverage; keep new verification proposals pending until their decision.
* What is the happy path test?
* What is the failure path test? (Be specific — which failure?)
* What is the edge case test? (nil, empty, boundary values, concurrent access)
For each behavior, complete this assertion check:
1. **Map the requirement.** Name its observable assertion and a wrong result it rejects. Map it to the user's exact requirement or individually approved remedy. A stated outcome plus its retained caller contract can determine the assertion, even without assertion syntax. Translate semantic counts, conditions and quantifiers exactly; never weaken an exact count to a lower bound.
2. **Reuse settled proof.** Selecting an existing probe or spelling out a determined check is implementation work, not another approval. Reuse these requirements without asking again. Verify the caller's path; helper coverage alone does not prove it. Honor previously accepted risks and equivalent caller coverage.
3. **Resolve actual gaps.** Explain what the existing requirement or approved remedy fails to cover before calling a check missing. Ask individually only for an unresolved behavioral choice, new outcome, or independent uncovered failure mode. Vague success labels do not settle values; scope/approach approval does not resolve an individual assertion gap. Never silently add, defer or waive a missing behavioral assertion. Keep required behaviors mandatory unless the user explicitly approves changing them.
Test ambition check (all modes): For each new feature, answer:
* What's the test that would make you confident shipping at 2am on a Friday?
* What's the test a hostile QA engineer would write to break this?
* What's the chaos test?
Test pyramid check: Many unit, fewer integration, few E2E? Or inverted?
Flakiness risk: Flag any test depending on time, randomness, external services, or ordering.
Load/stress test requirements: For any new codepath called frequently or processing significant data.
For LLM/prompt changes: Check CLAUDE.md for the "Prompt/LLM changes" file patterns. If this plan touches ANY of those patterns, state which eval suites must be run, which cases should be added, and what baselines to compare against.
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 7: Performance Review
Evaluate:
* N+1 queries. For ORM-backed data access, especially association traversal: does the plan preload/batch instead of querying in a loop?
* Memory usage. For every new data structure: what's the maximum size in production?
* Database indexes. For every new query: is there an index?
* Caching opportunities. For every expensive computation or external call: should it be cached?
* Background job sizing. For every new job: worst-case payload, runtime, retry behavior?
* Slow paths. Top 3 slowest new codepaths and estimated p99 latency.
* Connection pool pressure. New DB connections, Redis connections, HTTP connections?
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 8: Observability & Debuggability Review
New systems break. This section ensures you can see why.
Evaluate:
* Logging. For every new codepath: structured log lines at entry, exit, and each significant branch?
* Metrics. For every new feature: what metric tells you it's working? What tells you it's broken?
* Tracing. For new cross-service or cross-job flows: trace IDs propagated?
* Alerting. What new alerts should exist?
* Dashboards. What new dashboard panels do you want on day 1?
* Debuggability. If a bug is reported 3 weeks post-ship, can you reconstruct what happened from logs alone?
* Admin tooling. New operational tasks that need admin UI or rake tasks?
* Runbooks. For each new failure mode: what's the operational response?
**EXPANSION and SELECTIVE EXPANSION addition:**
* What observability would make this feature a joy to operate? (For SELECTIVE EXPANSION, include observability for any accepted cherry-picks.)
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 9: Deployment & Rollout Review
Evaluate:
* Migration safety. For every new DB migration: backward-compatible? Zero-downtime? Table locks?
* Feature flags. Should any part be behind a feature flag?
* Rollout order. Correct sequence: migrate first, deploy second?
* Rollback plan. Explicit step-by-step.
* Deploy-time risk window. Old code and new code running simultaneously — what breaks?
* Environment parity. Tested in staging?
* Post-deploy verification checklist. First 5 minutes? First hour?
* Smoke tests. What automated checks should run immediately post-deploy?
**EXPANSION and SELECTIVE EXPANSION addition:**
* What deploy infrastructure would make shipping this feature routine? (For SELECTIVE EXPANSION, assess whether accepted cherry-picks change the deployment risk profile.)
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 10: Long-Term Trajectory Review
Evaluate:
* Technical debt introduced. Code debt, operational debt, testing debt, documentation debt.
* Path dependency. Does this make future changes harder?
* Knowledge concentration. Documentation sufficient for a new engineer?
* Reversibility. Rate 1-5: 1 = one-way door, 5 = easily reversible.
* Ecosystem fit. Aligns with this repo's framework conventions?
* The 1-year question. Is this obvious to a new engineer in 12 months?
**EXPANSION and SELECTIVE EXPANSION additions:**
* What comes after this ships? Phase 2? Phase 3? Does the architecture support that trajectory?
* Platform potential. Does this create capabilities other features can leverage?
* (SELECTIVE EXPANSION only) Retrospective: Were the right cherry-picks accepted? Did any rejected expansions turn out to be load-bearing for the accepted ones?
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
### Section 11: Design & UX Review (skip if no UI scope detected)
The CEO calling in the designer. Not a pixel-level audit — that's /plan-design-review and /design-review. This is ensuring the plan has design intentionality.
Evaluate:
* Information architecture — what does the user see first, second, third?
* Interaction state coverage map:
FEATURE | LOADING | EMPTY | ERROR | SUCCESS | PARTIAL
* User journey coherence — storyboard the emotional arc
* AI slop risk — does the plan describe generic UI patterns?
* DESIGN.md alignment — does the plan match the stated design system?
* Responsive intention — is mobile mentioned or afterthought?
* Accessibility basics — keyboard nav, screen readers, contrast, touch targets
**EXPANSION and SELECTIVE EXPANSION additions:**
* What would make this UI feel *inevitable*?
* What 30-minute UI touches would make users think "oh nice, they thought of that"?
Required ASCII diagram: user flow showing screens/states and transitions.
If this plan has significant UI scope, recommend: "Consider running /plan-design-review for a deep design review of this plan before implementation."
**Post-Implementation Design Audit (if UI scope detected):** After implementation, run `/design-review` on the live site to catch visual issues that can only be evaluated with rendered output.
**Decision gate.** Complete Analyze → Resolve → Apply above for this section before continuing.
## Closing sequence
Continue through the blocks below in file order:
1. **Outside Voice:** run the configured review and resolve its findings through 0D. Record disabled or unavailable coverage and continue when no reviewer runs.
2. **Resolve remaining TODO choices:** use the selected mode's scope rules.
3. **Approval readiness:** check the ledger and record PASS before writing outputs. Its complete checklist is immediately after the TODO choices; no report or log is needed yet.
4. **Required Outputs:** follow the three stages below: prepare the plan body and summary, save and verify the terminal report, then publish the summary in chat.
5. **Cleanup and history:** perform permitted cleanup, attempt Review Log under the Artifact outcomes policy, then display the dashboard with the actual logging outcome.
6. **Navigation:** choose Next Steps and any docs/designs promotion; queue the next skill. For a substantive answer, call 0D for only that change, repeat Approval readiness and Required Outputs, then repeat step 5. Resume navigation without asking settled choices again. Navigation alone does not reopen decisions.
7. **Learnings:** finish learning and brain write-back. Return to this skill's main `SKILL.md`, at **Section self-check**. Its EXIT gate verifies completed work and saved readiness without asking again. After a passing gate, refresh the cache, run telemetry last, then exit or return to the caller.
### Outside Voice Integration Rule
Apply Analyze above to each outside finding before adding it to the same ledger.
Correct unsupported draft claims and preserve unknown risks. Reviewer agreement
is not new evidence or approval. Reopen a choice only for a supported material
risk, citing its prior answer and the new evidence; resolve it through 0D before
amending the plan.
{{CODEX_PLAN_REVIEW}}
## Resolve remaining TODO choices
### TODOS.md updates
**Keep the selected mode.** In HOLD SCOPE, a potential TODO must address an
evidenced gap in the accepted scope or its required correctness and operability.
Hypothetical future capacity, optional features, and alternatives to an adequate
approved remedy are expansions even when labeled TODOs; do not surface them in
HOLD SCOPE. Still audit observability and performance against the requirements,
and approve each real deferred gap individually. Expansion modes retain their
expansion scan and opt-in ceremony.
Only unanswered TODO proposals reach this menu. Do not ask again about an item
already deferred, skipped or kept; carry its actual answer and destination forward.
Resolve each remaining proposal through all four steps of 0D, using the menu
below. Keep its full comparison, saved question/options, Read-back and actual
answer. Never batch TODOs — one per question. If none remain, record that and continue.
Follow the format in `~/.claude/skills/gstack/review/TODOS-format.md`.
For each TODO, describe:
* **What:** One-line description of the work.
* **Why:** The concrete problem it solves or value it unlocks.
* **Pros:** What you gain by doing this work.
* **Cons:** Cost, complexity, or risks of doing it.
* **Context:** Enough detail that someone picking this up in 3 months understands the motivation, the current state, and where to start.
* **Effort estimate:** Give separate human-team and CC+gstack S/M/L/XL labels.
For a rough backlog estimate, start with S→S, M→S, L→M, XL→L. These are size
categories, not time ratios. When work is decomposed into Implementation Tasks,
estimate hours/minutes using that section's task-type ratios and actual work;
use those estimates to refine the backlog labels.
* **Priority:** P1/P2/P3
* **Depends on / blocked by:** Any prerequisites or ordering constraints.
Then present options: **A)** Add to TODOS.md **B)** Skip — not valuable enough **C)** Keep in the current plan as required work, only when it is already part of accepted scope.
{{PLAN_REVIEW_APPROVAL_CHECK}}
## Required Outputs
Complete these three stages in order. They separate preparing review content from
announcing saved completion; no stage depends on a completion log written later.
### Stage 1 — Prepare the plan body and summary
Write the following sections, registries, diagrams, Markdown tasks and Completion
Summary in the working plan from approved changes. Keep them before the terminal
report. Task JSONL and approved TODOs use their specified paths, separate from the
0H CEO archive. The prepared summary supplies the report's current facts; it is
not yet a chat announcement of saved completion.
### Review facts
Derive facts from the approved ledger and completed sections: mode, findings,
unresolved choices, critical gaps, scope dispositions and each outside attempt's
coverage. Status is `clean` only with zero unresolved choices and critical gaps;
otherwise `issues_open`. No report or completion log is needed yet.
Use these facts in the Summary, report row and Review Log. Artifact cells stay
pending until confirmed writes, or not persisted when forbidden. A substantive
late decision repeats readiness and recomputes facts before refreshing outputs.
### "NOT in scope" section
List explicitly deferred and rejected work separately, with each actual answer
and one-line rationale. Deferred work also goes to TODOS.md; rejected work does not.
### "What already exists" section
List existing code/flows that partially solve sub-problems and whether the plan reuses them.
### "Dream state delta" section
Where this plan leaves us relative to the 12-month ideal.
### Error & Rescue Registry (from Section 2)
Match the approved review depth. For implementation-ready work, list every method
that can fail, its exception classes, rescue status/action and user impact.
For strategy-only work, use capability rows with failure mechanisms, user impact,
known safeguards, and an owner who must verify each unknown before implementation.
Do not invent method contracts. For one narrow decision, include only its dependencies.
### Failure Modes Registry
```
CODEPATH | FAILURE MODE | RESCUED? | TEST? | USER SEES? | LOGGED?
---------|----------------|----------|-------|----------------|--------
```
Any row with RESCUED=N, TEST=N, USER SEES=Silent → **CRITICAL GAP**.
For strategy-only rows, CODEPATH names the capability; mark unknown rescue/test
coverage as unknown and name the verification owner. Count capability rows in the
Completion Summary; implementation-ready reviews count method/codepath rows.
### Scope Expansion Decisions (EXPANSION and SELECTIVE EXPANSION only)
For EXPANSION and SELECTIVE EXPANSION, reference the CEO plan's full 0G scope record
under the storage policy. List its dispositions without asking again:
* Accepted: {list items added to scope}
* Deferred: {list items sent to TODOS.md}
* Skipped: {list items rejected}
### Diagrams (mandatory, produce all that apply)
1. System architecture
2. Data flow (including shadow paths)
3. State machine
4. Error flow
5. Deployment sequence
6. Rollback flowchart
### Stale Diagram Audit
List every ASCII diagram in files this plan touches. Still accurate?
{{TASKS_SECTION_EMIT:ceo-review}}
### Completion Summary
Fill this template from Review facts now, as part of the plan body. Artifact
outcomes remain pending until their writes are confirmed. Stage 3 publishes it
after report verification; forbidden writes stay labeled not persisted.
Use the full mode name from Step 0E; replace spaces with underscores only in the
review log's `MODE` field. "System Audit" summarizes repository findings from
Step 0 and the review sections. "Lake Score" counts complete options selected:
Y is the number of answered coverage questions offering a 10/10 option; X is
how many selected that option. Count a reopened choice only once, using its
latest answered option; superseded answers add nothing. Exclude kind-only and
unanswered questions; use `N/A` when Y is zero.
```
+====================================================================+
| MEGA PLAN REVIEW — COMPLETION SUMMARY |
+====================================================================+
| Mode selected | [full mode name from Step 0E] |
| System Audit | [key findings] |
| Step 0 | [mode + key decisions] |
| Section 1 (Arch) | ___ issues found |
| Section 2 (Errors) | ___ error paths mapped, ___ GAPS |
| Section 3 (Security)| ___ issues found, ___ High severity |
| Section 4 (Data/UX) | ___ edge cases mapped, ___ unhandled |
| Section 5 (Quality) | ___ issues found |
| Section 6 (Tests) | Diagram produced, ___ gaps |
| Section 7 (Perf) | ___ issues found |
| Section 8 (Observ) | ___ gaps found |
| Section 9 (Deploy) | ___ risks flagged |
| Section 10 (Future) | Reversibility: _/5, debt items: ___ |
| Section 11 (Design) | ___ issues / SKIPPED (no UI scope) |
+--------------------------------------------------------------------+
| NOT in scope | written (___ items) |
| What already exists | written |
| Dream state delta | written |
| Error/rescue registry| ___ rows, ___ CRITICAL GAPS |
| Failure modes | ___ total, ___ CRITICAL GAPS |
| TODOS.md updates | ___ items proposed |
| Scope proposals | ___ proposed, ___ accepted (EXP + SEL) |
| CEO plan | written / not persisted / skipped by mode |
| Outside voice | provider + completed/unavailable/disabled/skipped |
| Lake Score | X/Y recommendations chose complete option |
| Diagrams produced | ___ (list types) |
| Stale diagrams found | ___ |
| Unresolved decisions | ___ (listed below) |
+====================================================================+
```
### Unresolved Decisions
If any AskUserQuestion goes unanswered, note it here. Never silently default.
### Stage 2 — Save and verify the terminal report
Use the prepared summary above, then follow this report procedure. Preserve the
complete body and summary before the report; no new body section follows it.
{{PLAN_FILE_REVIEW_REPORT}}
### Stage 3 — Publish the Completion Summary
**Publish the Completion Summary:** After the report Read-back gate passes, show
the prepared summary in chat with confirmed artifact outcomes. Do not append it
after the report in the file. If no plan/report write is permitted, show the
complete plan, report and summary as not persisted, then use **Gate outcome:
Blocked**. This delivers the review content without claiming saved completion;
skip Review Log, success telemetry and the next-skill handoff.
## Handoff Note Cleanup
After producing the Completion Summary, remove this branch's handoff notes only if the storage policy permits cleanup. Otherwise retain them and report that cleanup was not performed.
```bash
setopt +o nomatch 2>/dev/null || true # zsh compat
# gstack-slug prints both SLUG and BRANCH; eval sets them in this shell.
{{SLUG_EVAL}}
rm -f ~/.gstack/projects/$SLUG/*-$BRANCH-ceo-handoff-*.md 2>/dev/null || true
```
## Review Log
Attempt these history writes only after the plan/report's successful write and
Read-back. A failed plan/report save or verification stops before this block.
If metadata writes are forbidden, skip these commands and show their actual
fields in chat as **not persisted**.
Both history commands below are best-effort under Step 0's **Artifact outcomes**
policy. If one fails, retain its diagnostic, show its actual unsaved fields and
continue; do not claim that entry was recorded. Display the dashboard from saved
history, clearly identifying this run as unlogged when its review-log write failed
or was forbidden. This differs from 0H's required spec-metrics write.
This payload omits the dashboard's optional `plan_sha256`: use age for freshness
without claiming a content match when no hash was recorded.
Substitute these values from the Completion Summary before running the commands:
- **TIMESTAMP**: current UTC ISO 8601 datetime (e.g., 2026-03-16T14:30:00Z)
- **STATUS**: "clean" if 0 unresolved decisions AND 0 critical gaps; otherwise "issues_open"
- **unresolved**: number from "Unresolved decisions" in the summary
- **critical_gaps**: number from "Failure modes: ___ CRITICAL GAPS" in the summary
- **MODE**: the mode the user selected (SCOPE_EXPANSION / SELECTIVE_EXPANSION / HOLD_SCOPE / SCOPE_REDUCTION)
- **scope_proposed**: number from "Scope proposals: ___ proposed" in the summary (0 for HOLD/REDUCTION)
- **scope_accepted**: number from "Scope proposals: ___ accepted" in the summary (0 for HOLD/REDUCTION)
- **scope_deferred**: number of items deferred to TODOS.md from scope decisions (0 for HOLD/REDUCTION)
- **COMMIT**: output of `git rev-parse --short HEAD`
The second command records the accepted scope so later sessions can reuse it.
Substitute `SCOPE_SUMMARY` (e.g. "accepted 4 of 6 proposals", "held scope" or
"cut 3 items") and `VERDICT` (the summary's one-line verdict).
```bash
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"plan-ceo-review","timestamp":"TIMESTAMP","status":"STATUS","unresolved":N,"critical_gaps":N,"mode":"MODE","scope_proposed":N,"scope_accepted":N,"scope_deferred":N,"commit":"COMMIT"}' || { _CEO_LOG_EXIT=$?; echo "Review history not persisted (exit $_CEO_LOG_EXIT)." >&2; }
~/.claude/skills/gstack/bin/gstack-decision-log '{"decision":"CEO review (MODE): SCOPE_SUMMARY","rationale":"VERDICT","scope":"branch","source":"skill","confidence":8}' || { _CEO_DECISION_EXIT=$?; echo "Decision history not persisted (exit $_CEO_DECISION_EXIT)." >&2; }
```
{{REVIEW_DASHBOARD}}
## Next Steps — Review Chaining
After displaying the Review Readiness Dashboard, recommend the next review(s) based on what this CEO review discovered. Read the dashboard output to see which reviews have already been run and whether they are stale.
**Recommend /plan-eng-review if eng review is not skipped globally** — check the dashboard output for `skip_eng_review`. If it is `true`, eng review is opted out — do not recommend it. Otherwise, eng review is the required shipping gate. If this CEO review expanded scope, changed architectural direction, or accepted scope expansions, emphasize that a fresh eng review is needed. If an eng review already exists in the dashboard but the commit hash shows it predates this CEO review, note that it may be stale and should be re-run.
**Recommend /plan-design-review if UI scope was detected** — specifically if Section 11 (Design & UX Review) was NOT skipped, or if accepted scope expansions included UI-facing features. If an existing design review is stale (commit hash drift), note that. In SCOPE REDUCTION mode, skip this recommendation — design review is unlikely relevant for scope cuts.
**If both are needed, recommend eng review first** (required gate), then design review.
Use AskUserQuestion to present the next step. Include only applicable options:
- **A)** Run /plan-eng-review next (required gate)
- **B)** Run /plan-design-review next (only if UI scope detected)
- **C)** Skip — I'll handle reviews manually
## docs/designs Promotion (EXPANSION and SELECTIVE EXPANSION only)
At the end of the review, if the vision produced a compelling feature direction, offer to promote the CEO plan to the project repo. AskUserQuestion:
"The vision from this review produced {N} accepted scope expansions. Want to promote it to a design doc in the repo?"
- **A)** Promote to `docs/designs/{FEATURE}.md` (committed to repo, visible to the team)
- **B)** Keep in `~/.gstack/projects/` only (local, personal reference)
- **C)** Skip
If promoted and those writes are permitted, copy the CEO plan content to `docs/designs/{FEATURE}.md` (create the directory if needed) and update the original CEO plan's `status` from `ACTIVE` to `PROMOTED`. Otherwise present the proposed design document in chat, marked not persisted; do not claim promotion occurred.
## Learnings and brain write-back
Finish these review tasks without changing the plan. Then return to
this skill's main `SKILL.md` at **Section self-check** for terminal verification.
Success telemetry and exit happen there.
{{LEARNINGS_LOG}}
{{GBRAIN_SAVE_RESULTS}}
{{BRAIN_WRITE_BACK}}
Return to this skill's main `SKILL.md`: Section self-check → EXIT PLAN MODE GATE.