mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-07 05:56:41 +02:00
Garry Tan
38f31e3b1d
Replaces SDK-based assertions with runPlanSkillObservation contract. Each test launches real claude --permission-mode plan, invokes the skill, and asserts the outcome reaches 'asked' or 'plan_ready' within a 300s budget (no silent Write/Edit, no crash, no timeout). Affected: - test/skill-e2e-plan-ceo-plan-mode.test.ts - test/skill-e2e-plan-eng-plan-mode.test.ts - test/skill-e2e-plan-design-plan-mode.test.ts - test/skill-e2e-plan-devex-plan-mode.test.ts - test/skill-e2e-plan-mode-no-op.test.ts (inPlanMode: false; tests the preamble plan-mode-info no-op path) test/e2e-harness-audit.test.ts — recognize runPlanSkillObservation as a valid coverage path alongside the legacy canUseTool / runPlanModeSkillTest. test/helpers/touchfiles.ts — point the 5 plan-mode test selections and the e2e-harness-audit selection at test/helpers/claude-pty-runner.ts instead of the deleted plan-mode-helpers.ts. Proof: bun test EVALS=1 EVALS_TIER=gate on these 5 files runs sequentially in 790s and passes 5/5. Same tests were 0/5 on origin/main, on v1.0.0.0, and on this branch with the SDK harness. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
49 lines
2.1 KiB
TypeScript
49 lines
2.1 KiB
TypeScript
/**
|
|
* Plan-mode-info no-op regression (gate tier, paid, real-PTY).
|
|
*
|
|
* Asserts: when /plan-ceo-review is invoked OUTSIDE plan mode (no
|
|
* --permission-mode plan flag, no plan-mode reminder injected), the skill
|
|
* still reaches a terminal outcome ('asked' or 'plan_ready'). This is the
|
|
* negative coverage to the per-skill plan-mode smokes — if the
|
|
* plan-mode-info preamble section ever starts misfiring for non-plan-mode
|
|
* sessions (e.g., gating questions on a phrase that isn't there), this
|
|
* test catches it.
|
|
*
|
|
* Why this matters: outside plan mode, claude doesn't render a native
|
|
* confirmation UI. The skill must drive its own AskUserQuestion. Same
|
|
* runner, same outcome contract — just `inPlanMode: false`.
|
|
*/
|
|
|
|
import { describe, test, expect } from 'bun:test';
|
|
import { runPlanSkillObservation } from './helpers/claude-pty-runner';
|
|
|
|
const shouldRun = !!process.env.EVALS && process.env.EVALS_TIER === 'gate';
|
|
const describeE2E = shouldRun ? describe : describe.skip;
|
|
|
|
describeE2E('plan-mode-info no-op outside plan mode (gate regression)', () => {
|
|
test('skill reaches a terminal outcome outside plan mode', async () => {
|
|
const obs = await runPlanSkillObservation({
|
|
skillName: 'plan-ceo-review',
|
|
inPlanMode: false,
|
|
timeoutMs: 300_000,
|
|
});
|
|
|
|
if (obs.outcome === 'silent_write' || obs.outcome === 'exited' || obs.outcome === 'timeout') {
|
|
throw new Error(
|
|
`plan-mode no-op regression FAILED: outcome=${obs.outcome}\n` +
|
|
`summary: ${obs.summary}\n` +
|
|
`elapsed: ${obs.elapsedMs}ms\n` +
|
|
`--- evidence (last 2KB visible) ---\n${obs.evidence}`,
|
|
);
|
|
}
|
|
expect(['asked', 'plan_ready']).toContain(obs.outcome);
|
|
|
|
// Negative regression: the rendered output must NOT echo the plan-mode
|
|
// distinctive reminder phrase. If it does, the plan-mode preamble
|
|
// section is leaking outside plan mode.
|
|
const PLAN_MODE_REMINDER =
|
|
'Plan mode is active. The user indicated that they do not want you to execute yet';
|
|
expect(obs.evidence).not.toContain(PLAN_MODE_REMINDER);
|
|
}, 360_000);
|
|
});
|