mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-02 03:35:09 +02:00
aeea57f96a
* refactor: remove vestigial plan-mode handshake resolver Delete scripts/resolvers/preamble/generate-plan-mode-handshake.ts and its four question-registry entries. Split the authoritative "Plan Mode Safe Operations" and "Skill Invocation During Plan Mode" sections out of generate-completion-status.ts into a sibling generatePlanModeInfo() export in the same module, wired at preamble position 1 where the handshake used to live. Same text, new position. The vestigial handshake told interactive review skills to emit an A=exit-and-rerun / C=cancel AskUserQuestion before running their interactive STOP-Ask workflow. That contradicted the authoritative rule at the tail of completion-status.ts saying AskUserQuestion satisfies plan mode's end-of-turn requirement. Skills now run directly when invoked in plan mode, with each finding gated by AskUserQuestion just like outside plan mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test: rename plan-mode-handshake-helpers to plan-mode-helpers, strengthen smokes Rename test/helpers/plan-mode-handshake-helpers.ts to test/helpers/plan-mode-helpers.ts. Keep the write-guard helper that asserts no Write/Edit tool call before the first AskUserQuestion (this is what catches silent-bypass regressions the textual smoke can't see). Rename the API: runPlanModeHandshakeTest to runPlanModeSkillTest, assertHandshakeShape to assertNotHandshakeShape. Extend the capture struct with exitPlanModeBeforeAsk. Rewrite the four per-skill E2E tests (plan-ceo, plan-eng, plan-design, plan-devex) as smoke tests that assert the skill's Step 0 question fires first, not an A/C handshake. Each test picks a cheap first answer (HOLD, TRIAGE, numeric score) so the run terminates quickly. Keep test/skill-e2e-plan-mode-no-op.test.ts as the outside-plan-mode non-interference regression, per codex outside-voice review: deleting it would lose coverage for "the hoisted section stays quiet when plan mode is absent." Replace the gen-skill-docs.test.ts handshake describe block (lines 2778+) with a plan-mode-info describe block that: - scans every generated SKILL.md under the repo root + every host subdir (.agents, .openclaw, .opencode, .factory, .hermes, .kiro, .cursor, .slate) and asserts "## Plan Mode Handshake" is absent - asserts "## Skill Invocation During Plan Mode" lands in the first 15KB of each of the four review skills' generated SKILL.md Both assertions run on every bun test. A PR that re-introduces the handshake resolver fails CI immediately. Update test/e2e-harness-audit.test.ts to reference the renamed runPlanModeSkillTest. Update test/helpers/touchfiles.ts entries to point at the new resolver owner (generate-completion-status.ts) and the renamed helper, and align per-skill touchfile keys. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: regenerate SKILL.md across all hosts + refresh golden fixtures Run bun run gen:skill-docs for every host to flush the vestigial "## Plan Mode Handshake" section from every generated SKILL.md and emit the hoisted "## Skill Invocation During Plan Mode" section at preamble position 1 instead. Refresh the three golden-fixture snapshots (claude, codex, factory) to match the new position. No behavior change beyond the resolver swap in the prior commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: bump version and changelog (v1.12.1.0) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
121 lines
5.7 KiB
TypeScript
121 lines
5.7 KiB
TypeScript
/**
|
|
* Preamble composition root.
|
|
*
|
|
* Each generator lives in its own file under ./preamble/*.ts. This file only
|
|
* wires them together via generatePreamble(). Keep composition declarative —
|
|
* no inline logic beyond tier gating.
|
|
*
|
|
* Each skill runs independently via `claude -p` (or the host's equivalent).
|
|
* There is no shared loader. The preamble provides: update checks, session
|
|
* tracking, user preferences, repo mode detection, model overlays, and
|
|
* telemetry.
|
|
*
|
|
* Telemetry data flow:
|
|
* 1. Always: local JSONL append to ~/.gstack/analytics/ (inline, inspectable)
|
|
* 2. If _TEL != "off" AND binary exists: gstack-telemetry-log for remote reporting
|
|
*/
|
|
|
|
|
|
import type { TemplateContext } from './types';
|
|
import { generateModelOverlay } from './model-overlay';
|
|
import { generateQuestionTuning } from './question-tuning';
|
|
|
|
// Core bootstrap
|
|
import { generatePreambleBash } from './preamble/generate-preamble-bash';
|
|
import { generateUpgradeCheck } from './preamble/generate-upgrade-check';
|
|
import {
|
|
generateCompletionStatus,
|
|
generatePlanModeInfo,
|
|
} from './preamble/generate-completion-status';
|
|
|
|
// One-time onboarding prompts
|
|
import { generateLakeIntro } from './preamble/generate-lake-intro';
|
|
import { generateTelemetryPrompt } from './preamble/generate-telemetry-prompt';
|
|
import { generateProactivePrompt } from './preamble/generate-proactive-prompt';
|
|
import { generateRoutingInjection } from './preamble/generate-routing-injection';
|
|
import { generateVendoringDeprecation } from './preamble/generate-vendoring-deprecation';
|
|
import { generateSpawnedSessionCheck } from './preamble/generate-spawned-session-check';
|
|
import { generateWritingStyleMigration } from './preamble/generate-writing-style-migration';
|
|
|
|
// Host-specific instructions
|
|
import { generateBrainHealthInstruction } from './preamble/generate-brain-health-instruction';
|
|
|
|
// GBrain cross-machine sync (runs at skill start; end-side handled in completion-status)
|
|
import { generateBrainSyncBlock } from './preamble/generate-brain-sync-block';
|
|
|
|
// Behavioral / voice
|
|
import { generateVoiceDirective } from './preamble/generate-voice-directive';
|
|
|
|
// Tier 2+ context and interaction framework
|
|
import { generateContextRecovery } from './preamble/generate-context-recovery';
|
|
import { generateAskUserFormat } from './preamble/generate-ask-user-format';
|
|
import { generateWritingStyle } from './preamble/generate-writing-style';
|
|
import { generateCompletenessSection } from './preamble/generate-completeness-section';
|
|
import { generateConfusionProtocol } from './preamble/generate-confusion-protocol';
|
|
import { generateContinuousCheckpoint } from './preamble/generate-continuous-checkpoint';
|
|
import { generateContextHealth } from './preamble/generate-context-health';
|
|
|
|
// Tier 3+ repo mode + search
|
|
import { generateRepoModeSection } from './preamble/generate-repo-mode-section';
|
|
import { generateSearchBeforeBuildingSection } from './preamble/generate-search-before-building';
|
|
|
|
// Standalone export used directly by the resolver registry
|
|
export { generateTestFailureTriage } from './preamble/generate-test-failure-triage';
|
|
|
|
// Preamble Composition (tier → sections)
|
|
// ─────────────────────────────────────────────
|
|
// T1: core + upgrade + lake + telemetry + voice(trimmed) + completion
|
|
// T2: T1 + voice(full) + ask + completeness + context-recovery + confusion + checkpoint + context-health
|
|
// T3: T2 + repo-mode + search
|
|
// T4: (same as T3 — TEST_FAILURE_TRIAGE is a separate {{}} placeholder, not preamble)
|
|
//
|
|
// Skills by tier:
|
|
// T1: browse, setup-cookies, benchmark
|
|
// T2: investigate, cso, retro, doc-release, setup-deploy, canary, context-save, context-restore, health
|
|
// T3: autoplan, codex, design-consult, office-hours, ceo/design/eng-review
|
|
// T4: ship, review, qa, qa-only, design-review, land-deploy
|
|
export function generatePreamble(ctx: TemplateContext): string {
|
|
const tier = ctx.preambleTier ?? 4;
|
|
if (tier < 1 || tier > 4) {
|
|
throw new Error(`Invalid preamble-tier: ${tier} in ${ctx.tmplPath}. Must be 1-4.`);
|
|
}
|
|
const sections = [
|
|
generatePreambleBash(ctx),
|
|
// Plan-mode-skill semantics at position 1: after bash (so _SESSION_ID /
|
|
// _BRANCH / _TEL env vars are live) and before all onboarding gates so
|
|
// models read the authoritative "AskUserQuestion satisfies plan mode's
|
|
// end-of-turn" rule before any other instruction. Renders for all skills
|
|
// (not interactive-gated); the text applies universally.
|
|
generatePlanModeInfo(ctx),
|
|
generateUpgradeCheck(ctx),
|
|
generateWritingStyleMigration(ctx),
|
|
generateLakeIntro(),
|
|
generateTelemetryPrompt(ctx),
|
|
generateProactivePrompt(ctx),
|
|
generateRoutingInjection(ctx),
|
|
generateVendoringDeprecation(ctx),
|
|
generateSpawnedSessionCheck(),
|
|
generateBrainHealthInstruction(ctx),
|
|
// AskUserQuestion Format renders BEFORE the model overlay so the pacing rule
|
|
// is the ambient default; the overlay's behavioral nudges land as subordinate
|
|
// patches. Opus 4.7 reads top-to-bottom and absorbs the first pacing directive
|
|
// it hits; reversing this order regresses plan-review cadence (v1.6.4.0 bug).
|
|
...(tier >= 2 ? [generateAskUserFormat(ctx)] : []),
|
|
generateBrainSyncBlock(ctx),
|
|
generateModelOverlay(ctx),
|
|
generateVoiceDirective(tier),
|
|
...(tier >= 2 ? [
|
|
generateContextRecovery(ctx),
|
|
generateWritingStyle(ctx),
|
|
generateCompletenessSection(),
|
|
generateConfusionProtocol(),
|
|
generateContinuousCheckpoint(),
|
|
generateContextHealth(),
|
|
generateQuestionTuning(ctx),
|
|
] : []),
|
|
...(tier >= 3 ? [generateRepoModeSection(), generateSearchBeforeBuildingSection(ctx)] : []),
|
|
generateCompletionStatus(ctx),
|
|
];
|
|
return sections.filter(s => s && s.trim().length > 0).join('\n\n');
|
|
}
|