mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-10 06:58:59 +02:00
SinaandClaude Fable 5.1
f74d3a1a63
asideClient.ts replaces the direct $B client with one render() call per PDF (the exact option mapping the browse pdf command had: paper, margins, header/footer/page numbers, tagged, outline, printBackground, preferCSSPageSize, Paged.js wait); the diagram pre-pass, oversized-image downscale and DOCX rasters each run as one render script with per-fence try/catch; exit 4 now means no browser is available and names both remedies; $P setup reports which engine it found. The e2e gates run on whichever engine is present, so the Linux lane exercises the fallback. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
49 lines
2.1 KiB
TypeScript
49 lines
2.1 KiB
TypeScript
/**
|
|
* CI tripwire for the silent-skip class (#audit-2026-08: the 9 make-pdf e2e
|
|
* gate tests self-skipped on Linux for their entire life because the
|
|
* free-tests lane never built the binaries they probe — exit 0, no signal).
|
|
*
|
|
* Every sibling gate file guards itself with test.skipIf(!prerequisitesAvailable()),
|
|
* which is correct for LOCAL runs (a contributor without a build shouldn't
|
|
* fail) but is exactly how CI green stopped meaning "ran". This file inverts
|
|
* the polarity in CI: when GSTACK_EXPECT_BINARIES=1 (set by free-tests.yml's
|
|
* "Run free suite" step), the prerequisites are ASSERTED, so dropping the
|
|
* gate-build step or poppler from the workflow fails the required lane
|
|
* instead of quietly skipping the gates.
|
|
*
|
|
* Not set locally → the whole file self-skips, same as the gates.
|
|
*/
|
|
import { describe, expect, test } from "bun:test";
|
|
import * as fs from "node:fs";
|
|
import * as path from "node:path";
|
|
|
|
import { resolvePdftotext } from "../../src/pdftotext";
|
|
|
|
const ROOT = path.resolve(__dirname, "../../..");
|
|
const EXPECT_BINARIES = process.env.GSTACK_EXPECT_BINARIES === "1";
|
|
|
|
describe("gate prerequisites (CI tripwire)", () => {
|
|
test.skipIf(!EXPECT_BINARIES)("gate artifacts and tools exist when the lane promises them", () => {
|
|
const missing: string[] = [];
|
|
// Aside itself is deliberately NOT asserted: CI runners have no Aside. The
|
|
// gates print through gstack's own browse binary there (the fallback in
|
|
// lib/aside-render), so THAT build artifact is promised alongside the
|
|
// make-pdf binary, the diagram bundle, and poppler.
|
|
for (const rel of [
|
|
"make-pdf/dist/pdf",
|
|
"browse/dist/browse",
|
|
"lib/diagram-render/dist/diagram-render.html",
|
|
]) {
|
|
if (!fs.existsSync(path.join(ROOT, rel))) missing.push(rel);
|
|
}
|
|
try {
|
|
resolvePdftotext();
|
|
} catch (err: any) {
|
|
missing.push(`pdftotext (${err?.message ?? "unresolvable"})`);
|
|
}
|
|
// One assertion naming everything missing beats N opaque ones: the fix
|
|
// is always "restore the build:gates step / apt packages in free-tests.yml".
|
|
expect(missing).toEqual([]);
|
|
});
|
|
});
|