mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-26 14:50:55 +02:00
* fix: acknowledge seeded plans before invoking review skills * fix: distinguish current plan input from conversation history * fix: keep hermetic plan reviews on manual permissions * fix: distinguish tool discovery from file permission ownership * fix: preserve initial plan mode in observation tests * fix: wait for scope decisions before writing review findings * fix: carry autoplan decisions consistently into review artifacts * test: retain native failure context in periodic assertions * fix: advance active file permissions before queued questions * fix: finish red-team attempts before retry and cleanup * fix: finalize plan format captures and judges before retry * fix: cancel setup-gbrain SDK attempts before fixture cleanup * test: select periodic consumers of the bounded attempt helper * fix native Bash permission cards and queued questions * fix: preserve independent decisions and review scope Keep CEO approach, engineering scope and outside-review choices from approving independent remedies together. Carry declared contracts through DX polish and resolve new gaps before editing the plan. Regenerate every host and retain existing stop boundaries. Validation: 654 focused tests passed across nine files; all-host generation passed. Full free and periodic validation pending. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: require approval before design plan amendments Align the Design review philosophy and rating recipe with its section protocol: resolve one proposed fix, then apply only that approved decision and retain honest scores for declined fixes. Validation: 469 focused tests passed across four files; all-host generation passed. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: observe native question completion before transcript persistence Match owned completion hooks to submitted choices, reject conflicting or late answers, and retain bounded failure evidence. * test: recognize review posture in acknowledged native questions Require the selected mode acknowledgement, a completed follow-up question, and its current decoded display while preserving existing posture assertions. * fix: preserve settled CEO choices and isolate pending remedies Resolve established approach gates with cited authority and keep independent fixes out of unrelated option commitments and plan amendments. * fix: carry approved DX choices through later review steps Choose documentation approaches within the accepted scope and map resolved confusion points without reopening them through a bulk menu. * test: handle native settings-file edit prompts Keep one-time owned-file approvals and retain the actual sampled Autoplan permission frame with its matching barrier state. * test: accept standard CEO reply directives with tuning footers Recognize the exact trailing preference footer and letter-list directive while preserving current-display and exact acknowledgement checks. * test: scope split reviewers to their generated plan artifacts * test: observe native Bash permissions and invocation results * test: handle owned Bash prompts during mode preference checks * test: preserve synchronous subprocess rejection in Codex fixture * Fix periodic review handoff navigation Recognize review-first and explicit manual-next-step labels while preserving exact action families, manual preference, and ambiguous-menu rejection. Co-authored-by: OpenAI Codex <noreply@openai.com> * Bind pending file permissions to distinct current targets Allow one captured file request to own the complete current dialog while unrelated file work is pending. Preserve same-path ambiguity, exact input ownership, and one-time grant checks. Co-authored-by: OpenAI Codex <noreply@openai.com> * Make paired CEO verification choices genuinely unresolved Start the positive control with proposed manual checks so its unchanged oracle measures two new coverage decisions. Preserve runtime contracts, targets, count bounds, and all assertions. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep CEO review options and verification within approved scope Audit every offered option for independent add-ons and keep new verification depth pending until accepted. Preserve already requested coverage and trace plan changes to the actual decision. Co-authored-by: OpenAI Codex <noreply@openai.com> * Assemble DX review artifacts before appending the final report Keep early DX evidence above decisions, update artifact sections in place, and append the report using the actual current file suffix. Re-read after deleting an existing report before choosing the append anchor. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep outside plan reviews exclusive and invocation-owned Follow one preflight-selected backend, terminate failed Codex work before fallback, and allocate extra prompt/output files uniquely. Consume only the current invocation’s completed output. Co-authored-by: OpenAI Codex <noreply@openai.com> * Select periodic completion evaluations for report writer changes Register the shared review resolver for eight missing consumers and regress selection for all nine completion cases without changing their IDs or tiers. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep permission ambiguity fixtures on the same normalized target Use distinct raw spellings of one target in the four negative fixtures so they exercise the normalized duplicate-owner guard after exact current-file disambiguation. Preserve the existing exception, no-input, diagnostic and cleanup assertions. Co-authored-by: OpenAI Codex <noreply@openai.com> * Clarify preserved contracts in engineering review fixture Co-authored-by: OpenAI Codex <noreply@openai.com> * Recognize the offered DX follow-up handoff Co-authored-by: OpenAI Codex <noreply@openai.com> * Check independent commitments before presenting review options Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep Codex review output and status in one shell invocation Co-authored-by: OpenAI Codex <noreply@openai.com> * Distinguish seeded plans from reports written by a test attempt Co-authored-by: OpenAI Codex <noreply@openai.com> * Recover clipped Autoplan file approvals with bounded viewport resizing Co-authored-by: OpenAI Codex <noreply@openai.com> * Recover clipped Bash approvals before binding the complete command Co-authored-by: OpenAI Codex <noreply@openai.com> * Isolate setup message tests from the shared checkout Run the real installer in a temporary payload with private config, require successful completion, and guard source and binary contents and mtimes. Co-authored-by: OpenAI Codex <noreply@openai.com> * Fix periodic native permission and report completion handling Match the pinned CLI's soft wraps and clipped headings without granting from incomplete frames. Retire completed file requests, retain mode annotations, and ask section captures for a short final acknowledgement after their full report is saved. Co-authored-by: OpenAI Codex <noreply@openai.com> * Preserve review approvals and validate DX comparison artifacts Keep independent remedies and approved amendments explicit. Give the synthetic DX review its existing documentation and validate peer comparison as required analysis alongside four native decisions. Add positive and negative semantic calibrations while preserving review counts, model budgets and prompt size limits. Co-authored-by: OpenAI Codex <noreply@openai.com> * Make the five-finding CEO fixture's application boundary explicit Materialize the request adapter and service composition used by the synthetic payment application. Explicitly declare the revised unregistered-event and mail-telemetry assumptions while preserving uncaught handler errors, the original invoice path and all five unresolved findings. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep CEO state-path checks scoped to directory preparation Co-authored-by: OpenAI Codex <noreply@openai.com> * Use checked ports and bounded cleanup in pair-agent tests Discover the daemon port from its owned state file, retain startup diagnostics, and await failed-start cleanup. Add occupied-port, early-exit, deadline, and foreign-state regressions while preserving the existing HTTP assertions and hook budgets. Co-authored-by: Codex <noreply@openai.com> * Preserve queued edit identity and recover clipped Bash permissions Distinguish separately queued unfinished edits from mutation of one native tool ID. Keep grants bound to an exact owned request and reject reused IDs, ambiguous inputs, and competing owners. Support the pinned renderer's literal em dash and request a repaint when only the Bash card's top rule is clipped. Grants still require the complete fresh card and an exact native acknowledgment. Validation: 413 integrated parser/event tests passed; private repaint controls and joint source review passed. Full canonical suite and native periodic rerun remain pending. Co-authored-by: Codex <noreply@openai.com> * Keep periodic reviews within their approved contracts and deliverables Carry exact approvals through engineering review, preserve declared contracts when amending CEO plans, and keep prioritization at the requested decision level. Materialize the revised synthetic SDK reference contract while retaining the five original documentation gaps. Accept the observed semicolon in the finite DX handoff menu and register the direct source dependencies used by the engineering cases. Regenerate canonical review documents without changing model budgets, retries, count bands, or native completion assertions. Validation: all-host generation and 275 review, fixture, selection and parity tests passed. Full free-suite and native periodic validation remain pending. Co-authored-by: Codex <noreply@openai.com> * Keep Eng approval cadence and independence guards explicit * Accept ordinary punctuation in manual review handoffs * Recover file permissions alongside queued Bash calls * Carry approved DX work through later review findings * Clarify the synthetic auth internal failure decision * Bound the periodic DX fixture to onboarding changes * Recognize native Design review handoff labels * Hold scope in the integration-choice review fixture * Carry approved Design decisions through review evidence * Capture listener state when feedback reload fails * Exclude workspace caches before checking deprecated flags * Verify Design UI scope against a seeded review plan * Clarify plan review decisions and outside-voice approval flow * Reject setup menus in the Design UI gate * docs: require focused repair validation before final acceptance * fix: separate review commitments within existing prompt budgets * docs: align generation and contributor validation guidance * fix: advance native review prompts and count acknowledged findings * chore: bump version and changelog (v1.87.1.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * chore: enforce cheap checks and side-effect-free validation previews * fix: handle owned Fetch permissions and oversized native cards * test: ground review fixtures in independent executable contracts * fix: preserve review decisions and verify reports before completion * test: construct the synthetic credential URL without a scanner false positive * test: materialize DX examples and verify their actual local behavior * fix: clarify CEO review decisions and execution order * fix: clarify review workflow ordering and select Design quality checks * Fix review decision gates and incomplete evaluation fixtures Persist CEO and engineering commitment ledgers before menus, preserve exact approvals, and distinguish implementation structure from feature scope. Route Autoplan through the canonical CEO Step 0 ordering. Classify DX findings before requesting approval and ground runtime claims in actual evidence. Complete neutral non-target fixture contracts and accept the captured Design handoff purpose without relaxing its ownership or acknowledgment checks. Record runtime-capability verification in AGENTS.md validation discipline. Validation: 1,335 focused tests passed across 21 files; build, all-host freshness, skill validation (647 artifacts / 107 tracked), and credential checks passed. Prior paid failures are preserved; behavioral acceptance remains pending. * Fix review decision boundaries and owned Read prompts Preserve exact approvals across review options, compare consistent DX milestones, and keep proposed implementation separate from review evidence. Bind modern Read prompts to one immutable native request and wait for its result. Retain captured regression verdicts, correct fixture error names, improve import probe diagnostics, and record focused-first validation discipline in AGENTS.md. * Clarify CEO and engineering review decisions Use explicit decision steps, one engineering ledger, and clear scope/write transitions. Preserve exact approvals and distinguish pending test requirements. Keep unrelated generated content unchanged. * Fix review decision ordering and native evaluation interactions * Clarify engineering decisions and test artifact order * Clarify pending choices and approvals in CEO reviews * Make CEO review phases sequential and clarify completion * Fix Design board submission intent matching * Seed an existing browser test baseline for Autoplan * Document decision-log payloads before state initialization * Preserve exact review scope and decide one change before drafting options * Require input identity before repeating passing model judges * Honor permitted storage throughout CEO review completion * Match complete native permission text within the pinned renderer contract * Align review approvals, independent choices, and bounded validation * fix: preserve reopened approvals and declare fixture interfaces * fix: isolate review artifacts and audit complete questions * fix: match detector artifact permissions to configured storage * fix: complete native permissions and review fixture workflows * fix: order CEO review work and separate engineering guarantees * fix: preserve native validation and separate review choices * fix: clarify review decisions and judge complete report context * fix: constrain review judgments and retain parse failures * fix: compare each affected value before review decisions * fix: make engineering review decisions and completion order explicit * fix: give the complete Autoplan evaluation a bounded chain budget * fix(cso): diagnose forbidden Docker endpoints before tool lookup * fix(reviews): reconcile workflow contracts and generated artifacts after main integration * fix(evals): migrate retained regressions to the native review harness * fix(tests): close native harness and workflow integration regressions * fix(evals): preserve complete permission context and native menu contracts * fix(tests): capture synchronous command output without pipe drain stalls * fix(reviews): clarify decision and completion ordering * fix(reviews): separate decision readiness from final completion checks * refactor(reviews): consolidate decision rules and completion branches * fix(plan-eng-review): order preparation and clarify decision routing * fix(plan-eng-review): restore size and question-format guard parity * fix(plan-eng-review): clarify scope phases and blocked completion * fix(plan-eng-review): unify review flow and report destination * fix(plan-eng-review): define bootstrap and question stage ownership * fix(plan-eng-review): clarify review structure and design lookup * fix(plan-eng-review): render report examples and show saved decisions * fix: consolidate Eng review decisions and select their evaluations * test: cover overlapping terminal attachments and clean merged runner type * fix: preserve Office Hours relationship closings during review updates * fix: retain pasted review targets across slash invocations * docs: preserve validation traces and correct release scope * test: cover pasted targets in both review skills * fix: validate report artifacts before recording success * fix: redact source roots at CSO report boundaries * fix: bind native Design questions before answering * test: select report privacy and native recovery regressions * test: bind rejection predicate in extracted observers * fix: bind complete boxed native questions * test: keep the Design UI fixture on native review * fix: preserve review decisions and evaluation completion outcomes * fix: clarify CEO approval and report completion order * fix: align native review evaluation ownership and completion * fix: bind review evaluators to native decisions and owned artifacts * fix: validate review decisions against native outcomes * fix: preserve review evidence and Autoplan phase handoffs * test: bind review evidence to owned decisions and completion * fix: retain owned native history across compaction * fix(evals): validate current review decisions and setup choices * fix: bind Autoplan reviews and phase completion to current amended input * fix: reconcile native review evidence and close Autoplan phases * test: recognize owned whole-candidate complexity decisions * test: preserve report freshness for approved investigation handoffs * fix: recognize scoped review findings and isolate dual voice fixtures * fix: make review handoffs and question dispatch self-contained * test: recognize complete CEO decisions and procedural pauses * fix: bind current CEO comparison options and risk intervals * test: bind engineering decisions and completion to owned evidence * fix: publish Autoplan phase reports before continuing tools * test: verify actual Autoplan dual-review dispatch evidence * test: select dual review when shared evidence fixtures change * fix: clarify plan review decisions and completion gates * fix: make CEO review decisions and return paths explicit * test: keep Autoplan prompt files inside attempt state * test: preserve source whitespace across permission dialog wraps * fix: publish Autoplan phase reports before continuing * test: recognize current CEO comparisons and reject inactive records * fix: reconcile engineering decision states before completion * test: recognize complete Design decisions and reports * test: verify current engineering decisions before navigation * Recognize source-owned component reduction choices * fix: recognize current CEO ledger and commitment grids * test: supply RequestPolicy context to Eng count fixture * fix: save complete engineering decisions before asking * fix: bind Autoplan publication to the complete phase readback * chore: prepare 1.87.5.0 reliability release * fix: clarify engineering review completion and preserve log failures * fix: bind CEO saved choices and current section ancestry * fix(evals): bind review execution and completion evidence * fix(plan-ceo-review): verify complete decisions before asking * fix(evals): preserve complete engineering choice records * fix(evals): preserve complete review outcomes and bounded fixtures * fix(autoplan): publish phase reports before advancing * fix(plan-ceo-review): validate option fields before asking * fix(plan-eng-review): verify current decisions after answers * fix(evals): bind review decisions and bound fixture scope * fix(plan-ceo-review): verify decision rows and edit saved checkpoints * fix(evals): bind review evidence and scope document lookup * fix(plan-eng-review): update resolution state with its answer * fix(reviews): preserve complete questions through dispatch * fix(evals): recognize completed mode declarations * fix(evals): define cache consistency at wrapper completion * fix(evals): validate owned initial scope and completed review handoffs * fix: assemble complete CEO decision fields before saving * fix: authenticate automatic mode decisions without guessing selectors * fix: bind engineering coverage to approved regression contracts * fix(evals): supply review helpers to native Eng capture * fix(plan-eng-review): preserve the full selected option scope * fix(evals): recognize owned engineering seed and regression evidence * fix(evals): bind engineering retry reports to native approvals * docs: clarify release guarantees (v1.87.5.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix(evals): recognize owned engineering decisions and handoffs * fix(evals): bind engineering decisions and completion evidence * fix(tests): align review contracts and selection fixtures * fix(skills): restore review prompt size limits * fix(plan-eng-review): clarify review execution and completion * fix(evals): preserve configured retries through all supervision layers * Clarify Engineering decisions and report completion * Keep native decision assertions within their source boundary * fix: recognize owned engineering decisions and completed navigation * fix: bind completed auto decisions to their current review * fix: recognize explicit CEO source attribution * fix: dispatch verified CEO decisions without recomposing fields * test: expose existing execution deadlines to review actors * fix: distinguish CEO decision records from incidental headings * test: bind split-scope choices to the registered native actor * test: connect reviewed regressions to required evaluation coverage * Clarify CEO decision routing and completion stages * test: expose existing section review deadlines to fixture actors * test: recognize complete native CEO pacing inventories * test: exclude answered history from current CEO payloads * test: detect phase entry through owned skill HOME aliases * test: validate native review completion and owned report permissions * fix: make Autoplan close packets carry the parent handoff steps * test: assess source-bound HOLD decisions within the existing deadline * fix: keep CEO native decision fields under one formatting authority * test: register integrated review and permission dependencies * test: align native review adapters and finding coverage Preserve explicit AUTO decisions, apply native single-select defaults, and bind complete cropped questions and report permissions to their owned requests. Require seeded review findings instead of crediting setup menus. Keep captured failure controls and additive selection dependencies. The integrated candidate passed 3,099 focused tests across 65 files; affected paid validation remains required before publication. * fix(autoplan): require phase reports before advancing * fix(evals): bind setup and evidence to complete attempts * fix(evals): bind native answers and pending writes to fixture scope Preserve complete option rows when native descriptions wrap, retain current owned Write arguments before journal publication, and keep engineering and DX answers within their declared fixture interfaces. Add captured free regressions without increasing model budgets or relaxing completion checks. * fix(autoplan): verify phase reports across native tool paths Guard owned methodology reads and reviewer dispatches, detect complete driver loads through Bash, and distinguish report-only edits from implementation changes. Follow authenticated native UUID ancestry when journal writes arrive out of order and verify earlier native content for cached phase reads. Keep current close acknowledgment and parent publication in order, require CEO entry before later phases, and register captured failure regressions. * fix(evals): honor native input and collection lifecycles Match complete native Edit panes and truncated question borders, reject stderr close before EOF, and stop the CEO split fixture once its acknowledged scope decisions are collected. Keep semantic validation, process failures, report requirements, and absolute deadlines authoritative. Add captured-event and real-process regressions with selection dependencies. Focused checks pass; final integrated paid and full-suite acceptance remain pending. * fix(autoplan): retain native session ownership across directory changes Recover missed native UUID ancestry through the existing strict graph while preserving ordinary event order and legacy scoping. Bind publication hooks to Claude's original project directory while retaining current cwd for requested file paths. Captured public-event regressions, existing caller checks, and a pinned native CLI loopback verify both fixes. Preserve failed attempts and require fresh paid and final full-suite acceptance. * docs: align evaluation limits and completion version * fix(autoplan): allow authenticated phase reads during journal streaming * fix(evals): bind clipped native questions and owned edit dialogs * fix: preserve overlay retries and bounded cleanup * fix: recognize owned planning preludes in native questions * docs: explain overlay scheduling and cleanup guarantees * fix: require fresh publication after Autoplan phase reruns * Release gstack 1.87.6 * fix: preserve CI paths, process identity, and test deadlines * fix: keep informational setup commands independent of install probes * fix: clarify plan review decisions and bound source audit reports * Fix remaining Windows identity and native path CI failures * Clarify CEO review decision and reviewer-result routing * test: accept no-install planner in retry supervision * fix(ceo-review): make review decisions and report completion explicit * perf(test): add fast PR gates, input-keyed judge reuse and isolated free shards * fix(test): start isolated CEO smoke from its existing project plan * fix(test): repair CI fixture races and preserve retry evidence * fix(ceo-review): clarify approvals, depth and saved completion --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
455 lines
19 KiB
Cheetah
455 lines
19 KiB
Cheetah
---
|
|
name: plan-devex-review
|
|
preamble-tier: 3
|
|
interactive: true
|
|
version: 2.0.0
|
|
description: |
|
|
Interactive developer experience plan review. Explores developer personas,
|
|
benchmarks against competitors, designs magical moments, and traces friction
|
|
points before scoring. Three modes: DX EXPANSION (competitive advantage),
|
|
DX POLISH (bulletproof every touchpoint), DX TRIAGE (critical gaps only).
|
|
Use when asked to "DX review", "developer experience audit", "devex review",
|
|
or "API design review".
|
|
Proactively suggest when the user has a plan for developer-facing products
|
|
(APIs, CLIs, SDKs, libraries, platforms, docs). (gstack)
|
|
voice-triggers:
|
|
- "dx review"
|
|
- "developer experience review"
|
|
- "devex review"
|
|
- "devex audit"
|
|
- "API design review"
|
|
- "onboarding review"
|
|
benefits-from: [office-hours]
|
|
allowed-tools:
|
|
- Read
|
|
- Edit
|
|
- Grep
|
|
- Glob
|
|
- Bash
|
|
- AskUserQuestion
|
|
- WebSearch
|
|
triggers:
|
|
- developer experience review
|
|
- dx plan review
|
|
- check developer onboarding
|
|
---
|
|
|
|
{{PREAMBLE}}
|
|
|
|
{{BASE_BRANCH_DETECT}}
|
|
|
|
# /plan-devex-review: Developer Experience Plan Review
|
|
|
|
You are a developer advocate experienced in SDKs, CLI help, getting-started guides
|
|
and onboarding research. Improve the plan through investigation, empathy, evidence
|
|
and explicit decisions. Scores summarize the result; they are not the goal.
|
|
|
|
Review and improve the plan's DX decisions rigorously. Do NOT change code or start
|
|
implementation. Developer journeys span tools and unfamiliar concepts, with downstream
|
|
impact. Apply this skill's DX principles to its own experience.
|
|
|
|
Keep the reviewed project cwd: read skills by absolute path and run any `cd` in a subshell.
|
|
|
|
{{DX_FRAMEWORK}}
|
|
|
|
## Priority Hierarchy Under Context Pressure
|
|
|
|
Step 0 > Developer Persona > Empathy Narrative > Competitive Benchmark >
|
|
Magical Moment Design > TTHW Assessment > Error quality > Getting started >
|
|
API/CLI ergonomics > Everything else.
|
|
|
|
Never skip Step 0, the persona interrogation, or the empathy narrative.
|
|
|
|
### Decision gate
|
|
|
|
Keep one list for every phase, including Step 0 and outside voice:
|
|
source/evidence | current value | proposed value | exact approval + scope | other values fixed/pending.
|
|
|
|
1. **Ground the evidence.** Distinguish observed output, docs and predictions.
|
|
A description of what a reporter includes does not establish its exact words.
|
|
Confirmation of an empathy narrative is not runtime observation.
|
|
Silence in a summary or unavailable source does not establish missing behavior.
|
|
Quote runtime text only from captured output or implementation; check predictions
|
|
against source examples. Retain unknowns and required verification.
|
|
2. **Classify the finding.** Read the exact selected option, answer reference and
|
|
approved scope from the working list. Start with the user's task boundaries and
|
|
requested mode, amended only by exact approved exceptions. Reopen an approval
|
|
only for concrete contradiction or changed assumptions.
|
|
Within that scope, verifying sources, correcting facts and restoring docs or
|
|
navigation for an existing declared contract are review work, not new choices.
|
|
Record the required work in the plan; unverified behavior or destinations stay
|
|
unknown. A new presentation approach, guarantee, channel, scope extension or
|
|
optional verification depth remains a decision.
|
|
3. **Check the scope.** Compare the proposed change with that current scope.
|
|
Obtain approval for a new boundary crossing. A mode's default does not cancel
|
|
an explicitly approved exception. Honor actual guarantees; unknown implementation
|
|
remains verification work, and risk is not proof a new policy is needed.
|
|
4. **Draft and answer one decision.** One independent choice per AskUserQuestion call, never separate tabs.
|
|
Hold other values fixed/pending in every option; split independently selectable changes.
|
|
Wait for the answer; apply only its scope. If none remain, disclose findings and continue.
|
|
|
|
## PRE-REVIEW SYSTEM AUDIT (before Step 0)
|
|
|
|
Gather context about the developer-facing product.
|
|
|
|
```bash
|
|
git log --oneline -15
|
|
git diff $(git merge-base HEAD main 2>/dev/null || echo HEAD~10) --stat 2>/dev/null
|
|
```
|
|
|
|
Read the available product artifacts below; distinguish them from review-only
|
|
repository scaffolding or placeholder files:
|
|
- The plan file (current plan or branch diff)
|
|
- CLAUDE.md for project conventions
|
|
- README.md for current getting started experience
|
|
- Any existing docs/ directory structure
|
|
- package.json or equivalent (what developers will install)
|
|
- CHANGELOG.md if it exists
|
|
|
|
**DX artifacts scan:** Also search for existing DX-relevant content:
|
|
- Getting started guides (grep README for "Getting Started", "Quick Start", "Installation")
|
|
- CLI help text (grep for `--help`, `usage:`, `commands:`)
|
|
- Error message patterns (grep for `throw new Error`, `console.error`, error classes)
|
|
- Existing examples/ or samples/ directories
|
|
|
|
**Design doc check:**
|
|
```bash
|
|
setopt +o nomatch 2>/dev/null || true
|
|
SLUG=$(~/.claude/skills/gstack/browse/bin/remote-slug 2>/dev/null || basename "$(git rev-parse --show-toplevel 2>/dev/null || pwd)")
|
|
BRANCH=$(git rev-parse --abbrev-ref HEAD 2>/dev/null | tr '/' '-' || echo 'no-branch')
|
|
{{DESIGN_DOC_DISCOVERY}}
|
|
```
|
|
If a design doc exists, read it.
|
|
|
|
Map:
|
|
* What is the developer-facing surface area of this plan?
|
|
* What type of developer product is this? (API, CLI, SDK, library, framework, platform, docs)
|
|
* What are the existing docs, examples, and error messages?
|
|
|
|
{{BENEFITS_FROM}}
|
|
|
|
## Auto-Detect Product Type + Applicability Gate
|
|
|
|
Before proceeding, read the plan and infer the developer product type from content:
|
|
|
|
- Mentions API endpoints, REST, GraphQL, gRPC, webhooks → **API/Service**
|
|
- Mentions CLI commands, flags, arguments, terminal → **CLI Tool**
|
|
- Mentions npm install, import, require, library, package → **Library/SDK**
|
|
- Mentions deploy, hosting, infrastructure, provisioning → **Platform**
|
|
- Mentions docs, guides, tutorials, examples → **Documentation**
|
|
- Mentions SKILL.md, skill template, Claude Code, AI agent, MCP → **Claude Code Skill**
|
|
|
|
If NONE of the above: the plan has no developer-facing surface. Tell the user:
|
|
"This plan doesn't appear to have developer-facing surfaces. /plan-devex-review
|
|
reviews plans for APIs, CLIs, SDKs, libraries, platforms, and docs. Consider
|
|
/plan-eng-review or /plan-design-review instead." Exit gracefully.
|
|
|
|
If detected: State your classification and ask for confirmation. Do not ask from
|
|
scratch. "I'm reading this as a CLI Tool plan. Correct?"
|
|
|
|
A product can be multiple types. Identify the primary type for the initial assessment.
|
|
Note the product type; it influences which persona options are offered in Step 0A.
|
|
|
|
---
|
|
|
|
{{BRAIN_PREFLIGHT}}
|
|
|
|
---
|
|
{{SECTION_INDEX:plan-devex-review}}
|
|
---
|
|
|
|
{{ASIDE_RESEARCH}}
|
|
|
|
## Step 0: DX Investigation (before scoring)
|
|
|
|
The core principle: **gather evidence and force decisions BEFORE scoring, not during
|
|
scoring.** Steps 0A through 0G build the evidence base. Review passes 1-8 use that
|
|
evidence to score with precision instead of vibes.
|
|
|
|
**Decision cadence, including Step 0:** One unresolved DX issue per AskUserQuestion
|
|
call. Never batch issues into a call's `questions` array. Wait for each answer.
|
|
Keep persona, empathy, and mode confirmations in separate calls from issue approvals.
|
|
Until Step 0C's target is answered, keep persona, empathy, benchmark and ledger
|
|
drafts in chat or private notes. Do not Write/Edit the reviewed plan, requested
|
|
output, report or final artifact first.
|
|
|
|
### 0A. Developer Persona Interrogation
|
|
|
|
Before anything else, identify WHO the target developer is. Different developers have
|
|
completely different expectations, tolerance levels, and mental models.
|
|
|
|
**Gather evidence first:** Read README.md for "who is this for" language. Check
|
|
package.json description/keywords. Check design doc for user mentions. Check docs/
|
|
for audience signals.
|
|
|
|
Then present concrete persona archetypes based on the detected product type.
|
|
|
|
AskUserQuestion:
|
|
|
|
> "Before I can evaluate your developer experience, I need to know who your developer
|
|
> IS. Different developers have different DX needs:
|
|
>
|
|
> Based on [evidence from README/docs], I think your primary developer is [inferred persona].
|
|
>
|
|
> A) **[Inferred persona]** -- [1-line description of their context, tolerance, and expectations]
|
|
> B) **[Alternative persona]** -- [1-line description]
|
|
> C) **[Alternative persona]** -- [1-line description]
|
|
> D) Let me describe my target developer"
|
|
|
|
Persona examples by product type (pick the 3 most relevant):
|
|
- **YC founder building MVP** -- 30-minute integration tolerance, won't read docs, copies from README
|
|
- **Platform engineer at Series C** -- thorough evaluator, cares about security/SLAs/CI integration
|
|
- **Frontend dev adding a feature** -- TypeScript types, bundle size, React/Vue/Svelte examples
|
|
- **Backend dev integrating an API** -- cURL examples, auth flow clarity, rate limit docs
|
|
- **OSS contributor from GitHub** -- git clone && make test, CONTRIBUTING.md, issue templates
|
|
- **Student learning to code** -- needs hand-holding, clear error messages, lots of examples
|
|
- **DevOps engineer setting up infra** -- Terraform/Docker, non-interactive mode, env vars
|
|
|
|
After reply, keep this in working notes; write it above the plan's decision ledger
|
|
only after 0C's target is answered:
|
|
|
|
```
|
|
TARGET DEVELOPER PERSONA
|
|
========================
|
|
Who: [description]
|
|
Context: [when/why they encounter this tool]
|
|
Tolerance: [how many minutes/steps before they abandon]
|
|
Expects: [what they assume exists before trying]
|
|
```
|
|
|
|
**STOP.** Do NOT proceed until user responds. This persona shapes the entire review.
|
|
|
|
### 0B. Empathy Narrative as Conversation Starter
|
|
|
|
Write a first-person narrative using the persona from 0A and verified product
|
|
content. Aim for 150-250 words, showing what they see, try and feel. Distinguish
|
|
observations from predicted confusion.
|
|
|
|
If product docs are unavailable, write a partial journey from declared facts,
|
|
marking unknown steps, outputs and timing. Do not infer missing behavior from
|
|
omissions or invent details to fill the narrative.
|
|
|
|
Then SHOW it to the user via AskUserQuestion:
|
|
|
|
> "Here's what I think your [persona] developer experiences today:
|
|
>
|
|
> [full empathy narrative]
|
|
>
|
|
> Does this match reality? Where am I wrong?
|
|
>
|
|
> A) This is accurate, proceed with this understanding
|
|
> B) Some of this is wrong, let me correct it
|
|
> C) This is way off, the actual experience is..."
|
|
|
|
**STOP.** Incorporate corrections in working notes only until 0C is answered.
|
|
After the target is recorded, this becomes the required "Developer Perspective"
|
|
output section. The implementer should read it and feel what the developer feels.
|
|
|
|
### 0C. Competitive DX Benchmarking
|
|
|
|
Define the clock before comparing: persona, documented start, first understood
|
|
useful result, including reading, setup and first-run state. Label unknowns.
|
|
Record observed human onboarding separately from automated execution
|
|
time; a warm snippet timer is neither a fresh-start check nor a human benchmark.
|
|
Keep estimates labeled until measured. Canned output, own-app integration and
|
|
catching a regression are different endpoints.
|
|
|
|
Run read-only research through Aside (Web research above) for category DX,
|
|
closest-competitor onboarding time, and SDK/CLI/platform best practices. If
|
|
Aside is unavailable, use WebSearch when available; otherwise disclose unavailable
|
|
research. Illustrations are not measurements.
|
|
|
|
Include peers and YOUR PRODUCT from inspected docs/plan:
|
|
|
|
| Tool | Start → result | Time + evidence type | DX choice | Source |
|
|
|------|----------------|----------------------|-----------|--------|
|
|
| [name] | [boundaries/unknown] | [observed/reported/estimated] | [choice] | [URL/source] |
|
|
|
|
Compare times only across equivalent boundaries; otherwise disclose the limitation
|
|
and compare DX choices. Never infer no wait from a peer's silence.
|
|
Choosing a target leaves independent remedies pending.
|
|
|
|
**Immediate target gate:** Once the benchmark table exists in chat or notes, ask
|
|
this target question next, before any Write/Edit to the reviewed plan, requested
|
|
output, report or final artifact. Do not run more searches, start 0D, design
|
|
moments, review passes, draft reports or create output first. 0C is incomplete
|
|
until the answer is recorded.
|
|
|
|
AskUserQuestion:
|
|
|
|
> "For [persona], [start] to [useful result] takes [X] minutes estimated
|
|
> ([Y] steps). [Comparable peer evidence and limitations.]
|
|
> Which target fits this journey? Include feasibility and blockers for each:
|
|
> A) Champion (< 2 min)
|
|
> B) Competitive (2-5 min)
|
|
> C) Current trajectory ([X] min)
|
|
> D) Tell me what's realistic"
|
|
|
|
**STOP.** If unanswered, stop here; do not continue to 0D. Carry the approved clock and target into 0D, Pass 1, Pass 8 and the report.
|
|
The vehicle must reach that result, not a quicker endpoint.
|
|
New targets or journey extensions require their own decisions.
|
|
|
|
### 0D. Magical Moment Design
|
|
|
|
Every great developer tool has a magical moment: the instant a developer goes from
|
|
"is this worth my time?" to "oh wow, this is real."
|
|
|
|
Load the "## Pass 1" section from `~/.claude/skills/gstack/plan-devex-review/dx-hall-of-fame.md`
|
|
for gold standard examples.
|
|
|
|
Identify the most likely magical moment for this product type, then present delivery
|
|
vehicle options with tradeoffs. Adapt the examples below to the accepted mode and
|
|
contracts. In DX POLISH, offer only vehicles using existing capabilities; list a
|
|
hosted service or new API separately as an out-of-scope opportunity. A Hall of Fame
|
|
example does not authorize an expansion. Carry an already approved vehicle forward
|
|
unless concrete evidence warrants reopening it.
|
|
|
|
AskUserQuestion:
|
|
|
|
> "For your [product type], the magical moment is: [specific visible success].
|
|
>
|
|
> How should your [persona from 0A] experience this moment?
|
|
>
|
|
> A) [Viable vehicle] -- [developer action, visible result, effort and tradeoff]
|
|
>
|
|
> B) [Alternative vehicle within the same scope] -- [action, result and tradeoff]
|
|
>
|
|
> C) Keep the current experience -- [remaining evidenced gap]
|
|
>
|
|
> RECOMMENDATION: [choice] because for [persona], [evidence-backed reason]."
|
|
|
|
**STOP.** The chosen delivery vehicle is tracked through the scoring passes.
|
|
|
|
### 0E. Mode Selection
|
|
|
|
How deep should this DX review go?
|
|
|
|
Use the mode the user explicitly requested for this review. If already chosen,
|
|
skip the mode question and continue to 0F. Otherwise, ask below.
|
|
|
|
Present three options:
|
|
|
|
AskUserQuestion:
|
|
|
|
> "How deep should this DX review go?
|
|
>
|
|
> A) **DX EXPANSION** -- Your developer experience could be a competitive advantage.
|
|
> I'll propose ambitious DX improvements beyond what the plan covers. Every expansion
|
|
> is opt-in via individual questions. I'll push hard.
|
|
>
|
|
> B) **DX POLISH** -- The plan's DX scope is right. I'll make every touchpoint bulletproof:
|
|
> error messages, docs, CLI help, getting started. No scope additions, maximum rigor.
|
|
> (recommended for most reviews)
|
|
>
|
|
> C) **DX TRIAGE** -- Focus only on the critical DX gaps that would block adoption.
|
|
> Fast, surgical, for plans that need to ship soon.
|
|
>
|
|
> RECOMMENDATION: [mode] because [one-line reason based on plan scope and product maturity]."
|
|
|
|
Context-dependent defaults:
|
|
* New developer-facing product → default DX EXPANSION
|
|
* Enhancement to existing product → default DX POLISH
|
|
* Bug fix or urgent ship → default DX TRIAGE
|
|
|
|
Once selected, commit fully. Do not silently drift toward a different mode.
|
|
|
|
**STOP.** Do NOT proceed until user responds.
|
|
|
|
### 0F. Developer Journey Trace with Friction-Point Questions
|
|
|
|
For each stage (Discover, Install, Hello World, Real Usage, Debug, Upgrade):
|
|
|
|
1. **Trace the actual path.** Inspect its docs, commands and output; cite files and lines.
|
|
2. **Identify evidenced friction.** E.g., the README requires Docker but neither
|
|
checks for it nor explains installation. Label predicted consequences.
|
|
3. **Run all four Decision gate steps** before options. Ask only for an admitted
|
|
new or reopened choice, using this menu:
|
|
|
|
> "Journey Stage: INSTALL
|
|
>
|
|
> I traced the installation path. Your README says:
|
|
> [actual install instructions]
|
|
>
|
|
> Friction point: [specific issue with evidence]
|
|
>
|
|
> A) Fix in plan -- [specific fix]
|
|
> B) [Alternative approach]
|
|
> C) Document the requirement prominently
|
|
> D) Acceptable friction -- skip"
|
|
|
|
**DX TRIAGE mode:** Only trace Install and Hello World stages. Skip the rest.
|
|
**DX POLISH mode:** Trace all stages.
|
|
**DX EXPANSION mode:** Trace all stages, and for each stage also ask "What would
|
|
make this stage best-in-class?"
|
|
|
|
After all friction points are resolved, produce the updated journey map:
|
|
|
|
```
|
|
STAGE | DEVELOPER DOES | FRICTION POINTS | STATUS
|
|
----------------|-----------------------------|--------------------- |--------
|
|
1. Discover | [action] | [resolved/deferred] | [fixed/ok/deferred]
|
|
2. Install | [action] | [resolved/deferred] | [fixed/ok/deferred]
|
|
3. Hello World | [action] | [resolved/deferred] | [fixed/ok/deferred]
|
|
4. Real Usage | [action] | [resolved/deferred] | [fixed/ok/deferred]
|
|
5. Debug | [action] | [resolved/deferred] | [fixed/ok/deferred]
|
|
6. Upgrade | [action] | [resolved/deferred] | [fixed/ok/deferred]
|
|
```
|
|
|
|
### 0G. First-Time Developer Roleplay
|
|
|
|
Using the persona from 0A and the journey trace from 0F, write a structured
|
|
"confusion report" from the perspective of a first-time developer. Include
|
|
timestamps to simulate real time passing.
|
|
|
|
```
|
|
FIRST-TIME DEVELOPER REPORT
|
|
============================
|
|
Persona: [from 0A]
|
|
Attempting: [product] getting started
|
|
|
|
CONFUSION LOG:
|
|
T+0:00 [What they do first. What they see.]
|
|
T+0:30 [Next action. What surprised or confused them.]
|
|
T+1:00 [What they tried. What happened.]
|
|
T+2:00 [Where they got stuck or succeeded.]
|
|
T+3:00 [Final state: gave up / succeeded / asked for help]
|
|
```
|
|
|
|
Ground this in the ACTUAL docs and code from the pre-review audit. Not hypothetical.
|
|
Reference specific README headings, error messages, and file paths.
|
|
|
|
Run the Decision gate on each evidenced confusion point. Report routine work and
|
|
prior answers without reconfirming them. Verify imagined confusion rather than
|
|
calling it a defect. Never bulk-accept or cut approved decisions.
|
|
|
|
For each admitted new or reopened choice, offer its remedy, tradeoffs and alternatives.
|
|
**STOP.** Wait for its answer before applying that remedy or advancing.
|
|
|
|
---
|
|
|
|
## The 0-10 Rating Method
|
|
|
|
For each DX section:
|
|
1. Recall Step 0 evidence: persona, friction trace and competitive benchmark.
|
|
2. Rate 0-10, explain the evidenced gap and what 10 means for this product.
|
|
3. Read this pass's Hall of Fame section from dx-hall-of-fame.md.
|
|
4. Run the Decision gate for each gap. Record routine work within scope; ask and
|
|
wait only for admitted new or reopened choices.
|
|
5. Apply approved changes, then re-rate the amended plan. Keep unresolved risks
|
|
visible. A score is not measured success; never add scope just to reach 10.
|
|
|
|
**Mode-specific behavior:**
|
|
- **DX EXPANSION:** Also propose what would make this dimension best-in-class
|
|
for the persona. Each expansion requires its own opt-in AskUserQuestion.
|
|
- **DX POLISH:** Examine every touchpoint within the accepted scope and contracts.
|
|
Trace each issue to evidence. Do not redesign established APIs to improve a score.
|
|
- **DX TRIAGE:** Flag adoption blockers (below 5); skip nice-to-haves (5-7).
|
|
|
|
{{SECTION:review-sections}}
|
|
|
|
## Section self-check (before you finish)
|
|
|
|
Confirm you Read the review section the Section index named, and executed all 8 DX passes, the required outputs, and the review report in full. If you produced findings or the review report from memory without Reading `sections/review-sections.md`, stop and Read it now.
|
|
|
|
{{EXIT_PLAN_MODE_GATE}}
|