mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-27 07:01:54 +02:00
* feat: bind shared-code review advice to source and branch * feat: add shared-code extraction audit and scoped review checks * test: recognize complete source reads and explicit coverage legends * chore: bump version and changelog (v1.88.0.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: capture native review questions and retain public evidence Capture the actual first public native question with strict ownership and display matching. Preserve terminal failures and raw evidence, and retain SDK completion checks. * test: recognize verified review evidence and complete fixtures Recognize complete source and diagram evidence, concrete design and developer-experience decisions, and the complete planted scenario contracts. Preserve negative controls and grading thresholds. * fix: preserve decision brief structure in native questions Keep the required pros-and-cons heading and final Net field in native question text. Regenerate host outputs and document the release and evaluation repairs. Co-Authored-By: OpenAI Codex <noreply@openai.com> * docs: update project documentation for v1.88.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: correct eval retry accounting and ship workflow gates * fix: capture native eval evidence and stabilize CI fixtures * fix: keep shared-code eval skips read-only Choose explicit no-change answers instead of mixed fix/preservation options. Reuse the bounded revalidation prompt for path fixtures so required review metadata is available without repeated discovery. Preserve source checks, retry limits, and failed native terminal outcomes. Add captured-question and callback regressions, plus evaluation selection coverage for the affected fixtures. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
42 lines
3.9 KiB
JSON
42 lines
3.9 KiB
JSON
{
|
|
"provenance": {
|
|
"source": "September 21 fresh plan-design-finding-count confirmation",
|
|
"runId": "shared-libs-design-confirm-sep21",
|
|
"sourceCallSha256": "129093ff57df4abafb2184384525bde132620981e3dae7c7b5e756e45582fe1f"
|
|
},
|
|
"calls": [
|
|
{
|
|
"sessionId": "6001f9ea-6d4b-44e0-a37c-3598680da835",
|
|
"toolUseId": "toolu_01VRFDkXuLgHgy7cVBmWBpe4",
|
|
"questions": [
|
|
{
|
|
"header": "Issue 1 Save",
|
|
"question": "D1 — Issue 1: Save is indistinguishable from Reset/Cancel/Export in the header. How should the plan fix it?\n\nProject/branch/task: main branch, design review of the account-settings form plan against DESIGN.md.\nELI10: Four buttons in a row all look the same, so someone who just changed their email has to read every label to find the one that keeps their work. Design principle: hierarchy as service — the user should see first, second, third without thinking. Right now nothing is first.\nStakes if we pick wrong: users mis-hit Reset or Cancel next to Save and lose edits, or hesitate on every save. Either drains the goodwill reservoir on the page whose whole job is confidence.\nRecommendation: A because DESIGN.md already names the exact treatment, so this is a one-token change with no new visual exploration.\nCompleteness: A=10/10, B=5/10, C=0/10\nNet: A restores a single filled primary for one CSS token; B nudges weight only and still fails the DESIGN.md rule; C leaves the top gap in the plan open.",
|
|
"options": [
|
|
{
|
|
"label": "1A Filled primary Save (recommended)",
|
|
"description": "Save becomes the only filled primary (#1d4ed8, white text). Reset, Cancel, Export become neutral ghost buttons. Same DOM order, same 44px geometry. (human: ~1h / CC: ~5min) ✅ Matches DESIGN.md exactly; one primary per page. ✅ Works at 320px because the mobile stack already puts Save first. ❌ Ghost buttons need their own hover/disabled states verified for contrast."
|
|
},
|
|
{
|
|
"label": "1B Bold label only",
|
|
"description": "Keep all four the same size and color; bold Save's label weight only. (human: ~15min / CC: ~2min) ✅ Smallest diff, no new button variant. ✅ Keeps the current visual calm. ❌ Weight-only emphasis is weak at a glance and still violates DESIGN.md's filled-primary rule."
|
|
},
|
|
{
|
|
"label": "1C Defer",
|
|
"description": "Leave the four buttons uniform for now and record it as unresolved design debt. ✅ Zero work in this PR. ✅ Can be revisited with a live /design-review after ship. ❌ Ships a form with no clear primary action, the most visible gap in the plan."
|
|
}
|
|
],
|
|
"multiSelect": false
|
|
}
|
|
],
|
|
"answered": true,
|
|
"failed": false,
|
|
"answers": {
|
|
"D1 — Issue 1: Save is indistinguishable from Reset/Cancel/Export in the header. How should the plan fix it?\n\nProject/branch/task: main branch, design review of the account-settings form plan against DESIGN.md.\nELI10: Four buttons in a row all look the same, so someone who just changed their email has to read every label to find the one that keeps their work. Design principle: hierarchy as service — the user should see first, second, third without thinking. Right now nothing is first.\nStakes if we pick wrong: users mis-hit Reset or Cancel next to Save and lose edits, or hesitate on every save. Either drains the goodwill reservoir on the page whose whole job is confidence.\nRecommendation: A because DESIGN.md already names the exact treatment, so this is a one-token change with no new visual exploration.\nCompleteness: A=10/10, B=5/10, C=0/10\nNet: A restores a single filled primary for one CSS token; B nudges weight only and still fails the DESIGN.md rule; C leaves the top gap in the plan open.": "1A Filled primary Save (recommended)"
|
|
},
|
|
"unansweredQuestionIndices": [],
|
|
"answeredAt": "2026-09-21T17:22:25.728Z"
|
|
}
|
|
]
|
|
}
|