mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-19 14:44:44 +01:00
The secrets check no longer stops a push on three kinds of ordinary code that only look like secrets: TypeScript types with spaced generic arguments, Python arguments that read a settings constant, and camelCase dotted field paths. It also catches two kinds of real secrets it used to miss, one built with `+` from short pieces and one written in a comment, so pushes are both quieter and safer. Nothing to do; a secret in any of the loosened positions still fails the check. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Review-Finding: p1/adversarial-native#1 reader=adversarial-native Review-Finding: p1/outside-voice#1 reader=outside-voice Review-Finding: p1/outside-voice#2 reader=outside-voice
631 B
631 B
- The secrets check stops flagging three kinds of ordinary code as a secret, and catches two misses. TypeScript types with spaced generic arguments, Python keyword arguments that read a settings constant (
aws_secret_access_key=settings.S3_SECRET_KEY,), and camelCase dotted field paths ("form.section.fieldName") no longer stop a push. A secret built with+from short pieces, or written in a trailing or whole-line comment, is now reported. A secret in any of those positions still fails the check. Template keys, arrays of names and string-literal generic types still report and are documented as known limits. (#4289)