mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 22:48:57 +02:00
b3a27173fe
Re-derive of PR #2414 (SYKhayyat) onto current main. Most of the PR already landed in earlier waves: the tick-derived RESPAWN_GUARD_WINDOW_MS, the spawnTerminalAgent windowsHide flag, the process-liveness regression tests, and the browse/test import.meta.path sweep are all on main. Two pieces remained: 1. isProcessAlive EPERM semantics (error-handling.ts): on the signal-0 path, EPERM means the process EXISTS but we lack rights to signal it — that is ALIVE. Returning false made callers that validate liveness before killing (killAgentByRecord, the terminal-agent watchdog) skip the kill and respawn around a survivor — the self-reinforcing one-leak-per-tick chain from #2414/#2295. Matters for cross-user PID checks. 2. Six test/ files ADDED SINCE the PR reintroduced the exact Windows bug its second commit fixed: `new URL(import.meta.url).pathname` yields `/C:/Users/...` on Windows, so path.resolve prepends the cwd drive and every tripwire ENOENTs instead of asserting anything (egress-receipt, egress-lib, egress-receipt-wiring, gstack-egress-cli, pty-skill-seeding-wiring, skill-census). All six now use import.meta.path — Bun's absolute native path, identical arity. The remaining #2414 piece — replacing the Windows tasklist probe with signal-0 — lands as its own commit (#1952) on top of this shape. Tests: the 6 touched test files 47 pass; process-liveness-windows + error-handling 13 pass. Re-derived from PR #2414 by @SYKhayyat. Fixes the residual of #2295. Co-authored-by: SYKhayyat <shaulyoelkhayyat@gmail.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
70 lines
3.0 KiB
TypeScript
70 lines
3.0 KiB
TypeScript
/**
|
|
* Pins the three-count contract of test/helpers/skill-census.ts (C11).
|
|
*
|
|
* No hardcoded totals here — the catalog-budget test owns the ratchet.
|
|
* This file pins the STRUCTURAL relationships that make the three counts
|
|
* mean different things, using the live repo as the fixture.
|
|
*/
|
|
|
|
import { describe, expect, it } from 'bun:test';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { frontmatterName, skillCensus } from './helpers/skill-census';
|
|
|
|
const ROOT = path.resolve(import.meta.path, '..', '..');
|
|
const census = skillCensus(ROOT);
|
|
|
|
describe('skillCensus', () => {
|
|
it('physicalSkillFiles includes the root router and the symlinked dir', () => {
|
|
expect(census.physicalSkillFiles).toContain('SKILL.md');
|
|
expect(census.physicalSkillFiles).toContain('connect-chrome/SKILL.md');
|
|
expect(census.physicalSkillFiles).toContain('open-gstack-browser/SKILL.md');
|
|
});
|
|
|
|
it('authoredSkills dedupes the connect-chrome symlink and excludes the root router', () => {
|
|
expect(census.authoredSkills).toContain('open-gstack-browser');
|
|
expect(census.authoredSkills).not.toContain('connect-chrome');
|
|
// Root router is not an authored skill; its dir entry would be '' anyway.
|
|
for (const name of census.authoredSkills) expect(name.length).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('registryEntries carries the root alias and collapses shared frontmatter names', () => {
|
|
expect(census.registryEntries).toContain('_gstack-command');
|
|
expect(
|
|
census.registryEntries.filter((n) => n === 'open-gstack-browser'),
|
|
).toHaveLength(1);
|
|
});
|
|
|
|
it('count relationships hold: physical = authored + root + symlink dups', () => {
|
|
const symlinkDups = census.physicalSkillFiles.length - 1 - census.authoredSkills.length;
|
|
expect(symlinkDups).toBeGreaterThanOrEqual(1); // connect-chrome today
|
|
// Registry = unique frontmatter names + root alias. It can only collapse
|
|
// entries relative to physical, never invent them.
|
|
expect(census.registryEntries.length).toBeLessThanOrEqual(census.physicalSkillFiles.length);
|
|
expect(census.registryEntries.length).toBeGreaterThan(census.authoredSkills.length - 1);
|
|
});
|
|
|
|
it('frontmatterName mirrors setup: first ^name: line, whitespace stripped', () => {
|
|
const qa = frontmatterName(path.join(ROOT, 'qa', 'SKILL.md'));
|
|
expect(qa).toBe('qa');
|
|
const alias = frontmatterName(path.join(ROOT, 'connect-chrome', 'SKILL.md'));
|
|
expect(alias).toBe('open-gstack-browser');
|
|
expect(frontmatterName(path.join(ROOT, 'no-such-dir', 'SKILL.md'))).toBe('');
|
|
});
|
|
|
|
it('every registry entry a host would see resolves back to a physical SKILL.md', () => {
|
|
const names = new Set(
|
|
census.physicalSkillFiles
|
|
.filter((p) => p !== 'SKILL.md')
|
|
.map((p) => frontmatterName(path.join(ROOT, p)) || path.dirname(p)),
|
|
);
|
|
for (const entry of census.registryEntries) {
|
|
if (entry === '_gstack-command') {
|
|
expect(fs.existsSync(path.join(ROOT, 'SKILL.md'))).toBe(true);
|
|
} else {
|
|
expect(names.has(entry)).toBe(true);
|
|
}
|
|
}
|
|
});
|
|
});
|