mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-17 02:15:31 +02:00
Garry TanandClaude Fable 5
0f26859bd1
'Fix bun temp' x3, 'Restore deps' x5, 'Seed claude interactive config' x3, and 'Register gstack skills' x3 were byte-near-identical copies across the legacy matrix, the sliced lane, and the periodic lane — and only the MATRIX copy of register-skills carried the 19-line dangling-symlink + frontmatter fail-fast loop written after a silent 'Unknown command' + 35-min-timeout incident. Extract all four into .github/actions/ composites; the register composite carries the verification loop (generalized over the skill list), so the sliced and periodic lanes — the lanes that SURVIVE the matrix deletion — now inherit the check they had silently dropped. Matrix-job inline copies are left untouched: that job is deleted next. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
99 lines
4.7 KiB
YAML
99 lines
4.7 KiB
YAML
name: Register gstack skills for PTY tests
|
|
description: >
|
|
Register the skills PTY smokes invoke, in every place claude looks:
|
|
user-scoped ($HOME/.claude/skills — a gstack root symlink for the
|
|
preamble's absolute runtime paths, plus per-skill REAL-FILE copies because
|
|
claude's interactive-TUI skill scanner does not follow the
|
|
/github/home -> /__w cross-mount symlink), and project-scoped
|
|
(<repo>/.claude/skills, which the TUI reads for /slash commands and which
|
|
is gitignored so absent on a fresh CI checkout). Also pre-seeds every
|
|
one-time preamble marker so no PTY child takes a first-run branch mid-test
|
|
(feature discovery under ~/.claude/skills/gstack trips Claude Code's
|
|
sensitive-file permission prompt — the documented intermittent
|
|
scope-gate-question-NOT-observed failure).
|
|
|
|
Ends with the fail-fast verification loop the legacy matrix copy grew
|
|
after a silent "Unknown command" + 35-min-timeout incident: a dangling
|
|
symlink or renamed committed target fails HERE, in seconds, with a named
|
|
path — never as a wedged PTY session at the shard wall. Every consuming
|
|
lane inherits the loop by construction (it previously existed only in the
|
|
matrix copy; the sliced + periodic copies had silently dropped it).
|
|
inputs:
|
|
skills:
|
|
description: Space-separated skill dirs (each must have SKILL.md + sections/).
|
|
required: false
|
|
default: office-hours plan-ceo-review plan-eng-review plan-design-review
|
|
runs:
|
|
using: composite
|
|
steps:
|
|
- shell: bash
|
|
env:
|
|
SKILLS: ${{ inputs.skills }}
|
|
run: |
|
|
set -eu
|
|
SKILLS_DIR="$HOME/.claude/skills"
|
|
REPO="$GITHUB_WORKSPACE"
|
|
mkdir -p "$SKILLS_DIR"
|
|
# The gstack root stays a symlink — the preamble's runtime bash resolves
|
|
# ~/.claude/skills/gstack/bin/* and ~/.claude/skills/gstack/<skill>/sections/*
|
|
# through it, and bash follows cross-mount symlinks fine.
|
|
ln -snf "$REPO" "$SKILLS_DIR/gstack"
|
|
for s in $SKILLS; do
|
|
rm -rf "${SKILLS_DIR:?}/$s"
|
|
mkdir -p "$SKILLS_DIR/$s"
|
|
cp "$REPO/$s/SKILL.md" "$SKILLS_DIR/$s/SKILL.md"
|
|
cp -R "$REPO/$s/sections" "$SKILLS_DIR/$s/sections"
|
|
done
|
|
PROJ_SKILLS="$REPO/.claude/skills"
|
|
mkdir -p "$PROJ_SKILLS"
|
|
for s in $SKILLS; do
|
|
rm -rf "${PROJ_SKILLS:?}/$s"
|
|
mkdir -p "$PROJ_SKILLS/$s"
|
|
cp "$REPO/$s/SKILL.md" "$PROJ_SKILLS/$s/SKILL.md"
|
|
cp -R "$REPO/$s/sections" "$PROJ_SKILLS/$s/sections"
|
|
done
|
|
# Pre-seed every ONE-TIME preamble marker so no PTY child ever takes a
|
|
# first-run branch mid-test.
|
|
mkdir -p "$HOME/.gstack"
|
|
touch "$HOME/.gstack/.activated" \
|
|
"$HOME/.gstack/.first-loop-tip-shown" \
|
|
"$HOME/.gstack/.telemetry-prompted" \
|
|
"$HOME/.gstack/.proactive-prompted" \
|
|
"$HOME/.gstack/.completeness-intro-seen" \
|
|
"$HOME/.gstack/.plan-tune-nudge-shown"
|
|
# These two resolve through the gstack root symlink into $REPO —
|
|
# untracked scratch in the CI checkout, exactly where the preamble looks.
|
|
touch "$SKILLS_DIR/gstack/.feature-prompted-continuous-checkpoint" \
|
|
"$SKILLS_DIR/gstack/.feature-prompted-model-overlay"
|
|
echo "--- registry under $SKILLS_DIR ---"
|
|
ls -la "$SKILLS_DIR/gstack"
|
|
# ── Fail-fast verification ──────────────────────────────────────────
|
|
# A dangling symlink or moved/renamed committed target must fail here
|
|
# with a named path, not resurface as a silent "Unknown command" and a
|
|
# PTY session wedged to its wall timeout.
|
|
for f in \
|
|
"$SKILLS_DIR/gstack/bin/gstack-update-check" \
|
|
"$SKILLS_DIR/gstack/scripts/gen-skill-docs.ts"; do
|
|
if [ ! -e "$f" ]; then
|
|
echo "ERROR: gstack root symlink dangles or target moved: $f" >&2
|
|
exit 1
|
|
fi
|
|
done
|
|
for s in $SKILLS; do
|
|
if [ ! -e "$SKILLS_DIR/$s/SKILL.md" ]; then
|
|
echo "ERROR: skill-registry target missing: $SKILLS_DIR/$s/SKILL.md" >&2
|
|
exit 1
|
|
fi
|
|
grep -m1 "^name: $s\$" "$SKILLS_DIR/$s/SKILL.md" >/dev/null \
|
|
|| { echo "ERROR: $s SKILL.md missing 'name: $s' frontmatter" >&2; exit 1; }
|
|
# Sections must exist BOTH as the copied real files (TUI reads) and
|
|
# through the gstack root symlink (the preamble's runtime paths).
|
|
for d in "$SKILLS_DIR/$s/sections" "$SKILLS_DIR/gstack/$s/sections"; do
|
|
if [ ! -d "$d" ] || [ -z "$(ls -A "$d")" ]; then
|
|
echo "ERROR: skill sections missing or empty: $d" >&2
|
|
exit 1
|
|
fi
|
|
done
|
|
done
|
|
echo "skill registry OK"
|