mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-08 06:26:45 +02:00
cd85bdc196
1. Remove root token from /health endpoint entirely (CSO #1 CRITICAL). Origin header is spoofable. Extension reads from ~/.gstack/.auth.json. 2. Add domain check for newtab URL (CSO #5). Previously only goto was checked, allowing domain-restricted agents to bypass via newtab. 3. Validate scope values, rateLimit, expiresSeconds in createToken() (CSO #4). Rejects invalid scopes and negative values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
482 lines
14 KiB
TypeScript
482 lines
14 KiB
TypeScript
/**
|
|
* Token registry — per-agent scoped tokens for multi-agent browser access.
|
|
*
|
|
* Architecture:
|
|
* Root token (from server startup) → POST /token → scoped sub-tokens
|
|
* POST /connect (setup key exchange) → session token
|
|
*
|
|
* Token lifecycle:
|
|
* createSetupKey() → exchangeSetupKey() → session token (24h default)
|
|
* createToken() → direct session token (for CLI/local use)
|
|
* revokeToken() → immediate invalidation
|
|
* rotateRoot() → new root, all scoped tokens invalidated
|
|
*
|
|
* Scope categories (derived from commands.ts READ/WRITE/META sets):
|
|
* read — snapshot, text, html, links, forms, console, etc.
|
|
* write — goto, click, fill, scroll, newtab, etc.
|
|
* admin — eval, js, cookies, storage, useragent, state (destructive)
|
|
* meta — tab, diff, chain, frame, responsive
|
|
*
|
|
* Security invariants:
|
|
* 1. Only root token can mint sub-tokens (POST /token, POST /connect)
|
|
* 2. admin scope denied by default — must be explicitly granted
|
|
* 3. chain command scope-checks each subcommand individually
|
|
* 4. Root token never in connection strings or pasted instructions
|
|
*
|
|
* Zero side effects on import. Safe to import from tests.
|
|
*/
|
|
|
|
import * as crypto from 'crypto';
|
|
import { READ_COMMANDS, WRITE_COMMANDS, META_COMMANDS } from './commands';
|
|
|
|
// ─── Scope Definitions ─────────────────────────────────────────
|
|
// Derived from commands.ts, but reclassified by actual side effects.
|
|
// The key insight (from Codex adversarial review): commands.ts READ_COMMANDS
|
|
// includes js/eval/cookies/storage which are actually dangerous. The scope
|
|
// model here overrides the commands.ts classification.
|
|
|
|
/** Commands safe for read-only agents */
|
|
export const SCOPE_READ = new Set([
|
|
'snapshot', 'text', 'html', 'links', 'forms', 'accessibility',
|
|
'console', 'network', 'perf', 'dialog', 'is', 'inspect',
|
|
'url', 'tabs', 'status', 'screenshot', 'pdf', 'css', 'attrs',
|
|
]);
|
|
|
|
/** Commands that modify page state or navigate */
|
|
export const SCOPE_WRITE = new Set([
|
|
'goto', 'back', 'forward', 'reload',
|
|
'click', 'fill', 'select', 'hover', 'type', 'press', 'scroll', 'wait',
|
|
'upload', 'viewport', 'newtab', 'closetab',
|
|
'dialog-accept', 'dialog-dismiss',
|
|
]);
|
|
|
|
/** Dangerous commands — JS execution, credential access, browser-wide mutations */
|
|
export const SCOPE_ADMIN = new Set([
|
|
'eval', 'js', 'cookies', 'storage',
|
|
'cookie', 'cookie-import', 'cookie-import-browser',
|
|
'header', 'useragent',
|
|
'style', 'cleanup', 'prettyscreenshot',
|
|
// Browser-wide destructive commands (from Codex adversarial finding):
|
|
'state', 'handoff', 'resume', 'stop', 'restart', 'connect', 'disconnect',
|
|
]);
|
|
|
|
/** Meta commands — generally safe but some need scope checking */
|
|
export const SCOPE_META = new Set([
|
|
'tab', 'diff', 'frame', 'responsive', 'snapshot',
|
|
'watch', 'inbox', 'focus',
|
|
]);
|
|
|
|
export type ScopeCategory = 'read' | 'write' | 'admin' | 'meta';
|
|
|
|
const SCOPE_MAP: Record<ScopeCategory, Set<string>> = {
|
|
read: SCOPE_READ,
|
|
write: SCOPE_WRITE,
|
|
admin: SCOPE_ADMIN,
|
|
meta: SCOPE_META,
|
|
};
|
|
|
|
// ─── Types ──────────────────────────────────────────────────────
|
|
|
|
export interface TokenInfo {
|
|
token: string;
|
|
clientId: string;
|
|
type: 'session' | 'setup';
|
|
scopes: ScopeCategory[];
|
|
domains?: string[]; // glob patterns, e.g. ['*.myapp.com']
|
|
tabPolicy: 'own-only' | 'shared';
|
|
rateLimit: number; // requests per second (0 = unlimited)
|
|
expiresAt: string | null; // ISO8601, null = never
|
|
createdAt: string;
|
|
usesRemaining?: number; // for setup keys only
|
|
issuedSessionToken?: string; // for setup keys: the session token that was issued
|
|
commandCount: number; // how many commands have been executed
|
|
}
|
|
|
|
export interface CreateTokenOptions {
|
|
clientId: string;
|
|
scopes?: ScopeCategory[];
|
|
domains?: string[];
|
|
tabPolicy?: 'own-only' | 'shared';
|
|
rateLimit?: number;
|
|
expiresSeconds?: number | null; // null = never, default = 86400 (24h)
|
|
}
|
|
|
|
export interface TokenRegistryState {
|
|
agents: Record<string, Omit<TokenInfo, 'commandCount'>>;
|
|
}
|
|
|
|
// ─── Rate Limiter ───────────────────────────────────────────────
|
|
|
|
interface RateBucket {
|
|
count: number;
|
|
windowStart: number;
|
|
}
|
|
|
|
const rateBuckets = new Map<string, RateBucket>();
|
|
|
|
function checkRateLimit(clientId: string, limit: number): { allowed: boolean; retryAfterMs?: number } {
|
|
if (limit <= 0) return { allowed: true };
|
|
|
|
const now = Date.now();
|
|
const bucket = rateBuckets.get(clientId);
|
|
|
|
if (!bucket || now - bucket.windowStart >= 1000) {
|
|
rateBuckets.set(clientId, { count: 1, windowStart: now });
|
|
return { allowed: true };
|
|
}
|
|
|
|
if (bucket.count >= limit) {
|
|
const retryAfterMs = 1000 - (now - bucket.windowStart);
|
|
return { allowed: false, retryAfterMs: Math.max(retryAfterMs, 100) };
|
|
}
|
|
|
|
bucket.count++;
|
|
return { allowed: true };
|
|
}
|
|
|
|
// ─── Token Registry ─────────────────────────────────────────────
|
|
|
|
const tokens = new Map<string, TokenInfo>();
|
|
let rootToken: string = '';
|
|
|
|
export function initRegistry(root: string): void {
|
|
rootToken = root;
|
|
}
|
|
|
|
export function getRootToken(): string {
|
|
return rootToken;
|
|
}
|
|
|
|
export function isRootToken(token: string): boolean {
|
|
return token === rootToken;
|
|
}
|
|
|
|
function generateToken(prefix: string): string {
|
|
return `${prefix}${crypto.randomBytes(24).toString('hex')}`;
|
|
}
|
|
|
|
/**
|
|
* Create a scoped session token (for direct minting via CLI or /token endpoint).
|
|
* Only callable by root token holder.
|
|
*/
|
|
export function createToken(opts: CreateTokenOptions): TokenInfo {
|
|
const {
|
|
clientId,
|
|
scopes = ['read', 'write'],
|
|
domains,
|
|
tabPolicy = 'own-only',
|
|
rateLimit = 10,
|
|
expiresSeconds = 86400, // 24h default
|
|
} = opts;
|
|
|
|
// Validate inputs
|
|
const validScopes: ScopeCategory[] = ['read', 'write', 'admin', 'meta'];
|
|
for (const s of scopes) {
|
|
if (!validScopes.includes(s as ScopeCategory)) {
|
|
throw new Error(`Invalid scope: ${s}. Valid: ${validScopes.join(', ')}`);
|
|
}
|
|
}
|
|
if (rateLimit < 0) throw new Error('rateLimit must be >= 0');
|
|
if (expiresSeconds !== null && expiresSeconds !== undefined && expiresSeconds < 0) {
|
|
throw new Error('expiresSeconds must be >= 0 or null');
|
|
}
|
|
|
|
const token = generateToken('gsk_sess_');
|
|
const now = new Date();
|
|
const expiresAt = expiresSeconds === null
|
|
? null
|
|
: new Date(now.getTime() + expiresSeconds * 1000).toISOString();
|
|
|
|
const info: TokenInfo = {
|
|
token,
|
|
clientId,
|
|
type: 'session',
|
|
scopes,
|
|
domains,
|
|
tabPolicy,
|
|
rateLimit,
|
|
expiresAt,
|
|
createdAt: now.toISOString(),
|
|
commandCount: 0,
|
|
};
|
|
|
|
// Overwrite if clientId already exists (re-pairing)
|
|
// First revoke the old session token (but NOT setup keys — they track their issued session)
|
|
for (const [t, existing] of tokens) {
|
|
if (existing.clientId === clientId && existing.type === 'session') {
|
|
tokens.delete(t);
|
|
break;
|
|
}
|
|
}
|
|
|
|
tokens.set(token, info);
|
|
return info;
|
|
}
|
|
|
|
/**
|
|
* Create a one-time setup key for the /pair-agent ceremony.
|
|
* Setup keys expire in 5 minutes and can only be exchanged once.
|
|
*/
|
|
export function createSetupKey(opts: Omit<CreateTokenOptions, 'clientId'> & { clientId?: string }): TokenInfo {
|
|
const token = generateToken('gsk_setup_');
|
|
const now = new Date();
|
|
const expiresAt = new Date(now.getTime() + 5 * 60 * 1000).toISOString(); // 5 min
|
|
|
|
const info: TokenInfo = {
|
|
token,
|
|
clientId: opts.clientId || `remote-${Date.now()}`,
|
|
type: 'setup',
|
|
scopes: opts.scopes || ['read', 'write'],
|
|
domains: opts.domains,
|
|
tabPolicy: opts.tabPolicy || 'own-only',
|
|
rateLimit: opts.rateLimit || 10,
|
|
expiresAt,
|
|
createdAt: now.toISOString(),
|
|
usesRemaining: 1,
|
|
commandCount: 0,
|
|
};
|
|
|
|
tokens.set(token, info);
|
|
return info;
|
|
}
|
|
|
|
/**
|
|
* Exchange a setup key for a session token.
|
|
* Idempotent: if the same key is presented again and the prior session
|
|
* has 0 commands, returns the same session token (handles tunnel drops).
|
|
*/
|
|
export function exchangeSetupKey(setupKey: string, sessionExpiresSeconds?: number | null): TokenInfo | null {
|
|
const setup = tokens.get(setupKey);
|
|
if (!setup) return null;
|
|
if (setup.type !== 'setup') return null;
|
|
|
|
// Check expiry
|
|
if (setup.expiresAt && new Date(setup.expiresAt) < new Date()) {
|
|
tokens.delete(setupKey);
|
|
return null;
|
|
}
|
|
|
|
// Idempotent: if already exchanged but session has 0 commands, return existing
|
|
if (setup.usesRemaining === 0) {
|
|
if (setup.issuedSessionToken) {
|
|
const existing = tokens.get(setup.issuedSessionToken);
|
|
if (existing && existing.commandCount === 0) {
|
|
return existing;
|
|
}
|
|
}
|
|
return null; // Session used or gone — can't re-issue
|
|
}
|
|
|
|
// Consume the setup key
|
|
setup.usesRemaining = 0;
|
|
|
|
// Create the session token
|
|
const session = createToken({
|
|
clientId: setup.clientId,
|
|
scopes: setup.scopes,
|
|
domains: setup.domains,
|
|
tabPolicy: setup.tabPolicy,
|
|
rateLimit: setup.rateLimit,
|
|
expiresSeconds: sessionExpiresSeconds ?? 86400,
|
|
});
|
|
|
|
// Track which session token was issued from this setup key
|
|
setup.issuedSessionToken = session.token;
|
|
|
|
return session;
|
|
}
|
|
|
|
/**
|
|
* Validate a token and return its info if valid.
|
|
* Returns null for expired, revoked, or unknown tokens.
|
|
* Root token returns a special root info object.
|
|
*/
|
|
export function validateToken(token: string): TokenInfo | null {
|
|
if (isRootToken(token)) {
|
|
return {
|
|
token: rootToken,
|
|
clientId: 'root',
|
|
type: 'session',
|
|
scopes: ['read', 'write', 'admin', 'meta'],
|
|
tabPolicy: 'shared',
|
|
rateLimit: 0, // unlimited
|
|
expiresAt: null,
|
|
createdAt: '',
|
|
commandCount: 0,
|
|
};
|
|
}
|
|
|
|
const info = tokens.get(token);
|
|
if (!info) return null;
|
|
|
|
// Check expiry
|
|
if (info.expiresAt && new Date(info.expiresAt) < new Date()) {
|
|
tokens.delete(token);
|
|
return null;
|
|
}
|
|
|
|
return info;
|
|
}
|
|
|
|
/**
|
|
* Check if a command is allowed by the token's scopes.
|
|
* The `chain` command is special: it's allowed if the token has meta scope,
|
|
* but each subcommand within chain must be individually scope-checked.
|
|
*/
|
|
export function checkScope(info: TokenInfo, command: string): boolean {
|
|
if (info.clientId === 'root') return true;
|
|
|
|
// Special case: chain is in SCOPE_META but requires that the caller
|
|
// has scopes covering ALL subcommands. The actual subcommand check
|
|
// happens at dispatch time, not here.
|
|
if (command === 'chain' && info.scopes.includes('meta')) return true;
|
|
|
|
for (const scope of info.scopes) {
|
|
if (SCOPE_MAP[scope]?.has(command)) return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Check if a URL is allowed by the token's domain restrictions.
|
|
* Returns true if no domain restrictions, or if the URL matches any glob.
|
|
*/
|
|
export function checkDomain(info: TokenInfo, url: string): boolean {
|
|
if (info.clientId === 'root') return true;
|
|
if (!info.domains || info.domains.length === 0) return true;
|
|
|
|
try {
|
|
const parsed = new URL(url);
|
|
const hostname = parsed.hostname;
|
|
|
|
for (const pattern of info.domains) {
|
|
if (matchDomainGlob(hostname, pattern)) return true;
|
|
}
|
|
|
|
return false;
|
|
} catch {
|
|
return false; // Invalid URL — deny
|
|
}
|
|
}
|
|
|
|
function matchDomainGlob(hostname: string, pattern: string): boolean {
|
|
// Simple glob: *.example.com matches sub.example.com
|
|
// Exact: example.com matches example.com only
|
|
if (pattern.startsWith('*.')) {
|
|
const suffix = pattern.slice(1); // .example.com
|
|
return hostname.endsWith(suffix) || hostname === pattern.slice(2);
|
|
}
|
|
return hostname === pattern;
|
|
}
|
|
|
|
/**
|
|
* Check rate limit for a client. Returns { allowed, retryAfterMs? }.
|
|
*/
|
|
export function checkRate(info: TokenInfo): { allowed: boolean; retryAfterMs?: number } {
|
|
if (info.clientId === 'root') return { allowed: true };
|
|
return checkRateLimit(info.clientId, info.rateLimit);
|
|
}
|
|
|
|
/**
|
|
* Record that a command was executed by this token.
|
|
*/
|
|
export function recordCommand(token: string): void {
|
|
const info = tokens.get(token);
|
|
if (info) info.commandCount++;
|
|
}
|
|
|
|
/**
|
|
* Revoke a token by client ID. Returns true if found and revoked.
|
|
*/
|
|
export function revokeToken(clientId: string): boolean {
|
|
for (const [token, info] of tokens) {
|
|
if (info.clientId === clientId) {
|
|
tokens.delete(token);
|
|
rateBuckets.delete(clientId);
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Rotate the root token. All scoped tokens are invalidated.
|
|
* Returns the new root token.
|
|
*/
|
|
export function rotateRoot(): string {
|
|
rootToken = crypto.randomUUID();
|
|
tokens.clear();
|
|
rateBuckets.clear();
|
|
return rootToken;
|
|
}
|
|
|
|
/**
|
|
* List all active (non-expired) scoped tokens.
|
|
*/
|
|
export function listTokens(): TokenInfo[] {
|
|
const now = new Date();
|
|
const result: TokenInfo[] = [];
|
|
|
|
for (const [token, info] of tokens) {
|
|
if (info.expiresAt && new Date(info.expiresAt) < now) {
|
|
tokens.delete(token);
|
|
continue;
|
|
}
|
|
if (info.type === 'session') {
|
|
result.push(info);
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
/**
|
|
* Serialize the token registry for state file persistence.
|
|
*/
|
|
export function serializeRegistry(): TokenRegistryState {
|
|
const agents: TokenRegistryState['agents'] = {};
|
|
|
|
for (const info of tokens.values()) {
|
|
if (info.type === 'session') {
|
|
const { commandCount, ...rest } = info;
|
|
agents[info.clientId] = rest;
|
|
}
|
|
}
|
|
|
|
return { agents };
|
|
}
|
|
|
|
/**
|
|
* Restore the token registry from persisted state file data.
|
|
*/
|
|
export function restoreRegistry(state: TokenRegistryState): void {
|
|
tokens.clear();
|
|
const now = new Date();
|
|
|
|
for (const [clientId, data] of Object.entries(state.agents)) {
|
|
// Skip expired tokens
|
|
if (data.expiresAt && new Date(data.expiresAt) < now) continue;
|
|
|
|
tokens.set(data.token, {
|
|
...data,
|
|
clientId,
|
|
commandCount: 0,
|
|
});
|
|
}
|
|
}
|
|
|
|
// ─── Connect endpoint rate limiter (brute-force protection) ─────
|
|
|
|
let connectAttempts: { ts: number }[] = [];
|
|
const CONNECT_RATE_LIMIT = 3; // attempts per minute
|
|
const CONNECT_WINDOW_MS = 60000;
|
|
|
|
export function checkConnectRateLimit(): boolean {
|
|
const now = Date.now();
|
|
connectAttempts = connectAttempts.filter(a => now - a.ts < CONNECT_WINDOW_MS);
|
|
if (connectAttempts.length >= CONNECT_RATE_LIMIT) return false;
|
|
connectAttempts.push({ ts: now });
|
|
return true;
|
|
}
|