mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-01 14:34:42 +01:00
* feat(ship): reviewers read one packet; the parent reads only a compact findings record (GSTA-167) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(GSTA-167): keep the pinned CODEX_BOUNDARY literal in the resolver; a test holds the packet boundary equal to it Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(GSTA-167): a Step 7/8 audit is one packet, never sharded Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(GSTA-167): packets survive the replay: base as given, budget roles, read= ranges, data summaries, no stale partial manifest - --base origin/main no longer renders origin/origin/main (resolveBaseRef shared by build and audits) - PACKET lines carry budget_role and read= ranges under 30,000 bytes; build prints BUDGET_NEXT for gstack-ship-budget --next - each packet ends with END OF PACKET; the brief reads it with the read tool in parallel ranges, about 3 calls - .json/.jsonl/.ndjson/.csv/.tsv additions past 400 changed lines reach reviewers as a DATA SUMMARY - a partial build keeps other reviewers only at the same head, base and diff content - collect: a matrix counts only from a state-machines reviewer; a CRITICAL line failing validation is invalid Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(GSTA-167): pass-2 review fixes: data summaries read only the diff, a stale Red Team build refuses, any-case CRITICAL lines - topLevelKeys takes keys and columns from the diff's own lines, never the working tree, which a symlink can point at a private file (outside voice CRITICAL) - a --findings build whose head, diff base or content differs from the manifest refuses with STALE_MANIFEST instead of dropping the specialists' coverage (adversarial + Red Team) - collect: a CRITICAL line in any case, or one that fails to parse, makes its reviewer invalid (Red Team) - docs and the misplaced Value header in the review-packet tests Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(GSTA-167): CHANGELOG entry for reviewer packets; ship-budget names BUDGET_NEXT as the --next value Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
72 lines
3.8 KiB
Cheetah
72 lines
3.8 KiB
Cheetah
## Step 8: Plan Completion Audit
|
|
|
|
Complete this section in order:
|
|
1. Dispatch the audit, validate its result and resolve its Gate Logic.
|
|
2. Collect the plan's executable checks in Step 8.1; do not run them yet.
|
|
3. Run Step 8.2 Scope Drift.
|
|
4. Run Prior Learnings, including its setting question when offered, then proceed to Step 9 for review and QA.
|
|
|
|
**Dispatch this step as a subagent** using Agent, `subagent_type: "general-purpose"`
|
|
and `run_in_background: false`. Use Step 7's shared foreground-dispatch rule.
|
|
The child reads the plan and every referenced
|
|
code file; the parent validates its report and applies the gates below.
|
|
|
|
**Before dispatch, the parent binds the plan:**
|
|
|
|
{{PLAN_COMPLETION_GATE_SHIP:discovery}}
|
|
|
|
**Subagent prompt:** Substitute `<base>` and supply the bound plan's absolute path
|
|
or complete text, including user-approved scope changes. When discovery printed the
|
|
not-run line, skip dispatch. The child does not inherit the parent's conversation.
|
|
**By packet:** `~/.claude/skills/gstack/bin/gstack-review-packet build --audit plan-completion
|
|
--base <base> --plan-file <bound plan> --out-dir .gstack/tmp/review-packets-audit` writes the
|
|
prompt below, the whole plan and the diff into one packet; brief the child only with Step 7's
|
|
packet brief and read the LAST line of its `out=` file.
|
|
|
|
````text
|
|
You are running a ship-workflow plan completion audit. The base branch is `<base>`. Use `git diff origin/<base>` and inspect untracked files from `git status` to see the full proposed change. Do not commit or push. Report only: classify every item, but do not execute Gate Logic, ask the user, or advance the workflow. The parent applies those gates to your report.
|
|
|
|
{{PLAN_COMPLETION_AUDIT_SHIP}}
|
|
|
|
After your analysis, output a single JSON object with exactly these seven fields on the LAST LINE of your response (no other text after it):
|
|
{"total_items":N,"done":N,"changed":N,"partial":N,"not_done":N,"unverifiable":N,"summary":"<markdown checklist for PR body>"}
|
|
Counts map one-to-one to the classifications above and sum to total_items. No plan or no actionable items means all counts are zero with the skip reason in summary. Do not classify work as deferred; only the parent can record a user-approved deferral.
|
|
````
|
|
|
|
**Parent processing:**
|
|
|
|
1. Check the task's terminal status. Without successful completion and valid LAST-line
|
|
JSON, use the audit-failure fallback below (that JSON is its `out=` file's last line). Require exactly the seven declared
|
|
fields: nonnegative integer counts whose classification sum equals `total_items`,
|
|
and a string `summary`. Missing,
|
|
extra or invalid fields fail. Valid no-plan/no-actionable reports retain zero counts
|
|
and their summary.
|
|
2. Store counts for Step 20 and `summary` for Step 19's `## Plan Completion`.
|
|
3. Run the parent-computed Acceptance edits check below on the bound plan; it adds
|
|
`ACCEPTANCE_EDITED` beside the child's classes and never changes the child's
|
|
seven fields.
|
|
4. Apply Gate Logic below before continuing. Carry approved deferrals, with item text
|
|
and plan path, to Step 14; keep them separate from dropped scope. The gate supplies
|
|
the required PR notes and per-item manual verification evidence.
|
|
|
|
{{PLAN_COMPLETION_GATE_SHIP:acceptance}}
|
|
|
|
**Audit-failure fallback:** On failure, invalid JSON or no final output after ~10
|
|
minutes, stop any live child and confirm it stopped before an inline audit with the same
|
|
extraction/classification logic; never race a late result. If that also fails,
|
|
AskUserQuestion: A) Skip audit and ship, recording the reason in the PR body and
|
|
Step 20 metrics; B) Stop and fix the audit (recommended/default). Never fail open
|
|
silently: a skipped audit would let unverified plan items ship as done.
|
|
|
|
---
|
|
|
|
{{PLAN_COMPLETION_GATE_SHIP}}
|
|
|
|
{{PLAN_VERIFICATION_EXEC}}
|
|
|
|
{{SCOPE_DRIFT}}
|
|
|
|
{{LEARNINGS_SEARCH:query=release ship version changelog merge pr}}
|
|
|
|
---
|