mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-02 11:45:20 +02:00
Garry Tan
d9f17c2394
New bin/gstack-paths emits GSTACK_STATE_ROOT, PLAN_ROOT, TMP_ROOT exports for
skill bash blocks to source via eval. Honors GSTACK_HOME → CLAUDE_PLUGIN_DATA →
$HOME/.gstack → .gstack (and parallel chains for plan/tmp roots) so skills work
the same in plugin installs, global installs, and CI containers without HOME.
Eight skills migrate off inline ${CLAUDE_PLUGIN_DATA:-...} or ${GSTACK_HOME:-...}
chains: careful, freeze, guard, unfreeze, investigate, context-save,
context-restore, learn, office-hours, plan-tune, codex. Resolved values are
identical, so existing tests cover correctness; the win is consolidating 11
copy-pasted fallback chains behind one helper.
codex/SKILL.md.tmpl gets a new Step 0.6 Resolve portable roots that sources
gstack-paths once, then replaces hardcoded ~/.claude/plans/*.md and
/tmp/codex-*-XXXXXX.txt with "$PLAN_ROOT"/*.md and "$TMP_ROOT/codex-*-XXXXXX.txt".
Hardening direction credited to the McGluut/gstack fork; this is upstream's
factoring of the per-skill chain the fork inlined.
Tests: test/gstack-paths.test.ts covers all three fallback chains with 8 unit
tests (HOME unset, CLAUDE_PLUGIN_DATA set, GSTACK_HOME wins, etc).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
83 lines
3.0 KiB
TypeScript
83 lines
3.0 KiB
TypeScript
import { describe, test, expect } from 'bun:test';
|
|
import { spawnSync } from 'child_process';
|
|
import * as path from 'path';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
const BIN = path.join(ROOT, 'bin', 'gstack-paths');
|
|
|
|
function run(env: Record<string, string | undefined>): Record<string, string> {
|
|
const result = spawnSync(BIN, [], {
|
|
env: { PATH: process.env.PATH, ...env } as Record<string, string>,
|
|
encoding: 'utf-8',
|
|
});
|
|
if (result.status !== 0) {
|
|
throw new Error(`gstack-paths failed (status ${result.status}): ${result.stderr}`);
|
|
}
|
|
const out: Record<string, string> = {};
|
|
for (const line of result.stdout.split('\n')) {
|
|
const eq = line.indexOf('=');
|
|
if (eq > 0) out[line.slice(0, eq)] = line.slice(eq + 1);
|
|
}
|
|
return out;
|
|
}
|
|
|
|
describe('gstack-paths', () => {
|
|
test('GSTACK_HOME wins over CLAUDE_PLUGIN_DATA and HOME', () => {
|
|
const got = run({
|
|
GSTACK_HOME: '/tmp/explicit-state',
|
|
CLAUDE_PLUGIN_DATA: '/tmp/plugin-data',
|
|
HOME: '/tmp/home',
|
|
});
|
|
expect(got.GSTACK_STATE_ROOT).toBe('/tmp/explicit-state');
|
|
});
|
|
|
|
test('CLAUDE_PLUGIN_DATA wins over HOME when GSTACK_HOME unset', () => {
|
|
const got = run({
|
|
CLAUDE_PLUGIN_DATA: '/tmp/plugin-data',
|
|
HOME: '/tmp/home',
|
|
});
|
|
expect(got.GSTACK_STATE_ROOT).toBe('/tmp/plugin-data');
|
|
});
|
|
|
|
test('HOME-derived state root when GSTACK_HOME and CLAUDE_PLUGIN_DATA unset', () => {
|
|
const got = run({ HOME: '/tmp/myhome' });
|
|
expect(got.GSTACK_STATE_ROOT).toBe('/tmp/myhome/.gstack');
|
|
});
|
|
|
|
test('CWD fallback when HOME also unset (container env)', () => {
|
|
const got = run({ HOME: '' });
|
|
expect(got.GSTACK_STATE_ROOT).toBe('.gstack');
|
|
});
|
|
|
|
test('PLAN_ROOT chain: GSTACK_PLAN_DIR > CLAUDE_PLANS_DIR > HOME > CWD', () => {
|
|
expect(run({ GSTACK_PLAN_DIR: '/tmp/explicit', HOME: '/h' }).PLAN_ROOT).toBe('/tmp/explicit');
|
|
expect(run({ CLAUDE_PLANS_DIR: '/tmp/claude', HOME: '/h' }).PLAN_ROOT).toBe('/tmp/claude');
|
|
expect(run({ HOME: '/tmp/myhome' }).PLAN_ROOT).toBe('/tmp/myhome/.claude/plans');
|
|
expect(run({ HOME: '' }).PLAN_ROOT).toBe('.claude/plans');
|
|
});
|
|
|
|
test('TMP_ROOT chain: TMPDIR > TMP > .gstack/tmp', () => {
|
|
expect(run({ TMPDIR: '/tmp/x', HOME: '/h' }).TMP_ROOT).toBe('/tmp/x');
|
|
expect(run({ TMP: '/tmp/y', HOME: '/h' }).TMP_ROOT).toBe('/tmp/y');
|
|
expect(run({ HOME: '' }).TMP_ROOT).toBe('.gstack/tmp');
|
|
});
|
|
|
|
test('emits all three exports on every invocation', () => {
|
|
const got = run({ HOME: '/tmp/h' });
|
|
expect(got).toHaveProperty('GSTACK_STATE_ROOT');
|
|
expect(got).toHaveProperty('PLAN_ROOT');
|
|
expect(got).toHaveProperty('TMP_ROOT');
|
|
});
|
|
|
|
test('output is shell-evalable: only KEY=VALUE lines, no extra prose', () => {
|
|
const result = spawnSync(BIN, [], {
|
|
env: { PATH: process.env.PATH, HOME: '/tmp/h' } as Record<string, string>,
|
|
encoding: 'utf-8',
|
|
});
|
|
const lines = result.stdout.split('\n').filter(Boolean);
|
|
for (const line of lines) {
|
|
expect(line).toMatch(/^[A-Z_]+=.*/);
|
|
}
|
|
});
|
|
});
|